Re: Issue 2437 in reviewboard: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with Git repository
Comment #5 on issue 2437 by honghua@gmail.com: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with Git repository http://code.google.com/p/reviewboard/issues/detail?id=2437 refer to the log file, we can find that some diff file failed to view because cache miss for the key. 2012-01-09 17:26:56,306 - DEBUG - Generating diff viewer page for filediff id 58 2012-01-09 17:26:56,308 - DEBUG - Begin: Generating diff file info for diffset id 58 2012-01-09 17:26:56,331 - DEBUG - End: Generating diff file info for diffset id 58 2012-01-09 17:26:56,332 - DEBUG - Generating diff file info for diffset id 58 took 0.22316 seconds 2012-01-09 17:26:56,333 - DEBUG - Begin: Generating diff file info for diffset id 58, filediff 103 2012-01-09 17:26:56,355 - INFO - Cache miss for key gerrit.am.freescale.net:diff-sidebyside-hl-103. 2012-01-09 17:26:56,383 - DEBUG - Begin: Patching file arch/powerpc/kernel/setup_64.c 2012-01-09 17:26:56,405 - DEBUG - End: Patching file arch/powerpc/kernel/setup_64.c 2012-01-09 17:26:56,406 - DEBUG - Patching file arch/powerpc/kernel/setup_64.c took 0.22071 seconds But exactly, some diff could be view successfully. 2012-01-09 17:33:27,518 - DEBUG - Generating diff viewer page for filediff id 38 2012-01-09 17:33:27,520 - DEBUG - Begin: Generating diff file info for diffset id 38 2012-01-09 17:33:27,544 - DEBUG - End: Generating diff file info for diffset id 38 2012-01-09 17:33:27,545 - DEBUG - Generating diff file info for diffset id 38 took 0.24039 seconds 2012-01-09 17:33:27,547 - DEBUG - Begin: Generating diff file info for diffset id 38, filediff 79 2012-01-09 17:33:27,579 - DEBUG - End: Generating diff file info for diffset id 38, filediff 79 2012-01-09 17:33:27,580 - DEBUG - Generating diff file info for diffset id 38, filediff 79 took 0.31687 seconds 2012-01-09 17:33:27,765 - DEBUG - Done generating diff viewer page for filediff id 38 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2446 in reviewboard: Permissions problem after re-open
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2446 by b2larrys...@gmail.com: Permissions problem after re-open http://code.google.com/p/reviewboard/issues/detail?id=2446 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6 What's the URL of the page containing the problem? Internal server. What steps will reproduce the problem? 1. Post a review request, add reviewers and publish 2. Close the review request as "Submitted" 3. Have a site/project admin re-open the request since it should not have been closed yet. 4. All reviewers (people, specific groups) can access the re-opened review request, but the original poster cannot (unless he/she is part of the specifically added review group.) What is the expected output? What do you see instead? The original poster sees a message about not having permissions to access the specific request. What operating system are you using? What browser? Ubuntu 10.04, 11.04, Firefix and Chromium. Windows 7, Chromium. Please provide any additional information below. This can be worked around by having the project/site admin go into the now opened request and add the original poster to the list of reviewers. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #3 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Also to add, I'm using mercurial-reviewboard plugin with my mercurial to do the 'hg postreview -o ' to post it to the reviewboard. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #2 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi trowb, I saw the contents of the file tmplXUpmn and tempXUpmn-new, and found that both the files are identical. Also, the file tmplXUpmn has my index.xhtml content. Then I compared two other files which are present in the same directory, which are: 1. index.xhtml.diff 2. tmplXUpmn-new.rej When comparing both these files I found that index.xhtml.diff had this extra online as the first line in the file and the paths in the 2nd and 3rd lines were different too: [code] diff -r 4020b8bf5e12 -r cd26cce649a2 develop/src/modules/controller/src/main/webapp/index.xhtml --- a/develop/src/modules/controller/src/main/webapp/index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ b/develop/src/modules/controller/src/main/webapp/index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] Whereas in tmplXUpmn-new.rej I'm having the following lines: [code] --- index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] I'm not sure on why the paths are different in both these files. Please let me know if you need any more information. I'm not sure on what to look out for in those file and any guidances would be really helpful. Regards, Vairav -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: NeedInfo Comment #1 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 It looks like the contents of the raw file that "RhodeCode" is giving you is bogus. Can you look at /tmp/reviewboard.uV5elT/tmplXUpmn and see what's in it? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? Reviewboard version: 1.6.3 Repository: Mercurial Repository with the latest RhodeCode for managing the repositories. OS: Ubuntu 11.04 What's the URL of the page containing the problem? Its an internal Reviewboard site, so not accessible from outside the LAN. What steps will reproduce the problem? 1. Replace hgweb.cgi with RhodeCode for managing mercurial repositories 2. Created user 'reviewboard' with password 'reviewpass' and added the credentials to Repositories in the Admin Panel. 3. Post Review works, but when trying to View Diff I'm getting the output as stated below. What is the expected output? What do you see instead? [code] The patch to 'index.xhtml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uV5elT' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uV5elT/tmplXUpmn Hunk #1 FAILED at 148. Hunk #2 FAILED at 160. Hunk #3 FAILED at 188. Hunk #4 FAILED at 203. Hunk #5 FAILED at 218. Hunk #6 FAILED at 263. Hunk #7 FAILED at 398. Hunk #8 FAILED at 409. Hunk #9 FAILED at 429. 9 out of 9 hunks FAILED -- saving rejects to file /tmp/reviewboard.uV5elT/ tmplXUpmn-new.rej Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/views.py", line 151, in view_diff interdiffset, highlighting, True) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py", line 1071, in get_diff_files large_data=True) File "/usr/local/lib/python2.7/dist-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize data = lookup_callable() File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py", line 1070, in enable_syntax_highlighting)), File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py", line 551, in get_chunks old = get_original_file(filediff) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py", line 368, in get_original_file data = patch(filediff.parent_diff, data, filediff.source_file) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py", line 242, in patch (filename, tempdir, patch_output)) Exception: The patch to 'index.xhtml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uV5elT' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uV5elT/tmplXUpmn Hunk #1 FAILED at 148. Hunk #2 FAILED at 160. Hunk #3 FAILED at 188. Hunk #4 FAILED at 203. Hunk #5 FAILED at 218. Hunk #6 FAILED at 263. Hunk #7 FAILED at 398. Hunk #8 FAILED at 409. Hunk #9 FAILED at 429. 9 out of 9 hunks FAILED -- saving rejects to file /tmp/ reviewboard.uV5elT/tmplXUpmn-new.rej [/code] What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2444 in reviewboard: [minor] post-review is compatible with FreeBSD as well, should probably just say "unix like"
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2444 by ei...@eitanadler.com: [minor] post-review is compatible with FreeBSD as well, should probably just say "unix like" http://code.google.com/p/reviewboard/issues/detail?id=2444 What's the URL of the page this enhancement relates to, if any? on /r/new/ there is text that says "It is compatible with Windows, Linux, MacOS X, and Solaris." The script is compatible with FreeBSD as well. Instead of listing them all out though it should just say "Windows and Unix like operating systems" -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2386 in reviewboard: Can't Type Comments
Comment #3 on issue 2386 by bryant.c...@gmail.com: Can't Type Comments http://code.google.com/p/reviewboard/issues/detail?id=2386 Sorry for the late reply my question was forwarded to this forum with out my knowledge. You must be right about it being third party. It's working fine now. I don't remember disabling anything specific though. Thanks -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2390 in reviewboard: Adding a site commands directory breaks all management commands
Updates: Status: New Owner: chip...@gmail.com Labels: Component-RB-Site Milestone-Release1.6.x EasyFix Comment #5 on issue 2390 by chip...@gmail.com: Adding a site commands directory breaks all management commands http://code.google.com/p/reviewboard/issues/detail?id=2390 This sounds like a bug. We don't have unit testing for this, unfortunately, so something may have broken. It's probably an easy fix, though. (Might be a good one to have a student fix during our Sprint?) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2390 in reviewboard: Adding a site commands directory breaks all management commands
Comment #4 on issue 2390 by roy.jean...@gmail.com: Adding a site commands directory breaks all management commands http://code.google.com/p/reviewboard/issues/detail?id=2390 http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.5/#custom-management-commands -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
