Re: Review Request 50951: Update zeppelin shiro.ini template with ActiveDirectoryGroupRealm info

2016-08-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50951/#review145464
---


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 10, 2016, 4:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50951/
> ---
> 
> (Updated Aug. 10, 2016, 4:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Prabhjyot Singh, Rohit 
> Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18101
> https://issues.apache.org/jira/browse/AMBARI-18101
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add additional sample config for Zeppelin LDAP integration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  ddca230 
> 
> Diff: https://reviews.apache.org/r/50951/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Review Request 50972: Interactive Query configs are not reset after refresh/back on Install Wizard

2016-08-10 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50972/
---

Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Yusaku 
Sako.


Bugs: AMBARI-18111
https://issues.apache.org/jira/browse/AMBARI-18111


Repository: ambari


Description
---

Interactive Query configs are not reset after refresh/back on Install Wizard


Diffs
-

  ambari-web/app/controllers/installer.js a2bac41 
  ambari-web/app/controllers/wizard.js 2eab760 
  ambari-web/app/controllers/wizard/step5_controller.js 5597165 
  ambari-web/app/controllers/wizard/step6_controller.js 24b03f9 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js f369143 
  ambari-web/app/controllers/wizard/step7_controller.js 2b7bbcc 
  ambari-web/app/mixins/wizard/assign_master_components.js decafcc 
  ambari-web/app/routes/installer.js 6aa8d8c 
  ambari-web/test/controllers/installer_test.js 881d6ae 
  ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
14c7e20 
  ambari-web/test/controllers/wizard/step7_test.js 0104405 

Diff: https://reviews.apache.org/r/50972/diff/


Testing
---

Tested the fix on a deployed cluster:
1) Tested the patch on installer wizard
2) Tested that with the patch "Enabling Interactive query" is non-editable on 
"Add Service Wizard"
3) Tested cluster's service->configs page.

ambari-web unit tests:

  29243 tests complete (31 seconds)
  154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145449
---


Fix it, then Ship it!





ambari-server/docs/security/kerberos/enabling_kerberos.md (lines 42 - 59)


These bullets aren't rendering in any of the MD editors I tried them in. 
It's just one paragraph.



ambari-server/docs/security/kerberos/enabling_kerberos.md (lines 76 - 119)


None of the payloads rendered with any formatting in Mou or MacDown.



ambari-server/docs/security/kerberos/kerberos_service.md (lines 182 - 194)


Not formatted in Mou or MacDown



ambari-server/docs/security/kerberos/kerberos_service.md (lines 262 - 263)


These are huge headers; probably meant to just be commented out?



ambari-server/docs/security/kerberos/kerberos_service.md (lines 265 - 283)


None of this is actually formatted and it's hard to read in MD.


- Jonathan Hurley


On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-10 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/#review145446
---


Ship it!





ambari-server/docs/security/kerberos/index.md (lines 91 - 94)


Mou is not showing these on new lines.  Do you need a carriage return 
before the asterisk?



ambari-server/docs/security/kerberos/kerberos_descriptor.md (lines 148 - 153)


Mou isn't showing json formatted correctly, hopefully your editor does :)


- Nate Cole


On Aug. 10, 2016, 2:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50963/
> ---
> 
> (Updated Aug. 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
> Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18100
> https://issues.apache.org/jira/browse/AMBARI-18100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Kerberos Automation documentation to Ambari source tree so it may be 
> versioned. This documentation should be added as MD (markdown) files to 
> .../ambari-server/docs/security/kerberos.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/index.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
>   ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50963/diff/
> 
> 
> Testing
> ---
> 
> None needed, documentation only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145447
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 10, 2016, 4:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50953/
> ---
> 
> (Updated Aug. 10, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing code basically does that:
> takes all config versions that ever existed, iterates them in random order, 
> and the config that happened to be last gets into final configuration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
>  fdd7f1d 
> 
> Diff: https://reviews.apache.org/r/50953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145444
---


Ship it!




Ship It!

- Nate Cole


On Aug. 10, 2016, 12:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50953/
> ---
> 
> (Updated Aug. 10, 2016, 12:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing code basically does that:
> takes all config versions that ever existed, iterates them in random order, 
> and the config that happened to be last gets into final configuration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
>  fdd7f1d 
> 
> Diff: https://reviews.apache.org/r/50953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/
---

(Updated Aug. 11, 2016, 12:43 a.m.)


Review request for Ambari, Alexander Denissov and Matt.


Bugs: AMBARI-18110
https://issues.apache.org/jira/browse/AMBARI-18110


Repository: ambari


Description
---

Ambari build jobs are not running the unit tests for HAWQ.
HAWQ (and PXF) unit tests in the new common-services directory under test is 
being ignored during mvn's test phase.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 529c492 
  ambari-server/src/test/python/common-services/HAWQ/hawq_base_test_case.py 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
 b2e1d4d 
  
ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
 4066e29 
  ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
a44cad1 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 62d54cf 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
48203ca 
  ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
8674549 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
e0f1c43 
  ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
ee187e2 
  ambari-server/src/test/python/common-services/PXF/test_pxf.py c291261 
  ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
8b2a4ba 
  ambari-server/src/test/python/unitTests.py b010804 

Diff: https://reviews.apache.org/r/50965/diff/


Testing
---

```
Running tests for stack:None service:HAWQ
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 
/Users/ljain/dev/pivotal/ambari/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts
2016-08-10 13:20:33,060 - Removing HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-08-10 13:20:33,063 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-08-10 13:20:33,067 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-08-10 13:20:33,074 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145421
---


Ship it!




Ship It!

- Swapan Shridhar


On Aug. 10, 2016, 10:44 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 10, 2016, 10:44 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 
> 2bd1f99 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/
---

(Updated Aug. 10, 2016, 10:44 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.


Bugs: AMBARI-18070
https://issues.apache.org/jira/browse/AMBARI-18070


Repository: ambari


Description
---

Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
advertise_version as "false".

Atlas in common-services for has the following,
0.1.0.2.3 has versionAdvertised=false
0.7.0.2.5 has versionAdvertised=true

However, the current logic in ComponentModule always take the value of the 
parent, which is incorrect.

To fix this, if the current component has false, then take the value of the 
parent.

The ideal way to do this is to use another variable (a string) to read from the 
xml file so we can store "true", "false", null. If that variable is null, then 
inherit from the parent.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
d9d3105 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
a5004b2 
  ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
630d403 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 f21b250 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 
2bd1f99 

Diff: https://reviews.apache.org/r/50911/diff/


Testing
---

Added unit test. Waiting for full unit test results.

Verified via the api,
/api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
/api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true

Also tested with Storm, which has 4 versions inside common-services, by setting 
the metainfo.xml file for all versions  with versionAdvertised=false, which 
yielded advertise_version=false for all versions via the API, and then
changing only the first metainfo.xml file to versionAdvertised=true in 
metainfo.xml, which yielded all versions via the API reporting 
advertise_version=true


Thanks,

Alejandro Fernandez

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/#review145407
---


Ship it!




Looks good, very useful refactoring. Please consider a few suggestions for 
naming.

- Alexander Denissov


On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50965/
> ---
> 
> (Updated Aug. 10, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-18110
> https://issues.apache.org/jira/browse/AMBARI-18110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari build jobs are not running the unit tests for HAWQ.
> HAWQ (and PXF) unit tests in the new common-services directory under test is 
> being ignored during mvn's test phase.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  529c492 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
>  b2e1d4d 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
>  4066e29 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
> a44cad1 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py 
> PRE-CREATION 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 
> 62d54cf 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
> 48203ca 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
> 8674549 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> e0f1c43 
>   ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
> ee187e2 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 8b2a4ba 
>   ambari-server/src/test/python/unitTests.py b010804 
> 
> Diff: https://reviews.apache.org/r/50965/diff/
> 
> 
> Testing
> ---
> 
> ```
> Running tests for stack:None service:HAWQ
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 
> /Users/ljain/dev/pivotal/ambari/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts
> 2016-08-10 13:20:33,060 - Removing HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-08-10 13:20:33,063 - HAWQ 
> Standby Master Re-Sync

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-10 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50965/#review145405
---




ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
 (line 35)


probably do not need this here



ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py (line 25)


if this is a base class for HAWQ tests, maybe call it HAWQTestCase to 
denote that this is not a test class by itself ?



ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py (line 27)


this is where packages for HAWQ are, so COMMON_SERVICES_PACKAGE_DIR is a 
bit too general name for HAWQ specific directory



ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
(line 28)


PXF_ALERTS_DIR_PATH would be a better name


- Alexander Denissov


On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50965/
> ---
> 
> (Updated Aug. 10, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Matt.
> 
> 
> Bugs: AMBARI-18110
> https://issues.apache.org/jira/browse/AMBARI-18110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari build jobs are not running the unit tests for HAWQ.
> HAWQ (and PXF) unit tests in the new common-services directory under test is 
> being ignored during mvn's test phase.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  529c492 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py
>  b2e1d4d 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py
>  4066e29 
>   
> ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py 
> a44cad1 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py 
> PRE-CREATION 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py 
> 62d54cf 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py 
> 48203ca 
>   ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py 
> 8674549 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> e0f1c43 
>   ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py 
> ee187e2 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 8b2a4ba 
>   ambari-server/src/test/python/unitTests.py b010804 
> 
> Diff: https://reviews.apache.org/r/50965/diff/
> 
> 
> Testing
> ---
> 
> ```
> Running tests for stack:None service:HAWQ
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
>

Re: Review Request 50927: AMBARI-18012 : AMS Metrics Sink unable to connect to zookeeper to locate collector host.

2016-08-10 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50927/
---

(Updated Aug. 10, 2016, 7:54 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18012
https://issues.apache.org/jira/browse/AMBARI-18012


Repository: ambari


Description (updated)
---

Following exception is seen in the logs

Unable to connect to zookeeper.
java.lang.IllegalStateException: Client is not started
at 
org.apache.hadoop.metrics2.sink.relocated.google.common.base.Preconditions.checkState(Preconditions.java:149)
at 
org.apache.hadoop.metrics2.sink.relocated.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:77)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:74)
at 
org.apache.hadoop.metrics2.sink.relocated.curator.RetryLoop.callWithRetry(RetryLoop.java:107)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:74)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:363)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:209)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:315)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)


FIX
Fixed the issue in curator API usage.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 7b13362 

Diff: https://reviews.apache.org/r/50927/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 50927: AMBARI-18012 : AMS Metrics Sink unable to connect to zookeeper to locate collector host.

2016-08-10 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50927/#review145388
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 (line 58)


Why this change only in hbase properties?


- Sid Wagle


On Aug. 9, 2016, 6:38 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50927/
> ---
> 
> (Updated Aug. 9, 2016, 6:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18012
> https://issues.apache.org/jira/browse/AMBARI-18012
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following exception is seen in the logs
> 
> Unable to connect to zookeeper.
> java.lang.IllegalStateException: Client is not started
> at 
> org.apache.hadoop.metrics2.sink.relocated.google.common.base.Preconditions.checkState(Preconditions.java:149)
> at 
> org.apache.hadoop.metrics2.sink.relocated.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:77)
> at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:74)
> at 
> org.apache.hadoop.metrics2.sink.relocated.curator.RetryLoop.callWithRetry(RetryLoop.java:107)
> at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:74)
> at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:363)
> at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:209)
> at 
> org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:315)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
> at 
> org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
> at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
> 
> 
> FIX
> Fixed the issue in curator API usage.
> Also fixed an issue due to redundant protocol addition in the URL for AMS 
> metrics.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  7b13362 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  8d4a806 
> 
> Diff: https://reviews.apache.org/r/50927/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 50963: Add Kerberos Automation documentation to Ambari source tree so it may be versioned

2016-08-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50963/
---

Review request for Ambari, Hitesh Shah, Jonathan Hurley, Mahadev Konar, Nate 
Cole, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-18100
https://issues.apache.org/jira/browse/AMBARI-18100


Repository: ambari


Description
---

Add Kerberos Automation documentation to Ambari source tree so it may be 
versioned. This documentation should be added as MD (markdown) files to 
.../ambari-server/docs/security/kerberos.


Diffs
-

  ambari-server/docs/security/kerberos/enabling_kerberos.md PRE-CREATION 
  ambari-server/docs/security/kerberos/index.md PRE-CREATION 
  ambari-server/docs/security/kerberos/kerberos_descriptor.md PRE-CREATION 
  ambari-server/docs/security/kerberos/kerberos_service.md PRE-CREATION 

Diff: https://reviews.apache.org/r/50963/diff/


Testing
---

None needed, documentation only.


Thanks,

Robert Levas

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145379
---


Ship it!




Ship It!

- Nate Cole


On Aug. 10, 2016, 2:25 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 10, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50961: Permission denied issue during hive service check

2016-08-10 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50961/
---

(Updated Сер. 10, 2016, 6:21 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-18107
https://issues.apache.org/jira/browse/AMBARI-18107


Repository: ambari


Description
---

In hive service check we have code for templeton which creates few files like: 
show_db.post.txt and pig_post.txt. One thing is that these files will not be 
removed, so next service check should rewrite this files. In case when user 
changed some permissions/users/umask we will have permission problems like:
{code}
/var/lib/ambari-agent/tmp/show_db.post.txt: Permission denied
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 8d763cb 

Diff: https://reviews.apache.org/r/50961/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Jonathan Hurley 


> On Aug. 10, 2016, 8:28 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> >  lines 42-51
> > 
> >
> > Shouldn't need a new enum when TRUE/FALSE/NULL would suffice.
> 
> Alejandro Fernandez wrote:
> Are you suggesting Boolean instead? I think an Enum is just as simple but 
> gives us more options.
> 
> Nate Cole wrote:
> What are the other options?  null-checking is common.  Are you saying in 
> the above comment that true/false/inherit/null is valid?  What happens/what 
> is the default if you use the enum and it's null?

Inherit is implied if there is no element, right? That's basically null. I'm 
fine with leaving it as a boolean and null-checking to see if it's defined. The 
enum just converts the lack of an element into a switch-able type.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145333
---


On Aug. 9, 2016, 9:22 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 9, 2016, 9:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Nate Cole 


> On Aug. 10, 2016, 8:28 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> >  lines 42-51
> > 
> >
> > Shouldn't need a new enum when TRUE/FALSE/NULL would suffice.
> 
> Alejandro Fernandez wrote:
> Are you suggesting Boolean instead? I think an Enum is just as simple but 
> gives us more options.

What are the other options?  null-checking is common.  Are you saying in the 
above comment that true/false/inherit/null is valid?  What happens/what is the 
default if you use the enum and it's null?


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145333
---


On Aug. 9, 2016, 9:22 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 9, 2016, 9:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Sumit Mohanty 


> On Aug. 10, 2016, 5:55 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> >  line 49
> > 
> >
> > If null works then why do we need "inherit"? null should result in the 
> > same behavior as inherit, isn't it?
> > 
> > By the way what happens in case of 
> > - missing  in the meta info
> > - 
> > 
> > Are both of these null?
> 
> Alejandro Fernandez wrote:
> I can remove "inherit", which is equivalent to null according to the 
> logic.

Seems like that to me.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145308
---


On Aug. 10, 2016, 1:22 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Alejandro Fernandez 


> On Aug. 10, 2016, 5:55 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> >  line 49
> > 
> >
> > If null works then why do we need "inherit"? null should result in the 
> > same behavior as inherit, isn't it?
> > 
> > By the way what happens in case of 
> > - missing  in the meta info
> > - 
> > 
> > Are both of these null?

I can remove "inherit", which is equivalent to null according to the logic.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145308
---


On Aug. 10, 2016, 1:22 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-10 Thread Alejandro Fernandez 


> On Aug. 10, 2016, 12:28 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java,
> >  lines 42-51
> > 
> >
> > Shouldn't need a new enum when TRUE/FALSE/NULL would suffice.

Are you suggesting Boolean instead? I think an Enum is just as simple but gives 
us more options.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50911/#review145333
---


On Aug. 10, 2016, 1:22 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50911/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18070
> https://issues.apache.org/jira/browse/AMBARI-18070
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fresh install of HDP 2.5 does not have a version for ATLAS_SERVER or 
> ATLAS_CLIENT in the database (hostcomponentstate table) because ATLAS has 
> advertise_version as "false".
> 
> Atlas in common-services for has the following,
> 0.1.0.2.3 has versionAdvertised=false
> 0.7.0.2.5 has versionAdvertised=true
> 
> However, the current logic in ComponentModule always take the value of the 
> parent, which is incorrect.
> 
> To fix this, if the current component has false, then take the value of the 
> parent.
> 
> The ideal way to do this is to use another variable (a string) to read from 
> the xml file so we can store "true", "false", null. If that variable is null, 
> then inherit from the parent.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  d9d3105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a5004b2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml 
> 630d403 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  f21b250 
> 
> Diff: https://reviews.apache.org/r/50911/diff/
> 
> 
> Testing
> ---
> 
> Added unit test. Waiting for full unit test results.
> 
> Verified via the api,
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=false
> /api/v1/stacks/HDP/2.5/services/ATLAS/components has advertise_version=true
> 
> Also tested with Storm, which has 4 versions inside common-services, by 
> setting the metainfo.xml file for all versions  with versionAdvertised=false, 
> which yielded advertise_version=false for all versions via the API, and then
> changing only the first metainfo.xml file to versionAdvertised=true in 
> metainfo.xml, which yielded all versions via the API reporting 
> advertise_version=true
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145358
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 (line 42)


Since hive interactive is available since 2.5, shouldnt this change be a 
part of HDP 2.5 ?


- Gautam Borad


On Aug. 10, 2016, 2:27 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
>  ce4074a 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50948: stack_advisor should recommend AMS cache size and commit frequency

2016-08-10 Thread Sid Wagle 


> On Aug. 10, 2016, 4:17 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 664
> > 
> >
> > Can you add some comment about this growth function?
> 
> Dmytro Sen wrote:
> Attached graph to https://issues.apache.org/jira/browse/AMBARI-18098
> 
> Recommended cache size is based on number of sinks in the cluster - for 
> small cluster recommended cache size is 200, for large up to 800

Excellent, although we should make sure AMS memory setting is scaled by the 
same factor else this could cause OOM ?


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50948/#review145348
---


On Aug. 10, 2016, 12:25 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50948/
> ---
> 
> (Updated Aug. 10, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-18098
> https://issues.apache.org/jira/browse/AMBARI-18098
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> stack_advisor should recommend AMS cache size and commit frequency depending 
> on cluster size
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 87618a8 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 3f41acb 
> 
> Diff: https://reviews.apache.org/r/50948/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145354
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 10, 2016, 12:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50953/
> ---
> 
> (Updated Aug. 10, 2016, 12:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing code basically does that:
> takes all config versions that ever existed, iterates them in random order, 
> and the config that happened to be last gets into final configuration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
>  fdd7f1d 
> 
> Diff: https://reviews.apache.org/r/50953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50948: stack_advisor should recommend AMS cache size and commit frequency

2016-08-10 Thread Dmytro Sen 


> On Авг. 10, 2016, 4:17 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 664
> > 
> >
> > Can you add some comment about this growth function?

Attached graph to https://issues.apache.org/jira/browse/AMBARI-18098

Recommended cache size is based on number of sinks in the cluster - for small 
cluster recommended cache size is 200, for large up to 800


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50948/#review145348
---


On Авг. 10, 2016, 12:25 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50948/
> ---
> 
> (Updated Авг. 10, 2016, 12:25 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-18098
> https://issues.apache.org/jira/browse/AMBARI-18098
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> stack_advisor should recommend AMS cache size and commit frequency depending 
> on cluster size
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 87618a8 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 3f41acb 
> 
> Diff: https://reviews.apache.org/r/50948/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50951: Update zeppelin shiro.ini template with ActiveDirectoryGroupRealm info

2016-08-10 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50951/#review145352
---


Ship it!




Ship It!

- Prabhjyot Singh


On Aug. 10, 2016, 4:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50951/
> ---
> 
> (Updated Aug. 10, 2016, 4:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Prabhjyot Singh, Rohit 
> Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18101
> https://issues.apache.org/jira/browse/AMBARI-18101
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add additional sample config for Zeppelin LDAP integration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  ddca230 
> 
> Diff: https://reviews.apache.org/r/50951/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 50951: Update zeppelin shiro.ini template with ActiveDirectoryGroupRealm info

2016-08-10 Thread Rohit Choudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50951/#review145350
---


Ship it!




Ship It!

- Rohit Choudhary


On Aug. 10, 2016, 4:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50951/
> ---
> 
> (Updated Aug. 10, 2016, 4:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Prabhjyot Singh, Rohit 
> Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18101
> https://issues.apache.org/jira/browse/AMBARI-18101
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add additional sample config for Zeppelin LDAP integration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  ddca230 
> 
> Diff: https://reviews.apache.org/r/50951/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 50951: Update zeppelin shiro.ini template with ActiveDirectoryGroupRealm info

2016-08-10 Thread Renjith Kamath 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50951/
---

(Updated Aug. 10, 2016, 4:23 p.m.)


Review request for Ambari, Alejandro Fernandez, Prabhjyot Singh, Rohit 
Choudhary, and Sumit Mohanty.


Bugs: AMBARI-18101
https://issues.apache.org/jira/browse/AMBARI-18101


Repository: ambari


Description
---

- add additional sample config for Zeppelin LDAP integration


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 ddca230 

Diff: https://reviews.apache.org/r/50951/diff/


Testing
---

manually tested


Thanks,

Renjith Kamath

Re: Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145349
---




ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
 


random order


- Dmitro Lisnichenko


On Aug. 10, 2016, 7:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50953/
> ---
> 
> (Updated Aug. 10, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing code basically does that:
> takes all config versions that ever existed, iterates them in random order, 
> and the config that happened to be last gets into final configuration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
>  fdd7f1d 
> 
> Diff: https://reviews.apache.org/r/50953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/#review145347
---




ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
 


all config versions that ever existed


- Dmitro Lisnichenko


On Aug. 10, 2016, 7:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50953/
> ---
> 
> (Updated Aug. 10, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing code basically does that:
> takes all config versions that ever existed, iterates them in random order, 
> and the config that happened to be last gets into final configuration
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
>  fdd7f1d 
> 
> Diff: https://reviews.apache.org/r/50953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50948: stack_advisor should recommend AMS cache size and commit frequency

2016-08-10 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50948/#review145348
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 664)


Can you add some comment about this growth function?


- Sid Wagle


On Aug. 10, 2016, 12:25 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50948/
> ---
> 
> (Updated Aug. 10, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-18098
> https://issues.apache.org/jira/browse/AMBARI-18098
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> stack_advisor should recommend AMS cache size and commit frequency depending 
> on cluster size
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 87618a8 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 3f41acb 
> 
> Diff: https://reviews.apache.org/r/50948/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 50953: For discussion: AlertDefinitionCommand sends random (stale configs)

2016-08-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50953/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Repository: ambari


Description
---

Existing code basically does that:
takes all config versions that ever existed, iterates them in random order, and 
the config that happened to be last gets into final configuration


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java
 fdd7f1d 

Diff: https://reviews.apache.org/r/50953/diff/


Testing
---


Thanks,

Dmitro Lisnichenko

Re: Review Request 50952: Reinstalling or upgrading ambari-server emits a warning

2016-08-10 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50952/#review145338
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Сер. 10, 2016, 2:44 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50952/
> ---
> 
> (Updated Сер. 10, 2016, 2:44 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18103
> https://issues.apache.org/jira/browse/AMBARI-18103
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> cp: cannot stat ‘//var/lib/ambari-server/resources/views/*.jar’: No such file 
> or directory
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/package/rpm/preinstall.sh 6ed7444 
> 
> Diff: https://reviews.apache.org/r/50952/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

(Updated Aug. 10, 2016, 2:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 715f2f5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 ce4074a 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia

Re: Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Robert Levas 


> On Aug. 10, 2016, 2:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, 
> > line 697
> > 
> >
> > Rob - kerberos.json already has the spec to set the value to true. So 
> > the stack advisor changes should not be necessary.
> > 
> > I am happy to drop this patch unless you feel that the stack advisor is 
> > where we should keep the logic instead of kerberos.json.

I would eventually like to move all the configuration blocks from the Kerberos 
descriptor to the stack advisor.  Since the stack advisor is _smarter_ than the 
Kerberos descroptor logic, more flexibilty in setting properties can be 
utilized.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/#review145311
---


On Aug. 10, 2016, 2:18 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50946/
> ---
> 
> (Updated Aug. 10, 2016, 2:18 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-18096
> https://issues.apache.org/jira/browse/AMBARI-18096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Summarizing what we need to do in Ambari :
> 
> - yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
> - If (security is ON and TDE is OFF) -> 
> yarn.resourcemanager.proxy-user-privileges.enabled = True
> - If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 9a099c6 
> 
> Diff: https://reviews.apache.org/r/50946/diff/
> 
> 
> Testing
> ---
> 
> Manually ran all unit tests. Tested by patching a private cluster.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 715f2f5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 ce4074a 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia

Re: Review Request 50886: config page load takes long time on cluster with large number of config versions

2016-08-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50886/#review145334
---


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 9, 2016, 6:45 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50886/
> ---
> 
> (Updated Aug. 9, 2016, 6:45 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jonathan Hurley, Myroslav 
> Papirkovskyy, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18055
> https://issues.apache.org/jira/browse/AMBARI-18055
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> config page load takes long time on cluster with large number of config 
> versions
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1484953 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionRequest.java
>  b32ccdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
>  d7287e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
>  128fef0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  22f82fc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 0519123 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0d212a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
>  78461dc 
>   ambari-web/app/utils/ajax/ajax.js e432e0c 
> 
> Diff: https://reviews.apache.org/r/50886/diff/
> 
> 
> Testing
> ---
> 
> Verifed manually on a deployed cluster
> Added a unit test. Verified that corresponding unit tests to the files that 
> have been changed passes.
> waiting for Hadoop QA job to post result
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 50948: stack_advisor should recommend AMS cache size and commit frequency

2016-08-10 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50948/
---

Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-18098
https://issues.apache.org/jira/browse/AMBARI-18098


Repository: ambari


Description
---

stack_advisor should recommend AMS cache size and commit frequency depending on 
cluster size


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
87618a8 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 3f41acb 

Diff: https://reviews.apache.org/r/50948/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 50850: Pig view - Pig script creation fails

2016-08-10 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50850/#review145332
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Aug. 10, 2016, 9:53 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50850/
> ---
> 
> (Updated Aug. 10, 2016, 9:53 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, Robert Levas, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18045
> https://issues.apache.org/jira/browse/AMBARI-18045
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added date deserializer for parsing epoch time.
> 
> 
> Diffs
> -
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js abd72f1 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/models/pig_script.js 
> 641180f 
> 
> Diff: https://reviews.apache.org/r/50850/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 50850: Pig view - Pig script creation fails

2016-08-10 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50850/
---

(Updated Aug. 10, 2016, 9:53 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, Robert Levas, and Ashwin Rajeev.


Changes
---

Added different transformer for pigscript date.


Bugs: AMBARI-18045
https://issues.apache.org/jira/browse/AMBARI-18045


Repository: ambari


Description
---

Added date deserializer for parsing epoch time.


Diffs (updated)
-

  contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js abd72f1 
  contrib/views/pig/src/main/resources/ui/pig-web/app/models/pig_script.js 
641180f 

Diff: https://reviews.apache.org/r/50850/diff/


Testing
---

Manually Tested


Thanks,

Gaurav Nagar

Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-10 Thread Dmytro Grinenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review145318
---


Ship it!




Ship It!

- Dmytro Grinenko


On Aug. 9, 2016, 2:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 9, 2016, 2:15 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50710/#review145317
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 9, 2016, 5:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50710/
> ---
> 
> (Updated Aug. 9, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17991
> https://issues.apache.org/jira/browse/AMBARI-17991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use Jetty 8 instead of 9 in Ambari 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-funtest/pom.xml ebc34ec 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 0a24759 
>   ambari-project/pom.xml c7a0a6a 
>   ambari-server/pom.xml 814973b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/AmbariErrorHandler.java
>  373face 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bd96868 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  44cdf2b 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/JsonUtils.java 
> 63c88d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/AmbariErrorHandlerTest.java
>  30c22a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
>  1e063ec 
> 
> Diff: https://reviews.apache.org/r/50710/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/#review145311
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
696)


Rob - kerberos.json already has the spec to set the value to true. So the 
stack advisor changes should not be necessary.

I am happy to drop this patch unless you feel that the stack advisor is 
where we should keep the logic instead of kerberos.json.


- Sumit Mohanty


On Aug. 10, 2016, 6:18 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50946/
> ---
> 
> (Updated Aug. 10, 2016, 6:18 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-18096
> https://issues.apache.org/jira/browse/AMBARI-18096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Summarizing what we need to do in Ambari :
> 
> - yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
> - If (security is ON and TDE is OFF) -> 
> yarn.resourcemanager.proxy-user-privileges.enabled = True
> - If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 9a099c6 
> 
> Diff: https://reviews.apache.org/r/50946/diff/
> 
> 
> Testing
> ---
> 
> Manually ran all unit tests. Tested by patching a private cluster.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/
---

Review request for Ambari, Robert Levas and Swapan Shridhar.


Bugs: AMBARI-18096
https://issues.apache.org/jira/browse/AMBARI-18096


Repository: ambari


Description
---

Summarizing what we need to do in Ambari :

- yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
- If (security is ON and TDE is OFF) -> 
yarn.resourcemanager.proxy-user-privileges.enabled = True
- If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
9a099c6 

Diff: https://reviews.apache.org/r/50946/diff/


Testing
---

Manually ran all unit tests. Tested by patching a private cluster.


Thanks,

Sumit Mohanty