Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52688/#review154514
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 19, 2016, 11:42 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52688/
> ---
> 
> (Updated Oct. 19, 2016, 11:42 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18561
> https://issues.apache.org/jira/browse/AMBARI-18561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calculating absolute capacity for node labels
> Render sunburst chart based on node label capacity when selected
> Read-only mode for non-operator users in preemption and queue mappings
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  032b2ec 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  1d07351 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  d5b19ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  af15fa5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  631edbb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  9d84704 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  e7fba41 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  aa139b1 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e2d67bd 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> d838958 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  1ab1740 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  9973708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  6d398f6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  8fe627e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  f143911 
> 
> Diff: https://reviews.apache.org/r/52688/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154505
---


Ship it!




Ship It!

- Ashwin Rajeev


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154504
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50561/#review154502
---


Ship it!




Ship It!


contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 (line 154)


You could write a css class rather including inline styles.


- Pallav Kulshreshtha


On July 28, 2016, 11:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50561/
> ---
> 
> (Updated July 28, 2016, 11:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17943
> https://issues.apache.org/jira/browse/AMBARI-17943
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed the linefeed and carriage return and improved UX
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  061a445 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  d84dc4d 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  061a445 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  d84dc4d 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java
>  2c890f5 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java
>  be5733f 
> 
> Diff: https://reviews.apache.org/r/50561/diff/
> 
> 
> Testing
> ---
> 
> manual testing done
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52822/#review154501
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52822/
> ---
> 
> (Updated Oct. 13, 2016, 8:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18583
> https://issues.apache.org/jira/browse/AMBARI-18583
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ealiear BOM characters in the file were creating problem in upload. Now they 
> are removed using apache commons io library.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  9800c22 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  7dccbd4 
> 
> Diff: https://reviews.apache.org/r/52822/diff/
> 
> 
> Testing
> ---
> 
> manual testing done to verify support for both Big-endian and little-endian 
> BOM.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154495
---


Ship it!




Ship It!

- Gaurav Nagar


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52822/#review154494
---


Ship it!




Ship It!

- Gaurav Nagar


On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52822/
> ---
> 
> (Updated Oct. 13, 2016, 8:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18583
> https://issues.apache.org/jira/browse/AMBARI-18583
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ealiear BOM characters in the file were creating problem in upload. Now they 
> are removed using apache commons io library.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  9800c22 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  7dccbd4 
> 
> Diff: https://reviews.apache.org/r/52822/diff/
> 
> 
> Testing
> ---
> 
> manual testing done to verify support for both Big-endian and little-endian 
> BOM.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50561/#review154493
---


Ship it!




Ship It!

- Gaurav Nagar


On July 28, 2016, 11:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50561/
> ---
> 
> (Updated July 28, 2016, 11:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17943
> https://issues.apache.org/jira/browse/AMBARI-17943
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed the linefeed and carriage return and improved UX
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  061a445 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  d84dc4d 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  061a445 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  d84dc4d 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java
>  2c890f5 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java
>  be5733f 
> 
> Diff: https://reviews.apache.org/r/50561/diff/
> 
> 
> Testing
> ---
> 
> manual testing done
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 53364: AMBARI-18767 - E2E Integration for Manage JournalNode Wizard

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53364/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Bugs: AMBARI-18767
https://issues.apache.org/jira/browse/AMBARI-18767


Repository: ambari


Description
---

E2E Integration for Manage JournalNode Wizard.
2 more step has been added to ensure data consistency of HDFS.


Diffs
-

  ambari-web/app/controllers.js e576d6c 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js
 0da5264 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js
 920bbd1e 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js
 39a074e 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js
 a0425c8 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js
 PRE-CREATION 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step8_controller.js
 PRE-CREATION 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js
 56b6ff5 
  ambari-web/app/messages.js 45dfc2c 
  ambari-web/app/routes/manage_journalnode_routes.js 4803ca7 
  ambari-web/app/styles/application.less d0eebce 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
ae01f46 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step7.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step8.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs 
e654c50 
  ambari-web/app/views.js 2dda9dd 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js 
c32bd74 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step3_view.js 
cac4a7e 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step5_view.js 
651cabd 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step7_view.js 
PRE-CREATION 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step8_view.js 
PRE-CREATION 
  ambari-web/app/views/main/admin/highAvailability/journalNode/wizard_view.js 
434971b 

Diff: https://reviews.apache.org/r/53364/diff/


Testing
---

Manually tested on live cluster. All unit tests passed.


Thanks,

Richard Zang

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

[Jeff Zhang]

> On Nov. 1, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py,
> >  line 234
> > 
> >
> > Is this meant to account for a different Spark version in HDP stack?
> > If so, we can use stack_features.json and the check_stack_feature 
> > function to make it more clear why this is the case.
> 
> Jeff Zhang wrote:
> yes, this is only for HDP 2.6 or later version.  This is not feature, 
> just a compablity break, so I think it is not necessary to put it in 
> stack_features.json
> 
> Jeff Zhang wrote:
> BTW, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> Alejandro Fernandez wrote:
> We still don't have upgrade packs and config packs for HDP 2.5 to 2.6

Do you mean currently upgrade from 2.5 to 2.6 is not supported, and I can add 
that to config-upgrade.xml when it is supported ?


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53334/#review154422
---


On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53334/
> ---
> 
> (Updated Nov. 1, 2016, 1:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18758
> https://issues.apache.org/jira/browse/AMBARI-18758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 configuration key are changed.
> 
> livy.server.kerberos.keytab  --> livy.server.launch.kerberos.keytab
> livy.server.kerberos.principal  --> livy.server.launch.kerberos.principal
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3a1c482 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53334/diff/
> 
> 
> Testing
> ---
> 
> I have verified it in HDP 2.6. But havn't done for the upgrade.
> 
> @afernandez, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

[Alejandro Fernandez]

> On Nov. 1, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py,
> >  line 234
> > 
> >
> > Is this meant to account for a different Spark version in HDP stack?
> > If so, we can use stack_features.json and the check_stack_feature 
> > function to make it more clear why this is the case.
> 
> Jeff Zhang wrote:
> yes, this is only for HDP 2.6 or later version.  This is not feature, 
> just a compablity break, so I think it is not necessary to put it in 
> stack_features.json
> 
> Jeff Zhang wrote:
> BTW, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml

We still don't have upgrade packs and config packs for HDP 2.5 to 2.6


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53334/#review154422
---


On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53334/
> ---
> 
> (Updated Nov. 1, 2016, 1:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18758
> https://issues.apache.org/jira/browse/AMBARI-18758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 configuration key are changed.
> 
> livy.server.kerberos.keytab  --> livy.server.launch.kerberos.keytab
> livy.server.kerberos.principal  --> livy.server.launch.kerberos.principal
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3a1c482 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53334/diff/
> 
> 
> Testing
> ---
> 
> I have verified it in HDP 2.6. But havn't done for the upgrade.
> 
> @afernandez, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

[Jeff Zhang]

> On Nov. 1, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py,
> >  line 234
> > 
> >
> > Is this meant to account for a different Spark version in HDP stack?
> > If so, we can use stack_features.json and the check_stack_feature 
> > function to make it more clear why this is the case.
> 
> Jeff Zhang wrote:
> yes, this is only for HDP 2.6 or later version.  This is not feature, 
> just a compablity break, so I think it is not necessary to put it in 
> stack_features.json

BTW, do you know how to change the configuration key for upgrade ? I didn't 
find samples in config-upgrade.xml


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53334/#review154422
---


On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53334/
> ---
> 
> (Updated Nov. 1, 2016, 1:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18758
> https://issues.apache.org/jira/browse/AMBARI-18758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 configuration key are changed.
> 
> livy.server.kerberos.keytab  --> livy.server.launch.kerberos.keytab
> livy.server.kerberos.principal  --> livy.server.launch.kerberos.principal
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3a1c482 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53334/diff/
> 
> 
> Testing
> ---
> 
> I have verified it in HDP 2.6. But havn't done for the upgrade.
> 
> @afernandez, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

[Jeff Zhang]

> On Nov. 1, 2016, 5:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py,
> >  line 234
> > 
> >
> > Is this meant to account for a different Spark version in HDP stack?
> > If so, we can use stack_features.json and the check_stack_feature 
> > function to make it more clear why this is the case.

yes, this is only for HDP 2.6 or later version.  This is not feature, just a 
compablity break, so I think it is not necessary to put it in 
stack_features.json


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53334/#review154422
---


On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53334/
> ---
> 
> (Updated Nov. 1, 2016, 1:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18758
> https://issues.apache.org/jira/browse/AMBARI-18758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 configuration key are changed.
> 
> livy.server.kerberos.keytab  --> livy.server.launch.kerberos.keytab
> livy.server.kerberos.principal  --> livy.server.launch.kerberos.principal
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3a1c482 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53334/diff/
> 
> 
> Testing
> ---
> 
> I have verified it in HDP 2.6. But havn't done for the upgrade.
> 
> @afernandez, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 51744: SmartSense Mandatory Install

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51744/#review154483
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 1, 2016, 11:55 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51744/
> ---
> 
> (Updated Nov. 1, 2016, 11:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Zhe (Joe) Wang, 
> Richard Zang, Sumit Mohanty, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18346
> https://issues.apache.org/jira/browse/AMBARI-18346
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform a UI hack to force selection of SmartSense for HDP stacks (the user 
> cannot deselect).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> e0280b4 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> fb50f68 
>   ambari-web/app/controllers/wizard/step4_controller.js 7ad78cc 
>   ambari-web/app/mappers/stack_service_mapper.js c800e83 
>   ambari-web/app/models/stack_service.js 9cf9d49 
>   ambari-web/app/templates/wizard/step4.hbs c62d369 
> 
> Diff: https://reviews.apache.org/r/51744/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> Ambari-web unit test pass.
> 29244 tests complete (26 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 51744: SmartSense Mandatory Install

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51744/
---

(Updated Nov. 1, 2016, 11:53 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

Verified Manually.
Ambari-web unit tests pass.
29545 tests complete (25 seconds)
154 tests pending


Bugs: AMBARI-18346
https://issues.apache.org/jira/browse/AMBARI-18346


Repository: ambari


Description
---

Perform a UI hack to force selection of SmartSense for HDP stacks (the user 
cannot deselect).


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
e0280b4 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
fb50f68 
  ambari-web/app/controllers/wizard/step4_controller.js 7ad78cc 
  ambari-web/app/mappers/stack_service_mapper.js c800e83 
  ambari-web/app/models/stack_service.js 9cf9d49 
  ambari-web/app/templates/wizard/step4.hbs c62d369 

Diff: https://reviews.apache.org/r/51744/diff/


Testing
---

Verified manually.
Ambari-web unit test pass.
29244 tests complete (26 seconds)
154 tests pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53314/#review154479
---




ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
(line 29)


Doesn't really matter.


- Alejandro Fernandez


On Oct. 31, 2016, 8:09 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53314/
> ---
> 
> (Updated Oct. 31, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18732
> https://issues.apache.org/jira/browse/AMBARI-18732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need a fake stack that will make it easier to perform lifecycle commands 
> such as Start, Stop, Restart, Status, Service Checks etc.
> 
> This stack will eventually support UI themes, Kerberos, Alerts, etc. 
> 
> For now, the PERF stack should have 8+ services (HDFS, YARN, MR, ZK, plus 
> dummy ones like Happy, Sleepy, Grumpy, etc).
> We do want some of the complexity of the Hadoop core services and their 
> configs, and we also want really simple services (like the dwarfs) that can 
> be deployed on their own.
> 
> This stack should serve as a sample for how to implement a new stack, and 
> also abstract some of the complexity of the HDP stack in order to run 
> performance tests that stress the server by overloading it with heartbeats, 
> alerts, etc.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/after-INSTALL/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/configuration/happy-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/package/scripts/dwarf.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/configuration/snow-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/package/scripts/snow_white.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/themes/theme.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with just Snow and Happy services.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53314/#review154476
---


Ship it!





ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
(line 29)


nit. Do we need a different component name than the service name?


- Aravindan Vijayan


On Oct. 31, 2016, 8:09 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53314/
> ---
> 
> (Updated Oct. 31, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18732
> https://issues.apache.org/jira/browse/AMBARI-18732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need a fake stack that will make it easier to perform lifecycle commands 
> such as Start, Stop, Restart, Status, Service Checks etc.
> 
> This stack will eventually support UI themes, Kerberos, Alerts, etc. 
> 
> For now, the PERF stack should have 8+ services (HDFS, YARN, MR, ZK, plus 
> dummy ones like Happy, Sleepy, Grumpy, etc).
> We do want some of the complexity of the Hadoop core services and their 
> configs, and we also want really simple services (like the dwarfs) that can 
> be deployed on their own.
> 
> This stack should serve as a sample for how to implement a new stack, and 
> also abstract some of the complexity of the HDP stack in order to run 
> performance tests that stress the server by overloading it with heartbeats, 
> alerts, etc.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/after-INSTALL/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-RESTART/scripts/hook.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/configuration/happy-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/package/scripts/dwarf.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/themes/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/configuration/snow-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/package/scripts/snow_white.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/themes/theme.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing with just Snow and Happy services.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53356/#review154475
---




ambari-agent/conf/windows/service_wrapper.py (line 127)


All TODOs will be fixed by AMBARI-18734.


- Alejandro Fernandez


On Nov. 1, 2016, 10:49 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53356/
> ---
> 
> (Updated Nov. 1, 2016, 10:49 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
> Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18733
> https://issues.apache.org/jira/browse/AMBARI-18733
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there are limitations to running multiple Ambari Agents on the same 
> host because it uses a single path for
> /etc/ambari-agent/conf/ambari-agent.ini
> /var/run/ambari-agent/ambari-agent.pid
> /var/lib/ambari-agent/data
> /var/log/ambari-agent/
> 
> Ambari Agent already has a way to change the port, log dir, and pid dir 
> through its config file, so we also need it to support its own unique home 
> directory with its own unique config file.
> Furthermore, the agent will have to override its hostname.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent 30897dd 
>   ambari-agent/conf/windows/service_wrapper.py d031c34 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 78b34e5 
>   ambari-agent/src/main/python/ambari_agent/Facter.py a1f815d 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py a65c1cd 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 82ea9b6 
>   ambari-agent/src/main/python/ambari_agent/Register.py 2d85b03 
>   ambari-agent/src/main/python/ambari_agent/main.py 8cbb839 
>   ambari-agent/src/test/python/ambari_agent/TestCheckWebUI.py 4980477 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py 5c014db 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py ffb5d83 
> 
> Diff: https://reviews.apache.org/r/53356/diff/
> 
> 
> Testing
> ---
> 
> Verified on the PERF stack and up to 100 Ambari Agents running on the same 
> host.
> Unit tests passed.
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 22 licence.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  8.093 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] Ambari Web . SUCCESS [01:35 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.245 
> s]
> [INFO] Ambari Admin View .. SUCCESS [  9.764 
> s]
> [INFO] utility  SUCCESS [  0.294 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.728 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.304 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.745 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.696 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.889 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.480 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.526 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [07:44 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  3.375 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  7.694 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 16.058 
> s]
> [INFO] Ambari Server .. SUCCESS [23:02 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  2.103 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 16.735 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.037 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.368 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.294 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.033 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.036 
> s]
> [INFO] Ambari Groovy Shell  SUCCESS [  3.017 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  0.274 
> s]
> [INFO] Ambari 

Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53356/
---

Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit 
Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18733
https://issues.apache.org/jira/browse/AMBARI-18733


Repository: ambari


Description
---

Currently there are limitations to running multiple Ambari Agents on the same 
host because it uses a single path for
/etc/ambari-agent/conf/ambari-agent.ini
/var/run/ambari-agent/ambari-agent.pid
/var/lib/ambari-agent/data
/var/log/ambari-agent/

Ambari Agent already has a way to change the port, log dir, and pid dir through 
its config file, so we also need it to support its own unique home directory 
with its own unique config file.
Furthermore, the agent will have to override its hostname.


Diffs
-

  ambari-agent/conf/unix/ambari-agent 30897dd 
  ambari-agent/conf/windows/service_wrapper.py d031c34 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 78b34e5 
  ambari-agent/src/main/python/ambari_agent/Facter.py a1f815d 
  ambari-agent/src/main/python/ambari_agent/Hardware.py a65c1cd 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 82ea9b6 
  ambari-agent/src/main/python/ambari_agent/Register.py 2d85b03 
  ambari-agent/src/main/python/ambari_agent/main.py 8cbb839 
  ambari-agent/src/test/python/ambari_agent/TestCheckWebUI.py 4980477 
  ambari-agent/src/test/python/ambari_agent/TestHardware.py 5c014db 
  ambari-agent/src/test/python/ambari_agent/TestMain.py ffb5d83 

Diff: https://reviews.apache.org/r/53356/diff/


Testing
---

Verified on the PERF stack and up to 100 Ambari Agents running on the same host.
Unit tests passed.

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 22 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  8.093 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.036 s]
[INFO] Ambari Web . SUCCESS [01:35 min]
[INFO] Ambari Views ... SUCCESS [  2.245 s]
[INFO] Ambari Admin View .. SUCCESS [  9.764 s]
[INFO] utility  SUCCESS [  0.294 s]
[INFO] ambari-metrics . SUCCESS [  0.728 s]
[INFO] Ambari Metrics Common .. SUCCESS [  5.304 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.745 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.696 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.889 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.480 s]
[INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.526 s]
[INFO] Ambari Metrics Collector ... SUCCESS [07:44 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  3.375 s]
[INFO] Ambari Metrics Grafana . SUCCESS [  7.694 s]
[INFO] Ambari Metrics Assembly  SUCCESS [ 16.058 s]
[INFO] Ambari Server .. SUCCESS [23:02 min]
[INFO] Ambari Functional Tests  SUCCESS [  2.103 s]
[INFO] Ambari Agent ... SUCCESS [ 16.735 s]
[INFO] Ambari Client .. SUCCESS [  0.037 s]
[INFO] Ambari Python Client ... SUCCESS [  0.368 s]
[INFO] Ambari Groovy Client ... SUCCESS [  5.294 s]
[INFO] Ambari Shell ... SUCCESS [  0.033 s]
[INFO] Ambari Python Shell  SUCCESS [  0.036 s]
[INFO] Ambari Groovy Shell  SUCCESS [  3.017 s]
[INFO] ambari-logsearch ... SUCCESS [  0.274 s]
[INFO] Ambari Logsearch Appender .. SUCCESS [  0.329 s]
[INFO] Ambari Logsearch Solr Client ... SUCCESS [  2.076 s]
[INFO] Ambari Logsearch Portal  SUCCESS [  1.739 s]
[INFO] Ambari Logsearch Log Feeder  SUCCESS [  7.252 s]
[INFO] Ambari Logsearch Assembly .. SUCCESS [  0.068 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:14 min
[INFO] Finished at: 2016-11-01T15:43:50-07:00
[INFO] Final Memory: 182M/4025M
[INFO] 


Thanks,

Alejandro 

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

> On Oct. 31, 2016, 4:27 p.m., Robert Levas wrote:
> > This seems dangerous.  
> > 
> > I think it would be a better option to make this explicit by using a 
> > configuration attribute. For example:
> > 
> > '''
> > 
> >   ...
> >   kerberos_principal
> >   ...
> > 
> > '''
> > 
> > However I am not sure if this data is available at the time you would need 
> > it.

Hello Robert,
Would it be ok if a new property type is defined to identify kerberos principal 
EX: kerberos-principal rather than defining it in 
 ? As we currently use password 
to identify and filter out password references while blueprint export.


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review154274
---


On Oct. 28, 2016, 5:50 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Oct. 28, 2016, 5:50 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  f890326 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  5bedb9d 
> 
> Diff: https://reviews.apache.org/r/53213/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Suitable keytabs are generated automatically when not 
> mentioned in blueprint. Service starts succeeded with a blueprint exported 
> with the code change. 
> Modified existing unit test cases.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

[Robert Levas]

On Nov. 1, 2016, 3:32 p.m., Robert Levas wrote:
> > Minor question on the method's transactionality...

ok.. look like a transaction is in order.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53338/#review154441
---


On Nov. 1, 2016, 9:30 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53338/
> ---
> 
> (Updated Nov. 1, 2016, 9:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18751
> https://issues.apache.org/jira/browse/AMBARI-18751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install Ambari 2.4.2 (from branch-2.4)
> - Upgrade to Ambari 2.5.0
> 
> The following exception fails the upgrade. It appears as though this is from 
> [a recent 
> commit|https://github.com/apache/ambari/commit/57116b774c62e5ff6ce22de70458e7c01cccdb07]
>  into {{branch-2.4}}: AMBARI-18433
> 
> When the upgrade runs, it assumes that the role authorizations need to be 
> added. In existing 2.4.0 and 2.4.1 installations, this is true. But since 
> this code is now in the 2.4 branch, 2.4.2+ installations will already have 
> the required data seeded.
> 
> ```
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:220) log() - [c3p0] A 
> PooledConnection that has already signalled a Connection error is still in 
> use!
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:223) log() - [c3p0] 
> Another error has occurred [ org.postgresql.util.PSQLException: ERROR: 
> current transaction is aborted, commands ignored until end of transaction 
> block ] which will not be reported to listeners!
> org.postgresql.util.PSQLException: ERROR: current transaction is aborted, 
> commands ignored until end of transaction block
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
>   at 
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeQuery(NewProxyPreparedStatement.java:353)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.wasFailureCommunicationBased(DatabasePlatform.java:2914)
>   at 
> org.eclipse.persistence.platform.server.ServerPlatformBase.wasFailureCommunicationBased(ServerPlatformBase.java:546)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1616)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
>   at 
> org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.acquireWriteLocks(UnitOfWorkImpl.java:1646)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitTransactionAfterWriteChanges(UnitOfWorkImpl.java:1614)
>   at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.commitRootUnitOfWork(RepeatableWriteUnitOfWork.java:285)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitAndResume(UnitOfWorkImpl.java:1169)
>   at 
> org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:134)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:153)

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53283/#review154442
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 (line 206)


Can you correct your tab stops to be 4 instead of 8?


Just the tab stops adjustment...

- Jonathan Hurley


On Nov. 1, 2016, 1:33 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53283/
> ---
> 
> (Updated Nov. 1, 2016, 1:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Robert Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18744
> https://issues.apache.org/jira/browse/AMBARI-18744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store 
> information
> 
> ** 1. Support specfication for credential store information **
> ```xml
> 
> SERVICE_NAME
>   :
> 
> true
> false
> 
>   :
>   :
> 
> ```
> 
> ** 2. REST API GET/PUT for credential store information and GET for stack 
> definition **
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  eb874b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
>  c4881b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceRequest.java
>  b11d47c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  75f65c0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  13f822e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  0fc65eb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 6f8d306 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 7f83604 
>   ambari-server/src/main/resources/properties.json 34d4641 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
>  f99b5ff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  9986ee3 
> 
> Diff: https://reviews.apache.org/r/53283/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.454s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.046s]
> [INFO] Ambari Web  SUCCESS [1:11.776s]
> [INFO] Ambari Views .. SUCCESS [1.026s]
> [INFO] Ambari Admin View . SUCCESS [6.440s]
> [INFO] utility ... SUCCESS [0.324s]
> [INFO] ambari-metrics  SUCCESS [0.841s]
> [INFO] Ambari Metrics Common . SUCCESS [6.418s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.699s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.202s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.185s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.997s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.428s]
> [INFO] Ambari Metrics Collector .. SUCCESS [8.557s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.103s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.799s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:12.253s]
> [INFO] Ambari Server . SUCCESS [2:27.435s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.044s]
> [INFO] Ambari Agent .. SUCCESS [25.372s]
> [INFO] Ambari Client . SUCCESS [0.060s]
> [INFO] Ambari Python Client .. SUCCESS [1.027s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.933s]
> [INFO] Ambari Shell .. SUCCESS [0.037s]
> [INFO] Ambari Python Shell ... SUCCESS [0.651s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.797s]
> [INFO] ambari-logsearch 

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53338/#review154441
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
 (line 133)


@Transactional?


Minor question on the method's transactionality...

- Jonathan Hurley


On Nov. 1, 2016, 9:30 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53338/
> ---
> 
> (Updated Nov. 1, 2016, 9:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18751
> https://issues.apache.org/jira/browse/AMBARI-18751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install Ambari 2.4.2 (from branch-2.4)
> - Upgrade to Ambari 2.5.0
> 
> The following exception fails the upgrade. It appears as though this is from 
> [a recent 
> commit|https://github.com/apache/ambari/commit/57116b774c62e5ff6ce22de70458e7c01cccdb07]
>  into {{branch-2.4}}: AMBARI-18433
> 
> When the upgrade runs, it assumes that the role authorizations need to be 
> added. In existing 2.4.0 and 2.4.1 installations, this is true. But since 
> this code is now in the 2.4 branch, 2.4.2+ installations will already have 
> the required data seeded.
> 
> ```
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:220) log() - [c3p0] A 
> PooledConnection that has already signalled a Connection error is still in 
> use!
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:223) log() - [c3p0] 
> Another error has occurred [ org.postgresql.util.PSQLException: ERROR: 
> current transaction is aborted, commands ignored until end of transaction 
> block ] which will not be reported to listeners!
> org.postgresql.util.PSQLException: ERROR: current transaction is aborted, 
> commands ignored until end of transaction block
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
>   at 
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeQuery(NewProxyPreparedStatement.java:353)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.wasFailureCommunicationBased(DatabasePlatform.java:2914)
>   at 
> org.eclipse.persistence.platform.server.ServerPlatformBase.wasFailureCommunicationBased(ServerPlatformBase.java:546)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1616)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
>   at 
> org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.acquireWriteLocks(UnitOfWorkImpl.java:1646)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitTransactionAfterWriteChanges(UnitOfWorkImpl.java:1614)
>   at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.commitRootUnitOfWork(RepeatableWriteUnitOfWork.java:285)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitAndResume(UnitOfWorkImpl.java:1169)
>   at 
> org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:134)
>   at 
> 

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53283/#review154437
---


Ship it!




Ship It!

- Robert Levas


On Nov. 1, 2016, 1:33 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53283/
> ---
> 
> (Updated Nov. 1, 2016, 1:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> Robert Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18744
> https://issues.apache.org/jira/browse/AMBARI-18744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store 
> information
> 
> ** 1. Support specfication for credential store information **
> ```xml
> 
> SERVICE_NAME
>   :
> 
> true
> false
> 
>   :
>   :
> 
> ```
> 
> ** 2. REST API GET/PUT for credential store information and GET for stack 
> definition **
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  eb874b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
>  c4881b8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceRequest.java
>  b11d47c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  75f65c0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  13f822e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  0fc65eb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 6f8d306 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 7f83604 
>   ambari-server/src/main/resources/properties.json 34d4641 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
>  f99b5ff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java
>  9986ee3 
> 
> Diff: https://reviews.apache.org/r/53283/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.454s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.046s]
> [INFO] Ambari Web  SUCCESS [1:11.776s]
> [INFO] Ambari Views .. SUCCESS [1.026s]
> [INFO] Ambari Admin View . SUCCESS [6.440s]
> [INFO] utility ... SUCCESS [0.324s]
> [INFO] ambari-metrics  SUCCESS [0.841s]
> [INFO] Ambari Metrics Common . SUCCESS [6.418s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.699s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.202s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.185s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.997s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.428s]
> [INFO] Ambari Metrics Collector .. SUCCESS [8.557s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.103s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.799s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:12.253s]
> [INFO] Ambari Server . SUCCESS [2:27.435s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.044s]
> [INFO] Ambari Agent .. SUCCESS [25.372s]
> [INFO] Ambari Client . SUCCESS [0.060s]
> [INFO] Ambari Python Client .. SUCCESS [1.027s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.933s]
> [INFO] Ambari Shell .. SUCCESS [0.037s]
> [INFO] Ambari Python Shell ... SUCCESS [0.651s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.797s]
> [INFO] ambari-logsearch .. SUCCESS [0.337s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.195s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.085s]
> [INFO] Ambari Logsearch Portal ... SUCCESS 

Re: Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53346/#review154436
---


Ship it!




Ship It!

- Di Li


On Nov. 1, 2016, 6:47 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53346/
> ---
> 
> (Updated Nov. 1, 2016, 6:47 p.m.)
> 
> 
> Review request for Ambari, Di Li and Jayush Luniya.
> 
> 
> Bugs: AMBARI-18765
> https://issues.apache.org/jira/browse/AMBARI-18765
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Description
> 
> For a given service if the theme.json file is not properly formatted, Ambari 
> server will still start 'successfully' but attempts to add that service to 
> the cluster will fail.
> 
> The Ambari server start will log the theme error. Although it neglects to 
> mention which theme file and service are in error.
> 
> When you attempt to add the service, it will query for the service's themes:
> 
> api/v1/stacks//versions//services?StackServices/service_name.in(HDFS,YARN,MAPREDUCE2,ZOOKEEPER,RANGER,RANGER_KMS,SLIDER)/ThemeInfo/default=true=themes/*
> 
> This will return something like the following for the invalid theme:
> 
> "ThemeInfo" :
> { "default" : true, "file_name" : "theme_version_2.json", "service_name" : 
> "RANGER_KMS", "stack_name" : "BigInsights", "stack_version" : "4.3", 
> "theme_data" : null }
> 
> where the theme_data is null.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 650bdf1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  044f2c4 
>   
> ambari-server/src/test/resources/extensions/EXT/0.1/services/OOZIE2/metainfo.xml
>  ab67178 
>   
> ambari-server/src/test/resources/extensions/EXT/0.1/services/OOZIE2/themes/working_theme.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/extensions/EXT/0.2/services/OOZIE2/metainfo.xml
>  9ae4f4b 
>   
> ambari-server/src/test/resources/extensions/EXT/0.2/services/OOZIE2/themes/broken_theme.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53346/diff/
> 
> 
> Testing
> ---
> 
> mvn test -Dtest=StackManagerExtensionTest -DskipPythonTests
> 
> passes without errors
> 
> mvn test
> 
> Failed tests:
>   UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107
>   Unexpected method call 
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
> org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service):
> AmbariManagementController.getClusters(): expected: at least 0, actual: 1
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
> interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service): expected: 1, actual: 0
>   DataStoreImplTest.testFind:526 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:475 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:357 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:426
>   Expectation failure on verify:
> DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
>   AmbariAuthenticationFilterTest.testOnSuccessfulAuthentication:98 » Linkage 
> loa...
> 
> Tests run: 4660, Failures: 5, Errors: 3, Skipped: 34
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/
---

(Updated Nov. 1, 2016, 6:57 p.m.)


Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton.


Changes
---

Hello Nate, Could you please review the updated patch. Thank you


Bugs: AMBARI-18355
https://issues.apache.org/jira/browse/AMBARI-18355


Repository: ambari


Description
---

Currently stack definitions do not list conditional dependencies, adding those 
to the stack definitions would make it easy to validate errors in case of 
blueprint deployment. Please refer to document attached to Jira


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 
e3db662 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 a5f33ff 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
9c1387d 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 ff9af17 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 b1de8ef 

Diff: https://reviews.apache.org/r/51815/diff/


Testing
---

Written Junit test cases. Perfomred manual testing to check the Namenode HA 
component dependency. Was able to proceed with the installation for valid 
blueprint. and got validation error message while registering blueprint when 
the Blueprint did not satisfy the conditional dependencies.


Thanks,

Amruta Borkar

Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53346/
---

Review request for Ambari, Di Li and Jayush Luniya.


Bugs: AMBARI-18765
https://issues.apache.org/jira/browse/AMBARI-18765


Repository: ambari


Description
---

Description

For a given service if the theme.json file is not properly formatted, Ambari 
server will still start 'successfully' but attempts to add that service to the 
cluster will fail.

The Ambari server start will log the theme error. Although it neglects to 
mention which theme file and service are in error.

When you attempt to add the service, it will query for the service's themes:

api/v1/stacks//versions//services?StackServices/service_name.in(HDFS,YARN,MAPREDUCE2,ZOOKEEPER,RANGER,RANGER_KMS,SLIDER)/ThemeInfo/default=true=themes/*

This will return something like the following for the invalid theme:

"ThemeInfo" :
{ "default" : true, "file_name" : "theme_version_2.json", "service_name" : 
"RANGER_KMS", "stack_name" : "BigInsights", "stack_version" : "4.3", 
"theme_data" : null }

where the theme_data is null.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
650bdf1 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
 044f2c4 
  
ambari-server/src/test/resources/extensions/EXT/0.1/services/OOZIE2/metainfo.xml
 ab67178 
  
ambari-server/src/test/resources/extensions/EXT/0.1/services/OOZIE2/themes/working_theme.json
 PRE-CREATION 
  
ambari-server/src/test/resources/extensions/EXT/0.2/services/OOZIE2/metainfo.xml
 9ae4f4b 
  
ambari-server/src/test/resources/extensions/EXT/0.2/services/OOZIE2/themes/broken_theme.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53346/diff/


Testing
---

mvn test -Dtest=StackManagerExtensionTest -DskipPythonTests

passes without errors

mvn test

Failed tests:
  UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107
  Unexpected method call 
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service):
AmbariManagementController.getClusters(): expected: at least 0, actual: 1
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service): expected: 1, actual: 0
  DataStoreImplTest.testFind:526 expected: but was:
  DataStoreImplTest.testRemove:475 expected: but was:
  DataStoreImplTest.testStore_update:357 expected: but was:
  DataStoreImplTest.testStore_update_longStringValue:426
  Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review154434
---


Ship it!




Ship It!

- Robert Levas


On Oct. 21, 2016, 10:38 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 21, 2016, 10:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java 
> 255c5e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  a80cd03 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263.patch_base
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53334/#review154422
---




ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 (line 234)


Is this meant to account for a different Spark version in HDP stack?
If so, we can use stack_features.json and the check_stack_feature function 
to make it more clear why this is the case.


- Alejandro Fernandez


On Nov. 1, 2016, 1:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53334/
> ---
> 
> (Updated Nov. 1, 2016, 1:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18758
> https://issues.apache.org/jira/browse/AMBARI-18758
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 configuration key are changed.
> 
> livy.server.kerberos.keytab  --> livy.server.launch.kerberos.keytab
> livy.server.kerberos.principal  --> livy.server.launch.kerberos.principal
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3a1c482 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53334/diff/
> 
> 
> Testing
> ---
> 
> I have verified it in HDP 2.6. But havn't done for the upgrade.
> 
> @afernandez, do you know how to change the configuration key for upgrade ? I 
> didn't find samples in config-upgrade.xml
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 53340: Ambari Database Check failed to Complete Error

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53340/#review154413
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 1, 2016, 11:26 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53340/
> ---
> 
> (Updated Nov. 1, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Matt, Nate Cole, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18725
> https://issues.apache.org/jira/browse/AMBARI-18725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Built Ambari from branch-2.4, branch-2.5 and trunk. All the builds have the 
> same issue when the start command is run.
> ```
> > ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> No errors were found.
> ERROR: Exiting with exit code 1.
> REASON: Database check failed to complete. Please check 
> /var/log/ambari-server/ambari-server.log and 
> /var/log/ambari-server/ambari-server-check-database.log for more 
> information.{code}
> 
> The database.log says {code}Error preallocating sequence numbers
> ```
> 
> Nothing suspicious on ambari-server.log.
> 
> Log file ambari-server-check-database.log attached with this JIRA for 
> reference.
> 
> 
> *Update*
> Reverting 
> https://github.com/apache/ambari/commit/b632b33bc35afc5a01354e8916fdcdf698e49e19
>  on a local copy of branch-2.4 fixed the issue on branch-2.4 build
> Reverting 
> https://github.com/apache/ambari/commit/49f58e8402b543875c61f8d74a052bd6cd45a788
>  on a local copy of branch-2.5 fixed the issue on branch-2.5 build
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql dd0cce6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 5b9315f 
> 
> Diff: https://reviews.apache.org/r/53340/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 53340: Ambari Database Check failed to Complete Error

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53340/#review154411
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 1, 2016, 3:26 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53340/
> ---
> 
> (Updated Nov. 1, 2016, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Matt, Nate Cole, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18725
> https://issues.apache.org/jira/browse/AMBARI-18725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Built Ambari from branch-2.4, branch-2.5 and trunk. All the builds have the 
> same issue when the start command is run.
> ```
> > ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> No errors were found.
> ERROR: Exiting with exit code 1.
> REASON: Database check failed to complete. Please check 
> /var/log/ambari-server/ambari-server.log and 
> /var/log/ambari-server/ambari-server-check-database.log for more 
> information.{code}
> 
> The database.log says {code}Error preallocating sequence numbers
> ```
> 
> Nothing suspicious on ambari-server.log.
> 
> Log file ambari-server-check-database.log attached with this JIRA for 
> reference.
> 
> 
> *Update*
> Reverting 
> https://github.com/apache/ambari/commit/b632b33bc35afc5a01354e8916fdcdf698e49e19
>  on a local copy of branch-2.4 fixed the issue on branch-2.4 build
> Reverting 
> https://github.com/apache/ambari/commit/49f58e8402b543875c61f8d74a052bd6cd45a788
>  on a local copy of branch-2.5 fixed the issue on branch-2.5 build
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql dd0cce6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 5b9315f 
> 
> Diff: https://reviews.apache.org/r/53340/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 53340: Ambari Database Check failed to Complete Error

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53340/
---

Review request for Ambari, Jonathan Hurley, Matt, Nate Cole, and Robert 
Nettleton.


Bugs: AMBARI-18725
https://issues.apache.org/jira/browse/AMBARI-18725


Repository: ambari


Description
---

Built Ambari from branch-2.4, branch-2.5 and trunk. All the builds have the 
same issue when the start command is run.
```
> ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
Ambari database consistency check started...
No errors were found.
ERROR: Exiting with exit code 1.
REASON: Database check failed to complete. Please check 
/var/log/ambari-server/ambari-server.log and 
/var/log/ambari-server/ambari-server-check-database.log for more 
information.{code}

The database.log says {code}Error preallocating sequence numbers
```

Nothing suspicious on ambari-server.log.

Log file ambari-server-check-database.log attached with this JIRA for reference.


*Update*
Reverting 
https://github.com/apache/ambari/commit/b632b33bc35afc5a01354e8916fdcdf698e49e19
 on a local copy of branch-2.4 fixed the issue on branch-2.4 build
Reverting 
https://github.com/apache/ambari/commit/49f58e8402b543875c61f8d74a052bd6cd45a788
 on a local copy of branch-2.5 fixed the issue on branch-2.5 build


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql dd0cce6 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
5b9315f 

Diff: https://reviews.apache.org/r/53340/diff/


Testing
---

Manually tested.


Thanks,

Robert Levas

Re: Review Request 53273: Not able to change the default port ambari server listens to

[Anita Jebaraj]

> On Oct. 29, 2016, 5:04 p.m., Attila Doroszlai wrote:
> > Nice catch.
> > 
> > Would be nice to use the constants defined in `serverConfiguration` for 
> > default port and property names.
> > 
> > Even nicer: extract the logic for getting the port (including check for 
> > SSL) into a function in `serverConfiguration`.  Similar logic is 
> > implemented in `serverUtils.get_ambari_server_api_base()`.

hi Attilathank you..I have updated the patch based on your comments...can 
you please help in pushing the code?


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review154216
---


On Nov. 1, 2016, 5:39 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 1, 2016, 5:39 a.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 5886561 
>   ambari-server/src/test/python/TestUtils.py 5d32125 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53338/#review154399
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 1, 2016, 1:30 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53338/
> ---
> 
> (Updated Nov. 1, 2016, 1:30 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18751
> https://issues.apache.org/jira/browse/AMBARI-18751
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install Ambari 2.4.2 (from branch-2.4)
> - Upgrade to Ambari 2.5.0
> 
> The following exception fails the upgrade. It appears as though this is from 
> [a recent 
> commit|https://github.com/apache/ambari/commit/57116b774c62e5ff6ce22de70458e7c01cccdb07]
>  into {{branch-2.4}}: AMBARI-18433
> 
> When the upgrade runs, it assumes that the role authorizations need to be 
> added. In existing 2.4.0 and 2.4.1 installations, this is true. But since 
> this code is now in the 2.4 branch, 2.4.2+ installations will already have 
> the required data seeded.
> 
> ```
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:220) log() - [c3p0] A 
> PooledConnection that has already signalled a Connection error is still in 
> use!
> 2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:223) log() - [c3p0] 
> Another error has occurred [ org.postgresql.util.PSQLException: ERROR: 
> current transaction is aborted, commands ignored until end of transaction 
> block ] which will not be reported to listeners!
> org.postgresql.util.PSQLException: ERROR: current transaction is aborted, 
> commands ignored until end of transaction block
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
>   at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
>   at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
>   at 
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeQuery(NewProxyPreparedStatement.java:353)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.wasFailureCommunicationBased(DatabasePlatform.java:2914)
>   at 
> org.eclipse.persistence.platform.server.ServerPlatformBase.wasFailureCommunicationBased(ServerPlatformBase.java:546)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1616)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
>   at 
> org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
>   at 
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
>   at 
> org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.acquireWriteLocks(UnitOfWorkImpl.java:1646)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitTransactionAfterWriteChanges(UnitOfWorkImpl.java:1614)
>   at 
> org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.commitRootUnitOfWork(RepeatableWriteUnitOfWork.java:285)
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitAndResume(UnitOfWorkImpl.java:1169)
>   at 
> org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:134)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:153)
>   at 
> 

Re: Review Request 53337: ambari-server.pid might not be created

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53337/#review154398
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 1, 2016, 11:13 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53337/
> ---
> 
> (Updated Nov. 1, 2016, 11:13 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-18760
> https://issues.apache.org/jira/browse/AMBARI-18760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> /var/run/ambari-server/ambari-server.pid might not be created, but IOError 
> not logged
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/utils.py 5886561 
> 
> Diff: https://reviews.apache.org/r/53337/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53338/
---

(Updated Nov. 1, 2016, 9:30 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-18751
https://issues.apache.org/jira/browse/AMBARI-18751


Repository: ambari


Description (updated)
---

STR:
- Install Ambari 2.4.2 (from branch-2.4)
- Upgrade to Ambari 2.5.0

The following exception fails the upgrade. It appears as though this is from [a 
recent 
commit|https://github.com/apache/ambari/commit/57116b774c62e5ff6ce22de70458e7c01cccdb07]
 into {{branch-2.4}}: AMBARI-18433

When the upgrade runs, it assumes that the role authorizations need to be 
added. In existing 2.4.0 and 2.4.1 installations, this is true. But since this 
code is now in the 2.4 branch, 2.4.2+ installations will already have the 
required data seeded.

```
2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:220) log() - [c3p0] A 
PooledConnection that has already signalled a Connection error is still in use!
2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:223) log() - [c3p0] 
Another error has occurred [ org.postgresql.util.PSQLException: ERROR: current 
transaction is aborted, commands ignored until end of transaction block ] which 
will not be reported to listeners!
org.postgresql.util.PSQLException: ERROR: current transaction is aborted, 
commands ignored until end of transaction block
at 
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
at 
org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
at 
org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
at 
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeQuery(NewProxyPreparedStatement.java:353)
at 
org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.wasFailureCommunicationBased(DatabasePlatform.java:2914)
at 
org.eclipse.persistence.platform.server.ServerPlatformBase.wasFailureCommunicationBased(ServerPlatformBase.java:546)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1616)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
at 
org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.acquireWriteLocks(UnitOfWorkImpl.java:1646)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitTransactionAfterWriteChanges(UnitOfWorkImpl.java:1614)
at 
org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.commitRootUnitOfWork(RepeatableWriteUnitOfWork.java:285)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitAndResume(UnitOfWorkImpl.java:1169)
at 
org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:134)
at 
org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:153)
at 
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at 
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at 
org.apache.ambari.server.orm.dao.PermissionDAO$$EnhancerByGuice$$abe53a1.merge()
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.addAuthorizationToRole(AbstractUpgradeCatalog.java:888)
at 

Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53338/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-18751
https://issues.apache.org/jira/browse/AMBARI-18751


Repository: ambari


Description
---

STR:
- Install Ambari 2.4.2 (from branch-2.4)
- Upgrade to Ambari 2.5.0

The following exception fails the upgrade. It appears as though this is from [a 
recent 
commit|https://github.com/apache/ambari/commit/57116b774c62e5ff6ce22de70458e7c01cccdb07]
 into {{branch-2.4}}: AMBARI-18433

When the upgrade runs, it assumes that the role authorizations need to be 
added. In existing 2.4.0 and 2.4.1 installations, this is true. But since this 
code is now in the 2.4 branch, 2.4.2+ installations will already have the 
required data seeded.

```
2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:220) log() - [c3p0] A 
PooledConnection that has already signalled a Connection error is still in use!
2016-10-31 11:12:01,193 WARN  [main] (Slf4jMLog.java:223) log() - [c3p0] 
Another error has occurred [ org.postgresql.util.PSQLException: ERROR: current 
transaction is aborted, commands ignored until end of transaction block ] which 
will not be reported to listeners!
org.postgresql.util.PSQLException: ERROR: current transaction is aborted, 
commands ignored until end of transaction block
at 
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
at 
org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
at 
org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:417)
at 
org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:302)
at 
com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeQuery(NewProxyPreparedStatement.java:353)
at 
org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.wasFailureCommunicationBased(DatabasePlatform.java:2914)
at 
org.eclipse.persistence.platform.server.ServerPlatformBase.wasFailureCommunicationBased(ServerPlatformBase.java:546)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.processExceptionForCommError(DatabaseAccessor.java:1616)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:900)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeNoSelect(DatabaseAccessor.java:964)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:633)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatch(ParameterizedSQLBatchWritingMechanism.java:149)
at 
org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:134)
at 
org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.writesCompleted(DatabaseAccessor.java:1845)
at 
org.eclipse.persistence.internal.sessions.AbstractSession.writesCompleted(AbstractSession.java:4300)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.writesCompleted(UnitOfWorkImpl.java:5592)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.acquireWriteLocks(UnitOfWorkImpl.java:1646)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitTransactionAfterWriteChanges(UnitOfWorkImpl.java:1614)
at 
org.eclipse.persistence.internal.sessions.RepeatableWriteUnitOfWork.commitRootUnitOfWork(RepeatableWriteUnitOfWork.java:285)
at 
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitAndResume(UnitOfWorkImpl.java:1169)
at 
org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:134)
at 
org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:153)
at 
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at 
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at 
org.apache.ambari.server.orm.dao.PermissionDAO$$EnhancerByGuice$$abe53a1.merge()
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.addAuthorizationToRole(AbstractUpgradeCatalog.java:888)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.addRoleAuthorization(AbstractUpgradeCatalog.java:848)
at 

Re: Review Request 53273: Not able to change the default port ambari server listens to

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review154392
---


Ship it!




Ship It!

- Di Li


On Nov. 1, 2016, 5:39 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 1, 2016, 5:39 a.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 5886561 
>   ambari-server/src/test/python/TestUtils.py 5d32125 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53307/#review154389
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 31, 2016, 9:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53307/
> ---
> 
> (Updated Oct. 31, 2016, 9:19 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18748
> https://issues.apache.org/jira/browse/AMBARI-18748
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1)Install old version regarding env. 
> 2)Make ambari only  upgrade
> 
> Actual result: 
> ambari-server upgrade fell  
> {code}
> 2016-10-28 01:20:19,601 ERROR 
> com.hw.ambari.ui.util.cluster_managers.CommandExecutor.executeCommandSequence():
>  *Command '[ambari-server upgrade --verbose, ]' 
> failed with exitcode 11 ***
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  Result of ambari-server upgrade command:
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  [OUTPUT STREAM]
> Using python  /usr/bin/python
> Upgrading ambari-server
> Updating properties in ambari.properties ...
> WARNING: Original file ambari-env.sh kept
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: No mpack replay logs found. Skipping replaying mpack commands
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Fixing database objects owner
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Ambari Server configured for MySQL. Confirm you have made a backup of the 
> Ambari Server database [y/n] (y)? INFO: Loading properties from 
> /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Upgrading database schema
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: about to run command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -cp 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/mysql-connector-java.jar'
>  org.apache.ambari.server.upgrade.SchemaUpgradeHelper > 
> /var/log/ambari-server/ambari-server.out 2>&1
> INFO: Return code from schema upgrade command, retcode = 1
> Error output from schema upgrade command:
> Exception in thread "main" org.apache.ambari.server.AmbariException: Entity 
> must be managed to call remove: 
> org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try merging 
> the detached and try the remove again.
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:240)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:356)
> Caused by: java.lang.IllegalArgumentException: Entity must be managed to call 
> remove: org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try 
> merging the detached and try the remove again.
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.performRemove(UnitOfWorkImpl.java:3578)
>   at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.remove(EntityManagerImpl.java:574)
>   at 
> org.apache.ambari.server.orm.dao.PrincipalDAO.remove(PrincipalDAO.java:132)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.convertRolePrincipals(UpgradeCatalog242.java:213)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDMLUpdates(UpgradeCatalog242.java:122)
>   at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:908)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237)
>   ... 1 more
> 
> 
> ERROR: Error executing schema upgrade, please check the server logs.
> ERROR: Ambari server upgrade failed. Please look at 
> /var/log/ambari-server/ambari-server.log, for more details.
> ERROR: Exiting 

Re: Review Request 53273: Not able to change the default port ambari server listens to

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review154388
---


Ship it!




Ship It!

- Tim Thorpe


On Nov. 1, 2016, 5:39 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 1, 2016, 5:39 a.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 5886561 
>   ambari-server/src/test/python/TestUtils.py 5d32125 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 53337: ambari-server.pid might not be created

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53337/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-18760
https://issues.apache.org/jira/browse/AMBARI-18760


Repository: ambari


Description
---

/var/run/ambari-server/ambari-server.pid might not be created, but IOError not 
logged


Diffs
-

  ambari-server/src/main/python/ambari_server/utils.py 5886561 

Diff: https://reviews.apache.org/r/53337/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53307/#review154385
---


Ship it!




Ship It!

- Robert Levas


On Oct. 31, 2016, 9:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53307/
> ---
> 
> (Updated Oct. 31, 2016, 9:19 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18748
> https://issues.apache.org/jira/browse/AMBARI-18748
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1)Install old version regarding env. 
> 2)Make ambari only  upgrade
> 
> Actual result: 
> ambari-server upgrade fell  
> {code}
> 2016-10-28 01:20:19,601 ERROR 
> com.hw.ambari.ui.util.cluster_managers.CommandExecutor.executeCommandSequence():
>  *Command '[ambari-server upgrade --verbose, ]' 
> failed with exitcode 11 ***
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  Result of ambari-server upgrade command:
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  [OUTPUT STREAM]
> Using python  /usr/bin/python
> Upgrading ambari-server
> Updating properties in ambari.properties ...
> WARNING: Original file ambari-env.sh kept
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: No mpack replay logs found. Skipping replaying mpack commands
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Fixing database objects owner
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Ambari Server configured for MySQL. Confirm you have made a backup of the 
> Ambari Server database [y/n] (y)? INFO: Loading properties from 
> /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Upgrading database schema
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: about to run command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -cp 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/mysql-connector-java.jar'
>  org.apache.ambari.server.upgrade.SchemaUpgradeHelper > 
> /var/log/ambari-server/ambari-server.out 2>&1
> INFO: Return code from schema upgrade command, retcode = 1
> Error output from schema upgrade command:
> Exception in thread "main" org.apache.ambari.server.AmbariException: Entity 
> must be managed to call remove: 
> org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try merging 
> the detached and try the remove again.
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:240)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:356)
> Caused by: java.lang.IllegalArgumentException: Entity must be managed to call 
> remove: org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try 
> merging the detached and try the remove again.
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.performRemove(UnitOfWorkImpl.java:3578)
>   at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.remove(EntityManagerImpl.java:574)
>   at 
> org.apache.ambari.server.orm.dao.PrincipalDAO.remove(PrincipalDAO.java:132)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.convertRolePrincipals(UpgradeCatalog242.java:213)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDMLUpdates(UpgradeCatalog242.java:122)
>   at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:908)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237)
>   ... 1 more
> 
> 
> ERROR: Error executing schema upgrade, please check the server logs.
> ERROR: Ambari server upgrade failed. Please look at 
> /var/log/ambari-server/ambari-server.log, for more details.
> ERROR: Exiting with 

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53307/#review154381
---


Ship it!




Ship It!

- Dmytro Sen


On Ноя. 1, 2016, 1:19 д.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53307/
> ---
> 
> (Updated Ноя. 1, 2016, 1:19 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18748
> https://issues.apache.org/jira/browse/AMBARI-18748
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1)Install old version regarding env. 
> 2)Make ambari only  upgrade
> 
> Actual result: 
> ambari-server upgrade fell  
> {code}
> 2016-10-28 01:20:19,601 ERROR 
> com.hw.ambari.ui.util.cluster_managers.CommandExecutor.executeCommandSequence():
>  *Command '[ambari-server upgrade --verbose, ]' 
> failed with exitcode 11 ***
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  Result of ambari-server upgrade command:
> 2016-10-28 01:20:19,603 INFO 
> com.hw.ambari.ui.util.cluster_managers.UpgradeClusterManager.upgrade_schema():
>  [OUTPUT STREAM]
> Using python  /usr/bin/python
> Upgrading ambari-server
> Updating properties in ambari.properties ...
> WARNING: Original file ambari-env.sh kept
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: No mpack replay logs found. Skipping replaying mpack commands
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Fixing database objects owner
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Ambari Server configured for MySQL. Confirm you have made a backup of the 
> Ambari Server database [y/n] (y)? INFO: Loading properties from 
> /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Upgrading database schema
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: about to run command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -cp 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/mysql-connector-java.jar'
>  org.apache.ambari.server.upgrade.SchemaUpgradeHelper > 
> /var/log/ambari-server/ambari-server.out 2>&1
> INFO: Return code from schema upgrade command, retcode = 1
> Error output from schema upgrade command:
> Exception in thread "main" org.apache.ambari.server.AmbariException: Entity 
> must be managed to call remove: 
> org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try merging 
> the detached and try the remove again.
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:240)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:356)
> Caused by: java.lang.IllegalArgumentException: Entity must be managed to call 
> remove: org.apache.ambari.server.orm.entities.PrincipalEntity@5e81dbde, try 
> merging the detached and try the remove again.
>   at 
> org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.performRemove(UnitOfWorkImpl.java:3578)
>   at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.remove(EntityManagerImpl.java:574)
>   at 
> org.apache.ambari.server.orm.dao.PrincipalDAO.remove(PrincipalDAO.java:132)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.convertRolePrincipals(UpgradeCatalog242.java:213)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDMLUpdates(UpgradeCatalog242.java:122)
>   at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:908)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237)
>   ... 1 more
> 
> 
> ERROR: Error executing schema upgrade, please check the server logs.
> ERROR: Ambari server upgrade failed. Please look at 
> /var/log/ambari-server/ambari-server.log, for more details.
> ERROR: Exiting with exit