date:20161107


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53496/#review155221
---




ambari-agent/conf/unix/agent-multiplier.py (line 25)


Will remove ()


- Alejandro Fernandez


On Nov. 4, 2016, 6:27 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53496/
> ---
> 
> (Updated Nov. 4, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Myroslav 
> Papirkovskyy, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18735
> https://issues.apache.org/jira/browse/AMBARI-18735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need a method of easily bootstrapping multiple Ambari Agents on a single 
> host.
> For example, a script that will create each agent's home directory, modify 
> its config file with unique hostname and port number, etc.
> The script should also allow starting/stopping all agents on the host, and 
> aggregating the status.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/agent-multiplier.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53496/diff/
> 
> 
> Testing
> ---
> 
> Verified it works locally and on a cloud environment.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review155209
---



Pushed to trunk, commit 3ec7df13485b629bcf08310f3916b6401f827dbe
branch-2.5, commit dce90ea23f916a8ff5275b8667b510541a74bce4

- Alejandro Fernandez


On Oct. 19, 2016, 10:51 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 19, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53502/#review155201
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 7, 2016, 8:26 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53502/
> ---
> 
> (Updated Nov. 7, 2016, 8:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18681
> https://issues.apache.org/jira/browse/AMBARI-18681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18681 Add host structured_out to manual task
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  b999f2f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  78969e4 
> 
> Diff: https://reviews.apache.org/r/53502/diff/
> 
> 
> Testing
> ---
> 
> TBD
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-07 Thread Duc Le


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53502/
---

(Updated Nov. 7, 2016, 8:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Changes
---

Addressed review comments. I still need to set up my box to run tests.


Bugs: AMBARI-18681
https://issues.apache.org/jira/browse/AMBARI-18681


Repository: ambari


Description
---

AMBARI-18681 Add host structured_out to manual task


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 b999f2f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 78969e4 

Diff: https://reviews.apache.org/r/53502/diff/


Testing
---

TBD


Thanks,

Duc Le

Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53506/#review155181
---


Ship it!




Does this need to be tested on CentOS 6? If everything passes, +1

- Alejandro Fernandez


On Nov. 6, 2016, 1:23 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53506/
> ---
> 
> (Updated Nov. 6, 2016, 1:23 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18761
> https://issues.apache.org/jira/browse/AMBARI-18761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I use CentOS 7 as a host OS. When the host check runs, it shows warning. The 
> warning says "The following services should be up: Service ntpd."
> I think "chrony" is a default NTP client and server on CentOS7. So We should 
> check if there are ntpd or chronyd on a host.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 0c0a3b3 
> 
> Diff: https://reviews.apache.org/r/53506/diff/
> 
> 
> Testing
> ---
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12837535/AMBARI-18761.3.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//console
> This message is automatically generated.
> ```
> 
> Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and 
> recheck host.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7

2016-11-07 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53506/#review155179
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 6, 2016, 1:23 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53506/
> ---
> 
> (Updated Nov. 6, 2016, 1:23 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18761
> https://issues.apache.org/jira/browse/AMBARI-18761
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I use CentOS 7 as a host OS. When the host check runs, it shows warning. The 
> warning says "The following services should be up: Service ntpd."
> I think "chrony" is a default NTP client and server on CentOS7. So We should 
> check if there are ntpd or chronyd on a host.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 0c0a3b3 
> 
> Diff: https://reviews.apache.org/r/53506/diff/
> 
> 
> Testing
> ---
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12837535/AMBARI-18761.3.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9154//console
> This message is automatically generated.
> ```
> 
> Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and 
> recheck host.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 53273: Not able to change the default port ambari server listens to


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review155175
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 7, 2016, 6:11 p.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 757c333 
>   ambari-server/src/test/python/TestUtils.py 367b7fe 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 53512: Fix the backend for HAWQ View BETA

2016-11-07 Thread Lav Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53512/#review155174
---


Ship it!




Ship It!

- Lav Jain


On Nov. 5, 2016, 5:34 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53512/
> ---
> 
> (Updated Nov. 5, 2016, 5:34 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-18779
> https://issues.apache.org/jira/browse/AMBARI-18779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the backend for HAWQ View so that the backend is able to query from 
> pg_stat_activity table.
> 
> 
> Diffs
> -
> 
>   contrib/views/hawq/README.md b8b51ba 
>   contrib/views/hawq/pom.xml e49a23b 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/HAWQDataSource.java
>  PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/HAWQViewServlet.java
>  4202eef 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/JsonApiResource.java
>  PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/QueryResource.java
>  PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/QueryResourceProvider.java
>  PRE-CREATION 
>   
> contrib/views/hawq/src/main/java/org/apache/ambari/view/hawq/QueryService.java
>  PRE-CREATION 
>   contrib/views/hawq/src/main/resources/WEB-INF/web.xml e12f314 
>   contrib/views/hawq/src/main/resources/ui/app/adapters/query.js f82c00d 
>   contrib/views/hawq/src/main/resources/ui/app/app.js af4fdc4 
>   contrib/views/hawq/src/main/resources/ui/app/components/query-table.js 
> d28e2f2 
>   contrib/views/hawq/src/main/resources/ui/app/models/query.js 5906c34 
>   contrib/views/hawq/src/main/resources/ui/app/resolver.js b9eabe4 
>   contrib/views/hawq/src/main/resources/ui/app/router.js f058f78 
>   contrib/views/hawq/src/main/resources/ui/app/routes/application.js 4ad870b 
>   contrib/views/hawq/src/main/resources/ui/app/routes/main.js a05324a 
>   contrib/views/hawq/src/main/resources/ui/app/serializers/query.js 9546da4 
>   contrib/views/hawq/src/main/resources/ui/app/styles/app.scss 7470867 
>   contrib/views/hawq/src/main/resources/ui/app/templates/application.hbs 
> 4c831d1 
>   
> contrib/views/hawq/src/main/resources/ui/app/templates/components/query-table.hbs
>  5af548a 
>   contrib/views/hawq/src/main/resources/ui/app/templates/main.hbs 6baba0c 
>   contrib/views/hawq/src/main/resources/ui/app/utils/utils.js 7b02cca 
>   contrib/views/hawq/src/main/resources/ui/bower.json 5bab18f 
>   contrib/views/hawq/src/main/resources/ui/config/environment.js 4c742ef 
>   contrib/views/hawq/src/main/resources/ui/package.json f1b4116 
>   
> contrib/views/hawq/src/main/resources/ui/tests/acceptance/application-test.js 
> c7ce7c7 
>   
> contrib/views/hawq/src/main/resources/ui/tests/helpers/module-for-acceptance.js
>  3efeee7 
>   contrib/views/hawq/src/main/resources/ui/tests/helpers/test-helper.js 
> 8c70dbc 
>   
> contrib/views/hawq/src/main/resources/ui/tests/integration/components/query-table-test.js
>  e02f8fd 
>   contrib/views/hawq/src/main/resources/ui/tests/test-helper.js 96975ee 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/adapters/query-test.js 
> bab0260 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/models/query-test.js 
> b83130e 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/routes/main-test.js 
> 7ad0b79 
>   
> contrib/views/hawq/src/main/resources/ui/tests/unit/serializers/query-test.js 
> 6cd5f88 
>   contrib/views/hawq/src/main/resources/ui/tests/unit/utils/utils-test.js 
> 969ee6d 
>   contrib/views/hawq/src/main/resources/view.log4j.properties PRE-CREATION 
>   contrib/views/hawq/src/main/resources/view.xml 1421c27 
>   
> contrib/views/hawq/src/test/java/org/apache/ambari/view/hawq/HAWQDataSourceTest.java
>  PRE-CREATION 
>   
> contrib/views/hawq/src/test/java/org/apache/ambari/view/hawq/QueryResourceProviderTest.java
>  PRE-CREATION 
>   contrib/views/pom.xml 39560b5 
> 
> Diff: https://reviews.apache.org/r/53512/diff/
> 
> 
> Testing
> ---
> 
> Added tests on backend and updated tests on frontend.
> Tested on live cluster.
> 
> Hadoop QA passed: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/9153//testReport/
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-07 Thread Anita Jebaraj



> On Nov. 7, 2016, 5:29 p.m., Di Li wrote:
> > hello Anita, AMBARI-18741-Nov2.patch does not apply to trunk, can you 
> > please rebase and provide a new patch ?

Hi Di, I have rebased the patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review155164
---


On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 7, 2016, 6:11 p.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 757c333 
>   ambari-server/src/test/python/TestUtils.py 367b7fe 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-07 Thread Anita Jebaraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/
---

(Updated Nov. 7, 2016, 6:11 p.m.)


Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.


Bugs: AMBARI-18741
https://issues.apache.org/jira/browse/AMBARI-18741


Repository: ambari


Description
---

After including client.api.port in ambari.properties, ambari-server still tries 
to connect to port 8080

The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
defined in ambari.properties then the value should be taken as the port number.

https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
  ambari-server/src/main/python/ambari_server/utils.py 757c333 
  ambari-server/src/test/python/TestUtils.py 367b7fe 

Diff: https://reviews.apache.org/r/53273/diff/


Testing
---

Performed manual testing.


Thanks,

Anita Jebaraj

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-07 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review155164
---



hello Anita, AMBARI-18741-Nov2.patch does not apply to trunk, can you please 
rebase and provide a new patch ?

- Di Li


On Nov. 2, 2016, 6:31 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53273/
> ---
> 
> (Updated Nov. 2, 2016, 6:31 p.m.)
> 
> 
> Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18741
> https://issues.apache.org/jira/browse/AMBARI-18741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After including client.api.port in ambari.properties, ambari-server still 
> tries to connect to port 8080
> 
> The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is 
> defined in ambari.properties then the value should be taken as the port 
> number.
> 
> https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc 
>   ambari-server/src/main/python/ambari_server/utils.py 348d5df 
>   ambari-server/src/test/python/TestUtils.py 5d32125 
> 
> Diff: https://reviews.apache.org/r/53273/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 53544: Deployment failing at creating principal

2016-11-07 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53544/#review155162
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 (line 473)


Can we log an INFO or WARNING message when retying?


- Robert Levas


On Nov. 7, 2016, 11:48 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53544/
> ---
> 
> (Updated Nov. 7, 2016, 11:48 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> 
> 
> 2016-10-31 20:23:01,076 - Failed to create principal, 
> kafka/nat-r7-bwqs-hsihiveserver2-12-4.openstacklo...@example.com - Unexpected 
> error condition executing the kadmin command
> 
> 
> This looks like intermittent issue since not all jobs hit it.
> 
> Here is a live cluster: 
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 52b4744 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  86c26c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  7e915fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  6fd30ee 
> 
> Diff: https://reviews.apache.org/r/53544/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53544: Deployment failing at creating principal

2016-11-07 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53544/#review155160
---

Fix it, then Ship it!

Ship It!

ambari-server/docs/configuration/index.md (line 76)

This is an incorrect or confusing property name. The `authentication.*` 
properties control aspects of the authentication mechanism into Ambari.  In 
this case we are creating a property to control behavior when creating Kerberos 
identities for the cluster, so the name of the propery seems confusing to me.  

How about something like `kerberos.kadmin.call.retries` or maybe something 
more generic like `kerberos.operation.retries` which might cover other 
operations like access to Active Directory's LDAP interface or some FreeIPA 
call. 

The `kerberos.*` properties (for example, `kerberos.keytab.cache.dir`) seem 
to be more related to processing tasks needed when creating Kerberos identities.

ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (lines 1392 - 1393)

This is an incorrect or confusing property name. The `authentication.*` 
properties control aspects of the authentication mechanism into Ambari.  In 
this case we are creating a property to control behavior when creating Kerberos 
identities for the cluster, so the name of the propery seems confusing to me.  

How about something like `kerberos.kadmin.call.retries` or maybe something 
more generic like `kerberos.operation.retries` which might cover other 
operations like access to Active Directory's LDAP interface or some FreeIPA 
call. 

The `kerberos.*` properties (for example, `kerberos.keytab.cache.dir`) seem 
to be more related to processing tasks needed when creating Kerberos identities.

- Robert Levas

On Nov. 7, 2016, 11:48 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53544/
> ---
> 
> (Updated Nov. 7, 2016, 11:48 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> 
> 
> 2016-10-31 20:23:01,076 - Failed to create principal, 
> kafka/nat-r7-bwqs-hsihiveserver2-12-4.openstacklo...@example.com - Unexpected 
> error condition executing the kadmin command
> 
> 
> This looks like intermittent issue since not all jobs hit it.
> 
> Here is a live cluster: 
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 52b4744 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  86c26c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  7e915fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  6fd30ee 
> 
> Diff: https://reviews.apache.org/r/53544/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 53544: Deployment failing at creating principal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53544/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755


Repository: ambari


Description
---

Cluster deployment via blueprint failed at creating principals




2016-10-31 20:23:01,076 - Failed to create principal, 
kafka/nat-r7-bwqs-hsihiveserver2-12-4.openstacklo...@example.com - Unexpected 
error condition executing the kadmin command


This looks like intermittent issue since not all jobs hit it.

Here is a live cluster: 


Diffs
-

  ambari-server/docs/configuration/index.md 52b4744 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 86c26c8 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 7e915fc 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
 6fd30ee 

Diff: https://reviews.apache.org/r/53544/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-07 Thread Robert Levas



> On Nov. 1, 2016, 2:46 p.m., Robert Levas wrote:
> > Ship It!
> 
> Vishal Ghugare wrote:
> Thank you Robert! I would really appreciate if you can commit these 
> changes on my behalf to trunk ( I am not a committer).The latest patch is 
> attached to AMBARI-12263. Thanks again.

I assume that the latest patch is the one that was reviewed here correct?  
If so, I can just download from this review.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review154434
---


On Oct. 21, 2016, 10:38 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 21, 2016, 10:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java 
> 255c5e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  a80cd03 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263.patch_base
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base
>

Re: Review Request 53504: Manage Ambari principals should be set to off when upgrading Ambari from versions < 2.4.0

2016-11-07 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53504/#review155147
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 4, 2016, 10:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53504/
> ---
> 
> (Updated Nov. 4, 2016, 10:56 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18804
> https://issues.apache.org/jira/browse/AMBARI-18804
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since users would have manually set up the Ambari principal after enabling 
> Kerberos using `ambari-server setup-security` `option #3` ("Setup Ambari 
> kerberos JAAS configuration") in Ambari versions before 2.4.0, there is no 
> need to configure Ambari to automatically manage its principals after an 
> upgrade to version 2.4.0 and above. 
> 
> Therefore, upon upgrade to Ambari 2.4.0 or above, the upgrade process (in 
> `UpgradeCatalog240`) should ensure that 
> `kerberos-env/create_ambari_principal` is set to "false".  By default this 
> value will be set to "true" after 
> `org.apache.ambari.server.upgrade.AbstractUpgradeCatalog#addNewConfigurationsFromXml`
>  is executed. 
> 
> Note: This may have an effect on Ambari versions 2.4.2 and above if Kerberos 
> authentication is enabled and the SPNEGO (`HTTP/_HOST`) principal and keytab 
> file is already created and installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  54afd8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  958758f 
> 
> Diff: https://reviews.apache.org/r/53504/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade from 2.2.2.
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:11:23.488s
> [INFO] Finished at: Fri Nov 04 18:28:36 EDT 2016
> [INFO] Final Memory: 61M/1909M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53502/#review155145
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 (lines 176 - 177)


Agreed - let's use JSON here to avoid syntax issues which can only be found 
at runtime.


- Jonathan Hurley


On Nov. 4, 2016, 6:51 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53502/
> ---
> 
> (Updated Nov. 4, 2016, 6:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18681
> https://issues.apache.org/jira/browse/AMBARI-18681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18681 Add host structured_out to manual task
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  b999f2f 
> 
> Diff: https://reviews.apache.org/r/53502/diff/
> 
> 
> Testing
> ---
> 
> TBD
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 53504: Manage Ambari principals should be set to off when upgrading Ambari from versions < 2.4.0

2016-11-07 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53504/#review155144
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 4, 2016, 6:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53504/
> ---
> 
> (Updated Nov. 4, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18804
> https://issues.apache.org/jira/browse/AMBARI-18804
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since users would have manually set up the Ambari principal after enabling 
> Kerberos using `ambari-server setup-security` `option #3` ("Setup Ambari 
> kerberos JAAS configuration") in Ambari versions before 2.4.0, there is no 
> need to configure Ambari to automatically manage its principals after an 
> upgrade to version 2.4.0 and above. 
> 
> Therefore, upon upgrade to Ambari 2.4.0 or above, the upgrade process (in 
> `UpgradeCatalog240`) should ensure that 
> `kerberos-env/create_ambari_principal` is set to "false".  By default this 
> value will be set to "true" after 
> `org.apache.ambari.server.upgrade.AbstractUpgradeCatalog#addNewConfigurationsFromXml`
>  is executed. 
> 
> Note: This may have an effect on Ambari versions 2.4.2 and above if Kerberos 
> authentication is enabled and the SPNEGO (`HTTP/_HOST`) principal and keytab 
> file is already created and installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  54afd8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  958758f 
> 
> Diff: https://reviews.apache.org/r/53504/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade from 2.2.2.
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:11:23.488s
> [INFO] Finished at: Fri Nov 04 18:28:36 EDT 2016
> [INFO] Final Memory: 61M/1909M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 53504: Manage Ambari principals should be set to off when upgrading Ambari from versions < 2.4.0

2016-11-07 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53504/#review155139
---


Ship it!




Ship It!

- Nate Cole


On Nov. 4, 2016, 6:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53504/
> ---
> 
> (Updated Nov. 4, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18804
> https://issues.apache.org/jira/browse/AMBARI-18804
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since users would have manually set up the Ambari principal after enabling 
> Kerberos using `ambari-server setup-security` `option #3` ("Setup Ambari 
> kerberos JAAS configuration") in Ambari versions before 2.4.0, there is no 
> need to configure Ambari to automatically manage its principals after an 
> upgrade to version 2.4.0 and above. 
> 
> Therefore, upon upgrade to Ambari 2.4.0 or above, the upgrade process (in 
> `UpgradeCatalog240`) should ensure that 
> `kerberos-env/create_ambari_principal` is set to "false".  By default this 
> value will be set to "true" after 
> `org.apache.ambari.server.upgrade.AbstractUpgradeCatalog#addNewConfigurationsFromXml`
>  is executed. 
> 
> Note: This may have an effect on Ambari versions 2.4.2 and above if Kerberos 
> authentication is enabled and the SPNEGO (`HTTP/_HOST`) principal and keytab 
> file is already created and installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  54afd8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  958758f 
> 
> Diff: https://reviews.apache.org/r/53504/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade from 2.2.2.
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:11:23.488s
> [INFO] Finished at: Fri Nov 04 18:28:36 EDT 2016
> [INFO] Final Memory: 61M/1909M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-07 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53502/#review155137
---




ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 (lines 176 - 177)


Could also create a proper Json Object that you set attributes on, but this 
will work as well.

Please also add a test to make sure that the manual task indeed has the 
expected output.  Likely in UpgradeHelperTest.testHostGroupingOrchestration()


- Nate Cole


On Nov. 4, 2016, 6:51 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53502/
> ---
> 
> (Updated Nov. 4, 2016, 6:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18681
> https://issues.apache.org/jira/browse/AMBARI-18681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18681 Add host structured_out to manual task
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  b999f2f 
> 
> Diff: https://reviews.apache.org/r/53502/diff/
> 
> 
> Testing
> ---
> 
> TBD
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

2016-11-07 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50561/
---

(Updated Nov. 7, 2016, 2:44 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

uploaded new patch with minor change to make it work with current ambari version


Bugs: AMBARI-17943
https://issues.apache.org/jira/browse/AMBARI-17943


Repository: ambari


Description
---

removed the linefeed and carriage return and improved UX


Diffs (updated)
-

  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 061a445 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 d84dc4d 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 061a445 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 d84dc4d 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java
 2c890f5 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java
 be5733f 

Diff: https://reviews.apache.org/r/50561/diff/


Testing
---

manual testing done


Thanks,

Nitiraj Rathore

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

2016-11-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/#review155132
---


Ship it!




Ship It!

- Sebastian Toader


On Nov. 7, 2016, 2:54 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53477/
> ---
> 
> (Updated Nov. 7, 2016, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18479 and AMBARI-18770
> https://issues.apache.org/jira/browse/AMBARI-18479
> https://issues.apache.org/jira/browse/AMBARI-18770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is 
> configured. The issue is curl is configured to follow redirects, but not send 
> the initial requests credentials to the redirected location. 
> 
> From curl manual:
> (HTTP/HTTPS)  If the server reports that the requested page has moved to a 
> different location (indicated with a Location: header and a 3XX response 
> code), this 
>   option will make curl redo the request on the new place. If 
> used together with -i, --include or -I, --head, headers from all requested  
> pages  will  be  shown. 
>   When  authentication  is used, curl only sends its credentials 
> to the initial host. If a redirect takes curl to a different host, it won't 
> be able to intercept 
>   the user+password. See also --location-trusted on how to change 
> this. 
> 
> In the patch a changed the -L switch to --location-trusted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  2acf871 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  daa8e7e 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/WEBHCAT/package/files/alert_webhcat_server.py
>  7ee375e 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py 
> ccd472c 
> 
> Diff: https://reviews.apache.org/r/53477/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> 1. Installed Ambari from RPM
> 2. Added the following services: HDFS, YARN, MapReduce2, ZooKeeper
> 3. Enabled kerberos
> 4. Enabled YARN HA
> 5. Enabled SPNEGO Authentication
> 6. Ran service check on YARN and checked alert statuses
> 
> Tests in ambari project ran clean.
> 
> Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
> Ran 442 tests in 102.060s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.



> On Nov. 7, 2016, 11:04 a.m., Attila Doroszlai wrote:
> > `ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/WEBHCAT/package/files/alert_webhcat_server.py`
> >  also contains `curl -L`.  Can you please check if that one needs to be 
> > changed, too?

I changed it.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/#review155120
---


On Nov. 7, 2016, 1:54 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53477/
> ---
> 
> (Updated Nov. 7, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18479 and AMBARI-18770
> https://issues.apache.org/jira/browse/AMBARI-18479
> https://issues.apache.org/jira/browse/AMBARI-18770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is 
> configured. The issue is curl is configured to follow redirects, but not send 
> the initial requests credentials to the redirected location. 
> 
> From curl manual:
> (HTTP/HTTPS)  If the server reports that the requested page has moved to a 
> different location (indicated with a Location: header and a 3XX response 
> code), this 
>   option will make curl redo the request on the new place. If 
> used together with -i, --include or -I, --head, headers from all requested  
> pages  will  be  shown. 
>   When  authentication  is used, curl only sends its credentials 
> to the initial host. If a redirect takes curl to a different host, it won't 
> be able to intercept 
>   the user+password. See also --location-trusted on how to change 
> this. 
> 
> In the patch a changed the -L switch to --location-trusted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  2acf871 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  daa8e7e 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/WEBHCAT/package/files/alert_webhcat_server.py
>  7ee375e 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py 
> ccd472c 
> 
> Diff: https://reviews.apache.org/r/53477/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> 1. Installed Ambari from RPM
> 2. Added the following services: HDFS, YARN, MapReduce2, ZooKeeper
> 3. Enabled kerberos
> 4. Enabled YARN HA
> 5. Enabled SPNEGO Authentication
> 6. Ran service check on YARN and checked alert statuses
> 
> Tests in ambari project ran clean.
> 
> Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
> Ran 442 tests in 102.060s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/
---

(Updated Nov. 7, 2016, 1:54 p.m.)

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, and Sebastian
Toader.

Bugs: AMBARI-18479 and AMBARI-18770
https://issues.apache.org/jira/browse/AMBARI-18479
https://issues.apache.org/jira/browse/AMBARI-18770

Repository: ambari

Description
---

YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is
configured. The issue is curl is configured to follow redirects, but not send
the initial requests credentials to the redirected location.

>From curl manual:
(HTTP/HTTPS) If the server reports that the requested page has moved to a
different location (indicated with a Location: header and a 3XX response code),
this
option will make curl redo the request on the new place. If used
together with -i, --include or -I, --head, headers from all requested pages
will be shown.
When authentication is used, curl only sends its credentials to
the initial host. If a redirect takes curl to a different host, it won't be
able to intercept
the user+password. See also --location-trusted on how to change
this.

In the patch a changed the -L switch to --location-trusted

Diffs (updated)
-

ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
2acf871

ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
daa8e7e

ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/WEBHCAT/package/files/alert_webhcat_server.py
7ee375e
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py
ccd472c

Diff: https://reviews.apache.org/r/53477/diff/

Testing
---

Manual testing.
1. Installed Ambari from RPM
2. Added the following services: HDFS, YARN, MapReduce2, ZooKeeper
3. Enabled kerberos
4. Enabled YARN HA
5. Enabled SPNEGO Authentication
6. Ran service check on YARN and checked alert statuses

Tests in ambari project ran clean.

Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
Ran 442 tests in 102.060s

Thanks,

Attila Magyar

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/
---

(Updated Nov. 7, 2016, 1:36 p.m.)

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, and Sebastian
Toader.

Changes
---

added unittest to service_check.py

Bugs: AMBARI-18479 and AMBARI-18770
https://issues.apache.org/jira/browse/AMBARI-18479
https://issues.apache.org/jira/browse/AMBARI-18770

Repository: ambari

Description
---

In the patch a changed the -L switch to --location-trusted

Diffs (updated)
-

ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
2acf871

ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
daa8e7e
ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py
ccd472c

Diff: https://reviews.apache.org/r/53477/diff/

Testing
---

Tests in ambari project ran clean.

Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
Ran 442 tests in 102.060s

Thanks,

Attila Magyar

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

2016-11-07 Thread Gautam Borad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53129/#review155122
---


Ship it!




Ship It!

- Gautam Borad


On Oct. 26, 2016, 10:53 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53129/
> ---
> 
> (Updated Oct. 26, 2016, 10:53 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18671
> https://issues.apache.org/jira/browse/AMBARI-18671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add below properties under kms-site.xml having value as '*', if YARN|SPARK 
> services are installed
> 
> - hadoop.kms.proxyuser.[livy|yarn].groups
> - hadoop.kms.proxyuser.[livy|yarn].hosts
> - hadoop.kms.proxyuser.[livy|yarn].users
> 
> Also with above changes need to revert changes done for AMBARI-18096
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 24b9f6e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 986ca69 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> cd69dc3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 72e59aa 
> 
> Diff: https://reviews.apache.org/r/53129/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Kms installation with Yarn|Spark on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

2016-11-07 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/#review155120
---


Ship it!




`ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/WEBHCAT/package/files/alert_webhcat_server.py`
 also contains `curl -L`.  Can you please check if that one needs to be 
changed, too?

- Attila Doroszlai


On Nov. 7, 2016, 9:22 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53477/
> ---
> 
> (Updated Nov. 7, 2016, 9:22 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18479 and AMBARI-18770
> https://issues.apache.org/jira/browse/AMBARI-18479
> https://issues.apache.org/jira/browse/AMBARI-18770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is 
> configured. The issue is curl is configured to follow redirects, but not send 
> the initial requests credentials to the redirected location. 
> 
> From curl manual:
> (HTTP/HTTPS)  If the server reports that the requested page has moved to a 
> different location (indicated with a Location: header and a 3XX response 
> code), this 
>   option will make curl redo the request on the new place. If 
> used together with -i, --include or -I, --head, headers from all requested  
> pages  will  be  shown. 
>   When  authentication  is used, curl only sends its credentials 
> to the initial host. If a redirect takes curl to a different host, it won't 
> be able to intercept 
>   the user+password. See also --location-trusted on how to change 
> this. 
> 
> In the patch a changed the -L switch to --location-trusted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  2acf871 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  daa8e7e 
> 
> Diff: https://reviews.apache.org/r/53477/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> 1. Installed Ambari from RPM
> 2. Added the following services: HDFS, YARN, MapReduce2, ZooKeeper
> 3. Enabled kerberos
> 4. Enabled YARN HA
> 5. Enabled SPNEGO Authentication
> 6. Ran service check on YARN and checked alert statuses
> 
> Tests in ambari project ran clean.
> 
> Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
> Ran 442 tests in 102.060s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 53523: Ambari-agent user home directory permissions changed to accumulo:accumulo in non-root

2016-11-07 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53523/#review155118
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 7, 2016, 10:01 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53523/
> ---
> 
> (Updated Лис. 7, 2016, 10:01 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18807
> https://issues.apache.org/jira/browse/AMBARI-18807
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This reproduces only if accumulo service is present.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
> 
> Diff: https://reviews.apache.org/r/53523/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 53523: Ambari-agent user home directory permissions changed to accumulo:accumulo in non-root


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53523/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18807
https://issues.apache.org/jira/browse/AMBARI-18807


Repository: ambari


Description
---

This reproduces only if accumulo service is present.


Diffs
-

  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
 33d3273 

Diff: https://reviews.apache.org/r/53523/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 53480: Add a cluster version directly as INSTALLED

2016-11-07 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53480/#review155116
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 4, 2016, 9:23 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53480/
> ---
> 
> (Updated Nov. 4, 2016, 9:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-18708
> https://issues.apache.org/jira/browse/AMBARI-18708
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When creating a repository for a cluster, allow the API to set directly to 
> INSTALLED.  This is the case where bits are known to be preinstalled.
> 
> This API call will set direct values for {{cluster_version}} and 
> {{host_version}}.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  4e9fd6b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> b1958ef 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> bd6cc0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  bb46c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 513d924 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  9837b0f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  dcbc435 
> 
> Diff: https://reviews.apache.org/r/53480/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 34:29 min
> [INFO] Finished at: 2016-11-04T15:20:02-04:00
> [INFO] Final Memory: 45M/687M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-11-07 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/#review155115
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 7, 2016, 11:40 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52420/
> ---
> 
> (Updated Nov. 7, 2016, 11:40 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18505
> https://issues.apache.org/jira/browse/AMBARI-18505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SmartSense status command does an http call without timeout in 1.2 version of
> SS.
> 
> Ambari agent queues STATUS commands until we end up with HB lost state with
> ton of commands queued up.
> 
> This should just never happen is commands are getting queued by by the agent
> every HB.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> 655b2fc 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/main.py a5edfe3 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 59b41cd 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 01028ec 
> 
> Diff: https://reviews.apache.org/r/52420/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/#review155114
---




ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py (line 91)


The fix for the recent. HB lost issue.


- Andrew Onischuk


On Nov. 7, 2016, 9:40 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52420/
> ---
> 
> (Updated Nov. 7, 2016, 9:40 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18505
> https://issues.apache.org/jira/browse/AMBARI-18505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SmartSense status command does an http call without timeout in 1.2 version of
> SS.
> 
> Ambari agent queues STATUS commands until we end up with HB lost state with
> ton of commands queued up.
> 
> This should just never happen is commands are getting queued by by the agent
> every HB.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> 655b2fc 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 
> PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/main.py a5edfe3 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 59b41cd 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 01028ec 
> 
> Diff: https://reviews.apache.org/r/52420/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/
---

(Updated Nov. 7, 2016, 9:40 a.m.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18505
https://issues.apache.org/jira/browse/AMBARI-18505


Repository: ambari


Description
---

SmartSense status command does an http call without timeout in 1.2 version of
SS.

Ambari agent queues STATUS commands until we end up with HB lost state with
ton of commands queued up.

This should just never happen is commands are getting queued by by the agent
every HB.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 914e09a 
  ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
  ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 
  ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 655b2fc 
  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/main.py a5edfe3 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
  ambari-agent/src/test/python/ambari_agent/TestController.py 59b41cd 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 01028ec 

Diff: https://reviews.apache.org/r/52420/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52958: Fix Log Search User Config bug


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52958/
---

(Updated Nov. 7, 2016, 9:25 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18616
https://issues.apache.org/jira/browse/AMBARI-18616


Repository: ambari


Description
---

Log Search User Config UI screen does not offer the chance to modify the filter 
settings for those logs which don't have any log entries loaded so far. For 
these logs the initial settings will be in effect until the first modification 
of the filters when all of these settings will be erased, and thus every log 
will be loaded for them without filtering.

The User Config UI should always show all the logs, first those which already 
have some log entries in the solr, then the rest.

Also some minor refactoring for cleaner code.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/HadoopServiceConfigHelper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 58337f7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 45d66cf 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 d276769 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java
 b09610c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/filter/CreateLogfeederFilterView.js
 9bdf0fa 

Diff: https://reviews.apache.org/r/52958/diff/


Testing
---

Done


Thanks,

Miklos Gergely

Re: Review Request 52528: Custom logsearch property should override default value



> On Oct. 10, 2016, 9:09 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java,
> >  line 91
> > 
> >
> > Minor question (and I won't raise an issue about this):
> > 
> > Why is the final modifier removed here?  Is there a specific reason for 
> > this?

Is there a specific reason to have it there? All through this project the final 
modifier is only used for a method argument if the argument is referenced in an 
anonymus classes. So I'm removing it for consistency reasons.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52528/#review152064
---


On Nov. 7, 2016, 9:21 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52528/
> ---
> 
> (Updated Nov. 7, 2016, 9:21 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18529
> https://issues.apache.org/jira/browse/AMBARI-18529
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Custom properties are now overriding default proplerties, not the other way
> Also removed some unused code, and made UserDao more reasonable
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
>  0810571 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
>  eb6c9f1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
>  92a7aaa 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  e55653f 
> 
> Diff: https://reviews.apache.org/r/52528/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 52528: Custom logsearch property should override default value


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52528/
---

(Updated Nov. 7, 2016, 9:21 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18529
https://issues.apache.org/jira/browse/AMBARI-18529


Repository: ambari


Description
---

Custom properties are now overriding default proplerties, not the other way
Also removed some unused code, and made UserDao more reasonable


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
 0810571 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
 eb6c9f1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
 92a7aaa 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 e55653f 

Diff: https://reviews.apache.org/r/52528/diff/


Testing
---

done.


Thanks,

Miklos Gergely

Re: Review Request 51583: Add ability to add custom grok filters and custom grok patterns with Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51583/
---

(Updated Nov. 7, 2016, 9:20 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18298
https://issues.apache.org/jira/browse/AMBARI-18298


Repository: ambari


Description
---

Allow the operators to view the logsearch grok patterns and add new patterns to 
them


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-grok.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
 81e17d8 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
e0280b4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 63bc21f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 688a9b0 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 49aa357 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-default_grok_patterns.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 7f9acba 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 1ebbda9 
  ambari-web/app/data/HDP2/site_properties.js fac40c4 

Diff: https://reviews.apache.org/r/51583/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 52467: Use logsearch truststore to look for credential in case of external authentication


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52467/
---

(Updated Nov. 7, 2016, 9:19 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18510
https://issues.apache.org/jira/browse/AMBARI-18510


Repository: ambari


Description
---

Logsearch looks for credentials also in it's own trust store, not only in 
cacarts in case of external authentication

Other changes:
- authentication cleanup
- authentication unit tests added
- trust store and key store handling moved to it's own class (SSLUtil)
- docker test environment can be configured to use SSL for solr, and https for 
logsearch portal
- also removed non-existent LogProcessor.jar from the classpath of Log Search 
and Log Feeder


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dfc7b7b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 75d8be3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 c476b9d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 1844d8f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
 eab33a1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
 d37e545 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 7e146ac 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
 51b3547 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
 400361b 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 4e8901d 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
 fa3efb8 
  ambari-logsearch/docker/.gitignore 0d6af58 
  ambari-logsearch/docker/Dockerfile a09f235 
  ambari-logsearch/docker/bin/start.sh a09e4b2 
  ambari-logsearch/docker/logsearch-docker.sh 022b1ba 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh e69b1db 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2ad7055 
  ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh 92fa354 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
 d1c1ef9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
 501603a 

Diff: https://reviews.apache.org/r/52467/diff/


Testing
---

Tested in docker envrionment.


Thanks,

Miklos Gergely

Re: Review Request 51197: Zeppelin logsearch configuration typo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51197/
---

(Updated Nov. 7, 2016, 9:18 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18193
https://issues.apache.org/jira/browse/AMBARI-18193


Repository: ambari


Description
---

an s was missing


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 cb7b79f 

Diff: https://reviews.apache.org/r/51197/diff/


Testing
---


Thanks,

Miklos Gergely

Re: Review Request 51844: Audit logs should not be filtered by Log Feeder


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51844/
---

(Updated Nov. 7, 2016, 9:17 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18372
https://issues.apache.org/jira/browse/AMBARI-18372


Repository: ambari


Description
---

LogFeeder shouldn't filter audit logs.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 801a289 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 2c81c19 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
 02ffd47 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
 e103346 

Diff: https://reviews.apache.org/r/51844/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 51748: Ranger audit log collection is not used in Log Search (managed by ambari)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51748/
---

(Updated Nov. 7, 2016, 9:16 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18348
https://issues.apache.org/jira/browse/AMBARI-18348


Repository: ambari


Description
---

Audit log collection and ranger audit log collection are 2 different collection 
with almost the same schema. With solr alias support, we can use both.
Also use ambari audit logs inside audit collection, not in service log 
collection


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 c9c3f2c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterKeyValueTest.java
 30cee42 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 e521c8e 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 8b0ce75 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 8d84093 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
 34f4b30 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 8ac6fa7 
  ambari-web/app/data/HDP2/site_properties.js 9311e75 

Diff: https://reviews.apache.org/r/51748/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 51570: Enable log search for NIFI_CA component


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51570/
---

(Updated Nov. 7, 2016, 9:15 a.m.)


Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18293
https://issues.apache.org/jira/browse/AMBARI-18293


Repository: ambari


Description
---

Add NIFI_CA log to logsearch


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
 9ce3fde 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 99f1740 

Diff: https://reviews.apache.org/r/51570/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 51537: Use the PropertiesFile python command to create property files instead of jinja templates


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51537/
---

(Updated Nov. 7, 2016, 9:14 a.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, Robert 
Nettleton, and Sumit Mohanty.


Changes
---

fix branches


Bugs: AMBARI-18279
https://issues.apache.org/jira/browse/AMBARI-18279


Repository: ambari


Description
---

Instead of using jinja templates use the PropetiesFile command in 
resource_management.libraries.resources.properties_file to generate the 
property files, thus prevent enumerating all the non-custom properties in 
params.py

Also fixed a bug: the default values for the audit logs solr znodes and quorum 
were mixed up.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 56ff2d1 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5c3954f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 d3851d3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 aa89609 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 86f0be4 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 1bcee2d 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py f4dbd63 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 5a2e6e8 
  ambari-server/src/test/python/stacks/2.4/configs/default.json a016ce0 
  ambari-web/app/data/HDP2/site_properties.js 1fad1d6 

Diff: https://reviews.apache.org/r/51537/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 51354: Clean up Log Feeder


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51354/
---

(Updated Nov. 7, 2016, 9:13 a.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

fix branches


Bugs: AMBARI-18246
https://issues.apache.org/jira/browse/AMBARI-18246


Repository: ambari


Description
---

- long methods were broken up to smaller independent parts
- narrowed the scope of too widely defined variables
- fixed visibilities of the methods/fields
- converted constants / enums to use java conventions for names
- maximum line length is 120 characters, fixed unnecessary short lines
- rearranged the functions so that they follow the order of the lifecycle of 
these components
- refactored some overcomplicated parts
- removed unused codes


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 373d743 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
 287982f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 ab371f1 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 372c208 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 2954106 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 7adb468 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 5feb9c4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 c9f5ded 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java
 48a7f1d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
 b18c9b0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
 c9d28bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 5ba56a5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
 a2a9db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java
 c57c028 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 ae0cfc0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java
 09673a0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogfeederScheduler.java
 bc807193 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
 b5e4eb3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
 04d2ca4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/FilterLogData.java
 3a8eae9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
 906dd25 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 6dbf8be 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
 c692a9d

Re: Review Request 51369: Fix LogSearch utility classes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51369/
---

(Updated Nov. 7, 2016, 9:12 a.m.)


Review request for Ambari, Dharmesh Kakadia, Hayat Behlim, Oliver Szabo, and 
Robert Nettleton.


Changes
---

fix branches


Bugs: AMBARI-18253
https://issues.apache.org/jira/browse/AMBARI-18253


Repository: ambari


Description
---

A utility class should not be instantiated, should have no state and should 
have only static methods. Currently some of the classes under the util package 
are instantiated moreover injected as components, and have state.

BizUtil, CommonUtil, DateUtil, FileUtil, JSONUtil, RESTErrorUtil, SolrUtil were 
converted to proper utility classes.
QueryBase was merged into SolrUtil.
ConfigUtil, PropertiesUtil and XMlPropertiesHelper were moved to common, and 
renamed to Helpers.
ExternalServerClient was moved to common.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 fcebcea 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
 2cf2139 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 a6f77e9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 af6d62d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 2129f9e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 a0c1134 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
 b7853df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGenerator.java
 3793f50 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGeneratorBase.java
 49006e2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 947fdbb 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogFileMgr.java
 8badb61 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 9baccce 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
 02e2e69 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
 28f806c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
 0c8be45 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
 ca6df65 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java
 a906ceb 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/UserConfigREST.java
 a79a737 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 c644cd5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/BizUtil.java
 814b8ee 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/CommonUtil.java
 8ec04f8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
 88f92a2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/DateUtil.java
 516d828 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ExternalServerClient.java
 882a8bd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/FileUtil.java
 e3c2063 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
 5332d18 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
 59f0296 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/QueryBase.java
 5961cff

Re: Review Request 51326: Fix package structure in Logfeeder


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51326/
---

(Updated Nov. 7, 2016, 9:11 a.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

fix branches


Bugs: AMBARI-18236
https://issues.apache.org/jira/browse/AMBARI-18236


Repository: ambari


Description
---

- all utility classes are in the util package
- only the LogFeeder class is in the top level package


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
 44bc829 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
 c3ccc47 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
 fa60702 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 3cf0fff 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
 da61d83 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 a86d989 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java
 9bb1564 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
 b2a7786 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MurmurHash.java
 2a54f28 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
 41b005b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogfeederException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/exception/LogfeederException.java
 c22b512 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
 01d4f79 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
 7aa649d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 f375374 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
 1b8b3a3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 76af16c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
 9d3545e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMgr.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
 12a512f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
 48ad7ac 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 872460b 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogfeederScheduler.java
 128c5c4 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
 8691a19 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/FilterLogData.java
 bf33f93 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 45ccc70 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
 e1f8f97 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
 7e530f5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricCount.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsMgr.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
 a4e0eda 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java
 aef8dc5 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 f711a5f

Re: Review Request 51289: Add unit tests for Log Search components and refactor them as needed - Vol 1


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51289/
---

(Updated Nov. 7, 2016, 9:11 a.m.)


Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
Robert Nettleton.


Changes
---

fix branches


Bugs: AMBARI-18227
https://issues.apache.org/jira/browse/AMBARI-18227


Repository: ambari


Description
---

Dao and common package are covered with unit tests now.

Cleanup done:

- maximum line length is 120 now
- ManageStartEndTime fixed (it may have returned an invalid time range if it 
was asked right between updating the window)
- fix setupCollectionsWithImplicitRouting, maxShardsPerNode were set twice 
instead of numShards and maxShardsPerNode
- RequestContext was removed as it was never used only in UserDao, the 
constants were moved there too
- UserSessionInfo was removed as it contained only one field, and getter/setter 
for it.
- LogSearchContext was introduced by merging LogsearchContextUtil, 
UserSessionInfo, LogsearchContextHolder, LogsearchSecurityContext
- UserInfoAttributes was removed as it contained only constants which were used 
in 
- removed the class org.apache.ambari.logsearch.util.StringUtil, 
org.apache.commons.lang.StringUtils is used instead
- StringUtils, ArrayUtils and CollectionUtils are used at various locations
- java naming conventions enforced
- visibilities fixed
- unused codes removed
- handle constants as constants


Diffs
-

  ambari-logsearch/ambari-logsearch-portal/pom.xml a886b37 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 d1fbcde 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 5dcdac1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogsearchContextUtil.java
 617f2fd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ManageStartEndTime.java
 94b7159 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 59e698f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/RequestContext.java
 83ed3bd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
 d0facbc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/UserSessionInfo.java
 78fea31 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 5a56ad7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 5aba6d1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 cda5e26 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 e612475 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
 6b2f049 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserInfoAttributes.java
 7bc3555 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGenerator.java
 d3975b3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGeneratorBase.java
 a813e96 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 ab287bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogFileMgr.java
 1bd9a78 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 257f04d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
 99eb9f2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/PublicMgr.java
 0dccb74 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/SessionMgr.java
 dbc14e1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
 c4fbd9f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
 d934e84 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
 a128098 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java
 373f7ff

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

2016-11-07 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53477/#review155112
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
 (line 183)


Please add some unit test to verify that the curl command is invoked with 
the correct parameters.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 (line 132)


Please add unit test to ensure that the curl command is invoked with 
correct parameters.


- Sebastian Toader


On Nov. 7, 2016, 9:22 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53477/
> ---
> 
> (Updated Nov. 7, 2016, 9:22 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18479 and AMBARI-18770
> https://issues.apache.org/jira/browse/AMBARI-18479
> https://issues.apache.org/jira/browse/AMBARI-18770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is 
> configured. The issue is curl is configured to follow redirects, but not send 
> the initial requests credentials to the redirected location. 
> 
> From curl manual:
> (HTTP/HTTPS)  If the server reports that the requested page has moved to a 
> different location (indicated with a Location: header and a 3XX response 
> code), this 
>   option will make curl redo the request on the new place. If 
> used together with -i, --include or -I, --head, headers from all requested  
> pages  will  be  shown. 
>   When  authentication  is used, curl only sends its credentials 
> to the initial host. If a redirect takes curl to a different host, it won't 
> be able to intercept 
>   the user+password. See also --location-trusted on how to change 
> this. 
> 
> In the patch a changed the -L switch to --location-trusted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  2acf871 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  daa8e7e 
> 
> Diff: https://reviews.apache.org/r/53477/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> 1. Installed Ambari from RPM
> 2. Added the following services: HDFS, YARN, MapReduce2, ZooKeeper
> 3. Enabled kerberos
> 4. Enabled YARN HA
> 5. Enabled SPNEGO Authentication
> 6. Ran service check on YARN and checked alert statuses
> 
> Tests in ambari project ran clean.
> 
> Tests run: 4662, Failures: 0, Errors: 0, Skipped: 34
> Ran 442 tests in 102.060s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.