date:20170113


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55083/#review161638
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 13, 2017, 1:42 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55083/
> ---
> 
> (Updated Jan. 13, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19029
> https://issues.apache.org/jira/browse/AMBARI-19029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After enabling Namenode-HA, atlas had a critical alert that "This host-level 
> alert is triggered if the Metadata Server Web UI is unreachable."
> 
> As a fix we need to include hdfs-site.xml in Atlas conf directory classpath 
> when Namenode-HA is enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  05510cd 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a568cb7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  4b7bd3c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bb7f596 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> eaa5e21 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> f2fec70 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
> 
> Diff: https://reviews.apache.org/r/55083/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> test_service_check (test_service_check.TestAtlasCheck) ... 2017-01-12 
> 19:24:26,791 - Stack Feature Version Info: stack_version=2.3, 
> version=2.2.1.0-2067, current_cluster_version=None -> 2.2.1.0-2067
> 2017-01-12 19:24:26,795 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> 2017-01-12 19:24:26,806 - Stack Feature Version Info: stack_version=2.3, 
> version=2.2.1.0-2067, current_cluster_version=None -> 2.2.1.0-2067
> test_service_check_secure (test_service_check.TestAtlasCheck) ... 2017-01-12 
> 19:24:26,809 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf
> ok
> 
> test_configure_default (test_atlas_server.TestAtlasServer) ... 2017-01-12 
> 19:24:51,208 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
> 2017-01-12 19:24:51,212 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-01-12 19:24:51,230 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
> ok
> test_security_status (test_atlas_server.TestAtlasServer) ... 2017-01-12 
> 19:24:51,245 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
> 2017-01-12 19:24:51,249 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Madhuvanthi Radhakrishnan



> On Jan. 13, 2017, 1:56 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java,
> >  line 226
> > 
> >
> > I don't think you want "desiredConfig" here - at the point where this 
> > runs in the upgrade, desired configurations are already moved to the new 
> > stack. That could cause invalid replacements.

Hi Jonathan,
Since upgrade values do not automatically pick up the new values, I thought 
these fixes are meant to be made in the final/desired configs. Also,
In the final replacement stage, it is using the desiredConfig's content to 
replace the values.
In ConfigureAction.java - line 432 String replaced = 
StringUtils.replace(toReplace, replacement.find, replacement.replaceWith);
The toReplace is coming from newValues.get(replacement.key);
Map newValues = new HashMap(base);
Map base = config.getProperties();
Config config = cluster.getConfig(configType, desiredConfig.getTag());

Please correct me if I am wrong. Thank you.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/#review161523
---


On Jan. 12, 2017, 11:27 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55478/
> ---
> 
> (Updated Jan. 12, 2017, 11:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle HDP upgrade scenario
> Changes:
> 1. Add a new task called "regex-replace" for configure-upgrade.xml
> 2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 9ddb667 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  7ccd96d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> abd8fb9 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
> 
> Diff: https://reviews.apache.org/r/55478/diff/
> 
> 
> Testing
> ---
> 
> NonRolling Upgrade path 2.5-2.6
> -Verified that the log4j changes appear for 
> (HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard

2017-01-13 Thread Yusaku Sako


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55528/#review161633
---


Ship it!




Ship It!

- Yusaku Sako


On Jan. 14, 2017, 1:11 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55528/
> ---
> 
> (Updated Jan. 14, 2017, 1:11 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19543
> https://issues.apache.org/jira/browse/AMBARI-19543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Move the first row of graphs to the last in HDFS TopN Grafana Dashboard.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json
>  5b90ae9 
> 
> Diff: https://reviews.apache.org/r/55528/diff/
> 
> 
> Testing
> ---
> 
> Verified Manually.
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 55529: PREVIEW. HDP 3.0 TP - create Service Advisor for HDFS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161632
---




ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 (line 160)


Recommendation class



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 (line 182)


The logic in these functions was copied from older HDP stacks.



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 (line 259)


I can move this into stack advisor.



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 (line 356)


Validator class



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 (line 379)


Example



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 95)


This can now be used by service advisors.



ambari-server/src/main/resources/stacks/stack_advisor.py (line 884)


This method was moved from HDP 2.0.6 stack advisor to the default stack 
advisor.



ambari-server/src/main/resources/stacks/stack_advisor.py (line 1052)


New method.


- Alejandro Fernandez


On Jan. 14, 2017, 1:37 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55529/
> ---
> 
> (Updated Jan. 14, 2017, 1:37 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19097
> https://issues.apache.org/jira/browse/AMBARI-19097
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten 
> from HDP 2.0.6 through HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py
>  82316f4 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 5172042 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 9b217b3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 6ae29cb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> b601179 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> 4e4ef51 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 
> 26292d9 
>   ambari-server/src/main/resources/stacks/stack_advisor.py d648a53 
>   ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 355e211 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
> 
> Diff: https://reviews.apache.org/r/55529/diff/
> 
> 
> Testing
> ---
> 
> Verified recommendation and validation of HDFS while deploying HDP 3.0
> 
> Python unit tests passed.
> 
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 55529: PREVIEW. HDP 3.0 TP - create Service Advisor for HDFS


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-19097
https://issues.apache.org/jira/browse/AMBARI-19097


Repository: ambari


Description
---

Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten 
from HDP 2.0.6 through HDP 2.6


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py
 82316f4 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
5172042 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
9b217b3 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
6ae29cb 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
b601179 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
4e4ef51 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 
26292d9 
  ambari-server/src/main/resources/stacks/stack_advisor.py d648a53 
  ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
355e211 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 

Diff: https://reviews.apache.org/r/55529/diff/


Testing
---

Verified recommendation and validation of HDFS while deploying HDP 3.0

Python unit tests passed.

Total run:1157
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55528/
---

Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19543
https://issues.apache.org/jira/browse/AMBARI-19543


Repository: ambari


Description
---

Move the first row of graphs to the last in HDFS TopN Grafana Dashboard.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json
 5b90ae9 

Diff: https://reviews.apache.org/r/55528/diff/


Testing
---

Verified Manually.


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is



> On Jan. 14, 2017, 12:42 a.m., Siddharth Seth wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 1044
> > 
> >
> > If we leave minContainerSize unchanged here - the old computations 
> > continue as is, correct?
> > So there'll be no change in containers, or ramPerContainer.
> > 
> > Finally when ramPerContainer is normalized against the new 
> > minContainerSize - a new value will be set.

If user has set min container size, we need to use that - won't we? So the 
logic picks up the user specified value in all scenarios other than fresh 
install.


> On Jan. 14, 2017, 12:42 a.m., Siddharth Seth wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 1069
> > 
> >
> > Tnis should be a roundup instead of a roundDown.
> > 
> > int(ceil(float(cluster["ramPerContainer"]) / 
> > cluster["minContainerRam"]) * cluster["minContainerRam"])

Does that not have a chance of ramPerContainer * numContainer to exceed host's 
available memory?


> On Jan. 14, 2017, 12:42 a.m., Siddharth Seth wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 1075
> > 
> >
> > Think we should retain this rounding functionality, before rounding to 
> > the set minContainerSize. That can affect whether we go above or below the 
> > minContainerSize.

It is modifed to use the minContainer size. 
cluster["ramPerContainer"] = int(cluster["ramPerContainer"] / 
cluster["minContainerRam"]) * cluster["minContainerRam"]


> On Jan. 14, 2017, 12:42 a.m., Siddharth Seth wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 127
> > 
> >
> > This value gets changed based on the new ramPerContainer calculation, 
> > but somehow does not show up in recommendations.
> > 
> > Needs to be de-linked from the rounding, and stick to the old value.
> > 
> > I think the "minContainerSize" = user suggested value, as well as the 
> > rounding done for ramPerContainer will affect this.

I believe it only has impact during fresh install. After that users need to 
change the value explicitly.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161628
---


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is



> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote:
> > Looked at the changes in stack-advisor. Mostly look good to me.
> > Was a little confused by the change to minContainerSize based on whether 
> > the used change the yarn min-allocation-mb property.
> 
> Sumit Mohanty wrote:
> So the scenarios that I am trying to capture are:
> * Initial cluster creation - SA will ignore what value it gets in 
> yarn-site and use the computation strategy it has
> * Validation call, call when user lands on an UI page, call when any 
> other config changes - SA will use whatever value that comes through 
> "yarn-site" (this is by definition considered an user provided value)
> * If user change the min container size then it will be indicated in the 
> changed_configuration[] section and then the user supplied new value is used.
> 
> Siddharth Seth wrote:
> Sorry. I missed some stuff. Ran into some problems while running this on 
> a cluster. Looking some more. Will update comments after that.
> e.g. Setting min-container-size to 2048, reduced the map size to 2048 
> instead of the old value of 3072.

Thats because 3072 is invalid - does it not need to be a multiple of the min 
container size (2048). I think 4096 is too large to allow 4 containers on that 
host.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161592
---


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55486: AMBARI-19417. Enable hiveContext in Livy

2017-01-13 Thread Jeff Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55486/
---

(Updated Jan. 14, 2017, 12:51 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Address comment


Bugs: AMBARI-19417
https://issues.apache.org/jira/browse/AMBARI-19417


Repository: ambari


Description
---

Update the livy configuration to enable hiveContext


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 b7bfa73 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 457869d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-env.xml
 afb1d17 

Diff: https://reviews.apache.org/r/55486/diff/


Testing
---

Tested maunally.


Thanks,

Jeff Zhang

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161628
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 127)


This value gets changed based on the new ramPerContainer calculation, but 
somehow does not show up in recommendations.

Needs to be de-linked from the rounding, and stick to the old value.

I think the "minContainerSize" = user suggested value, as well as the 
rounding done for ramPerContainer will affect this.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 1044)


If we leave minContainerSize unchanged here - the old computations continue 
as is, correct?
So there'll be no change in containers, or ramPerContainer.

Finally when ramPerContainer is normalized against the new minContainerSize 
- a new value will be set.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 1069)


Tnis should be a roundup instead of a roundDown.

int(ceil(float(cluster["ramPerContainer"]) / cluster["minContainerRam"]) * 
cluster["minContainerRam"])



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 


Think we should retain this rounding functionality, before rounding to the 
set minContainerSize. That can affect whether we go above or below the 
minContainerSize.


- Siddharth Seth


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55527/
---

(Updated Jan. 14, 2017, 12:41 a.m.)


Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19540
https://issues.apache.org/jira/browse/AMBARI-19540


Repository: ambari


Description
---

As you can see 3 calls are made while changing from 1024 to 2048 and similarly 
3 calls when coming back to 1024. 
Beyond performance concern, multiple calls have a functional issue. The call 
includes previous value of the changed property - see the values. I would have 
expected the old value to be the value that was the original/saved value. 
However, it is wherever UI makes the stack advisor calls.
[root@smq1-1 stack-recommendations]# find . -name services.json | xargs grep -A 
3 changed
./55/services.json:  "changed-configurations" : [ {
./55/services.json-"type" : "yarn-site",
./55/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./55/services.json-"old_value" : "1024"

./56/services.json:  "changed-configurations" : [ {
./56/services.json-"type" : "yarn-site",
./56/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./56/services.json-"old_value" : "1280"

./57/services.json:  "changed-configurations" : [ {
./57/services.json-"type" : "yarn-site",
./57/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./57/services.json-"old_value" : "1792"

./58/services.json:  "changed-configurations" : [ {
./58/services.json-"type" : "yarn-site",
./58/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./58/services.json-"old_value" : "2048"

./59/services.json:  "changed-configurations" : [ {
./59/services.json-"type" : "yarn-site",
./59/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./59/services.json-"old_value" : "1792"

./60/services.json:  "changed-configurations" : [ {
./60/services.json-"type" : "yarn-site",
./60/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./60/services.json-"old_value" : "1280"


Diffs (updated)
-

  ambari-web/app/views/common/controls_view.js dc91f36 

Diff: https://reviews.apache.org/r/55527/diff/


Testing
---

Verified Mannually in the latest version of Google Chrome, Mozilla Firefox and 
Safari browsers.

Ambari-web unit tests pass
30298 passing (19s)
157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth



> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote:
> > Looked at the changes in stack-advisor. Mostly look good to me.
> > Was a little confused by the change to minContainerSize based on whether 
> > the used change the yarn min-allocation-mb property.
> 
> Sumit Mohanty wrote:
> So the scenarios that I am trying to capture are:
> * Initial cluster creation - SA will ignore what value it gets in 
> yarn-site and use the computation strategy it has
> * Validation call, call when user lands on an UI page, call when any 
> other config changes - SA will use whatever value that comes through 
> "yarn-site" (this is by definition considered an user provided value)
> * If user change the min container size then it will be indicated in the 
> changed_configuration[] section and then the user supplied new value is used.

Sorry. I missed some stuff. Ran into some problems while running this on a 
cluster. Looking some more. Will update comments after that.
e.g. Setting min-container-size to 2048, reduced the map size to 2048 instead 
of the old value of 3072.


- Siddharth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161592
---


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55527/
---

Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19540
https://issues.apache.org/jira/browse/AMBARI-19540


Repository: ambari


Description
---

As you can see 3 calls are made while changing from 1024 to 2048 and similarly 
3 calls when coming back to 1024. 
Beyond performance concern, multiple calls have a functional issue. The call 
includes previous value of the changed property - see the values. I would have 
expected the old value to be the value that was the original/saved value. 
However, it is wherever UI makes the stack advisor calls.
[root@smq1-1 stack-recommendations]# find . -name services.json | xargs grep -A 
3 changed
./55/services.json:  "changed-configurations" : [ {
./55/services.json-"type" : "yarn-site",
./55/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./55/services.json-"old_value" : "1024"

./56/services.json:  "changed-configurations" : [ {
./56/services.json-"type" : "yarn-site",
./56/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./56/services.json-"old_value" : "1280"

./57/services.json:  "changed-configurations" : [ {
./57/services.json-"type" : "yarn-site",
./57/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./57/services.json-"old_value" : "1792"

./58/services.json:  "changed-configurations" : [ {
./58/services.json-"type" : "yarn-site",
./58/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./58/services.json-"old_value" : "2048"

./59/services.json:  "changed-configurations" : [ {
./59/services.json-"type" : "yarn-site",
./59/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./59/services.json-"old_value" : "1792"

./60/services.json:  "changed-configurations" : [ {
./60/services.json-"type" : "yarn-site",
./60/services.json-"name" : "yarn.scheduler.minimum-allocation-mb",
./60/services.json-"old_value" : "1280"


Diffs
-

  ambari-web/app/views/common/controls_view.js dc91f36 

Diff: https://reviews.apache.org/r/55527/diff/


Testing
---

Verified Mannually in the latest version of Google Chrome, Mozilla Firefox and 
Safari browsers.

Ambari-web unit tests pass
30298 passing (19s)
157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/#review161605
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 13, 2017, 9:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55524/
> ---
> 
> (Updated Jan. 13, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19538
> https://issues.apache.org/jira/browse/AMBARI-19538
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings to Hive, Druid, Storm
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  f612766 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  c83b16e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml
>  cc837bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml
>  96562df 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  58f01e6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  aa116d6 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
>  58e1791 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
>  adf57fa 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml
>  1709f0d 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml
>  a1029a2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  6953530 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> bf9c208 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> 2b26dd8 
> 
> Diff: https://reviews.apache.org/r/55524/diff/
> 
> 
> Testing
> ---
> 
> Verified log4j rotation changes:
> UI
> DB
> API
> Disk
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is



> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote:
> > Looked at the changes in stack-advisor. Mostly look good to me.
> > Was a little confused by the change to minContainerSize based on whether 
> > the used change the yarn min-allocation-mb property.

So the scenarios that I am trying to capture are:
* Initial cluster creation - SA will ignore what value it gets in yarn-site and 
use the computation strategy it has
* Validation call, call when user lands on an UI page, call when any other 
config changes - SA will use whatever value that comes through "yarn-site" 
(this is by definition considered an user provided value)
* If user change the min container size then it will be indicated in the 
changed_configuration[] section and then the user supplied new value is used.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161592
---


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55482/#review161592
---



Looked at the changes in stack-advisor. Mostly look good to me.
Was a little confused by the change to minContainerSize based on whether the 
used change the yarn min-allocation-mb property.

- Siddharth Seth


On Jan. 13, 2017, 1:41 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55482/
> ---
> 
> (Updated Jan. 13, 2017, 1:41 a.m.)
> 
> 
> Review request for Ambari, Siddharth Seth, Swapan Shridhar, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A large value for YARN min container size reduces the number of AMs that can 
> be created for llap.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/stack_advisor.py abfab87 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 480e73d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cf7134e 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> d781147 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 02be812 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 378522e 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> a7ccdfe 
> 
> Diff: https://reviews.apache.org/r/55482/diff/
> 
> 
> Testing
> ---
> 
> Ran all stack advisor tests manually.
> 
> --
> Ran 270 tests in 6.771s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55522: Incorrect error message when trying to add a group to multiple roles


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/#review161599
---


Ship it!




Ship It!

- Di Li


On Jan. 13, 2017, 9:35 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55522/
> ---
> 
> (Updated Jan. 13, 2017, 9:35 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-19476
> https://issues.apache.org/jira/browse/AMBARI-19476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create a group and assign roles to the group.
> 2. If you add the same group to multiple roles, the error message says "Only 
> 1 role allowed per user".
> 
> Updated the error message to say users or groups.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> a01324b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js
>  c170235 
> 
> Diff: https://reviews.apache.org/r/55522/diff/
> 
> 
> Testing
> ---
> 
> Manual test verification.
> Ran mvn test.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55518/#review161597
---


Ship it!




Ship It!

- Di Li


On Jan. 13, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55518/
> ---
> 
> (Updated Jan. 13, 2017, 7:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Gaurav Nagar.
> 
> 
> Bugs: AMBARI-19451
> https://issues.apache.org/jira/browse/AMBARI-19451
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Per the Apache documentation for Yarn Node Labels 
> (http://hadoop.apache.org/docs/r2.7.3/hadoop-yarn/hadoop-yarn-site/NodeLabel.html),
>  queues that can only access nodes without labels are defined by setting the 
> property "yarn.scheduler.capacity..accessible-node-labels" with 
> space as the value.
> 
> Reproduction Steps:
> 1. In the Capacity Scheduler view (Yarn Queue Manager), create queues q1,q2, 
> and set accessible node labels for root,q1,q2 but not for default queue
> 2. Since there is no way to specify a "space" as the value for accessible 
> node labels via Yarn Queue Manager, add this property manually via yarn 
> configs. i.e. In Yarn -> Configs -> Scheduler, manually add 
> yarn.scheduler.capacity.root.default.accessible-node-labels= (space after the 
> =)
> 3. Save the configuration and restart Resource Manager as required
> 4. Return to Yarn Queue Manager, and click the default queue. It shows an 
> error - Label is not exist on cluster.
> 
> This seems to happen because in the capacity scheduler code, the value of the 
> yarn.scheduler.capacity..accessible-node-labels..capacity 
> is not trimmed and the " " string is considered to be a label.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> de19cc9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueContainer.hbs
>  453bbbc 
> 
> Diff: https://reviews.apache.org/r/55518/diff/
> 
> 
> Testing
> ---
> 
> Manual test.
> mvn test
> Build failure is unrelated to the change. Also, I could not reproduce the 
> build failure. The capacity scheduler code compiles cleanly.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 55524: Add log rotation settings to Hive, Druid, Storm

2017-01-13 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-19538
https://issues.apache.org/jira/browse/AMBARI-19538


Repository: ambari


Description
---

Add log rotation settings to Hive, Druid, Storm


Diffs
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 f612766 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 c83b16e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml
 cc837bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml
 96562df 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 58f01e6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a515b62 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 aa116d6 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
 58e1791 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
 adf57fa 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 c167d7c 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml
 1709f0d 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml
 a1029a2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 6953530 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
bf9c208 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
2b26dd8 

Diff: https://reviews.apache.org/r/55524/diff/


Testing
---

Verified log4j rotation changes:
UI
DB
API
Disk


Thanks,

Madhuvanthi Radhakrishnan

Review Request 55523: When viewing details of a group, the group type is sometimes empty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55523/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-19535
https://issues.apache.org/jira/browse/AMBARI-19535


Repository: ambari


Description
---

When you click on a Group and view its details, sometimes the Type shows an 
empty value. 

The following error can be seen on the web console.

vendor.js:22245 TypeError: Cannot read property 'LABEL_KEY' of undefined at 
main.js:2278 at wrappedCallback (vendor.js:23746) at vendor.js:23832 at 
Scope.$eval (vendor.js:24875) at Scope.$digest (vendor.js:24687) at 
Scope.$apply (vendor.js:24979) at done (vendor.js:20552) at completeRequest 
(vendor.js:20766) at XMLHttpRequest.xhr.onreadystatechange (vendor.js:20705)

This is happenening because the REST call that fetches group type details 
(getGroupType) does not always return before the groupTypeName is set in 
getMembers. 
To fix this, moved the code for setting groupTypeName to the getGroupType 
method. The groupTypeName is now set once the group type has been retrieved by 
the REST call.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
 aa6af2a 

Diff: https://reviews.apache.org/r/55523/diff/


Testing
---

Manual testing.
Ran mvn test.


Thanks,

Sangeeta Ravindran

Review Request 55522: Incorrect error message when trying to add a group to multiple roles


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-19476
https://issues.apache.org/jira/browse/AMBARI-19476


Repository: ambari


Description
---

1. Create a group and assign roles to the group.
2. If you add the same group to multiple roles, the error message says "Only 1 
role allowed per user".

Updated the error message to say users or groups.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
a01324b 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js
 c170235 

Diff: https://reviews.apache.org/r/55522/diff/


Testing
---

Manual test verification.
Ran mvn test.


Thanks,

Sangeeta Ravindran

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file



> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 246
> > 
> >
> > -1. If the config doesn't exist at all, that's a problem and we 
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing 
> > knoxsso-topology?
> > 
> > I want to understand the root cause first.
> 
> Di Li wrote:
> hi Alejandro,
> 
> This JIRA is to deal with third party stacks that are lack of config type 
> as well as properties in existing configurations.
> 
> The logic should not impact HDP. It helps to third party stacks to run 
> without having to ship empty config xml files (to satisfy the Python scripts) 
> or adding unnecessary properties to existing configuration xml files.
> 
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? 
> Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
> 
> I don't want relaxing constraints to introduce bugs if configs that need 
> to be present are not there.
> 
> Alejandro Fernandez wrote:
> I'm ok with relaxing constraints, I just want to understand the reason 
> why Sqoop, Hive, and Knox would not have those config types.
> 
> Di Li wrote:
> Hi Alejandro,
> 
> For stacks that I work on (third party, not HDP stacks), Sqoop only needs 
> sqoop-env.xml - as Sqoop build I am using doesn't require sqoop-site.xml.  
> Similarly, the Hive and Knox builds I am using do not have the same sets of 
> configuration xml files or the properties as HDP.
> 
> My current work requires me to update services in my stack to extend 
> common services. This change is OK when I run express upgrade. But when I run 
> a downgrade, the addtional config type and properties common services Python 
> scripts require causes downgrade to fail as the actual configurations during 
> the downgrade time is from my old release/stack (lack of sqoop-site.xml, for 
> example)
> 
> So my thought was to update common services to skip the ones that cause 
> my downgrade to fail. So that common services will not force me to have 
> configurations that I don't need.

k, thank you for the explanation.
In the future, it would be good to for the stacks to define which config types 
are optional/required.
Your change is ok in common-services since it needs to support all stacks.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
---


On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> ---
> 
> (Updated Jan. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Able to skip writing configuration files when the config type doesn't exist 
> in the command JSON file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7911058 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  cce9c5f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  8416e98 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  53a3316 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  d005cbe 
> 
> Diff: https://reviews.apache.org/r/55387/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161594
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> ---
> 
> (Updated Jan. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Able to skip writing configuration files when the config type doesn't exist 
> in the command JSON file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7911058 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  cce9c5f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  8416e98 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  53a3316 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  d005cbe 
> 
> Diff: https://reviews.apache.org/r/55387/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file



> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 246
> > 
> >
> > -1. If the config doesn't exist at all, that's a problem and we 
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing 
> > knoxsso-topology?
> > 
> > I want to understand the root cause first.
> 
> Di Li wrote:
> hi Alejandro,
> 
> This JIRA is to deal with third party stacks that are lack of config type 
> as well as properties in existing configurations.
> 
> The logic should not impact HDP. It helps to third party stacks to run 
> without having to ship empty config xml files (to satisfy the Python scripts) 
> or adding unnecessary properties to existing configuration xml files.
> 
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? 
> Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
> 
> I don't want relaxing constraints to introduce bugs if configs that need 
> to be present are not there.
> 
> Alejandro Fernandez wrote:
> I'm ok with relaxing constraints, I just want to understand the reason 
> why Sqoop, Hive, and Knox would not have those config types.

Hi Alejandro,

For stacks that I work on (third party, not HDP stacks), Sqoop only needs 
sqoop-env.xml - as Sqoop build I am using doesn't require sqoop-site.xml.  
Similarly, the Hive and Knox builds I am using do not have the same sets of 
configuration xml files or the properties as HDP.

My current work requires me to update services in my stack to extend common 
services. This change is OK when I run express upgrade. But when I run a 
downgrade, the addtional config type and properties common services Python 
scripts require causes downgrade to fail as the actual configurations during 
the downgrade time is from my old release/stack (lack of sqoop-site.xml, for 
example)

So my thought was to update common services to skip the ones that cause my 
downgrade to fail. So that common services will not force me to have 
configurations that I don't need.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
---


On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> ---
> 
> (Updated Jan. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Able to skip writing configuration files when the config type doesn't exist 
> in the command JSON file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7911058 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  cce9c5f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  8416e98 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  53a3316 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  d005cbe 
> 
> Diff: https://reviews.apache.org/r/55387/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55518/
---

Review request for Ambari, Di Li and Gaurav Nagar.

Bugs: AMBARI-19451
https://issues.apache.org/jira/browse/AMBARI-19451

Repository: ambari

Description
---

Per the Apache documentation for Yarn Node Labels
(http://hadoop.apache.org/docs/r2.7.3/hadoop-yarn/hadoop-yarn-site/NodeLabel.html),
queues that can only access nodes without labels are defined by setting the
property "yarn.scheduler.capacity..accessible-node-labels" with
space as the value.

Reproduction Steps:
1. In the Capacity Scheduler view (Yarn Queue Manager), create queues q1,q2,
and set accessible node labels for root,q1,q2 but not for default queue
2. Since there is no way to specify a "space" as the value for accessible node
labels via Yarn Queue Manager, add this property manually via yarn configs.
i.e. In Yarn -> Configs -> Scheduler, manually add
yarn.scheduler.capacity.root.default.accessible-node-labels= (space after the =)
3. Save the configuration and restart Resource Manager as required
4. Return to Yarn Queue Manager, and click the default queue. It shows an error
- Label is not exist on cluster.

This seems to happen because in the capacity scheduler code, the value of the
yarn.scheduler.capacity..accessible-node-labels..capacity is
not trimmed and the " " string is considered to be a label.

Diffs
-

contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js
de19cc9

contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueContainer.hbs
453bbbc

Diff: https://reviews.apache.org/r/55518/diff/

Testing
---

Manual test.
mvn test
Build failure is unrelated to the change. Also, I could not reproduce the build
failure. The capacity scheduler code compiles cleanly.

Thanks,

Sangeeta Ravindran

Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55516/
---

Review request for Ambari, DIPAYAN BHOWMICK and Nitiraj Rathore.


Bugs: AMBARI-19475
https://issues.apache.org/jira/browse/AMBARI-19475


Repository: ambari


Description
---

In the Workflow Manager View, when there are no co-ordinator or bundle records, 
the dashboard message says "Showing 1 to 0 of 0 records". This is because the 
start record is set to 1 by default.

Fix is to set the start record to 0, if the total records is 0.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 
78bc1c9 

Diff: https://reviews.apache.org/r/55516/diff/


Testing
---

Manual testing.


Thanks,

Sangeeta Ravindran

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file



> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 246
> > 
> >
> > -1. If the config doesn't exist at all, that's a problem and we 
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing 
> > knoxsso-topology?
> > 
> > I want to understand the root cause first.
> 
> Di Li wrote:
> hi Alejandro,
> 
> This JIRA is to deal with third party stacks that are lack of config type 
> as well as properties in existing configurations.
> 
> The logic should not impact HDP. It helps to third party stacks to run 
> without having to ship empty config xml files (to satisfy the Python scripts) 
> or adding unnecessary properties to existing configuration xml files.
> 
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? 
> Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
> 
> I don't want relaxing constraints to introduce bugs if configs that need 
> to be present are not there.

I'm ok with relaxing constraints, I just want to understand the reason why 
Sqoop, Hive, and Knox would not have those config types.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
---


On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> ---
> 
> (Updated Jan. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Able to skip writing configuration files when the config type doesn't exist 
> in the command JSON file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7911058 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  cce9c5f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  8416e98 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  53a3316 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  d005cbe 
> 
> Diff: https://reviews.apache.org/r/55387/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file



> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> >  line 246
> > 
> >
> > -1. If the config doesn't exist at all, that's a problem and we 
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing 
> > knoxsso-topology?
> > 
> > I want to understand the root cause first.
> 
> Di Li wrote:
> hi Alejandro,
> 
> This JIRA is to deal with third party stacks that are lack of config type 
> as well as properties in existing configurations.
> 
> The logic should not impact HDP. It helps to third party stacks to run 
> without having to ship empty config xml files (to satisfy the Python scripts) 
> or adding unnecessary properties to existing configuration xml files.

Are you saying that in a service like Sqoop that sqoop-site is optional? Samem 
goes for the other config types in Hive and Knox.
If so, we need a better way of indicating optional configs.

I don't want relaxing constraints to introduce bugs if configs that need to be 
present are not there.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
---


On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> ---
> 
> (Updated Jan. 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Able to skip writing configuration files when the config type doesn't exist 
> in the command JSON file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7911058 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  cce9c5f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  8416e98 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  53a3316 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  d005cbe 
> 
> Diff: https://reviews.apache.org/r/55387/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

2017-01-13 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-18739
https://issues.apache.org/jira/browse/AMBARI-18739


Repository: ambari


Description
---

Also includes code for AMBARI-18738. Perf: Allow components to report their 
version using distro-select and change configs using conf-select

In order to run Rolling/Express Upgrade, will need to create the 
Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
do it across major versions.

This means each service will need to support start commands with the 
upgrade_type option, have symlinks already in distro-select, etc.

At first, this can be a handful of services.
The goal is to simulate Rolling/Express Upgrade on the PERF stack.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 513ceac8dd 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 615a0cdcbc 
  ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
3dcece501d 
  ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
4dec16f372 
  ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
d70e87fb1e 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 9eca9ec724 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 9eca9ec724 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 9eca9ec724 
  
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
 9eca9ec724 
  ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
  ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
  ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
  ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
c5137fb133 
  ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
c5137fb133 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
15c5cfddd2 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
53cc11b7eb 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
f1f4b7d1ac 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
42edc8d493 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
 6fc338b1da 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
 96be63060a 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
 c3488e8bcc 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
5b4dbd4a2d 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
21e685ad80 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
bb2191b267 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
 57667bb888 
  
ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/install_packages.py PRE-CREATION 
  contrib/utils/perf/deploy-gce-perf-cluster.py 8ba7e42e0b 

Diff: https://reviews.apache.org/r/55515/diff/


Testing
---

Tested on my local 3-node cluster (both upgrade and downgrade). 
Script for creating Perf cluster downloads Ambari code from Apache git, so did 
not manage to test on gce, but script should work too (added required code).

What works:
- deploy of Perf 1.0 cluster
- RU to 2.0 (upgrade and downgrade)
- EU to 2.0 (upgrade and downgrade)

Issues:
- Clean deploy of perf 2.0 stack (dummy component install scripts are hardcoded 
with 1.1.1.1 version)


Thanks,

Dmitro Lisnichenko

Re: Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55514/#review161562
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Jan. 13, 2017, 6:25 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55514/
> ---
> 
> (Updated Jan. 13, 2017, 6:25 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19536
> https://issues.apache.org/jira/browse/AMBARI-19536
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Should do the following adjustments to integrate with the new style 
> guidelines:
> 
> Step 2, as for the contents inside of the white panel:
> 1. Make the two radio buttons horizontally aligned.
> 2. Browse file button should be consistent with other buttons
> 3. Each section title should be readable. 
> 
> Step 3, 
> 3. "Remove Selected" should be right aligned, also disappear if nothing 
> selected
> Warning section should have some margin
> 
> Step 7,
> 5. Advanced configs, collapse of each category should be consistent with 
> configs page after installed
> 
> Also, In general, the checkbox and radio buttons are not aligned with related 
> text.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js bd60f90 
>   ambari-web/app/styles/theme/bootstrap-ambari.css 5b18417 
>   ambari-web/app/styles/wizard.less b3a833d 
>   ambari-web/app/templates/wizard/step1.hbs 6900624 
>   ambari-web/app/templates/wizard/step2.hbs 4912851 
>   ambari-web/app/templates/wizard/step3.hbs 2ba87e1 
>   ambari-web/app/views/wizard/step2_view.js 719227d 
> 
> Diff: https://reviews.apache.org/r/55514/diff/
> 
> 
> Testing
> ---
> 
> 20236 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 55486: AMBARI-19417. Enable hiveContext in Livy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55486/#review161561
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 (line 79)


This a new stack, please  everywhere


- Alejandro Fernandez


On Jan. 13, 2017, 9:52 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55486/
> ---
> 
> (Updated Jan. 13, 2017, 9:52 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-19417
> https://issues.apache.org/jira/browse/AMBARI-19417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the livy configuration to enable hiveContext
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-env.xml
>  afb1d17 
> 
> Diff: https://reviews.apache.org/r/55486/diff/
> 
> 
> Testing
> ---
> 
> Tested maunally.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 55511: Ambari views : Adding new FileSystem support to views should work without code changes

2017-01-13 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55511/#review161558
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 13, 2017, 5:57 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55511/
> ---
> 
> (Updated Jan. 13, 2017, 5:57 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin 
> Rajeev.
> 
> 
> Bugs: AMBARI-19528
> https://issues.apache.org/jira/browse/AMBARI-19528
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Before this patch :
> Right now when new file-system support has to be added to views, we need to 
> add code to include several more key value pairs into the conf to make it 
> work.
> Usually these key value pairs are file-system class names, secret key and 
> access key.
> 
> In this patch:
> 1. load the complete core-site and hdfs-site into the conf for creating 
> filesystem. This will load any secret key, access key configured. It will 
> also load any other necessary parameters.
> 2. Create a new view setting's parameter per view which will have semi colon 
> separated key=value pairs that needs to be loaded into conf for connecting to 
> the filesystem. This will cover any extra parameters.
> 3. changes in pom.xml -> included Amazon S3 related jars and excluded 
> conflicting jars.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
> 10f216e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  6a4f04a 
>   ambari-views/src/main/java/org/apache/ambari/view/cluster/Cluster.java 
> 7f7c19b 
>   contrib/views/commons/pom.xml 4b7ee3a 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
>  bc3d11d 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/HdfsService.java
>  91eebcf 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java
>  97253ad 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UserService.java
>  dc303ce 
>   
> contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/ViewPropertyHelper.java
>  PRE-CREATION 
>   contrib/views/files/pom.xml ad9af4f 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
>  96d3541 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java
>  adaa6c9 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
>  051e40d 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
>  92af2d5 
>   contrib/views/files/src/main/resources/view.xml 640cee9 
>   contrib/views/hive-next/pom.xml 2e7beab 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/internal/HdfsApiSupplier.java
>  1cc1211 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java
>  654bfcc 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/SharedObjectsFactory.java
>  dd0b715 
>   contrib/views/hive-next/src/main/resources/view.xml 1107cd1 
>   contrib/views/hive20/pom.xml 6fc30f0 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java
>  e66b9ab 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/FileService.java
>  96e9554 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/files/FileService.java
>  a3623e9 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/utils/SharedObjectsFactory.java
>  5bc6070 
>   contrib/views/hive20/src/main/resources/view.xml 315d0a9 
>   contrib/views/jobs/src/main/resources/ui/.gitignore 503a8a9 
>   contrib/views/pig/pom.xml d7d2de9 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
>  509b20e 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/UserLocalObjects.java
>  8293899 
>   contrib/views/pig/src/main/resources/view.xml da8ffdd 
>   contrib/views/pom.xml 13cfb23 
>   contrib/views/utils/pom.xml c3cdab5 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  d505e9a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
>  c7ae952 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java
>  8bc3ca5 
>   contrib/views/wfmanager/pom.xml 95b988f

Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines

2017-01-13 Thread Xi Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55514/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-19536
https://issues.apache.org/jira/browse/AMBARI-19536


Repository: ambari


Description
---

Should do the following adjustments to integrate with the new style guidelines:

Step 2, as for the contents inside of the white panel:
1. Make the two radio buttons horizontally aligned.
2. Browse file button should be consistent with other buttons
3. Each section title should be readable. 

Step 3, 
3. "Remove Selected" should be right aligned, also disappear if nothing selected
Warning section should have some margin

Step 7,
5. Advanced configs, collapse of each category should be consistent with 
configs page after installed

Also, In general, the checkbox and radio buttons are not aligned with related 
text.


Diffs
-

  ambari-web/app/messages.js bd60f90 
  ambari-web/app/styles/theme/bootstrap-ambari.css 5b18417 
  ambari-web/app/styles/wizard.less b3a833d 
  ambari-web/app/templates/wizard/step1.hbs 6900624 
  ambari-web/app/templates/wizard/step2.hbs 4912851 
  ambari-web/app/templates/wizard/step3.hbs 2ba87e1 
  ambari-web/app/views/wizard/step2_view.js 719227d 

Diff: https://reviews.apache.org/r/55514/diff/


Testing
---

20236 passing (24s)
153 pending


Thanks,

Xi Wang

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161554
---




ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json 
(line 21)


Note that the "-" was moved into the principal_suffix value so that no 
suffix may be specified or the _separater_ may be removed or changed.


- Robert Levas


On Jan. 13, 2017, 1:14 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55513/
> ---
> 
> (Updated Jan. 13, 2017, 1:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19430
> https://issues.apache.org/jira/browse/AMBARI-19430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use common property for principal name prefix to help with customization of 
> unique principal names.  
> 
> All _headless_ Kerberos identities have a non-unique principal name (across 
> clusters). To help this issue, the cluster name is appended to these 
> principal names by adding "-${cluster-name|toLower()}" after the principal 
> name component. If the user wants to change this convention, they will need 
> to find all _headless_ principals and make the change. On top of that, when 
> adding new components, they will need to remember to make the change to new 
> _headless_ principal names. 
> 
> A better solution is to provide a _global_ property named "principal_suffix" 
> and use that in each _headless_ principal name. By default the value for this 
> property will be
> 
> ```
> principal_suffix="-${cluster_name|toLower()}"
> ```
> 
> If the user would like not use a prefix (in the event there is only a single 
> cluster connecting to the KDC), the value can be changed to
> 
> ```
> principal_suffix=""
> ```
> 
> Finally if the user would like to use some other randomizer, they can set the 
> value to something else. For example
> 
> ```
> principal_suffix="_12345"
> ```
> 
> The property is set in the Kerberos descriptor's "properties" block.   For 
> example:
> 
> ```
> {
>   "properties": {
> "realm": "${kerberos-env/realm}",
> ...,
> "principal_suffix": "-${cluster_name|toLower()}"
>   },
>   "identities": [
> ..., 
> {
>   "name": "smokeuser",
>   "principal": {
> "value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
> "type": "user",
> "configuration": "cluster-env/smokeuser_principal_name",
> "local_username": "${cluster-env/smokeuser}"
>   },
>   ...
> }
>   ],
>   "services": [
> {
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  d53205d 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  caef123 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  636d36e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 1dd801b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> fa6af33 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> e7f78cd 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 20e1dc0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> fcfe524 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 3068226 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  7c4c04c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json
>  9668354 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
>  20b10f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
>  678a2b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json
>  0fec0ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 9ed40ef 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> bd6c6c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> ae0d631 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> a16e2e1 
>

Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/
---

Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene 
Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-19430
https://issues.apache.org/jira/browse/AMBARI-19430


Repository: ambari


Description
---

Use common property for principal name prefix to help with customization of 
unique principal names.  

All _headless_ Kerberos identities have a non-unique principal name (across 
clusters). To help this issue, the cluster name is appended to these principal 
names by adding "-${cluster-name|toLower()}" after the principal name 
component. If the user wants to change this convention, they will need to find 
all _headless_ principals and make the change. On top of that, when adding new 
components, they will need to remember to make the change to new _headless_ 
principal names. 

A better solution is to provide a _global_ property named "principal_suffix" 
and use that in each _headless_ principal name. By default the value for this 
property will be

```
principal_suffix="-${cluster_name|toLower()}"
```

If the user would like not use a prefix (in the event there is only a single 
cluster connecting to the KDC), the value can be changed to

```
principal_suffix=""
```

Finally if the user would like to use some other randomizer, they can set the 
value to something else. For example

```
principal_suffix="_12345"
```

The property is set in the Kerberos descriptor's "properties" block.   For 
example:

```
{
  "properties": {
"realm": "${kerberos-env/realm}",
...,
"principal_suffix": "-${cluster_name|toLower()}"
  },
  "identities": [
..., 
{
  "name": "smokeuser",
  "principal": {
"value": "${cluster-env/smokeuser}${principal_suffix}@${realm}",
"type": "user",
"configuration": "cluster-env/smokeuser_principal_name",
"local_username": "${cluster-env/smokeuser}"
  },
  ...
}
  ],
  "services": [
{
```


Diffs
-

  
ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json 
d53205d 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
 caef123 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
636d36e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
f30c9e4 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
1dd801b 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
fa6af33 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
e7f78cd 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
20e1dc0 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
fcfe524 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
3068226 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
 7c4c04c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 9579d0f 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/kerberos.json 
9668354 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/HBASE/kerberos.json
 20b10f7 
  
ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/ACCUMULO/kerberos.json
 678a2b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/kerberos.json 
0fec0ab 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
9ed40ef 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
9000e95 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
bd6c6c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
ae0d631 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
a16e2e1 
  ambari-server/src/main/resources/stacks/HDP/3.0/kerberos.json 9579d0f 
  ambari-server/src/main/resources/stacks/PERF/1.0/kerberos.json a2a667b 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/kerberos.json 
3bf5fbd 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/kerberos.json 
ae84eaf 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/kerberos.json 
9ed40ef 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/kerberos.json 
974a69c 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/kerberos.json 
45e33f5 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/kerberos.json 
47a979a8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 91cd608 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
 5c2e74e

Review Request 55511: Ambari views : Adding new FileSystem support to views should work without code changes

2017-01-13 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55511/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin Rajeev.


Bugs: AMBARI-19528
https://issues.apache.org/jira/browse/AMBARI-19528


Repository: ambari


Description
---

Before this patch :
Right now when new file-system support has to be added to views, we need to add 
code to include several more key value pairs into the conf to make it work.
Usually these key value pairs are file-system class names, secret key and 
access key.

In this patch:
1. load the complete core-site and hdfs-site into the conf for creating 
filesystem. This will load any secret key, access key configured. It will also 
load any other necessary parameters.
2. Create a new view setting's parameter per view which will have semi colon 
separated key=value pairs that needs to be loaded into conf for connecting to 
the filesystem. This will cover any extra parameters.
3. changes in pom.xml -> included Amazon S3 related jars and excluded 
conflicting jars.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ClusterImpl.java 
10f216e 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 6a4f04a 
  ambari-views/src/main/java/org/apache/ambari/view/cluster/Cluster.java 
7f7c19b 
  contrib/views/commons/pom.xml 4b7ee3a 
  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 bc3d11d 
  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/HdfsService.java
 91eebcf 
  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java
 97253ad 
  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UserService.java
 dc303ce 
  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/ViewPropertyHelper.java
 PRE-CREATION 
  contrib/views/files/pom.xml ad9af4f 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
 96d3541 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java
 adaa6c9 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
 051e40d 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
 92af2d5 
  contrib/views/files/src/main/resources/view.xml 640cee9 
  contrib/views/hive-next/pom.xml 2e7beab 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/internal/HdfsApiSupplier.java
 1cc1211 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java
 654bfcc 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/SharedObjectsFactory.java
 dd0b715 
  contrib/views/hive-next/src/main/resources/view.xml 1107cd1 
  contrib/views/hive20/pom.xml 6fc30f0 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java
 e66b9ab 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/FileService.java
 96e9554 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/files/FileService.java
 a3623e9 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/utils/SharedObjectsFactory.java
 5bc6070 
  contrib/views/hive20/src/main/resources/view.xml 315d0a9 
  contrib/views/jobs/src/main/resources/ui/.gitignore 503a8a9 
  contrib/views/pig/pom.xml d7d2de9 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
 509b20e 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/UserLocalObjects.java
 8293899 
  contrib/views/pig/src/main/resources/view.xml da8ffdd 
  contrib/views/pom.xml 13cfb23 
  contrib/views/utils/pom.xml c3cdab5 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 d505e9a 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 c7ae952 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java
 8bc3ca5 
  contrib/views/wfmanager/pom.xml 95b988f 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/FileServices.java
 ab286b2 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
 327d8fc 
  contrib/views/wfmanager/src/main/resources/view.xml c5d4a5b 

Diff: https://reviews.apache.org/r/55511/diff/


Testing
---

manual testing done on amazon s3 cluster and normal hdfs cluster.


Thanks,

Nitiraj Rathore

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55481/
---

(Updated Jan. 13, 2017, 12:44 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
Hurley, and Tim Thorpe.


Changes
---

Updated link; waiting on another review for merging.


Bugs: AMBARI-19527
https://issues.apache.org/jira/browse/AMBARI-19527


Repository: ambari


Description
---

When creating the initial upgrade packs, an effort was made to make them as 
least-verbose as possible.  In that, we assumed that all tasks that occurred 
during an Upgrade would also occur on a Downgrade.  That assumption led to some 
sneaky bugs that are difficult to troubleshoot.

The real fix is to make the XSD enforce "sibling" elements, such that when 
PRE-UPGRADE tasks are defined, you can enforce that a PRE-DOWNGRADE element 
exist.  Unfortunately, the JDK (even 1.8) doesn't support that version of XSD 
in JAXB.

The interim solution was to use the afterUnmarshal secret sauce to validate 
that the elements exist.  Allow a pre-downgrade or post-downgrade element to 
indicate that it can reuse the (pre-post)upgrade element definitions.

Many of the changes here are in upgrade packs to add the new required elements, 
and the unit test that parses all upgrade packs passes.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
 d76d59f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 76f1897 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 0b9cb3d 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 d274135 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 8c9414a 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 fa6d46b 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 42918ff 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
a2286d8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
c082e3b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
ec317a9 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
a0a7929 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 b9a7e1e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 d22e94a 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 58ca724 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
968e3b7 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c61c39 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
9b3ce4e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 11c59e9 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 6bca487 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 78418b0 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
076b45b 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
4abf0ec 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
 e7aace9 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1c65f9b 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
eb4309a 
  ambari-server/src/main/resources/upgrade-pack.xsd 3963a2c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 50780e3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackParsingTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 d9b1dd6 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml
 8ca9df4 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_component_tasks_test.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml
 802a04c 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
 018dab3 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 
cba7685 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
 6476978 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
 9348aa5 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 f505220

Re: Review Request 55508: Host-Ordered Upgrade packs are named incorrectly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55508/#review161548
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 13, 2017, 12:15 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55508/
> ---
> 
> (Updated Jan. 13, 2017, 12:15 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-19533
> https://issues.apache.org/jira/browse/AMBARI-19533
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There is a mismatch to how the Host-Ordered upgrade packs are defined.  
> branch-2.5 is correct for one of them (2.5), but 2.6 needs to be renamed and 
> both files need to be renamed on trunk.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>   
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
>   
> 
> Diff: https://reviews.apache.org/r/55508/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/#review161547
---


Ship it!




- Robert Nettleton


On Jan. 13, 2017, 10:36 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55493/
> ---
> 
> (Updated Jan. 13, 2017, 10:36 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19521
> https://issues.apache.org/jira/browse/AMBARI-19521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search Add 'last 24 hours' to the time picker buttons
> 
> Also fixed the indentations by using consistently spaces instead of mixed 
> spaces and tabs.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js
>  924f92f 
> 
> Diff: https://reviews.apache.org/r/55493/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/#review161546
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 13, 2017, 10:36 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55493/
> ---
> 
> (Updated Jan. 13, 2017, 10:36 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19521
> https://issues.apache.org/jira/browse/AMBARI-19521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search Add 'last 24 hours' to the time picker buttons
> 
> Also fixed the indentations by using consistently spaces instead of mixed 
> spaces and tabs.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js
>  924f92f 
> 
> Diff: https://reviews.apache.org/r/55493/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55485: Log Search Troubleshooting tab should allow to multi select services

2017-01-13 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55485/#review161545
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 13, 2017, 9:51 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55485/
> ---
> 
> (Updated Jan. 13, 2017, 9:51 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19518
> https://issues.apache.org/jira/browse/AMBARI-19518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Customer may select multiple services on the Troubleshooting tab, and the set 
> of components should be additive. There will be two modes to select the 
> servies:
> 
> 1. Manual mode: the customer may add/remove components manually. If the 
> customer adds/deletes any service this mode would be active, though the 
> components still there would not be removed. Also all the selected service 
> buttons will be inactivated.
> 
> 2. Service button mode: the customer may select services with the service 
> buttons, and the components of the actually selected services would be in the 
> list. In manual mode if any service button is clicked then the service button 
> mode would be active immediately, and also the previous component list would 
> be removed.
> 
> Also fixed the indentations by using consistently spaces instead of mixed 
> spaces and tabs.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/bower/select2/select2.js
>  3b9251e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
>  b19f3ce 
> 
> Diff: https://reviews.apache.org/r/55485/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Sandor Magyari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review161541
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 11, 2017, 9:28 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55308/
> ---
> 
> (Updated Jan. 11, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Sandor 
> Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19414
> https://issues.apache.org/jira/browse/AMBARI-19414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid using `status_params` in `__init__`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  f9d5fce3fa864a6a987b1c007fd88f069dd8a02f 
> 
> Diff: https://reviews.apache.org/r/55308/diff/
> 
> 
> Testing
> ---
> 
> Manual test:
>  * create cluster with Accumulo via blueprint
>  * verify install and start are successful
>  * verify PID is logged:
> 
> ```
> $ grep -l 'bin/accumulo' out*txt | xargs tail -n 1
> ==> output-17.txt <==
> 2017-01-07 21:29:08,656 - Component has started with pid(s): 18166
> 
> ==> output-19.txt <==
> 2017-01-07 21:29:26,636 - Component has started with pid(s): 18568
> 
> ==> output-20.txt <==
> 2017-01-07 21:29:36,031 - Component has started with pid(s): 18792
> 
> ==> output-21.txt <==
> 2017-01-07 21:29:37,691 - Component has started with pid(s): 18893
> 
> ==> output-22.txt <==
> 2017-01-07 21:30:12,982 - Component has started with pid(s): 19816
> ```
> 
> Ran existing unit tests:
> 
> ```
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Laszlo Puskas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review161540
---


Ship it!




Ship It!

- Laszlo Puskas


On Jan. 11, 2017, 9:28 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55308/
> ---
> 
> (Updated Jan. 11, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Sandor 
> Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19414
> https://issues.apache.org/jira/browse/AMBARI-19414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Avoid using `status_params` in `__init__`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  f9d5fce3fa864a6a987b1c007fd88f069dd8a02f 
> 
> Diff: https://reviews.apache.org/r/55308/diff/
> 
> 
> Testing
> ---
> 
> Manual test:
>  * create cluster with Accumulo via blueprint
>  * verify install and start are successful
>  * verify PID is logged:
> 
> ```
> $ grep -l 'bin/accumulo' out*txt | xargs tail -n 1
> ==> output-17.txt <==
> 2017-01-07 21:29:08,656 - Component has started with pid(s): 18166
> 
> ==> output-19.txt <==
> 2017-01-07 21:29:26,636 - Component has started with pid(s): 18568
> 
> ==> output-20.txt <==
> 2017-01-07 21:29:36,031 - Component has started with pid(s): 18792
> 
> ==> output-21.txt <==
> 2017-01-07 21:29:37,691 - Component has started with pid(s): 18893
> 
> ==> output-22.txt <==
> 2017-01-07 21:30:12,982 - Component has started with pid(s): 19816
> ```
> 
> Ran existing unit tests:
> 
> ```
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55502/#review161538
---


Ship it!




Ship It!

- Robert Levas


On Jan. 13, 2017, 9:15 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55502/
> ---
> 
> (Updated Jan. 13, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19525
> https://issues.apache.org/jira/browse/AMBARI-19525
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19525: Unit Test failure during schema verification of configuration 
> files
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/configuration-schema.xsd 
> daba29fd3553abfda15cfece34f865d03c8b8646 
> 
> Diff: https://reviews.apache.org/r/55502/diff/
> 
> 
> Testing
> ---
> 
> ** mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5429 licence.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35.070s
> [INFO] Finished at: Fri Jan 13 06:14:23 PST 2017
> [INFO] Final Memory: 56M/632M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value



> On Jan. 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!
> 
> ping wang wrote:
> Hi Di, could you please help commit the code? Thanks!

Done. Please close this RB request.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components



> On Jan. 12, 2017, 10:55 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line 
> > 1551
> > 
> >
> > Please run without -DskipPythonTests flag

Updated unit test failure.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/#review161445
---


On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46268/
> ---
> 
> (Updated Jan. 13, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19044
> https://issues.apache.org/jira/browse/AMBARI-19044
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari provides a single toggle button to enable Ranger plugins 
> for a component. Plugin enabled results in a bunch of configuration which are 
> created on backend which are tighly coupled with Ranger admin installed on 
> the same cluster.
> 
> Need to make sure plugins communicate to Ranger admin which is installed on 
> separate cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  05510cd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  6561928 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cb509cd 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  9373f17 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  f5d7f38 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  8eed2d5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  0d73e39 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f804851 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  e3aff9d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  81a4e3e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  82849c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  528dec2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
>  b4c0790 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
>  3949402 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
>  cf4a82e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
>  91061d1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  ae9314b 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d245178 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  7601dfa 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
>  95e653c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  4dc51eb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  b1f6e1e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  983702f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  e81d62a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  017df91 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  3117139 
>   
>

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components



> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote:
> > ambari-web/app/controllers/main/service/info/configs.js, line 518
> > 
> >
> > Is this supposed to be part of the fix?

Yes we need to revert the earlier UI implementation to show all the ranger 
plugin configs even if rabger is not installed.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/#review161439
---


On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46268/
> ---
> 
> (Updated Jan. 13, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19044
> https://issues.apache.org/jira/browse/AMBARI-19044
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari provides a single toggle button to enable Ranger plugins 
> for a component. Plugin enabled results in a bunch of configuration which are 
> created on backend which are tighly coupled with Ranger admin installed on 
> the same cluster.
> 
> Need to make sure plugins communicate to Ranger admin which is installed on 
> separate cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  05510cd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  6561928 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cb509cd 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  9373f17 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  f5d7f38 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  8eed2d5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  0d73e39 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f804851 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  e3aff9d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  81a4e3e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  82849c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  528dec2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
>  b4c0790 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
>  3949402 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
>  cf4a82e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
>  91061d1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  ae9314b 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d245178 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  7601dfa 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
>  95e653c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  4dc51eb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  b1f6e1e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  983702f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  e81d62a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  017df91 
>   
>

Re: Review Request 55503: AMBARI-19526 : Ambari should mark oozie servers to be restarted when atlas hook configs or jars change.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55503/#review161535
---


Ship it!




Ship It!

- Mugdha Varadkar


On Jan. 13, 2017, 3:28 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55503/
> ---
> 
> (Updated Jan. 13, 2017, 3:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19526
> https://issues.apache.org/jira/browse/AMBARI-19526
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When making atlas config or jars change, oozie sharelib needs to be updated 
> for hive and Oozie should be marked for restart.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/metainfo.xml 
> 6392ed4 
> 
> Diff: https://reviews.apache.org/r/55503/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on centos-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components



> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote:
> > ambari-web/app/controllers/wizard/step7_controller.js, line 539
> > 
> >
> > Is this supposed to be part of the fix?

Yes we need to revert the earlier UI implementation to show all the ranger 
plugin configs even if rabger is not installed.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/#review161439
---


On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46268/
> ---
> 
> (Updated Jan. 13, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19044
> https://issues.apache.org/jira/browse/AMBARI-19044
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari provides a single toggle button to enable Ranger plugins 
> for a component. Plugin enabled results in a bunch of configuration which are 
> created on backend which are tighly coupled with Ranger admin installed on 
> the same cluster.
> 
> Need to make sure plugins communicate to Ranger admin which is installed on 
> separate cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  05510cd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  6561928 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cb509cd 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  9373f17 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  f5d7f38 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  8eed2d5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  0d73e39 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f804851 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  e3aff9d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  81a4e3e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  82849c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  528dec2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
>  b4c0790 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
>  3949402 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
>  cf4a82e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
>  91061d1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  ae9314b 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d245178 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  7601dfa 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
>  95e653c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  4dc51eb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  b1f6e1e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  983702f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  e81d62a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  017df91 
>   
>

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components



> On Jan. 12, 2017, 10:57 p.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly on latest trunk. Can you update the patch?

@Jayush I have attached the latest patch for trunk on 
https://issues.apache.org/jira/secure/attachment/12847349/AMBARI-19044.2.trunk.patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/#review161446
---


On Jan. 13, 2017, 3:33 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46268/
> ---
> 
> (Updated Jan. 13, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19044
> https://issues.apache.org/jira/browse/AMBARI-19044
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, Ambari provides a single toggle button to enable Ranger plugins 
> for a component. Plugin enabled results in a bunch of configuration which are 
> created on backend which are tighly coupled with Ranger admin installed on 
> the same cluster.
> 
> Need to make sure plugins communicate to Ranger admin which is installed on 
> separate cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  05510cd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  6561928 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  cb509cd 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  9373f17 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  f5d7f38 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  8eed2d5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  0d73e39 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f804851 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  e3aff9d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a515b62 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  81a4e3e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  82849c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  528dec2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
>  b4c0790 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
>  3949402 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
>  cf4a82e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
>  91061d1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  ae9314b 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d245178 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  7601dfa 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
>  95e653c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  4dc51eb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  b1f6e1e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  983702f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  c167d7c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  e81d62a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  017df91 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  3117139 
>   
>

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/
---

(Updated Jan. 13, 2017, 3:33 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Updated patch with latest changes


Bugs: AMBARI-19044
https://issues.apache.org/jira/browse/AMBARI-19044


Repository: ambari


Description
---

Currently, Ambari provides a single toggle button to enable Ranger plugins for 
a component. Plugin enabled results in a bunch of configuration which are 
created on backend which are tighly coupled with Ranger admin installed on the 
same cluster.

Need to make sure plugins communicate to Ranger admin which is installed on 
separate cluster.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 05510cd 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 6561928 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 cb509cd 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 9373f17 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
 f5d7f38 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 8eed2d5 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 0d73e39 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 f804851 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 e3aff9d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a515b62 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 81a4e3e 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 82849c8 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 528dec2 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml
 b4c0790 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
 3949402 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml
 cf4a82e 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml
 91061d1 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
 ae9314b 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 d245178 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 7601dfa 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml
 95e653c 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
 4dc51eb 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
 b1f6e1e 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
 983702f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 c167d7c 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 e81d62a 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-plugin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 017df91 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 3117139 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
 6ea7f82 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 bb7f596 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
 960c751 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
 c57c5f0 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
 830c539 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml
 d5880dd 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
cf7134e

Review Request 55503: AMBARI-19526 : Ambari should mark oozie servers to be restarted when atlas hook configs or jars change.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55503/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-19526
https://issues.apache.org/jira/browse/AMBARI-19526


Repository: ambari


Description
---

When making atlas config or jars change, oozie sharelib needs to be updated for 
hive and Oozie should be marked for restart.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/metainfo.xml 
6392ed4 

Diff: https://reviews.apache.org/r/55503/diff/


Testing
---

Verified fresh installation on centos-6.


Thanks,

Vishal Suvagia

Re: Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55502/#review161527
---


Ship it!




Ship It!

- Nate Cole


On Jan. 13, 2017, 9:15 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55502/
> ---
> 
> (Updated Jan. 13, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19525
> https://issues.apache.org/jira/browse/AMBARI-19525
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19525: Unit Test failure during schema verification of configuration 
> files
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/configuration-schema.xsd 
> daba29fd3553abfda15cfece34f865d03c8b8646 
> 
> Diff: https://reviews.apache.org/r/55502/diff/
> 
> 
> Testing
> ---
> 
> ** mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5429 licence.
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
> [INFO] skipping execute as per configuraion
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35.070s
> [INFO] Finished at: Fri Jan 13 06:14:23 PST 2017
> [INFO] Final Memory: 56M/632M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55502/
---

Review request for Ambari, Dmytro Grinenko, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-19525
https://issues.apache.org/jira/browse/AMBARI-19525


Repository: ambari


Description
---

AMBARI-19525: Unit Test failure during schema verification of configuration 
files


Diffs
-

  ambari-server/src/main/resources/configuration-schema.xsd 
daba29fd3553abfda15cfece34f865d03c8b8646 

Diff: https://reviews.apache.org/r/55502/diff/


Testing
---

** mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5429 licence.
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
[INFO] skipping execute as per configuraion
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 35.070s
[INFO] Finished at: Fri Jan 13 06:14:23 PST 2017
[INFO] Final Memory: 56M/632M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55481: Downgrade executes section if is not defined


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55481/#review161525
---


Ship it!




Sweet! This should really help prevent unwanted configurations and python 
actions in downgrades ...


ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
 (lines 139 - 146)


Unit tests will parse all _real_ upgrade packs, right? Not just the ones in 
`test/resources` ? Just want to make sure a `mvn test` will exercise this stuff 
:)



ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 (lines 531 - 540)


Hah! Neat idea to use the JAXB hooks to overcome the limitations!


- Jonathan Hurley


On Jan. 12, 2017, 8:42 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55481/
> ---
> 
> (Updated Jan. 12, 2017, 8:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
> Hurley, and Tim Thorpe.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When creating the initial upgrade packs, an effort was made to make them as 
> least-verbose as possible.  In that, we assumed that all tasks that occurred 
> during an Upgrade would also occur on a Downgrade.  That assumption led to 
> some sneaky bugs that are difficult to troubleshoot.
> 
> The real fix is to make the XSD enforce "sibling" elements, such that when 
> PRE-UPGRADE tasks are defined, you can enforce that a PRE-DOWNGRADE element 
> exist.  Unfortunately, the JDK (even 1.8) doesn't support that version of XSD 
> in JAXB.
> 
> The interim solution was to use the afterUnmarshal secret sauce to validate 
> that the elements exist.  Allow a pre-downgrade or post-downgrade element to 
> indicate that it can reuse the (pre-post)upgrade element definitions.
> 
> Many of the changes here are in upgrade packs to add the new required 
> elements, and the unit test that parses all upgrade packs passes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
>  d76d59f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  76f1897 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  0b9cb3d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d274135 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  8c9414a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  fa6d46b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  42918ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> a2286d8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> c082e3b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ec317a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a0a7929 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b9a7e1e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  d22e94a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  58ca724 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 968e3b7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c61c39 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9b3ce4e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  11c59e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  6bca487 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  78418b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 076b45b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 4abf0ec 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
>  e7aace9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  1c65f9b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> eb4309a 
>   ambari-server/src/main/resources/upgrade-pack.xsd 3963a2c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  50780e3 
>   
>

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/#review161523
---




ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (line 219)


r is not a very descriptive variable name.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (line 226)


I don't think you want "desiredConfig" here - at the point where this runs 
in the upgrade, desired configurations are already moved to the new stack. That 
could cause invalid replacements.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (lines 226 - 239)


This should be done in a try/catch since an errors here will break the 
whole upgrade.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (line 233)


Neither is m :)



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (lines 234 - 235)


Formatting looks off here.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 (line 469)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 (line 217)


Can you move the comment above the area of code it's annotating.



ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
(line 63)


Can you include a slightly more specific message, like "Parameterizing 
ZooKeeper Log4J Properties"



ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 (line 301)


Can you make these titles a little more descriptive? Such as 
"Parameterizing Oozie Log4J Properties"



ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 (lines 301 - 305)


Can you make these titles a little more descriptive? Such as 
"Parameterizing Oozie Log4J Properties" and "Updating the Oozie Log4J 
properties to include parameterizations"


- Jonathan Hurley


On Jan. 12, 2017, 6:27 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55478/
> ---
> 
> (Updated Jan. 12, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle HDP upgrade scenario
> Changes:
> 1. Add a new task called "regex-replace" for configure-upgrade.xml
> 2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 9ddb667 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  7ccd96d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> abd8fb9 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
> 
> Diff: https://reviews.apache.org/r/55478/diff/
> 
> 
> Testing
> ---
> 
> NonRolling Upgrade path 2.5-2.6
> -Verified that the log4j changes appear for 
> (HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario



> On Jan. 12, 2017, 8:20 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml,
> >  line 173
> > 
> >
> > INFRA_SOLR is not part of the HDP upgrade (instead of that: Ambari 
> > upgrade), also the changes have already done in UpgradeCatalog250 for 
> > INFRA_SOLR and LOGSEARCH
> 
> Aravindan Vijayan wrote:
> AMS should not be part of HDP upgrade as well.

That's a tough call - most Ambari upgrade windows do not allow for service 
outage, which includes things like AMS and LogSearch, so when an organization 
upgrades Ambari and then sees stale configurations, they aren't able to simply 
restart those services. I think that's why this work was put into the HDP 
upgrade packs.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55478/#review161474
---


On Jan. 12, 2017, 6:27 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55478/
> ---
> 
> (Updated Jan. 12, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle HDP upgrade scenario
> Changes:
> 1. Add a new task called "regex-replace" for configure-upgrade.xml
> 2. Add log4j changes for each service in upgrade-<>.xml and nonrolling-<>.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  5428ea7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  d7bb338 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 9ddb667 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  7ccd96d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> abd8fb9 
>   ambari-server/src/main/resources/upgrade-config.xsd e274451 
> 
> Diff: https://reviews.apache.org/r/55478/diff/
> 
> 
> Testing
> ---
> 
> NonRolling Upgrade path 2.5-2.6
> -Verified that the log4j changes appear for 
> (HDFS,YARN,ZOOKEEPER,AMS,OOZIE,KNOX,KAFKA,HBASE,FALCON) services.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55083: AMBARI-19029 : Atlas web UI inaccessible alert after enabling Namenode-HA.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55083/
---

(Updated Jan. 13, 2017, 1:42 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Changes
---

Updated patch to add dependency of restarting Atlas on hdfs-site changes


Bugs: AMBARI-19029
https://issues.apache.org/jira/browse/AMBARI-19029


Repository: ambari


Description
---

After enabling Namenode-HA, atlas had a critical alert that "This host-level 
alert is triggered if the Metadata Server Web UI is unreachable."

As a fix we need to include hdfs-site.xml in Atlas conf directory classpath 
when Namenode-HA is enabled.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 05510cd 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a568cb7 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 4b7bd3c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 bb7f596 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
eaa5e21 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
f2fec70 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 

Diff: https://reviews.apache.org/r/55083/diff/


Testing
---

Verified fresh install on Cent-OS 6.

test_service_check (test_service_check.TestAtlasCheck) ... 2017-01-12 
19:24:26,791 - Stack Feature Version Info: stack_version=2.3, 
version=2.2.1.0-2067, current_cluster_version=None -> 2.2.1.0-2067
2017-01-12 19:24:26,795 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok
2017-01-12 19:24:26,806 - Stack Feature Version Info: stack_version=2.3, 
version=2.2.1.0-2067, current_cluster_version=None -> 2.2.1.0-2067
test_service_check_secure (test_service_check.TestAtlasCheck) ... 2017-01-12 
19:24:26,809 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf
ok

test_configure_default (test_atlas_server.TestAtlasServer) ... 2017-01-12 
19:24:51,208 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
2017-01-12 19:24:51,212 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2017-01-12 19:24:51,230 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
ok
test_security_status (test_atlas_server.TestAtlasServer) ... 2017-01-12 
19:24:51,245 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-1235, current_cluster_version=None -> 2.5.0.0-1235
2017-01-12 19:24:51,249 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok


Thanks,

Vishal Suvagia

Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55501/
---

(Updated Jan. 13, 2017, 1:42 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19522
https://issues.apache.org/jira/browse/AMBARI-19522


Repository: ambari


Description
---

Saving worksheet as saved query and Export query results featutes


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad 
  contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
b42c495 
  
contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 
17df66d 
  contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
5eac78a 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 8719170 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d 
  contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 441352e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs
 PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
371f404 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
b776fd2 

Diff: https://reviews.apache.org/r/55501/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 55469: Hive Metastore process cannot be determined to be up and listening on the network


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55469/#review161521
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 12, 2017, 4:55 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55469/
> ---
> 
> (Updated Jan. 12, 2017, 4:55 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit 
> Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Metastore process cannot be determined to be up and listening on the 
> network , alert is on for same for long time .
> 
> hive metastore log is having following error:
> 
> 2017-01-11 19:59:00,171 ERROR [pool-7-thread-200]: server.TThreadPoolServer 
> (TThreadPoolServer.java:run(297)) - Error occurred during processing of 
> message.
> java.lang.RuntimeException: org.apache.thrift.transport.TTransportException: 
> Invalid status -128
> 
> In health check command, HIVE_CONF_DIR is being set to the conf.server 
> directory, which ambari-qa user doesn't have access to. It should be set to 
> /usr/hdp/current/hive-metastore/conf instead.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  0873730 
> 
> Diff: https://reviews.apache.org/r/55469/diff/
> 
> 
> Testing
> ---
> 
> Mnaually verified.
> Unit test passed except unlrelated RANGER_KMS/test_kms_server.py
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55501/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19522
https://issues.apache.org/jira/browse/AMBARI-19522


Repository: ambari


Description
---

Saving worksheet as saved query and Export query results featutes


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 8ccd7ad 
  contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
b42c495 
  
contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 
17df66d 
  contrib/views/hive20/src/main/resources/ui/app/components/save-hdfs.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/saved-query.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js d254ed1 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 2346345 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
5eac78a 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 8719170 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 4928e5c 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js 5a2f62d 
  contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6bf8e5a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 441352e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs
 PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
371f404 
  contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs 3575ec1 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
b776fd2 

Diff: https://reviews.apache.org/r/55501/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 55485: Log Search Troubleshooting tab should allow to multi select services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55485/#review161513
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 13, 2017, 9:51 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55485/
> ---
> 
> (Updated Jan. 13, 2017, 9:51 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19518
> https://issues.apache.org/jira/browse/AMBARI-19518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Customer may select multiple services on the Troubleshooting tab, and the set 
> of components should be additive. There will be two modes to select the 
> servies:
> 
> 1. Manual mode: the customer may add/remove components manually. If the 
> customer adds/deletes any service this mode would be active, though the 
> components still there would not be removed. Also all the selected service 
> buttons will be inactivated.
> 
> 2. Service button mode: the customer may select services with the service 
> buttons, and the components of the actually selected services would be in the 
> list. In manual mode if any service button is clicked then the service button 
> mode would be active immediately, and also the previous component list would 
> be removed.
> 
> Also fixed the indentations by using consistently spaces instead of mixed 
> spaces and tabs.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/bower/select2/select2.js
>  3b9251e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
>  b19f3ce 
> 
> Diff: https://reviews.apache.org/r/55485/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/
---

(Updated Jan. 13, 2017, 12:40 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

increase service check tries (because logsearch now responsible to upload 
configurations...do more things during startup)


Bugs: AMBARI-19468
https://issues.apache.org/jira/browse/AMBARI-19468


Repository: ambari


Description
---

- added setAcl operation inside logsearch code
- added reload collection command (on schema or solrconfig change)
- removed logsearch solr client dependency
- refactor some methods to handlers in collection dao
- removed upload configurations call from ambari logsearch stack code.
- enable ACL security for Log Search / Infra Solr
- fixed jinja template generation in solr-client log4j config


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 2e48c6a 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 d270b13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 82dd7df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 f80d6e5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 d78ff0da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 da76924 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/SolrZkRequestHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 fa6162a 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java
 b144b41 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureSolrZNodeZkCommand.java
 faa21d4 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java
 8e0132d 
  ambari-logsearch/docker/bin/start.sh 81c9e66 
  ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
1bd8c70 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 71c1a1c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/infra_solr.py
 532be47 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 946cf15 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 740c560 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5ffd5e6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 30a1cda 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9ff9c74 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
f2fec70 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 33ac715 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
4510f4b 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
9144f12 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
e517e3a 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
a04f9f8 

Diff: https://reviews.apache.org/r/55429/diff/


Testing
---

done. mostly manually

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/#review161511
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 13, 2017, 10:36 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55493/
> ---
> 
> (Updated Jan. 13, 2017, 10:36 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19521
> https://issues.apache.org/jira/browse/AMBARI-19521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search Add 'last 24 hours' to the time picker buttons
> 
> Also fixed the indentations by using consistently spaces instead of mixed 
> spaces and tabs.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js
>  924f92f 
> 
> Diff: https://reviews.apache.org/r/55493/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55492: Log Feeder should store keystore / truststore passwords in files


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55492/#review161510
---


Ship it!




Ship It!

- Oliver Szabo


On Jan. 13, 2017, 10:52 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55492/
> ---
> 
> (Updated Jan. 13, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19519
> https://issues.apache.org/jira/browse/AMBARI-19519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder should not put the passwords of the keystore/truststore in the 
> command line, as it may be visible to others. Instead it should be in a file, 
> just like for Log Search Portal.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  6d0f22c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 5aecd00 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5ffd5e6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  14f8d20 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  9ff9c74 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
>  6795dab 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 02570e2 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 30e12e9 
> 
> Diff: https://reviews.apache.org/r/55492/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55481/#review161508
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 13, 2017, 1:42 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55481/
> ---
> 
> (Updated Jan. 13, 2017, 1:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
> Hurley, and Tim Thorpe.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When creating the initial upgrade packs, an effort was made to make them as 
> least-verbose as possible.  In that, we assumed that all tasks that occurred 
> during an Upgrade would also occur on a Downgrade.  That assumption led to 
> some sneaky bugs that are difficult to troubleshoot.
> 
> The real fix is to make the XSD enforce "sibling" elements, such that when 
> PRE-UPGRADE tasks are defined, you can enforce that a PRE-DOWNGRADE element 
> exist.  Unfortunately, the JDK (even 1.8) doesn't support that version of XSD 
> in JAXB.
> 
> The interim solution was to use the afterUnmarshal secret sauce to validate 
> that the elements exist.  Allow a pre-downgrade or post-downgrade element to 
> indicate that it can reuse the (pre-post)upgrade element definitions.
> 
> Many of the changes here are in upgrade packs to add the new required 
> elements, and the unit test that parses all upgrade packs passes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
>  d76d59f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  76f1897 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  0b9cb3d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d274135 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  8c9414a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  fa6d46b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  42918ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> a2286d8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> c082e3b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ec317a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a0a7929 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b9a7e1e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  d22e94a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  58ca724 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 968e3b7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c61c39 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9b3ce4e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  11c59e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  6bca487 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  78418b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 076b45b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 4abf0ec 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
>  e7aace9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  1c65f9b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> eb4309a 
>   ambari-server/src/main/resources/upgrade-pack.xsd 3963a2c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  50780e3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackParsingTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  d9b1dd6 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml
>  8ca9df4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_component_tasks_test.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml
>  802a04c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
>  018dab3 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-13 Thread ping wang



> On 一月 11, 2017, 7:18 p.m., Alejandro Fernandez wrote:
> > Ship It!

Hi Alejandro, thank you very much for your approval!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review161286
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-13 Thread ping wang



> On 一月 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!

Hi Di, could you please help commit the code? Thanks!


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---


On 十二月 24, 2016, 7:12 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

2017-01-13 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55494/#review161502
---


Ship it!




Ship It!

- Attila Doroszlai


On Jan. 13, 2017, 11:50 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55494/
> ---
> 
> (Updated Jan. 13, 2017, 11:50 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-19520
> https://issues.apache.org/jira/browse/AMBARI-19520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> 
> In case ambari server is restarted after restart will ask agents to 
> re-register with the server.
> Once the agent successfully re-registered with the server it should be 
> transition out from heartbeat lost state. However in some cases it takes a 
> while until agents transition out from heartbeat lost state thus the server 
> may request the agent to re-register again.
> 
> Solution:
> Ensure upon agent re-regsitration that StatusCommandExecutor child process is 
> spawned before status commands received from the server (in the response to 
> the registration) are added to the status command queue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 6b1b196 
>   ambari-agent/src/main/python/ambari_agent/main.py 2e0517b 
> 
> Diff: https://reviews.apache.org/r/55494/diff/
> 
> 
> Testing
> ---
> 
> Manually tested covering:
> 1. Restart agent
> 2. Restart amabari-server with agents being up and running
> 3. Kill StatusCommandExecutor child process
> 
> Unit test results:
> 
> Total run:1158
> Total errors:0
> Total failures:0
> OK
> 
> Ran 452 tests in 20.976s
> 
> OK
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [10.142s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.029s]
> [INFO] Ambari Views .. SUCCESS [1.707s]
> [INFO] utility ... SUCCESS [1.189s]
> [INFO] ambari-metrics  SUCCESS [0.473s]
> [INFO] Ambari Metrics Common . SUCCESS [1.012s]
> [INFO] Ambari Server . SUCCESS [1:45.492s]
> [INFO] Ambari Agent .. SUCCESS [25.860s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 55492: Log Feeder should store keystore / truststore passwords in files


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55492/
---

(Updated Jan. 13, 2017, 10:52 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Updated unit tests


Bugs: AMBARI-19519
https://issues.apache.org/jira/browse/AMBARI-19519


Repository: ambari


Description
---

Log Feeder should not put the passwords of the keystore/truststore in the 
command line, as it may be visible to others. Instead it should be in a file, 
just like for Log Search Portal.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 6d0f22c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 5aecd00 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5ffd5e6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 14f8d20 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9ff9c74 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
 6795dab 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 02570e2 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 30e12e9 

Diff: https://reviews.apache.org/r/55492/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

2017-01-13 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55494/
---

Review request for Ambari, Attila Doroszlai, Andrew Onischuk, and Sandor 
Magyari.


Bugs: AMBARI-19520
https://issues.apache.org/jira/browse/AMBARI-19520


Repository: ambari


Description
---

Problem:

In case ambari server is restarted after restart will ask agents to re-register 
with the server.
Once the agent successfully re-registered with the server it should be 
transition out from heartbeat lost state. However in some cases it takes a 
while until agents transition out from heartbeat lost state thus the server may 
request the agent to re-register again.

Solution:
Ensure upon agent re-regsitration that StatusCommandExecutor child process is 
spawned before status commands received from the server (in the response to the 
registration) are added to the status command queue.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 6b1b196 
  ambari-agent/src/main/python/ambari_agent/main.py 2e0517b 

Diff: https://reviews.apache.org/r/55494/diff/


Testing
---

Manually tested covering:
1. Restart agent
2. Restart amabari-server with agents being up and running
3. Kill StatusCommandExecutor child process

Unit test results:

Total run:1158
Total errors:0
Total failures:0
OK

Ran 452 tests in 20.976s

OK

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [10.142s]
[INFO] Apache Ambari Project POM . SUCCESS [0.029s]
[INFO] Ambari Views .. SUCCESS [1.707s]
[INFO] utility ... SUCCESS [1.189s]
[INFO] ambari-metrics  SUCCESS [0.473s]
[INFO] Ambari Metrics Common . SUCCESS [1.012s]
[INFO] Ambari Server . SUCCESS [1:45.492s]
[INFO] Ambari Agent .. SUCCESS [25.860s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Sebastian Toader

Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19521
https://issues.apache.org/jira/browse/AMBARI-19521


Repository: ambari


Description
---

Log Search Add 'last 24 hours' to the time picker buttons

Also fixed the indentations by using consistently spaces instead of mixed 
spaces and tabs.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js 
924f92f 

Diff: https://reviews.apache.org/r/55493/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Review Request 55492: Log Feeder should store keystore / truststore passwords in files


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55492/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19519
https://issues.apache.org/jira/browse/AMBARI-19519


Repository: ambari


Description
---

Log Feeder should not put the passwords of the keystore/truststore in the 
command line, as it may be visible to others. Instead it should be in a file, 
just like for Log Search Portal.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
 6d0f22c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 5aecd00 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5ffd5e6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 14f8d20 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9ff9c74 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
 6795dab 

Diff: https://reviews.apache.org/r/55492/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Review Request 55486: AMBARI-19417. Enable hiveContext in Livy

2017-01-13 Thread Jeff Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55486/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-19417
https://issues.apache.org/jira/browse/AMBARI-19417


Repository: ambari


Description
---

Update the livy configuration to enable hiveContext


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
 b7bfa73 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
 457869d 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-env.xml
 afb1d17 

Diff: https://reviews.apache.org/r/55486/diff/


Testing
---

Tested maunally.


Thanks,

Jeff Zhang

Review Request 55485: Log Search Troubleshooting tab should allow to multi select services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55485/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19518
https://issues.apache.org/jira/browse/AMBARI-19518


Repository: ambari


Description
---

Customer may select multiple services on the Troubleshooting tab, and the set 
of components should be additive. There will be two modes to select the servies:

1. Manual mode: the customer may add/remove components manually. If the 
customer adds/deletes any service this mode would be active, though the 
components still there would not be removed. Also all the selected service 
buttons will be inactivated.

2. Service button mode: the customer may select services with the service 
buttons, and the components of the actually selected services would be in the 
list. In manual mode if any service button is clicked then the service button 
mode would be active immediately, and also the previous component list would be 
removed.

Also fixed the indentations by using consistently spaces instead of mixed 
spaces and tabs.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/bower/select2/select2.js
 3b9251e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
 b19f3ce 

Diff: https://reviews.apache.org/r/55485/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.

2017-01-13 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55444/#review161497
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 12, 2017, 6:49 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55444/
> ---
> 
> (Updated Jan. 12, 2017, 6:49 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19478
> https://issues.apache.org/jira/browse/AMBARI-19478
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Scenario - During import Workflow.
> If any of the action contains configuration that the workflow designer does 
> not understand(eg. streaming in map-reduce), the action editor should warn 
> the users and show a text area for manually editing the configuration
> The configuration should be taken into consideration while the final workflow 
> xml is generated.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 
> 7390205 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  8ee5a0a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 99d96ac 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/custom-mapping-handler.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> d4d8f50 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  527badf 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
>  b9e4307 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less dcf2905 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  069c052 
> 
> Diff: https://reviews.apache.org/r/55444/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55481/#review161495
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 13, 2017, 3:42 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55481/
> ---
> 
> (Updated Jan. 13, 2017, 3:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
> Hurley, and Tim Thorpe.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When creating the initial upgrade packs, an effort was made to make them as 
> least-verbose as possible.  In that, we assumed that all tasks that occurred 
> during an Upgrade would also occur on a Downgrade.  That assumption led to 
> some sneaky bugs that are difficult to troubleshoot.
> 
> The real fix is to make the XSD enforce "sibling" elements, such that when 
> PRE-UPGRADE tasks are defined, you can enforce that a PRE-DOWNGRADE element 
> exist.  Unfortunately, the JDK (even 1.8) doesn't support that version of XSD 
> in JAXB.
> 
> The interim solution was to use the afterUnmarshal secret sauce to validate 
> that the elements exist.  Allow a pre-downgrade or post-downgrade element to 
> indicate that it can reuse the (pre-post)upgrade element definitions.
> 
> Many of the changes here are in upgrade packs to add the new required 
> elements, and the unit test that parses all upgrade packs passes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
>  d76d59f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  76f1897 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  0b9cb3d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d274135 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  8c9414a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  fa6d46b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  42918ff 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> a2286d8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> c082e3b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ec317a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a0a7929 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b9a7e1e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  d22e94a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  58ca724 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 968e3b7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c61c39 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 9b3ce4e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  11c59e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  6bca487 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  78418b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 076b45b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 4abf0ec 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
>  e7aace9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  1c65f9b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> eb4309a 
>   ambari-server/src/main/resources/upgrade-pack.xsd 3963a2c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  50780e3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackParsingTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  d9b1dd6 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml
>  8ca9df4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_component_tasks_test.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml
>  802a04c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
>  018dab3 
>

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55007/
---

(Updated Jan. 13, 2017, 9:32 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Madhan Neethiraj, Mugdha Varadkar, and Oliver Szabo.


Changes
---

Updated code to remove unnecessary parenthesis.


Bugs: AMBARI-19288
https://issues.apache.org/jira/browse/AMBARI-19288


Repository: ambari


Description
---

Currently, for 2.5 and 2.6 stacks, there a call to install hive-hook if Falcon 
client is installed.Need to remove that dependency.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 6fba224 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 d7981e1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 a753f89 

Diff: https://reviews.apache.org/r/55007/diff/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed