Re: Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/#review173871
---


Ship it!




Ship It!

- Mugdha Varadkar


On May 3, 2017, 3:12 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58965/
> ---
> 
> (Updated May 3, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20920
> https://issues.apache.org/jira/browse/AMBARI-20920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
> the commands will be scheduled appropriately. These should be captured in 
> (role command order) for Atlas.
> 
> PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
> AMBARI-20920 Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 58dcf8d 
> 
> 
> Diff: https://reviews.apache.org/r/58965/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58978: Ranger Quick links not showing load balancer in Ranger-admin HA

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58978/#review173852
---


Ship it!




Ship It!

- Richard Zang


On May 3, 2017, 11:24 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58978/
> ---
> 
> (Updated May 3, 2017, 11:24 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20926
> https://issues.apache.org/jira/browse/AMBARI-20926
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Quick links not pointing to load balancer URL when ranger HA is 
> enabled. Quick links pointing to http://:6080 port.
> 
> Ambari affected: 2.4.2 and 2.5.0.3
> 
> Prior to ambari upgrade in 2.2.2, quicklink was showing only the Ranger 
> loadbalancer UI. After upgrading to 2.4.2, it showing both ranger admin URLs 
> instead of the load balancer URL in quicklinks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/quick_view_link_view.js 86a7cb9b5e 
>   ambari-web/test/views/common/quick_link_view_test.js 71790782d1 
> 
> 
> Diff: https://reviews.apache.org/r/58978/diff/1/
> 
> 
> Testing
> ---
> 
> 30380 passing (34s)
> 157 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 58978: Ranger Quick links not showing load balancer in Ranger-admin HA

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58978/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-20926
https://issues.apache.org/jira/browse/AMBARI-20926


Repository: ambari


Description
---

Ranger Quick links not pointing to load balancer URL when ranger HA is enabled. 
Quick links pointing to http://:6080 port.

Ambari affected: 2.4.2 and 2.5.0.3

Prior to ambari upgrade in 2.2.2, quicklink was showing only the Ranger 
loadbalancer UI. After upgrading to 2.4.2, it showing both ranger admin URLs 
instead of the load balancer URL in quicklinks.


Diffs
-

  ambari-web/app/views/common/quick_view_link_view.js 86a7cb9b5e 
  ambari-web/test/views/common/quick_link_view_test.js 71790782d1 


Diff: https://reviews.apache.org/r/58978/diff/1/


Testing
---

30380 passing (34s)
157 pending


Thanks,

Xi Wang

Re: Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/
---

(Updated May 3, 2017, 5:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, and Nate 
Cole.


Changes
---

Added unit test


Bugs: AMBARI-20924
https://issues.apache.org/jira/browse/AMBARI-20924


Repository: ambari


Description
---

Possibly caused by AMBARI-20750:

Upgrades are failing because of a {{VERSION_MISMATCH}} between all components 
of the upgrade. Initially, on restart, the version comes back correct and the 
host component transitions into {{COMPLETED}}. 

However, the following status command returns the old version, forcing the 
component back into the {{VERSION_MISMATCH}} state.

What's odd is that no status commands should be returning the component 
version. It seems like what's happening is that 
{{/var/lib/ambari-agent/data/structured-out-status.json}} is being read even if 
the status command did not update the file.


Diffs (updated)
-

  ambari-agent/src/test/python/resource_management/TestScript.py 65f8c2d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
dc657fb 
  ambari-server/src/test/python/unitTests.py a8e72e9 


Diff: https://reviews.apache.org/r/58969/diff/2/

Changes: https://reviews.apache.org/r/58969/diff/1-2/


Testing (updated)
---

--
Total run:1170
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:05 min
[INFO] Finished at: 2017-05-03T17:45:26-04:00
[INFO] Final Memory: 17M/245M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173824
---




ambari-web/app/templates/wizard/step8.hbs
Lines 102 (patched)


You can use the download icon.



- Sangeeta Ravindran


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/#review173819
---


Ship it!




Ship It!

- Eugene Chekanskiy


On May 3, 2017, 6 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58969/
> ---
> 
> (Updated May 3, 2017, 6 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20924
> https://issues.apache.org/jira/browse/AMBARI-20924
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Possibly caused by AMBARI-20750:
> 
> Upgrades are failing because of a {{VERSION_MISMATCH}} between all components 
> of the upgrade. Initially, on restart, the version comes back correct and the 
> host component transitions into {{COMPLETED}}. 
> 
> However, the following status command returns the old version, forcing the 
> component back into the {{VERSION_MISMATCH}} state.
> 
> What's odd is that no status commands should be returning the component 
> version. It seems like what's happening is that 
> {{/var/lib/ambari-agent/data/structured-out-status.json}} is being read even 
> if the status command did not update the file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> dc657fb 
> 
> 
> Diff: https://reviews.apache.org/r/58969/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/#review173817
---


Ship it!




Ship It!

- Nate Cole


On May 3, 2017, 2 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58969/
> ---
> 
> (Updated May 3, 2017, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20924
> https://issues.apache.org/jira/browse/AMBARI-20924
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Possibly caused by AMBARI-20750:
> 
> Upgrades are failing because of a {{VERSION_MISMATCH}} between all components 
> of the upgrade. Initially, on restart, the version comes back correct and the 
> host component transitions into {{COMPLETED}}. 
> 
> However, the following status command returns the old version, forcing the 
> component back into the {{VERSION_MISMATCH}} state.
> 
> What's odd is that no status commands should be returning the component 
> version. It seems like what's happening is that 
> {{/var/lib/ambari-agent/data/structured-out-status.json}} is being read even 
> if the status command did not update the file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> dc657fb 
> 
> 
> Diff: https://reviews.apache.org/r/58969/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/
---

(Updated May 3, 2017, 4:18 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-20907
https://issues.apache.org/jira/browse/AMBARI-20907


Repository: ambari


Description
---

User management tables in the DB should be:

# users
Name   |Type  |Description
---|--|---
user_id|INTEGER   |Internal unique identifier
principal_id   |INTEGER   |Foreign key from adminprincipal table
user_name  |VARCHAR   |Unique, case-insensitive, login 
identifier expected to be used when logging into Ambari
create_time|TIMESTAMP |Creation time for this account in 
Ambari
active |BOOLEAN   |Active/not active flag
consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
attempts since the last successful authentication
active_widgets_layout  |VARCHAR   |
display_name   |VARCHAR   |Cosmetic name value to show the user 
in user interfaces
local_username |VARCHAR   |Case-sensitive username to use when 
impersonating user in facilities like Ambari Views

- Primary Key: `user_id`
- Foreign Key: `principal_id` -> `adminprincipal.principal_id`


# user_authentication
Name  |Type |Description
--|-|
user_authentication_id|INTEGER  |Primary key for this table
user_id   |INTEGER  |Foreign key from users table
authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP,  
KERBEROS, JTW, PAM, etc...
authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: the 
user's password (digest); LDAP: the user’s distinguished name; KERBEROS: the 
user’s principal; etc...
create_time   |TIMESTAMP|Creation time of this record
update_time   |TIMESTAMP|Update time for this record, can be used to 
enforce password retention times

- Primary Key: `user_authentication_id`
- Foreign Key: `user_id` -> `users.user_id`


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 64a0137f5b 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 


Diff: https://reviews.apache.org/r/58929/diff/2/


Testing (updated)
---

Tested creating new databases using Posgress, MySQL, MS SQL Server, and Derby. 
_I have no way to test creating Oracle and SQL Anywhere databases._


Thanks,

Robert Levas

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 3, 2017, 2:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 279 (patched)
> > 
> >
> > I'm also in favor of a shorter name, fail_count

Renamed to `consecutive_failures`


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173779
---


On May 3, 2017, 4:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 3, 2017, 4:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 3:59 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
> > Lines 299 (patched)
> > 
> >
> > try_count ?
> 
> Jonathan Hurley wrote:
> Or maybe consecutive_failures

done.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173633
---


On May 3, 2017, 4:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 3, 2017, 4:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 3:58 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 296 (patched)
> > 
> >
> > Oracle 12 allows more than 30 characters for db objects; this name may 
> > be pushing it :)
> 
> Nate Cole wrote:
> I should say Oracle 12 allows longer names, but 11 and lower are limited 
> to 30.

Renamed to `FK_user_authentication_users`


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173630
---


On May 3, 2017, 4:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 3, 2017, 4:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 3:57 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 279 (patched)
> > 
> >
> > Typo in "attempts"

Renamed to `consecutive_failures`.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173629
---


On May 3, 2017, 4:15 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 3, 2017, 4:15 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/
---

(Updated May 3, 2017, 4:15 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Changes
---

Updates due to reviewer suggestions.


Bugs: AMBARI-20907
https://issues.apache.org/jira/browse/AMBARI-20907


Repository: ambari


Description
---

User management tables in the DB should be:

# users
Name   |Type  |Description
---|--|---
user_id|INTEGER   |Internal unique identifier
principal_id   |INTEGER   |Foreign key from adminprincipal table
user_name  |VARCHAR   |Unique, case-insensitive, login 
identifier expected to be used when logging into Ambari
create_time|TIMESTAMP |Creation time for this account in 
Ambari
active |BOOLEAN   |Active/not active flag
consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
attempts since the last successful authentication
active_widgets_layout  |VARCHAR   |
display_name   |VARCHAR   |Cosmetic name value to show the user 
in user interfaces
local_username |VARCHAR   |Case-sensitive username to use when 
impersonating user in facilities like Ambari Views

- Primary Key: `user_id`
- Foreign Key: `principal_id` -> `adminprincipal.principal_id`


# user_authentication
Name  |Type |Description
--|-|
user_authentication_id|INTEGER  |Primary key for this table
user_id   |INTEGER  |Foreign key from users table
authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP,  
KERBEROS, JTW, PAM, etc...
authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: the 
user's password (digest); LDAP: the user’s distinguished name; KERBEROS: the 
user’s principal; etc...
create_time   |TIMESTAMP|Creation time of this record
update_time   |TIMESTAMP|Update time for this record, can be used to 
enforce password retention times

- Primary Key: `user_authentication_id`
- Foreign Key: `user_id` -> `users.user_id`


Diffs (updated)
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 64a0137f5b 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 


Diff: https://reviews.apache.org/r/58929/diff/2/

Changes: https://reviews.apache.org/r/58929/diff/1-2/


Testing
---

Tested creating new databases using Posgress, MySQL, and Derby. 
_I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._


Thanks,

Robert Levas

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173808
---




ambari-web/app/templates/wizard/step8.hbs
Lines 102 (patched)


If this patch intends to add the functionality only during cluster install 
and not Add Service wizard, then the button should displayed conditionally.


- Sangeeta Ravindran


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173806
---




ambari-web/app/controllers/wizard/step8_controller.js
Lines 1814 (patched)


this may be my  preference, but can we use method name like 
"hostInExistingHostGroup" ? then later on, your logic would look like 
self.hostInExistingHostGroup.



ambari-web/app/controllers/wizard/step8_controller.js
Lines 1816 (patched)


spacing



ambari-web/app/controllers/wizard/step8_controller.js
Lines 1923 (patched)


can we use cluster name as the blueprint name ? then later on when we add 
the popup alert dialog telling users what to do with the bp and cluster 
template, we can give them some examples with the cluster name mentioned as the 
bp name.



ambari-web/app/messages.js
Lines 128 (patched)


Can we use "Generate Blueprint" or something hinting the files will be 
generated ?


- Di Li


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Anita Jebaraj]

> On May 3, 2017, 6:54 p.m., Robert Levas wrote:
> > Ship It!

Thank you Robert, please help in pushing the changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173790
---


On May 3, 2017, 6:24 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 6:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/2/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Di Li]

> On May 2, 2017, 6:22 p.m., Robert Nettleton wrote:
> > ambari-web/app/controllers/wizard/step8_controller.js
> > Lines 1925 (patched)
> > 
> >
> > Similar to my last point, the default provision_action is always 
> > "INSTALL_AND_START", so this might not need to be set in the Blueprint.
> 
> Amruta Borkar wrote:
> Hello Robert, 
> Thank you for your input, I think exporting these properties would make 
> users aware of the options that are available to them. May be we can export 
> both properties with default values? "config_recommendation_strategy" : 
> "NEVER_APPLY" and "provision_action" : "INSTALL_AND_START"?
> @Di could you please provide your input?

These two really are optional and mostly there just for the sake of giving 
users hints on what would happen if a user deploys a cluster with the bp 
exported. we should change config recommendation strategy to NEVER APPLY as I 
expect bp exported to contain a complete set of configurations. 
provision_action can remain as INSTALL_AND_START (doesn't hurt to have it).


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173615
---


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173802
---




ambari-web/app/controllers/wizard/step8_controller.js
Lines 21 (patched)


Good practice to add a semi-colon.


- Sangeeta Ravindran


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

[Amruta Borkar]

> On May 2, 2017, 6:22 p.m., Robert Nettleton wrote:
> > ambari-web/app/controllers/wizard/step8_controller.js
> > Lines 1925 (patched)
> > 
> >
> > Similar to my last point, the default provision_action is always 
> > "INSTALL_AND_START", so this might not need to be set in the Blueprint.

Hello Robert, 
Thank you for your input, I think exporting these properties would make users 
aware of the options that are available to them. May be we can export both 
properties with default values? "config_recommendation_strategy" : 
"NEVER_APPLY" and "provision_action" : "INSTALL_AND_START"?
@Di could you please provide your input?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58864/#review173615
---


On May 1, 2017, 9:06 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58864/
> ---
> 
> (Updated May 1, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert 
> Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20698
> https://issues.apache.org/jira/browse/AMBARI-20698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI be able to export a blueprint when a user reaches the Deploy page and the 
> bp can be used to install a cluster later on.
> This patch exports blueprint and template. Currently HostGroups are formed 
> only based on the component mapping. In this patch configGroups are not 
> addressed. ConfigGroup and other improvements will be addressed in next 
> revisions of this functionality.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 
>   ambari-web/app/messages.js 8f8d981af7 
>   ambari-web/app/templates/wizard/step8.hbs ac32710468 
> 
> 
> Diff: https://reviews.apache.org/r/58864/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing done. I have attached blueprint.json and clustertemplate.json 
> files that are currently generated with this patch applied.
> 
> 
> File Attachments
> 
> 
> exported_blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json
> exported_clustertemplate
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173791
---


Ship it!




Ship It!

- Tim Thorpe


On May 3, 2017, 6:24 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 6:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/2/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173790
---


Ship it!




Ship It!

- Robert Levas


On May 3, 2017, 2:24 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 2:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/2/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58970: Repositories must be resolved correctly when installing new components

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/#review173787
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 1373-1376 (patched)


This lookup is a DB-hit ... Instead, you can use the new 
`getDesiredRepositoryVersion()` method off of the ServiceComponent


- Jonathan Hurley


On May 3, 2017, 2:12 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58970/
> ---
> 
> (Updated May 3, 2017, 2:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20923
> https://issues.apache.org/jira/browse/AMBARI-20923
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When formulating commands to agents, the correct repositories need to be used 
> for the components.  For example, after a cluster is patched, the following 
> repos could exist:
> ||Service||Component||Repository||
> |HDFS|NN| 2.5.0.0|
> |HDFS|DN| 2.5.0.0|
> |YARN|RM| 2.5.0.1|
> |YARN|NM| 2.5.0.1|
> 
> When installing an additional NM, the 2.5.0.1 repository should be used.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 0dd9c02d40 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  849d6fba42 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  bd62cbbd52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d6905fb7a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8995e51987 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  eb1b187459 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  b0d085b942 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  0a583aeea9 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 5206ea351c 
> 
> 
> Diff: https://reviews.apache.org/r/58970/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Anita Jebaraj]

> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > 
> >
> > There are other User types - LDAP and JWT.  You should check to see if 
> > any user exists with the username. If the existing user is not a PAM user 
> > the failure should occur.  
> > 
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
> 
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here.  My interpretation 
> is that the PAM users will not be found using the 
> UserDAO.findLocalUserByName(String userName) method.  So basically the 
> getUserType() != UserType.PAM is unnecessary.  Although it wouldn't hurt.
> 
> Anita Jebaraj wrote:
> Hi Tim, Robert means that I should look for all user types like 
> (Local/ldap/jwt), I am aware ldap cannot be enabled when pam is enabled, but 
> jwt users can exist when pam is enabled. That should be the reason why he 
> wants me to look for all the users.
> 
> Tim Thorpe wrote:
> Sorry missed the part where you changed findLocalUserByName to 
> findUserByName.  That makes sense now.

Hi Robert, please review the new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---


On May 3, 2017, 6:24 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 6:24 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/2/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/
---

(Updated May 3, 2017, 6:24 p.m.)


Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
Thorpe.


Bugs: AMBARI-20909
https://issues.apache.org/jira/browse/AMBARI-20909


Repository: ambari


Description
---

Create a local user "test" in Ambari

Create a system user "test" with different password

Trying to authenticate via pam in Ambari UI as user "test" throws Server Error 
in Ambari UI, without any error in Ambari-server logs

Also the UI gets stalled and not even able to login as admin user unless the 
browser cache is removed or Ambari UI is opened in a new browser page

Ambari doesn't allow creating users with same user name but different 
types(Local/pam), We reach the pam authentication only when the local user 
authentication failed due to non-existing userid or incorrect password, So if 
local user exists do not attempt to authenticate via PAM, This lets Ambari to 
avoid importing duplicate userid into the database


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 b3fb861 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 b7272c5 


Diff: https://reviews.apache.org/r/58968/diff/2/

Changes: https://reviews.apache.org/r/58968/diff/1-2/


Testing
---

Updated the related test cases


Thanks,

Anita Jebaraj

Re: Review Request 58963: AMBARI-20918. AmbariServer Metrics service cannot be disabled

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58963/#review173782
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 3, 2017, 1:08 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58963/
> ---
> 
> (Updated May 3, 2017, 1:08 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20918
> https://issues.apache.org/jira/browse/AMBARI-20918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that `Configuration.AMBARISERVER_METRICS_DISABLE` is a 
> `ConfigurationProperty`, not a `[Bb]oolean`, so it never 
> `equals(true)`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  ff20834c1a26611206e2839b1c877503eb434084 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bc6b4281338ff1457b0b404c4ac6d664e32af108 
> 
> 
> Diff: https://reviews.apache.org/r/58963/diff/1/
> 
> 
> Testing
> ---
> 
> Started Ambari Server with 3 possible states of the flag:
> 
>  * no `ambariserver.metrics.disable` in `ambari.properties`
>  * `ambariserver.metrics.disable=true`
>  * `ambariserver.metrics.disable=false`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58960: Install: Recommend chronyd instead of ntpd for RHEL 7

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58960/#review173781
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 3, 2017, 11:45 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58960/
> ---
> 
> (Updated May 3, 2017, 11:45 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20917
> https://issues.apache.org/jira/browse/AMBARI-20917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RHEL 7 has moved away from NTPD, and is now using chronyd 
> (https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/System_Administrators_Guide/ch-Configuring_NTP_Using_the_chrony_Suite.html).
>  For the host checks we perform during add host we need to add logic to 
> recommend chronyd instead of ntpd.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 
> 
> 
> Diff: https://reviews.apache.org/r/58960/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/#review173780
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 3, 2017, 3:12 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58965/
> ---
> 
> (Updated May 3, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20920
> https://issues.apache.org/jira/browse/AMBARI-20920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
> the commands will be scheduled appropriately. These should be captured in 
> (role command order) for Atlas.
> 
> PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
> AMBARI-20920 Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 58dcf8d 
> 
> 
> Diff: https://reviews.apache.org/r/58965/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173779
---




ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 279 (patched)


I'm also in favor of a shorter name, fail_count


- Alejandro Fernandez


On May 2, 2017, 7:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/#review173777
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 3, 2017, 6 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58969/
> ---
> 
> (Updated May 3, 2017, 6 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20924
> https://issues.apache.org/jira/browse/AMBARI-20924
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Possibly caused by AMBARI-20750:
> 
> Upgrades are failing because of a {{VERSION_MISMATCH}} between all components 
> of the upgrade. Initially, on restart, the version comes back correct and the 
> host component transitions into {{COMPLETED}}. 
> 
> However, the following status command returns the old version, forcing the 
> component back into the {{VERSION_MISMATCH}} state.
> 
> What's odd is that no status commands should be returning the component 
> version. It seems like what's happening is that 
> {{/var/lib/ambari-agent/data/structured-out-status.json}} is being read even 
> if the status command did not update the file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> dc657fb 
> 
> 
> Diff: https://reviews.apache.org/r/58969/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Tim Thorpe]

> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > 
> >
> > There are other User types - LDAP and JWT.  You should check to see if 
> > any user exists with the username. If the existing user is not a PAM user 
> > the failure should occur.  
> > 
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
> 
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here.  My interpretation 
> is that the PAM users will not be found using the 
> UserDAO.findLocalUserByName(String userName) method.  So basically the 
> getUserType() != UserType.PAM is unnecessary.  Although it wouldn't hurt.
> 
> Anita Jebaraj wrote:
> Hi Tim, Robert means that I should look for all user types like 
> (Local/ldap/jwt), I am aware ldap cannot be enabled when pam is enabled, but 
> jwt users can exist when pam is enabled. That should be the reason why he 
> wants me to look for all the users.

Sorry missed the part where you changed findLocalUserByName to findUserByName.  
That makes sense now.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---


On May 3, 2017, 4:48 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 4:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58970: Repositories must be resolved correctly when installing new components

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/#review173776
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 3, 2017, 6:12 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58970/
> ---
> 
> (Updated May 3, 2017, 6:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20923
> https://issues.apache.org/jira/browse/AMBARI-20923
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When formulating commands to agents, the correct repositories need to be used 
> for the components.  For example, after a cluster is patched, the following 
> repos could exist:
> ||Service||Component||Repository||
> |HDFS|NN| 2.5.0.0|
> |HDFS|DN| 2.5.0.0|
> |YARN|RM| 2.5.0.1|
> |YARN|NM| 2.5.0.1|
> 
> When installing an additional NM, the 2.5.0.1 repository should be used.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 0dd9c02d40 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  849d6fba42 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  bd62cbbd52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d6905fb7a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8995e51987 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  eb1b187459 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  b0d085b942 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  0a583aeea9 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
> 5206ea351c 
> 
> 
> Diff: https://reviews.apache.org/r/58970/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 58970: Repositories must be resolved correctly when installing new components

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-20923
https://issues.apache.org/jira/browse/AMBARI-20923


Repository: ambari


Description
---

When formulating commands to agents, the correct repositories need to be used 
for the components.  For example, after a cluster is patched, the following 
repos could exist:
||Service||Component||Repository||
|HDFS|NN| 2.5.0.0|
|HDFS|DN| 2.5.0.0|
|YARN|RM| 2.5.0.1|
|YARN|NM| 2.5.0.1|

When installing an additional NM, the 2.5.0.1 repository should be used.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
0dd9c02d40 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
 849d6fba42 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 bd62cbbd52 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d6905fb7a4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 8995e51987 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
 eb1b187459 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 b0d085b942 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 0a583aeea9 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 
5206ea351c 


Diff: https://reviews.apache.org/r/58970/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Anita Jebaraj]

> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > 
> >
> > There are other User types - LDAP and JWT.  You should check to see if 
> > any user exists with the username. If the existing user is not a PAM user 
> > the failure should occur.  
> > 
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
> 
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here.  My interpretation 
> is that the PAM users will not be found using the 
> UserDAO.findLocalUserByName(String userName) method.  So basically the 
> getUserType() != UserType.PAM is unnecessary.  Although it wouldn't hurt.

Hi Tim, Robert means that I should look for all user types like 
(Local/ldap/jwt), I am aware ldap cannot be enabled when pam is enabled, but 
jwt users can exist when pam is enabled. That should be the reason why he wants 
me to look for all the users.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---


On May 3, 2017, 4:48 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 4:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Tim Thorpe]

> On May 3, 2017, 5:08 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Lines 79 (patched)
> > 
> >
> > There are other User types - LDAP and JWT.  You should check to see if 
> > any user exists with the username. If the existing user is not a PAM user 
> > the failure should occur.  
> > 
> > For example:
> > ```
> > UserEntitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```

Hi Robert, I'm not sure I'm following your logic here.  My interpretation is 
that the PAM users will not be found using the 
UserDAO.findLocalUserByName(String userName) method.  So basically the 
getUserType() != UserType.PAM is unnecessary.  Although it wouldn't hurt.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---


On May 3, 2017, 4:48 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 4:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/
---

Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, and Nate 
Cole.


Bugs: AMBARI-20924
https://issues.apache.org/jira/browse/AMBARI-20924


Repository: ambari


Description
---

Possibly caused by AMBARI-20750:

Upgrades are failing because of a {{VERSION_MISMATCH}} between all components 
of the upgrade. Initially, on restart, the version comes back correct and the 
host component transitions into {{COMPLETED}}. 

However, the following status command returns the old version, forcing the 
component back into the {{VERSION_MISMATCH}} state.

What's odd is that no status commands should be returning the component 
version. It seems like what's happening is that 
{{/var/lib/ambari-agent/data/structured-out-status.json}} is being read even if 
the status command did not update the file.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
dc657fb 


Diff: https://reviews.apache.org/r/58969/diff/1/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173752
---




ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
Lines 79 (patched)


There are other User types - LDAP and JWT.  You should check to see if any 
user exists with the username. If the existing user is not a PAM user the 
failure should occur.  

For example:
```
UserEntitiy foundUser = userDAO.findUserByName(username)'
if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
... Fail ...
}
```


- Robert Levas


On May 3, 2017, 12:48 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 12:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173746
---


Ship it!




Ship It!

- Di Li


On May 3, 2017, 4:48 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58968/
> ---
> 
> (Updated May 3, 2017, 4:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-20909
> https://issues.apache.org/jira/browse/AMBARI-20909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a local user "test" in Ambari
> 
> Create a system user "test" with different password
> 
> Trying to authenticate via pam in Ambari UI as user "test" throws Server 
> Error in Ambari UI, without any error in Ambari-server logs
> 
> Also the UI gets stalled and not even able to login as admin user unless the 
> browser cache is removed or Ambari UI is opened in a new browser page
> 
> Ambari doesn't allow creating users with same user name but different 
> types(Local/pam), We reach the pam authentication only when the local user 
> authentication failed due to non-existing userid or incorrect password, So if 
> local user exists do not attempt to authenticate via PAM, This lets Ambari to 
> avoid importing duplicate userid into the database
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  b3fb861 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  b7272c5 
> 
> 
> Diff: https://reviews.apache.org/r/58968/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the related test cases
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 4:11 p.m., Attila Doroszlai wrote:
> > FYI see https://reviews.apache.org/r/58840/ for a way to smoke-test the 
> > SQLServer DB script using Docker.
> 
> Robert Levas wrote:
> Attila, thanks for the link. However I am having difficulty getting 
> docker or that image to run. :(

Seems like I need a VM with more than 3.5GB of RAM available.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173631
---


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 58968: Server Error in Ambari UI, when trying to login as a pam user due to user name conflict

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/
---

Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim 
Thorpe.


Bugs: AMBARI-20909
https://issues.apache.org/jira/browse/AMBARI-20909


Repository: ambari


Description
---

Create a local user "test" in Ambari

Create a system user "test" with different password

Trying to authenticate via pam in Ambari UI as user "test" throws Server Error 
in Ambari UI, without any error in Ambari-server logs

Also the UI gets stalled and not even able to login as admin user unless the 
browser cache is removed or Ambari UI is opened in a new browser page

Ambari doesn't allow creating users with same user name but different 
types(Local/pam), We reach the pam authentication only when the local user 
authentication failed due to non-existing userid or incorrect password, So if 
local user exists do not attempt to authenticate via PAM, This lets Ambari to 
avoid importing duplicate userid into the database


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 b3fb861 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 b7272c5 


Diff: https://reviews.apache.org/r/58968/diff/1/


Testing
---

Updated the related test cases


Thanks,

Anita Jebaraj

Re: Review Request 58929: Create Database Schema for Improved User Account Management

[Robert Levas]

> On May 2, 2017, 4:11 p.m., Attila Doroszlai wrote:
> > FYI see https://reviews.apache.org/r/58840/ for a way to smoke-test the 
> > SQLServer DB script using Docker.

Attila, thanks for the link. However I am having difficulty getting docker or 
that image to run. :(


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173631
---


On May 2, 2017, 3:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> ---
> 
> (Updated May 2, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20907
> https://issues.apache.org/jira/browse/AMBARI-20907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User management tables in the DB should be:
> 
> # users
> Name   |Type  |Description
> ---|--|---
> user_id|INTEGER   |Internal unique identifier
> principal_id   |INTEGER   |Foreign key from adminprincipal 
> table
> user_name  |VARCHAR   |Unique, case-insensitive, login 
> identifier expected to be used when logging into Ambari
> create_time|TIMESTAMP |Creation time for this account in 
> Ambari
> active |BOOLEAN   |Active/not active flag
> consecutive_failed_auth_attemps|INTEGER   |The number a failed authorization 
> attempts since the last successful authentication
> active_widgets_layout  |VARCHAR   |
> display_name   |VARCHAR   |Cosmetic name value to show the 
> user in user interfaces
> local_username |VARCHAR   |Case-sensitive username to use 
> when impersonating user in facilities like Ambari Views
> 
> - Primary Key: `user_id`
> - Foreign Key: `principal_id` -> `adminprincipal.principal_id`
> 
> 
> # user_authentication
> Name  |Type |Description
> --|-|
> user_authentication_id|INTEGER  |Primary key for this table
> user_id   |INTEGER  |Foreign key from users table
> authentication_type   |VARCHAR  |Type of authentication system - LOCAL, LDAP, 
>  KERBEROS, JTW, PAM, etc...
> authentication_key|VARCHAR  |Type-specific key (or identifier): LOCAL: 
> the user's password (digest); LDAP: the user’s distinguished name; KERBEROS: 
> the user’s principal; etc...
> create_time   |TIMESTAMP|Creation time of this record
> update_time   |TIMESTAMP|Update time for this record, can be used to 
> enforce password retention times
> 
> - Primary Key: `user_authentication_id`
> - Foreign Key: `user_id` -> `users.user_id`
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc271c 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17594 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248b25 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af96807c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 64a0137f5b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d7d5 
> 
> 
> Diff: https://reviews.apache.org/r/58929/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating new databases using Posgress, MySQL, and Derby. 
> _I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Qin Liu]

> On April 26, 2017, 5:59 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
> > Lines 170 (patched)
> > 
> >
> > Why isn't the OK state part of this?
> > 
> > 
> > If only these 2 states are valid, let's use a collection of states that 
> > force a recalculation and put it in AlertState.java
> 
> Qin Liu wrote:
> Hi Alejandro,
> 
> The OK state of the alert is not part of this because the state of its 
> aggregate alert won't be affected by MM state changes, The alert in 
> CRITICAL/WARNING state will affect its aggregate alert because its state will 
> be changed from muffed CRITICAL/WARNING state to CRITICAL/WARNING state when 
> MM is changed from MM on to MM off or CRITICAL/WARNING state to muffed 
> CRITICAL/WARNING state.when MM is changed from MM off to MM on.
> 
> For your 2nd comment, could you please explain how to use a collection of 
> states that force a recalculation and put it in AlertState.java? Thank you!
> 
> Alejandro Fernandez wrote:
> public static EnumSet RECALCULATE_AGG_STATUS_STATES = 
> EnumSet.of(CRITIAL, WARNING);
> 
> And just use a .contains()
> 
> Qin Liu wrote:
> Fixed. Thanks Akejandro!

Hi afernandez,

I would like to add you as a reviewer.


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review173069
---


On April 28, 2017, 2:42 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated April 28, 2017, 2:42 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/#review173739
---


Ship it!




Ship It!

- Sumit Mohanty


On May 3, 2017, 3:12 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58965/
> ---
> 
> (Updated May 3, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20920
> https://issues.apache.org/jira/browse/AMBARI-20920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
> the commands will be scheduled appropriately. These should be captured in 
> (role command order) for Atlas.
> 
> PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
> AMBARI-20920 Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 58dcf8d 
> 
> 
> Diff: https://reviews.apache.org/r/58965/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/
---

(Updated May 3, 2017, 3:12 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20920
https://issues.apache.org/jira/browse/AMBARI-20920


Repository: ambari


Description (updated)
---

ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
the commands will be scheduled appropriately. These should be captured in (role 
command order) for Atlas.

PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
AMBARI-20920 Apache JIRA.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
58dcf8d 


Diff: https://reviews.apache.org/r/58965/diff/1/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia

Review Request 58965: AMBARI-20920 : Atlas restart fails due to missing hbase dependency in role-command

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58965/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-20920
https://issues.apache.org/jira/browse/AMBARI-20920


Repository: ambari


Description
---

ATLAS component STARTs or RESTARTs are dependent on HBASE STARTs/RESTARTs, so 
the commands will be scheduled appropriately. These should be captured in (role 
command order) for Atlas.

PS: Attached patch is for branch-2.5, trunk-addendum patch is attached to 
AMBARI-20920 jira.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/role_command_order.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
58dcf8d 


Diff: https://reviews.apache.org/r/58965/diff/1/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Jonathan Hurley]

> On April 28, 2017, 6:46 p.m., Jonathan Hurley wrote:
> > Ship It!
> 
> Qin Liu wrote:
> Thank you so much, Jonathan!
> 
> Qin Liu wrote:
> Hi Jonathan,
> 
> I would really appreciate if you can commit the changes.

It only has 1 ship-it right now. Typically, reviews need 2.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review173392
---


On April 27, 2017, 10:42 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated April 27, 2017, 10:42 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58960: Install: Recommend chronyd instead of ntpd for RHEL 7

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58960/#review173734
---


Ship it!




Ship It!

- Sumit Mohanty


On May 3, 2017, 11:45 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58960/
> ---
> 
> (Updated May 3, 2017, 11:45 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20917
> https://issues.apache.org/jira/browse/AMBARI-20917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RHEL 7 has moved away from NTPD, and is now using chronyd 
> (https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/System_Administrators_Guide/ch-Configuring_NTP_Using_the_chrony_Suite.html).
>  For the host checks we perform during add host we need to add logic to 
> recommend chronyd instead of ntpd.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 
> 
> 
> Diff: https://reviews.apache.org/r/58960/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

[Qin Liu]

> On April 28, 2017, 10:46 p.m., Jonathan Hurley wrote:
> > Ship It!
> 
> Qin Liu wrote:
> Thank you so much, Jonathan!

Hi Jonathan,

I would really appreciate if you can commit the changes.


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58411/#review173392
---


On April 28, 2017, 2:42 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58411/
> ---
> 
> (Updated April 28, 2017, 2:42 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20726
> https://issues.apache.org/jira/browse/AMBARI-20726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Aggregate alert does not show status properly at Maintenance Mode change.
> 
> Steps to reproduce:
> Install a cluster that has HBase with one regionserver installed.
> 
> Scenario 1:
> 1. Turn On Maintenance Mode on the RegionServer or on the RegionServer host 
> or on the HBase service.
> 2. Stop the RegionServer after that.
> 3. No red alerts will show as expected.
>Percent RegionServers Available - OK affected: [0], total: [1]
> 4. Now Turn Off Maintenance Mode, still keep the RegionServer down.
>But Percent RegionServers Available alert will still show "OK" - "CRIT" is 
> expected.
> 
> Scenario 2:
> 1) Stop the RegionServer - Red alert will show as expected.
>Percent RegionServers Available - CRIT affected: [1], total: [1]
> 2) Now Turn On Maintenance Mode - For RegionServer status, Red alert will be 
> gone as expected.
>But Percent RegionServers Available alert will still show "CRIT" - "OK" is 
> expected.
>
> The fix is to fire an AggregateAlertRecalculateEvent to refresh aggregate 
> alert at Maintenance Mode change time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
>  847a207 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
> 8e04eb1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
>  bdc662a 
> 
> 
> Diff: https://reviews.apache.org/r/58411/diff/4/
> 
> 
> Testing
> ---
> 
> The fix has been manually tested via HDP UI.
> The unit testcase AlertMaintenanceModeListenerTest.java has been updated to 
> reflect the change.
> 
> testrun_ambari-server Results :
> Tests run: 4977, Failures: 0, Errors: 0, Skipped: 39
> 
> The skipped testcases has nothing to do with the fix.
> 
> 
> File Attachments
> 
> 
> AMBARI-20726.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/24/011309ea-84c8-470c-b467-bbe2a2372f46__AMBARI-20726.patch
> AMBARI-20726_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/26/8aa802d1-17a9-4871-8ea1-1449a29506ae__AMBARI-20726_2.patch
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 58963: AMBARI-20918. AmbariServer Metrics service cannot be disabled

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58963/#review173733
---


Ship it!




Ship It!

- Aravindan Vijayan


On May 3, 2017, 1:08 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58963/
> ---
> 
> (Updated May 3, 2017, 1:08 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20918
> https://issues.apache.org/jira/browse/AMBARI-20918
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that `Configuration.AMBARISERVER_METRICS_DISABLE` is a 
> `ConfigurationProperty`, not a `[Bb]oolean`, so it never 
> `equals(true)`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  ff20834c1a26611206e2839b1c877503eb434084 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bc6b4281338ff1457b0b404c4ac6d664e32af108 
> 
> 
> Diff: https://reviews.apache.org/r/58963/diff/1/
> 
> 
> Testing
> ---
> 
> Started Ambari Server with 3 possible states of the flag:
> 
>  * no `ambariserver.metrics.disable` in `ambari.properties`
>  * `ambariserver.metrics.disable=true`
>  * `ambariserver.metrics.disable=false`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58918: AMBARI-20911 Add property in Ranger for including SSL protocols

[Mugdha Varadkar]

> On May 2, 2017, 2:16 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
> > Lines 33 (patched)
> > 
> >
> > cURL on several supported OS's don't support TLSv1.2

Closing the Review request as fix for AMBARI-20911: 
https://issues.apache.org/jira/browse/AMBARI-20911 is no more required.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58918/#review173585
---


On May 2, 2017, 11:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58918/
> ---
> 
> (Updated May 2, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20911
> https://issues.apache.org/jira/browse/AMBARI-20911
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ranger.service.https.attrib.ssl.enabled.protocols property in 
> ranger-admin-site config type for stack 2.6
> 
> For fresh install the value required is: TLSv1.1,TLSv1.2
> For upgrade: SSLv2Hello,TLSv1,TLSv1.1,TLSv1.2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-admin-site.xml
>  ebf8517 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 8b5c07d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> d98bb53 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> b3d19d4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 1eb9836 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 559d8dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 0470b7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> a6b7523 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  a74d085 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 35d3da2 
> 
> 
> Diff: https://reviews.apache.org/r/58918/diff/1/
> 
> 
> Testing
> ---
> 
> Tested EU Upgrade with Ranger.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Nate Cole]

> On May 2, 2017, 4:07 p.m., Jonathan Hurley wrote:
> > What's the state of this review? Seems like it's been dormant for a week...
> 
> Madhuvanthi Radhakrishnan wrote:
> Hi Jonathan,
> This patch was scraped for 2.5.1 since the changes were made in the HDF 
> mpack instead. But we do want to keep this approach open for discussion for 
> 3.0.0

In that case, please close the review.  Discussion won't happen on a code 
review.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review173637
---


On April 19, 2017, 3:29 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
> 
> (Updated April 19, 2017, 3:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  463d61f53d 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 2c441ad5a0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcbd2a 
>   
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json
>  c6575b51a7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 
> ab5e2cdaf9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 
> 0b5ba6a0ba 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 
> 1550715d72 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 
> 013bb8b8d2 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> 7ded3a01e1 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 
> 7a29ea0c0d 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 
> a9db11c645 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 
> fb561f74f3 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> 86ca03a4a3 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> cbe8ebeb15 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> dc4c43b9e0 
>   ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 
> 0da58ce2a5 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/3/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 58963: AMBARI-20918. AmbariServer Metrics service cannot be disabled

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58963/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20918
https://issues.apache.org/jira/browse/AMBARI-20918


Repository: ambari


Description
---

The problem is that `Configuration.AMBARISERVER_METRICS_DISABLE` is a 
`ConfigurationProperty`, not a `[Bb]oolean`, so it never 
`equals(true)`.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 ff20834c1a26611206e2839b1c877503eb434084 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 bc6b4281338ff1457b0b404c4ac6d664e32af108 


Diff: https://reviews.apache.org/r/58963/diff/1/


Testing
---

Started Ambari Server with 3 possible states of the flag:

 * no `ambariserver.metrics.disable` in `ambari.properties`
 * `ambariserver.metrics.disable=true`
 * `ambariserver.metrics.disable=false`


Thanks,

Attila Doroszlai

Review Request 58960: Install: Recommend chronyd instead of ntpd for RHEL 7

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58960/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-20917
https://issues.apache.org/jira/browse/AMBARI-20917


Repository: ambari


Description
---

RHEL 7 has moved away from NTPD, and is now using chronyd 
(https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/System_Administrators_Guide/ch-Configuring_NTP_Using_the_chrony_Suite.html).
 For the host checks we perform during add host we need to add logic to 
recommend chronyd instead of ntpd.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 4b7bfd7 


Diff: https://reviews.apache.org/r/58960/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

[Masahiro Tanaka]

> On April 29, 2017, 3:35 a.m., Aravindan Vijayan wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
> Thank you! Could you commit it?
> 
> Aravindan Vijayan wrote:
> Done. Please close the review and the jira.

Thank you very much!


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
---


On April 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> ---
> 
> (Updated April 20, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I had in trouble compiling same as in 
> https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , 
> not storm-1.1.0-SNAPSHOT
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 
> 
> 
> Diff: https://reviews.apache.org/r/58575/diff/1/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-metrics/ambari-metrics-storm-sink.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

[Masahiro Tanaka]

> On May 3, 2017, 3:37 a.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you very much!


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review173621
---


On April 17, 2017, 9:40 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated April 17, 2017, 9:40 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/3/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58802/
---

(Updated May 3, 2017, 1:59 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

fixed review comments


Bugs: AMBARI-20875
https://issues.apache.org/jira/browse/AMBARI-20875


Repository: ambari


Description
---

When removing a service, the configurations for that service are kept for 
historical purposes, but their various associations in the database are removed 
(specifically, the {{serviceconfigmapping}} relationships).

After removing a service, the orphaned configurations now cause a warning to be 
displayed on Ambari Server startup:

{noformat}
2017-04-06 17:15:24,003  WARN - You have config(s): 
ranger-storm-policymgr-ssl-version1467149286586,atlas-env-version1471883877194,falcon-env-version1467044148480,storm-site-version1467149286586,storm-site-version1474944944095,ranger-storm-plugin-properties-version1467149286586,hana_hadoop-env-version1476989318735,hana_hadoop-env-version1468951412523,hanaes-site-version1475773173499,hanaes-site-version1477639131416,atlas-env-version1471880496396,falcon-startup.properties-version1474944962583,ranger-storm-security-version1467149286586,falcon-env-version1474944962517,application-properties-version1471883877194,hanaes-site-version1468951412523,application-properties-version1471992143777,application-properties-version1471880496396,hana_hadoop-env-version1475790068354,hana_hadoop-env-version1477639131416,falcon-runtime.properties-version1467044148480,atlas-env-version1471992143777,hana_hadoop-env-version1475773173499,storm-env-version1467149286586,hanaes-site-version1475790068354,hanaes-s
 
ite-version1476902714170,atlas-env-version1471883827584,hana_hadoop-env-version1477695406433,hanaes-site-version1476989583427,falcon-log4j-version1,falcon-env-version1474944962457,hanaes-site-version1468959251565,falcon-client.properties-version1,atlas-env-version1471993347065,falcon-startup.properties-version1467044148480,storm-cluster-log4j-version1467149286586,hanaes-site-version1472285532383,hana_hadoop-env-version1477695089738,hana_hadoop-env-version1468959251565,hana_hadoop-env-version1476989821279,atlas-log4j-version1,storm-site-version1467612840864,storm-worker-log4j-version1467149286586,ranger-storm-audit-version1467149286586,application-properties-version1471993347065,application-properties-version1471883827584,hana_hadoop-env-version1477695579450
 that is(are) not mapped (in serviceconfigmapping table) to any service!
{noformat}

These orphaned configurations have entries in both {{clusterconfig}} and 
{{clusterconfigmapping}} but are otherwise not references anywhere. They don't 
hurt anything, but do trigger this warning since we can't determine if they 
_should_ have mappings in {{serviceconfigmapping}}.

A few options:
- When removing a service, remove configurations as well, leaving no orphans. 
Some would argue that this is a bad move since re-adding the service later 
would allow you to see the old configurations. I do not believe this is true 
since the old configurations are never associated with the new service's 
{{serviceconfig}} or {{serviceconfigmapping}}.

- Make the warning smarter somehow to ignore these since it's expected they are 
orphaned.
-- Somehow determine the service which should own the config and see if it 
exists in the cluster?
-- Add a new column to {{clusterconfig}} to mark it as deleted?


To clean these warnings, we had to:
{code}
CREATE TEMPORARY TABLE IF NOT EXISTS orphaned_configs AS
(SELECT
cc.config_id,
cc.type_name,
cc.version_tag
FROM clusterconfig cc, clusterconfigmapping ccm
WHERE cc.config_id NOT IN (SELECT
scm.config_id
FROM serviceconfigmapping scm)
AND cc.type_name != 'cluster-env'
AND cc.type_name = ccm.type_name
AND cc.version_tag = ccm.version_tag);

DELETE FROM clusterconfigmapping
WHERE EXISTS
(SELECT 1 FROM orphaned_configs
WHERE clusterconfigmapping.type_name = orphaned_configs.type_name AND 
clusterconfigmapping.version_tag = orphaned_configs.version_tag);

DELETE FROM clusterconfig WHERE clusterconfig.config_id IN (SELECT config_id 
FROM orphaned_configs);

SELECT * FROM orphaned_configs;

DROP TABLE orphaned_configs;
{code}

I've considered advanced heuristics based on service metainfo with config 
dependencies, and service config mappings. But this approach may be unreliable 
when given inaccurate service metainfo between stack upgrades. Also, this 
approach is likely to delay server start on clusters with thousands of configs.
So the solution Add a new column to clusterconfig to mark it as deleted. So 
warning will not be generated for such cluster configs.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 c33c4e3815 
  

Re: Review Request 58857: Setting Desired Stack Ids to Correct Values During Service and Patch Upgrades

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58857/#review173720
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 2, 2017, 11:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58857/
> ---
> 
> (Updated May 2, 2017, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-20894
> https://issues.apache.org/jira/browse/AMBARI-20894
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Long story short here is that this is the first major breaking change for 
> supporting service/patch upgrades. Some highlights:
> - Services and components will now track their "desired repository"
> - The cluster_version is deprecated and I've removed the use of it in many 
> places in order to get this compiling. It will be further removed by a future 
> commit
> - The host components are now compared to their components to verify if the 
> upgrade has succeeded
> - Some things are still very wrong
> -- I have about 300 unit test compile errors. Once I fix those, I'm sure they 
> will all fail. It's something we plan to fix in iterations as more code is 
> changed to support service and patch
> -- There are DDL changes here; we will do the work to upgrade the database in 
> a separate Jira
> -- Lots of useless code has been removed
> -- The python code still doesn't understand per-component versions; that is a 
> follow-up Jira.
> 
> Please review and keep in mind that many areas are partially complete since 
> there are many other Jiras tracking this work. That's why it's in a feature 
> branch :)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> da47351 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c1028dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
>  7dfbe47 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  b2a03e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  04b72ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
>  5b6c739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
>  f6993f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c3e66fc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  ff8d0be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  46e791b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  6556852 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  623851a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  abf8e6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  930a535 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
>  ea2938b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  0b3d8ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4ed9617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  17fd323 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
>  885f995 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  5b65833 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
>  5d73fac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
>  52c0cf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  32d6151 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  7bcb9d0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 1ef204d 
>   

Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173719
---



I guess "clear filter" takes lot of space. I think clear filter should be a 
simpler icon (may be a X) and it should be before refresh.

- belliraj hb


On May 1, 2017, 10:15 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 1, 2017, 10:15 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>