Re: Review Request 61422: Check for config group host mapping left behind after host delete
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61422/#review182186
---
Ship it!
Ship It!
- Sumit Mohanty
On Aug. 4, 2017, 4:06 a.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61422/
> ---
>
> (Updated Aug. 4, 2017, 4:06 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Vitalyi
> Brodetskyi.
>
>
> Bugs: AMBARI-21658
> https://issues.apache.org/jira/browse/AMBARI-21658
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Delete hosts deletes the config group host mapping as well, however, certain
> older versions of Ambari have reported seeing orphaned mappings in the
> configgrouphostmapping table.
>
> This results in Add Service wizard being stuck with the following error
> message:
>
> {code}
> This is a JS issue. No exceptions/error in Ambari server logs:
> Uncaught TypeError: Cannot read property 'id' of undefined
> at http://192.167.42.111:8080/javascripts/app.js:37021:96
> at Array.map (native)
> at Class.
> {code}
>
> The patch addresses identifying such an error on server start and providing a
> way to fix it automatically.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
> c6239d8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
> d35fc1a
>
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
> 03edcf8
>
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
> 9c8eb74
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java
> 3f73657
>
>
> Diff: https://reviews.apache.org/r/61422/diff/1/
>
>
> Testing
> ---
>
> Verified manually.
> Unit test added.
>
>
> Thanks,
>
> Sid Wagle
>
>
Review Request 61422: Check for config group host mapping left behind after host delete
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61422/
---
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Vitalyi
Brodetskyi.
Bugs: AMBARI-21658
https://issues.apache.org/jira/browse/AMBARI-21658
Repository: ambari
Description
---
Delete hosts deletes the config group host mapping as well, however, certain
older versions of Ambari have reported seeing orphaned mappings in the
configgrouphostmapping table.
This results in Add Service wizard being stuck with the following error message:
{code}
This is a JS issue. No exceptions/error in Ambari server logs:
Uncaught TypeError: Cannot read property 'id' of undefined
at http://192.167.42.111:8080/javascripts/app.js:37021:96
at Array.map (native)
at Class.
{code}
The patch addresses identifying such an error on server start and providing a
way to fix it automatically.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
c6239d8
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
d35fc1a
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
03edcf8
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
9c8eb74
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java
3f73657
Diff: https://reviews.apache.org/r/61422/diff/1/
Testing
---
Verified manually.
Unit test added.
Thanks,
Sid Wagle
Re: Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/#review182184 --- Ship it! Ship It! - Jonathan Hurley On Aug. 3, 2017, 4:20 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61415/ > --- > > (Updated Aug. 3, 2017, 4:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21654 > https://issues.apache.org/jira/browse/AMBARI-21654 > > > Repository: ambari > > > Description > --- > > Ensure backword compatibility for older BI value add services. These services > do not get updated service definitions so their Python API references are old. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/version.py > 7dfa6b8 > > > Diff: https://reviews.apache.org/r/61415/diff/1/ > > > Testing > --- > > patch a cluster, now BI value add services (service definitions got copied > over automatically by the Ambari upgrade process, their service defintions > are NOT part of the stack shipped in Ambari) can restart now. > > > Thanks, > > Di Li > >
Re: Review Request 61414: Patch/Service Downgrades Are Not Correctly Scoped
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61414/#review182170
---
Ship it!
Ship It!
- Alejandro Fernandez
On Aug. 3, 2017, 8:17 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61414/
> ---
>
> (Updated Aug. 3, 2017, 8:17 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-21656
> https://issues.apache.org/jira/browse/AMBARI-21656
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When creating a downgrade from either a {{PATCH}} or {{SERVICE}} upgrade, the
> following is observed:
>
> - Things like "set version on all hosts" runs
> - The upgrade "services" structure is empty, indicating an entire cluster is
> being downgraded
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
> 629f3cd771
>
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
> 215cab85cf
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
> 8bf0400753
>
>
> Diff: https://reviews.apache.org/r/61414/diff/1/
>
>
> Testing
> ---
>
> PENDING... still need to write the UTs to cover the UpgradeContext being
> initialized correctly on DOWNGRADE.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/#review182160 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 3, 2017, 8:20 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61415/ > --- > > (Updated Aug. 3, 2017, 8:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21654 > https://issues.apache.org/jira/browse/AMBARI-21654 > > > Repository: ambari > > > Description > --- > > Ensure backword compatibility for older BI value add services. These services > do not get updated service definitions so their Python API references are old. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/version.py > 7dfa6b8 > > > Diff: https://reviews.apache.org/r/61415/diff/1/ > > > Testing > --- > > patch a cluster, now BI value add services (service definitions got copied > over automatically by the Ambari upgrade process, their service defintions > are NOT part of the stack shipped in Ambari) can restart now. > > > Thanks, > > Di Li > >
Re: Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/#review182157 --- Ship it! Ship It! - Tim Thorpe On Aug. 3, 2017, 8:20 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61415/ > --- > > (Updated Aug. 3, 2017, 8:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21654 > https://issues.apache.org/jira/browse/AMBARI-21654 > > > Repository: ambari > > > Description > --- > > Ensure backword compatibility for older BI value add services. These services > do not get updated service definitions so their Python API references are old. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/version.py > 7dfa6b8 > > > Diff: https://reviews.apache.org/r/61415/diff/1/ > > > Testing > --- > > patch a cluster, now BI value add services (service definitions got copied > over automatically by the Ambari upgrade process, their service defintions > are NOT part of the stack shipped in Ambari) can restart now. > > > Thanks, > > Di Li > >
Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, and Tim Thorpe. Bugs: AMBARI-21654 https://issues.apache.org/jira/browse/AMBARI-21654 Repository: ambari Description --- Ensure backword compatibility for older BI value add services. These services do not get updated service definitions so their Python API references are old. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/version.py 7dfa6b8 Diff: https://reviews.apache.org/r/61415/diff/1/ Testing --- patch a cluster, now BI value add services (service definitions got copied over automatically by the Ambari upgrade process, their service defintions are NOT part of the stack shipped in Ambari) can restart now. Thanks, Di Li
Review Request 61414: Patch/Service Downgrades Are Not Correctly Scoped
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61414/
---
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-21656
https://issues.apache.org/jira/browse/AMBARI-21656
Repository: ambari
Description
---
When creating a downgrade from either a {{PATCH}} or {{SERVICE}} upgrade, the
following is observed:
- Things like "set version on all hosts" runs
- The upgrade "services" structure is empty, indicating an entire cluster is
being downgraded
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
629f3cd771
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
215cab85cf
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
8bf0400753
Diff: https://reviews.apache.org/r/61414/diff/1/
Testing
---
PENDING... still need to write the UTs to cover the UpgradeContext being
initialized correctly on DOWNGRADE.
Thanks,
Jonathan Hurley
Re: Review Request 61405: AMBARI-21650 Ranger Usersync process starts with older stack script during cross stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61405/#review182133 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 3, 2017, 1:27 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61405/ > --- > > (Updated Aug. 3, 2017, 1:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Sumit > Mohanty. > > > Bugs: AMBARI-21650 > https://issues.apache.org/jira/browse/AMBARI-21650 > > > Repository: ambari > > > Description > --- > > EU from IOP(4.2.5) stack to HDP(2.6.2) starts Ranger Usersync process for IOP > stack. > This is because the symbolic link used for starting Ranger Usersync process > points to IOP Ranger Usersync script file > > /usr/bin/ranger-usersync -> > /usr/iop/current/ranger-usersync/ranger-usersync-services.sh > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 2fa7b2f > > > Diff: https://reviews.apache.org/r/61405/diff/1/ > > > Testing > --- > > Tested EU from IOP to HDP and HDP-2.5.x to HDP-2.6.x > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 61407: Create VDF and xsd to support MAINT upgrades
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61407/#review182121
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 3, 2017, 6:29 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61407/
> ---
>
> (Updated Aug. 3, 2017, 6:29 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-21653
> https://issues.apache.org/jira/browse/AMBARI-21653
>
>
> Repository: ambari
>
>
> Description
> ---
>
> * Add MAINT as a VDF type
> * Add {{release-version}} to {{manifest/service}} elements.
> * Update {{contrib/version-builder}} for these new elements.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
> f79d828496
>
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
> 85da0f8811
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/AvailableVersion.java
> b10a13e9a1
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestService.java
> 2bbacd584c
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
> be63c19470
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
> 97f391ec0a
> ambari-server/src/main/resources/version_definition.xsd bef3739219
>
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
> ac7c39a806
> ambari-server/src/test/resources/version_definition_test_maint.xml
> PRE-CREATION
> contrib/version-builder/example.py 8c7be5f215
> contrib/version-builder/example.sh ca7ba10806
> contrib/version-builder/version_builder.py 6d1689ac9c
>
>
> Diff: https://reviews.apache.org/r/61407/diff/1/
>
>
> Testing
> ---
>
> Manual. Automated:
>
> Tests run: 4408, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 23:36.062s
> [INFO] Finished at: Thu Aug 03 11:52:33 EDT 2017
> [INFO] Final Memory: 54M/558M
> [INFO]
>
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 61407: Create VDF and xsd to support MAINT upgrades
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61407/#review182117
---
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 3, 2017, 11:29 a.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61407/
> ---
>
> (Updated Aug. 3, 2017, 11:29 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Repository: ambari
>
>
> Description
> ---
>
> * Add MAINT as a VDF type
> * Add {{release-version}} to {{manifest/service}} elements.
> * Update {{contrib/version-builder}} for these new elements.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
> f79d828496
>
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
> 85da0f8811
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/AvailableVersion.java
> b10a13e9a1
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestService.java
> 2bbacd584c
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
> be63c19470
>
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
> 97f391ec0a
> ambari-server/src/main/resources/version_definition.xsd bef3739219
>
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
> ac7c39a806
> ambari-server/src/test/resources/version_definition_test_maint.xml
> PRE-CREATION
> contrib/version-builder/example.py 8c7be5f215
> contrib/version-builder/example.sh ca7ba10806
> contrib/version-builder/version_builder.py 6d1689ac9c
>
>
> Diff: https://reviews.apache.org/r/61407/diff/1/
>
>
> Testing
> ---
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/#review182116 --- Ship it! Ship It! - Oliver Szabo On Aug. 2, 2017, 11:05 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61277/ > --- > > (Updated Aug. 2, 2017, 11:05 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21623 > https://issues.apache.org/jira/browse/AMBARI-21623 > > > Repository: ambari > > > Description > --- > > Log Search Config is getting too complex, it serves too many kind of things. > It should be separated into two interfaces, one for the Server and one for > the Log Feeders to make it cleaner. > > Also fixed a minor issue about shipper configurations without any post map > values. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java > 76be392 > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java > 77b48eb > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServer.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java > e308346 > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java > b64dae8 > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java > f990c5c > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeederClass1.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeederClass2.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServerClass1.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServerClass2.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigLogFeederZK.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigServerZK.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java > 387d0c6 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > ba3412b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java > 30b61a1 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java > 10642d1 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java > b370e58 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > ce040f9 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java > 3f6df75 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java > 6de34ce > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 15f59e4 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java > 8b4c7bf > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java > a1181b4 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilter.java > 84bddb8 > > > Diff: https://reviews.apache.org/r/61277/diff/2/ > > > Testing > --- > > Tested on local cluster, still works > > > Thanks, > > Miklos Gergely > >
Re: Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/#review182115 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Aug. 2, 2017, 8:20 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61386/ > --- > > (Updated Aug. 2, 2017, 8:20 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-21640 > https://issues.apache.org/jira/browse/AMBARI-21640 > > > Repository: ambari > > > Description > --- > > List of dashboards affected. > HDFS-Users > HBase - Tables > HBase - Users > Kafka - Topics > Nifi - Hosts > > > The problem here is that the 'cluster name' field added through AMBARI-20896 > was not handled correctly. Whenever the Cluster name is not present, it > appends an 'undefined' to the GET metrics URL causing wrong requests. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b4a339e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDF/grafana-nifi-hosts.json > 94aa285 > > > Diff: https://reviews.apache.org/r/61386/diff/1/ > > > Testing > --- > > Manually tested all Grafana dashboards except Druid. (Including HDFS-Users, > HBase-Tables, HBase - Users, Storm-Topology, Kafka-Topics, Nifi-Hosts) > > > Thanks, > > Aravindan Vijayan > >
Review Request 61407: Create VDF and xsd to support MAINT upgrades
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61407/
---
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Repository: ambari
Description
---
* Add MAINT as a VDF type
* Add {{release-version}} to {{manifest/service}} elements.
* Update {{contrib/version-builder}} for these new elements.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java
f79d828496
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
85da0f8811
ambari-server/src/main/java/org/apache/ambari/server/state/repository/AvailableVersion.java
b10a13e9a1
ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestService.java
2bbacd584c
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
be63c19470
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
97f391ec0a
ambari-server/src/main/resources/version_definition.xsd bef3739219
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
ac7c39a806
ambari-server/src/test/resources/version_definition_test_maint.xml
PRE-CREATION
contrib/version-builder/example.py 8c7be5f215
contrib/version-builder/example.sh ca7ba10806
contrib/version-builder/version_builder.py 6d1689ac9c
Diff: https://reviews.apache.org/r/61407/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61404/#review182114 --- Ship it! Ship It! - Robert Levas On Aug. 3, 2017, 9:17 a.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61404/ > --- > > (Updated Aug. 3, 2017, 9:17 a.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, and Robert Levas. > > > Bugs: AMBARI-21648 > https://issues.apache.org/jira/browse/AMBARI-21648 > > > Repository: ambari > > > Description > --- > > Ambari database tables can be created in any AzureDB schema beside the > default 'dbo'. The generated DDL sql will fail in case the Ambari database > tables were to be created in other schema than 'dbo' as it looks up db > objects in 'dbo' schema only. > If no schema is specified than db object will be looked up in the default > schema of the user > > > Diffs > - > > ambari-server/src/main/python/azuredb_create_generator.py 6ceaa90 > > > Diff: https://reviews.apache.org/r/61404/diff/1/ > > > Testing > --- > > 1. Manual testing > > 2. Unit tests: > mvn clean test -am -pl ambari-server > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 20.766 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.005 > s] > [INFO] Ambari Views ... SUCCESS [ 2.548 > s] > [INFO] ambari-utility . SUCCESS [ 3.386 > s] > [INFO] ambari-metrics . SUCCESS [ 0.526 > s] > [INFO] Ambari Metrics Common .. SUCCESS [ 4.724 > s] > [INFO] Ambari Service Advisor . SUCCESS [ 0.336 > s] > [INFO] Ambari Server .. SUCCESS [33:35 > min] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 34:08 min > [INFO] Finished at: 2017-08-03T15:10:27+02:00 > [INFO] Final Memory: 74M/629M > [INFO] > > > > Thanks, > > Sebastian Toader > >
Re: Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.
> On Aug. 2, 2017, 8:24 p.m., Sid Wagle wrote: > > Ship It! Thank you Sid. I will wait for a Ship it from a UI engineer as well. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/#review182033 --- On Aug. 2, 2017, 8:20 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61386/ > --- > > (Updated Aug. 2, 2017, 8:20 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-21640 > https://issues.apache.org/jira/browse/AMBARI-21640 > > > Repository: ambari > > > Description > --- > > List of dashboards affected. > HDFS-Users > HBase - Tables > HBase - Users > Kafka - Topics > Nifi - Hosts > > > The problem here is that the 'cluster name' field added through AMBARI-20896 > was not handled correctly. Whenever the Cluster name is not present, it > appends an 'undefined' to the GET metrics URL causing wrong requests. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b4a339e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDF/grafana-nifi-hosts.json > 94aa285 > > > Diff: https://reviews.apache.org/r/61386/diff/1/ > > > Testing > --- > > Manually tested all Grafana dashboards except Druid. (Including HDFS-Users, > HBase-Tables, HBase - Users, Storm-Topology, Kafka-Topics, Nifi-Hosts) > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 61403: AMBARI-21554. Regenerating keytabs fails in Stack Advisor after upgrading Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61403/#review182107 --- Ship it! Ship It! - Di Li On Aug. 3, 2017, 12:54 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61403/ > --- > > (Updated Aug. 3, 2017, 12:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Eric Yang, Jonathan > Hurley, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21554 > https://issues.apache.org/jira/browse/AMBARI-21554 > > > Repository: ambari > > > Description > --- > > Fix: Add the custom directory where `stack_advisor_25` etc. are defined to > the Python path. > > Code taken from IBM Ambari 2.2. Added some explanatory comment. > > > Diffs > - > > ambari-server/src/main/resources/scripts/stack_advisor.py > 66ab248d071a197eaf12057e10a8f315b1aebd9b > > > Diff: https://reviews.apache.org/r/61403/diff/1/ > > > Testing > --- > > Tested manually according to steps to reproduce in the bug description. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61404/#review182104 --- Ship it! Ship It! - Attila Magyar On Aug. 3, 2017, 1:17 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61404/ > --- > > (Updated Aug. 3, 2017, 1:17 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, and Robert Levas. > > > Bugs: AMBARI-21648 > https://issues.apache.org/jira/browse/AMBARI-21648 > > > Repository: ambari > > > Description > --- > > Ambari database tables can be created in any AzureDB schema beside the > default 'dbo'. The generated DDL sql will fail in case the Ambari database > tables were to be created in other schema than 'dbo' as it looks up db > objects in 'dbo' schema only. > If no schema is specified than db object will be looked up in the default > schema of the user > > > Diffs > - > > ambari-server/src/main/python/azuredb_create_generator.py 6ceaa90 > > > Diff: https://reviews.apache.org/r/61404/diff/1/ > > > Testing > --- > > 1. Manual testing > > 2. Unit tests: > mvn clean test -am -pl ambari-server > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 20.766 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.005 > s] > [INFO] Ambari Views ... SUCCESS [ 2.548 > s] > [INFO] ambari-utility . SUCCESS [ 3.386 > s] > [INFO] ambari-metrics . SUCCESS [ 0.526 > s] > [INFO] Ambari Metrics Common .. SUCCESS [ 4.724 > s] > [INFO] Ambari Service Advisor . SUCCESS [ 0.336 > s] > [INFO] Ambari Server .. SUCCESS [33:35 > min] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 34:08 min > [INFO] Finished at: 2017-08-03T15:10:27+02:00 > [INFO] Final Memory: 74M/629M > [INFO] > > > > Thanks, > > Sebastian Toader > >
Re: Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61404/#review182103 --- Ship it! Ship It! - Attila Doroszlai On Aug. 3, 2017, 3:17 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61404/ > --- > > (Updated Aug. 3, 2017, 3:17 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, and Robert Levas. > > > Bugs: AMBARI-21648 > https://issues.apache.org/jira/browse/AMBARI-21648 > > > Repository: ambari > > > Description > --- > > Ambari database tables can be created in any AzureDB schema beside the > default 'dbo'. The generated DDL sql will fail in case the Ambari database > tables were to be created in other schema than 'dbo' as it looks up db > objects in 'dbo' schema only. > If no schema is specified than db object will be looked up in the default > schema of the user > > > Diffs > - > > ambari-server/src/main/python/azuredb_create_generator.py 6ceaa90 > > > Diff: https://reviews.apache.org/r/61404/diff/1/ > > > Testing > --- > > 1. Manual testing > > 2. Unit tests: > mvn clean test -am -pl ambari-server > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 20.766 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.005 > s] > [INFO] Ambari Views ... SUCCESS [ 2.548 > s] > [INFO] ambari-utility . SUCCESS [ 3.386 > s] > [INFO] ambari-metrics . SUCCESS [ 0.526 > s] > [INFO] Ambari Metrics Common .. SUCCESS [ 4.724 > s] > [INFO] Ambari Service Advisor . SUCCESS [ 0.336 > s] > [INFO] Ambari Server .. SUCCESS [33:35 > min] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 34:08 min > [INFO] Finished at: 2017-08-03T15:10:27+02:00 > [INFO] Final Memory: 74M/629M > [INFO] > > > > Thanks, > > Sebastian Toader > >
Re: Review Request 61403: AMBARI-21554. Regenerating keytabs fails in Stack Advisor after upgrading Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61403/#review182101 --- Ship it! Ship It! - Tim Thorpe On Aug. 3, 2017, 12:54 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61403/ > --- > > (Updated Aug. 3, 2017, 12:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Eric Yang, Jonathan > Hurley, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21554 > https://issues.apache.org/jira/browse/AMBARI-21554 > > > Repository: ambari > > > Description > --- > > Fix: Add the custom directory where `stack_advisor_25` etc. are defined to > the Python path. > > Code taken from IBM Ambari 2.2. Added some explanatory comment. > > > Diffs > - > > ambari-server/src/main/resources/scripts/stack_advisor.py > 66ab248d071a197eaf12057e10a8f315b1aebd9b > > > Diff: https://reviews.apache.org/r/61403/diff/1/ > > > Testing > --- > > Tested manually according to steps to reproduce in the bug description. > > > Thanks, > > Attila Doroszlai > >
Review Request 61405: AMBARI-21650 Ranger Usersync process starts with older stack script during cross stack upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61405/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Sumit Mohanty. Bugs: AMBARI-21650 https://issues.apache.org/jira/browse/AMBARI-21650 Repository: ambari Description --- EU from IOP(4.2.5) stack to HDP(2.6.2) starts Ranger Usersync process for IOP stack. This is because the symbolic link used for starting Ranger Usersync process points to IOP Ranger Usersync script file /usr/bin/ranger-usersync -> /usr/iop/current/ranger-usersync/ranger-usersync-services.sh Diffs - ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 2fa7b2f Diff: https://reviews.apache.org/r/61405/diff/1/ Testing --- Tested EU from IOP to HDP and HDP-2.5.x to HDP-2.6.x Thanks, Mugdha Varadkar
Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61404/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, and Robert Levas. Bugs: AMBARI-21648 https://issues.apache.org/jira/browse/AMBARI-21648 Repository: ambari Description --- Ambari database tables can be created in any AzureDB schema beside the default 'dbo'. The generated DDL sql will fail in case the Ambari database tables were to be created in other schema than 'dbo' as it looks up db objects in 'dbo' schema only. If no schema is specified than db object will be looked up in the default schema of the user Diffs - ambari-server/src/main/python/azuredb_create_generator.py 6ceaa90 Diff: https://reviews.apache.org/r/61404/diff/1/ Testing --- 1. Manual testing 2. Unit tests: mvn clean test -am -pl ambari-server [INFO] Reactor Summary: [INFO] [INFO] Ambari Main SUCCESS [ 20.766 s] [INFO] Apache Ambari Project POM .. SUCCESS [ 0.005 s] [INFO] Ambari Views ... SUCCESS [ 2.548 s] [INFO] ambari-utility . SUCCESS [ 3.386 s] [INFO] ambari-metrics . SUCCESS [ 0.526 s] [INFO] Ambari Metrics Common .. SUCCESS [ 4.724 s] [INFO] Ambari Service Advisor . SUCCESS [ 0.336 s] [INFO] Ambari Server .. SUCCESS [33:35 min] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 34:08 min [INFO] Finished at: 2017-08-03T15:10:27+02:00 [INFO] Final Memory: 74M/629M [INFO] Thanks, Sebastian Toader
Review Request 61403: AMBARI-21554. Regenerating keytabs fails in Stack Advisor after upgrading Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61403/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Eric Yang, Jonathan Hurley, Sid Wagle, and Tim Thorpe. Bugs: AMBARI-21554 https://issues.apache.org/jira/browse/AMBARI-21554 Repository: ambari Description --- Fix: Add the custom directory where `stack_advisor_25` etc. are defined to the Python path. Code taken from IBM Ambari 2.2. Added some explanatory comment. Diffs - ambari-server/src/main/resources/scripts/stack_advisor.py 66ab248d071a197eaf12057e10a8f315b1aebd9b Diff: https://reviews.apache.org/r/61403/diff/1/ Testing --- Tested manually according to steps to reproduce in the bug description. Thanks, Attila Doroszlai
Re: Review Request 61400: Race condition causing execution commands to fail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61400/#review182093
---
Ship it!
Ship It!
- Dmytro Sen
On Aug. 3, 2017, 9:23 a.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61400/
> ---
>
> (Updated Aug. 3, 2017, 9:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Sid
> Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21646
> https://issues.apache.org/jira/browse/AMBARI-21646
>
>
> Repository: ambari
>
>
> Description
> ---
>
> STR:
> 1\. Execution command started
> 2\. Registration failed
> 3\. Execution command finished.
>
> At this point we try to send an execution command result as not a registered
> agent.
> Which leads to exception on server or agent.
>
>
>
> ERROR 2017-08-02 13:36:52,524 ActionQueue.py:207 - Exception while
> processing EXECUTION_COMMAND command
> Traceback (most recent call last):
> File "/usr/lib/python2.6/site-packages/ambari_agent/ActionQueue.py",
> line 200, in process_command
> self.execute_command(command)
> File "/usr/lib/python2.6/site-packages/ambari_agent/ActionQueue.py",
> line 410, in execute_command
> self.commandStatuses.put_command_status(command, roleResult)
> File
> "/usr/lib/python2.6/site-packages/ambari_agent/CommandStatusDict.py", line
> 59, in put_command_status
> self.force_update_to_server(command['clusterId'], new_report)
> File
> "/usr/lib/python2.6/site-packages/ambari_agent/CommandStatusDict.py", line
> 62, in force_update_to_server
>
> self.initializer_module.connection.send(message={'clusters':{cluster_id:
> [report]}}, destination=Constants.COMMANDS_STATUS_REPORTS_ENDPOINT)
> File "/usr/lib/python2.6/site-packages/ambari_agent/Utils.py", line
> 223, in decorated
> v = undecorated(self)
> File
> "/usr/lib/python2.6/site-packages/ambari_agent/InitializerModule.py", line
> 102, in connection
> conn.connect(wait=True)
> File "/usr/lib/python2.6/site-packages/ambari_stomp/protocol.py", line
> 505, in connect
> self.transport.wait_for_connection()
> File
> "/usr/lib/python2.6/site-packages/ambari_stomp/adapter/websocket.py", line
> 83, in wait_for_connection
> raise ConnectionResponseTimeout("Waiting for connection confirmation
> timed out")
> ConnectionResponseTimeout: Waiting for connection confirmation timed out
>
>
> Diffs
> -
>
> ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py f6d304c
> ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 5e5eb0d
>
>
> Diff: https://reviews.apache.org/r/61400/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 61273: Do not call refreshnodes command after deleting a slave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/#review182092 --- Ship it! Ship It! - Andrew Onischuk On Aug. 2, 2017, 3:08 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61273/ > --- > > (Updated Aug. 2, 2017, 3:08 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21621 > https://issues.apache.org/jira/browse/AMBARI-21621 > > > Repository: ambari > > > Description > --- > > If DN is deleted the hostname is removed from exclude file and refreshnodes > command is called. If those actions are not followed by NN restart, the > deleted DN will be shown as DEAD on NN UI. > > The slave should be removed by NN from the UI, but Ambari should not call > refreshnodes command on deletion to ensure slave is in "decommissioned and > dead" state, not "dead" > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 3016027 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > c9df2b9 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > b3ac578 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py > 1581c2a > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_windows.py > 6c492d8 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > 9cf163a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 5fb236b > > > Diff: https://reviews.apache.org/r/61273/diff/3/ > > > Testing > --- > > manual + unit tests > > > Thanks, > > Dmytro Sen > >
Re: Review Request 61396: Annotate upgrade packs for scope
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61396/#review182091 --- Ship it! Ship It! - Nate Cole On Aug. 2, 2017, 10:03 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61396/ > --- > > (Updated Aug. 2, 2017, 10:03 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-21643 > https://issues.apache.org/jira/browse/AMBARI-21643 > > > Repository: ambari > > > Description > --- > > Upgrade Packs for patches need coverage to know what should and should not be > executed during a PU. > > - On downgrade, we see "Set Version On All Hosts". This group needs to be > scoped for only full upgrades. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/WidgetLayoutService.java > 3902236142 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 981c7d55aa > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 00af91e0ee > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > ca3c19358a > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > c15c9d41cb > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 2beed1df85 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > cf2c2574da > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 5fe0d2e897 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > 4e14e83bd6 > > > Diff: https://reviews.apache.org/r/61396/diff/1/ > > > Testing > --- > > > Thanks, > > Jonathan Hurley > >
Review Request 61400: Race condition causing execution commands to fail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61400/
---
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-21646
https://issues.apache.org/jira/browse/AMBARI-21646
Repository: ambari
Description
---
STR:
1\. Execution command started
2\. Registration failed
3\. Execution command finished.
At this point we try to send an execution command result as not a registered
agent.
Which leads to exception on server or agent.
ERROR 2017-08-02 13:36:52,524 ActionQueue.py:207 - Exception while
processing EXECUTION_COMMAND command
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ambari_agent/ActionQueue.py", line
200, in process_command
self.execute_command(command)
File "/usr/lib/python2.6/site-packages/ambari_agent/ActionQueue.py", line
410, in execute_command
self.commandStatuses.put_command_status(command, roleResult)
File
"/usr/lib/python2.6/site-packages/ambari_agent/CommandStatusDict.py", line 59,
in put_command_status
self.force_update_to_server(command['clusterId'], new_report)
File
"/usr/lib/python2.6/site-packages/ambari_agent/CommandStatusDict.py", line 62,
in force_update_to_server
self.initializer_module.connection.send(message={'clusters':{cluster_id:
[report]}}, destination=Constants.COMMANDS_STATUS_REPORTS_ENDPOINT)
File "/usr/lib/python2.6/site-packages/ambari_agent/Utils.py", line 223,
in decorated
v = undecorated(self)
File
"/usr/lib/python2.6/site-packages/ambari_agent/InitializerModule.py", line 102,
in connection
conn.connect(wait=True)
File "/usr/lib/python2.6/site-packages/ambari_stomp/protocol.py", line
505, in connect
self.transport.wait_for_connection()
File
"/usr/lib/python2.6/site-packages/ambari_stomp/adapter/websocket.py", line 83,
in wait_for_connection
raise ConnectionResponseTimeout("Waiting for connection confirmation
timed out")
ConnectionResponseTimeout: Waiting for connection confirmation timed out
Diffs
-
ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py f6d304c
ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 5e5eb0d
Diff: https://reviews.apache.org/r/61400/diff/1/
Testing
---
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 61251: Dynamically determine what keytab files have been distributed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review182085 --- Ship it! Ship It! - Robert Levas On Aug. 3, 2017, 4:14 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61251/ > --- > > (Updated Aug. 3, 2017, 4:14 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Robert Levas, and Sebastian > Toader. > > > Bugs: AMBARI-21613 > https://issues.apache.org/jira/browse/AMBARI-21613 > > > Repository: ambari > > > Description > --- > > Dynamically determine what keytab files have been distributed to hosts. A > custom command should be available via the KERBEROS_CLIENT to query for the > keytab files installed on the relevant host. The communication between the > Ambari server and the agents should generate data needed to determine what > keytab files exist. > > > Diffs > - > > ambari-common/src/main/python/resource_management/core/resources/klist.py > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 1bc4c36 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > a08abab > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > e5b7afd > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > 6a2dd09 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > 39fdcf5 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > fcd57af > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/metainfo.xml > 0e42bda > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py > b2cdaa6 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py > abf58ee > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > baa9bae > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 4508527 > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > f638845 > > > Diff: https://reviews.apache.org/r/61251/diff/4/ > > > Testing > --- > > 1. > - created a cluster with kerberos enabled > - deleted a keytab file from a host > - regenerated missing keytabs > - checked that the deleted keytab file was recreated > > 2. > - regenerated missing keytabs when no keytab files were missing > - checked that no keytab file was regenerated > > 3. > - created a 15 nodes cluster on openstack with services: HDFS, YARN, > ZOOKEEPER, SPARK1, SPARK2, HIVE > - measured the time taken to regenerate all keytabs and only missing keytabs: > > regenerate missing keytabs only: 12.84 seconds (?=2.33) > regenerate all keytabs: 39.1 seconds (?=5.37) > > existing tests: > > server: > Ran 246 tests in 6.999s > OK > -- > Total run:1146 > Total errors:0 > Total failures:0 > > Results : > Tests run: 4816, Failures: 0, Errors: 0, Skipped: 35 > > agent: > Ran 470 tests in 98.589s > OK > > > Thanks, > > Attila Magyar > >
Re: Review Request 61251: Dynamically determine what keytab files have been distributed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/ --- (Updated Aug. 3, 2017, 8:14 a.m.) Review request for Ambari, Balázs Bence Sári, Robert Levas, and Sebastian Toader. Changes --- sudo for running klist Bugs: AMBARI-21613 https://issues.apache.org/jira/browse/AMBARI-21613 Repository: ambari Description --- Dynamically determine what keytab files have been distributed to hosts. A custom command should be available via the KERBEROS_CLIENT to query for the keytab files installed on the relevant host. The communication between the Ambari server and the agents should generate data needed to determine what keytab files exist. Diffs (updated) - ambari-common/src/main/python/resource_management/core/resources/klist.py PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 1bc4c36 ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java a08abab ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e5b7afd ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 6a2dd09 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py 39fdcf5 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py fcd57af ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/metainfo.xml 0e42bda ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py b2cdaa6 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py abf58ee ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java baa9bae ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 4508527 ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py f638845 Diff: https://reviews.apache.org/r/61251/diff/4/ Changes: https://reviews.apache.org/r/61251/diff/3-4/ Testing (updated) --- 1. - created a cluster with kerberos enabled - deleted a keytab file from a host - regenerated missing keytabs - checked that the deleted keytab file was recreated 2. - regenerated missing keytabs when no keytab files were missing - checked that no keytab file was regenerated 3. - created a 15 nodes cluster on openstack with services: HDFS, YARN, ZOOKEEPER, SPARK1, SPARK2, HIVE - measured the time taken to regenerate all keytabs and only missing keytabs: regenerate missing keytabs only: 12.84 seconds (?=2.33) regenerate all keytabs: 39.1 seconds (?=5.37) existing tests: server: Ran 246 tests in 6.999s OK -- Total run:1146 Total errors:0 Total failures:0 Results : Tests run: 4816, Failures: 0, Errors: 0, Skipped: 35 agent: Ran 470 tests in 98.589s OK Thanks, Attila Magyar
