Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi
Done. Thanks Sid. 
 
Regards,
Chandana Mirashi
IBM Silicon Valley Laboratory
Phone: (408)463-2826 T/L: 543-2826




From:   Sid Wagle 
To: Sid Wagle , Balázs Bence Sári 
, Juanjo Marron 
Cc: Chandana Mirashi , Alejandro Fernandez 
, Ambari 
Date:   08/17/2017 02:45 PM
Subject:Re: Review Request 61043: AMBARI-21325: Quicklink support 
through Knox
Sent by:Sid Wagle 



This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/61043/ 

On July 28th, 2017, 2:41 p.m. UTC, Balázs Bence Sári wrote:

ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
(Diff revision 2) 


67
  private String supportsKnox;
Why not boolean?
On August 4th, 2017, 4:53 p.m. UTC, Chandana Mirashi wrote:
I followed similar property (require_username)) that was already added to 
Link.java. Ref AMBARI-11268.
Hi Chandana, Could you please mark the issues already fixed as Fixed and 
something like this as Dropped? Makes it easy for the next review.
Reviewer can reopen the issue if there is disagreement. Thanks.

- Sid

On August 17th, 2017, 9:40 p.m. UTC, Chandana Mirashi wrote:

Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid 
Wagle.
By Chandana Mirashi.
Updated Aug. 17, 2017, 9:40 p.m.
Bugs: AMBARI-21325 
Repository: ambari 
Description 

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 

   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on 
whether SSL is enabled for the services listed above, the port and 
protocol in params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in 
the quicklinks.json for the service/component.
Testing 



1.  ambari-server: mvn test


2.  mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py 
test


3.  ambari-web: mvn test
 21213 passing (54s)
 128 pending


Diffs 
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
(1d2e712)
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 
(4558069)
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 
(5568122)
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 
(a4216e3)
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 
(43cf641)
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 
(36f71b5)
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 
(0aca8e3)
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 
(df4c1b4)
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
 
(PRE-CREATION)
ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 
(1805c3b)
ambari-web/app/views/common/quick_view_link_view.js (5888acb)
View Diff






Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Sid Wagle


> On July 28, 2017, 2:41 p.m., Balázs Bence Sári wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
> > Lines 67 (patched)
> > 
> >
> > Why not boolean?
> 
> Chandana Mirashi wrote:
> I followed similar property (require_username)) that was already added to 
> Link.java. Ref AMBARI-11268.

Hi Chandana, Could you please mark the issues already fixed as Fixed and 
something like this as Dropped? Makes it easy for the next review.
Reviewer can reopen the issue if there is disagreement. Thanks.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181664
---


On Aug. 17, 2017, 9:40 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated Aug. 17, 2017, 9:40 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  43cf641 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js 5888acb 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/3/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>



Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/
---

(Updated Aug. 17, 2017, 9:40 p.m.)


Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.


Changes
---

Updated patch with Aug 15th build corresponding to new patch submitted to 
AMBARI-21325.


Bugs: AMBARI-21325
https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
---

Add quicklink support through Knox.
Changes:
1. Add new json properties knox_url, knox_path, supports_knox
   a. knox_url: template to be used for urls that are proxied through Knox 
   b. knox_path: Knox gateway path that will be added to the proxy url.
   c. supports_knox: whether link will be redirected through Knox
2. Add above json properties to quicklinks.json
3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
SPARKUI services to Knox topology template.
4. Automate protocol and port added to Knox topology file. Based on whether SSL 
is enabled for the services listed above, the port and protocol in 
params_linux.py will be updated.
5. Update quick_view_link_view.js so that when Knox is installed and 
support_knox is true, quicklink url follows knox url template specified in the 
quicklinks.json for the service/component.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
1d2e712 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 4558069 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
 43cf641 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
 0aca8e3 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
 df4c1b4 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
  ambari-web/app/views/common/quick_view_link_view.js 5888acb 


Diff: https://reviews.apache.org/r/61043/diff/3/

Changes: https://reviews.apache.org/r/61043/diff/2-3/


Testing
---

1. ambari-server: mvn test
2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
3. ambari-web: mvn test
 21213 passing (54s)
 128 pending


Thanks,

Chandana Mirashi



Re: Review Request 60981: EU failure: Oozie service check fails if Falcon is not installed

2017-08-17 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60981/#review183158
---


Ship it!




Ship It!

- Sid Wagle


On Aug. 17, 2017, 10:31 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60981/
> ---
> 
> (Updated Aug. 17, 2017, 10:31 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-21525
> https://issues.apache.org/jira/browse/AMBARI-21525
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If a cluster is installed without Falcon then service check fails for Oozie 
> during upgrade.
> 
> Error message:
> {code}
> 2017-06-19 12:01:32,848 FATAL Services:514 - 
> SERVER[abokor-eu-2.openstacklocal] E0113: class not found 
> [org.apache.oozie.extensions.OozieELExtensions]
> org.apache.oozie.service.ServiceException: E0113: class not found 
> [org.apache.oozie.extensions.OozieELExtensions]
> at org.apache.oozie.service.ELService.findMethod(ELService.java:226)
> at 
> org.apache.oozie.service.ELService.extractFunctions(ELService.java:104)
> at org.apache.oozie.service.ELService.init(ELService.java:135)
> at 
> org.apache.oozie.service.Services.setServiceInternal(Services.java:386)
> at org.apache.oozie.service.Services.setService(Services.java:372)
> at org.apache.oozie.service.Services.loadServices(Services.java:305)
> at org.apache.oozie.service.Services.init(Services.java:213)
> at 
> org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServicesLoader.java:46)
> at 
> org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4276)
> at 
> org.apache.catalina.core.StandardContext.start(StandardContext.java:4779)
> at 
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:803)
> at 
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:780)
> at 
> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:583)
> at 
> org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:676)
> at 
> org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:602)
> at 
> org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:503)
> at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1322)
> at 
> org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:325)
> at 
> org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
> at 
> org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1069)
> at org.apache.catalina.core.StandardHost.start(StandardHost.java:822)
> at 
> org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1061)
> at 
> org.apache.catalina.core.StandardEngine.start(StandardEngine.java:463)
> at 
> org.apache.catalina.core.StandardService.start(StandardService.java:525)
> at 
> org.apache.catalina.core.StandardServer.start(StandardServer.java:761)
> at org.apache.catalina.startup.Catalina.start(Catalina.java:595)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
> at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)
> {code}
> 
> Once Falcon is installed on the cluster, service check & upgrade passes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/oozie-site.xml
>  d46069d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/oozie-site.xml
>  1473961 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/oozie-site.xml
>  eb179e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e660742 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
>  191e667 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 855d33ad 
> 
> 
> Diff: https://reviews.apache.org/r/60981/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>



Re: Review Request 61718: Log Search UI: implement histogram filtering by all possible criterias

2017-08-17 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61718/#review183143
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Aug. 17, 2017, 4:52 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61718/
> ---
> 
> (Updated Aug. 17, 2017, 4:52 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-21747
> https://issues.apache.org/jira/browse/AMBARI-21747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Service logs histogram API request should contain parameters for filtering by 
> message/cluster/component/level/hostname.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  5402214 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts
>  125b237 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts
>  57a147c 
> 
> 
> Diff: https://reviews.apache.org/r/61718/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 78 of 78 SUCCESS (1.429 secs / 1.39 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>



Review Request 61718: Log Search UI: implement histogram filtering by all possible criterias

2017-08-17 Thread Andrii Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61718/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-21747
https://issues.apache.org/jira/browse/AMBARI-21747


Repository: ambari


Description
---

Service logs histogram API request should contain parameters for filtering by 
message/cluster/component/level/hostname.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts
 5402214 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts
 125b237 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts
 57a147c 


Diff: https://reviews.apache.org/r/61718/diff/1/


Testing
---

Executed 78 of 78 SUCCESS (1.429 secs / 1.39 secs)


Thanks,

Andrii Babiichuk



Re: Review Request 61660: Service and Patch Upgrade Catalog Changes for 2.6 - additional fixes

2017-08-17 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61660/#review183140
---


Ship it!




Ship It!

- Nate Cole


On Aug. 17, 2017, 6:10 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61660/
> ---
> 
> (Updated Aug. 17, 2017, 6:10 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21728
> https://issues.apache.org/jira/browse/AMBARI-21728
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Things that were missing:
> - Address Jonathan's comment at https://reviews.apache.org/r/61503/
> - Oracle DB support
> - Test coverage for AMBARI-21169
> 
> Also, will publish patch for trunk (forward-port an upgrade catalog) in a 
> separate review request
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 01bec59e86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> bed21e8e04 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java
>  603c33b919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java
>  34358a9283 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java
>  602117acf8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java
>  2df4547b97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java
>  fa8ba027db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java
>  b0aac455e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  d14021bc21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  d576cc8ef4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61660/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>



Re: Review Request 61717: Log Search UI: set interval between values for service logs histogram depending on time range

2017-08-17 Thread Andrii Tkach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61717/#review183139
---


Ship it!




Ship It!

- Andrii Tkach


On Aug. 17, 2017, 3:33 p.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61717/
> ---
> 
> (Updated Aug. 17, 2017, 3:33 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-21746
> https://issues.apache.org/jira/browse/AMBARI-21746
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Interval between values of histogram is specified by API request parameter. 
> Its value should vary depending on filtering time range.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>  21b7116 
> 
> 
> Diff: https://reviews.apache.org/r/61717/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 78 of 78 SUCCESS (1.546 secs / 1.498 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>



Review Request 61717: Log Search UI: set interval between values for service logs histogram depending on time range

2017-08-17 Thread Andrii Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61717/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-21746
https://issues.apache.org/jira/browse/AMBARI-21746


Repository: ambari


Description
---

Interval between values of histogram is specified by API request parameter. Its 
value should vary depending on filtering time range.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts
 21b7116 


Diff: https://reviews.apache.org/r/61717/diff/1/


Testing
---

Executed 78 of 78 SUCCESS (1.546 secs / 1.498 secs)


Thanks,

Andrii Babiichuk



Re: Review Request 61715: package_regex in get_package_from_available() can match wrong pkg

2017-08-17 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61715/#review183135
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Сер. 17, 2017, 3:02 після полудня, Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61715/
> ---
> 
> (Updated Сер. 17, 2017, 3:02 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21744
> https://issues.apache.org/jira/browse/AMBARI-21744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Due to the issue with regex (missing ^ and $ boundaries), 
> resource_management.libraries.script.script.Script#get_package_from_available 
> may return wrong package.
> {code}
> >>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
> ...print 'YES'
> ...
> YES
> >>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
> ...print 'YES'
> ...
> YES
> {code}
> 
> In this case, the first package name from a list of available packages will 
> be returned.
> The impact of bug is that we may install a wrong package if it's simillary 
> named and goes first at list. Patch is a single-line fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 54a7e6df6f 
> 
> 
> Diff: https://reviews.apache.org/r/61715/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>



Review Request 61715: package_regex in get_package_from_available() can match wrong pkg

2017-08-17 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61715/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21744
https://issues.apache.org/jira/browse/AMBARI-21744


Repository: ambari


Description
---

Due to the issue with regex (missing ^ and $ boundaries), 
resource_management.libraries.script.script.Script#get_package_from_available 
may return wrong package.
{code}
>>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
>>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
...print 'YES'
...
YES
>>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
...print 'YES'
...
YES
{code}

In this case, the first package name from a list of available packages will be 
returned.
The impact of bug is that we may install a wrong package if it's simillary 
named and goes first at list. Patch is a single-line fix.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
54a7e6df6f 


Diff: https://reviews.apache.org/r/61715/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko



Re: Review Request 61695: Upgrade Associated Repository is Wrong for Downgrades and Patches

2017-08-17 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61695/#review183133
---


Ship it!




Ship It!

- Nate Cole


On Aug. 16, 2017, 3:09 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61695/
> ---
> 
> (Updated Aug. 16, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-21734
> https://issues.apache.org/jira/browse/AMBARI-21734
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During a patch reversion, the associated repository of the upgrade was the 
> target. This seems wrong as the associated version on a downgrade is the 
> single repo that you're coming from. 
> 
> When this was changed, it caused problems setting the desired repository, so 
> something is definitely wrong here. 
> 
> Also, there were some leftover Python changes related to reversion/downgrades 
> which I included in this.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  6ae71ef9f5 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/upgrade_summary.py
>  f2f5e425fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  4a28f5694c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java
>  0f7ac720b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  3d7f5336d3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  b75ff132fc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py
>  9121923a18 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  886156a833 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  101cd409a0 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  769e6ec4be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  349ff5cb02 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/upgrade.py
>  e79a8ad218 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  bf00f132aa 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_metastore.py
>  7728ac6b11 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_server_upgrade.py
>  0105a7d08e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
>  e9d62b188c 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/kafka_broker.py
>  b8d44f045f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/params.py
>  799866a3b7 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/upgrade.py
>  e405cb54f3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_metastore.py
>  2705e5a2b7 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_server_upgrade.py
>  71263d4a04 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
>  770d3c5617 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KAFKA/package/scripts/kafka_broker.py
>  16e7039f95 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  973d9dd3a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  aa216f74fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  629ea9bb76 
>   ambari-server/src/test/python/TestUpgradeSummary.py 614dcd2d81 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> ac5d6ae28f 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
>  a49bbd9458 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_upgrade.py
>  9aa3d96983 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/params_linux.py
>  1e4487d02a 
> 
> 
> Diff: https://reviews.apache.org/r/61695/diff/1/
> 
> 
> Testing
> ---
> 
> 

Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183130
---


Ship it!




Ship It!

- Nate Cole


On Aug. 17, 2017, 8:28 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 26.000 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.780 
> s]
> [INFO] Ambari Server .. SUCCESS [22:28 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  0.801 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 35.469 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.024 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.351 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.979 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.025 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.027 
> s]
> [INFO] Ambari Groovy Shell  SUCCESS [  3.565 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  0.065 
> s]
> [INFO] Ambari 

Re: Review Request 61713: AMBARI-21743 Delete ranger-solr-plugin-enabled property during Cross Stack Upgrade

2017-08-17 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61713/
---

(Updated Aug. 17, 2017, 1:33 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Oliver Szabo, and 
Sumit Mohanty.


Bugs: AMBARI-21743
https://issues.apache.org/jira/browse/AMBARI-21743


Repository: ambari


Description
---

For Cross stack upgrade, after upgrading to Ambari-2.5 and then upgrading to 
stack 2.6, ranger-solr-plugin-enabled property in ranger-env config type is not 
used. Hence need to delete this config during upgrade.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
 6ed6a11 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 e5f3690 


Diff: https://reviews.apache.org/r/61713/diff/1/


Testing
---

Tested EU from IOP-4.2.5 to HDP-2.6.x


Thanks,

Mugdha Varadkar



Re: Review Request 61713: AMBARI-21743 Delete ranger-solr-plugin-enabled property during Cross Stack Upgrade

2017-08-17 Thread Gautam Borad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61713/#review183129
---


Ship it!




Ship It!

- Gautam Borad


On Aug. 17, 2017, 1:15 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61713/
> ---
> 
> (Updated Aug. 17, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Oliver Szabo, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21743
> https://issues.apache.org/jira/browse/AMBARI-21743
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Cross stack upgrade, after upgrading to Ambari-2.5 and then upgrading to 
> stack 2.6, ranger-solr-plugin-enabled property in ranger-env config type is 
> not used. Hence need to delete this config during upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6ed6a11 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  e5f3690 
> 
> 
> Diff: https://reviews.apache.org/r/61713/diff/1/
> 
> 
> Testing
> ---
> 
> Tested EU from IOP-4.2.5 to HDP-2.6.x
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>



Re: Review Request 61713: AMBARI-21743 Delete ranger-solr-plugin-enabled property during Cross Stack Upgrade

2017-08-17 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61713/#review183127
---


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 17, 2017, 1:15 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61713/
> ---
> 
> (Updated Aug. 17, 2017, 1:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Oliver Szabo, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21743
> https://issues.apache.org/jira/browse/AMBARI-21743
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Cross stack upgrade, after upgrading to Ambari-2.5 and then upgrading to 
> stack 2.6, ranger-solr-plugin-enabled property in ranger-env config type is 
> not used. Hence need to delete this config during upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6ed6a11 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  e5f3690 
> 
> 
> Diff: https://reviews.apache.org/r/61713/diff/1/
> 
> 
> Testing
> ---
> 
> Tested EU from IOP-4.2.5 to HDP-2.6.x
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>



Review Request 61713: AMBARI-21743 Delete ranger-solr-plugin-enabled property during Cross Stack Upgrade

2017-08-17 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61713/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Oliver Szabo, and 
Sumit Mohanty.


Bugs: AMBARI-21743
https://issues.apache.org/jira/browse/AMBARI-21743


Repository: ambari


Description
---

For Cross stack upgrade, after upgrading to Ambari-2.5 and then upgrading to 
stack 2.6, ranger-solr-plugin-enabled property in ranger-env config type is not 
used. Hence need to delete this config during upgrade.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
 6ed6a11 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 e5f3690 


Diff: https://reviews.apache.org/r/61713/diff/1/


Testing
---

Tested EU from IOP-4.2.5 to HDP-2.6.x


Thanks,

Mugdha Varadkar



Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Jonathan Hurley


> On Aug. 17, 2017, 4:07 a.m., Attila Doroszlai wrote:
> > ambari-project/pom.xml
> > Lines 37 (patched)
> > 
> >
> > Please override this in `ambari-server/pom.xml` using a value without 
> > `-XX:MaxPermSize=512m`.
> 
> Attila Doroszlai wrote:
> (only in trunk)
> 
> Jonathan Hurley wrote:
> This patch was actually for branch-2.6, which still uses JDK 7 and can 
> use this property. For my commit for trunk, I have this removed here anyway. 
> Do you think that's sufficient?
> 
> Attila Doroszlai wrote:
> I'm not sure.  I think most subprojects still use JDK 7 in trunk.  They 
> might be OK with the default perm. size, though.
> 
> Attila Doroszlai wrote:
> Oh, I see this property is only used in ambari-server.

Yes, other projects can choose to parameterize and adjust if they need to - 
right now, I think that ambari-server is the only one which needs the 
developers to override settings.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183108
---


On Aug. 17, 2017, 8:28 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-17 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61707/
---

(Updated Aug. 17, 2017, 8:51 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Changes
---

Added Jenkins test results - PASSED.


Bugs: AMBARI-21602
https://issues.apache.org/jira/browse/AMBARI-21602


Repository: ambari


Description
---

Pre-configure (certain) services when Kerberos is enabled to reduce number of 
core service restarts when services are added.  

While processing the Kerberos descriptor, include services marked to be 
_pre-configured_.  When a tagged service is encountered, process it weather it 
is installed or not. However if it is not installed, only apply configuration 
changes for existing configuration types.  This will set at least the core-site 
changes related to proxyuser and auth-to-local rules properties. By doing this, 
if a tagged service is later installed, the settings will already be in place 
in the existing service configs and thus the existing services will not need to 
be restarted. 

Caveats:
- Default values for the uninstalled, tagged, services will be assumed 
- The stack advisor will be used to suggest locations of components - used to 
build the clusterHostInfo structure that may be used to derive property values. 

Note: This processing is to occur when Kerberos is enabled.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 eb97ee376d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
 7ba1b1887d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 3329e76226 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 3819863763 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 6c6c43911b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 91a84ea643 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 59bd96a8f5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java
 64ead405eb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java
 d4bb501231 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/UsedIdentities.java
 46f5642eb1 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 dd2b2237e5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 2e331bb77f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PreconfigureServiceType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 60523cdd75 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 ca15695564 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 f239cffd93 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java
 78aaa77a48 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
23fd0a95f5 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
ff1d37808d 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
149579f57d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 7f53daa357 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 eba1b3aecc 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 771a23cd3f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 1f10d7e122 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 e07e28e062 
  ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
 6be9f328af 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 5afe87ebb0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 b22099973c 
  

Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Attila Doroszlai


> On Aug. 17, 2017, 10:07 a.m., Attila Doroszlai wrote:
> > ambari-project/pom.xml
> > Lines 37 (patched)
> > 
> >
> > Please override this in `ambari-server/pom.xml` using a value without 
> > `-XX:MaxPermSize=512m`.
> 
> Attila Doroszlai wrote:
> (only in trunk)
> 
> Jonathan Hurley wrote:
> This patch was actually for branch-2.6, which still uses JDK 7 and can 
> use this property. For my commit for trunk, I have this removed here anyway. 
> Do you think that's sufficient?
> 
> Attila Doroszlai wrote:
> I'm not sure.  I think most subprojects still use JDK 7 in trunk.  They 
> might be OK with the default perm. size, though.

Oh, I see this property is only used in ambari-server.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183108
---


On Aug. 17, 2017, 2:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 2:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 26.000 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.780 
> s]
> [INFO] Ambari Server .. SUCCESS [22:28 
> min]
> [INFO] Ambari Functional 

Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Attila Doroszlai


> On Aug. 17, 2017, 10:07 a.m., Attila Doroszlai wrote:
> > ambari-project/pom.xml
> > Lines 37 (patched)
> > 
> >
> > Please override this in `ambari-server/pom.xml` using a value without 
> > `-XX:MaxPermSize=512m`.
> 
> Attila Doroszlai wrote:
> (only in trunk)
> 
> Jonathan Hurley wrote:
> This patch was actually for branch-2.6, which still uses JDK 7 and can 
> use this property. For my commit for trunk, I have this removed here anyway. 
> Do you think that's sufficient?

I'm not sure.  I think most subprojects still use JDK 7 in trunk.  They might 
be OK with the default perm. size, though.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183108
---


On Aug. 17, 2017, 2:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 2:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 26.000 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.780 
> s]
> [INFO] Ambari Server .. SUCCESS [22:28 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  0.801 
> s]
> [INFO] Ambari Agent 

Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Attila Doroszlai


> On Aug. 17, 2017, 10:07 a.m., Attila Doroszlai wrote:
> > ambari-project/pom.xml
> > Lines 37 (patched)
> > 
> >
> > Please override this in `ambari-server/pom.xml` using a value without 
> > `-XX:MaxPermSize=512m`.

(only in trunk)


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183108
---


On Aug. 17, 2017, 4:02 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 4:02 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 26.000 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.780 
> s]
> [INFO] Ambari Server .. SUCCESS [22:28 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  0.801 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 35.469 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.024 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.351 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.979 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.025 
> s]
> 

Re: Review Request 61711: Add CREATE/UPDATE/DELETE actions to alert_definitions event

2017-08-17 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61711/#review183116
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Сер. 17, 2017, 10:47 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61711/
> ---
> 
> (Updated Сер. 17, 2017, 10:47 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21741
> https://issues.apache.org/jira/browse/AMBARI-21741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py b3802b1 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3d7c30c 
>   ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
> 39b88e6 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
>  0829c31 
>   ambari-agent/src/main/python/ambari_agent/main.py ece9b7a 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 38d0e9e 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definition_expected.json
>  PRE-CREATION 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json
>  cc21244 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_add.json
>  PRE-CREATION 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_delete.json
>  PRE-CREATION 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_edit.json
>  PRE-CREATION 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_small.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61711/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 61711: Add CREATE/UPDATE/DELETE actions to alert_definitions event

2017-08-17 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61711/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21741
https://issues.apache.org/jira/browse/AMBARI-21741


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py b3802b1 
  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3d7c30c 
  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
39b88e6 
  
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
 0829c31 
  ambari-agent/src/main/python/ambari_agent/main.py ece9b7a 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 38d0e9e 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definition_expected.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json
 cc21244 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_add.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_delete.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_edit.json
 PRE-CREATION 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_small.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61711/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk



Re: Review Request 60981: EU failure: Oozie service check fails if Falcon is not installed

2017-08-17 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60981/
---

(Updated Сер. 17, 2017, 10:30 до полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.


Bugs: AMBARI-21525
https://issues.apache.org/jira/browse/AMBARI-21525


Repository: ambari


Description
---

If a cluster is installed without Falcon then service check fails for Oozie 
during upgrade.

Error message:
{code}
2017-06-19 12:01:32,848 FATAL Services:514 - SERVER[abokor-eu-2.openstacklocal] 
E0113: class not found [org.apache.oozie.extensions.OozieELExtensions]
org.apache.oozie.service.ServiceException: E0113: class not found 
[org.apache.oozie.extensions.OozieELExtensions]
at org.apache.oozie.service.ELService.findMethod(ELService.java:226)
at 
org.apache.oozie.service.ELService.extractFunctions(ELService.java:104)
at org.apache.oozie.service.ELService.init(ELService.java:135)
at 
org.apache.oozie.service.Services.setServiceInternal(Services.java:386)
at org.apache.oozie.service.Services.setService(Services.java:372)
at org.apache.oozie.service.Services.loadServices(Services.java:305)
at org.apache.oozie.service.Services.init(Services.java:213)
at 
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServicesLoader.java:46)
at 
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4276)
at 
org.apache.catalina.core.StandardContext.start(StandardContext.java:4779)
at 
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:803)
at 
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:780)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:583)
at 
org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:676)
at 
org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:602)
at 
org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:503)
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1322)
at 
org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:325)
at 
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1069)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:822)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1061)
at 
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:463)
at 
org.apache.catalina.core.StandardService.start(StandardService.java:525)
at 
org.apache.catalina.core.StandardServer.start(StandardServer.java:761)
at org.apache.catalina.startup.Catalina.start(Catalina.java:595)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)
{code}

Once Falcon is installed on the cluster, service check & upgrade passes.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/oozie-site.xml
 d46069d 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/oozie-site.xml
 1473961 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/oozie-site.xml
 eb179e6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
e660742 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml
 191e667 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
855d33ad 


Diff: https://reviews.apache.org/r/60981/diff/2/

Changes: https://reviews.apache.org/r/60981/diff/1-2/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi



Re: Review Request 61710: Log Search UI: implement multiple options select for filters

2017-08-17 Thread Oleg Nechiporenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61710/#review183115
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Aug. 17, 2017, 10:10 a.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61710/
> ---
> 
> (Updated Aug. 17, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-21740
> https://issues.apache.org/jira/browse/AMBARI-21740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to select several options of given filtering instance at 
> once.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts
>  0914864 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html
>  b2ce3a0 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html
>  b777b52 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts
>  029d87b 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html
>  db4ee79 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less
>  0853883 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts
>  3e9a445 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts
>  2f8c969 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts
>  c414782 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html
>  d2de5e2 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts
>  4d6509b 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts
>  40e7d89 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html
>  caae24e 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html
>  f18285f 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts
>  d1baedc 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 
> 7715876 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts 
> 028c10d 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 
> 13a1e68 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts
>  f79ba45 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts
>  009b263 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts
>  985a0bf 
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts
>  a93eee5 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 
> 7180ebb 
> 
> 
> Diff: https://reviews.apache.org/r/61710/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>



Review Request 61710: Log Search UI: implement multiple options select for filters

2017-08-17 Thread Andrii Babiichuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61710/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-21740
https://issues.apache.org/jira/browse/AMBARI-21740


Repository: ambari


Description
---

User should be able to select several options of given filtering instance at 
once.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts
 0914864 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html
 b2ce3a0 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html
 b777b52 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts
 029d87b 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html
 db4ee79 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less
 0853883 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts
 3e9a445 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts
 2f8c969 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts
 c414782 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html
 d2de5e2 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts
 4d6509b 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts
 40e7d89 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html
 caae24e 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html
 f18285f 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts
 d1baedc 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 
7715876 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts 
028c10d 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 
13a1e68 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts
 f79ba45 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 
009b263 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts
 985a0bf 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts
 a93eee5 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 
7180ebb 


Diff: https://reviews.apache.org/r/61710/diff/1/


Testing
---

Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs)


Thanks,

Andrii Babiichuk



Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183108
---




ambari-project/pom.xml
Lines 37 (patched)


Please override this in `ambari-server/pom.xml` using a value without 
`-XX:MaxPermSize=512m`.


- Attila Doroszlai


On Aug. 17, 2017, 4:02 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61699/
> ---
> 
> (Updated Aug. 17, 2017, 4:02 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21735
> https://issues.apache.org/jira/browse/AMBARI-21735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regardless of what options are set via {{MAVEN_OPTS}} or even 
> {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg 
> lines for forked VMs:
> 
> {code}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java 
> -Xms512m -Xmx1024m -jar
> {code}
> 
> Setting argLines to different values is never picked up.
> 
> ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to 
> expose which test might have been crashing the builds. After I did this, a 
> couple of tests starting failing, most notably DDLTest.***
> 
> **Apparently we had a test case which compared the DDLs of other DBs to that 
> of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns 
> out, we had inconsistencies!***
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 91ddb45d09 
>   ambari-server/pom.xml 3ff8218a70 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 806a6aeb57 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> 779c937cca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
>  05a75b3e6a 
>   pom.xml e7d75e46c2 
> 
> 
> Diff: https://reviews.apache.org/r/61699/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  3.848 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [01:51 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.612 
> s]
> [INFO] Ambari Admin View .. SUCCESS [ 11.764 
> s]
> [INFO] ambari-utility . SUCCESS [  4.849 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.348 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  5.817 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 16.685 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.450 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.666 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.766 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.498 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [08:26 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  6.452 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  3.974 
> s]
> [INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.351 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [ 26.000 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.780 
> s]
> [INFO] Ambari Server .. SUCCESS [22:28 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  0.801 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 35.469 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.024 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.351 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  5.979 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.025 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.027 
> s]
> [INFO] Ambari Groovy Shell 

Review Request 61709: Ambari should expose whether a service is able to rolling-restart instead of hard coding service name

2017-08-17 Thread Madhuvanthi Radhakrishnan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61709/
---

Review request for Ambari, Jaimin Jetly, Jayush Luniya, Koji Sekiguchi, and 
Sumit Mohanty.


Bugs: AMBARI-21737
https://issues.apache.org/jira/browse/AMBARI-21737


Repository: ambari


Description
---

Add a new property called rollingRestartAllowed to metainfo.xml Existing logic 
of client components are not removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 0b0a5da2b0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
 764e394540 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
a8a9a0faef 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml 
f408ba38ac 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
d322adc47b 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  ambari-web/app/mappers/stack_service_mapper.js 8931066f76 
  ambari-web/app/models/stack_service_component.js eb6f2dbff7 


Diff: https://reviews.apache.org/r/61709/diff/1/


Testing
---

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 25:12 min
[INFO] Finished at: 2017-08-17T00:01:59-07:00
[INFO] Final Memory: 85M/962M
[INFO] 

Install ambari
Deploy HDP
Ensure no regression
Kafka brokers allow rolling restart

This property can be used for any other services which have components that are 
not clients but support rolling restart.


Thanks,

Madhuvanthi Radhakrishnan