Re: Review Request 62474: AMS: Add smart configs support for service

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185920
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 21, 2017, 7:57 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

> On Sept. 21, 2017, 7:37 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
> > Lines 81 (patched)
> > 
> >
> > Should we allow minimum of 0? Or is that a normal practice in other 
> > services' enhanced configs?

Fixed


> On Sept. 21, 2017, 7:37 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
> > Line 789 (original), 803 (patched)
> > 
> >
> > Unrelated query, but shouldnt this be in ams-env? We would ideally need 
> > restart of metrics collector and monitors for this change.

We need to open another Jira for this property to be handled correctly 
collector needs to tell the sink: Start writing to the monitor from now on.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185913
---


On Sept. 21, 2017, 7:57 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/
---

(Updated Sept. 21, 2017, 7:57 p.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.


Changes
---

Fixes based on comments.


Bugs: AMBARI-22034
https://issues.apache.org/jira/browse/AMBARI-22034


Repository: ambari


Description
---

Mode, memory and some other settings are hard to hand edit and can use some 
better UI tooling.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 44073ab 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 81da5c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4d33661 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 9c4fc02 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 2c9378e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 43c3685 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62474/diff/2/

Changes: https://reviews.apache.org/r/62474/diff/1-2/


Testing
---

Manually tested.


Thanks,

Sid Wagle

Re: Review Request 62474: AMS: Add smart configs support for service

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185913
---




ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
Line 70 (original), 70 (patched)


The default whitelist file will be 
/etc/ambari-metrics-collector/conf/metrics_whitelist.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
Lines 81 (patched)


Should we allow minimum of 0? Or is that a normal practice in other 
services' enhanced configs?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
Line 789 (original), 803 (patched)


Unrelated query, but shouldnt this be in ams-env? We would ideally need 
restart of metrics collector and monitors for this change.


- Aravindan Vijayan


On Sept. 21, 2017, 7:30 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:30 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.


Bugs: AMBARI-22034
https://issues.apache.org/jira/browse/AMBARI-22034


Repository: ambari


Description
---

Mode, memory and some other settings are hard to hand edit and can use some 
better UI tooling.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 44073ab 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 81da5c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4d33661 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 9c4fc02 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 2c9378e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 43c3685 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62474/diff/1/


Testing
---

Manually tested.


Thanks,

Sid Wagle

Re: Review Request 62465: AMBARI-22025. Service auto start broken due to incomplete execution command

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/
---

(Updated Sept. 21, 2017, 8:29 p.m.)


Review request for Ambari, Balázs Bence Sári, Jonathan Hurley, and Nate Cole.


Changes
---

unit test coverage


Bugs: AMBARI-22025
https://issues.apache.org/jira/browse/AMBARI-22025


Repository: ambari


Description
---

Execution commands embedded in status commands are created programmatically 
instead of deserializing JSON.  AMBARI-21361 centralized addition of 
`service_package_folder` and `hooks_folder`, but the logic is not executed in 
this case.

Fix: reuse the logic (extracted to the method `setVersions`) which adds 
`service_package_folder` and a few other parameters.

(patch is for branch-2.6)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 7b202598d5bb88d78dc8486ed2801f87efb326a8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96ed2613888c1badc50c21f540868444e5698b51 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 61e322f71a373c0e3c69d44b89ef0b270aa6a85c 


Diff: https://reviews.apache.org/r/62465/diff/2/

Changes: https://reviews.apache.org/r/62465/diff/1-2/


Testing
---

* Tested manually on local cluster per STR.
* Unit tests: `Tests run: 4909, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Re: Review Request 62467: Add UID/GID related issue with external users not listed in /etc/passwd

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/
---

(Updated Sept. 21, 2017, 6 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
---

added doc, fixed bug


Bugs: AMBARI-22027
https://issues.apache.org/jira/browse/AMBARI-22027


Repository: ambari


Description
---

Why this works?
If there is no custom uids it will use system-defined uid(behaivor before 
GID\UID feature) and will not try to use UID that occupied by external systems, 
like ldap.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
 bcd4b17 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 
a13ac24 


Diff: https://reviews.apache.org/r/62467/diff/2/

Changes: https://reviews.apache.org/r/62467/diff/1-2/


Testing
---

mvn clean test, cluster deployment.


Thanks,

Eugene Chekanskiy

Re: Review Request 62465: AMBARI-22025. Service auto start broken due to incomplete execution command

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/#review185907
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 21, 2017, 11:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62465/
> ---
> 
> (Updated Sept. 21, 2017, 11:16 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22025
> https://issues.apache.org/jira/browse/AMBARI-22025
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Execution commands embedded in status commands are created programmatically 
> instead of deserializing JSON.  AMBARI-21361 centralized addition of 
> `service_package_folder` and `hooks_folder`, but the logic is not executed in 
> this case.
> 
> Fix: reuse the logic (extracted to the method `setVersions`) which adds 
> `service_package_folder` and a few other parameters.
> 
> (patch is for branch-2.6)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  7b202598d5bb88d78dc8486ed2801f87efb326a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  96ed2613888c1badc50c21f540868444e5698b51 
> 
> 
> Diff: https://reviews.apache.org/r/62465/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested manually on local cluster per STR.
> * Unit tests: `Tests run: 4909, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62467: Add UID/GID related issue with external users not listed in /etc/passwd

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/#review185902
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
Line 159 (original), 158 (patched)


how about adding comment with meaning of None?


- Dmitro Lisnichenko


On Sept. 21, 2017, 6:32 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62467/
> ---
> 
> (Updated Sept. 21, 2017, 6:32 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22027
> https://issues.apache.org/jira/browse/AMBARI-22027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Why this works?
> If there is no custom uids it will use system-defined uid(behaivor before 
> GID\UID feature) and will not try to use UID that occupied by external 
> systems, like ldap.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  ee950e8 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  a13ac24 
> 
> 
> Diff: https://reviews.apache.org/r/62467/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deployment.
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62468: OOZIE/OOZIE_SERVER restart failed saying AttributeError: 'NoneType' object has no attribute 'upper' during EU

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62468/#review185901
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 21, 2017, 6:56 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62468/
> ---
> 
> (Updated Sept. 21, 2017, 6:56 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.
> 
> 
> Bugs: AMBARI-22030
> https://issues.apache.org/jira/browse/AMBARI-22030
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A code path that was previously added is not working with new structures.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/upgrade_summary.py
>  507bc42985 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  2f474a186a 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> dfa22fd07b 
> 
> 
> Diff: https://reviews.apache.org/r/62468/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Python change only unit tests:
> 
> --
> Total run:1192
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62468: OOZIE/OOZIE_SERVER restart failed saying AttributeError: 'NoneType' object has no attribute 'upper' during EU

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62468/
---

Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.


Bugs: AMBARI-22030
https://issues.apache.org/jira/browse/AMBARI-22030


Repository: ambari


Description
---

A code path that was previously added is not working with new structures.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/upgrade_summary.py
 507bc42985 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 2f474a186a 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
dfa22fd07b 


Diff: https://reviews.apache.org/r/62468/diff/1/


Testing
---

Manual.  Python change only unit tests:

--
Total run:1192
Total errors:0
Total failures:0


Thanks,

Nate Cole

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185899
---


Ship it!




Ship It!

- Nate Cole


On Sept. 21, 2017, 7:56 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62449/
> ---
> 
> (Updated Sept. 21, 2017, 7:56 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21919
> https://issues.apache.org/jira/browse/AMBARI-21919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos identity references should use the "reference" attribute rather than 
> rely on the "name" attribute to indicate the identity descriptor references 
> some other identity descriptor.  
> 
> Either method should work on the backend, however the UI appears to not fully 
> handle the "named" reference properly. 
> 
> The solution is to change 
> ```
> {
>   "name": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> by changing the "name" attribute to "reference" and adding a new "name" 
> reference with a unique name relative to the scope of the identity 
> descriptor. For example:
> 
> ```
> {
>   "name":"hdfs_namenode_namenode_nn"
>   "reference": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> # NOTE:
> My apologies for the large patch. However, most of the changes are to 
> `kerberos.json` files  where there are one or more changes like:
> 
> ```
> "name": "/HDFS/NAMENODE/namenode_nn",
> ```
> to
> ```
> "name": "hdfs_namenode_namenode_nn"
> "reference": "/HDFS/NAMENODE/namenode_nn",
> ```
> 
> There are also a few other file changes, related to upgrading to Ambari 
> 2.6.0, that may be more interesting to review:
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
> 
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
> - 
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> - ambari-server/src/main/resources/kerberos_descriptor_schema.json
> - 
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  a555bb5b90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  85d4f69ed8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  a1d373bad6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  c92b3dc4d3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  7e3f449b74 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
>  94b1b14f8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  a6afda5fbe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  4fe4d3272f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  e136bcf8e6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  7d10ccc667 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
>  08af720165 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 4ed6b7871d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  63e929883c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  011921b192 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603d47 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> b5acf92f3f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json
>  c34026ae81 
>   
> 

Re: Review Request 62465: AMBARI-22025. Service auto start broken due to incomplete execution command

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/#review185898
---


Ship it!




Any new tests required?

- Nate Cole


On Sept. 21, 2017, 11:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62465/
> ---
> 
> (Updated Sept. 21, 2017, 11:16 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22025
> https://issues.apache.org/jira/browse/AMBARI-22025
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Execution commands embedded in status commands are created programmatically 
> instead of deserializing JSON.  AMBARI-21361 centralized addition of 
> `service_package_folder` and `hooks_folder`, but the logic is not executed in 
> this case.
> 
> Fix: reuse the logic (extracted to the method `setVersions`) which adds 
> `service_package_folder` and a few other parameters.
> 
> (patch is for branch-2.6)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  7b202598d5bb88d78dc8486ed2801f87efb326a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  96ed2613888c1badc50c21f540868444e5698b51 
> 
> 
> Diff: https://reviews.apache.org/r/62465/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested manually on local cluster per STR.
> * Unit tests: `Tests run: 4909, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62467: Add UID/GID related issue with external users not listed in /etc/passwd

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/#review185896
---


Ship it!




Ship It!

- Robert Levas


On Sept. 21, 2017, 11:32 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62467/
> ---
> 
> (Updated Sept. 21, 2017, 11:32 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22027
> https://issues.apache.org/jira/browse/AMBARI-22027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Why this works?
> If there is no custom uids it will use system-defined uid(behaivor before 
> GID\UID feature) and will not try to use UID that occupied by external 
> systems, like ldap.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
>  ee950e8 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py
>  a13ac24 
> 
> 
> Diff: https://reviews.apache.org/r/62467/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deployment.
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 62467: Add UID/GID related issue with external users not listed in /etc/passwd

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/
---

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-22027
https://issues.apache.org/jira/browse/AMBARI-22027


Repository: ambari


Description
---

Why this works?
If there is no custom uids it will use system-defined uid(behaivor before 
GID\UID feature) and will not try to use UID that occupied by external systems, 
like ldap.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
 ee950e8 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 
a13ac24 


Diff: https://reviews.apache.org/r/62467/diff/1/


Testing
---

mvn clean test, cluster deployment.


Thanks,

Eugene Chekanskiy

Re: Review Request 62351: AMBARI-21910 Ranger Usersync config to support nested group evaluation for LDAP Sync source property

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62351/#review185894
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
Lines 398 (patched)


Maybe a better title? Like "Enabling Nested Group Sync for Ranger"


- Jonathan Hurley


On Sept. 20, 2017, 7:38 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62351/
> ---
> 
> (Updated Sept. 20, 2017, 7:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-21910
> https://issues.apache.org/jira/browse/AMBARI-21910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of RANGER-1735, we are supporting nested groups in ranger usersync. 
> For this, introduced one new property 
> "ranger.usersync.ldap.grouphierarchylevels". The value should be an integer 
> with default value as 0. This property should be under Ranger --> Configs --> 
> Ranger User Info --> Group Configs tab.
> This property can be enabled with a flag labelled as "Sync Nested Groups". 
> 1. Default value for this flag is "No"
> 2. This flag is always shown under Group Configs (even when "Enable group 
> Sync" is set to "No")
> 3. If this flag is set to "No", then the value for 
> ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 
> 4. If this flag is set to "Yes", then 
> ranger.usersync.ldap.grouphierarchylevels is shown and allowed to set any 
> integer greater than 0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  627216e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
>  a994856 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  8068a38 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  535ac2e 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 74271cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculationTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62351/diff/2/
> 
> 
> Testing
> ---
> 
> Test Fresh Installs.
> Ambari upgrade with stack 2.6.
> Unit Test passed for UpgradeCatalog260Test.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 62465: AMBARI-22025. Service auto start broken due to incomplete execution command

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/
---

Review request for Ambari, Balázs Bence Sári, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-22025
https://issues.apache.org/jira/browse/AMBARI-22025


Repository: ambari


Description
---

Execution commands embedded in status commands are created programmatically 
instead of deserializing JSON.  AMBARI-21361 centralized addition of 
`service_package_folder` and `hooks_folder`, but the logic is not executed in 
this case.

Fix: reuse the logic (extracted to the method `setVersions`) which adds 
`service_package_folder` and a few other parameters.

(patch is for branch-2.6)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 7b202598d5bb88d78dc8486ed2801f87efb326a8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96ed2613888c1badc50c21f540868444e5698b51 


Diff: https://reviews.apache.org/r/62465/diff/1/


Testing
---

* Tested manually on local cluster per STR.
* Unit tests: `Tests run: 4909, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185891
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 21, 2017, 7:56 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62449/
> ---
> 
> (Updated Sept. 21, 2017, 7:56 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21919
> https://issues.apache.org/jira/browse/AMBARI-21919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos identity references should use the "reference" attribute rather than 
> rely on the "name" attribute to indicate the identity descriptor references 
> some other identity descriptor.  
> 
> Either method should work on the backend, however the UI appears to not fully 
> handle the "named" reference properly. 
> 
> The solution is to change 
> ```
> {
>   "name": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> by changing the "name" attribute to "reference" and adding a new "name" 
> reference with a unique name relative to the scope of the identity 
> descriptor. For example:
> 
> ```
> {
>   "name":"hdfs_namenode_namenode_nn"
>   "reference": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> # NOTE:
> My apologies for the large patch. However, most of the changes are to 
> `kerberos.json` files  where there are one or more changes like:
> 
> ```
> "name": "/HDFS/NAMENODE/namenode_nn",
> ```
> to
> ```
> "name": "hdfs_namenode_namenode_nn"
> "reference": "/HDFS/NAMENODE/namenode_nn",
> ```
> 
> There are also a few other file changes, related to upgrading to Ambari 
> 2.6.0, that may be more interesting to review:
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
> 
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
> - 
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> - ambari-server/src/main/resources/kerberos_descriptor_schema.json
> - 
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  a555bb5b90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  85d4f69ed8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  a1d373bad6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  c92b3dc4d3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  7e3f449b74 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
>  94b1b14f8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  a6afda5fbe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  4fe4d3272f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  e136bcf8e6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  7d10ccc667 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
>  08af720165 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 4ed6b7871d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  63e929883c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  011921b192 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603d47 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> b5acf92f3f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json
>  c34026ae81 
>   
> 

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185889
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 21, 2017, 10:47 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62460/
> ---
> 
> (Updated Sept. 21, 2017, 10:47 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22019
> https://issues.apache.org/jira/browse/AMBARI-22019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The new Log Search web UTs are not enabled by default (as earlier it did not 
> run in headless mode), now: enable it and make it skippable
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 
> 
> 
> Diff: https://reviews.apache.org/r/62460/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests run and passed, skipped if i addeed -DskipTests
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62461: Livy not working with the default configuration

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/
---

(Updated Sept. 21, 2017, 6:30 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22021
https://issues.apache.org/jira/browse/AMBARI-22021


Repository: ambari


Description
---

This started failing with ZEPPELIN-2909, which introduces `"className": 
"org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
following exception;


java.lang.NullPointerException
at 
org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 6a9891972b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
 71d381705a 


Diff: https://reviews.apache.org/r/62461/diff/3/

Changes: https://reviews.apache.org/r/62461/diff/2-3/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62461: Livy not working with the default configuration

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/#review185886
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
Line 250 (original), 255 (patched)


It should be still `scoped`



ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
Line 101 (original), 106 (patched)


still scoped


- Jeff Zhang


On Sept. 21, 2017, 12:54 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62461/
> ---
> 
> (Updated Sept. 21, 2017, 12:54 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22021
> https://issues.apache.org/jira/browse/AMBARI-22021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This started failing with ZEPPELIN-2909, which introduces `"className": 
> "org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
> following exception;
> 
> 
> java.lang.NullPointerException
>   at 
> org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
>   at 
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
>   at 
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
>   at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
>   at 
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  6a9891972b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  71d381705a 
> 
> 
> Diff: https://reviews.apache.org/r/62461/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62461: Livy not working with the default configuration

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/
---

(Updated Sept. 21, 2017, 6:24 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22021
https://issues.apache.org/jira/browse/AMBARI-22021


Repository: ambari


Description (updated)
---

This started failing with ZEPPELIN-2909, which introduces `"className": 
"org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
following exception;


java.lang.NullPointerException
at 
org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 6a9891972b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
 71d381705a 


Diff: https://reviews.apache.org/r/62461/diff/2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62461: Livy not working with the default configuration

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/#review185885
---


Ship it!




Ship It!

- Gaurav Nagar


On Sept. 21, 2017, 12:47 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62461/
> ---
> 
> (Updated Sept. 21, 2017, 12:47 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22021
> https://issues.apache.org/jira/browse/AMBARI-22021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This started failing with ZEPPELIN-2909, which introduces `"className": 
> "org.apache.zeppelin.livy.LivySharedInterpreter". and now Livy fails with 
> following exception;`
> 
> 
> java.lang.NullPointerException
>   at 
> org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
>   at 
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
>   at 
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
>   at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
>   at 
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  6a9891972b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  71d381705a 
> 
> 
> Diff: https://reviews.apache.org/r/62461/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62461: Livy not working with the default configuration

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/
---

(Updated Sept. 21, 2017, 6:17 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22021
https://issues.apache.org/jira/browse/AMBARI-22021


Repository: ambari


Description
---

This started failing with ZEPPELIN-2909, which introduces `"className": 
"org.apache.zeppelin.livy.LivySharedInterpreter". and now Livy fails with 
following exception;`


java.lang.NullPointerException
at 
org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 6a9891972b 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
 71d381705a 


Diff: https://reviews.apache.org/r/62461/diff/2/

Changes: https://reviews.apache.org/r/62461/diff/1-2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185879
---


Ship it!




Ship It!

- Attila Magyar


On Sept. 21, 2017, 11:56 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62449/
> ---
> 
> (Updated Sept. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21919
> https://issues.apache.org/jira/browse/AMBARI-21919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos identity references should use the "reference" attribute rather than 
> rely on the "name" attribute to indicate the identity descriptor references 
> some other identity descriptor.  
> 
> Either method should work on the backend, however the UI appears to not fully 
> handle the "named" reference properly. 
> 
> The solution is to change 
> ```
> {
>   "name": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> by changing the "name" attribute to "reference" and adding a new "name" 
> reference with a unique name relative to the scope of the identity 
> descriptor. For example:
> 
> ```
> {
>   "name":"hdfs_namenode_namenode_nn"
>   "reference": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> # NOTE:
> My apologies for the large patch. However, most of the changes are to 
> `kerberos.json` files  where there are one or more changes like:
> 
> ```
> "name": "/HDFS/NAMENODE/namenode_nn",
> ```
> to
> ```
> "name": "hdfs_namenode_namenode_nn"
> "reference": "/HDFS/NAMENODE/namenode_nn",
> ```
> 
> There are also a few other file changes, related to upgrading to Ambari 
> 2.6.0, that may be more interesting to review:
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
> 
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
> - 
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> - ambari-server/src/main/resources/kerberos_descriptor_schema.json
> - 
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  a555bb5b90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  85d4f69ed8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  a1d373bad6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  c92b3dc4d3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  7e3f449b74 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
>  94b1b14f8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  a6afda5fbe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  4fe4d3272f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  e136bcf8e6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  7d10ccc667 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
>  08af720165 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 4ed6b7871d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  63e929883c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  011921b192 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603d47 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> b5acf92f3f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json
>  c34026ae81 
>   
> 

Review Request 62461: Livy not working with the default configuration

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22021
https://issues.apache.org/jira/browse/AMBARI-22021


Repository: ambari


Description
---

This started failing with ZEPPELIN-2909, which introduces `"className": 
"org.apache.zeppelin.livy.LivySharedInterpreter". and now Livy fails with 
following exception;`


java.lang.NullPointerException
at 
org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
 6a9891972b 


Diff: https://reviews.apache.org/r/62461/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Robert Levas]

> On Sept. 21, 2017, 3:02 a.m., Attila Magyar wrote:
> > ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/kerberos.json
> > Lines 69 (patched)
> > 
> >
> > is it ok to not have backslash here?

It is technically ok to not have a backslash there. However, in this case, the 
referance would not resolve to anything and thus it is a bug.  Nice catch.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185846
---


On Sept. 21, 2017, 7:56 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62449/
> ---
> 
> (Updated Sept. 21, 2017, 7:56 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21919
> https://issues.apache.org/jira/browse/AMBARI-21919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos identity references should use the "reference" attribute rather than 
> rely on the "name" attribute to indicate the identity descriptor references 
> some other identity descriptor.  
> 
> Either method should work on the backend, however the UI appears to not fully 
> handle the "named" reference properly. 
> 
> The solution is to change 
> ```
> {
>   "name": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> by changing the "name" attribute to "reference" and adding a new "name" 
> reference with a unique name relative to the scope of the identity 
> descriptor. For example:
> 
> ```
> {
>   "name":"hdfs_namenode_namenode_nn"
>   "reference": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> # NOTE:
> My apologies for the large patch. However, most of the changes are to 
> `kerberos.json` files  where there are one or more changes like:
> 
> ```
> "name": "/HDFS/NAMENODE/namenode_nn",
> ```
> to
> ```
> "name": "hdfs_namenode_namenode_nn"
> "reference": "/HDFS/NAMENODE/namenode_nn",
> ```
> 
> There are also a few other file changes, related to upgrading to Ambari 
> 2.6.0, that may be more interesting to review:
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
> 
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
> - 
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> - ambari-server/src/main/resources/kerberos_descriptor_schema.json
> - 
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  a555bb5b90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  85d4f69ed8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  a1d373bad6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  c92b3dc4d3 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  7e3f449b74 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
>  94b1b14f8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  a6afda5fbe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  4fe4d3272f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  e136bcf8e6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  7d10ccc667 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
>  08af720165 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 4ed6b7871d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  63e929883c 
>   

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/
---

(Updated Sept. 21, 2017, 7:56 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-21919
https://issues.apache.org/jira/browse/AMBARI-21919


Repository: ambari


Description
---

Kerberos identity references should use the "reference" attribute rather than 
rely on the "name" attribute to indicate the identity descriptor references 
some other identity descriptor.  

Either method should work on the backend, however the UI appears to not fully 
handle the "named" reference properly. 

The solution is to change 
```
{
  "name": "/HDFS/NAMENODE/namenode_nn",
  "principal": {
"configuration": 
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
  },
  "keytab": {
"configuration": 
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
  }
}
```

by changing the "name" attribute to "reference" and adding a new "name" 
reference with a unique name relative to the scope of the identity descriptor. 
For example:

```
{
  "name":"hdfs_namenode_namenode_nn"
  "reference": "/HDFS/NAMENODE/namenode_nn",
  "principal": {
"configuration": 
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
  },
  "keytab": {
"configuration": 
"ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
  }
}
```

# NOTE:
My apologies for the large patch. However, most of the changes are to 
`kerberos.json` files  where there are one or more changes like:

```
"name": "/HDFS/NAMENODE/namenode_nn",
```
to
```
"name": "hdfs_namenode_namenode_nn"
"reference": "/HDFS/NAMENODE/namenode_nn",
```

There are also a few other file changes, related to upgrading to Ambari 2.6.0, 
that may be more interesting to review:
- 
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
  
- 
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
- 
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
- ambari-server/src/main/resources/kerberos_descriptor_schema.json
- 
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java


Diffs (updated)
-

  
ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json 
a555bb5b90 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 85d4f69ed8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 a1d373bad6 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 c92b3dc4d3 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
 7e3f449b74 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
 94b1b14f8c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
 a6afda5fbe 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json 
4fe4d3272f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
e136bcf8e6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json 
7d10ccc667 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json 
08af720165 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
4ed6b7871d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
63e929883c 
  
ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json 
011921b192 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
1cf1603d47 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
b5acf92f3f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json 
c34026ae81 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/kerberos.json 
af1130dbd1 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json 
b4d0018e8e 
  ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json 
b4d0018e8e 
  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
247a602c71 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json
 6ab76106b6 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/kerberos.json
 6ab76106b6 
  

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185874
---


Ship it!




Ship It!

- Miklos Gergely


On Sept. 21, 2017, 10:47 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62460/
> ---
> 
> (Updated Sept. 21, 2017, 10:47 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22019
> https://issues.apache.org/jira/browse/AMBARI-22019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The new Log Search web UTs are not enabled by default (as earlier it did not 
> run in headless mode), now: enable it and make it skippable
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 
> 
> 
> Diff: https://reviews.apache.org/r/62460/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests run and passed, skipped if i addeed -DskipTests
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185873
---


Ship it!




Ship It!

- Attila Magyar


On Sept. 21, 2017, 10:47 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62460/
> ---
> 
> (Updated Sept. 21, 2017, 10:47 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22019
> https://issues.apache.org/jira/browse/AMBARI-22019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The new Log Search web UTs are not enabled by default (as earlier it did not 
> run in headless mode), now: enable it and make it skippable
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 
> 
> 
> Diff: https://reviews.apache.org/r/62460/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests run and passed, skipped if i addeed -DskipTests
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185872
---


Ship it!




Ship It!

- Andrii Babiichuk


On Вер. 21, 2017, 10:47 до полудня, Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62460/
> ---
> 
> (Updated Вер. 21, 2017, 10:47 до полудня)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22019
> https://issues.apache.org/jira/browse/AMBARI-22019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The new Log Search web UTs are not enabled by default (as earlier it did not 
> run in headless mode), now: enable it and make it skippable
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 
> 
> 
> Diff: https://reviews.apache.org/r/62460/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests run and passed, skipped if i addeed -DskipTests
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/
---

Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, and 
Robert Nettleton.


Bugs: AMBARI-22019
https://issues.apache.org/jira/browse/AMBARI-22019


Repository: ambari


Description
---

The new Log Search web UTs are not enabled by default (as earlier it did not 
run in headless mode), now: enable it and make it skippable


Diffs
-

  ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 


Diff: https://reviews.apache.org/r/62460/diff/1/


Testing
---

unit tests run and passed, skipped if i addeed -DskipTests


Thanks,

Oliver Szabo

Re: Review Request 62456: Add JMX enable/disable option to Infra Solr

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62456/#review185868
---


Ship it!




Ship It!

- Attila Magyar


On Sept. 21, 2017, 9:29 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62456/
> ---
> 
> (Updated Sept. 21, 2017, 9:29 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22013
> https://issues.apache.org/jira/browse/AMBARI-22013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Add jmx enable option to Infra Solr stack (also change the default value 
> from true to false)
> - Add java.rmi.server.hostname property to the solr env file (add this to the 
> docker environment) to make JMX RMI communication work with JConsole.
> - Set the infra solr property ordering in ambari-web
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh faaa6ff 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh 11b9fe0 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  e4ea885 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  5cc344e 
>   ambari-web/app/data/configs/services/ambari_infra_properties.js aae7fa5 
> 
> 
> Diff: https://reviews.apache.org/r/62456/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually on 3 node cluster
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62454: Could not copy tez tarball to HDFS during prepare upgrade (EU)

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62454/#review185866
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 20, 2017, 11:51 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62454/
> ---
> 
> (Updated Sept. 20, 2017, 11:51 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22011
> https://issues.apache.org/jira/browse/AMBARI-22011
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The lookup of versions was failing because a property is no longer being 
> passed.  Use the UpgradeSummary structure to check for versions.  New 
> behavior is consistent with older versions of Ambari.
> 
> 2017-09-19 11:42:05,742 - Before starting Stack Upgrade, check if tez tarball 
> has been copied to HDFS.
> 2017-09-19 11:42:05,742 - Stack version 2.6.0.0 is sufficient to check if 
> need to copy tez.tar.gz to HDFS.
> 2017-09-19 11:42:05,742 - Called copy_to_hdfs tarball: tez
> 2017-09-19 11:42:05,743 - Stack Feature Version Info: Cluster Stack=2.6, 
> Command Stack=None, Command Version=2.5.3.0-37, Upgrade Direction=upgrade -> 
> 2.5.3.0-37
> 2017-09-19 11:42:05,743 - Skipping stack-select on RU_EXECUTE_TASKS because 
> it does not exist in the stack-select package structure.
> 2017-09-19 11:42:05,743 - Unable to determine the current version of the 
> component for this command; unable to copy the tarball
> 2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack 
> version could be be determined.
> 2017-09-19 11:42:05,743 - Cannot copy tez tarball to HDFS because stack 
> version could be be determined.
> 2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or 
> incorrect parameter.
> 2017-09-19 11:42:05,744 - Could not copy tarball tez due to a missing or 
> incorrect parameter.
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
>  line 58, in 
> TezPreUpgrade().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 327, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py",
>  line 55, in prepare
> raise Fail("Could not copy tez tarball to HDFS.")
> resource_management.core.exceptions.Fail: Could not copy tez tarball to HDFS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  e0dd96de1e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  64e1cc1c94 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py
>  8bdfe46230 
> 
> 
> Diff: https://reviews.apache.org/r/62454/diff/2/
> 
> 
> Testing
> ---
> 
> Manual EU including Tez succeeded.  We have no direct tests of copy_tarballs 
> so only manual verification.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62448: Addition of service component after patching a service still keeps the component at base version

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/#review185865
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 20, 2017, 10:59 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62448/
> ---
> 
> (Updated Sept. 20, 2017, 10:59 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22007
> https://issues.apache.org/jira/browse/AMBARI-22007
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This bug will affect adding components to hosts where other versions of the 
> component was already installed. It occurs because Storm was already 
> installed on the machine you added the Supervisor to and the symlinks were 
> already created with the older version. 
> 
> Example:
> {code:title=After Patch, Before Adding Supervisor}
> /usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
> /usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
> /usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
> {code}
> 
> The installation of any Storm component causes the symlink for 
> {{storm-supervisor}} to also get created. However, when the upgrade was 
> applied, it didn't upgrade supervisor on this machine since it technically 
> wasn't installed there (at least as far as Ambari is concerned).
> 
> Any other test which follows this pattern will fail until I can fix this. 
> However, adding a branch new host should work correctly and install the new 
> version.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  9fbb42bec5 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 59401669f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  135171391f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  3c15d92948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  e1da8131ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
>  aa298944fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  b812476d31 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  72269f0f7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  3ab28e9a5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  afd3d1d6a5 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 796d9b2d7a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c0026013c0 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql d78c1c78c6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 90f1397b94 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> c4bb76314b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f7aa912ec 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
>  cd8b499e1e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  ddff0e9560 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2b70 
> 
> 
> Diff: https://reviews.apache.org/r/62448/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Patch Upgrade follow by adding components
> New cluster deployment via UI using ambiguous repo
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62456: Add JMX enable/disable option to Infra Solr

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62456/#review185858
---


Ship it!




Ship It!

- Miklos Gergely


On Sept. 21, 2017, 9:29 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62456/
> ---
> 
> (Updated Sept. 21, 2017, 9:29 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22013
> https://issues.apache.org/jira/browse/AMBARI-22013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Add jmx enable option to Infra Solr stack (also change the default value 
> from true to false)
> - Add java.rmi.server.hostname property to the solr env file (add this to the 
> docker environment) to make JMX RMI communication work with JConsole.
> - Set the infra solr property ordering in ambari-web
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh faaa6ff 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh 11b9fe0 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  e4ea885 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  5cc344e 
>   ambari-web/app/data/configs/services/ambari_infra_properties.js aae7fa5 
> 
> 
> Diff: https://reviews.apache.org/r/62456/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually on 3 node cluster
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 62456: Add JMX enable/disable option to Infra Solr

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62456/
---

Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, and 
Sandor Magyari.


Bugs: AMBARI-22013
https://issues.apache.org/jira/browse/AMBARI-22013


Repository: ambari


Description
---

- Add jmx enable option to Infra Solr stack (also change the default value from 
true to false)
- Add java.rmi.server.hostname property to the solr env file (add this to the 
docker environment) to make JMX RMI communication work with JConsole.
- Set the infra solr property ordering in ambari-web


Diffs
-

  ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh faaa6ff 
  ambari-logsearch/docker/test-config/solr/solr-env.sh 11b9fe0 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
 52a5e6a 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 e4ea885 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
 5cc344e 
  ambari-web/app/data/configs/services/ambari_infra_properties.js aae7fa5 


Diff: https://reviews.apache.org/r/62456/diff/1/


Testing
---

tested manually on 3 node cluster


Thanks,

Oliver Szabo

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185846
---




ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/kerberos.json
Lines 69 (patched)


is it ok to not have backslash here?


- Attila Magyar


On Sept. 20, 2017, 5:42 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62449/
> ---
> 
> (Updated Sept. 20, 2017, 5:42 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21919
> https://issues.apache.org/jira/browse/AMBARI-21919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos identity references should use the "reference" attribute rather than 
> rely on the "name" attribute to indicate the identity descriptor references 
> some other identity descriptor.  
> 
> Either method should work on the backend, however the UI appears to not fully 
> handle the "named" reference properly. 
> 
> The solution is to change 
> ```
> {
>   "name": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> by changing the "name" attribute to "reference" and adding a new "name" 
> reference with a unique name relative to the scope of the identity 
> descriptor. For example:
> 
> ```
> {
>   "name":"hdfs_namenode_namenode_nn"
>   "reference": "/HDFS/NAMENODE/namenode_nn",
>   "principal": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.principal"
>   },
>   "keytab": {
> "configuration": 
> "ranger-hdfs-audit/xasecure.audit.jaas.Client.option.keyTab"
>   }
> }
> ```
> 
> # NOTE:
> My apologies for the large patch. However, most of the changes are to 
> `kerberos.json` files  where there are one or more changes like:
> 
> ```
> "name": "/HDFS/NAMENODE/namenode_nn",
> ```
> to
> ```
> "name": "hdfs_namenode_namenode_nn"
> "reference": "/HDFS/NAMENODE/namenode_nn",
> ```
> 
> There are also a few other file changes, related to upgrading to Ambari 
> 2.6.0, that may be more interesting to review:
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
> 
> - 
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
> - 
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> - ambari-server/src/main/resources/kerberos_descriptor_schema.json
> - 
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> 
> 
> Diffs
> -
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json
>  a555bb5b90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  85d4f69ed8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  a1d373bad6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  0b9f2c4c98 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/kerberos.json
>  7e3f449b74 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/kerberos.json
>  94b1b14f8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  a6afda5fbe 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json
>  4fe4d3272f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  e136bcf8e6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/kerberos.json
>  7d10ccc667 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/kerberos.json
>  08af720165 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 4ed6b7871d 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  63e929883c 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/kerberos.json
>  011921b192 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603d47 
>   
>