Re: Review Request 64186: Update server setup to deny GPL as default

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192237
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 29, 2017, 7:20 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 29, 2017, 7:20 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 64196: Uploading a Zero KB file to HDFS via File View Fails

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64196/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-22490
https://issues.apache.org/jira/browse/AMBARI-22490


Repository: ambari


Description
---

Removed the empty file check.


Diffs
-

  contrib/views/files/src/main/resources/ui/app/components/upload-file.js 
8a14272 


Diff: https://reviews.apache.org/r/64196/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 64196: Uploading a Zero KB file to HDFS via File View Fails

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64196/#review192219
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Nov. 30, 2017, 1:52 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64196/
> ---
> 
> (Updated Nov. 30, 2017, 1:52 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-22490
> https://issues.apache.org/jira/browse/AMBARI-22490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed the empty file check.
> 
> 
> Diffs
> -
> 
>   contrib/views/files/src/main/resources/ui/app/components/upload-file.js 
> 8a14272 
> 
> 
> Diff: https://reviews.apache.org/r/64196/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192203
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 12:20 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Changes
---

Fixed typo


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/3/

Changes: https://reviews.apache.org/r/64186/diff/2-3/


Testing
---

mvn clean test


Thanks,

Sid Wagle

Re: Review Request 64186: Update server setup to deny GPL as default

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192200
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Line 77 (original), 77 (patched)


Typo: INSTALLED


- Vivek Ratnavel Subramanian


On Nov. 30, 2017, 12:02 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:02 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64185: UI should pass repo_name for repository validation

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64185/#review192197
---


Ship it!




Ship It!

- Yusaku Sako


On Nov. 29, 2017, 11:40 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64185/
> ---
> 
> (Updated Nov. 29, 2017, 11:40 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22554
> https://issues.apache.org/jira/browse/AMBARI-22554
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI should pass Repositories/repo_name property as part of validation request 
> to API
> 
> /stacks/{stackName}/versions/{stackVersion}/operating_systems/{osType}/repositories/{repoId}
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 46f4f42 
>   ambari-web/app/controllers/installer.js afce91a 
> 
> 
> Diff: https://reviews.apache.org/r/64185/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 12:02 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/2/

Changes: https://reviews.apache.org/r/64186/diff/1-2/


Testing (updated)
---

mvn clean test


Thanks,

Sid Wagle

Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 


Diff: https://reviews.apache.org/r/64186/diff/1/


Testing
---


Thanks,

Sid Wagle

Review Request 64185: UI should pass repo_name for repository validation

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64185/
---

Review request for Ambari, Jaimin Jetly, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-22554
https://issues.apache.org/jira/browse/AMBARI-22554


Repository: ambari


Description
---

UI should pass Repositories/repo_name property as part of validation request to 
API

/stacks/{stackName}/versions/{stackVersion}/operating_systems/{osType}/repositories/{repoId}


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
46f4f42 
  ambari-web/app/controllers/installer.js afce91a 


Diff: https://reviews.apache.org/r/64185/diff/1/


Testing
---

Manually tested.


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64174/#review192169
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 350 (patched)


Will this delete existing data? Any implications of doing so?


- Sid Wagle


On Nov. 29, 2017, 8:49 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64174/
> ---
> 
> (Updated Nov. 29, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
> 
> 
> Bugs: AMBARI-22544
> https://issues.apache.org/jira/browse/AMBARI-22544
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading from Ambari 2.5.2 to Ambari 2.6.0, we hit this error 
> preventing from completing the ambari-server upgrade.
> 
> ```
> 20 Nov 2017 11:39:08,115 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: 
> Cannot delete or update a parent row: a foreign key constraint fails 
> (`ambari_01`.`clusters`, CONSTRAINT `FK_clusters_upgrade_id` FOREIGN KEY 
> (`upgrade_id`) REFERENCES `upgrade` (`upgrade_id`))
> ```
> 
> To get around this, we had to restore the db backup from 2.5.3 and adjust a 
> table in mysql with ‘update clusters set upgrade_id = null’ so a record in 
> the ‘upgrades’ table could be removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  35f9f65dc89302aaf4c555d269beb221f2c0a793 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  c6111712c3f79347234d282461e0d9f0ed5a8b75 
> 
> 
> Diff: https://reviews.apache.org/r/64174/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check of described case
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64174/
---

Review request for Ambari, Andrew Onischuk and Sid Wagle.


Bugs: AMBARI-22544
https://issues.apache.org/jira/browse/AMBARI-22544


Repository: ambari


Description
---

When upgrading from Ambari 2.5.2 to Ambari 2.6.0, we hit this error preventing 
from completing the ambari-server upgrade.

```
20 Nov 2017 11:39:08,115 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: 
Cannot delete or update a parent row: a foreign key constraint fails 
(`ambari_01`.`clusters`, CONSTRAINT `FK_clusters_upgrade_id` FOREIGN KEY 
(`upgrade_id`) REFERENCES `upgrade` (`upgrade_id`))
```

To get around this, we had to restore the db backup from 2.5.3 and adjust a 
table in mysql with ‘update clusters set upgrade_id = null’ so a record in the 
‘upgrades’ table could be removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 35f9f65dc89302aaf4c555d269beb221f2c0a793 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 c6111712c3f79347234d282461e0d9f0ed5a8b75 


Diff: https://reviews.apache.org/r/64174/diff/1/


Testing
---

mvn clean test
manual check of described case


Thanks,

Myroslav Papirkovskyy

Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63945/#review192168
---


Ship it!




Ship It!

- Nate Cole


On Nov. 20, 2017, 9:25 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63945/
> ---
> 
> (Updated Nov. 20, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22393
> https://issues.apache.org/jira/browse/AMBARI-22393
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The bootstrap process fails with code 44 incase the ambari repository URL is 
> not set for a particular os type in the ambari.properties file. Checks for 
> the returned status code from bootstrap.py and accordingly displays a prompt 
> on UI for ambari reposiory URL for the failing os types.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java
>  3d1b31c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
>  b72ca20 
>   ambari-web/app/controllers/wizard/step3_controller.js 29393e3 
>   ambari-web/app/messages.js 390f803 
>   ambari-web/app/styles/wizard.less cb9eb92 
>   ambari-web/app/templates/wizard/step3.hbs e00012c 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/63945/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web and ambari-server.
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/
---

(Updated Nov. 29, 2017, 9:21 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Changes
---

doc


Bugs: AMBARI-22550
https://issues.apache.org/jira/browse/AMBARI-22550


Repository: ambari


Description
---

Only send `/commandParams/version` if it is resolved: using unresolved version 
eg. `2.6.3.0` only causes problems.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 7630c553c0e55ffa314f02bc9c68337d502a93be 


Diff: https://reviews.apache.org/r/64173/diff/2/

Changes: https://reviews.apache.org/r/64173/diff/1-2/


Testing
---

* Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) is 
sent in "start" commands (and version is absent in "install" commands), and 
that WebHCat server is started OK.
* Tested service auto-restart for regression per steps in 
[AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
* Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/#review192166
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2017, 3 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64173/
> ---
> 
> (Updated Nov. 29, 2017, 3 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22550
> https://issues.apache.org/jira/browse/AMBARI-22550
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only send `/commandParams/version` if it is resolved: using unresolved 
> version eg. `2.6.3.0` only causes problems.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  7630c553c0e55ffa314f02bc9c68337d502a93be 
> 
> 
> Diff: https://reviews.apache.org/r/64173/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) 
> is sent in "start" commands (and version is absent in "install" commands), 
> and that WebHCat server is started OK.
> * Tested service auto-restart for regression per steps in 
> [AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
> * Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64166: History and Hive server start failed during IOP migration with AttributeError

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64166/#review192165
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2017, 11:55 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64166/
> ---
> 
> (Updated Nov. 29, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22547
> https://issues.apache.org/jira/browse/AMBARI-22547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR*
> # Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP version: 
> 4.2.5.0- (LZO is enabled in HDFS configs)
> # Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
> cd4db8e9ac0ea7ce14fc1253959a121688f34952
> # Register HDP-2.6.4.0-51 version and call remove iop-slect
> # Install the bits and start EU
> 
> *Result*
> History server start failed with below error:
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
>  line 81, in pre_upgrade_restart
> copy_to_hdfs("tez", params.user_group, params.hdfs_user, 
> skip=params.sysprep_skip_copy_tarballs_hdfs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 464, in copy_to_hdfs
> source_file = prepare_function()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 94, in _prepare_tez_tarball
> hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>   File "/usr/lib64/python2.6/posixpath.py", line 65, in join
> if b.startswith('/'):
> AttributeError: 'NoneType' object has no attribute 'startswith'
> ```
> 
> The error looks to be due to lzo changes, as the following code has the issue:
> ```
> # if enabled, LZO GPL libraries must be copied as well
>  91   if lzo_utils.should_install_lzo():
>  92 stack_root = Script.get_stack_root()
>  93 tez_version = 
> component_version.get_component_repository_version("TEZ")
>  94 hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>  95
> ```
> 
> **In this system, Tez is not installed and Hive is on MapReduce. However, the 
> Tez binaries are installed and should be updated in the event that Tez is 
> installed after upgrade.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  bd1cede834 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  2871dc0ff3 
> 
> 
> Diff: https://reviews.apache.org/r/64166/diff/1/
> 
> 
> Testing
> ---
> 
> Manual install & upgrade
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/#review192164
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
Lines 303-304 (original), 303-304 (patched)


Adjust documention to indicate why !resolved() is necessary.


- Jonathan Hurley


On Nov. 29, 2017, 3 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64173/
> ---
> 
> (Updated Nov. 29, 2017, 3 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22550
> https://issues.apache.org/jira/browse/AMBARI-22550
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only send `/commandParams/version` if it is resolved: using unresolved 
> version eg. `2.6.3.0` only causes problems.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
>  7630c553c0e55ffa314f02bc9c68337d502a93be 
> 
> 
> Diff: https://reviews.apache.org/r/64173/diff/1/
> 
> 
> Testing
> ---
> 
> * Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) 
> is sent in "start" commands (and version is absent in "install" commands), 
> and that WebHCat server is started OK.
> * Tested service auto-restart for regression per steps in 
> [AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
> * Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 64173: AMBARI-22550. Service install/start failure due to wrong version directory

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-22550
https://issues.apache.org/jira/browse/AMBARI-22550


Repository: ambari


Description
---

Only send `/commandParams/version` if it is resolved: using unresolved version 
eg. `2.6.3.0` only causes problems.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 212363b85f1ef4f4b3b91f0ddb2fe91cd897d5dc 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 7630c553c0e55ffa314f02bc9c68337d502a93be 


Diff: https://reviews.apache.org/r/64173/diff/1/


Testing
---

* Tested cluster creation: verified that resolved version (eg. 2.6.3.0-235) is 
sent in "start" commands (and version is absent in "install" commands), and 
that WebHCat server is started OK.
* Tested service auto-restart for regression per steps in 
[AMBARI-22025](https://issues.apache.org/jira/browse/AMBARI-22025).
* Added unit test.  `Tests run: 4931, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

[Robert Levas]

> On Nov. 28, 2017, 9:34 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
> > Lines 97-99 (patched)
> > 
> >
> > Nit: we've recently been using various builders for these:  
> > Sets.newHashSet(...), Map builders and the like.

Fixed in version 2.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64089/#review192031
---


On Nov. 29, 2017, 2:16 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64089/
> ---
> 
> (Updated Nov. 29, 2017, 2:16 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert Nettleton, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22481
> https://issues.apache.org/jira/browse/AMBARI-22481
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make Ambari configuration API consistent with existing API. 
> 
> The current API entry point (as of AMBARI-21307) to set and test the LDAP 
> configuration is {{/api/v1/ldapconfigs}}. This should be more inline with the 
> existing entry point for Ambari server related data...  
> `/api/v1/services/AMBARI/components/AMBARI_SERVER`.  
> 
> The new API entry point for Ambari server related configuration data should 
> be `/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations`.  For 
> the LDAP-specific configuration, the configuration category is 
> *"ldap-configuration"*.  
> 
> See AMBARI-22481 for examples on using the API.
> 
> For testing the configuration, the following directives should be used:
> 
> * `op=test-connection`
> * `op=test-attributes`
> * `op=detect-attributes`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
>  b614c5e92f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
>  2f1af512be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  fecaedc459 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
>  c7c37a6956 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
>  7bac65ec83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigOperation.java
>  478d4ff188 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
>  0e065e5f21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
>  22784cd599 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapRequestInfo.java
>  eeecfeec38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
>  0604d2bdc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  4ec15ef7e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationCategory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerLDAPConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperationStatusMetaData.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandlerFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
>  78078652f0 
>   ambari-server/src/main/java/org/apache/ambari/server/ldap/LdapModule.java 
> 089da1df7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigKeys.java
>  da655adb57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
>  6c466bae37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java
>  aafd204abc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
>  ac9c1bc8ee 
> 

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64089/
---

(Updated Nov. 29, 2017, 2:16 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Jayush Luniya, Nate Cole, Robert Nettleton, and Swapan 
Shridhar.


Changes
---

Addressed all reviewer concerns.


Bugs: AMBARI-22481
https://issues.apache.org/jira/browse/AMBARI-22481


Repository: ambari


Description
---

Make Ambari configuration API consistent with existing API. 

The current API entry point (as of AMBARI-21307) to set and test the LDAP 
configuration is {{/api/v1/ldapconfigs}}. This should be more inline with the 
existing entry point for Ambari server related data...  
`/api/v1/services/AMBARI/components/AMBARI_SERVER`.  

The new API entry point for Ambari server related configuration data should be 
`/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations`.  For the 
LDAP-specific configuration, the configuration category is 
*"ldap-configuration"*.  

See AMBARI-22481 for examples on using the API.

For testing the configuration, the following directives should be used:

* `op=test-connection`
* `op=test-attributes`
* `op=detect-attributes`


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
 b614c5e92f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
 2f1af512be 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 fecaedc459 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
 c7c37a6956 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
 7bac65ec83 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigOperation.java
 478d4ff188 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
 0e065e5f21 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
 22784cd599 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapRequestInfo.java
 eeecfeec38 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
 0604d2bdc9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 4ec15ef7e4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationCategory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerLDAPConfigurationHandler.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperationStatusMetaData.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandler.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandlerFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
 78078652f0 
  ambari-server/src/main/java/org/apache/ambari/server/ldap/LdapModule.java 
089da1df7b 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigKeys.java
 da655adb57 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
 6c466bae37 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java
 aafd204abc 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
 ac9c1bc8ee 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapFacade.java
 0118840b73 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapFacade.java
 ef84d1bb2b 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionService.java
 a9a9b539f2 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationService.java
 3f6995c48a 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupMemberAttrDetector.java
 8c34ef81aa 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupNameAttrDetector.java
 0315ef2b62 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupObjectClassDetector.java
 b681134b5a 
  

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

[Robert Levas]

> On Nov. 28, 2017, 4:45 a.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java
> > Lines 52 (patched)
> > 
> >
> > Do we need this init() method? I don't think @StaticallyInject requires 
> > it.
> 
> Nate Cole wrote:
> +1 for this comment.
> 
> Robert Levas wrote:
> I could not get my unittest to inject the objects properly, so I added 
> this. I will go back to the drawing board to try to get injection to work in 
> the unittest.

Fixed in version 2.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64089/#review192005
---


On Nov. 29, 2017, 2:16 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64089/
> ---
> 
> (Updated Nov. 29, 2017, 2:16 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert Nettleton, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22481
> https://issues.apache.org/jira/browse/AMBARI-22481
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make Ambari configuration API consistent with existing API. 
> 
> The current API entry point (as of AMBARI-21307) to set and test the LDAP 
> configuration is {{/api/v1/ldapconfigs}}. This should be more inline with the 
> existing entry point for Ambari server related data...  
> `/api/v1/services/AMBARI/components/AMBARI_SERVER`.  
> 
> The new API entry point for Ambari server related configuration data should 
> be `/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations`.  For 
> the LDAP-specific configuration, the configuration category is 
> *"ldap-configuration"*.  
> 
> See AMBARI-22481 for examples on using the API.
> 
> For testing the configuration, the following directives should be used:
> 
> * `op=test-connection`
> * `op=test-attributes`
> * `op=detect-attributes`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
>  b614c5e92f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
>  2f1af512be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  fecaedc459 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
>  c7c37a6956 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
>  7bac65ec83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigOperation.java
>  478d4ff188 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
>  0e065e5f21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
>  22784cd599 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapRequestInfo.java
>  eeecfeec38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
>  0604d2bdc9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  4ec15ef7e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationCategory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerLDAPConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperationStatusMetaData.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandlerFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
>  78078652f0 
>   ambari-server/src/main/java/org/apache/ambari/server/ldap/LdapModule.java 
> 089da1df7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigKeys.java
>  da655adb57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
>  6c466bae37 
>   
> 

Re: Review Request 64166: History and Hive server start failed during IOP migration with AttributeError

[Jonathan Hurley]

> On Nov. 29, 2017, 1:41 p.m., Dmytro Grinenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
> > Lines 96 (patched)
> > 
> >
> > seems that tez_version variable is better to rename to something like 
> > component_version or just version

That's a good point. I'll rename it.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64166/#review192153
---


On Nov. 29, 2017, 11:55 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64166/
> ---
> 
> (Updated Nov. 29, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22547
> https://issues.apache.org/jira/browse/AMBARI-22547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR*
> # Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP version: 
> 4.2.5.0- (LZO is enabled in HDFS configs)
> # Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
> cd4db8e9ac0ea7ce14fc1253959a121688f34952
> # Register HDP-2.6.4.0-51 version and call remove iop-slect
> # Install the bits and start EU
> 
> *Result*
> History server start failed with below error:
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
>  line 81, in pre_upgrade_restart
> copy_to_hdfs("tez", params.user_group, params.hdfs_user, 
> skip=params.sysprep_skip_copy_tarballs_hdfs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 464, in copy_to_hdfs
> source_file = prepare_function()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 94, in _prepare_tez_tarball
> hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>   File "/usr/lib64/python2.6/posixpath.py", line 65, in join
> if b.startswith('/'):
> AttributeError: 'NoneType' object has no attribute 'startswith'
> ```
> 
> The error looks to be due to lzo changes, as the following code has the issue:
> ```
> # if enabled, LZO GPL libraries must be copied as well
>  91   if lzo_utils.should_install_lzo():
>  92 stack_root = Script.get_stack_root()
>  93 tez_version = 
> component_version.get_component_repository_version("TEZ")
>  94 hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>  95
> ```
> 
> **In this system, Tez is not installed and Hive is on MapReduce. However, the 
> Tez binaries are installed and should be updated in the event that Tez is 
> installed after upgrade.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  bd1cede834 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  2871dc0ff3 
> 
> 
> Diff: https://reviews.apache.org/r/64166/diff/1/
> 
> 
> Testing
> ---
> 
> Manual install & upgrade
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64166: History and Hive server start failed during IOP migration with AttributeError

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64166/#review192153
---


Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
Lines 96 (patched)


seems that tez_version variable is better to rename to something like 
component_version or just version


- Dmytro Grinenko


On Nov. 29, 2017, 4:55 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64166/
> ---
> 
> (Updated Nov. 29, 2017, 4:55 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22547
> https://issues.apache.org/jira/browse/AMBARI-22547
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR*
> # Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP version: 
> 4.2.5.0- (LZO is enabled in HDFS configs)
> # Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
> cd4db8e9ac0ea7ce14fc1253959a121688f34952
> # Register HDP-2.6.4.0-51 version and call remove iop-slect
> # Install the bits and start EU
> 
> *Result*
> History server start failed with below error:
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
>  line 81, in pre_upgrade_restart
> copy_to_hdfs("tez", params.user_group, params.hdfs_user, 
> skip=params.sysprep_skip_copy_tarballs_hdfs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 464, in copy_to_hdfs
> source_file = prepare_function()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
>  line 94, in _prepare_tez_tarball
> hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>   File "/usr/lib64/python2.6/posixpath.py", line 65, in join
> if b.startswith('/'):
> AttributeError: 'NoneType' object has no attribute 'startswith'
> ```
> 
> The error looks to be due to lzo changes, as the following code has the issue:
> ```
> # if enabled, LZO GPL libraries must be copied as well
>  91   if lzo_utils.should_install_lzo():
>  92 stack_root = Script.get_stack_root()
>  93 tez_version = 
> component_version.get_component_repository_version("TEZ")
>  94 hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
> "hadoop", "lib", "native")
>  95
> ```
> 
> **In this system, Tez is not installed and Hive is on MapReduce. However, the 
> Tez binaries are installed and should be updated in the event that Tez is 
> installed after upgrade.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  bd1cede834 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  2871dc0ff3 
> 
> 
> Diff: https://reviews.apache.org/r/64166/diff/1/
> 
> 
> Testing
> ---
> 
> Manual install & upgrade
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192141
---




ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Lines 4017 (patched)


what's the difference between assemblying this JsonObjet by hand or just 
serializing with gson.toJson(serviceComponentFilter) ?


- Attila Magyar


On Nov. 29, 2017, 5:14 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> ---
> 
> (Updated Nov. 29, 2017, 5:14 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
> 
> 
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
> 
> Server actions determine what principals to process based on filters passed 
> to action, this allow:
> 
> * selective generation
> * split generation process per-host/per-service/per-component basis and make 
> generation concurrent for seperate parts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  53cceb0ded 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  83d2c9808d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80df0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  749943dc00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  ab85aa1d7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  06725003bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  a8723b7bfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  81e4b3d0bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  f27dc48ea4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
>  0898133bb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  a25931b946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java
>  5dd54ca30c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  d4e80c65d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  7e57e4ae95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  b8affb4e19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  002076d85c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  338415280f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  5ec4c1011e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  0c906592af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
>  4c80bd425e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
>  bfd5e4036d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  ff5f5cef1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  671ad95c8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  83a2106afd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java
>  PRE-CREATION 
>   
> 

Re: Review Request 64167: Update LDAP sync process to work with improved user management facility

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/#review192139
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 29, 2017, 5:06 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64167/
> ---
> 
> (Updated Nov. 29, 2017, 5:06 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21222
> https://issues.apache.org/jira/browse/AMBARI-21222
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update LDAP sync process to work with improved user management facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  816767e703 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  13c17f9778 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  bba8cf2ad2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  ec0564110c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  c3451dd084 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java
>  0f9089a342 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  34bbe9782e 
> 
> 
> Diff: https://reviews.apache.org/r/64167/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:45 min
> [INFO] Finished at: 2017-11-29T11:41:32-05:00
> [INFO] Final Memory: 98M/1962M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 64167: Update LDAP sync process to work with improved user management facility

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/#review192138
---


Ship it!




No more strings! :)

- Jonathan Hurley


On Nov. 29, 2017, 12:06 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64167/
> ---
> 
> (Updated Nov. 29, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21222
> https://issues.apache.org/jira/browse/AMBARI-21222
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update LDAP sync process to work with improved user management facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  816767e703 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  13c17f9778 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  bba8cf2ad2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  ec0564110c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  c3451dd084 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java
>  0f9089a342 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  34bbe9782e 
> 
> 
> Diff: https://reviews.apache.org/r/64167/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:45 min
> [INFO] Finished at: 2017-11-29T11:41:32-05:00
> [INFO] Final Memory: 98M/1962M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
---

(Updated Nov. 29, 2017, 5:14 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.


Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530


Repository: ambari


Description
---

Moved out of data files for principal generation.
Now before every kerberos action all info written to database.

Server actions determine what principals to process based on filters passed to 
action, this allow:

* selective generation
* split generation process per-host/per-service/per-component basis and make 
generation concurrent for seperate parts


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 53cceb0ded 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 83d2c9808d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 a7b9d80df0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 749943dc00 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 ab85aa1d7c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
 06725003bf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
 a8723b7bfa 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
 81e4b3d0bf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
 f27dc48ea4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
 0898133bb5 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
 a25931b946 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java
 5dd54ca30c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
 d4e80c65d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
 7e57e4ae95 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 b8affb4e19 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
 002076d85c 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 338415280f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 5ec4c1011e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 0c906592af 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
 4c80bd425e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
 bfd5e4036d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 ff5f5cef1c 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 671ad95c8f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 83a2106afd 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 17e484ad10 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 ca78dbb8a2 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 5ac1ac316d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a 
  

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
---

(Updated Nov. 29, 2017, 5:12 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.


Changes
---

Addresed some of the issues, fixed ignored unit tests


Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530


Repository: ambari


Description
---

Moved out of data files for principal generation.
Now before every kerberos action all info written to database.

Server actions determine what principals to process based on filters passed to 
action, this allow:

* selective generation
* split generation process per-host/per-service/per-component basis and make 
generation concurrent for seperate parts


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 53cceb0ded 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 83d2c9808d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 a7b9d80df0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 749943dc00 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 ab85aa1d7c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
 06725003bf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
 a8723b7bfa 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
 81e4b3d0bf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
 f27dc48ea4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
 0898133bb5 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
 a25931b946 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java
 5dd54ca30c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
 d4e80c65d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
 7e57e4ae95 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 b8affb4e19 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
 002076d85c 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 338415280f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 5ec4c1011e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 0c906592af 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
 4c80bd425e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
 bfd5e4036d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 ff5f5cef1c 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 671ad95c8f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 83a2106afd 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 17e484ad10 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 ca78dbb8a2 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 5ac1ac316d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86 
  

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

[Eugene Chekanskiy]

> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
> > Lines 614-616 (original), 616-618 (patched)
> > 
> >
> > It seems like `service`, `component`, and `principal` are not needed 
> > here anymore.   Maybe we should remove them from the Heartbeat request and 
> > response structures. This will require some changes on the agent side as 
> > well.

As for now I removed service and component, because it is really not needed by 
agent, but principal field will become List in future, as it will represent 
list of principals for each keytab. But this will be changed


> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
> > Lines 1902-1903 (original), 1921-1953 (patched)
> > 
> >
> > It seems like this could be simplified using more _JPA-like_ logic.  
> > Someone with more experience with JPA (than me) should probably take a look.

I guess it can, I will try. But service-component mapping will require creating 
of additional entity. But maybe it will be simpler than current variant.


> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 938 (patched)
> > 
> >
> > Technially, this _unnatural_ key is not necessary since you have a 
> > valid _natural_ key - principal, keytab, component, service.

This is done to avoid one-to-many between KerberosKeytabPrincipalEntity and 
HostEntity, and indicate that principals with kkp_id=-1 belongs to 
ambari-server only, and still have mapping to host. So for cases when 
ambari-server host does not have ambari agent, host_id will be null and kkp_id 
-1.


> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 945 (patched)
> > 
> >
> > Should host_id be part of this?

see comment above, host_id=kkp_id or host_id=null kkp_id=-1.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192040
---


On Nov. 28, 2017, 1:17 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> ---
> 
> (Updated Nov. 28, 2017, 1:17 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
> 
> 
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
> 
> Server actions determine what principals to process based on filters passed 
> to action, this allow:
> 
> * selective generation
> * split generation process per-host/per-service/per-component basis and make 
> generation concurrent for seperate parts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  53cceb0ded 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  83d2c9808d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80df0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  749943dc00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  ab85aa1d7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  a8723b7bfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java
>  0898133bb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  a25931b946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  d4e80c65d2 
>   
> 

Review Request 64167: Update LDAP sync process to work with improved user management facility

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-21222
https://issues.apache.org/jira/browse/AMBARI-21222


Repository: ambari


Description
---

Update LDAP sync process to work with improved user management facility


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 816767e703 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 13c17f9778 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 bba8cf2ad2 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 ec0564110c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 c3451dd084 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java
 0f9089a342 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 34bbe9782e 


Diff: https://reviews.apache.org/r/64167/diff/1/


Testing
---

Manually tested

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:45 min
[INFO] Finished at: 2017-11-29T11:41:32-05:00
[INFO] Final Memory: 98M/1962M
[INFO] 
```

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 64155: Update the version of Ember and jQuery for Hive View

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64155/#review192136
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Nov. 29, 2017, 12:40 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64155/
> ---
> 
> (Updated Nov. 29, 2017, 12:40 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-22542
> https://issues.apache.org/jira/browse/AMBARI-22542
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the ember and jquery versions.
> 
> 
> Diffs
> -
> 
>   contrib/views/files/src/main/resources/ui/bower.json f1472ee 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 
> 
> 
> Diff: https://reviews.apache.org/r/64155/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 64166: History and Hive server start failed during IOP migration with AttributeError

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64166/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22547
https://issues.apache.org/jira/browse/AMBARI-22547


Repository: ambari


Description
---

*STR*
# Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP version: 
4.2.5.0- (LZO is enabled in HDFS configs)
# Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
cd4db8e9ac0ea7ce14fc1253959a121688f34952
# Register HDP-2.6.4.0-51 version and call remove iop-slect
# Install the bits and start EU

*Result*
History server start failed with below error:
```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
 line 81, in pre_upgrade_restart
copy_to_hdfs("tez", params.user_group, params.hdfs_user, 
skip=params.sysprep_skip_copy_tarballs_hdfs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
 line 464, in copy_to_hdfs
source_file = prepare_function()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
 line 94, in _prepare_tez_tarball
hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, "hadoop", 
"lib", "native")
  File "/usr/lib64/python2.6/posixpath.py", line 65, in join
if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'
```

The error looks to be due to lzo changes, as the following code has the issue:
```
# if enabled, LZO GPL libraries must be copied as well
 91   if lzo_utils.should_install_lzo():
 92 stack_root = Script.get_stack_root()
 93 tez_version = 
component_version.get_component_repository_version("TEZ")
 94 hadoop_lib_native_lzo_dir = os.path.join(stack_root, tez_version, 
"hadoop", "lib", "native")
 95
```

**In this system, Tez is not installed and Hive is on MapReduce. However, the 
Tez binaries are installed and should be updated in the event that Tez is 
installed after upgrade.**


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
 bd1cede834 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 2871dc0ff3 


Diff: https://reviews.apache.org/r/64166/diff/1/


Testing
---

Manual install & upgrade


Thanks,

Jonathan Hurley

Re: Review Request 64164: LZO Upgrade pre-check is missing from BigInsights Upgrade packs

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64164/#review192132
---


Ship it!




Ship It!

- Di Li


On Nov. 29, 2017, 4:35 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64164/
> ---
> 
> (Updated Nov. 29, 2017, 4:35 p.m.)
> 
> 
> Review request for Ambari, Di Li and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22546
> https://issues.apache.org/jira/browse/AMBARI-22546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add LZO check for BI upgrade packs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  ecf57f0e4f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  a169eacc61 
> 
> 
> Diff: https://reviews.apache.org/r/64164/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.  No new unit tests.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 64164: LZO Upgrade pre-check is missing from BigInsights Upgrade packs

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64164/#review192130
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 29, 2017, 11:35 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64164/
> ---
> 
> (Updated Nov. 29, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Di Li and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22546
> https://issues.apache.org/jira/browse/AMBARI-22546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add LZO check for BI upgrade packs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  ecf57f0e4f 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  a169eacc61 
> 
> 
> Diff: https://reviews.apache.org/r/64164/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.  No new unit tests.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 64164: LZO Upgrade pre-check is missing from BigInsights Upgrade packs

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64164/
---

Review request for Ambari, Di Li and Jonathan Hurley.


Bugs: AMBARI-22546
https://issues.apache.org/jira/browse/AMBARI-22546


Repository: ambari


Description
---

Add LZO check for BI upgrade packs


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 ecf57f0e4f 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
 a169eacc61 


Diff: https://reviews.apache.org/r/64164/diff/1/


Testing
---

Manual testing.  No new unit tests.


Thanks,

Nate Cole

Re: Review Request 64147: AMBARI-22539. Cannot add host with host_name in request body

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64147/#review192129
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 29, 2017, 8:38 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64147/
> ---
> 
> (Updated Nov. 29, 2017, 8:38 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22539
> https://issues.apache.org/jira/browse/AMBARI-22539
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for one kind of `host_name` specification was [inadvertently 
> removed](https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java;h=f9604900af1e84756d2aeed3e6cee864b3586c58;hp=2a91bfe07536a4a0f49497f24aafa9108e257f94;hb=48f7fb22ae2ea61d7b05fa24703ccff2941bf8ff;hpb=88d93b92429225e03f46cb739a738b9033d45b84)
>  from `ScaleClusterRequest` in Ambari 2.6.0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  0df8f13bd922547b5951ad9bc70dd83524c5b442 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  ad90a2559b8a644b1855fedca3c6a55dc663f20f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  b8395570448b75e74cf075110467a4279051f9ac 
> 
> 
> Diff: https://reviews.apache.org/r/64147/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually per STR.
> Added unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64161: Tie MapReduce to Hive and Tez For Patch Upgrades

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64161/#review192126
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2017, 9:49 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64161/
> ---
> 
> (Updated Nov. 29, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22545
> https://issues.apache.org/jira/browse/AMBARI-22545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is currently unable to upgrade without MapReduce since the property 
> {{mapreduce.admin.user.env}} cannot properly be detected from 
> {{mapred-site}}. 
> 
> STR:
> - Install a base cluster at 2.6.3.0 with ZK, HDFS, YARN, MapR, Tez, Hive
> - Push YARN/Tez forward to 2.6.3.1-1
> - Push Hive forward to 2.6.3.2-1
> - Push MapR forward to 2.6.3.3-1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  794d2b0466 
> 
> 
> Diff: https://reviews.apache.org/r/64161/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64161: Tie MapReduce to Hive and Tez For Patch Upgrades

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64161/#review192124
---


Ship it!




Ship It!

- Dmytro Grinenko


On Nov. 29, 2017, 2:49 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64161/
> ---
> 
> (Updated Nov. 29, 2017, 2:49 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22545
> https://issues.apache.org/jira/browse/AMBARI-22545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is currently unable to upgrade without MapReduce since the property 
> {{mapreduce.admin.user.env}} cannot properly be detected from 
> {{mapred-site}}. 
> 
> STR:
> - Install a base cluster at 2.6.3.0 with ZK, HDFS, YARN, MapR, Tez, Hive
> - Push YARN/Tez forward to 2.6.3.1-1
> - Push Hive forward to 2.6.3.2-1
> - Push MapR forward to 2.6.3.3-1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  794d2b0466 
> 
> 
> Diff: https://reviews.apache.org/r/64161/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 64161: Tie MapReduce to Hive and Tez For Patch Upgrades

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64161/
---

Review request for Ambari, Dmytro Grinenko and Nate Cole.


Bugs: AMBARI-22545
https://issues.apache.org/jira/browse/AMBARI-22545


Repository: ambari


Description
---

Hive is currently unable to upgrade without MapReduce since the property 
{{mapreduce.admin.user.env}} cannot properly be detected from {{mapred-site}}. 

STR:
- Install a base cluster at 2.6.3.0 with ZK, HDFS, YARN, MapR, Tez, Hive
- Push YARN/Tez forward to 2.6.3.1-1
- Push Hive forward to 2.6.3.2-1
- Push MapR forward to 2.6.3.3-1


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 794d2b0466 


Diff: https://reviews.apache.org/r/64161/diff/1/


Testing
---

Manual


Thanks,

Jonathan Hurley

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192121
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> ---
> 
> (Updated Nov. 29, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Without proper authentication details rest calls returs with 302 (to /login), 
> that should be changed and get a 401 status
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  2fe5f7b 
> 
> 
> Diff: https://reviews.apache.org/r/64156/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64155: Update the version of Ember and jQuery for Hive View

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64155/#review192119
---


Ship it!




Ship It!

- Nitiraj Rathore


On Nov. 29, 2017, 12:40 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64155/
> ---
> 
> (Updated Nov. 29, 2017, 12:40 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-22542
> https://issues.apache.org/jira/browse/AMBARI-22542
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the ember and jquery versions.
> 
> 
> Diffs
> -
> 
>   contrib/views/files/src/main/resources/ui/bower.json f1472ee 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 
> 
> 
> Diff: https://reviews.apache.org/r/64155/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192118
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> ---
> 
> (Updated Nov. 29, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Without proper authentication details rest calls returs with 302 (to /login), 
> that should be changed and get a 401 status
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  2fe5f7b 
> 
> 
> Diff: https://reviews.apache.org/r/64156/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

[Krisztian Kasa]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192117
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> ---
> 
> (Updated Nov. 29, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Without proper authentication details rest calls returs with 302 (to /login), 
> that should be changed and get a 401 status
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  2fe5f7b 
> 
> 
> Diff: https://reviews.apache.org/r/64156/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/
---

Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert Nettleton.


Bugs: AMBARI-22543
https://issues.apache.org/jira/browse/AMBARI-22543


Repository: ambari


Description
---

Without proper authentication details rest calls returs with 302 (to /login), 
that should be changed and get a 401 status


Diffs
-

  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
 2fe5f7b 


Diff: https://reviews.apache.org/r/64156/diff/1/


Testing
---

done


Thanks,

Oliver Szabo

Review Request 64155: Update the version of Ember and jQuery for Hive View

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64155/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-22542
https://issues.apache.org/jira/browse/AMBARI-22542


Repository: ambari


Description
---

Changed the ember and jquery versions.


Diffs
-

  contrib/views/files/src/main/resources/ui/bower.json f1472ee 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 


Diff: https://reviews.apache.org/r/64155/diff/1/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 64153: Oozie stop failed during IOP migration with missing module get_lzo_packages

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64153/#review192116
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 29, 2017, 1:22 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64153/
> ---
> 
> (Updated Nov. 29, 2017, 1:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22541
> https://issues.apache.org/jira/browse/AMBARI-22541
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **STR**
> 
>   1. Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP 
> version: 4.2.5.0- (LZO is enabled in HDFS configs)
>   2. Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
> cd4db8e9ac0ea7ce14fc1253959a121688f34952
>   3. Register HDP-2.6.4.0-51 version and call remove iop-slect
>   4. Install the bits and start EU
> 
> **Result**  
> EU failed at Stop Oozie server
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py",
>  line 148, in 
> OozieServer().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 367, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py",
>  line 84, in stop
> import params
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params.py",
>  line 28, in 
> from params_linux import *
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py",
>  line 33, in 
> from resource_management.libraries.functions.get_lzo_packages import 
> get_lzo_packages
> ImportError: No module named get_lzo_packages
> 
> 
> Live cluster: 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py
>  33a309fa2e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py
>  0e6179b8a7 
> 
> 
> Diff: https://reviews.apache.org/r/64153/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 64153: Oozie stop failed during IOP migration with missing module get_lzo_packages

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64153/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Sid Wagle, 
and Vitalyi Brodetskyi.


Bugs: AMBARI-22541
https://issues.apache.org/jira/browse/AMBARI-22541


Repository: ambari


Description
---

**STR**

  1. Deployed cluster with Ambari version: 2.4.2.0_IBM_00 and HDP version: 
4.2.5.0- (LZO is enabled in HDFS configs)
  2. Upgrade Ambari to Target Version: 2.6.1.0-64 | Hash: 
cd4db8e9ac0ea7ce14fc1253959a121688f34952
  3. Register HDP-2.6.4.0-51 version and call remove iop-slect
  4. Install the bits and start EU

**Result**  
EU failed at Stop Oozie server




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py",
 line 148, in 
OozieServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 367, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie_server.py",
 line 84, in stop
import params
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params.py",
 line 28, in 
from params_linux import *
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py",
 line 33, in 
from resource_management.libraries.functions.get_lzo_packages import 
get_lzo_packages
ImportError: No module named get_lzo_packages


Live cluster: 


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py
 33a309fa2e 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py
 0e6179b8a7 


Diff: https://reviews.apache.org/r/64153/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 64147: AMBARI-22539. Cannot add host with host_name in request body

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64147/
---

Review request for Ambari, Balázs Bence Sári, Nate Cole, and Robert Nettleton.


Bugs: AMBARI-22539
https://issues.apache.org/jira/browse/AMBARI-22539


Repository: ambari


Description
---

Support for one kind of `host_name` specification was [inadvertently 
removed](https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java;h=f9604900af1e84756d2aeed3e6cee864b3586c58;hp=2a91bfe07536a4a0f49497f24aafa9108e257f94;hb=48f7fb22ae2ea61d7b05fa24703ccff2941bf8ff;hpb=88d93b92429225e03f46cb739a738b9033d45b84)
 from `ScaleClusterRequest` in Ambari 2.6.0.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 0df8f13bd922547b5951ad9bc70dd83524c5b442 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
 ad90a2559b8a644b1855fedca3c6a55dc663f20f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
 b8395570448b75e74cf075110467a4279051f9ac 


Diff: https://reviews.apache.org/r/64147/diff/1/


Testing
---

Tested manually per STR.
Added unit test.


Thanks,

Attila Doroszlai