date:20171215

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193962
---


Ship it!




Ship It!

- Nate Cole


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Nate Cole



> On Dec. 15, 2017, 2:01 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > 
> >
> > These records should just be straight up deleted, not marked this way.
> 
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if  we 
> just remove records.
> 
> Jonathan Hurley wrote:
> If the UI is deleting the records, why do we even need this?
> 
> Myroslav Papirkovskyy wrote:
> Because we cannot remove CURRENT version. This state is set if at least 
> one host finished install for all components.
> 
> Jonathan Hurley wrote:
> Gotcha...

Got it.  Looks good to me!  Ship it.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Jonathan Hurley



> On Dec. 15, 2017, 2:01 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > 
> >
> > These records should just be straight up deleted, not marked this way.
> 
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if  we 
> just remove records.
> 
> Jonathan Hurley wrote:
> If the UI is deleting the records, why do we even need this?
> 
> Myroslav Papirkovskyy wrote:
> Because we cannot remove CURRENT version. This state is set if at least 
> one host finished install for all components.

Gotcha...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193959
---


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy



> On Гру. 15, 2017, 9:01 після полудня, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > 
> >
> > These records should just be straight up deleted, not marked this way.
> 
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if  we 
> just remove records.
> 
> Jonathan Hurley wrote:
> If the UI is deleting the records, why do we even need this?

Because we cannot remove CURRENT version. This state is set if at least one 
host finished install for all components.


- Myroslav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---


On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Гру. 15, 2017, 7 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Jonathan Hurley



> On Dec. 15, 2017, 2:01 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > 
> >
> > These records should just be straight up deleted, not marked this way.
> 
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if  we 
> just remove records.

If the UI is deleting the records, why do we even need this?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy



> On Гру. 15, 2017, 9:01 після полудня, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > 
> >
> > These records should just be straight up deleted, not marked this way.

UI makes explicit call to delete host versions, which will fail if  we just 
remove records.


- Myroslav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---


On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Гру. 15, 2017, 7 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193951
---




ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
Lines 1357-1364 (patched)


These records should just be straight up deleted, not marked this way.


- Nate Cole


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193950
---



Why not just delete the records from host_version table when deleting the 
associated cluster. There is an association between repo, host_version, and 
cluster, so we can target only those which are scoped to the correct cluster.

- Jonathan Hurley


On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, noon)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193938
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 15, 2017, 5 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, 5 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193936
---




ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
Lines 1337 (patched)


i'm not sure on this, for example: if repoVersion were in the installed 
state and then we resetting it,  packages on the hosts would left; however 
initial state would allow DEREGISTER repo version, and register new one with 
same id but different actual version.

Would this cause any issue?


- Dmytro Grinenko


On Dec. 15, 2017, 5 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, 5 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193934
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Dec. 15, 2017, 7 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64652/
> ---
> 
> (Updated Dec. 15, 2017, 7 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-22659
> https://issues.apache.org/jira/browse/AMBARI-22659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unable go back in install wizard if install was finished at one of hosts.
> 
> ```
> Request 
> URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1
> 
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: 
> Repository version can't be deleted as it is used by the following hosts: 
> CURRENT on sanjay-divgi-test-2.openstacklocal, 
> sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
> sanjay-divgi-test-4.openstacklocal"
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
>  158370f3528f796e30a46862e8eb42882001ca02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
>  4a030af122dbe3ceb3c3592c000b126c864dc626 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  c23b971b85a843433f230b5a94c66ac46c5b1914 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
>  bb077d6667138acdaeaafa8b07f188b2ce3dc2af 
> 
> 
> Diff: https://reviews.apache.org/r/64652/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> manual check
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-22659
https://issues.apache.org/jira/browse/AMBARI-22659


Repository: ambari


Description
---

Unable go back in install wizard if install was finished at one of hosts.

```
Request 
URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1

{
  "status" : 500,
  "message" : "org.apache.ambari.server.controller.spi.SystemException: 
Repository version can't be deleted as it is used by the following hosts: 
CURRENT on sanjay-divgi-test-2.openstacklocal, 
sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, 
sanjay-divgi-test-4.openstacklocal"
}
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
 158370f3528f796e30a46862e8eb42882001ca02 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
 4a030af122dbe3ceb3c3592c000b126c864dc626 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 c23b971b85a843433f230b5a94c66ac46c5b1914 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java
 bb077d6667138acdaeaafa8b07f188b2ce3dc2af 


Diff: https://reviews.apache.org/r/64652/diff/1/


Testing
---

mvn clean test
manual check


Thanks,

Myroslav Papirkovskyy

Re: Review Request 64651: Revert adding repo_version column for stack table.

2017-12-15 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/#review193925
---


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 15, 2017, 4:47 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64651/
> ---
> 
> (Updated Dec. 15, 2017, 4:47 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22297
> https://issues.apache.org/jira/browse/AMBARI-22297
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack table does not need the repo_version column, so it should be removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
>  c479cdd427 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> dc77f19d63 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 333a0c3bc3 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  4313ae6028 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 1a8340ab0a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
>  d40679aea7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  730d51cb98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
>  558b334267 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
>  ca7a7aceb3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  8568b8c77e 
> 
> 
> Diff: https://reviews.apache.org/r/64651/diff/1/
> 
> 
> Testing
> ---
> 
> - Fixed related unit tests in ambari-server.
> - Unit test run: slightly improved unit test results on the feature branch. 
> See below.
> 
> Before patch test results:
> 
> Tests run: 4946, Failures: 216, Errors: 449, Skipped: 35
> 
> After patch test results:
> 
> Tests run: 4950, Failures: 216, Errors: 421, Skipped: 35
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 64651: Revert adding repo_version column for stack table.

2017-12-15 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/
---

(Updated Dec. 15, 2017, 3:47 p.m.)


Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, 
and Vitalyi Brodetskyi.


Bugs: AMBARI-22297
https://issues.apache.org/jira/browse/AMBARI-22297


Repository: ambari


Description
---

Stack table does not need the repo_version column, so it should be removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
 c479cdd427 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
dc77f19d63 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
 4313ae6028 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
1a8340ab0a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
 d40679aea7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 730d51cb98 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
 558b334267 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
 ca7a7aceb3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 8568b8c77e 


Diff: https://reviews.apache.org/r/64651/diff/1/


Testing (updated)
---

- Fixed related unit tests in ambari-server.
- Unit test run: slightly improved unit test results on the feature branch. See 
below.

Before patch test results:

Tests run: 4946, Failures: 216, Errors: 449, Skipped: 35

After patch test results:

Tests run: 4950, Failures: 216, Errors: 421, Skipped: 35


Thanks,

Balázs Bence Sári

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-15 Thread Jonathan Hurley



> On Dec. 12, 2017, 11:44 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
> > Lines 175-192 (patched)
> > 
> >
> > Interesting .. is this idempotent? Typically nested-selects with 
> > inserts are not if they could violate PKs. Maybe you need to breakt this 
> > out into 2 queries and ensure you're only inserting when necessary?
> > 
> > Then again, maybe I don't quite see what this query is doing and it's 
> > ok... Thought I'd flag it for discussion.
> 
> Robert Levas wrote:
> I assumed that this would fail if run multiple times. This is why there 
> is a conditional right before it:
> ```
> // Migrate data from users table (if not yet upgraded)
> if (!usersTableUpgraded()) {
>   dbAccessor.executeUpdate(
>   "insert into " + USER_AUTHENTICATION_TABLE +
>   "(" + USER_AUTHENTICATION_USER_AUTHENTICATION_ID_COLUMN + 
> ", " + USER_AUTHENTICATION_USER_ID_COLUMN + ", " + 
> USER_AUTHENTICATION_AUTHENTICATION_TYPE_COLUMN + ", " + 
> USER_AUTHENTICATION_AUTHENTICATION_KEY_COLUMN + ", " + 
> USER_AUTHENTICATION_CREATE_TIME_COLUMN + ", " + 
> USER_AUTHENTICATION_UPDATE_TIME_COLUMN + ")" +
>...
>   );
> }
> ```
> 
> Breaking this apart into several queries and a set of insert statements 
> might help; but I thought that it would be difficult since the updated 
> UserEntity class would be out of sync with the original table. What do others 
> do in this situation?  Maybe if I need to go this route, I would create a new 
> `user` table rather than upgrade the `users` table?  In the end, I would drop 
> the old `user` table, but the OldUserEntitiy class will need to live for many 
> versions of Ambari.

My only concern here was being able to run this again after it fails. Should we 
just drop the new table in this method if it exists? Then we can keep this 
block as-is...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193564
---


On Dec. 13, 2017, 5:01 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64544/
> ---
> 
> (Updated Dec. 13, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22577
> https://issues.apache.org/jira/browse/AMBARI-22577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate data from the users table (pre-Ambari 3.0.0) to the updated users 
> table and user_authentication tables.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
> 549c0fd7e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  513e78200d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  27514f648c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  20a06ccd54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  2de60957bc 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e58a04e4b2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql cc589e47f2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7cd083db4c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff232ebe3e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> d7c09f3381 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b4929b308d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  29f9d917e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
>  10076b0876 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  43d4d6b0c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  747f99b618 
> 
> 
> Diff: https://reviews.apache.org/r/64544/diff/2/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:21 min
> [INFO] Finished at:

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-15 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64637/#review193918
---


Ship it!




Ship It!

- Nate Cole


On Dec. 14, 2017, 10:38 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64637/
> ---
> 
> (Updated Dec. 14, 2017, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22655
> https://issues.apache.org/jira/browse/AMBARI-22655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While restarting Livy and Livy2 on a non-root cluster, the following is seen:
> 
> ```
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.repl.enableHiveContext has been deprecated as of Livy 0.4 and may be 
> removed in the future. Please use the new key livy.repl.enable-hive-context 
> instead.
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.server.csrf_protection.enabled has been deprecated as of Livy 0.4 and 
> may be removed in the future. Please use the new key 
> livy.server.csrf-protection.enabled instead.
> 17/12/14 14:36:23 INFO AccessManager: AccessControlManager acls 
> disabled;users with view permission: ;users with modify permission: ;users 
> with super permission: cstm-zeppelin;other allowed users: *
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Welcome to
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:     __
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:  / __/__  ___ _/ 
> /__
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: _\ \/ _ \/ _ `/ __/  
> '_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:/___/ .__/_,_/_/ /_/_\  
>  version 2.2.0.2.6.4.0-73
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:   /_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Using Scala version 
> 2.11.8, OpenJDK 64-Bit Server VM, 1.8.0_131
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Branch HEAD
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Compiled by user jenkins 
> on 2017-12-13T19:08:32Z
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Revision 
> a24017869f5450397136ee8b11be818e7cd3facb
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Url 
> g...@github.com:hortonworks/spark2.git
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Type --help for more 
> information.
> 17/12/14 14:36:29 WARN NativeCodeLoader: Unable to load native-hadoop library 
> for your platform... using builtin-java classes where applicable
> 17/12/14 14:36:31 INFO AHSProxy: Connecting to Application History server at 
> nat-yc-r7-ovvs-ambari-autostart-4-re-2.openstacklocal/172.22.121.144:10200
> 17/12/14 14:36:32 WARN DomainSocketFactory: The short-circuit local reads 
> feature cannot be used because libhadoop cannot be loaded.
> 17/12/14 14:36:33 INFO StateStore$: Using FileSystemStateStore for recovery.
> 17/12/14 14:36:33 INFO BatchSessionManager: Recovered 0 batch sessions. Next 
> session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Recovered 0 interactive 
> sessions. Next session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Heartbeat watchdog thread 
> started.
> 17/12/14 14:36:33 INFO LivyServer: SPNEGO auth enabled (principal = 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com)
> 17/12/14 14:36:33 INFO LivyServer: CSRF protection is enabled.
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Login using keytab 
> /etc/security/keytabs/spnego.service.keytab, for principal 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Map server: 
> nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklocal to principal: 
> [HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com], 
> added = true
> 17/12/14 14:36:34 WARN AbstractLifeCycle: FAILED 
> ServerConnector@df1cff6{SSL-http/1.1}{0.0.0.0:8999}: java.net.BindException: 
> Address already in use
> java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> ```
> 
> This occurs because the PID file cannot be accessed by the non-root agent and 
> returns an exit code of 1:
> {code}
> call returned (1, 'cat: /var/run/livy/livy-cstm-livy-server.pid: Permission 
> denied')
> {code}
> 
> This tricks out PID detection into thinking that there is no process running 
> (or a missing PID file) and therefore, we do not need to stop Livy/Livy2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  cce2148ab6 
>   
>

Re: Review Request 64611: AMBARI-22196. yum repo file contains parsing errors due to initial whitespace

2017-12-15 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64611/#review193917
---


Ship it!




Ship It!

- Balázs Bence Sári


On Dec. 14, 2017, 1:06 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64611/
> ---
> 
> (Updated Dec. 14, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> yum repo file created by Ambari results in `File contains parsing errors` due 
> to initial whitespace
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/cluster-settings.xml 
> 70b100aba3d1378a7eb0d29c1c6dc609b42d8d89 
> 
> 
> Diff: https://reviews.apache.org/r/64611/diff/1/
> 
> 
> Testing
> ---
> 
> Tested package installation via blueprint deployment.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64613: AMBARI-22249. Fix AmbariContext.serviceGroupDependencyResourceProvider initialization

2017-12-15 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64613/#review193916
---


Ship it!




Ship It!

- Balázs Bence Sári


On Dec. 14, 2017, 1:16 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64613/
> ---
> 
> (Updated Dec. 14, 2017, 1:16 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Swapan Shridhar, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Wrong variable is initialized.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  f4137683aaad84d5a66b93b4559abd7a1fb926bc 
> 
> 
> Diff: https://reviews.apache.org/r/64613/diff/1/
> 
> 
> Testing
> ---
> 
> Trivial fix.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to leftover parameter name

2017-12-15 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64614/#review193915
---


Ship it!




Ship It!

- Balázs Bence Sári


On Dec. 14, 2017, 1:25 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64614/
> ---
> 
> (Updated Dec. 14, 2017, 1:25 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22164
> https://issues.apache.org/jira/browse/AMBARI-22164
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> `serviceDisplayName` was changed to `serviceName` in both sides of the 
> assignment, but the parameter name was left as was, resulting in the member 
> variable `serviceName` always being set to `null`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
>  ea082c66e128a30368d6be195f3ee270a08e8518 
> 
> 
> Diff: https://reviews.apache.org/r/64614/diff/1/
> 
> 
> Testing
> ---
> 
> Tested in blueprint deployment.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 64651: Revert adding repo_version column for stack table.

2017-12-15 Thread Balázs Bence Sári


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64651/
---

Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, 
and Vitalyi Brodetskyi.


Bugs: AMBARI-22297
https://issues.apache.org/jira/browse/AMBARI-22297


Repository: ambari


Description
---

Stack table does not need the repo_version column, so it should be removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
 c479cdd427 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
dc77f19d63 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
 4313ae6028 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
1a8340ab0a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
 d40679aea7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 730d51cb98 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
 558b334267 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
 ca7a7aceb3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 8568b8c77e 


Diff: https://reviews.apache.org/r/64651/diff/1/


Testing
---

- Fixed related unit tests in ambari-server.
- Unit test run: pending


Thanks,

Balázs Bence Sári

Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

2017-12-15 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64607/#review193910
---


Ship it!




Shipt It!

- Oliver Szabo


On Dec. 15, 2017, 8:57 a.m., Krisztian Kasa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64607/
> ---
> 
> (Updated Dec. 15, 2017, 8:57 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22514 and AMBARI-22653
> https://issues.apache.org/jira/browse/AMBARI-22514
> https://issues.apache.org/jira/browse/AMBARI-22653
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Integration test environment for ambari-infra-manager using docker-compose 
> and jbehave
> * test cases for testing data export jobs
> 
> * deleting temporary files as soon as the file becomes unnecessary
> * configuring solr data export like jobs in property files only, no hardcoded 
> job and step configurations: query can be defined in property file for 
> pulling data from solr
> * validate job property values at application startup and before job execution
> * s3 upload support
> * not just interval end but interval start can be specified when exporting
> * interval start and end values can be other type than dateTime
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-manager-it/pom.xml PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraManagerStories.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/OffsetDateTimeConverter.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-manager-it/src/test/resources/log4j.properties 
> PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story
>  PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/Dockerfile adb584acec 
>   ambari-infra/ambari-infra-manager/docker/docker-compose.yml PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh 
> PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/ObjectSource.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/AbstractFileAction.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java
>  84ce16074b 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java
>  84f5ece26f 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java
>  69f41d333e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java
>  f1df46cfcc 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java
>  d6301c0c0e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportPropertyMap.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java
>  3bab6d505e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java
>  a4378a4340 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java
>  6232cfc4c6 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java
>  c9871a3660 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java
>  26a8c6310f 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java
>  02d898d979 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java
>  495401d633 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java
>  3214e50e91 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java
>  db4069bad7 
>   
>

Re: Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

2017-12-15 Thread Pravin Dsilva



> On Dec. 13, 2017, 3:20 p.m., Nate Cole wrote:
> > ambari-server/src/main/python/ambari_server/serverSetup.py
> > Lines 870-876 (patched)
> > 
> >
> > This appears to always force someone to pick an OS and changes the 
> > expectation of how the server gets installed.
> > 
> > We shouldn't be changing how things are working today.  You should do 
> > either:
> > - After picking JAVA_HOME, then we should ask if they want to customize 
> > the OS type (as a choice).
> > - Use another command line option to add a JAVA_HOME for an OS type.  
> > No need to ask the type, just use whatever value they put in the option.  
> > This way, you only have to check for the option to know to write 
> > "java.home.redhat7".  No option means we maintain current behavior.
> > 
> > I would prefer the 2nd option as it's likely easier to document.  If we 
> > start asking "hard choices" the everyday user will get confused.

I have made the changes as per the 2nd option.


- Pravin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64571/#review193682
---


On Dec. 15, 2017, 12:23 p.m., Pravin Dsilva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64571/
> ---
> 
> (Updated Dec. 15, 2017, 12:23 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22404
> https://issues.apache.org/jira/browse/AMBARI-22404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes to ambari-server setup script for accepting user values for Java Home 
> for OS type.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py 655a5d2 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 13d5348 
>   ambari-server/src/test/python/TestAmbariServer.py 8ce2457 
> 
> 
> Diff: https://reviews.apache.org/r/64571/diff/2/
> 
> 
> Testing
> ---
> 
> All tests passed
> 
> 
> Thanks,
> 
> Pravin Dsilva
> 
>

Re: Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

2017-12-15 Thread Pravin Dsilva


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64571/
---

(Updated Dec. 15, 2017, 12:23 p.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22404
https://issues.apache.org/jira/browse/AMBARI-22404


Repository: ambari


Description
---

Changes to ambari-server setup script for accepting user values for Java Home 
for OS type.


Diffs (updated)
-

  ambari-server/src/main/python/ambari-server.py 655a5d2 
  ambari-server/src/main/python/ambari_server/serverSetup.py 13d5348 
  ambari-server/src/test/python/TestAmbariServer.py 8ce2457 


Diff: https://reviews.apache.org/r/64571/diff/2/

Changes: https://reviews.apache.org/r/64571/diff/1-2/


Testing
---

All tests passed


Thanks,

Pravin Dsilva

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-15 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64637/#review193904
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 15, 2017, 3:38 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64637/
> ---
> 
> (Updated Dec. 15, 2017, 3:38 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22655
> https://issues.apache.org/jira/browse/AMBARI-22655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While restarting Livy and Livy2 on a non-root cluster, the following is seen:
> 
> ```
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.repl.enableHiveContext has been deprecated as of Livy 0.4 and may be 
> removed in the future. Please use the new key livy.repl.enable-hive-context 
> instead.
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.server.csrf_protection.enabled has been deprecated as of Livy 0.4 and 
> may be removed in the future. Please use the new key 
> livy.server.csrf-protection.enabled instead.
> 17/12/14 14:36:23 INFO AccessManager: AccessControlManager acls 
> disabled;users with view permission: ;users with modify permission: ;users 
> with super permission: cstm-zeppelin;other allowed users: *
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Welcome to
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:     __
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:  / __/__  ___ _/ 
> /__
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: _\ \/ _ \/ _ `/ __/  
> '_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:/___/ .__/_,_/_/ /_/_\  
>  version 2.2.0.2.6.4.0-73
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:   /_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Using Scala version 
> 2.11.8, OpenJDK 64-Bit Server VM, 1.8.0_131
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Branch HEAD
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Compiled by user jenkins 
> on 2017-12-13T19:08:32Z
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Revision 
> a24017869f5450397136ee8b11be818e7cd3facb
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Url 
> g...@github.com:hortonworks/spark2.git
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Type --help for more 
> information.
> 17/12/14 14:36:29 WARN NativeCodeLoader: Unable to load native-hadoop library 
> for your platform... using builtin-java classes where applicable
> 17/12/14 14:36:31 INFO AHSProxy: Connecting to Application History server at 
> nat-yc-r7-ovvs-ambari-autostart-4-re-2.openstacklocal/172.22.121.144:10200
> 17/12/14 14:36:32 WARN DomainSocketFactory: The short-circuit local reads 
> feature cannot be used because libhadoop cannot be loaded.
> 17/12/14 14:36:33 INFO StateStore$: Using FileSystemStateStore for recovery.
> 17/12/14 14:36:33 INFO BatchSessionManager: Recovered 0 batch sessions. Next 
> session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Recovered 0 interactive 
> sessions. Next session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Heartbeat watchdog thread 
> started.
> 17/12/14 14:36:33 INFO LivyServer: SPNEGO auth enabled (principal = 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com)
> 17/12/14 14:36:33 INFO LivyServer: CSRF protection is enabled.
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Login using keytab 
> /etc/security/keytabs/spnego.service.keytab, for principal 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Map server: 
> nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklocal to principal: 
> [HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com], 
> added = true
> 17/12/14 14:36:34 WARN AbstractLifeCycle: FAILED 
> ServerConnector@df1cff6{SSL-http/1.1}{0.0.0.0:8999}: java.net.BindException: 
> Address already in use
> java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> ```
> 
> This occurs because the PID file cannot be accessed by the non-root agent and 
> returns an exit code of 1:
> {code}
> call returned (1, 'cat: /var/run/livy/livy-cstm-livy-server.pid: Permission 
> denied')
> {code}
> 
> This tricks out PID detection into thinking that there is no process running 
> (or a missing PID file) and therefore, we do not need to stop Livy/Livy2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  cce2148ab6 
>   
>

Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

2017-12-15 Thread Krisztian Kasa


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64607/
---

(Updated Dec. 15, 2017, 8:57 a.m.)


Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sid Wagle.


Changes
---

* Integration tests plugin was put into a maven profile
* New test case for testing failure while running job and restart


Bugs: AMBARI-22514 and AMBARI-22653
https://issues.apache.org/jira/browse/AMBARI-22514
https://issues.apache.org/jira/browse/AMBARI-22653


Repository: ambari


Description
---

* Integration test environment for ambari-infra-manager using docker-compose 
and jbehave
* test cases for testing data export jobs

* deleting temporary files as soon as the file becomes unnecessary
* configuring solr data export like jobs in property files only, no hardcoded 
job and step configurations: query can be defined in property file for pulling 
data from solr
* validate job property values at application startup and before job execution
* s3 upload support
* not just interval end but interval start can be specified when exporting
* interval start and end values can be other type than dateTime


Diffs (updated)
-

  ambari-infra/ambari-infra-manager-it/pom.xml PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraManagerStories.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/OffsetDateTimeConverter.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java
 PRE-CREATION 
  ambari-infra/ambari-infra-manager-it/src/test/resources/log4j.properties 
PRE-CREATION 
  
ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story
 PRE-CREATION 
  ambari-infra/ambari-infra-manager/docker/Dockerfile adb584acec 
  ambari-infra/ambari-infra-manager/docker/docker-compose.yml PRE-CREATION 
  ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh 
PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/ObjectSource.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/AbstractFileAction.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java
 84ce16074b 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java
 84f5ece26f 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java
 69f41d333e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java
 f1df46cfcc 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java
 d6301c0c0e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportPropertyMap.java
 PRE-CREATION 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java
 3bab6d505e 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java
 a4378a4340 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java
 6232cfc4c6 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java
 c9871a3660 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java
 26a8c6310f 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java
 02d898d979 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java
 495401d633 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java
 3214e50e91 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java
 db4069bad7 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java
 2181ba368d 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryBuilder.java
 d0f6d40155 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java
 444a15b267 
  
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java
 8e34ca9b47

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

Review Request 64652: unable to proceed with cluster install after component install fails.

Re: Review Request 64651: Revert adding repo_version column for stack table.

Re: Review Request 64651: Revert adding repo_version column for stack table.

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

Re: Review Request 64611: AMBARI-22196. yum repo file contains parsing errors due to initial whitespace

Re: Review Request 64613: AMBARI-22249. Fix AmbariContext.serviceGroupDependencyResourceProvider initialization

Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to leftover parameter name

Review Request 64651: Revert adding repo_version column for stack table.

Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

Re: Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

Re: Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

26 matches

Site Navigation

Mail list logo

Footer information