Re: Review Request 64886: Log Search UI: implement Summary tab for Access Logs page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64886/#review194626 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 2, 2018, 1:08 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64886/ > --- > > (Updated Янв. 2, 2018, 1:08 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22714 > https://issues.apache.org/jira/browse/AMBARI-22714 > > > Repository: ambari > > > Description > --- > > Implement Summary tab with two diagrams: Top 6 users and Top 10 resources. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/package.json b9ee179 > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts b76de20 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.spec.ts > 05f80a7 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.ts > 0b8866a > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts > 15fefde > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts 05ea59d > ambari-logsearch/ambari-logsearch-web/src/app/classes/object.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > 3b38a03 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-top-resources-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts > 0700a98 > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-injector.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.ts > 0e578ab > > ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html > b73fa45 > > ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts > cbc0dd7 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > fc42e3c > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > a8037d0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 6a9aca5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts > 2dcecd1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > 8293ba0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts > d677d81 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 480706a > > ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.c
Re: Review Request 64884: AMBARI-22711 -- Ambari Versions Page is having JS error When using redhat satellite server for repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64884/#review194622 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 2, 2018, 10:26 д.п., Akhil S Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64884/ > --- > > (Updated Янв. 2, 2018, 10:26 д.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-22711 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22711 > > > Repository: ambari > > > Description > --- > > Ambari Versions page not updating when using Redhat satellite server for repos > Due to exception in JS Code > > as a Fix : > in stack_mapper.js code > for the line : stack.use_redhat_satellite = > Em.get(item,'operating_systems.0.OperatingSystems.ambari_managed_repositories') > === false; > > we need to remove the direct check of property and use the Em.get Instead > (Ember-metal > APIhttps://github.com/emberjs/ember.js/blob/0d68d0a3b3072995e3db603a24fe5ac56cf26d6d/packages/ember-metal/lib/property_get.js) > > > Diffs > - > > ambari-web/app/mappers/stack_mapper.js 323a033 > > > Diff: https://reviews.apache.org/r/64884/diff/1/ > > > Testing > --- > > * unit tests runs fine > * fix works fine > * > > > Thanks, > > Akhil S Naik > >
Re: Review Request 64716: LogSearch Title Bar Fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64716/#review194151 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 19, 2017, 5:15 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64716/ > --- > > (Updated Дек. 19, 2017, 5:15 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22675 > https://issues.apache.org/jira/browse/AMBARI-22675 > > > Repository: ambari > > > Description > --- > > The top LogSearch Title bar is currently fixed in size and shown during > scrolling. It's better to have a limited set of search controls displayed in > the LogSearch title bar, to provide a way to show the existing search, and > also allow the user to modify the search while in the middle of searching > results. > The search bar instead of the title bar should be sticky at the top. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.html > 833f43f > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less > f0fecfc > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > f9fe94b > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 5e401d8 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less > b4d44fb > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > 86709fb > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html > 95dd238 > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less > bca668d > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.ts > 6747a0c > > > Diff: https://reviews.apache.org/r/64716/diff/1/ > > > Testing > --- > > Executed 221 of 221 SUCCESS (7.013 secs / 6.895 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 64679: Log Search UI: incorrect caption for graph gap in weeks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64679/#review194063 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 18, 2017, 12:03 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64679/ > --- > > (Updated Дек. 18, 2017, 12:03 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22663 > https://issues.apache.org/jira/browse/AMBARI-22663 > > > Repository: ambari > > > Description > --- > > There's a text reflecting the gap between values of the graph. It's incorrect > when the unit is week (caption is not defined). > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 3f4f5c8 > > > Diff: https://reviews.apache.org/r/64679/diff/1/ > > > Testing > --- > > Executed 221 of 221 SUCCESS (6.166 secs / 6.035 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 64421: Log Search UI: Fixes for Top-Level Buttons
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64421/#review193138 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 7, 2017, 5:33 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64421/ > --- > > (Updated Дек. 7, 2017, 5:33 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22612 > https://issues.apache.org/jira/browse/AMBARI-22612 > > > Repository: ambari > > > Description > --- > > Recently, the top-level "Undo/Redo/Refresh/History" buttons have been moved > from the top bar to lower in the UI. Buttons should be centered in the bar > vertically. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 13911bd > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less > 9902b79 > > > Diff: https://reviews.apache.org/r/64421/diff/1/ > > > Testing > --- > > Executed 216 of 216 SUCCESS (4.644 secs / 4.562 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 64214: Log Search UI: layout and behaviour changes for filtering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64214/#review192303 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 30, 2017, 4:02 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64214/ > --- > > (Updated Ноя. 30, 2017, 4:02 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22564 > https://issues.apache.org/jira/browse/AMBARI-22564 > > > Repository: ambari > > > Description > --- > > 1. Move filter by cluster to top right (on the left from menu icon) and > display it only if there are more than one cluster available. > 2. Add Search button to the right from timezone selector > 3. Filtering by parameters from search box should be applied either by > clicking Search button > 4. Change “Excluded” to “Exclude” > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less > 880a97b > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts > 58e0025 > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.html > d6e9091 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html > b5f1e56 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less > d767e15 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 148e1b4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 4fe169d > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less > 962199b > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 01a8932 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less > 0207561 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > 4460821 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html > 4be0a47 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > 5bffdc5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > eac3bd6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 14cc89b > > ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.html > a2e666e > > ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.less > bd6d012 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html > 369ddd4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less > 32d1beb > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.spec.ts > 6679ba1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts > 91f27e8 > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 18268ad > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > 64b14b8 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 98b9e29 > ambari-logsearch/ambari-logsearch-web/webpack.config.js 75d6aee > > > Diff: https://reviews.apache.org/r/64214/diff/1/ > > > Testing > --- > > Executed 211 of 211 SUCCESS (4.549 secs / 4.463 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 64120: Log Search UI: refine search box
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64120/#review192029 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 28, 2017, 2:14 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64120/ > --- > > (Updated Ноя. 28, 2017, 2:14 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22531 > https://issues.apache.org/jira/browse/AMBARI-22531 > > > Repository: ambari > > > Description > --- > > 1. Provide styles for search criteria labels (background color: #dd, > border-radius: 2px, font color: #66, icon color: #66). > 2. Provide filtering by all possible criteria, including the ones that have > separate filtering controls. > 3. User should be able to choose parameter value from list of available > options (if any). > 4. If user submits any text instead of selecting parameter name from > dropdown, filter by message should be applied. > 5. Pressing Backspace in case when parameter value text isn't yet typed > should erase the current filter condition. > 6. Add more internal padding to the search box entries, like 5 px top/bottom, > and 2px left/right. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts 2a7205f > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > afed497 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > 509fa04 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts > 6f9de16 > ambari-logsearch/ambari-logsearch-web/src/app/classes/string.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 2d327a6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > 1f7e8db > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > b41f7cd > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > f34dd15 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > b06cfa4 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > 5fa265b > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > 92f9520 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > f0a5ce0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 18ff715 > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 7b7fcae > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts > 6d43ff1 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > e796183 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts > a161190 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts > 47cb25d > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > a715adc > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 175b585 > > > Diff: https://reviews.apache.org/r/64120/diff/1/ > > > Testing > --- > > Executed 211 of 211 SUCCESS (4.747 secs / 4.683 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 64036: Log Search UI: refine time range picker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64036/#review191749 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 22, 2017, 5:55 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64036/ > --- > > (Updated Ноя. 22, 2017, 5:55 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22503 > https://issues.apache.org/jira/browse/AMBARI-22503 > > > Repository: ambari > > > Description > --- > > 1. Values of time picker inputs should be synced with the selected time range. > 2. Label of toggle button should contain 'Custom' text when custom range is > specified with the time pickers. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.spec.ts > e6c0bfe > > ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.ts > efb5e34 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html > 621f995 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts > cacabc3 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > 90ab9b7 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json b214a4f > > > Diff: https://reviews.apache.org/r/64036/diff/1/ > > > Testing > --- > > Executed 211 of 211 SUCCESS (4.731 secs / 4.643 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 63839: Ambari Logsearch Web unit tests are sometimes failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63839/#review191069 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 15, 2017, 3:41 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63839/ > --- > > (Updated Ноя. 15, 2017, 3:41 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22455 > https://issues.apache.org/jira/browse/AMBARI-22455 > > > Repository: ambari > > > Description > --- > > Ambari Logsearch Web unit tests fail on CI builds: > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts > a465c10 > > > Diff: https://reviews.apache.org/r/63839/diff/1/ > > > Testing > --- > > Executed 206 of 206 SUCCESS (8.096 secs / 8.004 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 63758: Log Search UI: implement logout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63758/#review190826 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 13, 2017, 4:17 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63758/ > --- > > (Updated Ноя. 13, 2017, 4:17 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22429 > https://issues.apache.org/jira/browse/AMBARI-22429 > > > Repository: ambari > > > Description > --- > > Logout control should be available from user menu. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 37f3a49 > > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.spec.ts > 490e058 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > bd41c04 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > ac2fa84 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > f9ae154 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > f9192f4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/login-form/login-form.component.spec.ts > fb5c2a0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/login-form/login-form.component.ts > 2bc45404 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 71bbf67 > > ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts > 0e4c8a8 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts > 05c1a62 > ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts 4325f5b > ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts > 6f54e65 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > 73fc94c > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 16b4b32 > > > Diff: https://reviews.apache.org/r/63758/diff/1/ > > > Testing > --- > > Executed 205 of 205 SUCCESS (4.258 secs / 4.209 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 63734: Log Search UI: fixes for filtering form
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63734/#review190730 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 10, 2017, 4:19 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63734/ > --- > > (Updated Ноя. 10, 2017, 4:19 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22416 > https://issues.apache.org/jira/browse/AMBARI-22416 > > > Repository: ambari > > > Description > --- > > 1. Checkboxes in multiselect, labels of dropdown filter buttons etc. should > pick up currently selected value even if it's set from outside the form > 2. All the tabs should have their own isolated filtering options, so that > filters application on one tab doesn't affect other tab > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 56562df > ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts dde144b > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > 2c5c083 > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node-item.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts > a14e51a > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > d912b35 > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts bb8028a > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.ts > 4de47ea > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html > 798a609 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > f11ca09 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 0bf4422 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html > 5de78ad > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > 5455e67 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 3e40455 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts > 2c8ecd7 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > c294e8e > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts > 9e5a6f1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > fa739a4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > 0bb0204 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 9601a0e > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts > 4e9bdc9 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts > 0a9418f > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > 21949f1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 10f4af1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts > 8ee4ca3 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > 017bc82 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 261e213 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts > 5932e1b > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts > 81676a9 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html > 679a7e5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts > ff8675d > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.
Re: Review Request 63697: Log Search UI: restyle logs list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63697/#review190569 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 9, 2017, 11:25 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63697/ > --- > > (Updated Ноя. 9, 2017, 11:25 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22388 > https://issues.apache.org/jira/browse/AMBARI-22388 > > > Repository: ambari > > > Description > --- > > Restyle logs list as table. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 488437e > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 1e0f49c > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less > 67d0615 > ambari-logsearch/ambari-logsearch-web/webpack.config.js 7a60df2 > > > Diff: https://reviews.apache.org/r/63697/diff/1/ > > > Testing > --- > > Executed 140 of 140 SUCCESS (3.709 secs / 3.654 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62933: Log Search UI generated by maven build uses mock data instead of real API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62933/#review187785 --- Ship it! Ship It! - Aleksandr Kovalenko On Окт. 12, 2017, 1 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62933/ > --- > > (Updated Окт. 12, 2017, 1 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22218 > https://issues.apache.org/jira/browse/AMBARI-22218 > > > Repository: ambari > > > Description > --- > > ```pom.xml``` contains incorrect ```webpack``` task configuration, so that UI > is built with mock data usage. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/package.json f8525c4 > ambari-logsearch/ambari-logsearch-web/pom.xml a0621d9 > > > Diff: https://reviews.apache.org/r/62933/diff/1/ > > > Testing > --- > > 1. maven build > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main SUCCESS [ 28.513 > s] > [INFO] Apache Ambari Project POM .. SUCCESS [ 0.094 > s] > [INFO] ambari-utility . SUCCESS [ 7.669 > s] > [INFO] ambari-logsearch ... SUCCESS [ 1.971 > s] > [INFO] Ambari Logsearch Web ... SUCCESS [02:24 > min] > [INFO] > > [INFO] BUILD SUCCESS > > 2. tested generated files manually > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62749: Log Search UI: implement time range selection from graph
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62749/#review186948 --- Ship it! Ship It! - Aleksandr Kovalenko On Окт. 3, 2017, 1:06 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62749/ > --- > > (Updated Окт. 3, 2017, 1:06 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22118 > https://issues.apache.org/jira/browse/AMBARI-22118 > > > Repository: ambari > > > Description > --- > > User should be able to customize time range to filter logs by selecting the > interval on graph. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 9c6c336 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > fd3a58b > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less > d891862 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts > 7856ecc > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 6697c54 > > > Diff: https://reviews.apache.org/r/62749/diff/1/ > > > Testing > --- > > Executed 89 of 89 SUCCESS (2.763 secs / 2.733 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62499: Log Search UI: implement application of selected text to service logs filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62499/#review185963 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 22, 2017, 10:17 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62499/ > --- > > (Updated Сен. 22, 2017, 10:17 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22038 > https://issues.apache.org/jira/browse/AMBARI-22038 > > > Repository: ambari > > > Description > --- > > User should be able to add or exclude selected part of log message to filter > query. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts acf1b9f > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 42b9451 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html > 1baebed > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts > 3de664e > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts > 9940d73 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > dc76e79 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 72ab222 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 29a85c5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less > 584c1a7 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > a081e1b > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 65f0ee6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts > b674ec6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 4730190 > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 627dc27 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 1235a80 > ambari-logsearch/ambari-logsearch-web/src/polyfills.ts 0ab921a > > > Diff: https://reviews.apache.org/r/62499/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (2.094 secs / 2.08 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62440: Log Search UI: implement grouping of service logs by day
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62440/#review185792 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 20, 2017, 2:05 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62440/ > --- > > (Updated Сен. 20, 2017, 2:05 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22006 > https://issues.apache.org/jira/browse/AMBARI-22006 > > > Repository: ambari > > > Description > --- > > Service logs in list should be grouped in list by day of occurrence. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 888c524 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less > 91d796f > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > 6d73dcb > ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts f23139b > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 2d3f640 > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 0f90ba3 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e7126f0 > > > Diff: https://reviews.apache.org/r/62440/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (2.25 secs / 2.213 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62384: Log Search UI: implement logs filtering by custom time range
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62384/#review185559 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 18, 2017, 3:54 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62384/ > --- > > (Updated Сен. 18, 2017, 3:54 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21983 > https://issues.apache.org/jira/browse/AMBARI-21983 > > > Repository: ambari > > > Description > --- > > User should be able to customize time range to filter logs by selecting start > and end time with datepicker. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/package.json 7e8a0ba > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 8ea933c > > ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/date-picker/date-picker.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 5820b82 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less > 6b2408d > > ambari-logsearch/ambari-logsearch-web/src/app/components/modal/modal.component.ts > 32f59f6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 3f59a0d > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 38c063e > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 84c4abc > > ambari-logsearch/ambari-logsearch-web/src/vendor/css/bootstrap-datetimepicker.min.css > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/vendor/js/bootstrap-datetimepicker.min.js > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/webpack.config.js 72eaa7f > > > Diff: https://reviews.apache.org/r/62384/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (1.909 secs / 1.869 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62277: Log Search UI: reorganize generated files structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62277/#review185283 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 13, 2017, 1:16 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62277/ > --- > > (Updated Сен. 13, 2017, 1:16 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21946 > https://issues.apache.org/jira/browse/AMBARI-21946 > > > Repository: ambari > > > Description > --- > > All the resources (scripts/styles/fonts) for ```dist/index.html``` should be > placed into ```resources``` directory. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 > ambari-logsearch/ambari-logsearch-web/README.md ff1456e > ambari-logsearch/ambari-logsearch-web/package.json 0892d85 > ambari-logsearch/ambari-logsearch-web/pom.xml 075527b > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc > ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/62277/diff/3/ > > > Testing > --- > > Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62277: Log Search UI: reorganize generated files structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62277/#review185281 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 13, 2017, 12:06 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62277/ > --- > > (Updated Сен. 13, 2017, 12:06 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21946 > https://issues.apache.org/jira/browse/AMBARI-21946 > > > Repository: ambari > > > Description > --- > > All the resources (scripts/styles/fonts) for ```dist/index.html``` should be > placed into ```resources``` directory. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 > ambari-logsearch/ambari-logsearch-web/README.md ff1456e > ambari-logsearch/ambari-logsearch-web/package.json 0892d85 > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc > ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/62277/diff/2/ > > > Testing > --- > > Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62277: Log Search UI: reorganize generated files structure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62277/#review185278 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 13, 2017, 11:19 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62277/ > --- > > (Updated Сен. 13, 2017, 11:19 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21946 > https://issues.apache.org/jira/browse/AMBARI-21946 > > > Repository: ambari > > > Description > --- > > All the resources (scripts/styles/fonts) for ```dist/index.html``` should be > placed into ```resources``` directory. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/.angular-cli.json 70fd7b6 > ambari-logsearch/ambari-logsearch-web/package.json 0892d85 > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c15ecbc > ambari-logsearch/ambari-logsearch-web/webpack.config.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/62277/diff/1/ > > > Testing > --- > > Executed 84 of 84 SUCCESS (1.844 secs / 1.804 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62159: Log Search UI: implement combo search filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62159/#review184822 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 7, 2017, 3:14 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62159/ > --- > > (Updated Сен. 7, 2017, 3:14 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21905 > https://issues.apache.org/jira/browse/AMBARI-21905 > > > Repository: ambari > > > Description > --- > > Implement logs filtering item similar to 'Include Search' in current version. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/package.json 96733eb > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c08cb3a > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 87e82f6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less > d47160f > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.html > 3f00e8b > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.less > 1395959 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.spec.ts > 71039ed > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-text-field/filter-text-field.component.ts > 2b6bfea > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 6df6988 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less > 9ab09ef > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > b1cf990 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > e407021 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > f72183c > ambari-logsearch/ambari-logsearch-web/src/app/models/app-state.model.ts > 2995002 > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 5b9e90d > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > 702deab > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 9f6cacd > ambari-logsearch/ambari-logsearch-web/yarn.lock 291b489 > > > Diff: https://reviews.apache.org/r/62159/diff/1/ > > > Testing > --- > > Executed 84 of 84 SUCCESS (1.985 secs / 1.906 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61970: Log Search UI: add filter by hostname for service logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61970/#review184065 --- Ship it! Ship It! - Aleksandr Kovalenko On Авг. 29, 2017, 4:10 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61970/ > --- > > (Updated Авг. 29, 2017, 4:10 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21845 > https://issues.apache.org/jira/browse/AMBARI-21845 > > > Repository: ambari > > > Description > --- > > Service logs should be filtered by hostname. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts b883c75 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts > 63103ee > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html > d9d1de0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less > 804bf48 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.spec.ts > e16d93a > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts > 555e4a8 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > 80f5c0f > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts > c0234bb > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > 449a2e5 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.html > 2e642be > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts > 7b5169b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts > 517db98 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > 23a62a4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts > 96adc8f > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html > a0f25ff > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > 0b58ce1 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/node-bar/node-bar.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/node-bar/node-bar.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/node-bar/node-bar.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/node-bar/node-bar.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/pagination/pagination.component.html > 67fe591 > ambari-logsearch/ambari-logsearch-web-new/src/app/mock-data.ts 3404a4b > ambari-logsearch/ambari-logsearch-web-new/src/app/models/node.model.ts > a89c4fb > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > 8d71174 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-generator.service.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-generator.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts > 4be15b4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > 8088872 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts > 625a55c > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/logs-container.service.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/logs-container.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts > 2289f09 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/hosts.service.ts > PRE-CREATION > > ambari-logsearch/ambari-l
Re: Review Request 60751: Log Search UI: implement sorting of logs list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60751/#review180070 --- Ship it! Ship It! - Aleksandr Kovalenko On Июль 10, 2017, 5:57 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60751/ > --- > > (Updated Июль 10, 2017, 5:57 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21438 > https://issues.apache.org/jira/browse/AMBARI-21438 > > > Repository: ambari > > > Description > --- > > User should be able to sort logs list content by component name/level/time > etc. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 72b5ad1 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.spec.ts > 445ee97 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts > 6426f6a > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts > dda81e6 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts > b529686 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.html > bb7a206 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.less > ec8e84b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > f6d1294 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts > 1cf7d41 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.html > 8fb7659 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts > 9123969 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts > b05000b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > 450ce5a > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less > 46a157c > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts > 1917f7f > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > f42a2bb > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > 09b2e1e > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.less > 6ed0463 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts > ffcfb83 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > bf80445 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html > 597 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > 0c1f840 > ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less > 9a8ea09 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts > 0ad3795 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > 36bb756 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts > 40645f0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 755f307 > > > Diff: https://reviews.apache.org/r/60751/diff/1/ > > > Testing > --- > > Executed 47 of 47 SUCCESS (1.178 secs / 1.147 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 60708: Log Search UI: implement dynamic loading of options for filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60708/#review179873 --- Ship it! Ship It! - Aleksandr Kovalenko On Июль 7, 2017, 2:54 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60708/ > --- > > (Updated Июль 7, 2017, 2:54 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21429 > https://issues.apache.org/jira/browse/AMBARI-21429 > > > Repository: ambari > > > Description > --- > > Options for logs list filters should be loaded dynamically based on real > application data. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 65139db > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts > b1b691c > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts > 8828390 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts > 8291572 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > 652b864 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts > ea3d780 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > 5cfe4cc > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > d5f8881 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts > a8dc017 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > ce451d3 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts > 4ab85e5 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts > faed254 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts > 49dfa77 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts > a50c68d > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts > b3b955a > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/clusters.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/components.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts > a06852c > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts > 0abd910 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts > 4e47609 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts > ab77138 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts > 36cfd5f > ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts 732e8d3 > > > Diff: https://reviews.apache.org/r/60708/diff/1/ > > > Testing > --- > > Executed 46 of 46 SUCCESS (1.22 secs / 1.185 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 60567: Log Search UI: implement timezone customization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60567/#review179353 --- Ship it! Ship It! - Aleksandr Kovalenko On Июнь 30, 2017, 1:32 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60567/ > --- > > (Updated Июнь 30, 2017, 1:32 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21382 > https://issues.apache.org/jira/browse/AMBARI-21382 > > > Repository: ambari > > > Description > --- > > User should be able to customize timezone for displaying logs and metrics. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/package.json da44d30 > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts a095a97 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less > d0f079a > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.html > 1ac663e > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > e0414f3 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts > faaafcb > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.html > ed3c4ba > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts > e4f026c > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts > 3f23ffd > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > e278a09 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts > 934f37a > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > f7b8429 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > 827f63c > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts > 072bfcd > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > cc77784 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html > 132d717 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.spec.ts > 424d322 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > ded01b7 > > ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-settings.model.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > 1f3a89c > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts > d471e00 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > c4d2bdf > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts > 706d2f3 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts > 2e2db5b > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts > 99d2140 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts > 1c32d34 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts > b194f94 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts > 6859653 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts > 2c770f0 > ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts d269bc3 > ambari-logsearch/ambari-logsearch-web-new/yarn.lock ff37374 > > > Diff: https://reviews.apache.org/r/60567/diff/1/ > > > Testing > --- > > Executed 46 of 46 SUCCESS (1.37 secs / 1.333 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 60367: Log Search UI GA - first patch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60367/#review178667 --- Ship it! Ship It! - Aleksandr Kovalenko On Июнь 22, 2017, 1:06 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60367/ > --- > > (Updated Июнь 22, 2017, 1:06 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21308 > https://issues.apache.org/jira/browse/AMBARI-21308 > > > Repository: ambari > > > Description > --- > > The implementation of the new Log Search UI. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/.angular-cli.json PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/.editorconfig PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/.gitignore PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/README.md PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/e2e/app.e2e-spec.ts PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/e2e/app.po.ts PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/e2e/tsconfig.e2e.json > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/karma.conf.js PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/package.json PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/protractor.conf.js PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/accordion-panel/accordion-panel.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.html > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.less > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.spec.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/app.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/audit-logs-query-params.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/query-params.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/dropdown-list/dropdown-list.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-dropdown/filter-dropdown.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filter-text-field/filter-text-field.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/filters-panel/filters-panel.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web
Re: Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59497/#review176196 --- Ship it! Ship It! - Aleksandr Kovalenko On Май 23, 2017, 11:06 п.п., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59497/ > --- > > (Updated Май 23, 2017, 11:06 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Sangeeta Ravindran. > > > Bugs: AMBARI-21094 > https://issues.apache.org/jira/browse/AMBARI-21094 > > > Repository: ambari > > > Description > --- > > Steps to reproduce: > 1. Go to Customize Services screen > 2. Create a Custom HostGroup > 3. Click Back button > 4. Click Next Button > 5. See that Custom Hostgroup still exists, but all the data including > assigned hosts is erased. > Ambari typically erases all the changes when clicked on Back button, because > the Custom HostGroup is not deleted but data related to it is deleted by > Ambari, cluster state goes in inconsistent state. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7_controller.js 6685c0189a > > > Diff: https://reviews.apache.org/r/59497/diff/1/ > > > Testing > --- > > Tested manually, > Attached output screenshots > > > File Attachments > > > HostGroupList_BeforeClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/20029794-04d8-4611-83fe-884e30282ff7__HostGroupList_BeforeClickingBack.png > BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/3853d6c3-5fd0-4604-9923-602df062b51f__BeforeCodeChange_ManageHostGroup_Customgroup_AfterClickingBack.png > BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/2b28debe-b81f-4b25-946b-acdfc69a3042__BeforeCodeChange_ManageHostGroup_Defaultgroup_AfterClickingBack.png > BeforeCodeChange_HostGroupList_AfterlickingBack > > https://reviews.apache.org/media/uploaded/files/2017/05/23/5c9805e0-41ae-42fa-a87d-393f0da8a144__BeforeCodeChange_HostGroupList_AfterlickingBack.png > AfterCodeChange_HostGroupList > > https://reviews.apache.org/media/uploaded/files/2017/05/23/190f83cb-ce1b-4413-a9b3-cd988cd29133__AfterCodeChange_HostGroupList.png > AfterCodeChange_ManageHostGroupPage > > https://reviews.apache.org/media/uploaded/files/2017/05/23/1bb710b5-f5c3-482b-8dca-dd3950ec2fbb__AfterCodeChange_ManageHostGroupPage.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 59347: Add service wizard unresponsive while adding HST via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59347/#review175296 --- Ship it! Ship It! - Aleksandr Kovalenko On Май 17, 2017, 6:15 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59347/ > --- > > (Updated Май 17, 2017, 6:15 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-21044 > https://issues.apache.org/jira/browse/AMBARI-21044 > > > Repository: ambari > > > Description > --- > > While adding HST, the 'add service wizard' stay stuck after clicking next > button after choosing the target hosts. > > Exception in browser console logs - > Uncaught DOMException: Failed to execute 'setItem' on 'Storage': Setting the > value of 'ambari' exceeded the quota. > > > Diffs > - > > ambari-web/app/controllers/installer.js ec280fa > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js > b54986b > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 45c840a > ambari-web/app/controllers/wizard.js a8a0249 > ambari-web/app/controllers/wizard/step7/assign_master_controller.js 099931a > ambari-web/app/mixins/wizard/assign_master_components.js 3e2a09a > ambari-web/app/mixins/wizard/wizardHostsLoading.js 93dab02 > ambari-web/app/routes/add_service_routes.js 89a4a36 > ambari-web/app/routes/installer.js daefa48 > ambari-web/app/utils/ajax/ajax.js 0b584d8 > ambari-web/app/views/common/assign_master_components_view.js 892bcae > ambari-web/app/views/main/service/reassign_view.js 6885726 > ambari-web/test/controllers/installer_test.js 94af88e > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step1_controller_test.js > 17f5ed2 > ambari-web/test/controllers/main/service/add_controller_test.js a52c38f > ambari-web/test/controllers/wizard/step5_test.js 3c9048d > ambari-web/test/controllers/wizard_test.js 078f8ae > > ambari-web/test/views/main/admin/highAvailability/resourceManager/wizard_view_test.js > d30be42 > ambari-web/test/views/main/service/reassign_view_test.js f6ae81e > > > Diff: https://reviews.apache.org/r/59347/diff/1/ > > > Testing > --- > > 20698 passing (24s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 59024: UI Deploy: On enabling hive interactive query, value of 'Number of nodes used by Hive's LLAP' becomes invalid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59024/#review174023 --- Ship it! Ship It! - Aleksandr Kovalenko On Май 5, 2017, 2:37 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59024/ > --- > > (Updated Май 5, 2017, 2:37 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20941 > https://issues.apache.org/jira/browse/AMBARI-20941 > > > Repository: ambari > > > Description > --- > > After enabling Hive Interactive query, the value of "Number of nodes used by > Hive's LLAP" becomes invalid. > > > Diffs > - > > ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js > 948af5d > > ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js > 9817479 > > > Diff: https://reviews.apache.org/r/59024/diff/1/ > > > Testing > --- > > 20701 passing (22s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 58740: inconsistent suggestion for llap "Maximum Total Concurrent Queries"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58740/#review173055 --- Ship it! Ship It! - Aleksandr Kovalenko On Апрель 26, 2017, 3:53 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58740/ > --- > > (Updated Апрель 26, 2017, 3:53 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20862 > https://issues.apache.org/jira/browse/AMBARI-20862 > > > Repository: ambari > > > Description > --- > > > Info > This cluster has gone through below upgrade. > Ambari 2.4.2.0-115 - 2.5.0.3-8 > HDP 2.5.3-14 - HDP 2.6.0.3-8 > > > 1] Login and proceed to Hive configs > > 2] Select "Interactive query queue" in below mentioned order. > > "default" -> "llap" -> "validator" > In the above order "Maximum Total Concurrent Queries" suggested for llap > queue is "2" > > 3] Now select "Interactive query queue" in below mentioned order. > > "validator" -> "llap" -> "default" > > In the above order "Maximum Total Concurrent Queries" suggested for llap > queue is "5" > > 4] When I try to save config for "5", the recommendation screen shows "10" > > > Diffs > - > > ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js > c7e810b > > ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js > 5cc055c > > > Diff: https://reviews.apache.org/r/58740/diff/1/ > > > Testing > --- > > 20701 passing (23s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Review Request 58672: LogSearch: LogSearch UI support for viewing data from multiple clusters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58672/ --- Review request for Ambari, Andrii Babiichuk, Oliver Szabo, and Robert Nettleton. Bugs: AMBARI-20834 https://issues.apache.org/jira/browse/AMBARI-20834 Repository: ambari Description --- This JIRA tracks the User Interface changes necessary in the LogSearch Server in order to support viewing data from multiple clusters, and also to support viewing only a single cluster's data when data from multiple ephemeral clusters are stored in the SolrCloud. This new JIRA was filed to track only the UI changes required for this feature. Diffs - ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js 7710156 ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/SelectClusterDropdown.js PRE-CREATION ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/graphs/GraphLayoutView.js 728d721 ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js 43ee5db ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 543533b ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/common/DatePickerLayout_tmpl.html ed1df61 ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/common/SelectClusterDropdown_tmpl.html PRE-CREATION ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/graphs/GraphLayoutView_tmpl.html 02b384c ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/tabs/HierarchyTabLayoutView_tmpl.html d0d57ac Diff: https://reviews.apache.org/r/58672/diff/1/ Testing --- tested manually Thanks, Aleksandr Kovalenko
Re: Review Request 58237: Add Stomp client adapter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58237/#review171564 --- Ship it! Ship It! - Aleksandr Kovalenko On Апрель 6, 2017, 4:26 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58237/ > --- > > (Updated Апрель 6, 2017, 4:26 п.п.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20694 > https://issues.apache.org/jira/browse/AMBARI-20694 > > > Repository: ambari > > > Description > --- > > Implement Stomp client that will handle communication with the server via > WebSocket (or SockJS). > > > Diffs > - > > ambari-web/app/app.js 9c7d874 > ambari-web/app/assets/test/tests.js ef8d0bc > ambari-web/app/utils/stomp_client.js PRE-CREATION > ambari-web/brunch-config.js 31eb1cb > ambari-web/test/utils/stomp_client_test.js PRE-CREATION > ambari-web/vendor/scripts/sockjs.min.js PRE-CREATION > ambari-web/vendor/scripts/stomp.min.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/58237/diff/1/ > > > Testing > --- > > 20690 passing (36s) > 128 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 58266: Post-install host check: 'Rerun Checks' button is never disabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58266/#review171358 --- Ship it! Ship It! - Aleksandr Kovalenko On Апрель 7, 2017, 4:16 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58266/ > --- > > (Updated Апрель 7, 2017, 4:16 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20711 > https://issues.apache.org/jira/browse/AMBARI-20711 > > > Repository: ambari > > > Description > --- > > While post-install host check is running, 'Rerun Checks' button in 'Host > Checks' popup is not disabled. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 6e85190 > ambari-web/app/controllers/wizard/step3_controller.js c282451 > ambari-web/app/mixins/main/host/details/actions/check_host.js c0ebf02 > ambari-web/app/views/wizard/step3/hostWarningPopupFooter_view.js fb2019c > ambari-web/test/views/wizard/step3/hostWarningPopupFooter_view_test.js > d1fbc24 > > > Diff: https://reviews.apache.org/r/58266/diff/1/ > > > Testing > --- > > 20678 passing (20s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 58177: Host checks: incorrect message for single host warnings
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58177/#review170979
---
Ship it!
Ship It!
- Aleksandr Kovalenko
On Апрель 4, 2017, 4:23 п.п., Andrii Babiichuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58177/
> ---
>
> (Updated Апрель 4, 2017, 4:23 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20671
> https://issues.apache.org/jira/browse/AMBARI-20671
>
>
> Repository: ambari
>
>
> Description
> ---
>
> If there are some warnings for single host in host checks popup, messages for
> them are incorrect ('1 hosts' instead of '1 host').
>
>
> Diffs
> -
>
> ambari-web/app/controllers/wizard/step3_controller.js 7a07253
> ambari-web/app/mixins/main/host/details/actions/check_host.js fbee24c
> ambari-web/app/templates/wizard/step3/step3_host_warnings_popup.hbs e8c5201
> ambari-web/test/controllers/wizard/step3_test.js fa90065
>
>
> Diff: https://reviews.apache.org/r/58177/diff/1/
>
>
> Testing
> ---
>
> 20674 passing (24s)
> 128 pending
>
>
> Thanks,
>
> Andrii Babiichuk
>
>
Re: Review Request 57961: Ambari Admin Web: optimize string constants definition
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57961/#review170188 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 27, 2017, 4:25 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57961/ > --- > > (Updated Март 27, 2017, 4:25 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20589 > https://issues.apache.org/jira/browse/AMBARI-20589 > > > Repository: ambari > > > Description > --- > > 1. Optimize string constants definition in admin-web so that they are easier > searchable by key. > 2. Remove hardcoded strings from views and controllers in favor of constants > where necessary. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/authentication/AuthenticationMainCtrl.js > bce9189 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > ff255ef > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ExportBlueprintCtrl.js > a1e4fa0 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js > 5dc6bd3 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/LoginMessageMainCtrl.js > 911bb0b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js > 3656dfc > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 2990cef > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js > dcb7418 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js > 694a7bd > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 61420c0 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js > 3345b0b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js > 64abd9d > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > 418c115 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/modals/create.html > e13f84c > > ambari-admin/src/main/resources/ui/admin-web/app/views/authentication/main.html > 57ba7c9 > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html > 3729e7d > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html > 041a228 > > ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/loginMessage.html > 9dbc23f > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddRepositoryModal.html > a439bde > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html > 993cef5 > > ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html > c3ad9e7 > > ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html > bdecbdc > > ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html > db869f2 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 58326aa > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > b31e2c5 > ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html > 87e2be7 > > > Diff: https://reviews.apache.org/r/57961/diff/1/ > > > Testing > --- > > Executed 81 of 81 SUCCESS (0.553 secs / 0.548 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 57885: create table failing with HiveAccessControlException (additional patch)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57885/#review169901 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 23, 2017, 5:41 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57885/ > --- > > (Updated Март 23, 2017, 5:41 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20516 > https://issues.apache.org/jira/browse/AMBARI-20516 > > > Repository: ambari > > > Description > --- > > Create table query is failing with below error > > ``` > 2017-03-02T03:39:11,076 ERROR [970bf75a-09fc-4b25-9bdb-9019cd135966 > HiveServer2-Handler-Pool: Thread-349]: authorizer.RangerHiveAuthorizer > (RangerHiveAuthorizer.java:isURIAccessAllowed(1087)) - Error getting > permissions for > hdfs://cluster-hostname-04:8020/user/hcat/autoquerygen_data/data/table_1 > java.lang.reflect.UndeclaredThrowableException > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1884) > ~[hadoop-common-2.7.3.2.6.0.0-571.jar:?] > at > org.apache.hadoop.hive.common.FileUtils.checkFileAccessWithImpersonation(FileUtils.java:391) > ~[hive-common-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hadoop.hive.common.FileUtils.isActionPermittedForFileHierarchy(FileUtils.java:431) > ~[hive-common-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hadoop.hive.common.FileUtils.isActionPermittedForFileHierarchy(FileUtils.java:417) > ~[hive-common-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.ranger.authorization.hive.authorizer.RangerHiveAuthorizer.isURIAccessAllowed(RangerHiveAuthorizer.java:1070) > [ranger-hive-plugin-0.7.0.2.6.0.0-571.jar:0.7.0.2.6.0.0-571] > at > org.apache.ranger.authorization.hive.authorizer.RangerHiveAuthorizer.checkPrivileges(RangerHiveAuthorizer.java:251) > [ranger-hive-plugin-0.7.0.2.6.0.0-571.jar:0.7.0.2.6.0.0-571] > at > org.apache.hadoop.hive.ql.Driver.doAuthorizationV2(Driver.java:846) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.hadoop.hive.ql.Driver.doAuthorization(Driver.java:633) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:492) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:336) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1197) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1184) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:191) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:276) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.operation.Operation.run(Operation.java:312) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:508) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:495) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.CLIService.executeStatementAsync(CLIService.java:308) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(ThriftCLIService.java:506) > [hive-service-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1437) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at > org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1422) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) > [hive-exec-2.1.0.2.6.0.0-571.jar:2.1.0.2.6.0.0-571] > at org.apache.
Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/ --- (Updated Март 23, 2017, 3:22 п.п.) Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. Bugs: AMBARI-20535 https://issues.apache.org/jira/browse/AMBARI-20535 Repository: ambari Description --- Instead of having two different steps for "Configure Services" and "Configure Identities", we should have configuring identities properties overlaid on "Configure Services" page. Diffs (updated) - ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f ambari-web/app/controllers/main/service/add_controller.js 0989f76 ambari-web/app/controllers/wizard.js 7af9ab0 ambari-web/app/controllers/wizard/step7_controller.js 0207e6b ambari-web/app/controllers/wizard/step8_controller.js efd8834 ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a ambari-web/app/routes/add_kerberos_routes.js f556acb ambari-web/app/routes/add_service_routes.js 9ff0b10 ambari-web/app/templates/main/service/add.hbs 2873a87 ambari-web/app/utils/ajax/ajax.js b63027e ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 422ac26 ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 ambari-web/test/controllers/wizard/step7_test.js d5d157d ambari-web/test/controllers/wizard/step8_test.js bdc4f4c Diff: https://reviews.apache.org/r/57858/diff/3/ Changes: https://reviews.apache.org/r/57858/diff/2-3/ Testing --- 20604 passing (24s) 128 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/ --- (Updated Март 23, 2017, 12:38 п.п.) Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. Changes --- Fixed issue, that appears after returning back to the Customize Services step. Bugs: AMBARI-20535 https://issues.apache.org/jira/browse/AMBARI-20535 Repository: ambari Description --- Instead of having two different steps for "Configure Services" and "Configure Identities", we should have configuring identities properties overlaid on "Configure Services" page. Diffs (updated) - ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f ambari-web/app/controllers/main/service/add_controller.js 0989f76 ambari-web/app/controllers/wizard.js 7af9ab0 ambari-web/app/controllers/wizard/step7_controller.js 0207e6b ambari-web/app/controllers/wizard/step8_controller.js efd8834 ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a ambari-web/app/routes/add_kerberos_routes.js f556acb ambari-web/app/routes/add_service_routes.js 9ff0b10 ambari-web/app/templates/main/service/add.hbs 2873a87 ambari-web/app/utils/ajax/ajax.js b63027e ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 422ac26 ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 ambari-web/test/controllers/wizard/step7_test.js d5d157d ambari-web/test/controllers/wizard/step8_test.js bdc4f4c Diff: https://reviews.apache.org/r/57858/diff/2/ Changes: https://reviews.apache.org/r/57858/diff/1-2/ Testing --- 20604 passing (24s) 128 pending Thanks, Aleksandr Kovalenko
Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/ --- Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. Bugs: AMBARI-20535 https://issues.apache.org/jira/browse/AMBARI-20535 Repository: ambari Description --- Instead of having two different steps for "Configure Services" and "Configure Identities", we should have configuring identities properties overlaid on "Configure Services" page. Diffs - ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f ambari-web/app/controllers/main/service/add_controller.js 0989f76 ambari-web/app/controllers/wizard.js 7af9ab0 ambari-web/app/controllers/wizard/step7_controller.js 0207e6b ambari-web/app/controllers/wizard/step8_controller.js efd8834 ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a ambari-web/app/routes/add_kerberos_routes.js f556acb ambari-web/app/routes/add_service_routes.js 9ff0b10 ambari-web/app/templates/main/service/add.hbs 2873a87 ambari-web/app/utils/ajax/ajax.js b63027e ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 422ac26 ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 ambari-web/test/controllers/wizard/step7_test.js d5d157d ambari-web/test/controllers/wizard/step8_test.js bdc4f4c Diff: https://reviews.apache.org/r/57858/diff/1/ Testing --- 20604 passing (24s) 128 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57813: Service quick links not showing up in the UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57813/#review169700 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 22, 2017, 11:13 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57813/ > --- > > (Updated Март 22, 2017, 11:13 д.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. > > > Bugs: AMBARI-20521 > https://issues.apache.org/jira/browse/AMBARI-20521 > > > Repository: ambari > > > Description > --- > > STR: > Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with > master components hosted on 64 separate hosts) > Navigate to any service on ambari-web that has quicklinks > Actual Result: Quick links are incorrectly absent > Expected Result: Quick links should be shown > > > Diffs > - > > ambari-web/app/utils/ajax/ajax.js b856e44 > ambari-web/test/utils/ajax/ajax_test.js 35de05f > > > Diff: https://reviews.apache.org/r/57813/diff/2/ > > > Testing > --- > > 30380 passing (38s) > 157 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 57698: Incorrect position of services actions dropdown after scrolling down the sidebar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57698/#review169181
---
Ship it!
Ship It!
- Aleksandr Kovalenko
On Март 16, 2017, 5:37 п.п., Andrii Babiichuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57698/
> ---
>
> (Updated Март 16, 2017, 5:37 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20483
> https://issues.apache.org/jira/browse/AMBARI-20483
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **STR**
> 1. Resize browser window so that its height is less than height of navigation
> sidebar.
> 2. Scroll the sidebar ('Services' item should be visible).
> 3. Open the services actions dropdown.
>
> **Result**
> Dropwown is incorrectly positioned
>
>
> Diffs
> -
>
> ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1f61104
>
>
> Diff: https://reviews.apache.org/r/57698/diff/1/
>
>
> Testing
> ---
>
> 20579 passing (21s)
> 153 pending
>
>
> Thanks,
>
> Andrii Babiichuk
>
>
Re: Review Request 57642: Upgrade pre-checks screen does not show CONFIG_MERGE warning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57642/#review169009 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 15, 2017, 1:45 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57642/ > --- > > (Updated Март 15, 2017, 1:45 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20449 > https://issues.apache.org/jira/browse/AMBARI-20449 > > > Repository: ambari > > > Description > --- > > STR > Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1 > Register HDP-2.6 version and install the bits > Click on Upgrade and click on Warning hyperlink for EU > Result: > Shows 2 warnings for EU. Click on the Warning and it shows "only one warning" > and the warning for CONFIG_MERGE pre-check does not show up > (see attachments) > From the output of pre-checks API call, I do see two warning for Config Merge > as below: > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > a760f0c > ambari-web/app/messages.js 1a26516 > ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs > 79e1de5 > > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_configs_recommend_table.hbs > PRE-CREATION > ambari-web/app/views/common/modal_popups/cluster_check_popup.js a613f4b > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js > 1d88913 > ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js > d70379b > > > Diff: https://reviews.apache.org/r/57642/diff/1/ > > > Testing > --- > > 20570 passing (32s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 57475: Host Page filter doesn't work after sort by name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57475/#review168559 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 9, 2017, 6:39 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57475/ > --- > > (Updated Март 9, 2017, 6:39 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. > > > Bugs: AMBARI-20384 > https://issues.apache.org/jira/browse/AMBARI-20384 > > > Repository: ambari > > > Description > --- > > STR: > Filter on say Infra SOLR Instance: All > Sort by Name > Clear filter > Again use filter for any Component > Result: The value drop-down for the filter never appears. > > > Diffs > - > > ambari-web/app/controllers/main/host/combo_search_box.js dedd290 > > > Diff: https://reviews.apache.org/r/57475/diff/1/ > > > Testing > --- > > 30367 passing (35s) > 157 pending > > > Thanks, > > Andrii Tkach > >
Review Request 57464: Error during moving ResourceManager without Tez installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57464/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-20379 https://issues.apache.org/jira/browse/AMBARI-20379 Repository: ambari Description --- Run Move Wizard for ResourceManager without Tez installed. Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js f87d05b ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 612efd0 Diff: https://reviews.apache.org/r/57464/diff/1/ Testing --- 20577 passing (31s) 153 pending Thanks, Aleksandr Kovalenko
Review Request 57455: Complete button after move masters is grayed out even after move has completed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57455/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20373 https://issues.apache.org/jira/browse/AMBARI-20373 Repository: ambari Description --- STR : Move namenode from host1 to host2. Complete the move. The complete button is grayed out and can't be clicked. Diffs - ambari-web/app/routes/reassign_master_routes.js d5cbadb Diff: https://reviews.apache.org/r/57455/diff/1/ Testing --- 20577 passing (40s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57389: Discard/Save buttons for service configs are always enabled if custom property is overridden with empty value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57389/#review168159 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 7, 2017, 5:46 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57389/ > --- > > (Updated Март 7, 2017, 5:46 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20348 > https://issues.apache.org/jira/browse/AMBARI-20348 > > > Repository: ambari > > > Description > --- > > # STR > 1. Create custom property for any service > 2. Create override for this property (override value should be empty) > 3. Save changes > > # Result > Discard and Save button on configs page of the mentioned service are always > enabled. > > > Diffs > - > > ambari-web/app/utils/config.js 28881bb > ambari-web/test/utils/config_test.js f418614 > > > Diff: https://reviews.apache.org/r/57389/diff/1/ > > > Testing > --- > > 20577 passing (20s) > 153 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 57296: Full-height modals overflow viewport vertically
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57296/#review167852 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 3, 2017, 6:07 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57296/ > --- > > (Updated Март 3, 2017, 6:07 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20311 > https://issues.apache.org/jira/browse/AMBARI-20311 > > > Repository: ambari > > > Description > --- > > Modal popups that occupy all available height (i.e., containing background > operations logs) overflow viewport vertically. > > > Diffs > - > > ambari-web/app/styles/common.less ad1da66 > ambari-web/app/styles/log_file_search.less cf5ef29 > ambari-web/app/templates/common/host_progress_popup.hbs ae411b1 > ambari-web/app/views/common/host_progress_popup_body_view.js f119c3b > ambari-web/app/views/common/modal_popup.js f09ae62 > > > Diff: https://reviews.apache.org/r/57296/diff/1/ > > > Testing > --- > > 20575 passing (18s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 57290: Despite user selecting not to apply Config Changes, Changes are being applied
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57290/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-20302 https://issues.apache.org/jira/browse/AMBARI-20302 Repository: ambari Description --- Steps: 1) On an existing cluster, Delete Ambari Infra service 2) At time of deletion , there will be a popup which shows Recommended Config changes 3) Unselect the recommended config change and continue Expected: Config change should not be applied Acutal: Config change was applied regardless Refer to screenshot for the example config which got changed Diffs - ambari-web/app/controllers/main/service/item.js 621c3b6 ambari-web/test/controllers/main/service/item_test.js fff321c Diff: https://reviews.apache.org/r/57290/diff/1/ Testing --- 20575 passing (33s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57247: Create Widget: Metrics select is empty after refresh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57247/#review167693 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 2, 2017, 5:49 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57247/ > --- > > (Updated Март 2, 2017, 5:49 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20273 > https://issues.apache.org/jira/browse/AMBARI-20273 > > > Repository: ambari > > > Description > --- > > Steps to reproduce: > Open Create Widget wizard > Go to second step > Refresh page > Try to select metrics > Actual result: > Metrics select is empty > > > Diffs > - > > ambari-web/app/views/main/service/widgets/create/expression_view.js c4a1a3e > > > Diff: https://reviews.apache.org/r/57247/diff/1/ > > > Testing > --- > > 20574 passing (34s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 57245: Call to fetch Quick Links host fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57245/#review167689
---
Ship it!
Ship It!
- Aleksandr Kovalenko
On Март 2, 2017, 4:30 п.п., Andrii Tkach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57245/
> ---
>
> (Updated Март 2, 2017, 4:30 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20271
> https://issues.apache.org/jira/browse/AMBARI-20271
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Steps to reproduce:
> Go to Hosts page
> Switch page of hosts
> Go to Dashboard page
> Actual Result:
> Call to
> api/v1/clusters/perf/hosts?Hosts/host_name.in()=Hosts/public_host_name_response=true
> fails with error:
> {
> "status" : 400,
> "message" : "Unable to compile query predicate: IN operator is missing a
> required right operand."
> }
>
>
> Diffs
> -
>
> ambari-web/app/mappers/hosts_mapper.js b64bd8d
> ambari-web/app/views/common/quick_view_link_view.js bb21b9f
>
>
> Diff: https://reviews.apache.org/r/57245/diff/1/
>
>
> Testing
> ---
>
> 20574 passing (32s)
> 153 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 57144: While enabling Ranger Plugins, Improper formatting of recommended configs in the popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57144/#review167067 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 28, 2017, 1:20 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57144/ > --- > > (Updated Фев. 28, 2017, 1:20 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20235 > https://issues.apache.org/jira/browse/AMBARI-20235 > > > Repository: ambari > > > Description > --- > > While enabling Ranger Plugins, Improper formatting of recommended configs in > the popup. > > Seeing the recommended configs for Knox is improper format. The text is in > white color and the format is also not correct. > > STR: Enable Ranger Plugins, click save and go to recommended configs popup > > > Diffs > - > > ambari-web/app/styles/application.less 8cb9388 > > Diff: https://reviews.apache.org/r/57144/diff/ > > > Testing > --- > > 20520 passing (18s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 57133: Entries in columns ‘Current Value’ and ‘Resulting Value’ are same in Upgrade pre-checks screen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57133/#review167036 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 28, 2017, 10:35 д.п., Denys Buzhor wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57133/ > --- > > (Updated Фев. 28, 2017, 10:35 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20229 > https://issues.apache.org/jira/browse/AMBARI-20229 > > > Repository: ambari > > > Description > --- > > UI have to skip warnings where result and current values are the same. > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 35b2ecce36 > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js > 8bb6e0d87a > > Diff: https://reviews.apache.org/r/57133/diff/ > > > Testing > --- > > 20521 passing (23s) > 153 pending > > > Thanks, > > Denys Buzhor > >
Review Request 57098: Strange UI behavior on editing property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57098/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20214 https://issues.apache.org/jira/browse/AMBARI-20214 Repository: ambari Description --- When editing YARN Capacity Scheduler property and on UI shows "There is 1 configuration change in 1 service" page starts to scroll down infinitely, which makes impossibly to use page comfortable. Browser: Win64 Chrome Version 58.0.3018.3 (Official Build) Diffs - ambari-web/app/styles/config_history_flow.less e3fe0e7 ambari-web/app/views/main/service/info/configs.js cd64a8b Diff: https://reviews.apache.org/r/57098/diff/ Testing --- 20520 passing (27s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57095: UI asking user to "refresh yarn queue" on stopped yarn service, which results to infinite refresh time as yarn is stopped
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57095/#review166875 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 27, 2017, 2:57 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57095/ > --- > > (Updated Фев. 27, 2017, 2:57 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20211 > https://issues.apache.org/jira/browse/AMBARI-20211 > > > Repository: ambari > > > Description > --- > > STR: > - Deploy cluster > - Stop all services > - edit yarn capacity scheduler > - follow next instructions > > Result: > Modal popup with recommendation to refresh YARN queue is displayed even if > ResourceManager is not runing so that this command can't be executed. > > > Diffs > - > > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > f52d1af > > ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js > 1a93a26 > > Diff: https://reviews.apache.org/r/57095/diff/ > > > Testing > --- > > 20520 passing (19s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 57076: Config Groups are shown twice after creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57076/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20201 https://issues.apache.org/jira/browse/AMBARI-20201 Repository: ambari Description --- The same config group is being shown twice after config group creation. Here's what I did: Go to Services > HDFS > Configs Click on "Manage Config Groups" There were two groups already (Default and AMS-DN) Added the 10 config groups hdfs-01, hdfs-02, ... hdfs-10 Clicked on hdfs-01 from the left panel Clicked on the + icon from the right panel Used the filter to set "perf-c-1" This added 111 hosts. Hit OK. Hit Save. This brings you out of the config group popups. Back on the Service page, the click on "Manage Config Groups". There's a duplicate entry for hdfs-01 Click on the config group pulldown. There's a duplicate entry for hdfs-01 The duplicates go away after a page refresh Diffs - ambari-web/app/controllers/main/service/manage_config_groups_controller.js 0df5dc5 Diff: https://reviews.apache.org/r/57076/diff/ Testing --- 20490 passing (24s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 57026: Cover NameNode HA wizard with unit tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57026/#review166694 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 24, 2017, 10:05 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57026/ > --- > > (Updated Фев. 24, 2017, 10:05 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20165 > https://issues.apache.org/jira/browse/AMBARI-20165 > > > Repository: ambari > > > Description > --- > > Cover NameNode HA wizard with unit tests > > > Diffs > - > > ambari-web/app/assets/test/tests.js 05c1657 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js > 435fe0f > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js > 0a46af7 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step4_controller.js > c0f688e > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js > 7b20439 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step6_controller.js > 0ef3048 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js > b98c2df > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step1_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step2_controller_test.js > 570f45a > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js > 98d71da > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js > d5ab8d2 > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step5_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step6_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step9_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/57026/diff/ > > > Testing > --- > > 20490 passing (33s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 56982: Merge Preview Configuration changes to branch-2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56982/#review166513 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 23, 2017, 1:08 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56982/ > --- > > (Updated Фев. 23, 2017, 1:08 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20143 > https://issues.apache.org/jira/browse/AMBARI-20143 > > > Repository: ambari > > > Description > --- > > Merge the following to branch-2.5: > AMBARI-19048 > AMBARI-19189 > AMBARI-19572 > AMBARI-19231 > AMBARI-19308 > AMBARI-19678 > AMBARI-19281 > AMBARI-19318 > AMBARI-19387 > AMBARI-19447 > AMBARI-19586 > AMBARI-19644 > AMBARI-19590 > AMBARI-19713 > AMBARI-19924 > AMBARI-19896 > > > Diffs > - > > ambari-web/app/assets/test/tests.js 7440819 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js > 475cc52 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js > b241707 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js > 2bc6e37 > ambari-web/app/controllers/main/host/details.js f040db5 > ambari-web/app/controllers/main/service/info/configs.js 32062e8 > ambari-web/app/controllers/main/service/item.js 11df45a > ambari-web/app/controllers/main/service/reassign/step1_controller.js > 9f30bb7 > ambari-web/app/controllers/main/service/reassign/step3_controller.js > d717dea > ambari-web/app/controllers/main/service/reassign/step4_controller.js > e14cb2a > ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c > ambari-web/app/controllers/wizard/step7_controller.js 66ea208 > ambari-web/app/messages.js 33195e0 > ambari-web/app/mixins/common/configs/enhanced_configs.js f7cc4cf > ambari-web/app/mixins/common/track_request_mixin.js c665253 > ambari-web/app/mixins/main/service/groups_mapping.js 40cd0cb > ambari-web/app/routes/ra_high_availability_routes.js 9995937 > ambari-web/app/routes/reassign_master_routes.js 35bd96f > ambari-web/app/styles/application.less f7cab50 > ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs > b6fff84 > ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs > 456e9ed > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs > 32ea830 > ambari-web/app/templates/main/host/details/addComponentPopup.hbs ff69b9e > ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs > PRE-CREATION > ambari-web/app/templates/main/host/details/deleteComponentPopup.hbs 10b24fd > ambari-web/app/templates/main/service/add_host_popup.hbs 7431080 > ambari-web/app/templates/main/service/info/delete_service_warning_popup.hbs > PRE-CREATION > ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 > ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js > 8aa0125 > ambari-web/app/views/main/host/summary.js 80c4890 > ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 > ambari-web/app/views/main/service/reassign/step5_view.js c5fc3c8 > > ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js > PRE-CREATION > ambari-web/test/controllers/main/host/details_test.js 9efece0 > ambari-web/test/controllers/main/service/info/config_test.js 09772ff > ambari-web/test/controllers/main/service/item_test.js 1b21b78 > ambari-web/test/controllers/main/service/reassign/step1_controller_test.js > a43d91f > ambari-web/test/controllers/main/service/reassign/step3_controller_test.js > e433f47 > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 362153a > ambari-web/test/controllers/wizard/step7_test.js cd6b21c > > Diff: https://reviews.apache.org/r/56982/diff/ > > > Testing > --- > > 30331 passing (23s) > 157 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56942: Test and fix new modals styles on Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56942/#review166386 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 22, 2017, 6:11 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56942/ > --- > > (Updated Фев. 22, 2017, 6:11 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20118 > https://issues.apache.org/jira/browse/AMBARI-20118 > > > Repository: ambari > > > Description > --- > > Apply updated modal styles to ambari-web and fix inconsistences. > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > cb02665 > ambari-web/app/controllers/wizard/step7/assign_master_controller.js 81c80e1 > ambari-web/app/controllers/wizard/step9_controller.js f63bd79 > ambari-web/app/routes/main.js 14435e8 > ambari-web/app/styles/enhanced_service_dashboard.less dfbe042 > ambari-web/app/styles/modal_popups.less a6a0196 > ambari-web/app/styles/stack_versions.less 0e1d2d0 > ambari-web/app/styles/theme/bootstrap-ambari.css 2c84f88 > ambari-web/app/templates/common/assign_master_components.hbs d5eaf75 > ambari-web/app/templates/common/configs/propertyDependence_footer.hbs > ee03ad4 > ambari-web/app/templates/common/modal_popup.hbs 59e9c0b > ambari-web/app/templates/common/progress.hbs 8485698 > ambari-web/app/templates/main/service/info/save_popup_footer.hbs 4907b3a > ambari-web/app/templates/wizard/step3/step3_host_warning_popup_footer.hbs > d906b75 > ambari-web/app/views/common/assign_master_components_view.js 73654c7 > ambari-web/app/views/common/configs/service_configs_by_category_view.js > 25f7dfb > ambari-web/app/views/main/admin/kerberos/disable_view.js 64657e8 > ambari-web/app/views/wizard/step7/assign_master_view.js b795647 > > Diff: https://reviews.apache.org/r/56942/diff/ > > > Testing > --- > > 20373 passing (19s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 56893: Configs filter is not reset if configs has no filter input
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56893/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-20100 https://issues.apache.org/jira/browse/AMBARI-20100 Repository: ambari Description --- STR: 1. Open Add Service Wizard. 2. Proceed to the Customize Services step. 3. Input some value in configs filter. 4. Switch tab to Misc configs. Expected result: all configs are shown. Actual result: configs are filtered, it is unable to clear filter. Diffs - ambari-web/app/views/common/configs/service_config_view.js daf26b0 Diff: https://reviews.apache.org/r/56893/diff/ Testing --- 20376 passing (35s) 153 pending Thanks, Aleksandr Kovalenko
Review Request 56854: Wizard 'Assign Master ' step is showing inconsistent Select view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56854/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-20082 https://issues.apache.org/jira/browse/AMBARI-20082 Repository: ambari Description --- In Wizard > Assign Mater step, the select host menu is not consistent with the whole style guide. Should make it looks like a normal dropdown. As investigated, it is impossible to customize the "Option" menu, so would consider replacing that with dropdown button and dropdown menu. Diffs - ambari-web/app/styles/application.less aa8f075 ambari-web/app/styles/wizard.less 579b21b ambari-web/app/templates/common/assign_master_components.hbs a0a4990 ambari-web/app/templates/common/form/dropdown.hbs PRE-CREATION ambari-web/app/views.js 6972d2a ambari-web/app/views/common/assign_master_components_view.js 4646cf0 ambari-web/app/views/common/form/dropdown.js PRE-CREATION Diff: https://reviews.apache.org/r/56854/diff/ Testing --- 20376 passing (26s) 153 pending Thanks, Aleksandr Kovalenko
Review Request 56761: Hosts filter component list is not sorted so it is difficult to use
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56761/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-20051 https://issues.apache.org/jira/browse/AMBARI-20051 Repository: ambari Description --- Hosts filter component list is not sorted so it is difficult to use Diffs - ambari-web/app/views/main/host/combo_search_box.js 2f9900a ambari-web/test/views/main/host/combo_search_box_test.js c82167c Diff: https://reviews.apache.org/r/56761/diff/ Testing --- 30314 passing (23s) 157 pending Thanks, Aleksandr Kovalenko
Re: Review Request 56715: Operations do not show up in the operations list without a refresh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56715/#review165742 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 15, 2017, 6:16 п.п., Denys Buzhor wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56715/ > --- > > (Updated Фев. 15, 2017, 6:16 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20028 > https://issues.apache.org/jira/browse/AMBARI-20028 > > > Repository: ambari > > > Description > --- > > Restart attempted from the host page. > Ambari asks for a confirmation, shows the operations screen, but doesn't take > any action. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js c49bfaef86 > ambari-web/app/mixins/common/track_request_mixin.js 07eaf6e289 > ambari-web/app/routes/main.js 9ed2dd10c4 > > Diff: https://reviews.apache.org/r/56715/diff/ > > > Testing > --- > > 20340 passing (25s) > 153 pending > > > Thanks, > > Denys Buzhor > >
Re: Review Request 56712: Incorrect work of filters on Versions page of Admin View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56712/#review165713 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 15, 2017, 3:22 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56712/ > --- > > (Updated Фев. 15, 2017, 3:22 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-20025 > https://issues.apache.org/jira/browse/AMBARI-20025 > > > Repository: ambari > > > Description > --- > > Filter by cluster name doesn't work (while being enabled, showing versions > that are not installed on cluster) > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 1de8817 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > 84d7b33 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackversionsListCtrl_test.js > 6f168db > > Diff: https://reviews.apache.org/r/56712/diff/ > > > Testing > --- > > Executed 81 of 81 SUCCESS (0.466 secs / 0.461 secs) > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56679/#review165701 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 14, 2017, 8:29 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56679/ > --- > > (Updated Фев. 14, 2017, 8:29 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, and Yusaku Sako. > > > Bugs: AMBARI-20016 > https://issues.apache.org/jira/browse/AMBARI-20016 > > > Repository: ambari > > > Description > --- > > STR: > On a 1000-node cluster, go to Hosts page > Set the page size to 100 (shows hosts 1-100) > Using the paging controls, go to the next page (shows hosts 101-200) - this > takes several seconds > Using the paging controls, go to the next page (shows hosts 201-300) - this > takes longer > Repeat showing the next set of hosts. This gets progressively slower. I gave > up when I hit 701-800 since the page got totally stuck after waiting for 3 > minutes. > > > Diffs > - > > ambari-web/app/controllers/main.js 87a483e > ambari-web/app/controllers/main/service/add_controller.js f312a5a > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 4cf22d4 > ambari-web/app/controllers/wizard/step7_controller.js 1d24ee3 > ambari-web/app/mappers/alert_definition_summary_mapper.js 8b59c7c > ambari-web/app/mappers/alert_definitions_mapper.js c400b89 > ambari-web/app/mappers/alert_groups_mapper.js c079c21 > ambari-web/app/mappers/alert_instances_mapper.js 269941b > ambari-web/app/mappers/alert_notification_mapper.js 9567c77 > ambari-web/app/mappers/cluster_mapper.js 5689867 > ambari-web/app/mappers/components_state_mapper.js 89d5af2 > ambari-web/app/mappers/configs/config_groups_mapper.js fe3d7a1 > ambari-web/app/mappers/configs/service_config_version_mapper.js 68bf235 > ambari-web/app/mappers/configs/themes_mapper.js 8ad51bd > ambari-web/app/mappers/hosts_mapper.js 3c7dd70 > ambari-web/app/mappers/quicklinks_mapper.js 6cb1fe0 > ambari-web/app/mappers/repository_version_mapper.js 48e460b > ambari-web/app/mappers/root_service_mapper.js 1e0e070 > ambari-web/app/mappers/server_data_mapper.js a99d8ae > ambari-web/app/mappers/service_mapper.js 9a330f9 > ambari-web/app/mappers/service_metrics_mapper.js c4f37df > ambari-web/app/mappers/stack_mapper.js b1a5faf > ambari-web/app/mappers/stack_service_mapper.js 21c4db9 > ambari-web/app/mappers/stack_upgrade_history_mapper.js 823ae80 > ambari-web/app/mappers/stack_version_mapper.js bd37288 > ambari-web/app/mappers/target_cluster_mapper.js f774213 > ambari-web/app/mappers/users_mapper.js 80d7feb > ambari-web/app/mappers/widget_mapper.js 0991d4f > ambari-web/app/mixins/main/service/configs/config_overridable.js 93dea5f > ambari-web/app/mixins/main/service/groups_mapping.js 0781aa3 > ambari-web/app/models/user.js 4dde8ec > ambari-web/app/utils/http_client.js 9b8346c > ambari-web/test/controllers/main/admin_test.js b2828d0 > ambari-web/test/controllers/main/host/details_test.js 17b1eec > ambari-web/test/controllers/main/service/add_controller_test.js 715f46a > ambari-web/test/controllers/main/service/item_test.js 6430ab6 > ambari-web/test/mappers/alert_groups_mapper_test.js 9480e3d > ambari-web/test/mixins/main/service/configs/config_overridable_test.js > b1eb099 > ambari-web/test/models/host_component_test.js d577005 > ambari-web/test/models/host_stack_version_test.js 702e284 > ambari-web/test/models/rack_test.js a63eaba > ambari-web/test/models/stack_service_test.js bc101e0 > ambari-web/test/utils/http_client_test.js 589c44e > > Diff: https://reviews.apache.org/r/56679/diff/ > > > Testing > --- > > 20340 passing (34s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 56550: Set recommended tooltip appears in front of icon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56550/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19964 https://issues.apache.org/jira/browse/AMBARI-19964 Repository: ambari Description --- Go to installer step7 wizard and try to click on set recommended icon for DataNode maximum Java heap size Diffs - ambari-web/app/app.js 53394a0 ambari-web/app/templates/common/configs/widgets/controls.hbs 52cccd4 ambari-web/app/utils/bootstrap_reopen.js PRE-CREATION ambari-web/app/views/common/configs/service_configs_by_category_view.js f4f35c8 ambari-web/app/views/common/configs/widgets/config_widget_view.js e93baa2 Diff: https://reviews.apache.org/r/56550/diff/ Testing --- Results of running unit tests: 30319 passing (26s) 157 pending Thanks, Aleksandr Kovalenko
Re: Review Request 56548: Clicking on the login button (or hitting page refresh) to seeing the dashboard takes a while on a 1000-node cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56548/#review165135 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 10, 2017, 4:18 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56548/ > --- > > (Updated Фев. 10, 2017, 4:18 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. > > > Bugs: AMBARI-19962 > https://issues.apache.org/jira/browse/AMBARI-19962 > > > Repository: ambari > > > Description > --- > > Log in to Dashboard is really slow (about 15 seconds on a 1000-node cluster). > This does not include the time to load the widget graphs (loading the widget > takes additional ~5 seconds on top). > Let's identify the bottlenecks and how we can make this much faster (a few > seconds is ideal). > > > Diffs > - > > ambari-web/app/router.js d671e86 > ambari-web/app/utils/ajax/ajax.js e344128 > > Diff: https://reviews.apache.org/r/56548/diff/ > > > Testing > --- > > 20345 passing (31s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 56544: No config properties are changed after deleting service if it's performed after service page refresh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56544/#review165120 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 10, 2017, 1:58 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56544/ > --- > > (Updated Фев. 10, 2017, 1:58 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19960 > https://issues.apache.org/jira/browse/AMBARI-19960 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Navigate to the page of any service which requires reconfiguration on its > deleting. > 2. Refresh page. > 3. Delete service. > > **Result** > No config properties are changed. > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 7010ab5 > ambari-web/test/controllers/main/service/item_test.js 302a9a5 > > Diff: https://reviews.apache.org/r/56544/diff/ > > > Testing > --- > > 20345 passing (21s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56502: Unexpected paging behavior on Hosts page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56502/#review164949 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 9, 2017, 4:26 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56502/ > --- > > (Updated Фев. 9, 2017, 4:26 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19942 > https://issues.apache.org/jira/browse/AMBARI-19942 > > > Repository: ambari > > > Description > --- > > Ambari remembers the page size of the Hosts page that was previously used. > After setting the page size to 100, logging out, and logging back in, the > table only shows 10 hosts. Then all of a sudden it shows 100 hosts. This > experience is jarring to the end user. > It's much better if we don't show any hosts at all until all 100 hosts can be > shown. > > > Diffs > - > > ambari-web/app/views/main/host.js 9183f6b > ambari-web/test/views/main/host_test.js 50279e6 > > Diff: https://reviews.apache.org/r/56502/diff/ > > > Testing > --- > > 30312 passing (34s) > 157 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 56486: Restart Indicator in Service > Config page does not disappear automatically - page refresh required
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56486/#review164894 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 9, 2017, 11:07 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56486/ > --- > > (Updated Фев. 9, 2017, 11:07 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19937 > https://issues.apache.org/jira/browse/AMBARI-19937 > > > Repository: ambari > > > Description > --- > > After restarting components that need restart due to config changes, the > restart indicator does not go away automatically. The user needs to do a page > refresh to make it go away. > > > Diffs > - > > ambari-web/app/mappers/component_config_mapper.js c1568e0 > > Diff: https://reviews.apache.org/r/56486/diff/ > > > Testing > --- > > 20337 passing (35s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55099: Disable auto start before RU/EU and enable during finalization phase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55099/#review164104 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 2, 2017, 7:15 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55099/ > --- > > (Updated Фев. 2, 2017, 7:15 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19319 > https://issues.apache.org/jira/browse/AMBARI-19319 > > > Repository: ambari > > > Description > --- > > Add the API calls to disable/enable auto start and assign it to the UI team > to make the changes as part of RU/EU orchestration. > Lets see if we can also design an alert that WARNs when autostart is disabled > - especially if it was disabled due to EU/RU. > > > Diffs > - > > ambari-web/app/messages.js 6f8f435 > ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs > 8bb0904 > > Diff: https://reviews.apache.org/r/55099/diff/ > > > Testing > --- > > 19845 passing (24s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55099: Disable auto start before RU/EU and enable during finalization phase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55099/#review164105 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 2, 2017, 7:15 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55099/ > --- > > (Updated Фев. 2, 2017, 7:15 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19319 > https://issues.apache.org/jira/browse/AMBARI-19319 > > > Repository: ambari > > > Description > --- > > Add the API calls to disable/enable auto start and assign it to the UI team > to make the changes as part of RU/EU orchestration. > Lets see if we can also design an alert that WARNs when autostart is disabled > - especially if it was disabled due to EU/RU. > > > Diffs > - > > ambari-web/app/messages.js 6f8f435 > ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs > 8bb0904 > > Diff: https://reviews.apache.org/r/55099/diff/ > > > Testing > --- > > 19845 passing (24s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 56176: Recommendations for non-editable properties should be listed as 'Required Changes'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56176/#review163826 --- Ship it! Ship It! - Aleksandr Kovalenko On Фев. 1, 2017, 4:31 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56176/ > --- > > (Updated Фев. 1, 2017, 4:31 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19821 > https://issues.apache.org/jira/browse/AMBARI-19821 > > > Repository: ambari > > > Description > --- > > As result of configs recommendation API call, the changes to be made are > displayed in popup, so that user can discard some of them. There should be no > discard ability for non-editable properties. > The above is correct for delete service popup, service configs page and > 'configure services' wizard step. > > > Diffs > - > > ambari-web/app/mixins/common/configs/config_recommendation_parser.js > b014ede > ambari-web/app/mixins/common/configs/config_recommendations.js 7427a54 > > ambari-web/app/mixins/common/configs/config_with_override_recommendation_parser.js > 86ccb65 > ambari-web/app/mixins/common/configs/enhanced_configs.js c86f132 > ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js > ffb3add > ambari-web/test/mixins/common/configs/config_recommendations_test.js > baa8ed6 > ambari-web/test/mixins/common/configs/enhanced_configs_test.js 0955a8f > > ambari-web/test/views/common/modal_popups/dependent_configs_list_popup_test.js > 9dc4bf6 > > Diff: https://reviews.apache.org/r/56176/diff/ > > > Testing > --- > > 20325 passing (20s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56083: Reassign wizard erases config properties attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56083/#review163525 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 30, 2017, 3:41 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56083/ > --- > > (Updated Янв. 30, 2017, 3:41 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19781 > https://issues.apache.org/jira/browse/AMBARI-19781 > > > Repository: ambari > > > Description > --- > > In process of reconfiguring moved component, Reassign wizard doesn't save > attributes of affected properties. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step3_controller.js > f13cf0b > ambari-web/app/controllers/main/service/reassign/step4_controller.js > 2e9d431 > ambari-web/app/controllers/main/service/reassign_controller.js e512835 > ambari-web/app/routes/reassign_master_routes.js a2a9743 > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 6bf381a > > Diff: https://reviews.apache.org/r/56083/diff/ > > > Testing > --- > > 20325 passing (18s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56081: Normalize upgrade status label in Upgrade History
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56081/#review163521 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 30, 2017, 2:40 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56081/ > --- > > (Updated Янв. 30, 2017, 2:40 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19779 > https://issues.apache.org/jira/browse/AMBARI-19779 > > > Repository: ambari > > > Description > --- > > Normalize upgrade status label in Upgrade History > > > Diffs > - > > ambari-web/app/models/host_stack_version.js b0c000e > ambari-web/app/models/stack_version/stack_upgrade_history.js 9e0439c > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history.hbs > e023fbb > ambari-web/app/utils/string_utils.js f4e3674 > ambari-web/test/utils/string_utils_test.js 3c7b077 > > Diff: https://reviews.apache.org/r/56081/diff/ > > > Testing > --- > > 20330 passing (34s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55984: Refreshing the page (browser refresh) when on the tez view goes back to the main views page (non admin user)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55984/#review163127 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 26, 2017, 3:14 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55984/ > --- > > (Updated Янв. 26, 2017, 3:14 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19724 > https://issues.apache.org/jira/browse/AMBARI-19724 > > > Repository: ambari > > > Description > --- > > Create a new user. > Setup view access for the user. > Login: load the tez view. > Refresh via browser. > Goes back to the landing page instead of refreshing the tez view. > > > Diffs > - > > ambari-web/app/routes/main.js 382818b > > Diff: https://reviews.apache.org/r/55984/diff/ > > > Testing > --- > > 20323 passing (33s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55949: Styles for showing Config Changes need more polishing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55949/#review162999 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 25, 2017, 6:40 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55949/ > --- > > (Updated Янв. 25, 2017, 6:40 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19713 > https://issues.apache.org/jira/browse/AMBARI-19713 > > > Repository: ambari > > > Description > --- > > 1. When showing diff in the Config Change popup, the content for "Current" vs > "New" and "Current" vs "Recommended" columns don't line up properly. See the > attached screenshots. The left edge for the content box of "Current" / > "Recommended" should be flush with the left edge of the header. > 2. The color palette used for the diff looks a bit out of place in that they > don't mesh well with the rest of the colors used in Ambari Web. We should use > the standard colors that we use elsewhere for warn, alert, success, etc. > > > Diffs > - > > ambari-web/app/styles/application.less cf84c5b > ambari-web/app/styles/common.less 5541d7c > ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs > c53e29d > ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs > PRE-CREATION > ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js > e8e6df5 > > Diff: https://reviews.apache.org/r/55949/diff/ > > > Testing > --- > > 20323 passing (18s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 55930: Unable to register HDP version 2.6.0.0 on cluster with HDP 2.5.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55930/#review162946 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 25, 2017, 12:35 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55930/ > --- > > (Updated Янв. 25, 2017, 12:35 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19711 > https://issues.apache.org/jira/browse/AMBARI-19711 > > > Repository: ambari > > > Description > --- > > STR: > Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0 > Enable NN HA > Enable security > Perform ambari upgade to 2.5.0.0-724 > Register HDP 2.6.0.p > Result: Unable to register HDP version 2.6.0.0 on cluster with HDP 2.5.3.0 > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 3c16963 > > Diff: https://reviews.apache.org/r/55930/diff/ > > > Testing > --- > > PhantomJS 1.9.8 (Linux): Executed 76 of 76 SUCCESS (0.554 secs / 0.548 secs) > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55850: Confirmation for adding host component from service summary page should be displayed once
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55850/#review162660 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 23, 2017, 5:42 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55850/ > --- > > (Updated Янв. 23, 2017, 5:42 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19678 > https://issues.apache.org/jira/browse/AMBARI-19678 > > > Repository: ambari > > > Description > --- > > While adding component to host via Service Actions menu on service summary > page, two confirmation popups are displayed: the first one with host > selection and the second one with configs changes. Confirmation should be > displayed once. > The above is correct for Hive Metastore, Ranger KMS Server and Nimbus. Adding > any other component from service summary doesn't result in displaying > properties to be updated. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 1fcc14d > ambari-web/app/controllers/main/service/item.js 3a60137 > ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs > ed8445e > ambari-web/app/templates/main/service/add_host_popup.hbs e5f2c99 > ambari-web/test/controllers/main/host/details_test.js ff5887c > > Diff: https://reviews.apache.org/r/55850/diff/ > > > Testing > --- > > 20321 passing (21s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 55728: accordion classname missed on configs page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55728/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19633 https://issues.apache.org/jira/browse/AMBARI-19633 Repository: ambari Description --- accordion classname missed on configs page Diffs - ambari-web/app/views/common/configs/config_category_container_view.js 73ded75 Diff: https://reviews.apache.org/r/55728/diff/ Testing --- 20307 passing (28s) 153 pending Thanks, Aleksandr Kovalenko
Review Request 55629: Ranger Admin HA Wizard: next button disappears
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55629/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19591 https://issues.apache.org/jira/browse/AMBARI-19591 Repository: ambari Description --- Next button disappears on step1 after typing valid URL to load balancer. Diffs - ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step1.hbs ed7098c ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs 5342728 Diff: https://reviews.apache.org/r/55629/diff/ Testing --- 20242 passing (25s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 55582: Move Master and HA wizards for all components should show config changes that will be done as part of the wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55582/#review161754 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 16, 2017, 4:48 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55582/ > --- > > (Updated Янв. 16, 2017, 4:48 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19572 > https://issues.apache.org/jira/browse/AMBARI-19572 > > > Repository: ambari > > > Description > --- > > Move master and HA wizard usually shows config changes on "Review" page. > As part of this ticket, we need to verify that this is being done for such > wizards for all components and we are not missing for any component. > Basically no config is being changed without letting user preview it on "Move > Master" and "component HA" wizard for any component. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step1_controller.js > 9f30bb7 > ambari-web/app/controllers/main/service/reassign/step3_controller.js > d717dea > ambari-web/app/controllers/main/service/reassign/step4_controller.js > c9cc28f > ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c > ambari-web/app/messages.js 7ed5826 > ambari-web/app/routes/reassign_master_routes.js 10ad0e9 > ambari-web/app/styles/wizard.less 2dbdd03 > ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs > 0cd177d > ambari-web/app/templates/main/service/reassign/step3.hbs 1f88fb5 > ambari-web/app/views/main/service/reassign/step3_view.js 003fcb6 > ambari-web/app/views/main/service/reassign/step5_view.js 3a063b5 > ambari-web/test/controllers/main/service/reassign/step1_controller_test.js > a43d91f > ambari-web/test/controllers/main/service/reassign/step3_controller_test.js > e433f47 > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 9a73524 > > Diff: https://reviews.apache.org/r/55582/diff/ > > > Testing > --- > > 20389 tests complete (35 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 55384: Handle cancelling of add/delete component by user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55384/#review161081 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 10, 2017, 5:11 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55384/ > --- > > (Updated Янв. 10, 2017, 5:11 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19447 > https://issues.apache.org/jira/browse/AMBARI-19447 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Attempt to add/delete any host component that potentially requires configs > changes. > 2. Close confirmation popup before configs request is complete. > 3. Repeat (1) for other component that potentially requires configs changes. > > **Result** > Properties affected by the first component are displayed inside the > confirmation popup for the second one. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js e2a2d8e > ambari-web/test/controllers/main/host/details_test.js f047f15 > > Diff: https://reviews.apache.org/r/55384/diff/ > > > Testing > --- > > 20389 tests complete (33 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 55172: Cover JournalNode HA wizard with unit tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55172/#review160484 --- Ship it! Ship It! - Aleksandr Kovalenko On Янв. 4, 2017, 12:48 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55172/ > --- > > (Updated Янв. 4, 2017, 12:48 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19361 > https://issues.apache.org/jira/browse/AMBARI-19361 > > > Repository: ambari > > > Description > --- > > Cover JournalNode HA wizard with unit tests > > > Diffs > - > > ambari-web/app/assets/test/tests.js 4263016 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/progress_controller.js > 436a8bd > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js > e1252b7 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js > d1cb198 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js > 1938527 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js > 262fe93 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js > add2070 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js > fe9a15b > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/progress_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step1_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step2_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step6_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step7_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/step8_controller_test.js > PRE-CREATION > > ambari-web/test/controllers/main/admin/highAvailability/journalNode/wizard_controller_test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/55172/diff/ > > > Testing > --- > > 19935 passing (28s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 55169: UI to add config ...2.6/HIVE/configuration/hive-env.xml 'enable_heap_dump' config in smart configs page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55169/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19358 https://issues.apache.org/jira/browse/AMBARI-19358 Repository: ambari Description --- UI needs to add the config 'enable_heap_dump' in Smart configs panel, so that its easy for user to enable/disable. Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 54c92d8 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json PRE-CREATION Diff: https://reviews.apache.org/r/55169/diff/ Testing --- 19859 passing (20s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 55099: Disable auto start before RU/EU and enable during finalization phase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55099/#review160374 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 30, 2016, 11:11 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55099/ > --- > > (Updated Дек. 30, 2016, 11:11 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19319 > https://issues.apache.org/jira/browse/AMBARI-19319 > > > Repository: ambari > > > Description > --- > > Add the API calls to disable/enable auto start and assign it to the UI team > to make the changes as part of RU/EU orchestration. > Lets see if we can also design an alert that WARNs when autostart is disabled > - especially if it was disabled due to EU/RU. > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 59f2a90 > ambari-web/app/messages.js 6296d55 > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js > de2bf3b > > Diff: https://reviews.apache.org/r/55099/diff/ > > > Testing > --- > > 19845 passing (24s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 55100: yarn.nodemanager.linux-container-executor.cgroups.mount-path need to be added to "Isolated" group on UI for yarn configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55100/#review160296 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 30, 2016, 11:41 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55100/ > --- > > (Updated Дек. 30, 2016, 11:41 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19327 > https://issues.apache.org/jira/browse/AMBARI-19327 > > > Repository: ambari > > > Description > --- > > yarn.nodemanager.linux-container-executor.cgroups.mount-path need to be added > to "Isolated" group on UI for yarn configs. > > > Diffs > - > > ambari-web/app/data/configs/services/yarn_properties.js 3d7ac6d > > Diff: https://reviews.apache.org/r/55100/diff/ > > > Testing > --- > > 19857 passing (26s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 55102: Install Wizard cannot proceed beyond Select Services page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55102/ --- Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko. Bugs: AMBARI-19329 https://issues.apache.org/jira/browse/AMBARI-19329 Repository: ambari Description --- Install Wizard cannot proceed beyond Select Services page Diffs - ambari-web/app/controllers/wizard.js 8742546 ambari-web/app/controllers/wizard/step6_controller.js 745ecc7 ambari-web/test/controllers/wizard/step6_test.js 851b984 Diff: https://reviews.apache.org/r/55102/diff/ Testing --- 19840 passing (20s) 153 pending Thanks, Aleksandr Kovalenko
Re: Review Request 55101: Install Wizard needs to scroll back up to top on step transitions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55101/#review160293 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 30, 2016, 12:02 п.п., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55101/ > --- > > (Updated Дек. 30, 2016, 12:02 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19326 > https://issues.apache.org/jira/browse/AMBARI-19326 > > > Repository: ambari > > > Description > --- > > On trunk, I noticed that the new design is requiring a lot of scrolling down > for the Next button. Once the transition to the next page is made, I have to > scroll all the way to the top every time. This is quite annoying. > > > Diffs > - > > ambari-web/app/routes/installer.js b4aa799 > ambari-web/app/utils/ember_reopen.js 4fd7cd4 > > Diff: https://reviews.apache.org/r/55101/diff/ > > > Testing > --- > > 19991 tests complete (27 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 55072: Non-editable properties should be handled for add/delete host component
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55072/#review160240 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 28, 2016, 2:03 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55072/ > --- > > (Updated Дек. 28, 2016, 2:03 п.п.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-19308 > https://issues.apache.org/jira/browse/AMBARI-19308 > > > Repository: ambari > > > Description > --- > > Some properties updated after adding/deleting host component may be > read-only. For example, user can edit nimbus.seeds value only before cluster > install. Such cases should be handled. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js c38838f > ambari-web/app/messages.js a1b67e5 > ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs > a1f53ef > ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs > 295acc8 > ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js > 1aa46eb > ambari-web/test/controllers/main/host/details_test.js 024e994 > > Diff: https://reviews.apache.org/r/55072/diff/ > > > Testing > --- > > 19993 tests complete (22 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 54976: Display properties for all affected services before adding or deleting ZooKeeper Server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54976/#review159955 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 22, 2016, 12:33 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54976/ > --- > > (Updated Дек. 22, 2016, 12:33 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19281 > https://issues.apache.org/jira/browse/AMBARI-19281 > > > Repository: ambari > > > Description > --- > > Only the changes for Storm configs are displayed inside the confirmation > popup before adding and deleting ZooKeeper server. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 5f2af2c > ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs > 713ad8c > ambari-web/test/controllers/main/host/details_test.js cbebcf0 > > Diff: https://reviews.apache.org/r/54976/diff/ > > > Testing > --- > > 19860 tests complete (23 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 54973: Cover global controllers with unit tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54973/#review159946 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 22, 2016, 11:19 д.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54973/ > --- > > (Updated Дек. 22, 2016, 11:19 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19280 > https://issues.apache.org/jira/browse/AMBARI-19280 > > > Repository: ambari > > > Description > --- > > Cover following files: > /ambari-web/app/controllers/global/background_operations_controller.js > /ambari-web/app/controllers/global/cluster_controller.js > /ambari-web/app/controllers/global/configuration_controller.js > /ambari-web/app/controllers/global/errors_handler_controller.js > /ambari-web/app/controllers/global/update_controller.js > /ambari-web/app/controllers/global/user_settings_controller.js > /ambari-web/app/controllers/global/wizard_watcher_controller.js > > > Diffs > - > > ambari-web/app/controllers/global/background_operations_controller.js > 9612141 > ambari-web/app/controllers/global/cluster_controller.js d7cedd3 > ambari-web/app/controllers/global/configuration_controller.js 43afc0f > ambari-web/app/controllers/global/update_controller.js ce93b34 > ambari-web/app/controllers/global/user_settings_controller.js 9580400 > ambari-web/test/controllers/global/background_operations_test.js b22c105 > ambari-web/test/controllers/global/cluster_controller_test.js 47708ac > ambari-web/test/controllers/global/configuration_controller_test.js 5baac0e > ambari-web/test/controllers/global/errors_handler_controller_test.js > 2a726ee > ambari-web/test/controllers/global/update_controller_test.js dc57a57 > ambari-web/test/controllers/global/user_settings_controller_test.js 5ae17f8 > > Diff: https://reviews.apache.org/r/54973/diff/ > > > Testing > --- > > 19847 passing (26s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 54971: AHW Configurations page looks not like any other wizard page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54971/#review159939 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 22, 2016, 9:59 д.п., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54971/ > --- > > (Updated Дек. 22, 2016, 9:59 д.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: ambari-19279 > https://issues.apache.org/jira/browse/ambari-19279 > > > Repository: ambari > > > Description > --- > > Configurations page on AHW wasn't updated when Ambari Theme was created. > > > Diffs > - > > ambari-web/app/templates/main/host/addHost/step4.hbs 305b5f4 > > Diff: https://reviews.apache.org/r/54971/diff/ > > > Testing > --- > > 19866 tests complete (30 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 54934: NN HA Namespace input "jumps" when invalid value provided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54934/#review159808 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 21, 2016, 1:36 п.п., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54934/ > --- > > (Updated Дек. 21, 2016, 1:36 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and > Andrii Tkach. > > > Bugs: AMBARI-19267 > https://issues.apache.org/jira/browse/AMBARI-19267 > > > Repository: ambari > > > Description > --- > > Namespace input becomes full-width when some invalid value provided. Input > should always look the same. > > > Diffs > - > > ambari-web/app/styles/wizard.less 49b6723 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs > f5087f9 > ambari-web/test/controllers/main/host/details_test.js 4203644 > > Diff: https://reviews.apache.org/r/54934/diff/ > > > Testing > --- > > 19866 tests complete (24 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54865/#review159620 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 19, 2016, 5:02 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54865/ > --- > > (Updated Дек. 19, 2016, 5:02 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-19240 > https://issues.apache.org/jira/browse/AMBARI-19240 > > > Repository: ambari > > > Description > --- > > Earlier UI parsed "failures" property value to get hosts which were failed. > But in perf clusters "failures" is very big (more than 300 MB), so we decided > to add one more property which contains only hostnames which failed. > > > Diffs > - > > ambari-web/app/mixins/main/host/details/actions/check_host.js faf8ef1 > ambari-web/app/utils/ajax/ajax.js 5831521 > ambari-web/test/controllers/wizard/step3_test.js 1e1b3bd > > Diff: https://reviews.apache.org/r/54865/diff/ > > > Testing > --- > > 19725 passing (25s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 54781: Fix styles for disabled buttons
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54781/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19212 https://issues.apache.org/jira/browse/AMBARI-19212 Repository: ambari Description --- Some buttons are presented with tag. But Bootstrap styles do not handle disabled styles for buttons with disabled attribute. We need to replace such buttons with . Diffs - ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs de303c6 ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs d6bcbac ambari-web/app/templates/main/admin/kerberos/step1.hbs e53db25 ambari-web/app/templates/main/admin/kerberos/step2.hbs 384a25d ambari-web/app/templates/main/alerts/add_alert_definition/step2.hbs f9278d0 ambari-web/app/templates/main/alerts/add_alert_definition/step3.hbs 89c3253 ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs 9e4b07f ambari-web/app/templates/main/service/reassign/step1.hbs f34a9a1 ambari-web/app/templates/main/service/reassign/step5.hbs a9cfb45 Diff: https://reviews.apache.org/r/54781/diff/ Testing --- 19882 tests complete (36 seconds) 153 tests pending Thanks, Aleksandr Kovalenko
Review Request 54777: Manage Journalnode Wizard: error on step3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54777/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19208 https://issues.apache.org/jira/browse/AMBARI-19208 Repository: ambari Description --- app.js:207465 Uncaught TypeError: Cannot read property 'host_name' of undefined(...)(anonymous function) @ app.js:207465ComputedPropertyPrototype.get @ vendor.js:4608get @ vendor.js:3014Ember.Handlebars.getPath @ vendor.js:19671(anonymous function) ... Diffs - ambari-web/app/controllers/main/admin/highAvailability_controller.js 71c11db ambari-web/app/messages.js 24ff1fc ambari-web/test/controllers/main/admin/highAvailability_controller_test.js 1e3d140 Diff: https://reviews.apache.org/r/54777/diff/ Testing --- 19882 tests complete (42 seconds) 153 tests pending Thanks, Aleksandr Kovalenko
Review Request 54707: Metrics Collector Move Wizard should no longer Restart All Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54707/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19191 https://issues.apache.org/jira/browse/AMBARI-19191 Repository: ambari Description --- Metrics Collector Move Wizard should no longer Restart All Services Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js da7d2d9 Diff: https://reviews.apache.org/r/54707/diff/ Testing --- 19881 tests complete (28 seconds) 153 tests pending Thanks, Aleksandr Kovalenko
Re: Review Request 54667: Add Service Page in Atlas doesn't show config on change
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54667/ --- (Updated Дек. 12, 2016, 5:25 п.п.) Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19169 https://issues.apache.org/jira/browse/AMBARI-19169 Repository: ambari Description --- Steps to reproduce: Add Atlas service Under Authentication Tab > Enable LDAP Authentication This will open LDAP/AD section below Now in LDAP/AD section > select LDAP Authentication Type as AD, here the properties related to AD are not shown. Diffs - ambari-web/app/views/common/configs/service_configs_by_category_view.js 16258cf ambari-web/app/views/common/configs/widgets/config_widget_view.js 62b6057 Diff: https://reviews.apache.org/r/54667/diff/ Testing --- 19878 tests complete (29 seconds) 155 tests pending Thanks, Aleksandr Kovalenko
Re: Review Request 54668: Version in process of downgrade isn't displayed by selecting any filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54668/#review158874 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 12, 2016, 5:09 п.п., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54668/ > --- > > (Updated Дек. 12, 2016, 5:09 п.п.) > > > Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko. > > > Bugs: AMBARI-19174 > https://issues.apache.org/jira/browse/AMBARI-19174 > > > Repository: ambari > > > Description > --- > > During downgrade no repo version is filtered by 'Upgrade/Downgrade in > process' value. > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 6d97205 > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js > 3508feb > ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 8fccbd9 > ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js > e83ae2c > > ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js > 8087c67 > ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b9e8e6d > > Diff: https://reviews.apache.org/r/54668/diff/ > > > Testing > --- > > 19881 tests complete (28 seconds) > 153 tests pending > > > Thanks, > > Andrii Tkach > >
Review Request 54667: Add Service Page in Atlas doesn't show config on change
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54667/ --- Review request for Ambari and Alexandr Antonenko. Repository: ambari Description --- Steps to reproduce: Add Atlas service Under Authentication Tab > Enable LDAP Authentication This will open LDAP/AD section below Now in LDAP/AD section > select LDAP Authentication Type as AD, here the properties related to AD are not shown. Diffs - ambari-web/app/views/common/configs/service_configs_by_category_view.js 16258cf ambari-web/app/views/common/configs/widgets/config_widget_view.js 62b6057 Diff: https://reviews.apache.org/r/54667/diff/ Testing --- 19878 tests complete (29 seconds) 155 tests pending Thanks, Aleksandr Kovalenko
