Review Request 64043: SNMP Trap should contain sysuptime field filled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64043/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-22458 https://issues.apache.org/jira/browse/AMBARI-22458 Repository: ambari Description --- SNMP Trap should contain sysuptime field filled: Calculating the Ambari server up time and setting it in TRAP. Fix: calculating the uptime using below call. RuntimeMXBean runtimeMXBean = ManagementFactory.getRuntimeMXBean(); long uptimeInMillis = runtimeMXBean.getUptime(); Diffs - ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java 1eb9977 Diff: https://reviews.apache.org/r/64043/diff/1/ Testing --- I have done basic testing locally by printing the uptimeInMillis in the logs - I have provided this patch to one of the customer and they confirmed that this patch works fine and could see sysuptime in target SNMP Target server. Thanks, Amarnath reddy pappu
Re: Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/#review168188 --- Ship it! Ship It! - Amarnath reddy pappu On March 3, 2017, 8:23 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57304/ > --- > > (Updated March 3, 2017, 8:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid > Wagle. > > > Bugs: AMBARI-20157 > https://issues.apache.org/jira/browse/AMBARI-20157 > > > Repository: ambari > > > Description > --- > > Fix for SNMP notification order > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ba86687 > > > Diff: https://reviews.apache.org/r/57304/diff/1/ > > > Testing > --- > > 1. Added the debug statements in "AlertNoticeDispatchService.java" file to > see the order before it actually dispatches the notifications > Expected Result: it should print he notifications in correct order , smaller > notification_id notification first and bigger one later. > Actual Result: PASS > > --- > > sample ambari-server.log > > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 > uuid:d237b8f4-9a89-4e62-9fe3-562119908732 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 > uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 > uuid:37bf8683--4c94-b2d0-763e85ef3d5c > ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService > RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 > uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 > > > -- > > > Thanks, > > Amarnath reddy pappu > >
Review Request 57304: Code review request for AMBARI-20157
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57304/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-20157 https://issues.apache.org/jira/browse/AMBARI-20157 Repository: ambari Description --- Fix for SNMP notification order Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ba86687 Diff: https://reviews.apache.org/r/57304/diff/1/ Testing --- 1. Added the debug statements in "AlertNoticeDispatchService.java" file to see the order before it actually dispatches the notifications Expected Result: it should print he notifications in correct order , smaller notification_id notification first and bigger one later. Actual Result: PASS --- sample ambari-server.log ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951 uuid:d237b8f4-9a89-4e62-9fe3-562119908732 ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952 uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703 ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953 uuid:37bf8683--4c94-b2d0-763e85ef3d5c ambari-server.log:03 Mar 2017 11:45:09,787 INFO [AlertNoticeDispatchService RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954 uuid:62d6ea6f-2190-4771-9497-eb07d45a4537 -- Thanks, Amarnath reddy pappu
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 18, 2016, 9:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> > line 2428
> > <https://reviews.apache.org/r/52839/diff/3/?file=1540784#file1540784line2428>
> >
> > nit: "Indicates the delay, in milliseconds, for the log4j monitor to
> > check for changes"
> >
> > Something like that. We need to be very detailed so users/admins can
> > understand exactly what a config knob is for.
implemented
> On Oct. 18, 2016, 9:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> > lines 963-964
> > <https://reviews.apache.org/r/52839/diff/3/?file=1540785#file1540785line963>
> >
> > These can be collapsed:
> > LOG.error("Exception in setting log4j monitor delay of {} for {}",
> > monitorDelay, log4jpath, e);
implemented
- Amarnath reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review153176
---
On Oct. 19, 2016, 10:51 p.m., Amarnath reddy pappu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
>
> (Updated Oct. 19, 2016, 10:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole,
> and Sid Wagle.
>
>
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ability to enable the DEBUG logs in Ambari-server without server restart
>
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if
> there is any change in the file/timestamp it will reload the log4j
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 378db18
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
> c05840e
>
> Diff: https://reviews.apache.org/r/52839/diff/
>
>
> Testing
> ---
>
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of
> time.
> [Resutl] PASS
>
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins
> of time.
> [Resutl] PASS
>
>
> Thanks,
>
> Amarnath reddy pappu
>
>
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 19, 2016, 10:51 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- Hi, Implemented most of the review comments. Have attached final code before shipping it. Regards, Amar Bugs: AMBARI-18592 https://issues.apache.org/jira/browse/AMBARI-18592 Repository: ambari Description --- Ability to enable the DEBUG logs in Ambari-server without server restart 1. PropertyConfigurator would check log4j.properties update every 5mins. if there is any change in the file/timestamp it will reload the log4j configurations. 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds 3. Have modified only for ambari-server 4. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 378db18 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c05840e Diff: https://reviews.apache.org/r/52839/diff/ Testing --- 1. Change the log4j.properties from INFO to DEBUG [Expected Result] server should start logging the DEBUG logs with in 5mins of time. [Resutl] PASS 2. Change the log4j.properties from DEBUG to INFO [Expected Result] server should reduce the logging to INFO mode with in 5mins of time. [Resutl] PASS Thanks, Amarnath reddy pappu
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 18, 2016, 6:29 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- implemented minor comments and attached diff Bugs: AMBARI-18592 https://issues.apache.org/jira/browse/AMBARI-18592 Repository: ambari Description --- Ability to enable the DEBUG logs in Ambari-server without server restart 1. PropertyConfigurator would check log4j.properties update every 5mins. if there is any change in the file/timestamp it will reload the log4j configurations. 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds 3. Have modified only for ambari-server 4. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 378db18 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c05840e Diff: https://reviews.apache.org/r/52839/diff/ Testing --- 1. Change the log4j.properties from INFO to DEBUG [Expected Result] server should start logging the DEBUG logs with in 5mins of time. [Resutl] PASS 2. Change the log4j.properties from DEBUG to INFO [Expected Result] server should reduce the logging to INFO mode with in 5mins of time. [Resutl] PASS Thanks, Amarnath reddy pappu
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> > lines 950-951
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line950>
> >
> > Whitespace: missing between `){`, and extra blank line at start of
> > method.
don't see any space between ){ - however please check latest diff.
taken out blank line at start
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> > lines 953-954
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line953>
> >
> > Variable names `monitor_delay` and `monitor_dealy_long` should be
> > camelCase, ie. `monitorDelay`.
> >
> > Also, `monitor_dealy_long` has typo, should be `monitorDelayLong`.
implemented
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> > line 958
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line958>
> >
> > Whitespace
don't see any whitespace , however please check latest diff
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> > line 962
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line962>
> >
> > Whitespace
don't see any whitespace , however please check latest diff
- Amarnath reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review153034
---
On Oct. 17, 2016, 11:07 p.m., Amarnath reddy pappu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
>
> (Updated Oct. 17, 2016, 11:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole,
> and Sid Wagle.
>
>
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ability to enable the DEBUG logs in Ambari-server without server restart
>
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if
> there is any change in the file/timestamp it will reload the log4j
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 378db18
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
> c05840e
>
> Diff: https://reviews.apache.org/r/52839/diff/
>
>
> Testing
> ---
>
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of
> time.
> [Resutl] PASS
>
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins
> of time.
> [Resutl] PASS
>
>
> Thanks,
>
> Amarnath reddy pappu
>
>
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534965#file1534965line2430> > > > > How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`? > > Amarnath reddy pappu wrote: > not using this - because will loose option of setting in milliseconds in > ambari.properties > > Attila Doroszlai wrote: > Using `TimeUnit.MINUTES.toMillis(5)` for the default value will not > affect the ability to get the setting from `ambari.properties`. It's just a > more readable form of the same time length in milliseconds. implemented - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152643 ------- On Oct. 17, 2016, 11:07 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > --- > > (Updated Oct. 17, 2016, 11:07 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > --- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > --- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 13, 2016, 7:35 p.m., Jonathan Hurley wrote: > > Ship It! thank you - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152562 --- On Oct. 17, 2016, 11:07 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > --- > > (Updated Oct. 17, 2016, 11:07 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > --- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > --- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534965#file1534965line2430> > > > > How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`? not using this - because will loose option of setting in milliseconds in ambari.properties - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152643 --- On Oct. 13, 2016, 6:01 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > --- > > (Updated Oct. 13, 2016, 6:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > --- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > --- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 13, 2016, 6:20 p.m., Alejandro Fernandez wrote: > > Ship It! thank you - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152549 --- On Oct. 13, 2016, 6:01 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > --- > > (Updated Oct. 13, 2016, 6:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > --- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > --- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
> On Oct. 13, 2016, 11:10 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534966#file1534966line512> > > > > I'm curious - why use the configuration property getDefaultValue()? > > Shouldn't there be a Configuration accessor that actually checks for the > > property being set? I am not sure if having a configurable value would be useful in this case. 5mins default value would be good enough i feel. do you think there may be customers who would want to enable the DEBUG logs less than 5mins time? that is the only case i can think of. please advise so that I can proceed accordingly. - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152595 --- On Oct. 13, 2016, 6:01 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > --- > > (Updated Oct. 13, 2016, 6:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > --- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > --- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18592 https://issues.apache.org/jira/browse/AMBARI-18592 Repository: ambari Description --- Ability to enable the DEBUG logs in Ambari-server without server restart 1. PropertyConfigurator would check log4j.properties update every 5mins. if there is any change in the file/timestamp it will reload the log4j configurations. 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds 3. Have modified only for ambari-server 4. Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 378db18 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c05840e Diff: https://reviews.apache.org/r/52839/diff/ Testing --- 1. Change the log4j.properties from INFO to DEBUG [Expected Result] server should start logging the DEBUG logs with in 5mins of time. [Resutl] PASS 2. Change the log4j.properties from DEBUG to INFO [Expected Result] server should reduce the logging to INFO mode with in 5mins of time. [Resutl] PASS Thanks, Amarnath reddy pappu
Re: Review Request 52583: Request/access log feature in Ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 8:43 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- Have added another method and attached new code diff. Have marked the bug as fixed and resolved it. Bugs: AMBARI-18543 https://issues.apache.org/jira/browse/AMBARI-18543 Repository: ambari Description --- Request/access log feature in Ambari-server 1. Have provided option in ambari.properties to configure the path - "server.requestlogs.path" By default has given it as server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log 2. If some customers does not want this to enable then removing "server.requestlogs.path" property will not create any file. 3. currently have set the number of reatin days as 15 4. if somebody wants to reduce/increase that value then add that property in ambari.properties file 5. log content should look alike below, 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0" Please review and provide your comments. Diffs (updated) - ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5e498f0 Diff: https://reviews.apache.org/r/52583/diff/ Testing --- 1. install and start Ambari-server, access the UI. Expected Result: server should create ambari-server-access-_mm_dd.log Result: PASS 2. access few links in ambari server UI Expected Result: server should log URL and response code Result: PASS 3. Remove entry server.requestlogs.path from ambari.properties Expected Result: server should not create any request log Result: PASS 4. change the log path server.requestlogs.path in ambari.properties and restart server Expected Result: it should create request log in new path Result: PASS File Attachments sample request log https://reviews.apache.org/media/uploaded/files/2016/10/10/c6ccec4e-dd49-4f13-8533-bf20e13f9b2f__ambari-access-2016_10_10.log.bk Thanks, Amarnath reddy pappu
Re: Review Request 52583: Request/access log feature in Ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 7:27 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- Have attached sample request log file. Bugs: AMBARI-18543 https://issues.apache.org/jira/browse/AMBARI-18543 Repository: ambari Description --- Request/access log feature in Ambari-server 1. Have provided option in ambari.properties to configure the path - "server.requestlogs.path" By default has given it as server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log 2. If some customers does not want this to enable then removing "server.requestlogs.path" property will not create any file. 3. currently have set the number of reatin days as 15 4. if somebody wants to reduce/increase that value then add that property in ambari.properties file 5. log content should look alike below, 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0" Please review and provide your comments. Diffs - ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5e498f0 Diff: https://reviews.apache.org/r/52583/diff/ Testing --- 1. install and start Ambari-server, access the UI. Expected Result: server should create ambari-server-access-_mm_dd.log Result: PASS 2. access few links in ambari server UI Expected Result: server should log URL and response code Result: PASS 3. Remove entry server.requestlogs.path from ambari.properties Expected Result: server should not create any request log Result: PASS 4. change the log path server.requestlogs.path in ambari.properties and restart server Expected Result: it should create request log in new path Result: PASS File Attachments (updated) sample request log https://reviews.apache.org/media/uploaded/files/2016/10/10/c6ccec4e-dd49-4f13-8533-bf20e13f9b2f__ambari-access-2016_10_10.log.bk Thanks, Amarnath reddy pappu
Re: Review Request 52583: Request/access log feature in Ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 7:26 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- Hi, I have modified the code to take couple of more things. 1. now access/request log prints time taken for each call to Ambari-server 2. have disabled requests logs bydefault. 3. havetaken care one of the issue relating to handles. 4. corrected incorrect comments. Regards, Amar Bugs: AMBARI-18543 https://issues.apache.org/jira/browse/AMBARI-18543 Repository: ambari Description --- Request/access log feature in Ambari-server 1. Have provided option in ambari.properties to configure the path - "server.requestlogs.path" By default has given it as server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log 2. If some customers does not want this to enable then removing "server.requestlogs.path" property will not create any file. 3. currently have set the number of reatin days as 15 4. if somebody wants to reduce/increase that value then add that property in ambari.properties file 5. log content should look alike below, 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0" Please review and provide your comments. Diffs (updated) - ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5e498f0 Diff: https://reviews.apache.org/r/52583/diff/ Testing --- 1. install and start Ambari-server, access the UI. Expected Result: server should create ambari-server-access-_mm_dd.log Result: PASS 2. access few links in ambari server UI Expected Result: server should log URL and response code Result: PASS 3. Remove entry server.requestlogs.path from ambari.properties Expected Result: server should not create any request log Result: PASS 4. change the log path server.requestlogs.path in ambari.properties and restart server Expected Result: it should create request log in new path Result: PASS Thanks, Amarnath reddy pappu
Re: Review Request 52583: Request/access log feature in Ambari-server
> On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523456#file1523456line78> > > > > Not really a path, more like "pattern" or "format". Probably disable > > by default. > > > > > > Are PUT/POST added to the log? With data? For PUT/POST it does not print any data. here is an example 0:0:0:0:0:0:0:1 - - [10/Oct/2016:19:08:29 +] "POST https://localhost:8441/agent/v1/heartbeat/c6407.ambari.apache.org HTTP/1.1" 200 230 "-" "-" 60 0:0:0:0:0:0:0:1 - - [10/Oct/2016:19:08:29 +] "POST https://localhost:8441/agent/v1/register/c6407.ambari.apache.org HTTP/1.1" 200 29619 "-" "-" 309 > On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 1685-1687 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523458#file1523458line1685> > > > > Description is wrong (copy/paste?). Also property name should be > > pattern or format, not "path" addressed, attaching modified code for review. > On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 626-628 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523459#file1523459line626> > > > > I think this is something that should be disabled by default and > > enabled for support purposes. What goes in the log? POST/PUT bodies? yeah agreed - removed the properties from ambari.properties file. only way to enable this is, add server.requestlogs.path in properties > On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 627 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523459#file1523459line627> > > > > !StringUtils.isBlank(...) implemented. > On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 634-635 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523459#file1523459line634> > > > > Why only use the default value? Isn't that why it's configurable? This is configurable. > On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 641 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523459#file1523459line641> > > > > Agent communication is pretty stable, what purpose is there in logging > > it? Maybe a separate config for that? we were still observing some agent communication issues. basically using access log we can find out how much time Ambari is taking to respond back for each agent as well. - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review151651 --- On Oct. 5, 2016, 11:51 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52583/ > --- > > (Updated Oct. 5, 2016, 11:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18543 > https://issues.apache.org/jira/browse/AMBARI-18543 > > > Repository: ambari > > > Description > --- > > Request/access log feature in Ambari-server > > > 1. Have provided option in ambari.properties to configure the path - > "server.requestlogs.path" > By default has given it as > server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log > 2. If some customers does not want this to enable then removing > "server.requestlogs.path" property will not create any file. > 3. currently have set the number of reatin days as 15 > 4. if somebody wants to reduce/increase that value then add that property in > ambari.properties file > > 5. log content should look alike below, > > 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" > "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 > Firefox/48.0" > > Please review and provide your comments. &
Re: Review Request 52583: Request/access log feature in Ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 5, 2016, 11:51 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18543 https://issues.apache.org/jira/browse/AMBARI-18543 Repository: ambari Description (updated) --- Request/access log feature in Ambari-server 1. Have provided option in ambari.properties to configure the path - "server.requestlogs.path" By default has given it as server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log 2. If some customers does not want this to enable then removing "server.requestlogs.path" property will not create any file. 3. currently have set the number of reatin days as 15 4. if somebody wants to reduce/increase that value then add that property in ambari.properties file 5. log content should look alike below, 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0" Please review and provide your comments. Diffs - ambari-server/conf/unix/ambari.properties 4dcbe99 ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5e498f0 Diff: https://reviews.apache.org/r/52583/diff/ Testing --- 1. install and start Ambari-server, access the UI. Expected Result: server should create ambari-server-access-_mm_dd.log Result: PASS 2. access few links in ambari server UI Expected Result: server should log URL and response code Result: PASS 3. Remove entry server.requestlogs.path from ambari.properties Expected Result: server should not create any request log Result: PASS 4. change the log path server.requestlogs.path in ambari.properties and restart server Expected Result: it should create request log in new path Result: PASS Thanks, Amarnath reddy pappu
Re: Review Request 52583: Request/access log feature in Ambari-server
> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523456#file1523456line78> > > > > What is the content of this log? > > > > Please add a branch and Jira to the code review. > > Amarnath reddy pappu wrote: > Have updated JIRA. have taken out the code from trunk. > > sample log line would be like below, > > 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 > "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 > Firefox/48.0" AMBARI-18543 - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review151593 ------- On Oct. 5, 2016, 11:38 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52583/ > --- > > (Updated Oct. 5, 2016, 11:38 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Repository: ambari > > > Description > --- > > Request/access log feature in Ambari-server > > > 1. Have provided option in ambari.properties to configure the path - > "server.requestlogs.path" > By default has given it as > server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log > 2. If some customers does not want this to enable then removing > "server.requestlogs.path" property will not create any file. > 3. currently have set the number of reatin days as 15 > 4. if somebody wants to reduce/increase that value then add that property in > ambari.properties file > > Please review and provide your comments. > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 5e498f0 > > Diff: https://reviews.apache.org/r/52583/diff/ > > > Testing > --- > > 1. install and start Ambari-server, access the UI. > Expected Result: server should create ambari-server-access-_mm_dd.log > Result: PASS > > 2. access few links in ambari server UI > Expected Result: server should log URL and response code > Result: PASS > > 3. Remove entry server.requestlogs.path from ambari.properties > Expected Result: server should not create any request log > Result: PASS > > 4. change the log path server.requestlogs.path in ambari.properties and > restart server > Expected Result: it should create request log in new path > Result: PASS > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 52583: Request/access log feature in Ambari-server
> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > <https://reviews.apache.org/r/52583/diff/1/?file=1523456#file1523456line78> > > > > What is the content of this log? > > > > Please add a branch and Jira to the code review. Have updated JIRA. have taken out the code from trunk. sample log line would be like below, 192.168.65.1 - - [05/Oct/2016:23:45:18 +] "GET / HTTP/1.1" 404 618 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0" - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review151593 ------- On Oct. 5, 2016, 11:38 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52583/ > --- > > (Updated Oct. 5, 2016, 11:38 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Repository: ambari > > > Description > --- > > Request/access log feature in Ambari-server > > > 1. Have provided option in ambari.properties to configure the path - > "server.requestlogs.path" > By default has given it as > server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log > 2. If some customers does not want this to enable then removing > "server.requestlogs.path" property will not create any file. > 3. currently have set the number of reatin days as 15 > 4. if somebody wants to reduce/increase that value then add that property in > ambari.properties file > > Please review and provide your comments. > > > Diffs > - > > ambari-server/conf/unix/ambari.properties 4dcbe99 > ambari-server/conf/windows/ambari.properties 64cce3b > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 2e850ef > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 5e498f0 > > Diff: https://reviews.apache.org/r/52583/diff/ > > > Testing > --- > > 1. install and start Ambari-server, access the UI. > Expected Result: server should create ambari-server-access-_mm_dd.log > Result: PASS > > 2. access few links in ambari server UI > Expected Result: server should log URL and response code > Result: PASS > > 3. Remove entry server.requestlogs.path from ambari.properties > Expected Result: server should not create any request log > Result: PASS > > 4. change the log path server.requestlogs.path in ambari.properties and > restart server > Expected Result: it should create request log in new path > Result: PASS > > > Thanks, > > Amarnath reddy pappu > >
Review Request 52583: Request/access log feature in Ambari-server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Repository: ambari Description --- Request/access log feature in Ambari-server 1. Have provided option in ambari.properties to configure the path - "server.requestlogs.path" By default has given it as server.requestlogs.path=\var\log\ambari-server\ambari-access-_mm_dd.log 2. If some customers does not want this to enable then removing "server.requestlogs.path" property will not create any file. 3. currently have set the number of reatin days as 15 4. if somebody wants to reduce/increase that value then add that property in ambari.properties file Please review and provide your comments. Diffs - ambari-server/conf/unix/ambari.properties 4dcbe99 ambari-server/conf/windows/ambari.properties 64cce3b ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2e850ef ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5e498f0 Diff: https://reviews.apache.org/r/52583/diff/ Testing --- 1. install and start Ambari-server, access the UI. Expected Result: server should create ambari-server-access-_mm_dd.log Result: PASS 2. access few links in ambari server UI Expected Result: server should log URL and response code Result: PASS 3. Remove entry server.requestlogs.path from ambari.properties Expected Result: server should not create any request log Result: PASS 4. change the log path server.requestlogs.path in ambari.properties and restart server Expected Result: it should create request log in new path Result: PASS Thanks, Amarnath reddy pappu
Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)
> On Sept. 7, 2016, 9:05 p.m., Sid Wagle wrote: > > Ship It! Thanks for the review. I am closing this request. - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/#review148085 --- On Sept. 7, 2016, 9:02 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51678/ > --- > > (Updated Sept. 7, 2016, 9:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18290 > https://issues.apache.org/jira/browse/AMBARI-18290 > > > Repository: ambari > > > Description > --- > > If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port > to fetch JMX properties. because of that Ambari shows incorrect > Active/Standby node information. > > Have made code changes to read the "hbase.http.policy" property and then > decide the protocol. > > Note: I have not made any changes to Ambari Web. If HTTPS is enabled for > HBase then all quick links should be opened on HTTPS. Currently Ambari checks > "dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick > links. it does not check HBase "hbase.http.policy" property to decide. am > leaving this functionality as it is. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 066d5c4 > > Diff: https://reviews.apache.org/r/51678/diff/ > > > Testing > --- > > Test cases executed > -- > 1. Install Ambari2.4, install HBase service, in summary it should show > "Active HBase Master" properly > 2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it > should show "Active HBase Master" properly > 3. Install Ambari2.4, install HBase service and add one more HBase master. it > should show one node as active and other is standby > 4. Install Ambari2.4, install HBase service and add one more HBase master and > enable HTTPS. it should show one node as active and other is standby > > > Thanks, > > Amarnath reddy pappu > >
Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/ --- (Updated Sept. 7, 2016, 9:02 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Changes --- I have incorporated reviews comments and attached the new code diff again. Bugs: AMBARI-18290 https://issues.apache.org/jira/browse/AMBARI-18290 Repository: ambari Description --- If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port to fetch JMX properties. because of that Ambari shows incorrect Active/Standby node information. Have made code changes to read the "hbase.http.policy" property and then decide the protocol. Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase then all quick links should be opened on HTTPS. Currently Ambari checks "dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick links. it does not check HBase "hbase.http.policy" property to decide. am leaving this functionality as it is. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 066d5c4 Diff: https://reviews.apache.org/r/51678/diff/ Testing --- Test cases executed -- 1. Install Ambari2.4, install HBase service, in summary it should show "Active HBase Master" properly 2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it should show "Active HBase Master" properly 3. Install Ambari2.4, install HBase service and add one more HBase master. it should show one node as active and other is standby 4. Install Ambari2.4, install HBase service and add one more HBase master and enable HTTPS. it should show one node as active and other is standby Thanks, Amarnath reddy pappu
Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/ --- (Updated Sept. 6, 2016, 10:56 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18290 https://issues.apache.org/jira/browse/AMBARI-18290 Repository: ambari Description (updated) --- If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port to fetch JMX properties. because of that Ambari shows incorrect Active/Standby node information. Have made code changes to read the "hbase.http.policy" property and then decide the protocol. Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase then all quick links should be opened on HTTPS. Currently Ambari checks "dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick links. it does not check HBase "hbase.http.policy" property to decide. am leaving this functionality as it is. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 066d5c4 Diff: https://reviews.apache.org/r/51678/diff/ Testing --- Test cases executed -- 1. Install Ambari2.4, install HBase service, in summary it should show "Active HBase Master" properly 2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it should show "Active HBase Master" properly 3. Install Ambari2.4, install HBase service and add one more HBase master. it should show one node as active and other is standby 4. Install Ambari2.4, install HBase service and add one more HBase master and enable HTTPS. it should show one node as active and other is standby Thanks, Amarnath reddy pappu
Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18290 https://issues.apache.org/jira/browse/AMBARI-18290 Repository: ambari Description --- If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port to fetch JMX properties. Have made code changes to read the "hbase.http.policy" property and then decide the protocol. Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase then all quick links should be opened on HTTPS. Currently Ambari checks "dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick links. it does not check HBase "hbase.http.policy" property to decide. am leaving this functionality as it is. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 066d5c4 Diff: https://reviews.apache.org/r/51678/diff/ Testing --- Test cases executed -- 1. Install Ambari2.4, install HBase service, in summary it should show "Active HBase Master" properly 2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it should show "Active HBase Master" properly 3. Install Ambari2.4, install HBase service and add one more HBase master. it should show one node as active and other is standby 4. Install Ambari2.4, install HBase service and add one more HBase master and enable HTTPS. it should show one node as active and other is standby Thanks, Amarnath reddy pappu
