Re: Review Request 64988: Log Search UI: implement graph for access logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64988/#review194892 --- Ship it! Ship It! - Denys Buzhor On Jan. 5, 2018, 7:34 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64988/ > --- > > (Updated Jan. 5, 2018, 7:34 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-22741 > https://issues.apache.org/jira/browse/AMBARI-22741 > > > Repository: ambari > > > Description > --- > > Line chart with time-dependent counts of access events from different sources > should be implemented. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts da78a71 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less > 0830193 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts > 1bb7f92 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/time-graph.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts 3992828 > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > f996d92 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-graph-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts > eb891ed > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts > 148aa62 > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html > 3c5852a > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts > 260b383 > > ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.spec.ts > b6206db > > ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html > 4d0bd39 > > ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.spec.ts > 5f5f1b0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts > f82823a > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > 9f2bb16 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > 63824cb > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 082082c > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > d085f3e > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > c9f9b52 > > ambari-logsearch/ambari-logsearch-web/src/app/components/horizontal-histogram/horizontal-histogram.component.ts > 9553e2e > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts > 7bd87ad > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 8e507ae > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts > 2bb8731 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > 6d50a17 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 67d9423 > > ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.spec.ts > 0c323f7 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html > 720f55e > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less > 364517c > > ambari-logsearch/ambari-logsearch-web
Re: Review Request 64816: Implement download configuration options and custom (i.e. local) repo support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64816/#review194473 --- Ship it! Ship It! - Denys Buzhor On Dec. 22, 2017, 9:41 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64816/ > --- > > (Updated Dec. 22, 2017, 9:41 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-22695 > https://issues.apache.org/jira/browse/AMBARI-22695 > > > Repository: ambari > > > Description > --- > > Implement support for downloading mpacks from custom URLs (local repos) and > using proxy configuration or Satellite/Spacewalker options. > > If the Custom/Local download option is selected, present a screen to the user > that allows them to input custom URLs for the mpack locations. This will be > presented after the mpack selection step. > > If the user selected the Custom/Local download configuration, present a > screen where they can provide custom URLs for each product repo within the > mpacks for each OS that is selected. This screen is pre-filled with the > public repo URLs and the user can change any or all of them to use a custom > URL. > > > Diffs > - > > ambari-web/app/controllers.js 5af0937f9b > ambari-web/app/controllers/installer.js 59571e7f3c > ambari-web/app/controllers/wizard.js c5a07fff8d > ambari-web/app/controllers/wizard/configureDownload_controller.js > 08af9603f9 > ambari-web/app/controllers/wizard/customMpackRepos_controller.js > PRE-CREATION > ambari-web/app/controllers/wizard/customProductRepos_controller.js > PRE-CREATION > ambari-web/app/controllers/wizard/downloadProducts_controller.js d12ae11d1f > ambari-web/app/controllers/wizard/selectMpacks_controller.js 7951d155e0 > ambari-web/app/controllers/wizard/step0_controller.js 270c7a4b21 > ambari-web/app/controllers/wizard/step10_controller.js 6840c1389b > ambari-web/app/controllers/wizard/step1_controller.js c137d96b5d > ambari-web/app/controllers/wizard/step2_controller.js dffc17e76b > ambari-web/app/controllers/wizard/step3_controller.js 36bf05a20e > ambari-web/app/controllers/wizard/step4_controller.js d82bf34df5 > ambari-web/app/controllers/wizard/step5_controller.js 3ca4165e68 > ambari-web/app/controllers/wizard/step6_controller.js b1941f070f > ambari-web/app/controllers/wizard/step7_controller.js 4b1eacbd8a > ambari-web/app/controllers/wizard/step8_controller.js 3ad65f170c > ambari-web/app/controllers/wizard/step9_controller.js 9f27f654a6 > ambari-web/app/controllers/wizard/verifyProducts_controller.js PRE-CREATION > ambari-web/app/controllers/wizard/wizardStep_controller.js PRE-CREATION > ambari-web/app/mappers/stack_mapper.js 415845e6e9 > ambari-web/app/messages.js 2efc023cd3 > ambari-web/app/mixins/wizard/wizard_menu_view.js 6dd7394bf6 > ambari-web/app/models/repository.js c50750feda > ambari-web/app/router.js d0b171477e > ambari-web/app/routes/installer.js 80cf116f04 > ambari-web/app/styles/theme/bootstrap-ambari.css 97419c7782 > ambari-web/app/styles/wizard.less 4330c6a81b > ambari-web/app/templates/installer.hbs 47e63ccac5 > ambari-web/app/templates/wizard/customMpackRepos.hbs PRE-CREATION > ambari-web/app/templates/wizard/customProductRepos.hbs PRE-CREATION > ambari-web/app/templates/wizard/downloadProducts.hbs a42622507f > ambari-web/app/templates/wizard/selectMpacks.hbs d78861e43f > ambari-web/app/templates/wizard/verifyProducts.hbs PRE-CREATION > ambari-web/app/views.js 8810f1328c > ambari-web/app/views/wizard/configureDownload_view.js 71c6527b82 > ambari-web/app/views/wizard/customMpackRepos_view.js PRE-CREATION > ambari-web/app/views/wizard/customProductRepos_view.js PRE-CREATION > ambari-web/app/views/wizard/downloadProducts_view.js b70275a9ea > ambari-web/app/views/wizard/verifyProducts_view.js PRE-CREATION > ambari-web/test/controllers/installer_test.js 88289b2a43 > ambari-web/test/controllers/wizard/selectMpacks_test.js 13e28ce23b > > > Diff: https://reviews.apache.org/r/64816/diff/1/ > > > Testing > --- > > 20297 passing (47s) > 125 pending > > Note that no new tests were added. These will be done later. Current priority > is to make this functional for the 1/1/18 milestone. > > > Thanks, > > Jason Golieb > >
Re: Review Request 63956: Use case and service based mpack selection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63956/#review191881 --- Ship it! Ship It! - Denys Buzhor On Nov. 20, 2017, 3:55 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63956/ > --- > > (Updated Nov. 20, 2017, 3:55 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-22482 > https://issues.apache.org/jira/browse/AMBARI-22482 > > > Repository: ambari > > > Description > --- > > Enable selection of mpacks to install via use cases or by direct service > selection. This includes switching between "basic" and "advanced" selection > modes. Basic mode allows selection of use cases only. Advanced mode allows > selection of mpacks and/or services directly. > > > Diffs > - > > ambari-web/app/controllers/installer.js 14ae790df97 > ambari-web/app/controllers/wizard/downloadProducts_controller.js > b3537320292 > ambari-web/app/controllers/wizard/selectMpacks_controller.js a7c62ff0c6a > ambari-web/app/messages.js c9bae250241 > ambari-web/app/routes/installer.js 9a49c365344 > ambari-web/app/templates/wizard/selectMpacks.hbs 19855d3071e > ambari-web/app/templates/wizard/selectMpacks/mpack.hbs 9a65baf5b1a > ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs > 05e75ffb150 > ambari-web/app/templates/wizard/selectMpacks/service.hbs PRE-CREATION > ambari-web/app/templates/wizard/selectMpacks/usecase.hbs PRE-CREATION > ambari-web/app/utils/ajax/ajax.js f86fd3ddbbf > ambari-web/app/views/wizard/selectMpacks_view.js deab12b5354 > ambari-web/test/controllers/wizard/selectMpacks_test.js 7102d91f026 > > > Diff: https://reviews.apache.org/r/63956/diff/2/ > > > Testing > --- > > 20287 passing (30s) > 124 pending > > > Thanks, > > Jason Golieb > >
Re: Review Request 64020: AMBARI-22496. Admin View - Manage Versions page should show HDP-GPL repo if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64020/#review191770 --- Ship it! Ship It! - Denys Buzhor On Nov. 23, 2017, 12:43 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64020/ > --- > > (Updated Nov. 23, 2017, 12:43 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Jason Golieb, and Yusaku Sako. > > > Bugs: AMBARI-22496 > https://issues.apache.org/jira/browse/AMBARI-22496 > > > Repository: ambari > > > Description > --- > > Display HDP-GPL repo field under Repositories in Manage Versions of Admin > View only if the user agreed to the GPL license agreement during > ambari-server setup > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 09e3c28 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > d5f4401 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > aeaaa71 > > > Diff: https://reviews.apache.org/r/64020/diff/2/ > > > Testing > --- > > Tested manually. Ambari-admin unit tests pass. > > Chrome 62.0.3202 (Mac OS X 10.11.6): Executed 76 of 76 SUCCESS (0.508 secs / > 0.486 secs) > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 64020: AMBARI-22496. Admin View - Manage Versions page should show HDP-GPL repo if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64020/#review191764 --- Ship it! Ship It! - Denys Buzhor On Nov. 22, 2017, 3:42 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64020/ > --- > > (Updated Nov. 22, 2017, 3:42 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Jason Golieb, and Yusaku Sako. > > > Bugs: AMBARI-22496 > https://issues.apache.org/jira/browse/AMBARI-22496 > > > Repository: ambari > > > Description > --- > > Display HDP-GPL repo field under Repositories in Manage Versions of Admin > View only if the user agreed to the GPL license agreement during > ambari-server setup > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 09e3c28 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > d5f4401 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > aeaaa71 > > > Diff: https://reviews.apache.org/r/64020/diff/1/ > > > Testing > --- > > Tested manually. Ambari-admin unit tests pass. > > Chrome 62.0.3202 (Mac OS X 10.11.6): Executed 76 of 76 SUCCESS (0.508 secs / > 0.486 secs) > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 64017: Installer - Select Version page should show HDP-GPL repo if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64017/#review191763 --- Ship it! Ship It! - Denys Buzhor On Nov. 22, 2017, 2:25 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64017/ > --- > > (Updated Nov. 22, 2017, 2:25 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Jason Golieb, and Yusaku Sako. > > > Bugs: AMBARI-22495 > https://issues.apache.org/jira/browse/AMBARI-22495 > > > Repository: ambari > > > Description > --- > > Display HDP-GPL repo field under Repositories in Select Version step of > Installer only if user agrees to gpl license agreement > > > Diffs > - > > ambari-web/app/controllers/installer.js a45ac57 > ambari-web/app/controllers/wizard/step8_controller.js 4bedde0 > ambari-web/app/mappers/repository_version_mapper.js 90086f2 > ambari-web/app/mappers/stack_mapper.js 822d35b > ambari-web/app/models/repository.js 91f0083 > ambari-web/app/models/stack_version/repository.js 8bd4323 > ambari-web/app/templates/wizard/step1.hbs 485bd5d > ambari-web/test/controllers/installer_test.js 3e1c622 > > > Diff: https://reviews.apache.org/r/64017/diff/2/ > > > Testing > --- > > Manually tested and verified. > > Ambari-web unit tests pass > 30518 passing (27s) > 157 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 63683: Improve install wizard data handling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63683/#review190850 --- Ship it! Ship It! - Denys Buzhor On Nov. 10, 2017, 3:03 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63683/ > --- > > (Updated Nov. 10, 2017, 3:03 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-22385 > https://issues.apache.org/jira/browse/AMBARI-22385 > > > Repository: ambari > > > Description > --- > > Make data persistence more consistent by using consistent method calls and > locating them in the same place for each step. This ensures that all steps > persist if the browser is reloaded. > > Also, improve data handling behavior when navigating backward in the wizard. > Now, the wizard tracks the saved state of all steps. If the user navigates > backward, there will be a warning displayed indicating that if they make > changes, they will lose saved data in later steps. If they don't change > anything, they can navigate back and forth without losing data. If they do > change something, the state of all later steps is reset. > > > Diffs > - > > .gitignore a40e61acbe4 > ambari-web/app/app.js 2526baa0047 > ambari-web/app/controllers/installer.js 5dd09414804 > ambari-web/app/controllers/main/host/add_controller.js 6b158c131ee > ambari-web/app/controllers/main/service/add_controller.js c11bcf267a4 > ambari-web/app/controllers/wizard.js 540cc638eb2 > ambari-web/app/controllers/wizard/configureDownload_controller.js > f3a8b1b588a > ambari-web/app/controllers/wizard/downloadProducts_controller.js > 165debbfb95 > ambari-web/app/controllers/wizard/selectMpacks_controller.js 9ab5a125f55 > ambari-web/app/controllers/wizard/step2_controller.js 05813e28b3a > ambari-web/app/controllers/wizard/step3_controller.js 2c61e02ea76 > ambari-web/app/controllers/wizard/step5_controller.js 873665267a9 > ambari-web/app/controllers/wizard/step6_controller.js 68ec3edf8de > ambari-web/app/controllers/wizard/step7_controller.js 3def063ac00 > ambari-web/app/controllers/wizard/step8_controller.js 0c72295d921 > ambari-web/app/messages.js 82adc8082b9 > ambari-web/app/mixins/wizard/assign_master_components.js 84a56f1d56b > ambari-web/app/routes/installer.js 5899ff3d545 > ambari-web/app/templates/common/assign_master_components.hbs a47e3f631a9 > ambari-web/app/templates/wizard/selectMpacks.hbs dd55ff307a6 > ambari-web/app/templates/wizard/selectMpacks/mpack.hbs aea598e3829 > ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs > cba1177052f > ambari-web/app/templates/wizard/step2.hbs b4ee25c4113 > ambari-web/app/templates/wizard/step3.hbs b480fd317c5 > ambari-web/app/templates/wizard/step6.hbs 5741f09f36a > ambari-web/app/views.js 1ef0b62321b > ambari-web/app/views/wizard/selectMpacks/mpack_view.js 9c22eb98d76 > ambari-web/app/views/wizard/selectMpacks/selectedMpackVersion_view.js > ca503d78510 > ambari-web/app/views/wizard/selectMpacks_view.js 3dc4ec05166 > ambari-web/app/views/wizard/step2_view.js 6bbda30625e > ambari-web/app/views/wizard/step6_view.js ab37245d9b8 > ambari-web/test/controllers/installer_test.js f581d91857d > ambari-web/test/controllers/main/host/add_controller_test.js 089d0182d76 > ambari-web/test/controllers/main/service/add_controller_test.js 1119176977a > ambari-web/test/controllers/wizard/step5_test.js 57c33b23afd > ambari-web/test/controllers/wizard/step6_test.js 85b4fab283e > ambari-web/test/controllers/wizard/step8_test.js fc977b764c2 > ambari-web/test/views/wizard/step2_view_test.js 93939682a7d > ambari-web/test/views/wizard/step6_view_test.js 7a4dc9f2d3d > > > Diff: https://reviews.apache.org/r/63683/diff/1/ > > > Testing > --- > > 20262 passing (23s) > 124 pending > > This also resolved outstanding unit tests from AMBARI-22311 > > > Thanks, > > Jason Golieb > >
Re: Review Request 63757: Enable mpack version selection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63757/#review190849 --- Ship it! Ship It! - Denys Buzhor On Nov. 13, 2017, 3:54 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63757/ > --- > > (Updated Nov. 13, 2017, 3:54 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-22420 > https://issues.apache.org/jira/browse/AMBARI-22420 > > > Repository: ambari > > > Description > --- > > Implement the ability to change mpack version in the available mpacks list. > > > Diffs > - > > .gitignore a40e61acbe4 > ambari-web/app/app.js 2526baa0047 > ambari-web/app/controllers/installer.js 5dd09414804 > ambari-web/app/controllers/main/host/add_controller.js 6b158c131ee > ambari-web/app/controllers/main/service/add_controller.js c11bcf267a4 > ambari-web/app/controllers/wizard.js 540cc638eb2 > ambari-web/app/controllers/wizard/configureDownload_controller.js > f3a8b1b588a > ambari-web/app/controllers/wizard/downloadProducts_controller.js > 165debbfb95 > ambari-web/app/controllers/wizard/selectMpacks_controller.js 9ab5a125f55 > ambari-web/app/controllers/wizard/step2_controller.js 05813e28b3a > ambari-web/app/controllers/wizard/step3_controller.js 2c61e02ea76 > ambari-web/app/controllers/wizard/step5_controller.js 873665267a9 > ambari-web/app/controllers/wizard/step6_controller.js 68ec3edf8de > ambari-web/app/controllers/wizard/step7_controller.js 3def063ac00 > ambari-web/app/controllers/wizard/step8_controller.js 0c72295d921 > ambari-web/app/messages.js 82adc8082b9 > ambari-web/app/mixins/wizard/assign_master_components.js 84a56f1d56b > ambari-web/app/routes/installer.js 5899ff3d545 > ambari-web/app/templates/common/assign_master_components.hbs a47e3f631a9 > ambari-web/app/templates/wizard/selectMpacks.hbs dd55ff307a6 > ambari-web/app/templates/wizard/selectMpacks/mpack.hbs aea598e3829 > ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs > cba1177052f > ambari-web/app/templates/wizard/step2.hbs b4ee25c4113 > ambari-web/app/templates/wizard/step3.hbs b480fd317c5 > ambari-web/app/templates/wizard/step6.hbs 5741f09f36a > ambari-web/app/views.js 1ef0b62321b > ambari-web/app/views/wizard/selectMpacks/mpack_view.js 9c22eb98d76 > ambari-web/app/views/wizard/selectMpacks/selectedMpackVersion_view.js > ca503d78510 > ambari-web/app/views/wizard/selectMpacks_view.js 3dc4ec05166 > ambari-web/app/views/wizard/step2_view.js 6bbda30625e > ambari-web/app/views/wizard/step6_view.js ab37245d9b8 > ambari-web/test/controllers/installer_test.js f581d91857d > ambari-web/test/controllers/main/host/add_controller_test.js 089d0182d76 > ambari-web/test/controllers/main/service/add_controller_test.js 1119176977a > ambari-web/test/controllers/wizard/selectMpacks_test.js 73210b460d3 > ambari-web/test/controllers/wizard/step5_test.js 57c33b23afd > ambari-web/test/controllers/wizard/step6_test.js 85b4fab283e > ambari-web/test/controllers/wizard/step8_test.js fc977b764c2 > ambari-web/test/views/wizard/step2_view_test.js 93939682a7d > ambari-web/test/views/wizard/step6_view_test.js 7a4dc9f2d3d > > > Diff: https://reviews.apache.org/r/63757/diff/1/ > > > Testing > --- > > 20268 passing (20s) > 124 pending > > > Thanks, > > Jason Golieb > >
Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185408 --- Ship it! Ship It! - Denys Buzhor On Sept. 13, 2017, 6:31 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62242/ > --- > > (Updated Sept. 13, 2017, 6:31 p.m.) > > > Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako. > > > Bugs: AMBARI-21933 > https://issues.apache.org/jira/browse/AMBARI-21933 > > > Repository: ambari > > > Description > --- > > Implement breadcrumb navigation in the Background Operations modal and the > drill-down views within it. This also affects the use of these views in the > High Availability wizard. The breadcrumbs will provide a better navigation > experience within this series of dialogs, helping the user to see the context > of the current view and to navigate back up the hierarchy more easily. It > will also be more consistent with the overall UX of Ambari 3.0.0. > > > Diffs > - > > ambari-web/app/controllers/global/background_operations_controller.js > de420b5a131 > > ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js > 4cbe59b020c > ambari-web/app/messages.js 87a5e97a68d > ambari-web/app/styles/modal_popups.less f7fe88be71d > ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 > ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 > ambari-web/app/utils/host_progress_popup.js 5bd02cd76de > ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 > ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 > ambari-web/test/controllers/global/background_operations_test.js > 4a8235c484b > > ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js > 364d9b0b451 > ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 > ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 > ambari-web/test/views/common/host_progress_popup_body_view_test.js > 5ccc0245101 > > > Diff: https://reviews.apache.org/r/62242/diff/2/ > > > Testing > --- > > 21293 passing > > > Thanks, > > Jason Golieb > >
Re: Review Request 58345: Remove duplicate condition from route
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58345/#review171553
---
Ship it!
Ship It!
- Denys Buzhor
On April 11, 2017, 10:59 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58345/
> ---
>
> (Updated April 11, 2017, 10:59 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20732
> https://issues.apache.org/jira/browse/ambari-20732
>
>
> Repository: ambari
>
>
> Description
> ---
>
> {{adminServiceAutoStart.enter}} contains duplicate
> {{!App.isAuthorized('CLUSTER.MANAGE_AUTO_START')}}.
>
>
> Diffs
> -
>
> ambari-web/app/routes/main.js 0a2375e
> ambari-web/test/controllers/main_test.js 9673092
> ambari-web/test/init_test.js db72744
>
>
> Diff: https://reviews.apache.org/r/58345/diff/1/
>
>
> Testing
> ---
>
> 20663 passing (23s)
> 128 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 58023: JS error on Step6 installer when click "all/none"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58023/#review170379
---
Ship it!
Ship It!
- Denys Buzhor
On March 29, 2017, 11:27 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58023/
> ---
>
> (Updated March 29, 2017, 11:27 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20619
> https://issues.apache.org/jira/browse/ambari-20619
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Issue appears not every time you click "all" / "none"
>
> JS-error:
> {{Uncaught TypeError: Cannot read property 'then' of undefined}}
>
>
> Diffs
> -
>
> ambari-web/app/controllers/wizard/step6_controller.js adfa0ba
>
>
> Diff: https://reviews.apache.org/r/58023/diff/1/
>
>
> Testing
> ---
>
> 20606 passing (22s)
> 128 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57985: Comparison for configs with list of hostNames doesn't show all hosts correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57985/#review170276 --- Ship it! Ship It! - Denys Buzhor On March 28, 2017, 8:50 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57985/ > --- > > (Updated March 28, 2017, 8:50 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20602 > https://issues.apache.org/jira/browse/ambari-20602 > > > Repository: ambari > > > Description > --- > > Normal format for such configs - "HostName and N others". > Sometimes "HostName" is missing and value is shown as "and N others". > > > Diffs > - > > ambari-web/app/templates/wizard/component_hosts.hbs 802b970 > ambari-web/app/views/common/controls_view.js 120ca9a > ambari-web/test/views/common/controls_view_test.js 3ff5253 > > > Diff: https://reviews.apache.org/r/57985/diff/1/ > > > Testing > --- > > 20606 passing (23s) > 128 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57943: Not all config groups are shown in the config history table
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57943/#review170139
---
Ship it!
Ship It!
- Denys Buzhor
On March 27, 2017, 7:35 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57943/
> ---
>
> (Updated March 27, 2017, 7:35 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20577
> https://issues.apache.org/jira/browse/ambari-20577
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Filter view should be bound to the {{controller.content.[]}}
>
>
> Diffs
> -
>
> ambari-web/app/views/main/dashboard/config_history_view.js 0acf556
> ambari-web/test/controllers/wizard/step8_test.js 15b9245
> ambari-web/test/views/main/dashboard/config_history_view_test.js d799c44
>
>
> Diff: https://reviews.apache.org/r/57943/diff/1/
>
>
> Testing
> ---
>
> 20606 passing (21s)
> 128 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57688: Start/Stop Service command may silently fail without any reporting for user
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57688/#review169153
---
Ship it!
Ship It!
- Denys Buzhor
On March 16, 2017, 1 p.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57688/
> ---
>
> (Updated March 16, 2017, 1 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20481
> https://issues.apache.org/jira/browse/ambari-20481
>
>
> Repository: ambari
>
>
> Description
> ---
>
> * Go to HDFS
> * Click "Start" or "Stop" on Service Actions menu
> * Request may fails
>
> *ER* Popup with reason should be shown (e.g. {{defaultErrorHandler}})
> *AR* Nothing happens
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/service/item.js 5169564
> ambari-web/test/controllers/main/service/item_test.js c4a50ea
>
>
> Diff: https://reviews.apache.org/r/57688/diff/1/
>
>
> Testing
> ---
>
> 20580 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57681: Unable to load UI after enabling some experimental features
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57681/#review169118 --- Ship it! Ship It! - Denys Buzhor On March 16, 2017, 10:19 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57681/ > --- > > (Updated March 16, 2017, 10:19 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20478 > https://issues.apache.org/jira/browse/AMBARI-20478 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Go to Experimantal features page. > 2. Change some settings. > 3. Refresh page or log out and log back in. > > **Result** > UI is not loading. > JS error is thrown: > ``` > Uncaught Error: assertion failed: Must use Ember.set() to access this property > at Object.Ember.assert (vendor.js:12048) > at Object.set [as createAlerts] (vendor.js:14450) > at Function.jQuery.extend.jQuery.fn.extend (vendor.js:476) > at Class.getUserPrefSuccessCallback (app.js:939) > at Class.newFunc [as getUserPrefSuccessCallback] (vendor.js:12954) > at Class.opt.success (app.js:166233) > at fire (vendor.js:1141) > at Object.fireWith [as resolveWith] (vendor.js:1252) > at done (vendor.js:8178) > at XMLHttpRequest.callback (vendor.js:8702) > ``` > > > Diffs > - > > ambari-web/app/controllers/experimental.js da8f39d > ambari-web/test/controllers/experimental_test.js 0ff0758 > > > Diff: https://reviews.apache.org/r/57681/diff/2/ > > > Testing > --- > > 20579 passing (19s) > 153 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 57640: Admin/Version page doesn't mark StackAndVersion item as active
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57640/#review168995 --- Ship it! Ship It! - Denys Buzhor On March 15, 2017, 12:20 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57640/ > --- > > (Updated March 15, 2017, 12:20 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20458 > https://issues.apache.org/jira/browse/ambari-20458 > > > Repository: ambari > > > Description > --- > > * Go to Admin Stacks page > * "Stack and Versions" item in the main menu is shown as active > * Click on Versions Tab > > *ER* "Stack and Versions" item is active > *AR* "Stack and Versions" item is not active > > > Diffs > - > > ambari-web/app/templates/main/side-menu-item.hbs 44de409 > ambari-web/test/views/main/menu_test.js 658984c > > > Diff: https://reviews.apache.org/r/57640/diff/1/ > > > Testing > --- > > 20578 passing (22s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57637: Few breadcrumbs are missing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57637/#review168987 --- Ship it! Ship It! - Denys Buzhor On March 15, 2017, 10:53 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57637/ > --- > > (Updated March 15, 2017, 10:53 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20456 > https://issues.apache.org/jira/browse/ambari-20456 > > > Repository: ambari > > > Description > --- > > * admin/stack/versions > * admin/stack/history > * some views > > Add ability to generate breadcrumbs from Routes if they are not set manually > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > a760f0c > ambari-web/app/routes/activate_hawq_standby_routes.js 9ba6073 > ambari-web/app/routes/add_hawq_standby_routes.js 346f506 > ambari-web/app/routes/add_kerberos_routes.js 462ce44 > ambari-web/app/routes/high_availability_routes.js 8f5fb13 > ambari-web/app/routes/main.js aace4a2 > ambari-web/app/routes/manage_journalnode_routes.js 90b45b0 > ambari-web/app/routes/ra_high_availability_routes.js 5be6c44 > ambari-web/app/routes/reassign_master_routes.js 341172b > ambari-web/app/routes/remove_hawq_standby_routes.js 64250ee > ambari-web/app/routes/rm_high_availability_routes.js d8aa8b3 > ambari-web/app/routes/stack_upgrade_routes.js f95dd6e > ambari-web/app/routes/view.js 22a4057 > ambari-web/app/routes/views.js 073507c > ambari-web/app/views/common/breadcrumbs_view.js f9073ba > ambari-web/test/views/common/breadcrumbs_view_test.js 751811c > > > Diff: https://reviews.apache.org/r/57637/diff/1/ > > > Testing > --- > > 20578 passing (21s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57602: Clock widget is not displayed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57602/#review168908 --- Ship it! Ship It! - Denys Buzhor On March 14, 2017, 4:50 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57602/ > --- > > (Updated March 14, 2017, 4:50 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20446 > https://issues.apache.org/jira/browse/AMBARI-20446 > > > Repository: ambari > > > Description > --- > > Optional digital clock widget attached to page is hidden underneath the > navigation bar. > > > Diffs > - > > ambari-web/app/styles/application.less 151e404 > > > Diff: https://reviews.apache.org/r/57602/diff/1/ > > > Testing > --- > > 20569 passing (22s) > 153 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 57591: Alert Definition "Last Changed" field is shown incorrect if alert wan't triggered any time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57591/#review168876 --- Ship it! Ship It! - Denys Buzhor On March 14, 2017, 9:34 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57591/ > --- > > (Updated March 14, 2017, 9:34 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20441 > https://issues.apache.org/jira/browse/AMBARI-20441 > > > Repository: ambari > > > Description > --- > > * Go to Alert Definition details page for Definition with NONE status (e.g. > "NameNode Heap Usage (Daily)") > > *AR* "Last Changed" is shown as "Jan 01 1970" > *ER* This field should be empty > > > Diffs > - > > ambari-web/app/models/alerts/alert_definition.js b55ef1b > > ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js > f987c52 > ambari-web/test/models/alerts/alert_definition_test.js 3d8b62d > > > Diff: https://reviews.apache.org/r/57591/diff/1/ > > > Testing > --- > > 20562 passing (21s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57457: Remove duplicate code from wizard menu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57457/#review168440
---
Ship it!
Ship It!
- Denys Buzhor
On March 9, 2017, 12:04 p.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57457/
> ---
>
> (Updated March 9, 2017, 12:04 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: AMBARI-20375
> https://issues.apache.org/jira/browse/AMBARI-20375
>
>
> Repository: ambari
>
>
> Description
> ---
>
> {{'isStep..Disabled'}} and {{'isStep..Completed'}} may be rewritten as
> computed macros
>
>
> Diffs
> -
>
> ambari-web/app/mixins/wizard/wizard_menu_view.js 90b7354
> ambari-web/app/views/main/service/reassign_view.js 4adbf11
>
>
> Diff: https://reviews.apache.org/r/57457/diff/1/
>
>
> Testing
> ---
>
> 20573 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57455: Complete button after move masters is grayed out even after move has completed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57455/#review168434 --- Ship it! Ship It! - Denys Buzhor On March 9, 2017, 11:20 a.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57455/ > --- > > (Updated March 9, 2017, 11:20 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20373 > https://issues.apache.org/jira/browse/AMBARI-20373 > > > Repository: ambari > > > Description > --- > > STR : > Move namenode from host1 to host2. > Complete the move. The complete button is grayed out and can't be clicked. > > > Diffs > - > > ambari-web/app/routes/reassign_master_routes.js d5cbadb > > > Diff: https://reviews.apache.org/r/57455/diff/1/ > > > Testing > --- > > 20577 passing (40s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 57367: Alert Definition Name with brackets marked as invalid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57367/#review168110 --- Ship it! Ship It! - Denys Buzhor On March 7, 2017, 10:26 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57367/ > --- > > (Updated March 7, 2017, 10:26 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20338 > https://issues.apache.org/jira/browse/ambari-20338 > > > Repository: ambari > > > Description > --- > > * Go to definition details page "NameNode Heap Usage (Daily)" > * Click Edit definition name > * It's already marked as invalid > > *ER* Name with brackets should not be marked as invalid > > > Diffs > - > > ambari-web/app/messages.js 44bf13e > ambari-web/app/utils/validator.js 5173702 > ambari-web/test/utils/validator_test.js 8565b3d > > > Diff: https://reviews.apache.org/r/57367/diff/1/ > > > Testing > --- > > 20575 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57334: Move breadcrumbs to the separated view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57334/#review167972 --- Ship it! Ship It! - Denys Buzhor On March 6, 2017, 1 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57334/ > --- > > (Updated March 6, 2017, 1 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20136 > https://issues.apache.org/jira/browse/ambari-20136 > > > Repository: ambari > > > Description > --- > > Breadcrumbs items should be defined in the routes. > > > Diffs > - > > ambari-web/app/assets/test/tests.js 308edcd > ambari-web/app/routes/main.js 4460442 > ambari-web/app/routes/view.js 50d8f4b > ambari-web/app/routes/views.js 88b1251 > ambari-web/app/templates/application.hbs 9d6db78 > ambari-web/app/templates/common/breadcrumbs.hbs PRE-CREATION > ambari-web/app/views.js 7ec59f7 > ambari-web/app/views/application.js ef9df6a > ambari-web/app/views/common/breadcrumbs_view.js PRE-CREATION > ambari-web/test/controllers/main/service/item_test.js e33ecaa > ambari-web/test/views/common/breadcrumbs_view_test.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/57334/diff/1/ > > > Testing > --- > > 20576 passing (21s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57286: Popup "Save changed" appears when user switches config versions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57286/#review167816 --- Ship it! Ship It! - Denys Buzhor On March 3, 2017, 1:28 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57286/ > --- > > (Updated March 3, 2017, 1:28 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20297 > https://issues.apache.org/jira/browse/ambari-20297 > > > Repository: ambari > > > Description > --- > > * Create several config versions > * Switch to one of them > * While it's loading (spinner is shown) try to switch to another version > > *ER* Confirmation popup should not be shown > *AR* This popup is shown > > > Diffs > - > > ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f > > > Diff: https://reviews.apache.org/r/57286/diff/1/ > > > Testing > --- > > 30365 passing (22s) > 157 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 57214: Unexpected popup after disable kerberos "You are in the process of disabling security on your cluster"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57214/ --- Review request for Ambari. Bugs: AMBARI-20261 https://issues.apache.org/jira/browse/AMBARI-20261 Repository: ambari Description --- STR: * Disable Security * Click on "Complete" button Confirmation popup is shown instead of closing *Disable Security* popup. Diffs - ambari-web/app/routes/main.js d7d27857fd Diff: https://reviews.apache.org/r/57214/diff/1/ Testing --- 20574 passing (28s) 153 pending Thanks, Denys Buzhor
Re: Review Request 57197: Add ability to use brace expansion in the dependent keys
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57197/#review167248
---
Ship it!
Ship It!
- Denys Buzhor
On March 1, 2017, 10:15 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57197/
> ---
>
> (Updated March 1, 2017, 10:15 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20252
> https://issues.apache.org/jira/browse/ambari-20252
>
>
> Repository: ambari
>
>
> Description
> ---
>
> {{'a.b', 'a.c'}} {{'a.{b,c}'}}
>
> Such ability exists in the Ember for a few years and may be implemented in
> Ambari.
>
>
> Diffs
> -
>
> ambari-web/app/utils/ember_reopen.js c7f93af
> ambari-web/test/utils/ember_reopen_test.js aa50a50
>
>
> Diff: https://reviews.apache.org/r/57197/diff/1/
>
>
> Testing
> ---
>
> 20571 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57138: Don't recalculate side-menu content when moving to the views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57138/#review167048 --- Ship it! Ship It! - Denys Buzhor On Feb. 28, 2017, 11:55 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57138/ > --- > > (Updated Feb. 28, 2017, 11:55 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20231 > https://issues.apache.org/jira/browse/AMBARI-20231 > > > Repository: ambari > > > Description > --- > > Side menu should not be rerendered when user is moved to some View. > > > Diffs > - > > ambari-web/app/controllers/main/views_controller.js e2e9281 > ambari-web/app/views/application.js 207e77f > ambari-web/app/views/main/menu.js 91aaad7 > ambari-web/app/views/main/views_view.js 46b3e43 > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js > e850339 > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js > d2b385a > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js > 4af3aa9 > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js > 577f07b > > Diff: https://reviews.apache.org/r/57138/diff/ > > > Testing > --- > > 20520 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 57133: Entries in columns ‘Current Value’ and ‘Resulting Value’ are same in Upgrade pre-checks screen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57133/ --- Review request for Ambari. Bugs: AMBARI-20229 https://issues.apache.org/jira/browse/AMBARI-20229 Repository: ambari Description --- UI have to skip warnings where result and current values are the same. Diffs - ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 35b2ecce36 ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 8bb6e0d87a Diff: https://reviews.apache.org/r/57133/diff/ Testing --- 20521 passing (23s) 153 pending Thanks, Denys Buzhor
Re: Review Request 57098: Strange UI behavior on editing property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57098/#review166911 --- Ship it! Ship It! - Denys Buzhor On Feb. 27, 2017, 6:52 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57098/ > --- > > (Updated Feb. 27, 2017, 6:52 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20214 > https://issues.apache.org/jira/browse/AMBARI-20214 > > > Repository: ambari > > > Description > --- > > When editing YARN Capacity Scheduler property and on UI shows "There is 1 > configuration change in 1 service" page starts to scroll down infinitely, > which makes impossibly to use page comfortable. > Browser: Win64 Chrome Version 58.0.3018.3 (Official Build) > > > Diffs > - > > ambari-web/app/styles/config_history_flow.less e3fe0e7 > ambari-web/app/views/main/service/info/configs.js cd64a8b > > Diff: https://reviews.apache.org/r/57098/diff/ > > > Testing > --- > > 20520 passing (27s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 57081: Not able to delete custom property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57081/#review166848 --- Ship it! Ship It! - Denys Buzhor On Feb. 27, 2017, 10:52 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57081/ > --- > > (Updated Feb. 27, 2017, 10:52 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20147 > https://issues.apache.org/jira/browse/ambari-20147 > > > Repository: ambari > > > Description > --- > > Steps to reproduce the issue: > 1. Under Hive service , Create a custom Group called "hive-group1" > 2. Add a property say "hive.mv.files.thread" > 3. save the configurations > 4. Again go to hive configurations, select hive-group1 group and then try to > delete the configuration by clicking "-" , it does nothing - in console fails > with JS error as > Uncaught TypeError: Cannot read property 'without' of null > at Class.removeOverride (app.js:185869) > at handler (vendor.js:21227) > at HTMLAnchorElement. (vendor.js:13019) > at HTMLDivElement.dispatch (vendor.js:126) > at HTMLDivElement.i (vendor.js:126) > > > Diffs > - > > ambari-web/app/mixins/common/configs/configs_comparator.js b619aca > ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60 > > Diff: https://reviews.apache.org/r/57081/diff/ > > > Testing > --- > > 20490 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57076: Config Groups are shown twice after creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57076/#review166837 --- Ship it! Ship It! - Denys Buzhor On Feb. 26, 2017, 10:41 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57076/ > --- > > (Updated Feb. 26, 2017, 10:41 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20201 > https://issues.apache.org/jira/browse/AMBARI-20201 > > > Repository: ambari > > > Description > --- > > The same config group is being shown twice after config group creation. > Here's what I did: > Go to Services > HDFS > Configs > Click on "Manage Config Groups" > There were two groups already (Default and AMS-DN) > Added the 10 config groups hdfs-01, hdfs-02, ... hdfs-10 > Clicked on hdfs-01 from the left panel > Clicked on the + icon from the right panel > Used the filter to set "perf-c-1" > This added 111 hosts. Hit OK. Hit Save. This brings you out of the config > group popups. > Back on the Service page, the click on "Manage Config Groups". There's a > duplicate entry for hdfs-01 > Click on the config group pulldown. There's a duplicate entry for hdfs-01 > The duplicates go away after a page refresh > > > Diffs > - > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 0df5dc5 > > Diff: https://reviews.apache.org/r/57076/diff/ > > > Testing > --- > > 20490 passing (24s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 57022: After disabling security page is not refreshed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57022/#review11 --- Ship it! Ship It! - Denys Buzhor On Feb. 24, 2017, 8:45 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57022/ > --- > > (Updated Feb. 24, 2017, 8:45 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20163 > https://issues.apache.org/jira/browse/ambari-20163 > > > Repository: ambari > > > Description > --- > > When "Disable security popup" is closed, page should be refreshed. > > > Diffs > - > > ambari-web/app/routes/main.js 9730de2 > > Diff: https://reviews.apache.org/r/57022/diff/ > > > Testing > --- > > 20423 passing (24s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 56957: Click feedback/disable toggle is missing for transition buttons in Kerberos Wizard - prone to various failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56957/ --- Review request for Ambari. Bugs: AMBARI-20123 https://issues.apache.org/jira/browse/AMBARI-20123 Repository: ambari Description --- Following items should be fixed: * After the user clicks on "Next", need to disable the button right away and show the spin animation in the button like we already do for Install Wizard * While a step is still loading, do not allow the user to click Next (the button should be disabled until the step has completed loading) * Download CSV request can take some time, need to show spin animation and prevent additional clicks during data loading Diffs - ambari-web/app/controllers/main/admin/kerberos/step1_controller.js c0decfc ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 992fd34 ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8e5abd5 ambari-web/app/controllers/main/admin/kerberos/step5_controller.js 9cb75e0 ambari-web/app/mixins/wizard/wizardProgressPageController.js d426eda ambari-web/app/routes/add_kerberos_routes.js fe21dae ambari-web/app/styles/common.less 94a5cd3 ambari-web/app/templates/common/button_progress.hbs PRE-CREATION ambari-web/app/templates/common/progress.hbs fce5641 ambari-web/app/templates/main/admin/kerberos/step1.hbs 19e5596 ambari-web/app/templates/main/admin/kerberos/step2.hbs c17347c ambari-web/app/templates/main/admin/kerberos/step3.hbs 6e2ea57 ambari-web/app/templates/main/admin/kerberos/step4.hbs 1e6f956 ambari-web/app/templates/main/admin/kerberos/step5.hbs c0cdc00 ambari-web/app/views.js 9addd91 ambari-web/app/views/common/buttons/button_progress_view.js PRE-CREATION ambari-web/app/views/common/buttons/wizard_buttons.js PRE-CREATION ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 3181fda ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js 2e603da Diff: https://reviews.apache.org/r/56957/diff/ Testing --- 20375 passing (25s) 153 pending Thanks, Denys Buzhor
Review Request 56772: Storm config change results in Consistency check failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56772/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-20059 https://issues.apache.org/jira/browse/AMBARI-20059 Repository: ambari Description --- steps to reproduce: # install cluster with Storm and Ranger # go to Services -> Storm -> Configs # change any config # save configs observes configuration validation failure due to absent Yarn configs. Diffs - ambari-web/app/controllers/main/service/info/configs.js d95a2d281f ambari-web/app/mixins/common/track_request_mixin.js 4efcecb59d ambari-web/test/controllers/main/service/info/config_test.js 4cc2ef898a Diff: https://reviews.apache.org/r/56772/diff/ Testing --- 20344 passing (24s) 153 pending Thanks, Denys Buzhor
Re: Review Request 56750: Don't rerender all widgets when on of them is changed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56750/#review165841 --- Ship it! Ship It! - Denys Buzhor On Feb. 16, 2017, 1:29 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56750/ > --- > > (Updated Feb. 16, 2017, 1:29 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20043 > https://issues.apache.org/jira/browse/ambari-20043 > > > Repository: ambari > > > Description > --- > > Dashboard widgets are rerendered if some of them is changed. Actually only > this one should be updated and not other > > > Diffs > - > > ambari-web/app/assets/test/tests.js d47d558 > ambari-web/app/data/dashboard_widgets.js PRE-CREATION > ambari-web/app/messages.js 81833f3 > ambari-web/app/mixins/common/track_request_mixin.js 4efcecb > ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb > ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26 > ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js > 06bcffe > ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085 > > ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs > 86ffb47 > ambari-web/app/views.js 77b5d5a > ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js > PRE-CREATION > ambari-web/app/views/main/dashboard/widget.js e7a626c > ambari-web/app/views/main/dashboard/widgets.js 572625d > ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c > > ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js > PRE-CREATION > ambari-web/test/views/main/dashboard/widget_test.js a504c6d > ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2 > > Diff: https://reviews.apache.org/r/56750/diff/ > > > Testing > --- > > 20372 passing (22s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 56715: Operations do not show up in the operations list without a refresh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56715/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-20028 https://issues.apache.org/jira/browse/AMBARI-20028 Repository: ambari Description --- Restart attempted from the host page. Ambari asks for a confirmation, shows the operations screen, but doesn't take any action. Diffs - ambari-web/app/controllers/main/service/info/configs.js c49bfaef86 ambari-web/app/mixins/common/track_request_mixin.js 07eaf6e289 ambari-web/app/routes/main.js 9ed2dd10c4 Diff: https://reviews.apache.org/r/56715/diff/ Testing --- 20340 passing (25s) 153 pending Thanks, Denys Buzhor
Re: Review Request 56664: JS error in the "Supervisors Live" widget
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56664/#review165510 --- Ship it! Ship It! - Denys Buzhor On Feb. 14, 2017, 2:43 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56664/ > --- > > (Updated Feb. 14, 2017, 2:43 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-20011 > https://issues.apache.org/jira/browse/AMBARI-20011 > > > Repository: ambari > > > Description > --- > > Widget can't be edited because of JS-error > > > Diffs > - > > ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca > > Diff: https://reviews.apache.org/r/56664/diff/ > > > Testing > --- > > 20345 passing (24s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 56653: UI on Admin page-> Auto Start tab is not consistent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56653/#review165489 --- Ship it! Ship It! - Denys Buzhor On Feb. 14, 2017, 11:13 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56653/ > --- > > (Updated Feb. 14, 2017, 11:13 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-20002 > https://issues.apache.org/jira/browse/ambari-20002 > > > Repository: ambari > > > Description > --- > > UI on Admin page, Auto Start tab is not consistent. Observing that the Auto > Start button on Admin tab is sometimes a checkbox and sometimes a Toggle > Button. > STR: > -> Upgrade ambari from 2.2.2.0 to 2.5.0 > -> On Firefox Version 45, go to admin page -> Auto Start Tab > It was manually reproduced on Firefox Version 44 > > > Diffs > - > > ambari-web/app/views/main/admin/service_auto_start.js 6f7d644 > ambari-web/test/controllers/main/service/info/config_test.js 8ca48b1 > > Diff: https://reviews.apache.org/r/56653/diff/ > > > Testing > --- > > 20345 passing (21s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 56550: Set recommended tooltip appears in front of icon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56550/#review165138 --- Ship it! Ship It! - Denys Buzhor On Feb. 10, 2017, 4:52 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56550/ > --- > > (Updated Feb. 10, 2017, 4:52 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19964 > https://issues.apache.org/jira/browse/AMBARI-19964 > > > Repository: ambari > > > Description > --- > > Go to installer step7 wizard and try to click on set recommended icon for > DataNode maximum Java heap size > > > Diffs > - > > ambari-web/app/app.js 53394a0 > ambari-web/app/templates/common/configs/widgets/controls.hbs 52cccd4 > ambari-web/app/utils/bootstrap_reopen.js PRE-CREATION > ambari-web/app/views/common/configs/service_configs_by_category_view.js > f4f35c8 > ambari-web/app/views/common/configs/widgets/config_widget_view.js e93baa2 > > Diff: https://reviews.apache.org/r/56550/diff/ > > > Testing > --- > > Results of running unit tests: > 30319 passing (26s) > 157 pending > > > Thanks, > > Aleksandr Kovalenko > >
Review Request 56495: Service Config pages load very slowly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56495/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-19939 https://issues.apache.org/jira/browse/AMBARI-19939 Repository: ambari Description --- Reduce configurations loading time by disabling background polling while configurations loading in progress and enable when finished. Diffs - ambari-web/app/controllers/main/service/info/configs.js 319610c9aa ambari-web/app/mixins/common/configs/configs_loader.js 666cef8733 ambari-web/app/mixins/common/track_request_mixin.js 6fcc991ab5 ambari-web/app/routes/main.js 354198bb7d ambari-web/test/controllers/main/host/configs_service_test.js deb01ae42d ambari-web/test/controllers/main/host/details_test.js 7f3fcf74a6 ambari-web/test/controllers/main/service/info/config_test.js ce98c0ce7a ambari-web/test/mixins/common/configs/configs_loader_test.js 8f22b444f4 Diff: https://reviews.apache.org/r/56495/diff/ Testing --- 20342 passing (23s) 153 pending Thanks, Denys Buzhor
Re: Review Request 56485: Confusing Auto Start settings page behavior when loading and API takes a while
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56485/#review164890 --- Ship it! Ship It! - Denys Buzhor On Feb. 9, 2017, 10:09 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56485/ > --- > > (Updated Feb. 9, 2017, 10:09 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19934 > https://issues.apache.org/jira/browse/ambari-19934 > > > Repository: ambari > > > Description > --- > > When the Admin > Auto Start settings page gets loaded and the API is taking a > while, the behavior is really confusing. > It initially shows a checkbox that the user can click on. Upon clicking on > it, it shows various Auto Start configs. But when the page fully loads, this > whole section disappears, etc. > This is consistent with other pages that we have that depend on API results. > For example, Admin > Kerberos page does not show any status/button but shows > a spinner while the API call is in flight (other pages that follow this > pattern are Admin > Stacks and Versions > Versions | Upgrade History, etc). > > Since this is a new feature we are shipping, this page will receive some > attention and the current behavior looks unpolished and confusing - does not > inspire confidence. > > > Diffs > - > > ambari-web/app/templates/main/admin/service_auto_start.hbs 87fc915 > ambari-web/app/views/main/admin/service_auto_start.js be928ed > > Diff: https://reviews.apache.org/r/56485/diff/ > > > Testing > --- > > 30312 passing (22s) > 157 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 56393: Unable to add ZooKeeper Server to host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56393/#review164523 --- Ship it! Ship It! - Denys Buzhor On Feb. 7, 2017, 4:02 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56393/ > --- > > (Updated Feb. 7, 2017, 4:02 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19896 > https://issues.apache.org/jira/browse/AMBARI-19896 > > > Repository: ambari > > > Description > --- > > It's not possible to add ZooKeeper Server to host if none of the following > services is installed: Hive, YARN, HBase, Accumulo, Kafka, Atlas, Storm. > Infinite spinner is displayed inside the confirmation popup, submit button is > disabled. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 093603e > ambari-web/test/controllers/main/host/details_test.js 4eccf95 > > Diff: https://reviews.apache.org/r/56393/diff/ > > > Testing > --- > > 30327 passing (18s) > 157 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 56381: A lot of warning messages after opening "Upgrade to ..."-popup
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56381/#review164498
---
Ship it!
Ship It!
- Denys Buzhor
On Feb. 7, 2017, 11:16 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56381/
> ---
>
> (Updated Feb. 7, 2017, 11:16 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: AMBARI-19888
> https://issues.apache.org/jira/browse/AMBARI-19888
>
>
> Repository: ambari
>
>
> Description
> ---
>
> * Install ambari
> * Register new version
> * Install it (install should fail)
> * Go to {{#/main/admin/stack/versions}}
> * Click "Upgrade" for this version
> * Popup with checks appears
> * Click on link to see what checks failed
>
> *AR* A lot of warning about undefined variables appear:
> {noformat}
> WARNING: Watching an undefined global, Ember expects watched globals to be
> setup by the time the run loop is flushed, check for typos
> {noformat}
>
>
> Diffs
> -
>
> ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs
> 88d8eaf
> ambari-web/app/views/common/modal_popups/cluster_check_popup.js a2f6f83
> ambari-web/test/models/service_test.js 5bd0cf8
> ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js
> 71e602a
>
> Diff: https://reviews.apache.org/r/56381/diff/
>
>
> Testing
> ---
>
> 20326 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 56325: Confirmation for deleting services show serviceName and not displayName
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56325/#review164344 --- Ship it! Ship It! - Denys Buzhor On Feb. 6, 2017, 12:16 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56325/ > --- > > (Updated Feb. 6, 2017, 12:16 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19877 > https://issues.apache.org/jira/browse/ambari-19877 > > > Repository: ambari > > > Description > --- > > Example: > > Shown: "Service LOGSEARCH was successfully deleted" > Should be: "Service Log Search was successfully deleted" > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 9758ac3 > ambari-web/test/controllers/main/service/item_test.js b582e86 > > Diff: https://reviews.apache.org/r/56325/diff/ > > > Testing > --- > > 20327 passing (21s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 56321: Popup with alerts on the Service summary doesn't have arrows for alerts with state "None"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56321/#review164328 --- Ship it! Ship It! - Denys Buzhor On Feb. 6, 2017, 9:34 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56321/ > --- > > (Updated Feb. 6, 2017, 9:34 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19876 > https://issues.apache.org/jira/browse/ambari-19876 > > > Repository: ambari > > > Description > --- > > See screenshot attached to issue > > > Diffs > - > > ambari-web/app/controllers/main/service/info/summary.js 9bdf83a > > Diff: https://reviews.apache.org/r/56321/diff/ > > > Testing > --- > > 20325 passing (22s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 56273: JS error on host configs page
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56273/#review164106
---
Ship it!
Ship It!
- Denys Buzhor
On Feb. 3, 2017, 8:49 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56273/
> ---
>
> (Updated Feb. 3, 2017, 8:49 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-19862
> https://issues.apache.org/jira/browse/ambari-19862
>
>
> Repository: ambari
>
>
> Description
> ---
>
> {{app.js:193861 Uncaught TypeError: Cannot read property 'someProperty' of
> undefined}}
>
> on the
>
> {{return (isCustomPropertiesCategory && this.get('controller.filter') === ''
> && !this.get('mainView.columns').someProperty('selected')) ||}}
>
>
> Diffs
> -
>
> ambari-web/app/views/common/configs/service_configs_by_category_view.js
> d9b4409
>
> Diff: https://reviews.apache.org/r/56273/diff/
>
>
> Testing
> ---
>
> 30313 passing (23s)
> 157 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 56160: 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56160/#review163801 --- Ship it! Ship It! - Denys Buzhor On Feb. 1, 2017, 9:46 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56160/ > --- > > (Updated Feb. 1, 2017, 9:46 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19814 > https://issues.apache.org/jira/browse/ambari-19814 > > > Repository: ambari > > > Description > --- > > - 'num_llap_nodes' as of now is shown as a slider and comes only when we have > selected 'llap' named queue and is a child of root level. It is shown because > 'num_llap_nodes' visible attribute is set as True by SA. > - For any other queue, 'num_llap_nodes' is set as visible=false by SA call > and is not shown on UI. > > *Expected:* > A way to show 'num_llap_nodes' node on UI for user, irrespective of the queue > selected. > > > Diffs > - > > ambari-web/app/mixins.js ad682d7 > ambari-web/app/mixins/common/configs/widgets/unique/num_llap_nodes.js > PRE-CREATION > ambari-web/app/templates/common/configs/widgets/controls.hbs af5a56a > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 30ffadf > > Diff: https://reviews.apache.org/r/56160/diff/ > > > Testing > --- > > 30311 passing (22s) > 157 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 55979: Wizard modals are closed before confirmation popup appears
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55979/#review163108 --- Ship it! Ship It! - Denys Buzhor On Jan. 26, 2017, 9:07 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55979/ > --- > > (Updated Jan. 26, 2017, 9:07 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19722 > https://issues.apache.org/jira/browse/ambari-19722 > > > Repository: ambari > > > Description > --- > > * Open Kerberos Wizard > * Proceed to step2 > * Press "Esc" > * Wizard modal is closed > * Confirmation popup appears > > *ER* Confirmation popup should appears before closing wizard modal > > This happens because Bootstrap Modal has its own Esc-press handler. It should > be disabled > > > Diffs > - > > ambari-web/app/views/common/modal_popup.js 47b7d61 > > Diff: https://reviews.apache.org/r/55979/diff/ > > > Testing > --- > > 20476 tests complete (32 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 55877: Validation errors are not shown if properties do not exist
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55877/#review162799 --- Ship it! Ship It! - Denys Buzhor On Jan. 24, 2017, 12:40 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55877/ > --- > > (Updated Jan. 24, 2017, 12:40 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19691 > https://issues.apache.org/jira/browse/AMBARI-19691 > > > Repository: ambari > > > Description > --- > > Say property A, when set to a specific value, needs property B and C. But > property B and C do not exist in the config bag. This could be due to them > being optional and hence deleted or its after Ambari upgrade and the optional > properties B and C are not added. > > Now if stack advisor throws validation warnings that B and C must exist and > have a valid values those warnings are not shown in the UI. > > Fixing this behavior is also critical as we are trying not to add optional > properties when Ambari is upgraded to avoid service restarts. > > > Diffs > - > > ambari-web/app/mixins/common/serverValidator.js 9fb5ae3 > ambari-web/test/mixins/common/serverValidator_test.js 943eb57 > > Diff: https://reviews.apache.org/r/55877/diff/ > > > Testing > --- > > 30309 passing (22s) > 157 pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 55728: accordion classname missed on configs page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55728/#review162343 --- Ship it! Ship It! - Denys Buzhor On Jan. 19, 2017, 8:21 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55728/ > --- > > (Updated Jan. 19, 2017, 8:21 p.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19633 > https://issues.apache.org/jira/browse/AMBARI-19633 > > > Repository: ambari > > > Description > --- > > accordion classname missed on configs page > > > Diffs > - > > ambari-web/app/views/common/configs/config_category_container_view.js > 73ded75 > > Diff: https://reviews.apache.org/r/55728/diff/ > > > Testing > --- > > 20307 passing (28s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 55560: Timezone for timestamps in Upgrade History not consistent with Background Operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55560/#review161698 --- Ship it! Ship It! - Denys Buzhor On Jan. 16, 2017, 9:23 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55560/ > --- > > (Updated Jan. 16, 2017, 9:23 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: ambari-19560 > https://issues.apache.org/jira/browse/ambari-19560 > > > Repository: ambari > > > Description > --- > > Looks like the timestamp in Upgrade History are shown as per current > machine's timezone; while the timestamp entries in Background Operations > Window is in GMT > > This causes confusion while trying to correlate events that happen after > upgrade, as my machine's timezone is GMT+5.30, so the post upgrade events > appear to show up few hours before the upgrade time reported in 'Upgrade > History' > > > Diffs > - > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js > 8df8349 > > Diff: https://reviews.apache.org/r/55560/diff/ > > > Testing > --- > > 20389 tests complete (31 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 55484: Two SelectBoxes don't have class `form-control`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55484/#review161492
---
Ship it!
Ship It!
- Denys Buzhor
On Jan. 13, 2017, 9:15 a.m., Oleg Nechiporenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55484/
> ---
>
> (Updated Jan. 13, 2017, 9:15 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-19517
> https://issues.apache.org/jira/browse/ambari-19517
>
>
> Repository: ambari
>
>
> Description
> ---
>
> {{ambari-web/app/templates/main/service/add_host_popup.hbs}}
> {{ambari-web/app/templates/common/modal_popups/select_groups_popup.hbs}}
>
>
> Diffs
> -
>
> ambari-web/app/templates/common/modal_popups/select_groups_popup.hbs
> c7da8a4
> ambari-web/app/templates/main/service/add_host_popup.hbs 7431080
>
> Diff: https://reviews.apache.org/r/55484/diff/
>
>
> Testing
> ---
>
> 20389 tests complete (32 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 55415: Screen stuck when no suitable OS is detected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55415/#review161210 --- Ship it! Ship It! - Denys Buzhor On Jan. 11, 2017, 11:07 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55415/ > --- > > (Updated Jan. 11, 2017, 11:07 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19460 > https://issues.apache.org/jira/browse/AMBARI-19460 > > > Repository: ambari > > > Description > --- > > When the only machine in the cluster is running Ubuntu 16, deployment fails > at last step before start > > Expected behavior: > Click on the warning will go back to the review page > Actual behavior: > User is stuck at "task completed" screen, even though the deployment failed > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 6475d49 > ambari-web/app/mixins/wizard/wizardDeployProgressController.js 4a5cb84 > ambari-web/test/controllers/wizard/step8_test.js 5efb866 > > Diff: https://reviews.apache.org/r/55415/diff/ > > > Testing > --- > > 20389 tests complete (36 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 55052: Dependent configurations are not loaded if value is set via "Set recommended" button
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55052/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19303 https://issues.apache.org/jira/browse/AMBARI-19303 Repository: ambari Description --- STR : 1) Install cluster with AMS 2) Switch AMS to work in distributed mode (change timeline.metrics.service.operation.mode to distributed in AMS configs) 3) Save changed with all recommended dependent configs 4) Click "Set Recommended" for timeline.metrics.service.operation.mode (value should change to embedded) 5) Save configuration Result : error messages because dependent configs were not updated Stack Advisor wasn't called after pressing "Set Recommended" and value for timeline.metrics.service.operation.mode property was taken from default stack configurations with request which was called during page load ``` http://server-ip:8080/api/v1/stacks/HDP/versions/2.6/services?StackServices/service_name.in(HDFS,ZOOKEEPER,AMBARI_METRICS,SMARTSENSE,KERBEROS)=configurations/*,configurations/dependencies/*,StackServices/config_types/*&_=1482851694173 ``` Diffs - ambari-web/app/views/common/controls_view.js bcb90d89ad Diff: https://reviews.apache.org/r/55052/diff/ Testing --- 19829 passing (20s) 153 pending Thanks, Denys Buzhor
Review Request 54738: Kerberos advanced tab. Page wasn't refreshed after save changes. Save button is disabled.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54738/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19197 https://issues.apache.org/jira/browse/AMBARI-19197 Repository: ambari Description --- STR: - change properties on kerb advanced tab - save and regenerate keytab - wait for complete - change properties on kerb advanced tab Result: Save button is disabled. Diffs - ambari-web/app/templates/main/admin/kerberos.hbs 0e6facf9a6 Diff: https://reviews.apache.org/r/54738/diff/ Testing --- 19879 tests complete (32 seconds) 153 tests pending Thanks, Denys Buzhor
Review Request 54202: Add Host Wizard: validation failed on Assign Slaves step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54202/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19026 https://issues.apache.org/jira/browse/AMBARI-19026 Repository: ambari Description --- STR: * Install cluster with ZooKeeper * Run Add Host Wizard * Proceed to Assign Slaves and Clients step AR: First validation call returns error regarding missed components. ER: No validation errors appears on initial stage. Diffs - ambari-web/app/controllers/wizard/step6_controller.js dfd0687 ambari-web/test/controllers/wizard/step6_test.js b2bc879 Diff: https://reviews.apache.org/r/54202/diff/ Testing --- 20020 tests complete (26 seconds) 155 tests pending Thanks, Denys Buzhor
Review Request 54127: Create smart config tab for Hive and Oozie Database settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54127/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-18998 https://issues.apache.org/jira/browse/AMBARI-18998 Repository: ambari Description --- Create smart config tab for Hive and Oozie Database settings Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml de088dc ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml 804c662 ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/themes/theme.json 42bc889 ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml f62ac13 ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/configuration/oozie-env.xml 6c292aa ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml dcac2eb ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/themes/theme.json PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml f0a7754 ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/themes/theme.json PRE-CREATION ambari-web/app/app.js 051daff ambari-web/app/data/configs/services/hive_properties.js 47ba788 ambari-web/app/data/configs/services/oozie_properties.js 0f71688 Diff: https://reviews.apache.org/r/54127/diff/ Testing --- 19935 tests complete (26 seconds) 154 tests pending Thanks, Denys Buzhor
Review Request 53981: Stack property definitions made in ambari-web should be made stack agnostic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53981/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-18826 https://issues.apache.org/jira/browse/AMBARI-18826 Repository: ambari Description --- Stack property definitions made in ambari-web should be made stack agnostic Diffs - ambari-web/app/assets/test/tests.js 6a71db6 ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step2_controller.js ff338de ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller.js 3378cd5 ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js 9804428 ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 1e80e72 ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 08e0b73 ambari-web/app/controllers/main/host/details.js ec9a73f ambari-web/app/controllers/wizard/step7_controller.js 3d22fe9 ambari-web/app/controllers/wizard/step8_controller.js 24d8ec7 ambari-web/app/data/HDP2.2/hive_properties.js 1cdd5a2 ambari-web/app/data/HDP2.2/site_properties.js 03e0615 ambari-web/app/data/HDP2.2/tez_properties.js 46f18ba ambari-web/app/data/HDP2.2/yarn_properties.js 6233401 ambari-web/app/data/HDP2.3/hawq_activate_standby_properties.js ambari-web/app/data/HDP2.3/hawq_ha_properties.js ambari-web/app/data/HDP2.3/site_properties.js 2dadd1b ambari-web/app/data/HDP2/alert_notification.js ambari-web/app/data/HDP2/gluster_fs_properties.js 5cec5f1 ambari-web/app/data/HDP2/ha_properties.js ambari-web/app/data/HDP2/kerberos_descriptor_properties.js ambari-web/app/data/HDP2/kerberos_identities.js ambari-web/app/data/HDP2/move_journal_node_properties.js ambari-web/app/data/HDP2/rm_ha_properties.js ambari-web/app/data/HDP2/secure_mapping.js ambari-web/app/data/HDP2/site_properties.js d61d4aa ambari-web/app/data/HDP2/ui_properties.js ambari-web/app/data/configs/services/accumulo_properties.js PRE-CREATION ambari-web/app/data/configs/services/ambari_infra_properties.js PRE-CREATION ambari-web/app/data/configs/services/ambari_metrics_properties.js PRE-CREATION ambari-web/app/data/configs/services/falcon_properties.js PRE-CREATION ambari-web/app/data/configs/services/hawq_properties.js PRE-CREATION ambari-web/app/data/configs/services/hbase_properties.js PRE-CREATION ambari-web/app/data/configs/services/hdfs_properties.js PRE-CREATION ambari-web/app/data/configs/services/hive_properties.js PRE-CREATION ambari-web/app/data/configs/services/kafka_properties.js PRE-CREATION ambari-web/app/data/configs/services/kerberos_properties.js PRE-CREATION ambari-web/app/data/configs/services/knox_properties.js PRE-CREATION ambari-web/app/data/configs/services/logsearch_properties.js PRE-CREATION ambari-web/app/data/configs/services/mapreduce2_properties.js PRE-CREATION ambari-web/app/data/configs/services/oozie_properties.js PRE-CREATION ambari-web/app/data/configs/services/ranger_properties.js PRE-CREATION ambari-web/app/data/configs/services/storm_properties.js PRE-CREATION ambari-web/app/data/configs/services/tez_properties.js PRE-CREATION ambari-web/app/data/configs/services/yarn_properties.js PRE-CREATION ambari-web/app/data/configs/services/zookeeper_properties.js PRE-CREATION ambari-web/app/data/configs/site_properties.js PRE-CREATION ambari-web/app/data/custom_stack_map.js e52c570 ambari-web/app/mappers/configs/stack_config_properties_mapper.js 2c8959d ambari-web/app/mixins/wizard/addSecurityConfigs.js 7e495ea ambari-web/app/models/stack_service.js 0136ec3 ambari-web/app/utils/config.js 665497b ambari-web/app/views/common/controls_view.js 1fd5fde ambari-web/app/views/main/dashboard/widgets/hbase_links.js 235f73c ambari-web/app/views/main/service/reassign/step5_view.js c5fc3c8 ambari-web/copy-pluggable-stack-resources.sh 4dc9205 ambari-web/test/controllers/main/host/details_test.js 154d0b2 ambari-web/test/data/HDP2.2/site_properties_test.js 14599b3 ambari-web/test/data/HDP2.3/site_properties_test.js 6ce9c17 ambari-web/test/data/HDP2/secure_mapping_test.js 766243f ambari-web/test/data/HDP2/site_properties_test.js c8b7bbc ambari-web/test/utils/config_test.js 5012caa Diff: https://reviews.apache.org/r/53981/diff/ Testing --- 19824 tests complete (27 seconds) 154 tests pending Thanks, Denys Buzhor
