Review Request 61232: AMBARI-21609 - Unable to view HDP or HDF stack version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61232/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-21609 https://issues.apache.org/jira/browse/AMBARI-21609 Repository: ambari Description --- Fix NPE at UI installation flow with RedHat Satellite selected Diffs - ambari-web/app/mappers/repository_version_mapper.js 8ef50db ambari-web/app/mappers/stack_mapper.js 4b6a6f8 Diff: https://reviews.apache.org/r/61232/diff/1/ Testing --- Manually tested on live cluster. All unit tests passed. 30397 passing (22s) 157 pending Thanks, Richard Zang
Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60516/ --- Review request for Ambari, Andrii Babiichuk, Aleksandr Kovalenko, Denys Buzhor, Jaimin Jetly, and Yusaku Sako. Bugs: AMBARI-21371 https://issues.apache.org/jira/browse/AMBARI-21371 Repository: ambari Description --- propertyDependsOn is only available for stack level configuration. Add a null check. Diffs - ambari-web/app/mixins/common/configs/enhanced_configs.js 4561f77 Diff: https://reviews.apache.org/r/60516/diff/1/ Testing --- Manually tested on live cluster. All unit tests passed. 21208 passing (22s) 128 pending Thanks, Richard Zang
Re: Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59928/#review177408 --- Ship it! Ship It! - Richard Zang On June 8, 2017, 10:06 p.m., Duc Le wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59928/ > --- > > (Updated June 8, 2017, 10:06 p.m.) > > > Review request for Ambari, Richard Zang and Yusaku Sako. > > > Bugs: AMBARI-21205 > https://issues.apache.org/jira/browse/AMBARI-21205 > > > Repository: ambari > > > Description > --- > > AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features > > > Diffs > - > > ambari-web/app/config.js 451416d > ambari-web/app/routes/add_service_routes.js 13a1345 > ambari-web/app/routes/main.js 02b561d > ambari-web/app/templates/main/admin/kerberos.hbs 4f35fd5 > ambari-web/app/templates/main/service/all_services_actions.hbs 0ca1cd5 > ambari-web/app/views/main/admin.js 509f380 > ambari-web/app/views/main/admin/stack_upgrade/services_view.js f566814 > ambari-web/app/views/main/menu.js 00b1c38 > ambari-web/app/views/main/service/item.js 09457f2 > ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js > 70d182c > > > Diff: https://reviews.apache.org/r/59928/diff/3/ > > > Testing > --- > > Manual build and E2E testing > > > Thanks, > > Duc Le > >
Re: Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59928/#review177376 --- ambari-web/app/views/main/admin/stack_upgrade/services_view.js Line 59 (original), 59 (patched) <https://reviews.apache.org/r/59928/#comment250922> This change is causing FE unit test failure, could you please fix the UT accordingly? To run FE unit test, go to /ambari-web and run "npm test" 30379 passing (23s) 157 pending 2 failing 1) Ambari Web Unit tests test/views/main/admin/stack_upgrade/services_view_test App.MainAdminStackServicesView #goToAddService() routes to Add Service Wizard and set redirect path on wizard close: expected false to be true 2) Ambari Web Unit tests test/views/main/admin/stack_upgrade/services_view_test App.MainAdminStackServicesView #goToAddService() routes to Security Wizard: expected false to be true - Richard Zang On June 8, 2017, 7:31 p.m., Duc Le wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59928/ > --- > > (Updated June 8, 2017, 7:31 p.m.) > > > Review request for Ambari, Richard Zang and Yusaku Sako. > > > Bugs: AMBARI-21205 > https://issues.apache.org/jira/browse/AMBARI-21205 > > > Repository: ambari > > > Description > --- > > AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features > > > Diffs > - > > ambari-web/app/config.js 451416d > ambari-web/app/routes/add_service_routes.js 13a1345 > ambari-web/app/routes/main.js 02b561d > ambari-web/app/templates/main/admin/kerberos.hbs 4f35fd5 > ambari-web/app/templates/main/service/all_services_actions.hbs 0ca1cd5 > ambari-web/app/views/main/admin.js 509f380 > ambari-web/app/views/main/admin/stack_upgrade/services_view.js f566814 > ambari-web/app/views/main/menu.js 00b1c38 > ambari-web/app/views/main/service/item.js 09457f2 > > > Diff: https://reviews.apache.org/r/59928/diff/2/ > > > Testing > --- > > Manual build and E2E testing > > > Thanks, > > Duc Le > >
Re: Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59870/#review177262 --- Ship it! Ship It! - Richard Zang On June 7, 2017, 4:34 a.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59870/ > --- > > (Updated June 7, 2017, 4:34 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-21123 > https://issues.apache.org/jira/browse/AMBARI-21123 > > > Repository: ambari > > > Description > --- > > Web Codes Part > This patch amis to support creating alert target that inclueds property > ambari.dispatch-property.script.filename on web UI > > More details, please see https://issues.apache.org/jira/browse/AMBARI-20739 > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > df15513 > ambari-web/app/messages.js 02a54f7 > ambari-web/app/templates/main/alerts/create_alert_notification.hbs 7ec5b1e > ambari-web/app/utils/validator.js c069724 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > 0d58afa > > > Diff: https://reviews.apache.org/r/59870/diff/1/ > > > Testing > --- > > 1.cd ambari-web & mvn test > 21211 passing (33s) > 128 pending > > 2.Tested in a cluster > > > File Attachments > > > script_alert_notification_1.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/c77c5e4c-4d64-400a-8df9-11df1369e7fd__script_alert_notification_1.png > script_alert_notification_2.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/1c230f27-4158-4ef4-90a8-483b3cfd4d52__script_alert_notification_2.png > > > Thanks, > > yao lei > >
Re: Review Request 59485: Edit notifications options are always grey but can click and open a popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59485/#review176949 --- Ship it! Ship It! - Richard Zang On June 5, 2017, 10:28 a.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59485/ > --- > > (Updated June 5, 2017, 10:28 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-21097 > https://issues.apache.org/jira/browse/AMBARI-21097 > > > Repository: ambari > > > Description > --- > > Two Problems > > Steps to reproduce problem one (see notifiction.png): > 1.Open Alerts / Actions / Manage Alert Notifications > 2.Create an alert notification named test > 3.Select the created notification and click gear icon, you will find > Edit/Duplicate items are always grey but you can click and open a popup. > > Steps to reproduce problem two(see notification-2.png): > 1.Open Alerts / Actions / Manage Alert Notifications and delete all > notifications if exit > 2.Firstly click the gear icon and then click Edit(Duplicate) item, some > errors will ouput in browser console. > > > Diffs > - > > ambari-web/app/mappers/alert_notification_mapper.js 037c418 > ambari-web/app/models/alerts/alert_notification.js c2d7570 > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > da8faa8 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86 > > > Diff: https://reviews.apache.org/r/59485/diff/2/ > > > Testing > --- > > 1.cd ambari-web & mvn test > 30383 passing (34s) > 157 pending > > 2.Tested in a cluster > > > File Attachments > > > notification-2.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png > notification.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png > > > Thanks, > > yao lei > >
Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---
(Updated May 23, 2017, 1:49 a.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Changes
---
update {{{}}} wrap to show links correctly
Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082
Repository: ambari
Description
---
Fix step indicator
Fix service selection click
Diffs (updated)
-
ambari-web/app/styles/application.less 2fc1cf2
ambari-web/app/templates/wizard/step4.hbs 9f1d7df
ambari-web/app/views/wizard/step4_view.js 137b9f5
Diff: https://reviews.apache.org/r/59427/diff/3/
Changes: https://reviews.apache.org/r/59427/diff/2-3/
Testing
---
Manually tested on live cluster, all unit tests passed.
20699 passing (22s)
128 pending
Thanks,
Richard Zang
Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59427/ --- (Updated May 22, 2017, 8:46 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- Pixel adjustment Bugs: AMBARI-21082 https://issues.apache.org/jira/browse/AMBARI-21082 Repository: ambari Description --- Fix step indicator Fix service selection click Diffs (updated) - ambari-web/app/styles/application.less 2fc1cf2 ambari-web/app/templates/wizard/step4.hbs 9f1d7df ambari-web/app/views/wizard/step4_view.js 137b9f5 Diff: https://reviews.apache.org/r/59427/diff/2/ Changes: https://reviews.apache.org/r/59427/diff/1-2/ Testing --- Manually tested on live cluster, all unit tests passed. 20699 passing (22s) 128 pending Thanks, Richard Zang
Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59427/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-21082 https://issues.apache.org/jira/browse/AMBARI-21082 Repository: ambari Description --- Fix step indicator Fix service selection click Diffs - ambari-web/app/styles/application.less 2fc1cf2 ambari-web/app/templates/wizard/step4.hbs 9f1d7df ambari-web/app/views/wizard/step4_view.js 137b9f5 Diff: https://reviews.apache.org/r/59427/diff/1/ Testing --- Manually tested on live cluster, all unit tests passed. 20699 passing (22s) 128 pending Thanks, Richard Zang
Re: Review Request 58978: Ranger Quick links not showing load balancer in Ranger-admin HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58978/#review173852 --- Ship it! Ship It! - Richard Zang On May 3, 2017, 11:24 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58978/ > --- > > (Updated May 3, 2017, 11:24 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20926 > https://issues.apache.org/jira/browse/AMBARI-20926 > > > Repository: ambari > > > Description > --- > > Ranger Quick links not pointing to load balancer URL when ranger HA is > enabled. Quick links pointing to http://:6080 port. > > Ambari affected: 2.4.2 and 2.5.0.3 > > Prior to ambari upgrade in 2.2.2, quicklink was showing only the Ranger > loadbalancer UI. After upgrading to 2.4.2, it showing both ranger admin URLs > instead of the load balancer URL in quicklinks. > > > Diffs > - > > ambari-web/app/views/common/quick_view_link_view.js 86a7cb9b5e > ambari-web/test/views/common/quick_link_view_test.js 71790782d1 > > > Diff: https://reviews.apache.org/r/58978/diff/1/ > > > Testing > --- > > 30380 passing (34s) > 157 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 58861: AMBARI-20896 - Provide ability to visualize per cluster data from Grafana dashboards
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58861/ --- (Updated April 28, 2017, 11:22 p.m.) Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-20896 https://issues.apache.org/jira/browse/AMBARI-20896 Repository: ambari Description --- Provide ability to visualize per cluster data from Grafana dashboards Diffs - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 97de6e7 ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html 3f322c1 ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js a26e7d0 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json 6f53b84 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json c7a5777 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json ffcddea ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json 09929ec ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json ebf7a4c ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json 90fd37c ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json caaa86a ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json baca5bb ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-kafka-hosts.json 533a169 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json 2f69868 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json ab2434f ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json 9b79663 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json 35d2bd7 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json abbf221 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json b861862 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-database.json 229db83 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-topn.json 2c98e8d ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json c458931 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ams-hbase-misc.json 4820ae3 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ams-hbase-regionservers.json 4ec784e ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-servers.json 4776ff0 Diff: https://reviews.apache.org/r/58861/diff/1/ Testing (updated) --- Manually tested on live cluster, All unit tests passed. 20701 passing (23s) 128 pending Thanks, Richard Zang
Review Request 58861: AMBARI-20896 - Provide ability to visualize per cluster data from Grafana dashboards
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58861/ --- Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-20896 https://issues.apache.org/jira/browse/AMBARI-20896 Repository: ambari Description --- Provide ability to visualize per cluster data from Grafana dashboards Diffs - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 97de6e7 ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html 3f322c1 ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js a26e7d0 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-misc.json 6f53b84 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json c7a5777 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-datanodes.json ffcddea ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-home.json 09929ec ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-namenodes.json ebf7a4c ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json 90fd37c ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hivemetastore.json caaa86a ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hive-hiverserver2.json baca5bb ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-kafka-hosts.json 533a169 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-daemons.json 2f69868 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-llapdaemon-heatmaps.json ab2434f ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-cores-dashboard.json 9b79663 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-solr-hosts-dashboard.json 35d2bd7 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-nodemanagers.json abbf221 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-yarn-resourcemanagers.json b861862 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-database.json 229db83 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-topn.json 2c98e8d ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json c458931 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ams-hbase-misc.json 4820ae3 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ams-hbase-regionservers.json 4ec784e ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-system-servers.json 4776ff0 Diff: https://reviews.apache.org/r/58861/diff/1/ Testing --- Thanks, Richard Zang
Review Request 58637: AMBARI-20826 - HIVE "Quick Links" section showing Graphana related quicklinks when Graphana is not installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58637/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-20826 https://issues.apache.org/jira/browse/AMBARI-20826 Repository: ambari Description --- We cannot assume host for master component of current visiting service to be the default host for all quicklinks. Add component setting for SPARK2 quicklinks.json. Diffs - ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json ff285fc ambari-web/app/views/common/quick_view_link_view.js dfaf953 Diff: https://reviews.apache.org/r/58637/diff/1/ Testing --- Manually tested on liver cluster. All unit tests passed. 20700 passing (24s) 128 pending Thanks, Richard Zang
Review Request 58445: AMBARI-20738 - Cannot add repo for additional OS to an existing HDP version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58445/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-20738 https://issues.apache.org/jira/browse/AMBARI-20738 Repository: ambari Description --- Fix repo update logic. Remove redundant calls. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js c6ba241 Diff: https://reviews.apache.org/r/58445/diff/1/ Testing --- Manuall tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 81 of 81 SUCCESS (0.182 secs / 0.436 secs) Thanks, Richard Zang
Re: Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58256/#review171399
---
Ship it!
Ship It!
- Richard Zang
On April 7, 2017, 2:16 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58256/
> ---
>
> (Updated April 7, 2017, 2:16 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, Andrii
> Tkach, Di Li, Jaimin Jetly, Zhe (Joe) Wang, Matt, Nate Cole, Richard Zang,
> and Yusaku Sako.
>
>
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ambari now support creating/editing three kinds of alert dispatch targets by
> web wizard, including EMAIL,SNMP,Custom SNMP.
> If we want to create another kind of alert dispatch target ALERT_SCRIPT for
> script-based alert dispatcher,we have to execute a command manually like
> following:
> {code}
> POST api/v1/alert_targets
>
> {
> "AlertTarget": {
> "name": "syslogger",
> "description": "Syslog Target",
> "notification_type": "ALERT_SCRIPT",
> "global": true
> }
> }
> {code}
> or
> {code}
> POST api/v1/alert_targets
>
> {
> "AlertTarget": {
> "name": "syslogger",
> "description": "Syslog Target",
> "notification_type": "ALERT_SCRIPT",
> "global": false,
> "groups":[1,3]
> "alert_states":["WARNING","CRITICAL","UNKNOWN"],
> "properties": {
> "ambari.dispatch-property.script":
> "com.mycompany.dispatch.syslog.script"
> }
> }
> }
> {code}
> More details, please see
> https://cwiki.apache.org/confluence/display/AMBARI/Creating+a+Script-based+Alert+Dispatcher+-+2.4.0
> We should do this by web wizard rather than command line, which will lead to
> more convenience
> We think it is really helpeful for us when using script-based alert
> dispatcher.
>
>
> Diffs
> -
>
>
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
> 73c19c6
> ambari-web/app/messages.js a2edf06
> ambari-web/app/templates/main/alerts/create_alert_notification.hbs 5b40bca
>
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
> 31da561
>
>
> Diff: https://reviews.apache.org/r/58256/diff/1/
>
>
> Testing
> ---
>
> mvn test
> 20676 passing (34s)
> 128 pending
>
>
> Thanks,
>
> yao lei
>
>
Review Request 58260: AMBARI-20700 - UI should use the URL as-given by the backend
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58260/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-20700 https://issues.apache.org/jira/browse/AMBARI-20700 Repository: ambari Description --- Only overwrite urls if it is stack default, otherwise use url from /version_definition Remove old diagnosis log. Diffs - ambari-web/app/controllers/installer.js 369e163 Diff: https://reviews.apache.org/r/58260/diff/1/ Testing --- Manually tested on live cluster. All unit tests passed. 20675 passing (21s) 128 pending Thanks, Richard Zang
Re: Review Request 58257: Side Nav: improve views dropdown menu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58257/#review171312 --- Ship it! Ship It! - Richard Zang On April 7, 2017, 2:36 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58257/ > --- > > (Updated April 7, 2017, 2:36 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20699 > https://issues.apache.org/jira/browse/AMBARI-20699 > > > Repository: ambari > > > Description > --- > > Improve the current views menu on Side Nav. > > Now: views menu is in dark background, and not intuitive to open/click on. > > ToDo: Make it clickable and light background. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css b063fcfa34 > > > Diff: https://reviews.apache.org/r/58257/diff/1/ > > > Testing > --- > > 20606 passing (25s) > 128 pending > > > Thanks, > > Xi Wang > >
Review Request 58124: AMBARI-20651 - When in Upgrade paused state, links should be disabled for less privileged user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58124/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-20651 https://issues.apache.org/jira/browse/AMBARI-20651 Repository: ambari Description --- Show not allowed cursor for user without privilege to access upgrade wizard. Diffs - ambari-web/app/controllers/application.js df0a8e8 Diff: https://reviews.apache.org/r/58124/diff/1/ Testing --- Manually tested on live cluster. All unit tests passed. 20690 passing (22s) 128 pending Thanks, Richard Zang
Re: Review Request 58016: Auto-Start Services Switch button broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58016/#review170355 --- Ship it! Ship It! - Richard Zang On March 29, 2017, 1:34 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58016/ > --- > > (Updated March 29, 2017, 1:34 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20614 > https://issues.apache.org/jira/browse/AMBARI-20614 > > > Repository: ambari > > > Description > --- > > Auto-Start Services switch button should have two states only, now it is > broken. > > > Diffs > - > > ambari-web/app/styles/widgets.less af76e4f > > > Diff: https://reviews.apache.org/r/58016/diff/1/ > > > Testing > --- > > 20606 passing (25s) > 128 pending > > > Thanks, > > Xi Wang > >
Review Request 58007: AMBARI-20613 - Host Filtering interaction is confusing and cumbersome to perform simple filtering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58007/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-20613 https://issues.apache.org/jira/browse/AMBARI-20613 Repository: ambari Description --- Disable auto focus when autocomplete menu is displayed. Diffs - ambari-web/vendor/scripts/visualsearch.js ef07680 Diff: https://reviews.apache.org/r/58007/diff/1/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 57886: Warn users about pending requests while trying to enable Interactive Query immediately after disabling it
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57886/#review169917 --- Ship it! Ship It! - Richard Zang On March 23, 2017, 6:26 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57886/ > --- > > (Updated March 23, 2017, 6:26 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-20429 > https://issues.apache.org/jira/browse/AMBARI-20429 > > > Repository: ambari > > > Description > --- > > There is no warning shown to the user to avoid enabling of Interactive Query > immediately after disabling it. Allowing the users to enable Interactive > Query immediately after disabling it will result in an inconsistent state of > the system. Showing a popup to warn the user about a pending batch request > and stopping the enable command is required. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js 326f571 > ambari-web/app/messages.js bc40a26 > ambari-web/app/utils/ajax/ajax.js b856e44 > ambari-web/app/views/common/configs/widgets/config_widget_view.js cb5d5b9 > > > Diff: https://reviews.apache.org/r/57886/diff/1/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass. > 30369 passing (21s) > 157 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 57656: Side Nav: several issues and adjustments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57656/#review169213 --- Ship it! Ship It! - Richard Zang On March 15, 2017, 6:37 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57656/ > --- > > (Updated March 15, 2017, 6:37 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20464 > https://issues.apache.org/jira/browse/AMBARI-20464 > > > Repository: ambari > > > Description > --- > > 1. Scrolling on Side Nav menu can trigger scrolling on the main content. The > same issue for modals, wizards .etc. > 2. Service Actions icon "..." should occupy more space to click on. > Current behavior: need to click exactly on the icon to show actions dropdown. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css 98606e9 > ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1f61104 > > > Diff: https://reviews.apache.org/r/57656/diff/1/ > > > Testing > --- > > 20577 passing (28s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 57526: Side Nav: several issues tested on IE 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57526/#review168692 --- Ship it! Ship It! - Richard Zang On March 11, 2017, 12:48 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57526/ > --- > > (Updated March 11, 2017, 12:48 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-20405 > https://issues.apache.org/jira/browse/AMBARI-20405 > > > Repository: ambari > > > Description > --- > > CSS: > 1. Active item should have a green triangle at left. Now there was no active > effect for menu items except for Admin's submenu. > 2. Hovering on Services, service actions icon is invisible. Cannot trigger > any service actions. > 3. The scrollbar was too prominent, should hide scrollbar on every browser. > > JS: > 4. Click on Services/Admin menu, no collapse effect. And will go to > Service/Admin page. > 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi > menu. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 > ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f > > > Diff: https://reviews.apache.org/r/57526/diff/1/ > > > Testing > --- > > 20559 passing (27s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/ --- (Updated March 8, 2017, 12:39 a.m.) Review request for Ambari, Andrii Babiichuk, Jaimin Jetly, Oleg Nechiporenko, and Yusaku Sako. Changes --- Join if conditions Bugs: AMBARI-20287 https://issues.apache.org/jira/browse/AMBARI-20287 Repository: ambari Description --- Take subSectionTab into consideration on show/hide Diffs (updated) - ambari-web/app/models/configs/theme/sub_section.js 7274569 ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 ambari-web/app/views/common/configs/service_config_layout_tab_view.js 466a88d ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c Diff: https://reviews.apache.org/r/57268/diff/2/ Changes: https://reviews.apache.org/r/57268/diff/1-2/ Testing --- Manully tested on live cluster. All unit tests passed. 20560 passing (25s) 153 pending Thanks, Richard Zang
Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
> On March 4, 2017, 2:33 a.m., Jaimin Jetly wrote: > > ambari-web/app/models/configs/theme/sub_section_tab.js > > Line 84 (original), 84-87 (patched) > > <https://reviews.apache.org/r/57268/diff/1/?file=1655325#file1655325line84> > > > > Whats the reason behind making this computed property volatile ? Adding volatile here is because I keep getting inconsistent result on this computed property during manual test, so add volatile to make sure the value is consistent even it's updated more than once in one digest loop. - Richard --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review167925 --- On March 3, 2017, 7:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57268/ > --- > > (Updated March 3, 2017, 7:34 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > > Repository: ambari > > > Description > --- > > Take subSectionTab into consideration on show/hide > > > Diffs > - > > ambari-web/app/models/configs/theme/sub_section.js 7274569 > ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 466a88d > ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c > > > Diff: https://reviews.apache.org/r/57268/diff/1/ > > > Testing > --- > > Manully tested on live cluster. All unit tests passed. > 20560 passing (25s) > 153 pending > > > Thanks, > > Richard Zang > >
Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-20287 https://issues.apache.org/jira/browse/AMBARI-20287 Repository: ambari Description --- Take subSectionTab into consideration on show/hide Diffs - ambari-web/app/models/configs/theme/sub_section.js 7274569 ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 ambari-web/app/views/common/configs/service_config_layout_tab_view.js 466a88d ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c Diff: https://reviews.apache.org/r/57268/diff/1/ Testing --- Manully tested on live cluster. All unit tests passed. 20560 passing (25s) 153 pending Thanks, Richard Zang
Review Request 57228: AMBARI-20265 - Blueprint deployment with auto-restart settings enabled, auto-restart UI is incomplete.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57228/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-20265 https://issues.apache.org/jira/browse/AMBARI-20265 Repository: ambari Description --- Show UI even when count is 0 Diffs - ambari-web/app/controllers/main/admin/service_auto_start.js 3365cae Diff: https://reviews.apache.org/r/57228/diff/1/ Testing --- Manually tested on live cluster, all unit tests passed. 30365 passing (22s) 157 pending Thanks, Richard Zang
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/ --- (Updated Feb. 28, 2017, 7:44 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- Add as patch instead of extra file Bugs: AMBARI-20194 https://issues.apache.org/jira/browse/AMBARI-20194 Repository: ambari Description --- Enabled manage alert notification option based on user's privileges Diffs (updated) - ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js f37876f ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs 9b5442d ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5d81281 Diff: https://reviews.apache.org/r/57062/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/ --- (Updated Feb. 28, 2017, 3:55 a.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- A follow up fix to make sure UI shows correctly after logout and login with user with different role. Remove old 'isOperator' based restrictions on modal UI items since we are already enforcing RBAC on the pull down action list. Bugs: AMBARI-20194 https://issues.apache.org/jira/browse/AMBARI-20194 Repository: ambari Description --- Enabled manage alert notification option based on user's privileges Diffs - ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js a397b7b Diff: https://reviews.apache.org/r/57062/diff/ Testing --- Manually tested on live cluster. All unit tests passed. File Attachments (updated) AMBARI-20194-fix1.patch https://reviews.apache.org/media/uploaded/files/2017/02/28/be236f3c-50bd-4f66-a41b-895c0dbba006__AMBARI-20194-fix1.patch Thanks, Richard Zang
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57004/ --- (Updated Feb. 24, 2017, 2:27 a.m.) Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-20158 https://issues.apache.org/jira/browse/AMBARI-20158 Repository: ambari Description --- Always show host combo search. Merge instead of overwrite support list after loading user-pref. Diffs - ambari-web/app/config.js 6afa810 ambari-web/app/controllers/experimental.js 8b93761 ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df Diff: https://reviews.apache.org/r/57004/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20375 passing (23s) 153 pending File Attachments (updated) AMBARI-20158-fix1.patch https://reviews.apache.org/media/uploaded/files/2017/02/24/67d30316-bcff-4d49-80b7-afeffe9d703a__AMBARI-20158-fix1.patch Thanks, Richard Zang
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above
> On Feb. 24, 2017, 1:38 a.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/experimental.js, line 38
> > <https://reviews.apache.org/r/57004/diff/1/?file=1646551#file1646551line38>
> >
> > $.merge(response, App.get('supports')) returns back the first argument
> > passed. As a result the application behavior remains the same as it was
> > before this patch
> >
> > Please use $.extend instead of $.merge.
$.merge is for array, will adjust to $.extend
- Richard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
-------
On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> ---
>
> (Updated Feb. 23, 2017, 11:52 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> ---
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 57008: Side Nav: multiple fixes after integrated to trunk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57008/#review166628 --- Ship it! Ship It! - Richard Zang On Feb. 24, 2017, 12:35 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57008/ > --- > > (Updated Feb. 24, 2017, 12:35 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-20160 > https://issues.apache.org/jira/browse/AMBARI-20160 > > > Repository: ambari > > > Description > --- > > Need to fix the following issues after integrated the Side Navi Bar and Top > Bar to trunk: > 1. Service actions dropdown might positioned incorrectly sometimes. > 2. If the scrollbar shows up, sometimes it is on top of the actions dropdown > menu. > 3. Alerts Panel: change alert definition name into 14px in #333 > 4. Remove menu on Admin page, it is duplicated > 5. Alerts Panel: red alerts cnt circle should be able to display large > numbers. eg 99, 999, .etc > 6. FireFox issue: alert description not limited. should be limited to 3 lines > > > Diffs > - > > ambari-web/app/styles/application.less cb94a54 > ambari-web/app/styles/theme/bootstrap-ambari.css d88a1ed > ambari-web/app/styles/top-nav.less 8c373ce > ambari-web/app/templates/main/admin.hbs d1dfe74 > ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1c81aeb > > Diff: https://reviews.apache.org/r/57008/diff/ > > > Testing > --- > > 20375 passing (37s) > 153 pending > > > Thanks, > > Xi Wang > >
Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57004/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-20158 https://issues.apache.org/jira/browse/AMBARI-20158 Repository: ambari Description --- Always show host combo search. Merge instead of overwrite support list after loading user-pref. Diffs - ambari-web/app/config.js 6afa810 ambari-web/app/controllers/experimental.js 8b93761 ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df Diff: https://reviews.apache.org/r/57004/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20375 passing (23s) 153 pending Thanks, Richard Zang
Review Request 56961: DataNode Storage alert is duplicated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56961/ --- Review request for Ambari, Alexandr Antonenko and Xi Wang. Bugs: AMBARI-20125 https://issues.apache.org/jira/browse/AMBARI-20125 Repository: ambari Description --- Make sure each definition gets pushed only one time Diffs - ambari-web/app/controllers/main/service/info/summary.js 0ca9775 Diff: https://reviews.apache.org/r/56961/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20373 passing (21s) 153 pending Thanks, Richard Zang
Review Request 56777: AMBARI-20058 - 'Final' is not shown correctly in config diff tool and in older versions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56777/ --- Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko. Bugs: AMBARI-20058 https://issues.apache.org/jira/browse/AMBARI-20058 Repository: ambari Description --- This issue was introduced in AMBARI-15459 Fix the condition of showing override differently. Diffs - ambari-web/app/templates/common/configs/service_config_category.hbs fbcb828 ambari-web/app/views/common/configs/controls_view.js 8894ea6 Diff: https://reviews.apache.org/r/56777/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20340 passing (23s) 153 pending Thanks, Richard Zang
Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted
> On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote: > > ambari-web/app/mappers/configs/config_groups_mapper.js, line 71 > > <https://reviews.apache.org/r/56426/diff/1/?file=1627187#file1627187line71> > > > > sorting a list might not be very expensive on client side. But if there > > are multiple config groups with considerable hosts in each then it can have > > some performace impact. > > > > I don't see this to be significant. so I am ok with commiting this > > patch. But good to track this as a future requirement for ambari-server to > > expose an API that gives sorted hostnames for a configgroup by default or > > via sortBy predicate. Yes, sorting will cause noticable time when list is big, so when we have API provide sorted list of hosts, we can remove this from mapper. > On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote: > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js, > > line 569 > > <https://reviews.apache.org/r/56426/diff/1/?file=1627186#file1627186line569> > > > > parentconfiggroup should already be sorted to beging with as we are > > sorting all config groups in config group mapper. rmoving a host should > > keep the list sorted > > > > is again sorting required over here ? fixed in v2 > On Feb. 8, 2017, 7:28 p.m., Jaimin Jetly wrote: > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js, > > line 590 > > <https://reviews.apache.org/r/56426/diff/1/?file=1627186#file1627186line590> > > > > same as above. if a host is being emoved from a sorted list, again > > sorting the list may not be required. fixed in v2 - Richard --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56426/#review164745 --- On Feb. 8, 2017, 8:18 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56426/ > --- > > (Updated Feb. 8, 2017, 8:18 p.m.) > > > Review request for Ambari, Jaimin Jetly and Xi Wang. > > > Bugs: AMBARI-19912 > https://issues.apache.org/jira/browse/AMBARI-19912 > > > Repository: ambari > > > Description > --- > > Keep host list sorted on initial loading as well as after any operation. > > > Diffs > - > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 07756f0 > ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 > > Diff: https://reviews.apache.org/r/56426/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 20327 passing (21s) > 153 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56426/ --- (Updated Feb. 8, 2017, 8:18 p.m.) Review request for Ambari, Jaimin Jetly and Xi Wang. Changes --- Only sort the list with new entries. Bugs: AMBARI-19912 https://issues.apache.org/jira/browse/AMBARI-19912 Repository: ambari Description --- Keep host list sorted on initial loading as well as after any operation. Diffs (updated) - ambari-web/app/controllers/main/service/manage_config_groups_controller.js 07756f0 ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 Diff: https://reviews.apache.org/r/56426/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20327 passing (21s) 153 pending Thanks, Richard Zang
Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56426/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-19912 https://issues.apache.org/jira/browse/AMBARI-19912 Repository: ambari Description --- Keep host list sorted on initial loading as well as after any operation. Diffs - ambari-web/app/controllers/main/service/manage_config_groups_controller.js 07756f0 ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 Diff: https://reviews.apache.org/r/56426/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20327 passing (21s) 153 pending Thanks, Richard Zang
Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56298/ --- Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako. Bugs: AMBARI-19871 https://issues.apache.org/jira/browse/AMBARI-19871 Repository: ambari Description --- Fix version state variable usage. Diffs - ambari-web/app/views/common/configs/config_history_flow.js c216890 Diff: https://reviews.apache.org/r/56298/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 20325 passing (23s) 153 pending Thanks, Richard Zang
Review Request 55913: AMBARI-19701 - Provide minimal call context from UI when making stack advisor calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55913/ --- Review request for Ambari. Bugs: AMBARI-19701 https://issues.apache.org/jira/browse/AMBARI-19701 Repository: ambari Description --- Provide minimal call context Diffs - ambari-web/app/mixins/common/configs/enhanced_configs.js aece4c2 Diff: https://reviews.apache.org/r/55913/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30309 passing (21s) 157 pending Thanks, Richard Zang
Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55733/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-19637 https://issues.apache.org/jira/browse/AMBARI-19637 Repository: ambari Description --- Stop assuming the is always 1 repo url + 1 util url. UI Adjustment for repo with any number of urls. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 82c1c40 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js ae9850b ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 Diff: https://reviews.apache.org/r/55733/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.188 secs / 0.404 secs) Thanks, Richard Zang
Review Request 55596: AMBARI-19576 - Downgrade request fails as existing Upgrade request is considered 'in progress'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55596/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-19576 https://issues.apache.org/jira/browse/AMBARI-19576 Repository: ambari Description --- Wait for the request_status = ABORTED before initializing downgrade. Diffs - ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 3058580 ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 78e81a0 Diff: https://reviews.apache.org/r/55596/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30297 passing (21s) 157 pending Thanks, Richard Zang
Review Request 55159: AMBARI-19348 - Version number is incorrect when upgrade wizard is opened from Upgrade History
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55159/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-19348 https://issues.apache.org/jira/browse/AMBARI-19348 Repository: ambari Description --- Change fromVersion to toVersion Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 8817308 Diff: https://reviews.apache.org/r/55159/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 19859 passing (17s) 153 pending Thanks, Richard Zang
Review Request 55096: AMBARI-19324 - Ambai-web action to download all client configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55096/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-19324 https://issues.apache.org/jira/browse/AMBARI-19324 Repository: ambari Description --- Support download all client configs Diffs - ambari-web/app/controllers/main/service.js 2677723 ambari-web/app/messages.js 6296d55 ambari-web/app/mixins/main/host/details/support_client_configs_download.js 6e7cd9b ambari-web/app/templates/main/service/all_services_actions.hbs 7cd36c8 Diff: https://reviews.apache.org/r/55096/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 19838 passing (17s) 153 pending Thanks, Richard Zang
Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/ --- (Updated Dec. 7, 2016, 11:25 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- Add a general fix on tasks removal for various wizard progress pages Bugs: AMBARI-19118 https://issues.apache.org/jira/browse/AMBARI-19118 Repository: ambari Description --- Start Zookeeper Server and Ambari Infra before starting Ranger Admin. Diffs (updated) - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js ae27506 ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 3c220c1 ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step4_controller.js 722ae94 ambari-web/app/controllers/main/service/reassign/step4_controller.js 64c2a8e ambari-web/app/controllers/main/service/reassign/step6_controller.js 113686b ambari-web/app/messages.js 22720a9 ambari-web/app/mixins/wizard/wizardProgressPageController.js 3ee8a9a Diff: https://reviews.apache.org/r/54466/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25637 tests complete (26 seconds) 57 tests pending Thanks, Richard Zang
Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/ --- (Updated Dec. 7, 2016, 7:43 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- Fix text message sequence Bugs: AMBARI-19118 https://issues.apache.org/jira/browse/AMBARI-19118 Repository: ambari Description --- Start Zookeeper Server and Ambari Infra before starting Ranger Admin. Diffs (updated) - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js ae27506 ambari-web/app/messages.js 22720a9 Diff: https://reviews.apache.org/r/54466/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25637 tests complete (26 seconds) 57 tests pending Thanks, Richard Zang
Re: Review Request 54050: AMBARI-18981 - Manage JournalNodes Wizard: Display only the steps needed for DELETE ONLY task
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54050/ --- (Updated Dec. 6, 2016, 1:13 a.m.) Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Changes --- update patch according to latest trunk code Bugs: AMBARI-18981 https://issues.apache.org/jira/browse/AMBARI-18981 Repository: ambari Description --- Display only the steps needed for DELETE ONLY task Diffs (updated) - ambari-web/app/controllers/global/update_controller.js 4631f09 ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js 2305524 ambari-web/app/routes/manage_journalnode_routes.js e13a338 ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs 844e1c8 ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js 656c487 Diff: https://reviews.apache.org/r/54050/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25461 tests complete (23 seconds) 57 tests pending Thanks, Richard Zang
Review Request 54050: AMBARI-18981 - Manage JournalNodes Wizard: Display only the steps needed for DELETE ONLY task
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54050/ --- Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18981 https://issues.apache.org/jira/browse/AMBARI-18981 Repository: ambari Description --- Display only the steps needed for DELETE ONLY task Diffs - ambari-web/app/controllers/global/update_controller.js 4631f09 ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js 2305524 ambari-web/app/routes/manage_journalnode_routes.js 50e3ec9 ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs f7ee486 ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js 656c487 Diff: https://reviews.apache.org/r/54050/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25461 tests complete (23 seconds) 57 tests pending Thanks, Richard Zang
Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53922/ --- Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18942 https://issues.apache.org/jira/browse/AMBARI-18942 Repository: ambari Description --- Avoid reload after save / discard Diffs - ambari-web/app/controllers/main/admin/service_auto_start.js b425c78 ambari-web/app/templates/main/admin/service_auto_start.hbs 9dc4dfb ambari-web/app/views/main/admin/service_auto_start.js dcbbfc9 ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js a25d835 Diff: https://reviews.apache.org/r/53922/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25461 tests complete (22 seconds) 57 tests pending Thanks, Richard Zang
Review Request 53833: AMBARI-18916 - Manage JournalNodes Wizard: Text adjustments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53833/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-18916 https://issues.apache.org/jira/browse/AMBARI-18916 Repository: ambari Description --- Text adjustments Diffs - ambari-web/app/messages.js 83a7208 ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs e25e7b7 Diff: https://reviews.apache.org/r/53833/diff/ Testing --- Manually test on live cluster. All unit tests passed. 30621 tests complete (52 seconds) 151 tests pending Thanks, Richard Zang
Re: Review Request 53821: Implement Create Alerts: Create a base wizard for all steps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53821/#review156152 --- Ship it! Ship It! - Richard Zang On Nov. 16, 2016, 9:04 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53821/ > --- > > (Updated Nov. 16, 2016, 9:04 p.m.) > > > Review request for Ambari, Richard Zang and Yusaku Sako. > > > Bugs: AMBARI-18903 > https://issues.apache.org/jira/browse/AMBARI-18903 > > > Repository: ambari > > > Description > --- > > This is a FE task to implement the "Create Alerts Wizard " based on the > design attached. > > This task is to create the the following files so that we have a blank base > wizard as a start point. > > *4 controllers* in folder: controllers/main/alerts/create > wizard_controller.js (should extend App.WizardController) > step1_controller.js > step2_controller.js > step3_controller.js > > *4 views* in folder: views/main/alerts/create > wizard_view.js (extend sApp.WizardMenuMixin) > step1_view.js > step2_view.js > step3_view.js > > *4 templates* in folder: templates/main/alerts/create > wizard.hbs > step1.hbs > step2.hbs > step3.hbs > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > 36bc232 > > Diff: https://reviews.apache.org/r/53821/diff/ > > > Testing > --- > > > Thanks, > > Xi Wang > >
Review Request 53771: AMBARI-18890 - Enable "Auto Start" feature for services & components by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53771/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-18890 https://issues.apache.org/jira/browse/AMBARI-18890 Repository: ambari Description --- Emable auto start. Diffs - ambari-web/app/config.js c3c45b1 Diff: https://reviews.apache.org/r/53771/diff/ Testing --- Manually tested on live cluster. All unit test passed. 25353 tests complete (37 seconds) 57 tests pending Thanks, Richard Zang
Review Request 53664: AMBARI-18855 - Manage JournalNode Wizard: While assigning new JournalNodes, Current JournalNode selection value changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53664/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-18855 https://issues.apache.org/jira/browse/AMBARI-18855 Repository: ambari Description --- Sort old components by serviceComponentId before assigning new id to lastObject.serviceComponentId + 1; Force reevaluation of next button status after rendering components. Diffs - ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js c834517 ambari-web/app/mixins/wizard/assign_master_components.js 46409b2 Diff: https://reviews.apache.org/r/53664/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25349 tests complete (21 seconds) 57 tests pending Thanks, Richard Zang
Re: Review Request 53634: Review step has repository versions value as blank field
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53634/#review155535 --- Ship it! Ship It! - Richard Zang On Nov. 10, 2016, 1:04 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53634/ > --- > > (Updated Nov. 10, 2016, 1:04 a.m.) > > > Review request for Ambari, Richard Zang, Sumit Mohanty, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-18766 > https://issues.apache.org/jira/browse/AMBARI-18766 > > > Repository: ambari > > > Description > --- > > This was caused due to initial fix for > https://issues.apache.org/jira/secure/attachment/12836448/AMBARI-18766.patch > which did not accounted for repositroy version to have seperate value from > stack version > > > Diffs > - > > ambari-web/app/controllers/wizard/step8_controller.js 237e2d8 > ambari-web/test/controllers/wizard/step8_test.js 3abe2cb > > Diff: https://reviews.apache.org/r/53634/diff/ > > > Testing > --- > > Verified that the patch fixes the issue. > Verified that all ambari-web unit tests passes: > 29250 tests complete (33 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 53635: AMBARI-15126 - Move NameNode wizard in HA environment fails to update configs correctly when namenode is not running on default port
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53635/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-15126 https://issues.apache.org/jira/browse/AMBARI-15126 Repository: ambari Description --- Fix the problem by removing the hardcoded port and comparing host name only. Fix a configs UI problem appeared in wizard UI. Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js 243fa3b ambari-web/app/views/common/configs/service_configs_by_category_view.js ac59386 Diff: https://reviews.apache.org/r/53635/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30493 tests complete (37 seconds) 151 tests pending Thanks, Richard Zang
Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53565/#review155349 --- Ship it! Ship It! - Richard Zang On Nov. 8, 2016, 8:09 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53565/ > --- > > (Updated Nov. 8, 2016, 8:09 p.m.) > > > Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-18817 > https://issues.apache.org/jira/browse/AMBARI-18817 > > > Repository: ambari > > > Description > --- > > As part of this work experimental flag has been added by which host checks > can be disabled while going thorugh "Add Host Wizard" > > > Diffs > - > > ambari-web/app/config.js 06faf27 > ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed > ambari-web/app/templates/wizard/step3.hbs f5648e1 > > Diff: https://reviews.apache.org/r/53565/diff/ > > > Testing > --- > > manually verified the patch on the lcuster > verified that all ambar-web unit tests passes > 29248 tests complete (30 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 53563: AMBARI-18815 - Manage Journal Node Wizard: Link Add/Delete operation for JournalNode to the wizard
> On Nov. 8, 2016, 6:38 p.m., Alejandro Fernandez wrote: > > ambari-web/app/views/main/host/details/host_component_view.js, line 205 > > <https://reviews.apache.org/r/53563/diff/1/?file=1556432#file1556432line205> > > > > Will this TODO be fixed? Yes, this will be fixed in following up bug fixing JIRAs. - Richard --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53563/#review155323 --- On Nov. 8, 2016, 1:39 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53563/ > --- > > (Updated Nov. 8, 2016, 1:39 a.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18815 > https://issues.apache.org/jira/browse/AMBARI-18815 > > > Repository: ambari > > > Description > --- > > Link Add/Delete operation for JournalNode to the wizard > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 2076333 > ambari-web/app/messages.js d8ec229 > ambari-web/app/models/stack_service_component.js 17c2aa1 > ambari-web/app/templates/main/host/details/deleteComponentPopup.hbs 4fd5c52 > ambari-web/app/views/main/host/details/host_component_view.js 16071eb > > Diff: https://reviews.apache.org/r/53563/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 25347 tests complete (21 seconds) > 57 tests pending > > > Thanks, > > Richard Zang > >
Review Request 53563: AMBARI-18815 - Manage Journal Node Wizard: Link Add/Delete operation for JournalNode to the wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53563/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18815 https://issues.apache.org/jira/browse/AMBARI-18815 Repository: ambari Description --- Link Add/Delete operation for JournalNode to the wizard Diffs - ambari-web/app/controllers/main/host/details.js 2076333 ambari-web/app/messages.js d8ec229 ambari-web/app/models/stack_service_component.js 17c2aa1 ambari-web/app/templates/main/host/details/deleteComponentPopup.hbs 4fd5c52 ambari-web/app/views/main/host/details/host_component_view.js 16071eb Diff: https://reviews.apache.org/r/53563/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25347 tests complete (21 seconds) 57 tests pending Thanks, Richard Zang
Re: Review Request 53505: AMBARI-18805 Bulk delete hosts: sending a force option to delete all components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53505/#review155018 --- Ship it! Ship It! - Richard Zang On Nov. 4, 2016, 11:02 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53505/ > --- > > (Updated Nov. 4, 2016, 11:02 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18805 > https://issues.apache.org/jira/browse/AMBARI-18805 > > > Repository: ambari > > > Description > --- > > Send a force option to delete all components when delete hosts > > > Diffs > - > > ambari-web/app/utils/ajax/ajax.js d263ba0 > > Diff: https://reviews.apache.org/r/53505/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30351 tests complete (34 seconds) > 151 tests pending > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 50014: AMBARI-17703 - Hosts page: after component filter hosts have wrong list of components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50014/ --- (Updated Nov. 4, 2016, 9:55 p.m.) Review request for Ambari and Zhe (Joe) Wang. Changes --- Fix query parameter issue in the relay request Bugs: AMBARI-17703 https://issues.apache.org/jira/browse/AMBARI-17703 Repository: ambari Description --- Enable preload for host component related filters Diffs (updated) - ambari-web/app/controllers/global/update_controller.js fda1704 ambari-web/app/controllers/main/host.js cea40cb Diff: https://reviews.apache.org/r/50014/diff/ Testing --- Manually tested on live cluster, all unit tests passed. 29021 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 53364: AMBARI-18767 - E2E Integration for Manage JournalNode Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53364/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18767 https://issues.apache.org/jira/browse/AMBARI-18767 Repository: ambari Description --- E2E Integration for Manage JournalNode Wizard. 2 more step has been added to ensure data consistency of HDFS. Diffs - ambari-web/app/controllers.js e576d6c ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js 0da5264 ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js 920bbd1e ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js 39a074e ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js a0425c8 ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step8_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js 56b6ff5 ambari-web/app/messages.js 45dfc2c ambari-web/app/routes/manage_journalnode_routes.js 4803ca7 ambari-web/app/styles/application.less d0eebce ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs ae01f46 ambari-web/app/templates/main/admin/highAvailability/journalNode/step7.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step8.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs e654c50 ambari-web/app/views.js 2dda9dd ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js c32bd74 ambari-web/app/views/main/admin/highAvailability/journalNode/step3_view.js cac4a7e ambari-web/app/views/main/admin/highAvailability/journalNode/step5_view.js 651cabd ambari-web/app/views/main/admin/highAvailability/journalNode/step7_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step8_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/wizard_view.js 434971b Diff: https://reviews.apache.org/r/53364/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/ --- (Updated Oct. 27, 2016, 10:58 p.m.) Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Changes --- Add customizable label for view links on hive summary page Bugs: AMBARI-18696 https://issues.apache.org/jira/browse/AMBARI-18696 Repository: ambari Description --- Add Hive View Links to Hive Summary Page. Fix some name typo. Diffs (updated) - ambari-web/app/controllers/main/service/info/summary.js 6752bbf ambari-web/app/messages.js 1770624 ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 37225e1 ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs f73e2bb ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs eabb6dc ambari-web/app/templates/main/service/item.hbs 5eb4e5b ambari-web/app/templates/main/service/services/hive.hbs 23a2347 ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f ambari-web/app/views/common/quick_view_link_view.js 2678c1c ambari-web/app/views/main/service/services/hive.js 2530e42 Diff: https://reviews.apache.org/r/53178/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25699 tests complete (24 seconds) 57 tests pending Thanks, Richard Zang
Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18696 https://issues.apache.org/jira/browse/AMBARI-18696 Repository: ambari Description --- Add Hive View Links to Hive Summary Page. Fix some name typo. Diffs - ambari-web/app/controllers/main/service/info/summary.js c16bb3f ambari-web/app/messages.js 8f49cce ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs cb97978 ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 96f64ba ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs 884f322 ambari-web/app/templates/main/service/item.hbs 43fb3dd ambari-web/app/templates/main/service/services/hive.hbs 23a2347 ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f ambari-web/app/views/common/quick_view_link_view.js 17d7c04 ambari-web/app/views/main/service/services/hive.js 2530e42 Diff: https://reviews.apache.org/r/53178/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 25699 tests complete (24 seconds) 57 tests pending Thanks, Richard Zang
Review Request 53205: AMBARI-18709 - Javascript Error When Using ComponentState Filter On Host Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53205/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18709 https://issues.apache.org/jira/browse/AMBARI-18709 Repository: ambari Description --- Fix missing var statement. Diffs - ambari-web/app/controllers/main/host/combo_search_box.js 4ab3b7c Diff: https://reviews.apache.org/r/53205/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30371 tests complete (30 seconds) 151 tests pending Thanks, Richard Zang
Review Request 53109: Manage Journal Node Wizard Initial UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53109/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18669 https://issues.apache.org/jira/browse/AMBARI-18669 Repository: ambari Description --- Manage Journal Node Wizard Initial UI This feature is still hidden in experimental Diffs - ambari-web/app/config.js 4550eb8 ambari-web/app/controllers.js 2537f62 ambari-web/app/controllers/main/admin/highAvailability/journalNode/progress_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step3_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step5_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js PRE-CREATION ambari-web/app/controllers/main/admin/highAvailability/nameNode/wizard_controller.js 72f9ec2 ambari-web/app/controllers/main/admin/highAvailability_controller.js 4cd50a6 ambari-web/app/controllers/main/service/item.js 6ce811d ambari-web/app/controllers/wizard.js 05cd35c ambari-web/app/data/HDP2/move_journal_node_properties.js PRE-CREATION ambari-web/app/messages.js aa7fb81 ambari-web/app/models/host_component.js c6b8264 ambari-web/app/routes/main.js 45c1cd3 ambari-web/app/routes/manage_journalnode_routes.js PRE-CREATION ambari-web/app/styles/application.less b2b4dd1 ambari-web/app/templates/main/admin/highAvailability/journalNode/step1.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step3.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step4.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step5.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/step6.hbs PRE-CREATION ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs PRE-CREATION ambari-web/app/utils/db.js a6cdef7 ambari-web/app/views.js c8a8784 ambari-web/app/views/main/admin/highAvailability/journalNode/progress_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step1_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step3_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step4_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step5_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/step6_view.js PRE-CREATION ambari-web/app/views/main/admin/highAvailability/journalNode/wizard_view.js PRE-CREATION ambari-web/app/views/main/service/item.js a007e17 Diff: https://reviews.apache.org/r/53109/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29538 tests complete (30 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review153220 --- Ship it! Ship It! - Richard Zang On Oct. 18, 2016, 11:37 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 18, 2016, 11:37 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-admin/src/main/resources/ui/admin-web/package.json 42f584e > ambari-web/app/styles/common.less a053d28 > ambari-web/karma.conf.js 7442b95 > ambari-web/package.json 94ded60 > ambari-web/pom.xml d3de055 > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.91
Re: Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52555/#review152392 --- Ship it! Ship It! - Richard Zang On Oct. 5, 2016, 3:25 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52555/ > --- > > (Updated Oct. 5, 2016, 3:25 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18535 > https://issues.apache.org/jira/browse/AMBARI-18535 > > > Repository: ambari > > > Description > --- > > During fresh deployment, if HDP-2.4 is chosen then Ambari does not default to > the latest 2.4 release, HDP-2.4.2. This is likely because VDF files do not > exist for HDP-2.4 release and the older mechanism of picking the latest repo > URL form the hdp_urlinfo.json does not work. HDP-2.4.0 is chosen where as the > latest is HDP-2.4.2 > > > Diffs > - > > ambari-web/app/controllers/installer.js f8f70a0 > > Diff: https://reviews.apache.org/r/52555/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30374 tests complete (27 seconds) > 151 tests pending > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52710/#review152231 --- Ship it! Ship It! - Richard Zang On Oct. 12, 2016, 12:07 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52710/ > --- > > (Updated Oct. 12, 2016, 12:07 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18566 > https://issues.apache.org/jira/browse/AMBARI-18566 > > > Repository: ambari > > > Description > --- > > *STR:* > # Got to select versions page > # Choose "Use Local Repository" option and then choose "Use RedHat > Satellite/Spacewalk" option > # Next button will get enabled. click on next button. > > *Expected Result:* wizard goes to next page > *Actual Result:* On clicking next button, next button gets disabled and > wizard does not go to next page. > > > Diffs > - > > ambari-web/app/controllers/installer.js f8f70a0 > ambari-web/app/views/wizard/step1_view.js 2b80ad5 > > Diff: https://reviews.apache.org/r/52710/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30374 tests complete (27 seconds) > 151 tests pending > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151604 --- Ship it! Ship It! - Richard Zang On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 4, 2016, 12:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration SUCCESS [20.801s] > [INFO] Hive Jdbc . SUCCESS [1:00.664s] > [INFO] WF Manager View ... SUCCESS [32.911s] > [INFO] Hive .
Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52497/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18519 https://issues.apache.org/jira/browse/AMBARI-18519 Repository: ambari Description --- Enable Add/Remove JournalNode on NNHA Wizard Step 2 Diffs - ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js b8d7978 ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs 27653d3 Diff: https://reviews.apache.org/r/52497/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 30366 tests complete (30 seconds) 151 tests pending Thanks, Richard Zang
Re: Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- (Updated Sept. 21, 2016, 12:04 a.m.) Review request for Ambari and Zhe (Joe) Wang. Changes --- remove IDE related indentation Bugs: AMBARI-15059 https://issues.apache.org/jira/browse/AMBARI-15059 Repository: ambari Description --- Add extra handling logic for navigating out and save button. Diffs (updated) - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js 582b68b ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html ee5d860 Diff: https://reviews.apache.org/r/52102/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 secs) Thanks, Richard Zang
Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-15059 https://issues.apache.org/jira/browse/AMBARI-15059 Repository: ambari Description --- Add extra handling logic for navigating out and save button. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js 582b68b ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html ee5d860 Diff: https://reviews.apache.org/r/52102/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 secs) Thanks, Richard Zang
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- (Updated Sept. 14, 2016, 8:40 p.m.) Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Changes --- Add all related fields to dependency. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs (updated) - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
Re: Review Request 51440: AMBARI-15309 UI: ability to perform bulk delete host components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51440/#review147032 --- Ship it! Ship It! - Richard Zang On Aug. 25, 2016, 10:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51440/ > --- > > (Updated Aug. 25, 2016, 10:50 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15309 > https://issues.apache.org/jira/browse/AMBARI-15309 > > > Repository: ambari > > > Description > --- > > UI: ability to perform bulk delete host components > > > Diffs > - > > ambari-web/app/controllers/main/host/bulk_operations_controller.js 0e73c0c > ambari-web/app/messages.js 4cf3564 > ambari-web/app/utils/ajax/ajax.js 5538e6d > ambari-web/app/views/main/host/hosts_table_menu_view.js dccffaa > > Diff: https://reviews.apache.org/r/51440/diff/ > > > Testing > --- > > Local ambari-web test passed. > 30014 tests complete (26 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 51356: AMBARI-18247 Capacity scheduler's dependent config suggestion is incomprehensible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51356/#review146871 --- Ship it! Ship It! - Richard Zang On Aug. 24, 2016, 1 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51356/ > --- > > (Updated Aug. 24, 2016, 1 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18247 > https://issues.apache.org/jira/browse/AMBARI-18247 > > > Repository: ambari > > > Description > --- > > Dependent configs dialog shows recommended values for capacity scheduler > which is incomprehensible to read. It will be good to breakdown the specific > changes into separate rows. > > > Diffs > - > > ambari-web/app/mixins/common/configs/config_recommendations.js 398cf55 > ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs > 0fe073c > ambari-web/app/utils/config.js 7e1f5b8 > ambari-web/config.coffee 4a29e73 > ambari-web/karma.conf.js 013cc2e > ambari-web/test/mixins/common/configs/config_recommendations_test.js > 3f7d6b1 > ambari-web/vendor/scripts/difflib.js PRE-CREATION > ambari-web/vendor/scripts/diffview.js PRE-CREATION > ambari-web/vendor/styles/diffview.css PRE-CREATION > > Diff: https://reviews.apache.org/r/51356/diff/ > > > Testing > --- > > Modified unit test. > Local ambari-web test passed. > 29244 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 50275: AMBARI-17821 Atlas: Add Service Customize Services Page Issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50275/ --- Review request for Ambari, Andrii Tkach and Zhe (Joe) Wang. Bugs: AMBARI-17821 https://issues.apache.org/jira/browse/AMBARI-17821 Repository: ambari Description --- Push UI after recommendation finish Diffs - ambari-web/app/views/common/configs/service_config_container_view.js 8b6a9ce ambari-web/test/views/common/configs/service_config_container_view_test.js e7aaa62 Diff: https://reviews.apache.org/r/50275/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29292 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50165/#review142796 --- Ship it! Ship It! - Richard Zang On July 18, 2016, 10:20 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50165/ > --- > > (Updated July 18, 2016, 10:20 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-1 > https://issues.apache.org/jira/browse/AMBARI-1 > > > Repository: ambari > > > Description > --- > > STR: > # Go to SelectVersion page > # Clear any input with Base URL (for ex. ubuntu14) > # Click on next button > > Expected: input has now red borders and warning message appears below > "Attention: All repo URLs are required before you can proceed." > > Actually: Next button became to disabled state. Next page wasn't loaded. > > > Diffs > - > > ambari-web/app/controllers/installer.js 037e555 > ambari-web/app/models/operating_system.js c2588fe > > Diff: https://reviews.apache.org/r/50165/diff/ > > > Testing > --- > > Local ambari-web test passed. > 29285 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 50100: AMBARI-17754 - Issue with modify configs for hive service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50100/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-17754 https://issues.apache.org/jira/browse/AMBARI-17754 Repository: ambari Description --- Fix reference to undefined. Diffs - ambari-web/app/mixins/common/configs/enhanced_configs.js 46744ba Diff: https://reviews.apache.org/r/50100/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29285 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Review Request 50014: AMBARI-17703 - Hosts page: after component filter hosts have wrong list of components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50014/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17703 https://issues.apache.org/jira/browse/AMBARI-17703 Repository: ambari Description --- Enable preload for host component related filters Diffs - ambari-web/app/controllers/global/update_controller.js 98f528f ambari-web/app/controllers/main/host.js cea40cb Diff: https://reviews.apache.org/r/50014/diff/ Testing --- Manually tested on live cluster, all unit tests passed. 29021 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49931/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17663 https://issues.apache.org/jira/browse/AMBARI-17663 Repository: ambari Description --- Fix undefined reference. Diffs - ambari-web/app/views/common/sort_view.js bbb6004 Diff: https://reviews.apache.org/r/49931/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 29018 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49677: YARN Summary Panel shows ResourceManager heap incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49677/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17574 https://issues.apache.org/jira/browse/AMBARI-17574 Repository: ambari Description --- Use correct template. Diffs - ambari-web/app/messages.js dcf0426 ambari-web/app/views/main/service/services/yarn.js 7ccbfcf Diff: https://reviews.apache.org/r/49677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28941 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49664: HDFS Summary Panel is not showing the NameNode heap size correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49664/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17572 https://issues.apache.org/jira/browse/AMBARI-17572 Repository: ambari Description --- Fix parameter name. Diffs - ambari-web/app/views/main/service/services/hdfs.js 4bc2cce Diff: https://reviews.apache.org/r/49664/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28941 tests complete (30 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49475: Hosts filter works incorrect with Flume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49475/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17511 https://issues.apache.org/jira/browse/AMBARI-17511 Repository: ambari Description --- Add separate map for services. Diffs - ambari-web/app/views/main/host/combo_search_box.js 29a35ef Diff: https://reviews.apache.org/r/49475/diff/ Testing --- Manually tested on live cluster. 28939 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49126/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17388 https://issues.apache.org/jira/browse/AMBARI-17388 Repository: ambari Description --- Add null check. Diffs - ambari-web/app/controllers/wizard/step7_controller.js 3211974 Diff: https://reviews.apache.org/r/49126/diff/ Testing --- Manually tested on live cluster. All unit test passed. 28972 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Review Request 48998: AMBARI-17326 - Mark the role "(from group)" if there is no specific user level role set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48998/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17326 https://issues.apache.org/jira/browse/AMBARI-17326 Repository: ambari Description --- Mark the role "(from group)" if there is no specific user level role set. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js b4138b3 ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html c0f6144 Diff: https://reviews.apache.org/r/48998/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 48966: AMBARI-17322 No alerts on Select Version page when selected stack 2.2 with JDK 1.8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48966/#review138707 --- Ship it! Ship It! - Richard Zang On June 20, 2016, 9:11 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48966/ > --- > > (Updated June 20, 2016, 9:11 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17322 > https://issues.apache.org/jira/browse/AMBARI-17322 > > > Repository: ambari > > > Description > --- > > 1) Install Ambari with Oracle JDK 1.8 > 2) Go to Select Version page > 3) Select HDP 2.2 > Expected: Alert concering jdk mismatch > Actually: there is no alert > > > Diffs > - > > ambari-web/app/models/stack.js 5081f19 > ambari-web/app/utils/ajax/ajax.js 03a77ef > > Diff: https://reviews.apache.org/r/48966/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28646 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48834: AMBARI-17289 VDF: UI Edits #2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48834/#review138649 --- Ship it! Ship It! - Richard Zang On June 17, 2016, 1:40 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48834/ > --- > > (Updated June 17, 2016, 1:40 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17289 > https://issues.apache.org/jira/browse/AMBARI-17289 > > > Repository: ambari > > > Description > --- > > The CSS styling for Name on Register Version cleanup > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 542177d > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > e7bf01d > > Diff: https://reviews.apache.org/r/48834/diff/ > > > Testing > --- > > ambari-admin: > Executed 76 of 76 SUCCESS (0.15 secs / 0.358 secs) > Manual testing done > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 48888: AMBARI-17305 - Local User not displaying in View All option in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17305 https://issues.apache.org/jira/browse/AMBARI-17305 Repository: ambari Description --- JWT type will be supported from 2.4 so remove support flag. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 39a8e9c ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js 6318814 Diff: https://reviews.apache.org/r/4/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.13 secs / 0.379 secs) Thanks, Richard Zang
Review Request 48709: Nothing shows on the role section when user has the same role as its group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48709/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17239 https://issues.apache.org/jira/browse/AMBARI-17239 Repository: ambari Description --- Only show highest role. Fix ng-repeat usage to avoid error caused by duplicated items. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 69a15bd ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 18df5fa Diff: https://reviews.apache.org/r/48709/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.409 secs) Thanks, Richard Zang
Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17154 https://issues.apache.org/jira/browse/AMBARI-17154 Repository: ambari Description --- Fix warning text Diffs - ambari-web/app/messages.js 6c25357 Diff: https://reviews.apache.org/r/48517/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28649 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48456/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17134 https://issues.apache.org/jira/browse/AMBARI-17134 Repository: ambari Description --- Add support flag for user type 'JWT' Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 47b87c4 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js 4eb3633 ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js 3c5e7b2 Diff: https://reviews.apache.org/r/48456/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.12 secs / 0.368 secs) Thanks, Richard Zang
Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48451/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17132 https://issues.apache.org/jira/browse/AMBARI-17132 Repository: ambari Description --- Add facet validation check before search Diffs - ambari-web/app/messages.js 02da1f6 ambari-web/app/templates/main/host/combo_search_box.hbs 6ff9640 ambari-web/app/views/main/host/combo_search_box.js c6ac3bd Diff: https://reviews.apache.org/r/48451/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 28664 tests complete (27 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/#review136512 --- Ship it! Ship It! - Richard Zang On June 6, 2016, 6:22 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48289/ > --- > > (Updated June 6, 2016, 6:22 p.m.) > > > Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, > and Yusaku Sako. > > > Bugs: AMBARI-10908 > https://issues.apache.org/jira/browse/AMBARI-10908 > > > Repository: ambari > > > Description > --- > > On Hosts page, provide ability to delete hosts in bulk. > > > Diffs > - > > ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 > ambari-web/app/messages.js e8ca9ae > ambari-web/app/styles/application.less 5ee09cc > ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs > PRE-CREATION > ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION > ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs > PRE-CREATION > ambari-web/app/utils/ajax/ajax.js 195dab4 > ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 > > Diff: https://reviews.apache.org/r/48289/diff/ > > > Testing > --- > > Local ambari-web test passed. > 28648 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Review Request 48306: AMBARI-17077 - Unable to change user role in list view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17077 https://issues.apache.org/jira/browse/AMBARI-17077 Repository: ambari Description --- Fix role update logic Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js cd72ca6 Diff: https://reviews.apache.org/r/48306/diff/ Testing --- Manually tested on live cluster. All unit tests passed. PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.151 secs / 0.399 secs) Thanks, Richard Zang
Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48242/ --- Review request for Ambari, Alejandro Fernandez and Andrew Onischuk. Bugs: AMBARI-17039 https://issues.apache.org/jira/browse/AMBARI-17039 Repository: ambari Description --- Check both dfs.http.policy and deprecated dfs.https.enable Diffs - ambari-common/src/main/python/resource_management/libraries/functions/hdfs_utils.py PRE-CREATION ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py 919ccb5 ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py de46c1c ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py b634ce9 Diff: https://reviews.apache.org/r/48242/diff/ Testing --- mvn clean test Thanks, Richard Zang
Re: Review Request 47677: AMBARI-16804 - Refactor Move Master Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47677/ --- (Updated May 25, 2016, 9:32 p.m.) Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako. Changes --- Change place holder from numeric to variable name based. Bugs: AMBARI-16804 https://issues.apache.org/jira/browse/AMBARI-16804 Repository: ambari Description --- Refactor Move Master wizard. Extract configurable texts and stack related definitions into a separate JS file. Diffs (updated) - ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394 ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c ambari-web/app/data/wizards/move_master.js PRE-CREATION ambari-web/app/routes/reassign_master_routes.js f079432 ambari-web/app/templates/main/service/reassign.hbs 2477229 ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 ambari-web/app/utils/helper.js 7ab131c ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a ambari-web/app/views/main/service/reassign/step5_view.js 066b23b ambari-web/app/views/main/service/reassign/step6_view.js 33f8851 ambari-web/app/views/main/service/reassign/step7_view.js 60b357a ambari-web/test/controllers/main/service/reassign/step1_controller_test.js a43d91f ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d6ef9dc Diff: https://reviews.apache.org/r/47677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27828 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Review Request 47751: AMBARI-16831 - Atlas metadaserver doesn't show up in warning popup while deleting a host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47751/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16831 https://issues.apache.org/jira/browse/AMBARI-16831 Repository: ambari Description --- Include deletable master components. Diffs - ambari-web/app/controllers/main/host/details.js b16ef46 ambari-web/app/messages.js fe5a301 Diff: https://reviews.apache.org/r/47751/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27834 tests complete (33 seconds) 154 tests pending Thanks, Richard Zang
Review Request 47677: AMBARI-16804 - Refactor Move Master Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47677/ --- Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-16804 https://issues.apache.org/jira/browse/AMBARI-16804 Repository: ambari Description --- Refactor Move Master wizard. Extract configurable texts and stack related definitions into a separate JS file. Diffs - ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394 ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c ambari-web/app/data/wizards/move_master.js PRE-CREATION ambari-web/app/routes/reassign_master_routes.js f079432 ambari-web/app/templates/main/service/reassign.hbs 2477229 ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a ambari-web/app/views/main/service/reassign/step5_view.js 066b23b ambari-web/app/views/main/service/reassign/step6_view.js 33f8851 ambari-web/app/views/main/service/reassign/step7_view.js 60b357a ambari-web/test/controllers/main/service/reassign/step1_controller_test.js a43d91f ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d6ef9dc Diff: https://reviews.apache.org/r/47677/diff/ Testing --- Manually tested on live cluster. All unit tests passed. 27828 tests complete (28 seconds) 154 tests pending Thanks, Richard Zang
Re: Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47523/#review133822 --- Ship it! Ship It! - Richard Zang On May 18, 2016, 6:10 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47523/ > --- > > (Updated May 18, 2016, 6:10 a.m.) > > > Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-16725 > https://issues.apache.org/jira/browse/AMBARI-16725 > > > Repository: ambari > > > Description > --- > > RECOVERY alert types do not have a connection timeout, therefore, this should > not be shown in the UI (and not have an error because it's blank). > > > Diffs > - > > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 617f7cc > > Diff: https://reviews.apache.org/r/47523/diff/ > > > Testing > --- > > Local ambari-web test passed. > 27819 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
