Review Request 59941: Upgrade PreUpgradeCheck NullPointerException
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59941/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-21208 https://issues.apache.org/jira/browse/AMBARI-21208 Repository: ambari Description --- java.lang.NullPointerException at org.apache.ambari.server.state.stack.UpgradePack.getPrerequisiteChecks(UpgradePack.java:151) Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b8e57c7 Diff: https://reviews.apache.org/r/59941/diff/1/ Testing --- Done! Thanks, wang yaoxin
Review Request 57415: description incorrect for result class
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57415/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-20356 https://issues.apache.org/jira/browse/AMBARI-20356 Repository: ambari Description --- ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java "the results of the request a a Tree structure" should be "the results of the request as a Tree structure" Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java 8355dcf Diff: https://reviews.apache.org/r/57415/diff/1/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
> On 三月 6, 2017, 4:47 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml > > Lines 99-109 (patched) > > <https://reviews.apache.org/r/57326/diff/1/?file=1656518#file1656518line99> > > > > Are these _new_ properties used anywhere? > > wang yaoxin wrote: > These new properties are not used . These new properties are not being used elsewhere - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57326/#review167997 --- On 三月 7, 2017, 2:59 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57326/ > --- > > (Updated 三月 7, 2017, 2:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle. > > > Bugs: AMBARI-18892 > https://issues.apache.org/jira/browse/AMBARI-18892 > > > Repository: ambari > > > Description > --- > > when ambari enables kerberos, storm service ,nimbus_keytab and > nimbus_principal_name will duplicate > > > Diffs > - > > ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json > 20cc32d > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > fa2f6db > ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b > > > Diff: https://reviews.apache.org/r/57326/diff/2/ > > > Testing > --- > > done? > > > File Attachments > > > storm.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png > > > Thanks, > > wang yaoxin > >
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
> On 三月 6, 2017, 4:47 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml > > Lines 99-109 (patched) > > <https://reviews.apache.org/r/57326/diff/1/?file=1656518#file1656518line99> > > > > Are these _new_ properties used anywhere? These new properties are not used . - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57326/#review167997 --- On 三月 7, 2017, 2:59 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57326/ > --- > > (Updated 三月 7, 2017, 2:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle. > > > Bugs: AMBARI-18892 > https://issues.apache.org/jira/browse/AMBARI-18892 > > > Repository: ambari > > > Description > --- > > when ambari enables kerberos, storm service ,nimbus_keytab and > nimbus_principal_name will duplicate > > > Diffs > - > > ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json > 20cc32d > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > fa2f6db > ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b > > > Diff: https://reviews.apache.org/r/57326/diff/2/ > > > Testing > --- > > done? > > > File Attachments > > > storm.png > > https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png > > > Thanks, > > wang yaoxin > >
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57326/ --- (Updated 三月 7, 2017, 2:59 a.m.) Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle. Bugs: AMBARI-18892 https://issues.apache.org/jira/browse/AMBARI-18892 Repository: ambari Description --- when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate Diffs (updated) - ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b Diff: https://reviews.apache.org/r/57326/diff/2/ Changes: https://reviews.apache.org/r/57326/diff/1-2/ Testing --- done? File Attachments storm.png https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png Thanks, wang yaoxin
Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57326/ --- Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle. Bugs: AMBARI-18892 https://issues.apache.org/jira/browse/AMBARI-18892 Repository: ambari Description --- when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml 4cfe3d5 ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b Diff: https://reviews.apache.org/r/57326/diff/1/ Testing --- done? File Attachments storm.png https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png Thanks, wang yaoxin
Re: Review Request 53943: Improve remoteIp in audit log
> On 十一月 29, 2016, 3:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 53-55 > > <https://reviews.apache.org/r/53943/diff/3/?file=1571806#file1571806line53> > > > > This would actually do indexOf twice in cases where there are 2 or more > > IPs. > > > > Why not just make a method called something like > > normalizeIPAddress(String address) which either returns the string or > > returns the indexOf. > > > > This way, you only do it once. Hi Jonathan, Thanks for your suggestion, but this method likely requires to be invoked twice, unless define a variable - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157255 ------- On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > --- > > (Updated 十一月 29, 2016, 12:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > --- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > --- > > RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 > > > Thanks, > > wang yaoxin > >
Re: Review Request 53943: Improve remoteIp in audit log
> On 十一月 29, 2016, 11:55 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > <https://reviews.apache.org/r/53943/diff/2/?file=1571575#file1571575line87> > > > > unnecessary space before `;` Thanks Attila, I have modified my code - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157224 --- On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > --- > > (Updated 十一月 29, 2016, 12:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > --- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > --- > > RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 > > > Thanks, > > wang yaoxin > >
Re: Review Request 53943: Improve remoteIp in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:16 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. Changes --- Improve the description Bugs: AMBARI-18944 https://issues.apache.org/jira/browse/AMBARI-18944 Repository: ambari Description --- Mutil-agent were configured in some production environments, RemoteIp therefore will obtain mutilple IP addresses, like (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 0ac782f ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing --- RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 Thanks, wang yaoxin
Re: Review Request 53943: Improve remoteIp in audit log
> On 十一月 28, 2016, 4:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > <https://reviews.apache.org/r/53943/diff/1/?file=1567664#file1567664line88> > > > > 255.255.255.255 - 15 characters. But this is still not a very effective > > way to determine if the string contains 2 or more IPs. Just do the indexOf > > check instead. Thanks Jonathan ,I have modified my code - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157051 --- On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > --- > > (Updated 十一月 29, 2016, 12:57 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > --- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > --- > > test done! > > > Thanks, > > wang yaoxin > >
Re: Review Request 53943: Improve remoteIp in audit log
> On 十一月 28, 2016, 2:34 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > <https://reviews.apache.org/r/53943/diff/1/?file=1567664#file1567664line88> > > > > Why is this needed and where the 15 comes from? Thanks Sebastian ,I have modified my code and run the RequestUtilsTest ,All Tests Passsed ,Process finished with exit code 0 - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157029 --- On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > --- > > (Updated 十一月 29, 2016, 12:57 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > --- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > --- > > test done! > > > Thanks, > > wang yaoxin > >
Re: Review Request 53943: Improve remoteIp in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 1:04 a.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18944 https://issues.apache.org/jira/browse/AMBARI-18944 Repository: ambari Description --- Mutil-agent were configured in some production environments, RemoteIp therefore will obtain mutilple IP addresses, like (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. Diffs - ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 0ac782f ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing (updated) --- RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 Thanks, wang yaoxin
Re: Review Request 53943: Improve remoteIp in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:57 a.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. Changes --- Just do the indexOf check instead Bugs: AMBARI-18944 https://issues.apache.org/jira/browse/AMBARI-18944 Repository: ambari Description --- Mutil-agent were configured in some production environments, RemoteIp therefore will obtain mutilple IP addresses, like (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 0ac782f ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing --- test done! Thanks, wang yaoxin
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- (Updated 十一月 21, 2016, 7:52 a.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18441 https://issues.apache.org/jira/browse/AMBARI-18441 Repository: ambari Description --- My first upgrade test failed due to my environment issue. Since in real production environment this failure would occur again. ambari upgrade to 2.1.1 and later version, if the first time failed , excute ambari-server upgrade again will error duplicate key value violates unique constraint "pk_hostcomponentstate". Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! File Attachments AMBARI-18441-02.patch https://reviews.apache.org/media/uploaded/files/2016/11/16/4c6f3d15-96cc-4c22-babe-b45b103a8c30__AMBARI-18441-02.patch Thanks, wang yaoxin
Review Request 53943: Improve remoteIp in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18944 https://issues.apache.org/jira/browse/AMBARI-18944 Repository: ambari Description --- Mutil-agent were configured in some production environments, RemoteIp therefore will obtain mutilple IP addresses, like (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. Diffs - ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 0ac782f ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing --- test done! Thanks, wang yaoxin
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
> On 九月 27, 2016, 12:39 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java,
> > lines 225-226
> > <https://reviews.apache.org/r/52155/diff/2/?file=1508852#file1508852line225>
> >
> > This doesn't guarantee ordering of any kind - the first one which comes
> > back could have an ID of 9. Since it doesn't match `m_hcsId`, this code
> > would try to update it to to a value of 1 and possibly cause duplicates.
> >
> > You can simply skip this whole section of updating if the
> > `resultSet.getLong("id")` is non-null/non-zero.
> >
> > You can then so something like this:
> > `m_hcsId.set(NumberUtils.max(m_hcsId.get(), idKey)`
>
> wang yaoxin wrote:
> Hi Jonathan ,Thanks for your advice, that is highly appreciated. However,
> consider the randomness of the value of idKey, my method may avoid this
> issue. For instance, if the first-time get value of resultSet.getLong("id")
> is 2, and the second-time get value is 1, then basing on your method, the
> duplicates error would still occur. Hope we could get further agreement on
> this case, thanks.
>
> Jonathan Hurley wrote:
> The problem here is on the 2nd time through, correct? If the first time
> through it only did half of them (for some reason) then you're left with some
> rows having an ID and some not. My point is to totally skip rows which have a
> valid ID - you can sort by ID so you go through all of them first,
> incrementing m_hceId along the way. This way, you're going to be guaranteed
> to go through your non-zero IDs first and when you finally hit your first
> null ID, you're atomic counter is ready to pickup.
Hi Jonathan ,Thanks for? I understand what you mean, and I've made the
modification basing on your advice in AMBARI-18441-02.patch
- wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/#review150545
---
On 九月 27, 2016, 12:03 p.m., wang yaoxin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52155/
> ---
>
> (Updated 九月 27, 2016, 12:03 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton,
> and Sebastian Toader.
>
>
> Bugs: AMBARI-18441
> https://issues.apache.org/jira/browse/AMBARI-18441
>
>
> Repository: ambari
>
>
> Description
> ---
>
> My first upgrade test failed due to my environment issue. Since in real
> production environment this failure would occur again.
>
> ambari upgrade to 2.1.1 and later version, if the first time failed , excute
> ambari-server upgrade again will error duplicate key value violates unique
> constraint "pk_hostcomponentstate".
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
> db13612
>
> Diff: https://reviews.apache.org/r/52155/diff/
>
>
> Testing
> ---
>
> the unit test is UpgradeCatalog211Test.java: Process finished with exit code
> 0.
> done !
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- (Updated 十一月 16, 2016, 6:49 a.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18441 https://issues.apache.org/jira/browse/AMBARI-18441 Repository: ambari Description --- My first upgrade test failed due to my environment issue. Since in real production environment this failure would occur again. ambari upgrade to 2.1.1 and later version, if the first time failed , excute ambari-server upgrade again will error duplicate key value violates unique constraint "pk_hostcomponentstate". Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! File Attachments (updated) AMBARI-18441-02.patch https://reviews.apache.org/media/uploaded/files/2016/11/16/4c6f3d15-96cc-4c22-babe-b45b103a8c30__AMBARI-18441-02.patch Thanks, wang yaoxin
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
> On 九月 27, 2016, 12:39 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java,
> > lines 225-226
> > <https://reviews.apache.org/r/52155/diff/2/?file=1508852#file1508852line225>
> >
> > This doesn't guarantee ordering of any kind - the first one which comes
> > back could have an ID of 9. Since it doesn't match `m_hcsId`, this code
> > would try to update it to to a value of 1 and possibly cause duplicates.
> >
> > You can simply skip this whole section of updating if the
> > `resultSet.getLong("id")` is non-null/non-zero.
> >
> > You can then so something like this:
> > `m_hcsId.set(NumberUtils.max(m_hcsId.get(), idKey)`
Hi Jonathan ,Thanks for your advice, that is highly appreciated. However,
consider the randomness of the value of idKey, my method may avoid this issue.
For instance, if the first-time get value of resultSet.getLong("id") is 2, and
the second-time get value is 1, then basing on your method, the duplicates
error would still occur. Hope we could get further agreement on this case,
thanks.
- wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/#review150545
---
On 九月 27, 2016, 12:03 p.m., wang yaoxin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52155/
> ---
>
> (Updated 九月 27, 2016, 12:03 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton,
> and Sebastian Toader.
>
>
> Bugs: AMBARI-18441
> https://issues.apache.org/jira/browse/AMBARI-18441
>
>
> Repository: ambari
>
>
> Description
> ---
>
> My first upgrade test failed due to my environment issue. Since in real
> production environment this failure would occur again.
>
> ambari upgrade to 2.1.1 and later version, if the first time failed , excute
> ambari-server upgrade again will error duplicate key value violates unique
> constraint "pk_hostcomponentstate".
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
> db13612
>
> Diff: https://reviews.apache.org/r/52155/diff/
>
>
> Testing
> ---
>
> the unit test is UpgradeCatalog211Test.java: Process finished with exit code
> 0.
> done !
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- (Updated 九月 27, 2016, 12:03 p.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18441 https://issues.apache.org/jira/browse/AMBARI-18441 Repository: ambari Description (updated) --- My first upgrade test failed due to my environment issue. Since in real production environment this failure would occur again. ambari upgrade to 2.1.1 and later version, if the first time failed , excute ambari-server upgrade again will error duplicate key value violates unique constraint "pk_hostcomponentstate". Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! Thanks, wang yaoxin
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
> On 九月 22, 2016, 4:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > lines 204-207 > > <https://reviews.apache.org/r/52155/diff/1/?file=1508029#file1508029line204> > > > > Wouldn't this prevent the method from being executed again? > > wang yaoxin wrote: > My first upgrade test failed due to my environment issue. Since in real > production environment this failure would occur again, I am now submit the > patch for the purpose of optimizing the entire section of code Thnaks ,Jonathan ! - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150021 ------- On 九月 23, 2016, 4:58 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52155/ > --- > > (Updated 九月 23, 2016, 4:58 a.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-18441 > https://issues.apache.org/jira/browse/AMBARI-18441 > > > Repository: ambari > > > Description > --- > > ambari upgrade to 2.1.1, if the first time failed , excute ambari-server > upgrade again will error duplicate key value violates unique constraint > "pk_hostcomponentstate". > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java > db13612 > > Diff: https://reviews.apache.org/r/52155/diff/ > > > Testing > --- > > the unit test is UpgradeCatalog211Test.java: Process finished with exit code > 0. > done ! > > > Thanks, > > wang yaoxin > >
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
> On 九月 22, 2016, 4:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > lines 204-207 > > <https://reviews.apache.org/r/52155/diff/1/?file=1508029#file1508029line204> > > > > Wouldn't this prevent the method from being executed again? My first upgrade test failed due to my environment issue. Since in real production environment this failure would occur again, I am now submit the patch for the purpose of optimizing the entire section of code - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150021 ------- On 九月 22, 2016, 11:08 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52155/ > --- > > (Updated 九月 22, 2016, 11:08 a.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-18441 > https://issues.apache.org/jira/browse/AMBARI-18441 > > > Repository: ambari > > > Description > --- > > ambari upgrade to 2.1.1, if the first time failed , excute ambari-server > upgrade again will error duplicate key value violates unique constraint > "pk_hostcomponentstate". > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java > db13612 > > Diff: https://reviews.apache.org/r/52155/diff/ > > > Testing > --- > > the unit test is UpgradeCatalog211Test.java: Process finished with exit code > 0. > done ! > > > Thanks, > > wang yaoxin > >
Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- (Updated 九月 23, 2016, 4:58 a.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18441 https://issues.apache.org/jira/browse/AMBARI-18441 Repository: ambari Description --- ambari upgrade to 2.1.1, if the first time failed , excute ambari-server upgrade again will error duplicate key value violates unique constraint "pk_hostcomponentstate". Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! Thanks, wang yaoxin
Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18441 https://issues.apache.org/jira/browse/AMBARI-18441 Repository: ambari Description --- ambari upgrade to 2.1.1, if the first time failed , excute ambari-server upgrade again will error duplicate key value violates unique constraint "pk_hostcomponentstate". Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! Thanks, wang yaoxin
Re: Review Request 49802: Host Namenode Rebalance HDFS failed
> On 九月 14, 2016, 5:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py, > > line 283 > > <https://reviews.apache.org/r/49802/diff/2/?file=1498248#file1498248line283> > > > > Why would the json data be None? Rebalance HDFS in the host web view, it will not show the Rebalance HDFS dialog to fill the disk capacity value, so the default threshold should be the default value, but the namenode.py not given a default value, so rebalance hdfs wil fail. It would be difficult to change from fore-end, moreover, the change may not fit into fore-end's design ,and I sense the bug is a serious issue, so I think it is better to give it the default value in the namenode.py . - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49802/#review148934 --- On 九月 14, 2016, 8:07 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49802/ > --- > > (Updated 九月 14, 2016, 8:07 a.m.) > > > Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW > JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako. > > > Bugs: AMBARI-17546 > https://issues.apache.org/jira/browse/AMBARI-17546 > > > Repository: ambari > > > Description > --- > > the host view ,excute namenode rebalance HDFS, json none lead fail > > Rebalance HDFS in the host web view , it will not show the Rebalance HDFS > dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would > be difficult to change from fore-end, moreover, the change may not fit into > fore-end's design ,and I sense the bug is a serious issue, so I think it is > better to give it the default value in the namenode.py . > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > df02311 > > Diff: https://reviews.apache.org/r/49802/diff/ > > > Testing > --- > > done > > > Thanks, > > wang yaoxin > >
Re: Review Request 51843: rolling restart datanode cluster name in audit log show null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- (Updated 九月 18, 2016, 9:20 a.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18374 https://issues.apache.org/jira/browse/AMBARI-18374 Repository: ambari Description --- when rolling restart services ( eg:DataNode ) ,cluster name in audit log show null 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), Operation(Request from server), RequestType(POST), url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 Accepted), Command(RESTART), Cluster name(null) 2016-09-13T17:29:22.042+0800, User(admin), Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), RequestId(15) Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java 1074f0e Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 51843: rolling restart datanode cluster name in audit log show null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- (Updated 九月 16, 2016, 1:44 p.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Changes --- the new patch Bugs: AMBARI-18374 https://issues.apache.org/jira/browse/AMBARI-18374 Repository: ambari Description --- when rolling restart services ( eg:DataNode ) ,cluster name in audit log show null 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), Operation(Request from server), RequestType(POST), url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 Accepted), Command(RESTART), Cluster name(null) 2016-09-13T17:29:22.042+0800, User(admin), Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), RequestId(15) Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java 1074f0e Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 51843: rolling restart datanode cluster name in audit log show null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- (Updated 九月 16, 2016, 12:54 p.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18374 https://issues.apache.org/jira/browse/AMBARI-18374 Repository: ambari Description --- when rolling restart services ( eg:DataNode ) ,cluster name in audit log show null 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), Operation(Request from server), RequestType(POST), url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 Accepted), Command(RESTART), Cluster name(null) 2016-09-13T17:29:22.042+0800, User(admin), Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), RequestId(15) Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java 1074f0e Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 51843: rolling restart datanode cluster name in audit log show null
> On 九月 16, 2016, 10:58 a.m., Oliver Szabo wrote: > > after applying the diff i got: > > [ERROR] > > /Users/oszabo/prj/ambari/ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java:[103,5] > > cannot find symbol > > symbol: class Map > > location: class > > org.apache.ambari.server.audit.request.eventcreator.RequestEventCreator > > > > I think java.util.Map is not imported in the RequestEventCreator Hi ,Oliver, thank you for your kind-hearted offer, I have attach a new patch AMBARI-18374_02.patch - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/#review149186 ------- On 九月 16, 2016, 10:06 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51843/ > --- > > (Updated 九月 16, 2016, 10:06 a.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-18374 > https://issues.apache.org/jira/browse/AMBARI-18374 > > > Repository: ambari > > > Description > --- > > when rolling restart services ( eg:DataNode ) ,cluster name in audit log show > null > > 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), > Operation(Request from server), RequestType(POST), > url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 > Accepted), Command(RESTART), Cluster name(null) > > 2016-09-13T17:29:22.042+0800, User(admin), > Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), > RequestId(15) > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java > 075e328 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java > 1074f0e > > Diff: https://reviews.apache.org/r/51843/diff/ > > > Testing > --- > > done! > > > Thanks, > > wang yaoxin > >
Re: Review Request 51843: rolling restart datanode cluster name in audit log show null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- (Updated 九月 16, 2016, 10:06 a.m.) Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18374 https://issues.apache.org/jira/browse/AMBARI-18374 Repository: ambari Description --- when rolling restart services ( eg:DataNode ) ,cluster name in audit log show null 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), Operation(Request from server), RequestType(POST), url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 Accepted), Command(RESTART), Cluster name(null) 2016-09-13T17:29:22.042+0800, User(admin), Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), RequestId(15) Diffs - ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java 1074f0e Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 49802: Host Namenode Rebalance HDFS failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49802/ --- (Updated 九月 14, 2016, 8:07 a.m.) Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW JaimejucoummaUW, Zhe (Joe) Wang, Kuldeep Mishra, and Yusaku Sako. Changes --- It would be difficult to change from fore-end, moreover, the change may not fit into fore-end's design ,and I sense the bug is a serious issue Bugs: AMBARI-17546 https://issues.apache.org/jira/browse/AMBARI-17546 Repository: ambari Description (updated) --- the host view ,excute namenode rebalance HDFS, json none lead fail Rebalance HDFS in the host web view , it will not show the Rebalance HDFS dialog to fill the disk capacity value, so rebalance hdfs wil fail. It would be difficult to change from fore-end, moreover, the change may not fit into fore-end's design ,and I sense the bug is a serious issue, so I think it is better to give it the default value in the namenode.py . Diffs (updated) - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py df02311 Diff: https://reviews.apache.org/r/49802/diff/ Testing --- done Thanks, wang yaoxin
Review Request 51843: rolling restart datanode cluster name in audit log show null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian Toader. Bugs: AMBARI-18374 https://issues.apache.org/jira/browse/AMBARI-18374 Repository: ambari Description --- when rolling restart services ( eg:DataNode ) ,cluster name in audit log show null 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), Operation(Request from server), RequestType(POST), url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 Accepted), Command(RESTART), Cluster name(null) 2016-09-13T17:29:22.042+0800, User(admin), Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), RequestId(15) Diffs - ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin
Re: Review Request 49804: improve resourcemanager HA description
> On 九月 12, 2016, 9:08 a.m., Aleksandr Kovalenko wrote: > > ambari-web/app/models/host_component.js, line 333 > > <https://reviews.apache.org/r/49804/diff/1/?file=1439630#file1439630line333> > > > > What is the reason for this change? > > Why we decide to not show Enable label if HA is already enabled? Thank you ,Aleksandr . Just like the NameNode HA , it's better to decide the RM Enable lable and cssClass - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/#review148468 --- On 九月 12, 2016, 3:24 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49804/ > --- > > (Updated 九月 12, 2016, 3:24 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko, jun aoki, Zhe (Joe) Wang, > Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-17518 > https://issues.apache.org/jira/browse/AMBARI-17518 > > > Repository: ambari > > > Description > --- > > improve the resourcemanager HA description > > > Diffs > - > > ambari-web/app/models/host_component.js 973b809 > > Diff: https://reviews.apache.org/r/49804/diff/ > > > Testing > --- > > done > > > Thanks, > > wang yaoxin > >
Re: Review Request 49804: improve resourcemanager HA description
> On 九月 6, 2016, 7:41 p.m., Nate Cole wrote: > > Ship It! Thank you , but I don't have the authority to ship, so i will trouble you to commit the patch! - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/#review147904 --- On 九月 6, 2016, 9:57 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49804/ > --- > > (Updated 九月 6, 2016, 9:57 a.m.) > > > Review request for Ambari, jun aoki, Nate Cole, and Srimanth Gunturi. > > > Bugs: AMBARI-17518 > https://issues.apache.org/jira/browse/AMBARI-17518 > > > Repository: ambari > > > Description > --- > > improve the resourcemanager HA description > > > Diffs > - > > ambari-web/app/models/host_component.js 973b809 > > Diff: https://reviews.apache.org/r/49804/diff/ > > > Testing > --- > > done > > > Thanks, > > wang yaoxin > >
Re: Review Request 51422: ExtensionModeule's description is not corrent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51422/#review147280 --- Ship it! Ship It! - wang yaoxin On 八月 30, 2016, 9:07 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51422/ > --- > > (Updated 八月 30, 2016, 9:07 a.m.) > > > Review request for Ambari, Jaimin Jetly, Myroslav Papirkovskyy, Srimanth > Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako. > > > Bugs: AMBARI-18259 > https://issues.apache.org/jira/browse/AMBARI-18259 > > > Repository: ambari > > > Description > --- > > ExtensionModeule's description is not corrent > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java > 1fc5b0e > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java > e3f8d0d > > Diff: https://reviews.apache.org/r/51422/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Review Request 50742: operationStatus and taskStatus audit log should contain remoteIp message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50742/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Repository: ambari Description --- OperationStatusAuditEvent and TaskStatusAuditEvent auditlog message should contain the remoteip info, store in the pg table host_role_command Diffs - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java b44dc78 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java ff2ce92 ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java fd0068e ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java 1682e74 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 6288091 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0843616 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 43bdef9 ambari-server/src/test/java/org/apache/ambari/server/audit/OperationStatusAuditEventTest.java 038cebc ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java 8f769c7 Diff: https://reviews.apache.org/r/50742/diff/ Testing --- done Thanks, wang yaoxin
Review Request 50067: Error message does not deliver when executing ambari-server command as a non-root user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50067/ --- Review request for Ambari. Bugs: AMBARI-17728 https://issues.apache.org/jira/browse/AMBARI-17728 Repository: ambari Description --- non-root user: like hdfs excute : ambari-server stop show : Using python /usr/bin/python2.6 Stopping ambari-server intent to: You can't perform this operation as non-sudoer user. Please, re-login or configure sudo access for this user Diffs - ambari-server/sbin/ambari-server 81cf53b Diff: https://reviews.apache.org/r/50067/diff/ Testing --- done! Thanks, wang yaoxin
Review Request 49944: optimize log description of ambari agent stop
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49944/ --- Review request for Ambari. Bugs: AMBARI-17668 https://issues.apache.org/jira/browse/AMBARI-17668 Repository: ambari Description --- excute ambari agent ?going to execute kill -9?but none output log Diffs - ambari-agent/src/main/python/ambari_agent/main.py 1fc445e Diff: https://reviews.apache.org/r/49944/diff/ Testing --- done Thanks, wang yaoxin
Review Request 49804: improve resourcemanager HA description
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/ --- Review request for Ambari. Bugs: AMBARI-17518 https://issues.apache.org/jira/browse/AMBARI-17518 Repository: ambari Description --- improve the resourcemanager HA description Diffs - ambari-web/app/models/host_component.js 973b809 Diff: https://reviews.apache.org/r/49804/diff/ Testing --- done Thanks, wang yaoxin
Review Request 49802: Host Namenode Rebalance HDFS failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49802/ --- Review request for Ambari. Bugs: AMBARI-17546 https://issues.apache.org/jira/browse/AMBARI-17546 Repository: ambari Description --- the host view ,excute namenode rebalance HDFS, json none lead fail Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py df02311 Diff: https://reviews.apache.org/r/49802/diff/ Testing --- done Thanks, wang yaoxin
