Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-18 Thread Nahappan Somasundaram 


> On Jan. 18, 2017, 7:07 a.m., Jonathan Hurley wrote:
> > I see that you ran `mvn test -Dtest=ServicePropertiesTest 
> > -DskipPythonTests` ... but these changes are in Python ... Can you add a 
> > Python test to make sure that the JCEKS file copy is invoked properly?

The second test I ran was ** mvn test ** which ran the entire java and python 
tests successfully. Forgot to update the Testing Done section.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review162112
---


On Jan. 17, 2017, 5:03 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 17, 2017, 5:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
>  8282dc547f6bdbea3236f2dcc65e740354f41f74 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  82bb30179009d91a1dcc31d1c5c361ef4eea08a9 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-18 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review162112
---



I see that you ran `mvn test -Dtest=ServicePropertiesTest -DskipPythonTests` 
... but these changes are in Python ... Can you add a Python test to make sure 
that the JCEKS file copy is invoked properly?

- Jonathan Hurley


On Jan. 17, 2017, 8:03 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 17, 2017, 8:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
>  8282dc547f6bdbea3236f2dcc65e740354f41f74 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  82bb30179009d91a1dcc31d1c5c361ef4eea08a9 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review162111
---



This requires tests to cover the added code path.

- Nate Cole


On Jan. 17, 2017, 8:03 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 17, 2017, 8:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
>  8282dc547f6bdbea3236f2dcc65e740354f41f74 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  82bb30179009d91a1dcc31d1c5c361ef4eea08a9 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-17 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 17, 2017, 5:03 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Fixed UT failure. Added comments to security_commons function.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
 8282dc547f6bdbea3236f2dcc65e740354f41f74 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 82bb30179009d91a1dcc31d1c5c361ef4eea08a9 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-17 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 17, 2017, 2:55 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Refactor update_credential_provider_path() into security_common.py


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
 8282dc547f6bdbea3236f2dcc65e740354f41f74 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 82bb30179009d91a1dcc31d1c5c361ef4eea08a9 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-17 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161984
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (lines 54 - 80)


Can this logic be extraced out to a common location? It seems largly 
duplicated.


- Jonathan Hurley


On Jan. 17, 2017, 3:48 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 17, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  82bb30179009d91a1dcc31d1c5c361ef4eea08a9 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-17 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 17, 2017, 12:48 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Indentation of return params['configurations'][config_type] should be outside 
the **if** statement. This caused UTs to break and default installation of HIVE 
to fail.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 82bb30179009d91a1dcc31d1c5c361ef4eea08a9 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-17 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161924
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (lines 53 - 61)


Looks to be largely duplicated code.  Can it be abstracted to 
security_commons.py?  I'd hate to have to remember to do fixes in several 
places.  Would be nice to have some mocked out tests too.


- Nate Cole


On Jan. 16, 2017, 1:45 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 16, 2017, 1:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161781
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 16, 2017, 6:45 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 16, 2017, 6:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 10:45 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Use StaticFile() instead of shutil.move()


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161758
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 68)


Please replace
  shutil.move(src_provider_path, dest_provider_path)
File(dest_provider_path,
  owner = params.oozie_user,
  group = params.user_group,
  mode = 0640
)

into

File(dest_provider_path,
  owner = params.oozie_user,
  group = params.user_group,
  mode = 0640,
  content = StaticFile(src_provider_path)
)


- Andrew Onischuk


On Jan. 16, 2017, 5:30 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 16, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 9:30 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Added Andrew Onishuk to the review.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
---

(Updated Jan. 16, 2017, 8:03 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Use the configuration directory specified in the stack scripts instead of 
hard-coding them in the configs.


Bugs: AMBARI-19545
https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
---

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 21135ea5c65563716dc1fe5db0d533970d9fdb53 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
---

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-14 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161649
---



Please disregard this patch. I'm going to revise this patch to copy and set the 
acl instead of adding the paths to the configurations.

- Nahappan Somasundaram


On Jan. 14, 2017, 12:14 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> ---
> 
> (Updated Jan. 14, 2017, 12:14 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
> https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 02f42123b9b392251e1315f930d63cb11c0de2c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
>  0ff268b47dcb687cbf8a07392f440b82182f8311 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
>  856941fec6bb8475c786251ad11c84c065be4c1b 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> ---
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>