Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On May 7, 2016, 7:31 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> >  line 280
> > 
> >
> > We should add this to HDP25StackAdvisor instead?
> > 
> > 
> > ambari/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py

The method recommendHadoopProxyUsers is for hadoop configuration. I feel it is 
better to put it here. Otherwise I have to copy&paste part of code in 
recommendHadoopProxyUsers to HDP25StackAdvisor.py which is not good for code 
reuse and maintenance.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review132146
---


On May 7, 2016, 3:09 p.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 7, 2016, 3:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6e506a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On May 7, 2016, 7:27 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py,
> >  line 40
> > 
> >
> > Why 5?

5 should be enough for this kind of service check.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review132144
---


On May 7, 2016, 3:09 p.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 7, 2016, 3:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6e506a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47074/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-16290
https://issues.apache.org/jira/browse/AMBARI-16290


Repository: ambari


Description
---

**Problem Statement :**
1) Hive Restart fails to create repository in Ranger and goes for retries due 
to missing principal after enabling hive plugin in in kerberized environment.

2) Yarn Restart fails to create repository in Ranger in simple environment.

** Proposed Solution : **
1) Fixing principal required for hive server, adding new parameters required 
for Ranger service creation.
2) Fixing call for repository creation in simple environemnt.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 4f319ea 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 4a071ca 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 d3fc173 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 864d937 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 f42185e 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 72eb3ad 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 ec43fea 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 92eaaab 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 12ccef6 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 1dd25ce 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 c5f8940 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 d715a25 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 ba4c777 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 cf01965 

Diff: https://reviews.apache.org/r/47074/diff/


Testing
---

1) Verified Enable Hive Plugin and Ranger service creation after enabling 
plugin in kerberos / simple  environment.

2) Verified Enable Yarn Plugin and Ranger service creation after enabling 
plugin in simple  environment.


Thanks,

Gautam Borad

Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 

Diff: https://reviews.apache.org/r/47117/diff/


Testing
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Unit tests are still running locally...


Thanks,

Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132261
---


Ship it!




Ship It!

- Oliver Szabo


On May 9, 2016, 12:28 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132265
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
332)


Is there any function in python for min/max calculation instead of the "if" 
structure ...


- Laszlo Puskas


On May 9, 2016, 12:28 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Review Request 47118: Fixed Typo in logfeeder property name

[Hayat Behlim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47118/
---

Review request for Ambari.


Bugs: AMBARI-16304
https://issues.apache.org/jira/browse/AMBARI-16304


Repository: ambari


Description
---

Rename property logfeeder.solr.config.internal to logfeeder.solr.config.interval


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 e645a3d 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 22f3b78 

Diff: https://reviews.apache.org/r/47118/diff/


Testing
---


Thanks,

Hayat Behlim

Re: Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 9, 2016, 1:01 du)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 

Diff: https://reviews.apache.org/r/47117/diff/


Testing
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Unit tests are still running locally...


Thanks,

Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132266
---


Ship it!




Ship It!

- Laszlo Puskas


On May 9, 2016, 1:01 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 1:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132267
---


Ship it!




Ship It!

- Sumit Mohanty


On May 9, 2016, 1:01 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 1:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Review Request 47119: LogFeeder: enable/disable log level filter

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16305
https://issues.apache.org/jira/browse/AMBARI-16305


Repository: ambari


Description
---

Add abilliy to disable/enable log level filter on LogFeeder side (default: 
enabled)


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 2e92ab9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 97ad191 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 2408261 
  ambari-web/app/data/HDP2/site_properties.js 45c54a0 

Diff: https://reviews.apache.org/r/47119/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 47118: Fixed Typo in logfeeder property name

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47118/#review132270
---


Ship it!




Ship It!

- Oliver Szabo


On May 9, 2016, 12:53 p.m., Hayat Behlim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47118/
> ---
> 
> (Updated May 9, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16304
> https://issues.apache.org/jira/browse/AMBARI-16304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename property logfeeder.solr.config.internal to 
> logfeeder.solr.config.interval
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  e645a3d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  22f3b78 
> 
> Diff: https://reviews.apache.org/r/47118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hayat Behlim
> 
>

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47025/
---

(Updated May 9, 2016, 1:37 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added Remote Cluster Section in ambari-admin. This allows add, delete, create 
and listing of Remote Ambari Managed Cluster.
Added Remote Cluster section in View Instance Create/Edit page. This helps in 
linking view instance to a Remote Cluster


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html 8d7e8e7 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
 127bc74 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 480f85d 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersCreateCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
80a5352 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0566969 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
780352d 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4c81507 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 
eaff70b 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
4003137 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
f93867c 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47025/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/
---

(Updated May 9, 2016, 1:44 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updated patch as per comment.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added tables for Remote Cluster to create scripts.
Added table changes to UpgradeCatalog240


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f85a4c7 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
0f3a2c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7c85ba7 

Diff: https://reviews.apache.org/r/47026/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/
---

(Updated May 9, 2016, 1:48 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Removed commented code.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
(Can be Remote or Local) that is attached to view instance.
Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for differentiating 
cluster type attached to view instance.


Diffs (updated)
-

  
ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
 PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
ce91676 
  ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
  ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
0c3d3ce 
  ambari-views/src/main/resources/view.xsd 04902e9 
  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 7f1d489 
  contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
  
contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
 62fa21e 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 83eae9b 
  
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
 b4fccf9 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
 6b88b6f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java
 41dc88d 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
 c9f735a 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
 ec4df7d 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
 27e98f2 

Diff: https://reviews.apache.org/r/47027/diff/


Testing
---

Manual Testing


Thanks,

Gaurav Nagar

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/
---

(Updated May 9, 2016, 2 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

added logfeeder.solr.config.interval for fetching filter config


Bugs: AMBARI-16305
https://issues.apache.org/jira/browse/AMBARI-16305


Repository: ambari


Description
---

Add abilliy to disable/enable log level filter on LogFeeder side (default: 
enabled)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 2e92ab9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 97ad191 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 2408261 
  ambari-web/app/data/HDP2/site_properties.js 45c54a0 

Diff: https://reviews.apache.org/r/47119/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 9, 2016, 2:18 du)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Changes
---

Unit test report


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 

Diff: https://reviews.apache.org/r/47117/diff/


Testing (updated)
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)


Thanks,

Daniel Gergely

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/#review132276
---


Fix it, then Ship it!




Overal the patch looks fine to me, just with a few minor issues below that need 
clarification.

One additional question: How is the filter itself configured to a specific log 
level?  Shouldn't there be some new stack properties included that allow the 
user to select the levels to include in the filter? 

Thanks.


ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 275)


This property doesn't appear to be listed in the stack definition above.  

Is this intentional?



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 (line 21)


Should this property ever be configured by a user, or should this value 
always be "history"?


- Robert Nettleton


On May 9, 2016, 2 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47119/
> ---
> 
> (Updated May 9, 2016, 2 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16305
> https://issues.apache.org/jira/browse/AMBARI-16305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abilliy to disable/enable log level filter on LogFeeder side (default: 
> enabled)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  2e92ab9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  97ad191 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  2408261 
>   ambari-web/app/data/HDP2/site_properties.js 45c54a0 
> 
> Diff: https://reviews.apache.org/r/47119/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Oliver Szabo]

> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 275
> > 
> >
> > This property doesn't appear to be listed in the stack definition 
> > above.  
> > 
> > Is this intentional?

you right about that, i will remove it


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/#review132276
---


On May 9, 2016, 2 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47119/
> ---
> 
> (Updated May 9, 2016, 2 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16305
> https://issues.apache.org/jira/browse/AMBARI-16305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abilliy to disable/enable log level filter on LogFeeder side (default: 
> enabled)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  2e92ab9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  97ad191 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  2408261 
>   ambari-web/app/data/HDP2/site_properties.js 45c54a0 
> 
> Diff: https://reviews.apache.org/r/47119/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Robert Nettleton]

> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote:
> > Overal the patch looks fine to me, just with a few minor issues below that 
> > need clarification.
> > 
> > One additional question: How is the filter itself configured to a specific 
> > log level?  Shouldn't there be some new stack properties included that 
> > allow the user to select the levels to include in the filter? 
> > 
> > Thanks.
> 
> Oliver Szabo wrote:
> the levels can be found in logsearch.properties, logfeeder try to pull 
> the solr configs to gather these values

Ok, thanks for providing more info on this.  I'll remove the issues, since my 
questions have been answered.  

Thanks again!


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/#review132276
---


On May 9, 2016, 2 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47119/
> ---
> 
> (Updated May 9, 2016, 2 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16305
> https://issues.apache.org/jira/browse/AMBARI-16305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abilliy to disable/enable log level filter on LogFeeder side (default: 
> enabled)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  2e92ab9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  97ad191 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  2408261 
>   ambari-web/app/data/HDP2/site_properties.js 45c54a0 
> 
> Diff: https://reviews.apache.org/r/47119/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/
---

(Updated May 9, 2016, 2:51 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

remove history logs param


Bugs: AMBARI-16305
https://issues.apache.org/jira/browse/AMBARI-16305


Repository: ambari


Description
---

Add abilliy to disable/enable log level filter on LogFeeder side (default: 
enabled)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 2e92ab9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 97ad191 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 2408261 
  ambari-web/app/data/HDP2/site_properties.js 45c54a0 

Diff: https://reviews.apache.org/r/47119/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Oliver Szabo]

> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote:
> > Overal the patch looks fine to me, just with a few minor issues below that 
> > need clarification.
> > 
> > One additional question: How is the filter itself configured to a specific 
> > log level?  Shouldn't there be some new stack properties included that 
> > allow the user to select the levels to include in the filter? 
> > 
> > Thanks.

the levels can be found in logsearch.properties, logfeeder try to pull the solr 
configs to gather these values


> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2,
> >  line 21
> > 
> >
> > Should this property ever be configured by a user, or should this value 
> > always be "history"?

now, history collection is mostly hard coded in every level 
(logsearch/logfeeder), but later it will be configurable of course


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/#review132276
---


On May 9, 2016, 2 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47119/
> ---
> 
> (Updated May 9, 2016, 2 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16305
> https://issues.apache.org/jira/browse/AMBARI-16305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abilliy to disable/enable log level filter on LogFeeder side (default: 
> enabled)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  2e92ab9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  97ad191 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  2408261 
>   ambari-web/app/data/HDP2/site_properties.js 45c54a0 
> 
> Diff: https://reviews.apache.org/r/47119/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47118: Fixed Typo in logfeeder property name

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47118/#review132278
---


Ship it!




Ship It!

- Robert Nettleton


On May 9, 2016, 12:53 p.m., Hayat Behlim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47118/
> ---
> 
> (Updated May 9, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16304
> https://issues.apache.org/jira/browse/AMBARI-16304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename property logfeeder.solr.config.internal to 
> logfeeder.solr.config.interval
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  e645a3d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  22f3b78 
> 
> Diff: https://reviews.apache.org/r/47118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hayat Behlim
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132281
---


Ship it!




- Sebastian Toader


On May 9, 2016, 4:18 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 4:18 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
> (failing tests are not related to this issue)
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

[Jonathan Hurley]

> On May 6, 2016, 10:29 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 230
> > 
> >
> > Not using default? It's 100% guaranteed to be there?
> 
> Mugdha Varadkar wrote:
> These wont fail, because of the lazy failing implemented. CC @Andrew 
> Onishuk who had asked in one of the earlier RR to use this feature instead of 
> default().

I'm not following - if `ranger.tagsync.keystore.filename` isn't in the 
dictionary, then this line will absolutely throw an error.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47060/#review132031
---


On May 9, 2016, 1:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47060/
> ---
> 
> (Updated May 9, 2016, 1:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16285
> https://issues.apache.org/jira/browse/AMBARI-16285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 1) Renaming properties in ranger-tagsync-site.xml introduced in stack -2.5 
> followed by theme change.
> 2) Removed tagsync user password introduced in previous patch
> 3) Add default password in jceks for rangertagsync and rangerusersync
> 4) Derive tag source as ATLAS, if ATLAS is installed
> 5) Added new properties under ranger-ugsync-site.xml related to Policy 
> manager user's credentials in Ranger usersync service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  59190fe 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  1b56044 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  d013371 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ec0eea1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  08f6235 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
>  10ef1a8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml
>  d369098 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json
>  19411d4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
>   ambari-web/app/styles/widgets.less f385449 
> 
> Diff: https://reviews.apache.org/r/47060/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Tagsync on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

[Jonathan Hurley]

> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote:
> > ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java,
> >  line 28
> > 
> >
> > How is this different from AmbariStreamProvider which does not use an 
> > existing session? Isn't that the same thing as a remote Ambari cluster?
> 
> Gaurav Nagar wrote:
> AmbariClusterStreamProvider provides readFromAmbari and readFromCluster 
> methods to views for connecting to ambari cluster (remote or local).
> As view don't have much information about attached cluster (only 
> custer_handle which in remote case is just a name, not actually remote 
> cluster name), url formation for reading from cluster from view is not 
> possible. So need to expose above two methods.
> Also, view while requesting to ambari doesnot need to give useSession 
> variable which is not required in case of remote cluster.

I see where you're going with this, but it still seems odd that you're creating 
a brand new interface and implementation just to perform the same type of 
reading from a more specified endpoint. Couldn't you use the ViewContext to 
give you the cluster and then just build the URI and use an existing stream 
reader with it?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/#review132034
---


On May 9, 2016, 9:48 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47027/
> ---
> 
> (Updated May 9, 2016, 9:48 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
> (Can be Remote or Local) that is attached to view instance.
> Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for 
> differentiating cluster type attached to view instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
> ce91676 
>   ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> 0c3d3ce 
>   ambari-views/src/main/resources/view.xsd 04902e9 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  7f1d489 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
>   
> contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
>  62fa21e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  83eae9b 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  b4fccf9 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6b88b6f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java
>  41dc88d 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
>  c9f735a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
>  ec4df7d 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
>  27e98f2 
> 
> Diff: https://reviews.apache.org/r/47027/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

[Jonathan Hurley]

> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.
> 
> Jonathan Hurley wrote:
> I think that's implied though - what other kinds of remote clusters are 
> there?
> 
> Gaurav Nagar wrote:
> Currently we have only ambari managed. But in future we can have remote 
> clusters that are not managed by ambari also.

In that case, wouldn't it still be a remotecluster of a different type? Not a 
different table entirely?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 9, 2016, 9:44 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 9, 2016, 9:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132285
---


Ship it!




Ship It!

- Sandor Magyari


On May 9, 2016, 2:18 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 2:18 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
> (failing tests are not related to this issue)
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47074/#review132286
---



There should be python tests to cover the new code paths.

- Nate Cole


On May 9, 2016, 5:56 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47074/
> ---
> 
> (Updated May 9, 2016, 5:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16290
> https://issues.apache.org/jira/browse/AMBARI-16290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement :**
> 1) Hive Restart fails to create repository in Ranger and goes for retries due 
> to missing principal after enabling hive plugin in in kerberized environment.
> 
> 2) Yarn Restart fails to create repository in Ranger in simple environment.
> 
> ** Proposed Solution : **
> 1) Fixing principal required for hive server, adding new parameters required 
> for Ranger service creation.
> 2) Fixing call for repository creation in simple environemnt.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  4f319ea 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  4a071ca 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  864d937 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f42185e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  72eb3ad 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ec43fea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  92eaaab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  12ccef6 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  1dd25ce 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  c5f8940 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  ba4c777 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  cf01965 
> 
> Diff: https://reviews.apache.org/r/47074/diff/
> 
> 
> Testing
> ---
> 
> 1) Verified Enable Hive Plugin and Ranger service creation after enabling 
> plugin in kerberos / simple  environment.
> 
> 2) Verified Enable Yarn Plugin and Ranger service creation after enabling 
> plugin in simple  environment.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

[Jonathan Hurley]

> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.
> 
> Jonathan Hurley wrote:
> I think that's implied though - what other kinds of remote clusters are 
> there?
> 
> Gaurav Nagar wrote:
> Currently we have only ambari managed. But in future we can have remote 
> clusters that are not managed by ambari also.
> 
> Jonathan Hurley wrote:
> In that case, wouldn't it still be a remotecluster of a different type? 
> Not a different table entirely?

Discussed and it was my misunderstanding that remote clusters and remote ambari 
clusters wouldn't really share any common data, so there should separate tables 
for these (instead of a column type)


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 9, 2016, 9:44 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 9, 2016, 9:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all 
> > imports are there.
> 
> Juanjo  Marron wrote:
> Hi Jayush,
> 
> Thanks for the review.
> I'll add this couple of missing imports to ACCUMULO service check
> 
> I reviewed UTs, I did a fresh installation, no service-check run though. 
> Ill do service check as well from now. Any other test you think can be 
> required?
> 
> Also, Atlas installation was failing in trunk (even without this change 
> set) so I would need to retry on top of a stable trunk versions
> 
> Juanjo  Marron wrote:
> Please, wait review for now, more test on these services is being 
> performed
> Thanks

Hi Jasyuh, please could you review the final patch?

Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131209
---


On May 3, 2016, 6:12 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated May 3, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
>  b213028 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scri

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/
---

(Updated May 9, 2016, 5:09 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updated patch as suggested in comments.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote cluster 
credential.
Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
through ViewContextImpl.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 0b77511 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 4e7a032 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
 605f68d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 386e657 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 29dc2a7 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 2d6e5ba 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
 1dacd92 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 
ba7f446 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
d2d48a9 
  
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
 bb6a93c 
  ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
 8549d4a 
  
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
 a41e137 

Diff: https://reviews.apache.org/r/47023/diff/


Testing
---

Manual Testing


Thanks,

Gaurav Nagar

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/
---

(Updated May 9, 2016, 5:13 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updated patch as suggested in comments


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
(Can be Remote or Local) that is attached to view instance.
Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for differentiating 
cluster type attached to view instance.


Diffs (updated)
-

  
ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
 PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
ce91676 
  ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
  ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
0c3d3ce 
  ambari-views/src/main/resources/view.xsd 04902e9 
  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 7f1d489 
  contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
  
contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
 62fa21e 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 83eae9b 
  
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
 b4fccf9 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
 6b88b6f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java
 41dc88d 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
 c9f735a 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
 ec4df7d 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
 27e98f2 

Diff: https://reviews.apache.org/r/47027/diff/


Testing
---

Manual Testing


Thanks,

Gaurav Nagar

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

[Gaurav Nagar]

> On May 6, 2016, 5:53 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java,
> >  lines 83-86
> > 
> >
> > Is this really a M2M relationship? RemoteClusterServiceEntity are 
> > shared between clusters?

Yes RemoteClusterServiceEntity is shared between clusters.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/#review132081
---


On May 9, 2016, 5:09 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47023/
> ---
> 
> (Updated May 9, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote 
> cluster credential.
> Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
> Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
> through ViewContextImpl.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  0b77511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  4e7a032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  605f68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  386e657 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  29dc2a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2d6e5ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  1dacd92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  ba7f446 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d2d48a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  bb6a93c 
>   ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
>  8549d4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
>  a41e137 
> 
> Diff: https://reviews.apache.org/r/47023/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47119: LogFeeder: enable/disable log level filter

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47119/#review132306
---


Ship it!




Ship It!

- Miklos Gergely


On May 9, 2016, 2:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47119/
> ---
> 
> (Updated May 9, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16305
> https://issues.apache.org/jira/browse/AMBARI-16305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abilliy to disable/enable log level filter on LogFeeder side (default: 
> enabled)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  2e92ab9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  97ad191 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  2408261 
>   ambari-web/app/data/HDP2/site_properties.js 45c54a0 
> 
> Diff: https://reviews.apache.org/r/47119/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/#review132310
---


Ship it!





ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java (lines 25 - 
27)


Probably good to doc these as well.


- Jonathan Hurley


On May 9, 2016, 1:13 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47027/
> ---
> 
> (Updated May 9, 2016, 1:13 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
> (Can be Remote or Local) that is attached to view instance.
> Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for 
> differentiating cluster type attached to view instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
> ce91676 
>   ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> 0c3d3ce 
>   ambari-views/src/main/resources/view.xsd 04902e9 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  7f1d489 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
>   
> contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
>  62fa21e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  83eae9b 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  b4fccf9 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6b88b6f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java
>  41dc88d 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
>  c9f735a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
>  ec4df7d 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
>  27e98f2 
> 
> Diff: https://reviews.apache.org/r/47027/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 47130: Upgrade is blocked at 'Upgrade Options' wizard because of Service Checks requirement

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47130/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
Luniya.


Bugs: AMBARI-16380
https://issues.apache.org/jira/browse/AMBARI-16380


Repository: ambari


Description
---

The ServiceCheck prerequisite check was checking all service checks, not solely 
the most recent ones.  So even if Service Checks were run again, the prereq 
check was still failing on the old runs:

* Changed the query to only pull back SERVICE_CHECK records using a Predicate.
* Considered a stale config check, but that was adding complexity where none is 
needed (debatable).


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 8b39863 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
 4a3ae5c 

Diff: https://reviews.apache.org/r/47130/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/#review132312
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
 (lines 166 - 168)


Should this throw an exception if it can't be found?



ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 (lines 58 - 59)


What was wrong with getName() ? this seems a lot more likely to have 
problems



ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 (lines 71 - 80)


This returns a new cache every time it's called. This should be instantied 
as a member of the class instead.



ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
 (line 119)


You don't support any other type of primitive? integers, booleans?



ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
 (line 104)


Why is this transactional? The DAO should be transactional. This method is 
operating on a single entity.


- Jonathan Hurley


On May 9, 2016, 1:09 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47023/
> ---
> 
> (Updated May 9, 2016, 1:09 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote 
> cluster credential.
> Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
> Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
> through ViewContextImpl.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  0b77511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  4e7a032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  605f68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  386e657 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  29dc2a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2d6e5ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  1dacd92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  ba7f446 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d2d48a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  bb6a93c 
>   ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
>   
> 

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

[Jonathan Hurley]

> On May 6, 2016, 1:53 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java,
> >  lines 83-86
> > 
> >
> > Is this really a M2M relationship? RemoteClusterServiceEntity are 
> > shared between clusters?
> 
> Gaurav Nagar wrote:
> Yes RemoteClusterServiceEntity is shared between clusters.

Does it need to be? If you kept it 1:M so that a single remote cluster had a 
bunch of remote services, but those services were only for that cluster, it 
would make keeping the bi-directional relationship simpler.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/#review132081
---


On May 9, 2016, 1:09 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47023/
> ---
> 
> (Updated May 9, 2016, 1:09 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote 
> cluster credential.
> Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
> Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
> through ViewContextImpl.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  0b77511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  4e7a032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  605f68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  386e657 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  29dc2a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2d6e5ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  1dacd92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  ba7f446 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d2d48a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  bb6a93c 
>   ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
>  8549d4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
>  a41e137 
> 
> Diff: https://reviews.apache.org/r/47023/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
>

Review Request 47134: HAWQ Password handling updated

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/
---

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Bugs: AMBARI-16386
https://issues.apache.org/jira/browse/AMBARI-16386


Repository: ambari


Description
---

Updated salt used while creating HAWQ user, and also ensured that the password 
is treated exactly as entered on the HAWQ config ui.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 1bdc85a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 670a58b 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 

Diff: https://reviews.apache.org/r/47134/diff/


Testing
---

yes.
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,997 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-09 12:54:42,009 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-09 12:54:42,021 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Managemen

Re: Review Request 47130: Upgrade is blocked at 'Upgrade Options' wizard because of Service Checks requirement

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47130/
---

(Updated May 9, 2016, 3:55 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
Luniya.


Bugs: AMBARI-16380
https://issues.apache.org/jira/browse/AMBARI-16380


Repository: ambari


Description
---

The ServiceCheck prerequisite check was checking all service checks, not solely 
the most recent ones.  So even if Service Checks were run again, the prereq 
check was still failing on the old runs:

* Changed the query to only pull back SERVICE_CHECK records using a Predicate.
* Considered a stale config check, but that was adding complexity where none is 
needed (debatable).


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 8b39863 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
 4a3ae5c 

Diff: https://reviews.apache.org/r/47130/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4304, Failures: 0, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:25.682s
[INFO] Finished at: Mon May 09 15:46:16 EDT 2016
[INFO] Final Memory: 35M/700M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 47134: HAWQ Password handling updated

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132318
---


Ship it!




Ship It!

- Goutam Tadi


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016

Re: Review Request 47134: HAWQ Password handling updated

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 (line 53)


json.dumps ensures that quotes and special characters are escaped?

Did you consider && and giving an additional command? Or is this a new JIRA?


- Matt


On May 9, 2016, 12:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Runn

Re: Review Request 47134: HAWQ Password handling updated

[bhuvnesh chaudhary]

> On May 9, 2016, 8:06 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py,
> >  line 54
> > 
> >
> > json.dumps ensures that quotes and special characters are escaped?
> > 
> > Did you consider && and giving an additional command? Or is this a new 
> > JIRA?

It ensures that whatever is input is passed as a string as interpreted by bash. 
I tested && as well.
Some of the password which i tested..
"';//\p@ssw&&rd;touch abc.txt;
"';//p@ssw&&rd


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_ru

Review Request 47136: The 'krb5-conf' configuration is not available

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47136/
---

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Nate Cole, 
Sandor Magyari, and Sumit Mohanty.


Bugs: AMBARI-16397
https://issues.apache.org/jira/browse/AMBARI-16397


Repository: ambari


Description
---

Configuration is loaded:
```
06 May 2016 10:52:11,998  INFO [qtp-ambari-client-26] ClusterImpl:346 - Service 
config types loaded: {KAFKA=[ranger-kafka-policymgr-ssl, kafka-log4j, 
kafka-env, kafka-broker, ranger-kafka-security, ranger-kafka-plugin-properties, 
ranger-kafka-audit], PIG=[pig-properties, pig-env, pig-log4j], 
ZEPPELIN=[zeppelin-env, zeppelin-config], 
LOGSEARCH=[logsearch-service_logs-solrconfig, logsearch-admin-json, 
logfeeder-log4j, logsearch-env, logsearch-solr-log4j, logfeeder-env, 
logsearch-audit_logs-solrconfig, logsearch-solr-env, logfeeder-properties, 
logsearch-properties, logsearch-log4j, logsearch-solr-client-log4j, 
logsearch-solr-xml], RANGER_KMS=[kms-properties, ranger-kms-security, 
ranger-kms-site, kms-site, kms-env, dbks-site, ranger-kms-audit, 
ranger-kms-policymgr-ssl, kms-log4j], MAPREDUCE2=[mapred-site, mapred-env], 
SLIDER=[slider-log4j, slider-env, slider-client], HIVE=[llap-cli-log4j2, 
hive-interactive-site, hive-exec-log4j, hive-env, ranger-hive-policymgr-ssl, 
tez-interactive-site, 
 hive-site, hivemetastore-site, hive-interactive-env, webhcat-env, 
ranger-hive-plugin-properties, webhcat-site, hive-log4j, ranger-hive-audit, 
webhcat-log4j, hiveserver2-site, hcat-env, llap-daemon-log4j, 
ranger-hive-security], TEZ=[tez-env, tez-site], HBASE=[ranger-hbase-security, 
hbase-env, hbase-policy, hbase-log4j, hbase-site, ranger-hbase-policymgr-ssl, 
ranger-hbase-audit, ranger-hbase-plugin-properties], RANGER=[admin-properties, 
tagsync-log4j, ranger-site, ranger-ugsync-site, ranger-admin-site, 
ranger-tagsync-site, usersync-log4j, tagsync-application-properties, 
usersync-properties, admin-log4j, ranger-env], OOZIE=[oozie-log4j, oozie-env, 
oozie-site], FLUME=[flume-env, flume-conf], MAHOUT=[mahout-log4j, mahout-env], 
HDFS=[ssl-server, hdfs-log4j, ranger-hdfs-audit, ranger-hdfs-plugin-properties, 
ssl-client, hdfs-site, ranger-hdfs-policymgr-ssl, ranger-hdfs-security, 
hadoop-policy, hadoop-env, core-site], AMBARI_METRICS=[ams-ssl-client, 
ams-ssl-server, ams-hbase-log4j, ams-grafa
 na-env, ams-hbase-policy, ams-hbase-security-site, ams-hbase-env, ams-env, 
ams-grafana-ini, ams-log4j, ams-site, ams-hbase-site], 
SPARK=[spark-thrift-fairscheduler, spark-thrift-sparkconf, 
spark-log4j-properties, spark-defaults, spark-metrics-properties, 
spark-hive-site-override, spark-env], SMARTSENSE=[hst-log4j, hst-server-conf, 
hst-common-conf, capture-levels, hst-agent-conf, anonymization-rules], 
YARN=[ranger-yarn-policymgr-ssl, yarn-site, ranger-yarn-audit, 
ranger-yarn-security, ranger-yarn-plugin-properties, yarn-env, 
capacity-scheduler, yarn-log4j], FALCON=[falcon-startup.properties, 
falcon-runtime.properties, falcon-env], SQOOP=[sqoop-site, sqoop-env], 
ZOOKEEPER=[zoo.cfg, zookeeper-env, zookeeper-log4j], 
STORM=[ranger-storm-plugin-properties, storm-site, ranger-storm-audit, 
storm-cluster-log4j, storm-worker-log4j, ranger-storm-policymgr-ssl, 
ranger-storm-security, storm-env], ATLAS=[atlas-hbase-site, atlas-log4j, 
atlas-env, application-properties], GANGLIA=[ganglia-env], KNO
 X=[knoxsso-topology, ranger-knox-security, users-ldif, knox-env, 
ranger-knox-plugin-properties, gateway-site, gateway-log4j, 
ranger-knox-policymgr-ssl, ranger-knox-audit, topology, admin-topology, 
ldap-log4j], KERBEROS=[kerberos-env, krb5-conf], ACCUMULO=[accumulo-log4j, 
accumulo-env, client, accumulo-site]}
```

But: 
```
06 May 2016 12:43:46,050 ERROR [qtp-ambari-client-171] 
AbstractResourceProvider:314 - Caught AmbariException when getting a resource
org.apache.ambari.server.AmbariException: The 'krb5-conf' configuration is not 
available
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getKerberosDetails(KerberosHelperImpl.java:1903)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.addAmbariServerIdentity(KerberosHelperImpl.java:1364)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getActiveIdentities(KerberosHelperImpl.java:1283)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:163)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:145)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.getResources(AbstractResourceProvider.java:307)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider.getResources(Hos

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132335
---




File Attachment: AMBARI-15552-May-05.patch - AMBARI-15552-May-05.patch


Coding style needs to be fixed(many places). Also, could you please attach 
the latest patch to JIRA after the fix?


- Richard Zang


On May 5, 2016, 5:59 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 5, 2016, 5:59 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert messages must show more informative messages of what is happening 
> with the user's privileges and why. (addressing 1.2 and 2.3)
> 
> 
> Diffs
> -
> 
>   
> ambari-ad

Re: Review Request 47009: Falcon server start fails

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 (line 162)


Don't we want the server classpath to be changed in falcon-config?


- Venkat Ranganathan


On May 5, 2016, 5:07 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
> 
> (Updated May 5, 2016, 5:07 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deployed HDP-2.5 and Falcon server failed to start.
> 
> 
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> 
> 
> The command to start, in Ambari is:
> 
> 
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000'] 
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path': 
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
> 
> 
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/* 
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for 
> falcon webapp itself. That step should not be done and we should change it to 
> add falcon hook into webapp.jar itself post deployment like what we do for 
> Oozie with prepare-war or added to server classpath explicitly
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  3fdf2e6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  bf7f437 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  4b7c0c3 
> 
> Diff: https://reviews.apache.org/r/47009/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47134: HAWQ Password handling updated

[jun aoki]

> On May 9, 2016, 8:06 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py,
> >  line 54
> > 
> >
> > json.dumps ensures that quotes and special characters are escaped?
> > 
> > Did you consider && and giving an additional command? Or is this a new 
> > JIRA?
> 
> bhuvnesh chaudhary wrote:
> It ensures that whatever is input is passed as a string as interpreted by 
> bash. I tested && as well.
> Some of the password which i tested..
> "';//\p@ssw&&rd;touch abc.txt;
> "';//p@ssw&&rd

I'm a bit surprised with this json. Bhuvnesh, what you said make sense totally 
but maybe a good idea to have a comment.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.Test

Re: Review Request 47134: HAWQ Password handling updated

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132339
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 54)


Could you add a comment why "$1$salt$"? it is so magic if you are not 
familier with crpyt(I'm one of them)
$1 to be MD5 instead of default DES and more

https://en.wikipedia.org/wiki/Crypt_(C)#Key_Derivation_Functions_Supported_by_crypt


- jun aoki


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978

Re: Review Request 47136: The 'krb5-conf' configuration is not available

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47136/#review132343
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 (lines 1254 - 1258)


I realize hosts is defined as Collection, but it seems odd to mix 
Sets and Lists here.  Could just be a Set to indicate a unique-member 
collection?


- Nate Cole


On May 9, 2016, 5:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47136/
> ---
> 
> (Updated May 9, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Nate Cole, 
> Sandor Magyari, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16397
> https://issues.apache.org/jira/browse/AMBARI-16397
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configuration is loaded:
> ```
> 06 May 2016 10:52:11,998  INFO [qtp-ambari-client-26] ClusterImpl:346 - 
> Service config types loaded: {KAFKA=[ranger-kafka-policymgr-ssl, kafka-log4j, 
> kafka-env, kafka-broker, ranger-kafka-security, 
> ranger-kafka-plugin-properties, ranger-kafka-audit], PIG=[pig-properties, 
> pig-env, pig-log4j], ZEPPELIN=[zeppelin-env, zeppelin-config], 
> LOGSEARCH=[logsearch-service_logs-solrconfig, logsearch-admin-json, 
> logfeeder-log4j, logsearch-env, logsearch-solr-log4j, logfeeder-env, 
> logsearch-audit_logs-solrconfig, logsearch-solr-env, logfeeder-properties, 
> logsearch-properties, logsearch-log4j, logsearch-solr-client-log4j, 
> logsearch-solr-xml], RANGER_KMS=[kms-properties, ranger-kms-security, 
> ranger-kms-site, kms-site, kms-env, dbks-site, ranger-kms-audit, 
> ranger-kms-policymgr-ssl, kms-log4j], MAPREDUCE2=[mapred-site, mapred-env], 
> SLIDER=[slider-log4j, slider-env, slider-client], HIVE=[llap-cli-log4j2, 
> hive-interactive-site, hive-exec-log4j, hive-env, ranger-hive-policymgr-ssl, 
> tez-interactive-site
 , hive-site, hivemetastore-site, hive-interactive-env, webhcat-env, 
ranger-hive-plugin-properties, webhcat-site, hive-log4j, ranger-hive-audit, 
webhcat-log4j, hiveserver2-site, hcat-env, llap-daemon-log4j, 
ranger-hive-security], TEZ=[tez-env, tez-site], HBASE=[ranger-hbase-security, 
hbase-env, hbase-policy, hbase-log4j, hbase-site, ranger-hbase-policymgr-ssl, 
ranger-hbase-audit, ranger-hbase-plugin-properties], RANGER=[admin-properties, 
tagsync-log4j, ranger-site, ranger-ugsync-site, ranger-admin-site, 
ranger-tagsync-site, usersync-log4j, tagsync-application-properties, 
usersync-properties, admin-log4j, ranger-env], OOZIE=[oozie-log4j, oozie-env, 
oozie-site], FLUME=[flume-env, flume-conf], MAHOUT=[mahout-log4j, mahout-env], 
HDFS=[ssl-server, hdfs-log4j, ranger-hdfs-audit, ranger-hdfs-plugin-properties, 
ssl-client, hdfs-site, ranger-hdfs-policymgr-ssl, ranger-hdfs-security, 
hadoop-policy, hadoop-env, core-site], AMBARI_METRICS=[ams-ssl-client, 
ams-ssl-server, ams-hbase-log4j, ams-gra
 fana-env, ams-hbase-policy, ams-hbase-security-site, ams-hbase-env, ams-env, 
ams-grafana-ini, ams-log4j, ams-site, ams-hbase-site], 
SPARK=[spark-thrift-fairscheduler, spark-thrift-sparkconf, 
spark-log4j-properties, spark-defaults, spark-metrics-properties, 
spark-hive-site-override, spark-env], SMARTSENSE=[hst-log4j, hst-server-conf, 
hst-common-conf, capture-levels, hst-agent-conf, anonymization-rules], 
YARN=[ranger-yarn-policymgr-ssl, yarn-site, ranger-yarn-audit, 
ranger-yarn-security, ranger-yarn-plugin-properties, yarn-env, 
capacity-scheduler, yarn-log4j], FALCON=[falcon-startup.properties, 
falcon-runtime.properties, falcon-env], SQOOP=[sqoop-site, sqoop-env], 
ZOOKEEPER=[zoo.cfg, zookeeper-env, zookeeper-log4j], 
STORM=[ranger-storm-plugin-properties, storm-site, ranger-storm-audit, 
storm-cluster-log4j, storm-worker-log4j, ranger-storm-policymgr-ssl, 
ranger-storm-security, storm-env], ATLAS=[atlas-hbase-site, atlas-log4j, 
atlas-env, application-properties], GANGLIA=[ganglia-env], K
 NOX=[knoxsso-topology, ranger-knox-security, users-ldif, knox-env, 
ranger-knox-plugin-properties, gateway-site, gateway-log4j, 
ranger-knox-policymgr-ssl, ranger-knox-audit, topology, admin-topology, 
ldap-log4j], KERBEROS=[kerberos-env, krb5-conf], ACCUMULO=[accumulo-log4j, 
accumulo-env, client, accumulo-site]}
> ```
> 
> But: 
> ```
> 06 May 2016 12:43:46,050 ERROR [qtp-ambari-client-171] 
> AbstractResourceProvider:314 - Caught AmbariException when getting a resource
> org.apache.ambari.server.AmbariException: The 'krb5-conf' configuration is 
> not available
>   at 
> org.apache.ambari.server.controller.KerberosHelperImpl.getKerberosDetails(KerberosHelperImpl.java:1903)
>   at 
> org.apache.ambari.server.cont

Re: Review Request 47134: HAWQ Password handling updated

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132347
---


Ship it!




Ship It!

- Alexander Denissov


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized .

Review Request 47139: Ranger issues on summary page and config page

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47139/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.


Bugs: AMBARI-16409
https://issues.apache.org/jira/browse/AMBARI-16409


Repository: ambari


Description
---

# Ranger Admin Tab shows incorrect red badge with 1 error count
# Ranger summary page shows Kafka plugin status twice


Diffs
-

  ambari-web/app/controllers/main/service/info/summary.js 3a71cb3 
  ambari-web/app/models/configs/objects/service_config_property.js 24f648b 

Diff: https://reviews.apache.org/r/47139/diff/


Testing
---

Verified that patch resolves the issues on cluster
Verified that ambari-web unit tests passes with the patch:
27721 tests complete (28 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 47139: Ranger issues on summary page and config page

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47139/#review132348
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 9, 2016, 11:30 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47139/
> ---
> 
> (Updated May 9, 2016, 11:30 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16409
> https://issues.apache.org/jira/browse/AMBARI-16409
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> # Ranger Admin Tab shows incorrect red badge with 1 error count
> # Ranger summary page shows Kafka plugin status twice
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/summary.js 3a71cb3 
>   ambari-web/app/models/configs/objects/service_config_property.js 24f648b 
> 
> Diff: https://reviews.apache.org/r/47139/diff/
> 
> 
> Testing
> ---
> 
> Verified that patch resolves the issues on cluster
> Verified that ambari-web unit tests passes with the patch:
> 27721 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 47139: Ranger issues on summary page and config page

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47139/#review132349
---


Ship it!




Ship It!

- Richard Zang


On May 9, 2016, 11:30 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47139/
> ---
> 
> (Updated May 9, 2016, 11:30 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16409
> https://issues.apache.org/jira/browse/AMBARI-16409
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> # Ranger Admin Tab shows incorrect red badge with 1 error count
> # Ranger summary page shows Kafka plugin status twice
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/summary.js 3a71cb3 
>   ambari-web/app/models/configs/objects/service_config_property.js 24f648b 
> 
> Diff: https://reviews.apache.org/r/47139/diff/
> 
> 
> Testing
> ---
> 
> Verified that patch resolves the issues on cluster
> Verified that ambari-web unit tests passes with the patch:
> 27721 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 47140: Ambari Should Suspend Alerts Notifications During Upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47140/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-16410
https://issues.apache.org/jira/browse/AMBARI-16410


Repository: ambari


Description
---

Ambari reports alerts and triggers notifications during a stack upgrade. In 
most cases, alert notifications should be suppressed during the upgrade to 
prevent false positives. 

However, some alerts, such as those which don't related to the cluster, should 
remain fully operational:

- Host disk space
- Upgrade not finalized
- Ambari Server Performance


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
 21584fb 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
 f76867a 

Diff: https://reviews.apache.org/r/47140/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/
---

Review request for Ambari.


Bugs: AMBARI-16378
https://issues.apache.org/jira/browse/AMBARI-16378


Repository: ambari


Description
---

```
def getHostsForSlaveComponent(self, services, hosts, component, hostsList, 
hostsComponentsMap, freeHosts):
componentName = component["StackServiceComponents"]["component_name"]

if component["StackServiceComponents"]["cardinality"] == "ALL":
  return hostsList

componentIsPopulated = self.isComponentHostsPopulated(component)
if componentIsPopulated:
  return component["StackServiceComponents"]["hostnames"]

hostsForComponent = []

if self.isSlaveComponent(component):
  cardinality = str(component["StackServiceComponents"]["cardinality"])
  if self.isComponentUsingCardinalityForLayout(component) and cardinality:
# cardinality types: 1+, 1-2, 1
```

The correct parameter name is comonentName (instead of component)


Diffs
-

  ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 

Diff: https://reviews.apache.org/r/47138/diff/


Testing
---

Tested manually


Thanks,

Lav Jain

Review Request 47141: Stack advisor warning while looking for non-existing 'hive-interactive-site' when hive interactive is not installed/selected

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47141/
---

Review request for Ambari, Jaimin Jetly and Sumit Mohanty.


Bugs: AMBARI-16411
https://issues.apache.org/jira/browse/AMBARI-16411


Repository: ambari


Description
---

- Added check for existence of 'hive-interactive-site'.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
b8c44d3 

Diff: https://reviews.apache.org/r/47141/diff/


Testing
---

- Python UT passes.
- Tested the population of prop : hive.llap.zk.sm.connectionString


Thanks,

Swapan Shridhar

Re: Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/#review132350
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On May 9, 2016, 11:43 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47138/
> ---
> 
> (Updated May 9, 2016, 11:43 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-16378
> https://issues.apache.org/jira/browse/AMBARI-16378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> def getHostsForSlaveComponent(self, services, hosts, component, hostsList, 
> hostsComponentsMap, freeHosts):
> componentName = component["StackServiceComponents"]["component_name"]
> 
> if component["StackServiceComponents"]["cardinality"] == "ALL":
>   return hostsList
> 
> componentIsPopulated = self.isComponentHostsPopulated(component)
> if componentIsPopulated:
>   return component["StackServiceComponents"]["hostnames"]
> 
> hostsForComponent = []
> 
> if self.isSlaveComponent(component):
>   cardinality = str(component["StackServiceComponents"]["cardinality"])
>   if self.isComponentUsingCardinalityForLayout(component) and cardinality:
> # cardinality types: 1+, 1-2, 1
> ```
> 
> The correct parameter name is comonentName (instead of component)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 
> 
> Diff: https://reviews.apache.org/r/47138/diff/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47142/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16412
https://issues.apache.org/jira/browse/AMBARI-16412


Repository: ambari


Description
---

Adding TopN support to AMS API

Following are supported.

1. Top "N" hosts when 1 metric is requested for "H" hosts.
2. Top "N" metrics when "M" metrics (or a pattern) are requested for 0 or 1 
hosts.
3. When more than 20 hosts are requested, AMS defaults to Top N hosts condition 
with N=20.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TopNConfig.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 89c67d1 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 a0ecbcc 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
 ded64e3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
 632df3f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultCondition.java
 99a6125 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 6ee0006 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
 4cfc415 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
 9c6617c 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
 16bbf0e 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java
 277a98c 

Diff: https://reviews.apache.org/r/47142/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/#review132354
---


Ship it!




Ship It!

- Matt


On May 9, 2016, 4:43 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47138/
> ---
> 
> (Updated May 9, 2016, 4:43 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-16378
> https://issues.apache.org/jira/browse/AMBARI-16378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> def getHostsForSlaveComponent(self, services, hosts, component, hostsList, 
> hostsComponentsMap, freeHosts):
> componentName = component["StackServiceComponents"]["component_name"]
> 
> if component["StackServiceComponents"]["cardinality"] == "ALL":
>   return hostsList
> 
> componentIsPopulated = self.isComponentHostsPopulated(component)
> if componentIsPopulated:
>   return component["StackServiceComponents"]["hostnames"]
> 
> hostsForComponent = []
> 
> if self.isSlaveComponent(component):
>   cardinality = str(component["StackServiceComponents"]["cardinality"])
>   if self.isComponentUsingCardinalityForLayout(component) and cardinality:
> # cardinality types: 1+, 1-2, 1
> ```
> 
> The correct parameter name is comonentName (instead of component)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 
> 
> Diff: https://reviews.apache.org/r/47138/diff/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 47141: Stack advisor warning while looking for non-existing 'hive-interactive-site' when hive interactive is not installed/selected

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47141/#review132355
---


Ship it!




Ship It!

- Jaimin Jetly


On May 9, 2016, 11:44 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47141/
> ---
> 
> (Updated May 9, 2016, 11:44 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16411
> https://issues.apache.org/jira/browse/AMBARI-16411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added check for existence of 'hive-interactive-site'.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b8c44d3 
> 
> Diff: https://reviews.apache.org/r/47141/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested the population of prop : hive.llap.zk.sm.connectionString
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47085/
---

(Updated May 10, 2016, 12:17 a.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Changes
---

Attaching 2nd revision of the patch that includes the new requirement of 
splitting the metrics properties file into two:
one for llapdaemon and another for llaptaskscheduler


Bugs: AMBARI-16296
https://issues.apache.org/jira/browse/AMBARI-16296


Repository: ambari


Description
---

This patch makes start of HiveServer2 Interactive create 
/usr/hdp/current/hive-server2-hive2/conf/conf.server/hadoop-metrics2.properties 
(symlinked from /etc/hive2/conf/conf.server/) with following example content:

*.period=10
*.sink.timeline.plugin.urls=file:///usr/lib/ambari-metrics-hadoop-sink/ambari-metrics-hadoop-sink.jar
*.sink.timeline.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
*.sink.timeline.period=10
*.sink.timeline.sendInterval=6

# HTTPS properties
*.sink.timeline.truststore.path = /etc/security/clientKeys/all.jks
*.sink.timeline.truststore.type = jks
*.sink.timeline.truststore.password = bigdata

llapdaemon.sink.timeline.collector=http://metrics.collector.host.openstacklocal:6188

llapdaemon.sink.timeline_scheduler.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
llapdaemon.sink.timeline_scheduler.context=scheduler
llapdaemon.sink.timeline_scheduler.collector=http://metrics.collector.host.openstacklocal:6188


Diffs (updated)
-

  ambari-web/app/mixins/common/configs/configs_saver.js 1f81ef1 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
080fff1 

Diff: https://reviews.apache.org/r/47085/diff/


Testing
---

Verified that ambari-agent unit tests passes with the patch


Thanks,

Jaimin Jetly

Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47085/
---

(Updated May 10, 2016, 12:19 a.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16296
https://issues.apache.org/jira/browse/AMBARI-16296


Repository: ambari


Description
---

This patch makes start of HiveServer2 Interactive create 
/usr/hdp/current/hive-server2-hive2/conf/conf.server/hadoop-metrics2.properties 
(symlinked from /etc/hive2/conf/conf.server/) with following example content:

*.period=10
*.sink.timeline.plugin.urls=file:///usr/lib/ambari-metrics-hadoop-sink/ambari-metrics-hadoop-sink.jar
*.sink.timeline.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
*.sink.timeline.period=10
*.sink.timeline.sendInterval=6

# HTTPS properties
*.sink.timeline.truststore.path = /etc/security/clientKeys/all.jks
*.sink.timeline.truststore.type = jks
*.sink.timeline.truststore.password = bigdata

llapdaemon.sink.timeline.collector=http://metrics.collector.host.openstacklocal:6188

llapdaemon.sink.timeline_scheduler.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
llapdaemon.sink.timeline_scheduler.context=scheduler
llapdaemon.sink.timeline_scheduler.collector=http://metrics.collector.host.openstacklocal:6188


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 6a0d777 

Diff: https://reviews.apache.org/r/47085/diff/


Testing
---

Verified that ambari-agent unit tests passes with the patch


Thanks,

Jaimin Jetly

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47142/#review132356
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TopNConfig.java
 (line 21)


Missing JSON annotations.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 (line 218)


Lets make this configurable, no need to add config to the xml.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 (line 308)


We should cleanup the interface and remove this sigular function call 
unless it is documented as supported API.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
 (line 53)


formatting



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 (line 472)


Can we do refactor this? Builder would be great.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 (line 872)


Rename to getTargetTableUsingPrecision



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
 (line 146)


Add javadoc for method


- Sid Wagle


On May 9, 2016, 11:50 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47142/
> ---
> 
> (Updated May 9, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16412
> https://issues.apache.org/jira/browse/AMBARI-16412
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding TopN support to AMS API
> 
> Following are supported.
> 
> 1. Top "N" hosts when 1 metric is requested for "H" hosts.
> 2. Top "N" metrics when "M" metrics (or a pattern) are requested for 0 or 1 
> hosts.
> 3. When more than 20 hosts are requested, AMS defaults to Top N hosts 
> condition with N=20.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TopNConfig.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  89c67d1 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  a0ecbcc 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  ded64e3 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
>  632df3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultCondition.java
>  99a6125 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  6ee0006 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  4cfc415 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
>  9c6617c 
>   
> ambari-metric

Review Request 47147: AMBARI-16413: Ambari server does not start because of permission issues on symbolic links

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47147/
---

Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.


Bugs: AMBARI-16281
https://issues.apache.org/jira/browse/AMBARI-16281


Repository: ambari


Description
---

AMBARI-16413: Ambari server does not start because of permission issues on 
symbolic links

** Issue **

When setting up ambari-server with a non-root user, ownership change on various 
log files and other files do not work when those files are in a symbolic linked 
folder.

** Fix **
When doing a chown -R , specify the -L option to traverse every 
symbolic link.


Diffs
-

  ambari-common/src/main/python/ambari_commons/os_linux.py a64f99a 

Diff: https://reviews.apache.org/r/47147/diff/


Testing
---

** 1. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.567s

OK
--
Total run:1014
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:06.431s
[INFO] Finished at: Mon May 09 17:35:47 PDT 2016
[INFO] Final Memory: 61M/984M
[INFO] 

** 2. Manual testing **
Set up a VM and copy the changed os_linux.py script fromt the build to the VM. 
Run the following commands:
rm -rf /var/log/ambari-server
mkdir /tmp/log/ambari-server
cd /var/log
ln -s ambari-server /tmp/log/ambari-server

Run ambari-server setup and use a non-root user. Verify that the permissions on 
/var/log/ambari-server and it's contents now have the non-root user as the 
owner.

Run ambari-server start and verify that it was successful.


Thanks,

Nahappan Somasundaram

Re: Review Request 47141: Stack advisor warning while looking for non-existing 'hive-interactive-site' when hive interactive is not installed/selected

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47141/#review132359
---


Ship it!




Ship It!

- Sumit Mohanty


On May 9, 2016, 11:44 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47141/
> ---
> 
> (Updated May 9, 2016, 11:44 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16411
> https://issues.apache.org/jira/browse/AMBARI-16411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added check for existence of 'hive-interactive-site'.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b8c44d3 
> 
> Diff: https://reviews.apache.org/r/47141/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested the population of prop : hive.llap.zk.sm.connectionString
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47147: AMBARI-16413: Ambari server does not start because of permission issues on symbolic links

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47147/
---

(Updated May 9, 2016, 5:41 p.m.)


Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.


Changes
---

Fixed the bug number to AMBARI-16413.


Bugs: AMBARI-16413
https://issues.apache.org/jira/browse/AMBARI-16413


Repository: ambari


Description
---

AMBARI-16413: Ambari server does not start because of permission issues on 
symbolic links

** Issue **

When setting up ambari-server with a non-root user, ownership change on various 
log files and other files do not work when those files are in a symbolic linked 
folder.

** Fix **
When doing a chown -R , specify the -L option to traverse every 
symbolic link.


Diffs
-

  ambari-common/src/main/python/ambari_commons/os_linux.py a64f99a 

Diff: https://reviews.apache.org/r/47147/diff/


Testing
---

** 1. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.567s

OK
--
Total run:1014
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:06.431s
[INFO] Finished at: Mon May 09 17:35:47 PDT 2016
[INFO] Final Memory: 61M/984M
[INFO] 

** 2. Manual testing **
Set up a VM and copy the changed os_linux.py script fromt the build to the VM. 
Run the following commands:
rm -rf /var/log/ambari-server
mkdir /tmp/log/ambari-server
cd /var/log
ln -s ambari-server /tmp/log/ambari-server

Run ambari-server setup and use a non-root user. Verify that the permissions on 
/var/log/ambari-server and it's contents now have the non-root user as the 
owner.

Run ambari-server start and verify that it was successful.


Thanks,

Nahappan Somasundaram

Review Request 47152: AMBARI-16414: Clients are not present in Hosts filter

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47152/
---

Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang.


Bugs: AMBARI-16414
https://issues.apache.org/jira/browse/AMBARI-16414


Repository: ambari


Description
---

Deploy a cluster with default configs for Ambari-2.4.0.0
Navigate to Hosts Page
In the new filter there is no choice to filter a Client component
filtering client components was possible in old design of dropdown action menu 
(Ambari-2.2.2 and earlier). After the page is redesigned, this feature is 
missing.


Diffs
-

  ambari-web/app/views/main/host/combo_search_box.js 0b8c95b 

Diff: https://reviews.apache.org/r/47152/diff/


Testing
---

Manually tested on live cluster. 
All unit tests passed.
  27721 tests complete (31 seconds)
  154 tests pending


Thanks,

Richard Zang

Re: Review Request 47152: AMBARI-16414: Clients are not present in Hosts filter

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47152/#review132364
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 10, 2016, 1:45 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47152/
> ---
> 
> (Updated May 10, 2016, 1:45 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-16414
> https://issues.apache.org/jira/browse/AMBARI-16414
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deploy a cluster with default configs for Ambari-2.4.0.0
> Navigate to Hosts Page
> In the new filter there is no choice to filter a Client component
> filtering client components was possible in old design of dropdown action 
> menu (Ambari-2.2.2 and earlier). After the page is redesigned, this feature 
> is missing.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/host/combo_search_box.js 0b8c95b 
> 
> Diff: https://reviews.apache.org/r/47152/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. 
> All unit tests passed.
>   27721 tests complete (31 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 47136: The 'krb5-conf' configuration is not available

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47136/
---

(Updated May 9, 2016, 11:21 p.m.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Nate Cole, 
Sandor Magyari, and Sumit Mohanty.


Bugs: AMBARI-16397
https://issues.apache.org/jira/browse/AMBARI-16397


Repository: ambari


Description
---

Configuration is loaded:
```
06 May 2016 10:52:11,998  INFO [qtp-ambari-client-26] ClusterImpl:346 - Service 
config types loaded: {KAFKA=[ranger-kafka-policymgr-ssl, kafka-log4j, 
kafka-env, kafka-broker, ranger-kafka-security, ranger-kafka-plugin-properties, 
ranger-kafka-audit], PIG=[pig-properties, pig-env, pig-log4j], 
ZEPPELIN=[zeppelin-env, zeppelin-config], 
LOGSEARCH=[logsearch-service_logs-solrconfig, logsearch-admin-json, 
logfeeder-log4j, logsearch-env, logsearch-solr-log4j, logfeeder-env, 
logsearch-audit_logs-solrconfig, logsearch-solr-env, logfeeder-properties, 
logsearch-properties, logsearch-log4j, logsearch-solr-client-log4j, 
logsearch-solr-xml], RANGER_KMS=[kms-properties, ranger-kms-security, 
ranger-kms-site, kms-site, kms-env, dbks-site, ranger-kms-audit, 
ranger-kms-policymgr-ssl, kms-log4j], MAPREDUCE2=[mapred-site, mapred-env], 
SLIDER=[slider-log4j, slider-env, slider-client], HIVE=[llap-cli-log4j2, 
hive-interactive-site, hive-exec-log4j, hive-env, ranger-hive-policymgr-ssl, 
tez-interactive-site, 
 hive-site, hivemetastore-site, hive-interactive-env, webhcat-env, 
ranger-hive-plugin-properties, webhcat-site, hive-log4j, ranger-hive-audit, 
webhcat-log4j, hiveserver2-site, hcat-env, llap-daemon-log4j, 
ranger-hive-security], TEZ=[tez-env, tez-site], HBASE=[ranger-hbase-security, 
hbase-env, hbase-policy, hbase-log4j, hbase-site, ranger-hbase-policymgr-ssl, 
ranger-hbase-audit, ranger-hbase-plugin-properties], RANGER=[admin-properties, 
tagsync-log4j, ranger-site, ranger-ugsync-site, ranger-admin-site, 
ranger-tagsync-site, usersync-log4j, tagsync-application-properties, 
usersync-properties, admin-log4j, ranger-env], OOZIE=[oozie-log4j, oozie-env, 
oozie-site], FLUME=[flume-env, flume-conf], MAHOUT=[mahout-log4j, mahout-env], 
HDFS=[ssl-server, hdfs-log4j, ranger-hdfs-audit, ranger-hdfs-plugin-properties, 
ssl-client, hdfs-site, ranger-hdfs-policymgr-ssl, ranger-hdfs-security, 
hadoop-policy, hadoop-env, core-site], AMBARI_METRICS=[ams-ssl-client, 
ams-ssl-server, ams-hbase-log4j, ams-grafa
 na-env, ams-hbase-policy, ams-hbase-security-site, ams-hbase-env, ams-env, 
ams-grafana-ini, ams-log4j, ams-site, ams-hbase-site], 
SPARK=[spark-thrift-fairscheduler, spark-thrift-sparkconf, 
spark-log4j-properties, spark-defaults, spark-metrics-properties, 
spark-hive-site-override, spark-env], SMARTSENSE=[hst-log4j, hst-server-conf, 
hst-common-conf, capture-levels, hst-agent-conf, anonymization-rules], 
YARN=[ranger-yarn-policymgr-ssl, yarn-site, ranger-yarn-audit, 
ranger-yarn-security, ranger-yarn-plugin-properties, yarn-env, 
capacity-scheduler, yarn-log4j], FALCON=[falcon-startup.properties, 
falcon-runtime.properties, falcon-env], SQOOP=[sqoop-site, sqoop-env], 
ZOOKEEPER=[zoo.cfg, zookeeper-env, zookeeper-log4j], 
STORM=[ranger-storm-plugin-properties, storm-site, ranger-storm-audit, 
storm-cluster-log4j, storm-worker-log4j, ranger-storm-policymgr-ssl, 
ranger-storm-security, storm-env], ATLAS=[atlas-hbase-site, atlas-log4j, 
atlas-env, application-properties], GANGLIA=[ganglia-env], KNO
 X=[knoxsso-topology, ranger-knox-security, users-ldif, knox-env, 
ranger-knox-plugin-properties, gateway-site, gateway-log4j, 
ranger-knox-policymgr-ssl, ranger-knox-audit, topology, admin-topology, 
ldap-log4j], KERBEROS=[kerberos-env, krb5-conf], ACCUMULO=[accumulo-log4j, 
accumulo-env, client, accumulo-site]}
```

But: 
```
06 May 2016 12:43:46,050 ERROR [qtp-ambari-client-171] 
AbstractResourceProvider:314 - Caught AmbariException when getting a resource
org.apache.ambari.server.AmbariException: The 'krb5-conf' configuration is not 
available
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getKerberosDetails(KerberosHelperImpl.java:1903)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.addAmbariServerIdentity(KerberosHelperImpl.java:1364)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getActiveIdentities(KerberosHelperImpl.java:1283)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:163)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:145)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.getResources(AbstractResourceProvider.java:307)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdent

Re: Review Request 47136: The 'krb5-conf' configuration is not available

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47136/
---

(Updated May 9, 2016, 11:22 p.m.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Nate Cole, 
Sandor Magyari, and Sumit Mohanty.


Bugs: AMBARI-16397
https://issues.apache.org/jira/browse/AMBARI-16397


Repository: ambari


Description
---

Configuration is loaded:
```
06 May 2016 10:52:11,998  INFO [qtp-ambari-client-26] ClusterImpl:346 - Service 
config types loaded: {KAFKA=[ranger-kafka-policymgr-ssl, kafka-log4j, 
kafka-env, kafka-broker, ranger-kafka-security, ranger-kafka-plugin-properties, 
ranger-kafka-audit], PIG=[pig-properties, pig-env, pig-log4j], 
ZEPPELIN=[zeppelin-env, zeppelin-config], 
LOGSEARCH=[logsearch-service_logs-solrconfig, logsearch-admin-json, 
logfeeder-log4j, logsearch-env, logsearch-solr-log4j, logfeeder-env, 
logsearch-audit_logs-solrconfig, logsearch-solr-env, logfeeder-properties, 
logsearch-properties, logsearch-log4j, logsearch-solr-client-log4j, 
logsearch-solr-xml], RANGER_KMS=[kms-properties, ranger-kms-security, 
ranger-kms-site, kms-site, kms-env, dbks-site, ranger-kms-audit, 
ranger-kms-policymgr-ssl, kms-log4j], MAPREDUCE2=[mapred-site, mapred-env], 
SLIDER=[slider-log4j, slider-env, slider-client], HIVE=[llap-cli-log4j2, 
hive-interactive-site, hive-exec-log4j, hive-env, ranger-hive-policymgr-ssl, 
tez-interactive-site, 
 hive-site, hivemetastore-site, hive-interactive-env, webhcat-env, 
ranger-hive-plugin-properties, webhcat-site, hive-log4j, ranger-hive-audit, 
webhcat-log4j, hiveserver2-site, hcat-env, llap-daemon-log4j, 
ranger-hive-security], TEZ=[tez-env, tez-site], HBASE=[ranger-hbase-security, 
hbase-env, hbase-policy, hbase-log4j, hbase-site, ranger-hbase-policymgr-ssl, 
ranger-hbase-audit, ranger-hbase-plugin-properties], RANGER=[admin-properties, 
tagsync-log4j, ranger-site, ranger-ugsync-site, ranger-admin-site, 
ranger-tagsync-site, usersync-log4j, tagsync-application-properties, 
usersync-properties, admin-log4j, ranger-env], OOZIE=[oozie-log4j, oozie-env, 
oozie-site], FLUME=[flume-env, flume-conf], MAHOUT=[mahout-log4j, mahout-env], 
HDFS=[ssl-server, hdfs-log4j, ranger-hdfs-audit, ranger-hdfs-plugin-properties, 
ssl-client, hdfs-site, ranger-hdfs-policymgr-ssl, ranger-hdfs-security, 
hadoop-policy, hadoop-env, core-site], AMBARI_METRICS=[ams-ssl-client, 
ams-ssl-server, ams-hbase-log4j, ams-grafa
 na-env, ams-hbase-policy, ams-hbase-security-site, ams-hbase-env, ams-env, 
ams-grafana-ini, ams-log4j, ams-site, ams-hbase-site], 
SPARK=[spark-thrift-fairscheduler, spark-thrift-sparkconf, 
spark-log4j-properties, spark-defaults, spark-metrics-properties, 
spark-hive-site-override, spark-env], SMARTSENSE=[hst-log4j, hst-server-conf, 
hst-common-conf, capture-levels, hst-agent-conf, anonymization-rules], 
YARN=[ranger-yarn-policymgr-ssl, yarn-site, ranger-yarn-audit, 
ranger-yarn-security, ranger-yarn-plugin-properties, yarn-env, 
capacity-scheduler, yarn-log4j], FALCON=[falcon-startup.properties, 
falcon-runtime.properties, falcon-env], SQOOP=[sqoop-site, sqoop-env], 
ZOOKEEPER=[zoo.cfg, zookeeper-env, zookeeper-log4j], 
STORM=[ranger-storm-plugin-properties, storm-site, ranger-storm-audit, 
storm-cluster-log4j, storm-worker-log4j, ranger-storm-policymgr-ssl, 
ranger-storm-security, storm-env], ATLAS=[atlas-hbase-site, atlas-log4j, 
atlas-env, application-properties], GANGLIA=[ganglia-env], KNO
 X=[knoxsso-topology, ranger-knox-security, users-ldif, knox-env, 
ranger-knox-plugin-properties, gateway-site, gateway-log4j, 
ranger-knox-policymgr-ssl, ranger-knox-audit, topology, admin-topology, 
ldap-log4j], KERBEROS=[kerberos-env, krb5-conf], ACCUMULO=[accumulo-log4j, 
accumulo-env, client, accumulo-site]}
```

But: 
```
06 May 2016 12:43:46,050 ERROR [qtp-ambari-client-171] 
AbstractResourceProvider:314 - Caught AmbariException when getting a resource
org.apache.ambari.server.AmbariException: The 'krb5-conf' configuration is not 
available
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getKerberosDetails(KerberosHelperImpl.java:1903)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.addAmbariServerIdentity(KerberosHelperImpl.java:1364)
at 
org.apache.ambari.server.controller.KerberosHelperImpl.getActiveIdentities(KerberosHelperImpl.java:1283)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:163)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdentityResourceProvider$GetResourcesCommand.invoke(HostKerberosIdentityResourceProvider.java:145)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.getResources(AbstractResourceProvider.java:307)
at 
org.apache.ambari.server.controller.internal.HostKerberosIdent

Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47153/
---

Review request for Ambari and Sumit Mohanty.


Repository: ambari


Description
---

Storm - When kerberos enabled storm.thrift.transport is being set to wrong 
config


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
 19d4961 

Diff: https://reviews.apache.org/r/47153/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47153/#review132368
---




ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
 (line 24)


Can you add the Bug id in the Bugs field and also Branch - its trunk.


- Sumit Mohanty


On May 10, 2016, 3:46 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47153/
> ---
> 
> (Updated May 10, 2016, 3:46 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm - When kerberos enabled storm.thrift.transport is being set to wrong 
> config
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
>  19d4961 
> 
> Diff: https://reviews.apache.org/r/47153/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47153/
---

(Updated May 10, 2016, 3:59 a.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16416
https://issues.apache.org/jira/browse/AMBARI-16416


Repository: ambari


Description
---

Storm - When kerberos enabled storm.thrift.transport is being set to wrong 
config


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
 19d4961 

Diff: https://reviews.apache.org/r/47153/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47153/#review132369
---


Ship it!




Ship It!

- Sumit Mohanty


On May 10, 2016, 3:59 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47153/
> ---
> 
> (Updated May 10, 2016, 3:59 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16416
> https://issues.apache.org/jira/browse/AMBARI-16416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm - When kerberos enabled storm.thrift.transport is being set to wrong 
> config
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
>  19d4961 
> 
> Diff: https://reviews.apache.org/r/47153/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Review Request 47156: More information for Standby sync alert

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/
---

Review request for Ambari.


Bugs: AMBARI-16417
https://issues.apache.org/jira/browse/AMBARI-16417


Repository: ambari


Description
---

When Standby master is down (actually I removed it through API, and it got 
deleted but somehow the configuration has the old IP) the hawq alert pops up(, 
which is good) but only saying "HAWQSTANDBY is not in sync with HAWQMASTER".

If you take a close look at gp_master_mirroring table, it has more detailed 
information. (in this case, connection issue)
{code}
[gpadmin@ip-10-32-38-104 ~]$ psql -d template1 -c "select * from 
gp_master_mirroring;"
  summary_state   |   detail_state   |log_time| 
 error_message
--+--++--
 Not Synchronized | Connection error | 2016-04-12 21:14:23+00 | error received 
sending data to standby master: server closed the connection unexpectedly
  : This 
probably means the server terminated abnormally
  : before 
or while processing the request.
  :
(1 row)
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 c94be9e 

Diff: https://reviews.apache.org/r/47156/diff/


Testing
---


Thanks,

jun aoki

Review Request 47124: Hive View : Upload Table- Error on uploading csv with 1 row

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47124/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16266
https://issues.apache.org/jira/browse/AMBARI-16266


Repository: ambari


Description
---

Earlier : Uploading csv files with exactly 1 row gives error. This was because 
"is first row header" was by default assumed to be true, and that left no rows 
in the file for data. 
In this patch : "is first row header" is assumed to be false by default. more 
options added for header option like EMBEDDED and NONE for clear definition. 
Handled this on UI and backend.


Diffs
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 83eae9b 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java
 adbdf7f 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
 d94ad3c 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 d883743 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 b7d9011 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
 479c934 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
 555d8e3 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
 f925dc3 

Diff: https://reviews.apache.org/r/47124/diff/


Testing
---

Tests modified to account for change as the header line will not be included 
into the preview rows returned by parser. Explicit tests added for single row 
csv, json and xml.

Results :

Tests run: 101, Failures: 0, Errors: 0, Skipped: 0


File Attachments


AMBARI-16266_trunk.patch
  
https://reviews.apache.org/media/uploaded/files/2016/05/10/73f61edb-b15d-4cab-b2f2-96c50d467e8e__AMBARI-16266_trunk.patch


Thanks,

Nitiraj Rathore