Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/
---

Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Bugs: AMBARI-22124
https://issues.apache.org/jira/browse/AMBARI-22124


Repository: ambari


Description
---

We need to move AMS specific logic in the stack advisors to service advisor.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
 a2e31cc 


Diff: https://reviews.apache.org/r/62756/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/
---

(Updated Oct. 3, 2017, 5:11 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22123
https://issues.apache.org/jira/browse/AMBARI-22123


Repository: ambari


Description
---

Essentially, the symlinking was doing a quick-exit if the /etc//conf 
directory already existed. However, it might have been created by another RPM 
and not the component we actually care about.

The refactor here did two things:
- Invokes conf-select on the necessary packages
- Combined most of the logic between conf_select.select(...) and 
conf_select.convert_conf_directories_to_symlinks(...)
- Removed legacy code from back in the pre-HDP 2.3 days


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 86821bf47a 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
3ace3b1570 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py
 0727970adb 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py
 0727970adb 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
 20fd48de15 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
 92f5011978 
  ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
2eeec46b4a 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py
 3d9bfd7c3e 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
 b88f3858a7 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py
 31b083bd0d 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py
 2df001cf21 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py
 34687c453b 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py
 4ec6aa788f 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py
 34c683ab2f 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py
 424157b128 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py
 b235cad164 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py
 71c7bc17a2 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py
 4d65a404a2 


Diff: https://reviews.apache.org/r/62754/diff/2/

Changes: https://reviews.apache.org/r/62754/diff/1-2/


Testing (updated)
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Bugs: AMBARI-21220
https://issues.apache.org/jira/browse/AMBARI-21220


Repository: ambari


Description
---

Update Local Authentication process to work with improved user management 
facility


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 3099bc0857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 21ab757e1c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
 2a894374d1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
 2a2e397439 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 2dedc9e6ca 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 fea7fb978e 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 fb4ebf93e4 


Diff: https://reviews.apache.org/r/62757/diff/1/


Testing
---

Manually tested

Local test results: PASSED


Thanks,

Robert Levas

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review186998
---




ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
Lines 43 (patched)


This was renamed from AmbariLocalUserProvider to be more consisten with 
other authentication providers.

It was also moved from `org.apache.ambari.server.security.authorization` to 
`org.apache.ambari.server.security.authentication`



ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
Lines 40 (patched)


This was renamed from `AmbariLocalUserProviderTest`.

The generic authentication provider tests were moved to 
`AbstractAuthenticationProviderTes` to provide a way to test all relevant 
authentication providers so that they behave in a similar way.


- Robert Levas


On Oct. 3, 2017, 4:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 4:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review186999
---


Ship it!




Ship It!

- Aravindan Vijayan


On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 3, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187004
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 3, 2017, 8:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 8:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22123
https://issues.apache.org/jira/browse/AMBARI-22123


Repository: ambari


Description
---

Essentially, the symlinking was doing a quick-exit if the /etc//conf 
directory already existed. However, it might have been created by another RPM 
and not the component we actually care about.

The refactor here did two things:
- Invokes conf-select on the necessary packages
- Combined most of the logic between conf_select.select(...) and 
conf_select.convert_conf_directories_to_symlinks(...)
- Removed legacy code from back in the pre-HDP 2.3 days


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 86821bf47a 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
3ace3b1570 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py
 0727970adb 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py
 0727970adb 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
 20fd48de15 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py
 3d9bfd7c3e 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py
 b88f3858a7 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py
 31b083bd0d 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py
 2df001cf21 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py
 34687c453b 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py
 4ec6aa788f 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py
 34c683ab2f 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py
 424157b128 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py
 b235cad164 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py
 71c7bc17a2 
  
contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py
 4d65a404a2 


Diff: https://reviews.apache.org/r/62754/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley

Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22115
https://issues.apache.org/jira/browse/AMBARI-22115


Repository: ambari


Description
---

This is part of AMBARI-22115. We need to define alerts on JMX metrics which are 
pulled from a cluster that is not necessarily managed by Ambari. Therefore 
alerts can't run on ambari-agent host. I introduced a new SERVER type alert 
called JmxServerSideAlert that can pull the jmx metrics from a arbitrary url. 
The url comes from the alerts.json and it may contain placeholders like 
${hdfs-site/dfs.namenode.http-address}. This works similarly than the Python 
class MetricAlert.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
 81d72fb 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 5d2ecc6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
93801d5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 
4aeba45 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
 c58867a 
  
ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62744/diff/1/


Testing
---

Used the following alerts.json to test it

{   
  "ONEFS":{
"service": [
  { 
"name": "onefs_namenode_cpu",
"label": "OneFS NameNode Host CPU Utilization",
"description": "This host-level alert is triggered if CPU utilization 
of the NameNode exceeds certain warning and critical thresholds. It checks the 
NameNode JMX Servlet for the SystemCPULoad property. The threshold values are 
in percent.",
"interval": 1,
"help_url": 
"https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
"scope": "HOST",
"enabled": true,
"source": {
  "type": "SERVER",
  "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
  "uri": {
"http": "${hdfs-site/dfs.namenode.http-address}",
"https": "${hdfs-site/dfs.namenode.https-address}",
"https_property": "${hdfs-site/dfs.http.policy}",
"https_property_value": "HTTPS_ONLY",
"connection_timeout": 5.0
  },
  "reporting": {
"ok": {
  "text": "{1} CPU, load {0,number,percent}"
},
"warning": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 5
},
"critical": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 20
},
"units" : "%",
"type": "PERCENT"
   },
   "jmx": {
 "property_list": [
  "java.lang:type=OperatingSystem/SystemCpuLoad",
  "java.lang:type=OperatingSystem/AvailableProcessors"
 ]
   }
  }
  }
]
  }
}
1,1   Top


Thanks,

Attila Magyar

Re: Review Request 62726: Some ResourceProviders Are Not Transactional

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62726/#review186937
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 2, 2017, 5:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62726/
> ---
> 
> (Updated Oct. 2, 2017, 5:54 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22110
> https://issues.apache.org/jira/browse/AMBARI-22110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While investigating an issue with VDFs which don't contain any OS's which 
> match the cluster, it was observed that, even after throwing an Exception 
> inside of a Transaction, the entities created inside that transaction were 
> being committed.
> Eventual investigation led to a problem between Guice/AOP and our 
> ResourceProviders. The Guice documentations says that @Transactional methods 
> can only be intercepted on objects created by Guice:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  e3f1458202 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  9cd1d745c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0782685d07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  0b7f1db9c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  9d2b39effc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  781b01525f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  63e6c24fc8 
> 
> 
> Diff: https://reviews.apache.org/r/62726/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4914, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:53.576s
> [INFO] Finished at: Mon Oct 02 11:20:47 EDT 2017
> [INFO] Final Memory: 78M/1941M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62750: Cache becomes corrupt

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62750/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22119
https://issues.apache.org/jira/browse/AMBARI-22119


Repository: ambari


Description
---

Agent topology file cache became corrupt after writing of topology to it. It
contained some gibberish. I think it might be a rare simplejson bug. The file
was not trimmed correctly, during rewritting.

This happened only once on perf cluster. But worth a preventive fix.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ClusterCache.py 40b32886cf 


Diff: https://reviews.apache.org/r/62750/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62749: Log Search UI: implement time range selection from graph

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62749/#review186948
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Окт. 3, 2017, 1:06 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62749/
> ---
> 
> (Updated Окт. 3, 2017, 1:06 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22118
> https://issues.apache.org/jira/browse/AMBARI-22118
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to customize time range to filter logs by selecting the 
> interval on graph.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
>  9c6c336 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
>  fd3a58b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less
>  d891862 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts
>  7856ecc 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> 6697c54 
> 
> 
> Diff: https://reviews.apache.org/r/62749/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 89 of 89 SUCCESS (2.763 secs / 2.733 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Re: Review Request 62725: Create more simple HTML structure for menu button component

[Istvan Tobias]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62725/
---

(Updated Oct. 3, 2017, 3:11 p.m.)


Review request for Ambari, Andrii Babiichuk and Oliver Szabo.


Bugs: AMBARI-22109
https://issues.apache.org/jira/browse/AMBARI-22109


Repository: ambari


Description
---

The html sctructure should be more simple with less 'a' tag and handling the 
button's element as one component. It should be optimized with less event 
listeners and html element.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/components/accordion-panel/accordion-panel.component.less
 8366952 
  ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less 
d1aa7ff 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less
 a5da7f5 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less
 6faa192 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
 fc3dac8 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less
 4607d34 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.less
 d3523d3 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
 0fded67 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less
 f7dcc05 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html
 ca70927 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less
 6a3a43d 
  ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.less
 8238eaf 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.less
 df8ad2d 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less
 6d4378b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.less
 7d45778 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less
 e5e85f4 
  ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 
2dc6278 


Diff: https://reviews.apache.org/r/62725/diff/2/


Testing
---

Manual testing (yarn build, yarn start, yarn test, mvn clean package)

**mvn clean package**
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:47 min
[INFO] Finished at: 2017-10-02T17:54:23+02:00
[INFO] Final Memory: 19M/65M
[INFO] 

**yarn build**
?  Done in 23.45s.

**yarn test**
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 89 of 89 SUCCESS (2.405 secs / 2.393 
secs)
?  Done in 25.90s.


Thanks,

Istvan Tobias

Re: Review Request 62750: Cache becomes corrupt

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62750/#review186949
---


Ship it!




Ship It!

- Attila Doroszlai


On Oct. 3, 2017, 3:35 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62750/
> ---
> 
> (Updated Oct. 3, 2017, 3:35 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22119
> https://issues.apache.org/jira/browse/AMBARI-22119
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent topology file cache became corrupt after writing of topology to it. It
> contained some gibberish. I think it might be a rare simplejson bug. The file
> was not trimmed correctly, during rewritting.
> 
> This happened only once on perf cluster. But worth a preventive fix.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py 40b32886cf 
> 
> 
> Diff: https://reviews.apache.org/r/62750/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 62749: Log Search UI: implement time range selection from graph

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62749/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22118
https://issues.apache.org/jira/browse/AMBARI-22118


Repository: ambari


Description
---

User should be able to customize time range to filter logs by selecting the 
interval on graph.


Diffs
-

  
ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
 9c6c336 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
 fd3a58b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less
 d891862 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts
 7856ecc 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
6697c54 


Diff: https://reviews.apache.org/r/62749/diff/1/


Testing
---

Executed 89 of 89 SUCCESS (2.763 secs / 2.733 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 62718: Refactor existing server side actions to use the common AbstractUpgradeServerAction

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62718/
---

(Updated Oct. 3, 2017, 5:36 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22104
https://issues.apache.org/jira/browse/AMBARI-22104


Repository: ambari


Description
---

Other server-side classes need to use the abstract class in the summary. 
Identify fields that are largely common with the server-side actions and put 
them in the abstract class.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
 8ebb18635f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
 664cb2c9a9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
 44d2b4dba8 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 ec4d383dee 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 451f80211b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java
 f14d702a45 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixLzoCodecPath.java
 483372943b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 75588d5921 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
 5823c8bdf6 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseConfigCalculation.java
 739dd7e985 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseEnvMaxDirectMemorySizeAction.java
 fb1347 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveEnvClasspathAction.java
 c5000bf9b5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigAction.java
 23eacec7d2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/KerberosKeytabsAction.java
 4c6371b054 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ManualStageAction.java
 39b23bc930 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/OozieConfigCalculation.java
 9b8a7dc583 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 30bc47f526 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java
 e53c95f703 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 348b69eac7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java
 71c3a078f5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java
 3573748251 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 a6b94f4876 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/SparkShufflePropertyConfig.java
 b1aa6e187a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredRepositoryAction.java
 10d6630698 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java
 864060095b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java
 d6388584f0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicyTest.java
 daf1c30761 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
 fade2dd14d 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java
 ffd55eb742 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HBaseEnvMaxDirectMemorySizeActionTest.java
 d884d749ad 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveEnvClasspathActionTest.java
 d179db0ece 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigActionTest.java
 2f047fada9 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/KerberosKeytabsActionTest.java
 3678aa7502 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculationTest.java
 6527c9b7f0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
 d6a47f5024 
  

Re: Review Request 62744: Alerts for OneFS mpack

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review186980
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 20-21 (patched)


This is a funny looking import.  Use java.util.Collections directly.



ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 53-55 (patched)


nit: formatting; @Inject usually goes on its own line



ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java
Lines 24-25 (patched)


javadoc would be helpful



ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
Lines 227-231 (patched)


nit: formatting is a bit off


- Nate Cole


On Oct. 3, 2017, 7:01 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 3, 2017, 7:01 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/1/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187036
---




ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
Line 77 (original), 77 (patched)


Is this change to ATLAS service advisor supposed to be part of the patch?


- Jayush Luniya


On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 3, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62744: Alerts for OneFS mpack

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review187025
---




ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 52 (patched)


This should be configurable via the definiion.



ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 73 (patched)


/jmx should probably be parameterized? Or just make as part of the URI on 
the definition.



ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 80 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 83 (patched)


It's interesting to use the MetricsRetrievalService here. This service was 
created for use with the web client since it polls every few seconds. We 
figured it's better to respond quickly with metric data that migth be a few 
seconds old.

In this case, the alert only runs once every X minutes, so it's going to 
always be working with data that was retrieved X minutes ago. 

Is that the desired behavior?



ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
Lines 86 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
Lines 211 (patched)


Documentation.

Also - maybe call this something like `buildAlert` or `getAlert` to follow 
Java convention.



ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
Lines 225-231 (patched)


Do you need to worry about the SKIPPED state here?


- Jonathan Hurley


On Oct. 3, 2017, 7:01 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 3, 2017, 7:01 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/1/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
> "scope": "HOST",
> "enabled": true,
> 

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187029
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 2775-2780 (patched)


Can you also generate the new markdown file and include it in this patch?


- Jonathan Hurley


On Oct. 3, 2017, 4:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 4:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187037
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
Lines 21 (patched)


Can we also remove the duplicate code in HDP stack advisors?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
Lines 466 (patched)


Fix Typo "AMS Validator" instead of "Storm Validator"


- Jayush Luniya


On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 3, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>