Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104866
---

Ship it!


Ship It!

- Bill Farner


On Nov. 2, 2015, 5:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Nov. 2, 2015, 5:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/client/cli/client.py 
> c17f857dd1fd6289e2b3ca8e3f86211ede1344ad 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
>  INFO] Instances to be killed: [0]
> ERROR] INTERNAL: Communication with Aurora scheduler is kerberized. Did you 
> forget to run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104844
---

Ship it!


Master (f41938d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 3, 2015, 1:13 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Nov. 3, 2015, 1:13 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/client/cli/client.py 
> c17f857dd1fd6289e2b3ca8e3f86211ede1344ad 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
>  INFO] Instances to be killed: [0]
> ERROR] INTERNAL: Communication with Aurora scheduler is kerberized. Did you 
> forget to run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104841
---

Ship it!


LGTM!


src/main/python/apache/aurora/client/cli/client.py (line 49)


Do you think it's worth adding a test case for this functionality?


- Joshua Cohen


On Nov. 3, 2015, 1:13 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Nov. 3, 2015, 1:13 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/client/cli/client.py 
> c17f857dd1fd6289e2b3ca8e3f86211ede1344ad 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
>  INFO] Instances to be killed: [0]
> ERROR] INTERNAL: Communication with Aurora scheduler is kerberized. Did you 
> forget to run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/
---

(Updated Nov. 3, 2015, 1:13 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Hiding requests-kerberos output behind the -v flag.


Bugs: AURORA-1364
https://issues.apache.org/jira/browse/AURORA-1364


Repository: aurora


Description
---

The only reasonable way to wire it in is via the AuthModule, which is the only 
entity aware of the auth approach used.

Also, dropped AuthModule.payload() as it's no longer needed (SessionKey thrift 
struct is empty now).


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/scheduler_client.py 
8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
  src/main/python/apache/aurora/client/cli/client.py 
c17f857dd1fd6289e2b3ca8e3f86211ede1344ad 
  src/main/python/apache/aurora/common/auth/auth_module.py 
e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
  src/main/python/apache/aurora/common/auth/auth_module_manager.py 
2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
  src/main/python/apache/aurora/kerberos/auth_module.py 
fade00504a3122bc4b93e1cc1b7ebac6415303da 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 

Diff: https://reviews.apache.org/r/39797/diff/


Testing (updated)
---

./pants test.pytest --no-fast src/test/python::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Example error message:
```
...
 INFO] Instances to be killed: [0]
ERROR] INTERNAL: Communication with Aurora scheduler is kerberized. Did you 
forget to run "kinit"?
401 Client Error: Authorization Required
```


Thanks,

Maxim Khutornenko

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Maxim Khutornenko 


> On Oct. 30, 2015, 2:31 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 305-306
> > 
> >
> > It seems like this friendly error message is going to get buried at the 
> > top of the stack trace?
> > 
> > The output will be something like...
> > 
> > ERROR] Hey! Run kinit!
> > ERROR] GSS Error: (('Unspecified GSS failure...)
> > ...
> > 20 lines of stacktrace follow
> > ...
> > 
> > I'm not sure if there's any way around that, but it would certainly be 
> > nice to have "run kinit" be the last thing the user sees in the cases of 
> > these failures...
> 
> Maxim Khutornenko wrote:
> The stack is logged by requests-kerberos [1] before we get any chance to 
> react to it. I don't see an easy way to disable that logging without hiding 
> other (possibly important for troubleshooting) requests messages.
> 
> [1] - 
> https://github.com/requests/requests-kerberos/blob/master/requests_kerberos/kerberos_.py#L105-L133
> 
> Bill Farner wrote:
> Can you use the verbose flag and squash the logging when we're not 
> verbose?  This could cause us to lose information in rare non-repeatable 
> scenarios, but i'd be willing to risk that to provide a better experience in 
> normal cases.
> 
> Joshua Cohen wrote:
> +1. I'd be ok with asking users to re-run with --verbose for the rare 
> case if it means less support requests for failures to kinit.

I am fine with this suggestion too.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104566
---


On Oct. 30, 2015, 2:24 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Oct. 30, 2015, 2:24 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
> GSSError: ((' Miscellaneous failure (see text)', 851968), ('No credentials 
> cache file found', -1765328189))
> ERROR] Communication with Aurora scheduler is kerberized. Did you forget to 
> run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-11-02 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39822/#review104794
---

Ship it!


Ship It!

- Maxim Khutornenko


On Oct. 30, 2015, 8:14 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39822/
> ---
> 
> (Updated Oct. 30, 2015, 8:14 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1531
> https://issues.apache.org/jira/browse/AURORA-1531
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> upgrade psutil to 3.2.2
> psutil changelog:
> https://github.com/giampaolo/psutil/blob/36316de315a55dece354cf98533e647d7f62c49b/HISTORY.rst
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
> 
> Diff: https://reviews.apache.org/r/39822/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-11-02 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39822/#review104787
---

Ship it!


Ship It!

- Zameer Manji


On Oct. 30, 2015, 1:14 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39822/
> ---
> 
> (Updated Oct. 30, 2015, 1:14 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1531
> https://issues.apache.org/jira/browse/AURORA-1531
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> upgrade psutil to 3.2.2
> psutil changelog:
> https://github.com/giampaolo/psutil/blob/36316de315a55dece354cf98533e647d7f62c49b/HISTORY.rst
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
> 
> Diff: https://reviews.apache.org/r/39822/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-11-02 Thread Zameer Manji 


> On Nov. 1, 2015, 8:59 a.m., Bill Farner wrote:
> > Ship It!
> 
> Dmitriy Shirchenko wrote:
> sweet, if there are no other objections, can someone land this for me, 
> please?

Maxim is the last reviewer, so once he ships this he will land it.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39822/#review104661
---


On Oct. 30, 2015, 1:14 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39822/
> ---
> 
> (Updated Oct. 30, 2015, 1:14 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1531
> https://issues.apache.org/jira/browse/AURORA-1531
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> upgrade psutil to 3.2.2
> psutil changelog:
> https://github.com/giampaolo/psutil/blob/36316de315a55dece354cf98533e647d7f62c49b/HISTORY.rst
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
> 
> Diff: https://reviews.apache.org/r/39822/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Joshua Cohen 


> On Oct. 30, 2015, 2:31 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 305-306
> > 
> >
> > It seems like this friendly error message is going to get buried at the 
> > top of the stack trace?
> > 
> > The output will be something like...
> > 
> > ERROR] Hey! Run kinit!
> > ERROR] GSS Error: (('Unspecified GSS failure...)
> > ...
> > 20 lines of stacktrace follow
> > ...
> > 
> > I'm not sure if there's any way around that, but it would certainly be 
> > nice to have "run kinit" be the last thing the user sees in the cases of 
> > these failures...
> 
> Maxim Khutornenko wrote:
> The stack is logged by requests-kerberos [1] before we get any chance to 
> react to it. I don't see an easy way to disable that logging without hiding 
> other (possibly important for troubleshooting) requests messages.
> 
> [1] - 
> https://github.com/requests/requests-kerberos/blob/master/requests_kerberos/kerberos_.py#L105-L133
> 
> Bill Farner wrote:
> Can you use the verbose flag and squash the logging when we're not 
> verbose?  This could cause us to lose information in rare non-repeatable 
> scenarios, but i'd be willing to risk that to provide a better experience in 
> normal cases.

+1. I'd be ok with asking users to re-run with --verbose for the rare case if 
it means less support requests for failures to kinit.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104566
---


On Oct. 30, 2015, 2:24 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Oct. 30, 2015, 2:24 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
> GSSError: ((' Miscellaneous failure (see text)', 851968), ('No credentials 
> cache file found', -1765328189))
> ERROR] Communication with Aurora scheduler is kerberized. Did you forget to 
> run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Bill Farner 


> On Oct. 30, 2015, 7:31 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 305-306
> > 
> >
> > It seems like this friendly error message is going to get buried at the 
> > top of the stack trace?
> > 
> > The output will be something like...
> > 
> > ERROR] Hey! Run kinit!
> > ERROR] GSS Error: (('Unspecified GSS failure...)
> > ...
> > 20 lines of stacktrace follow
> > ...
> > 
> > I'm not sure if there's any way around that, but it would certainly be 
> > nice to have "run kinit" be the last thing the user sees in the cases of 
> > these failures...
> 
> Maxim Khutornenko wrote:
> The stack is logged by requests-kerberos [1] before we get any chance to 
> react to it. I don't see an easy way to disable that logging without hiding 
> other (possibly important for troubleshooting) requests messages.
> 
> [1] - 
> https://github.com/requests/requests-kerberos/blob/master/requests_kerberos/kerberos_.py#L105-L133

Can you use the verbose flag and squash the logging when we're not verbose?  
This could cause us to lose information in rare non-repeatable scenarios, but 
i'd be willing to risk that to provide a better experience in normal cases.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104566
---


On Oct. 29, 2015, 7:24 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Oct. 29, 2015, 7:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
> GSSError: ((' Miscellaneous failure (see text)', 851968), ('No credentials 
> cache file found', -1765328189))
> ERROR] Communication with Aurora scheduler is kerberized. Did you forget to 
> run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39797: Adding help message in case kerberos auth fails.

2015-11-02 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39797/#review104755
---


Ping Bill, Joshua.

- Maxim Khutornenko


On Oct. 30, 2015, 2:24 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39797/
> ---
> 
> (Updated Oct. 30, 2015, 2:24 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1364
> https://issues.apache.org/jira/browse/AURORA-1364
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only reasonable way to wire it in is via the AuthModule, which is the 
> only entity aware of the auth approach used.
> 
> Also, dropped AuthModule.payload() as it's no longer needed (SessionKey 
> thrift struct is empty now).
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea 
>   src/main/python/apache/aurora/kerberos/auth_module.py 
> fade00504a3122bc4b93e1cc1b7ebac6415303da 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39797/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python::
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Example error message:
> ```
> ...
> GSSError: ((' Miscellaneous failure (see text)', 851968), ('No credentials 
> cache file found', -1765328189))
> ERROR] Communication with Aurora scheduler is kerberized. Did you forget to 
> run "kinit"?
> 401 Client Error: Authorization Required
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 39854: Retry scheduler connection after unknown failures

2015-11-02 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39854/#review104754
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 2, 2015, 1:09 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39854/
> ---
> 
> (Updated Nov. 2, 2015, 1:09 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1533
> https://issues.apache.org/jira/browse/AURORA-1533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry scheduler connection after unknown failures.
> 
> The `with_scheduler` decorator used to guard the connection using a check of 
> `self._scheduler_client`. However, `_construct_scheduler` always sets 
> `self._scheduler_client` even though the actual thrift client in 
> `self._client` could not be created. This rendered the client useless, as it 
> can neither dispatch calls to Aurora, nor does it try to re-establish the 
> connection.
> 
> Many known classes of connection errors have not been affected by this bug 
> because those are explicitly handled in `method_wrapper` with a call to 
> `self.invalidate()`.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39854/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --options=-v 
> src/test/python/apache/aurora/client/api:scheduler_client
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 39822: upgrade psutil to 3.2.2

2015-11-02 Thread Dmitriy Shirchenko 


> On Nov. 1, 2015, 4:59 p.m., Bill Farner wrote:
> > Ship It!

sweet, if there are no other objections, can someone land this for me, please?


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39822/#review104661
---


On Oct. 30, 2015, 8:14 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39822/
> ---
> 
> (Updated Oct. 30, 2015, 8:14 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1531
> https://issues.apache.org/jira/browse/AURORA-1531
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> upgrade psutil to 3.2.2
> psutil changelog:
> https://github.com/giampaolo/psutil/blob/36316de315a55dece354cf98533e647d7f62c49b/HISTORY.rst
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
> 
> Diff: https://reviews.apache.org/r/39822/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104743
---

Ship it!


Applying your patch works for me on OS X 10.11- thanks!

- Joe Smith


On Oct. 29, 2015, 3:05 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
> 
> (Updated Oct. 29, 2015, 3:05 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew.  Of note, the script is checked
> in with chmod 555, its not intended to be edited.
> 
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
> 
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
> 
>  .pantsversion  |   1 -
>  3rdparty/python/requirements.txt   |   2 +-
>  BUILD  |  25 -
>  BUILD.tools|  19 --
>  build-support/jenkins/build.sh |   2 +-
>  build-support/pants_requirements.txt   |  30 ---
>  build-support/python/make-pycharm-virtualenv   |  11 +-
>  build-support/python/update-pants-requirements |  34 -
>  pants  | 102 
> +++---
>  pants.ini  |  63 
> ++-
>  src/main/python/apache/aurora/tools/BUILD  |   2 +-
>  src/main/python/apache/thermos/observer/BUILD  |   2 +-
>  12 files changed, 114 insertions(+), 179 deletions(-)
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
>   BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
>   build-support/python/make-pycharm-virtualenv 
> d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
>   build-support/python/update-pants-requirements 
> 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
>   pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 
>   pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 
>   src/main/python/apache/aurora/tools/BUILD 
> e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 
>   src/main/python/apache/thermos/observer/BUILD 
> d7eedabc0930711530b45ac98a1159e69d1a0c00 
> 
> Diff: https://reviews.apache.org/r/39784/diff/
> 
> 
> Testing
> ---
> 
> Locally: `./pants test.pytest --no-fast src/test/python:: -- -v`
> 
> Also generated a pycharm project via:
>   `./build-support/python/make-pycharm-virtualenv`
> Confirmed library source linking worked as did running unit tests
> via the IDE.
> 
> Also grepped for pants commands in the repo, found `binary` and `setup-py`
> and confirmed these worked.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois 


> On Oct. 29, 2015, 4:15 p.m., Zameer Manji wrote:
> > John, would you mind filing a ticket to track the followup work to use the 
> > built in pants checkstyle?
> 
> Joe Smith wrote:
> https://issues.apache.org/jira/browse/AURORA-1532

Thanks Joe.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104483
---


On Oct. 29, 2015, 4:05 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
> 
> (Updated Oct. 29, 2015, 4:05 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew.  Of note, the script is checked
> in with chmod 555, its not intended to be edited.
> 
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
> 
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
> 
>  .pantsversion  |   1 -
>  3rdparty/python/requirements.txt   |   2 +-
>  BUILD  |  25 -
>  BUILD.tools|  19 --
>  build-support/jenkins/build.sh |   2 +-
>  build-support/pants_requirements.txt   |  30 ---
>  build-support/python/make-pycharm-virtualenv   |  11 +-
>  build-support/python/update-pants-requirements |  34 -
>  pants  | 102 
> +++---
>  pants.ini  |  63 
> ++-
>  src/main/python/apache/aurora/tools/BUILD  |   2 +-
>  src/main/python/apache/thermos/observer/BUILD  |   2 +-
>  12 files changed, 114 insertions(+), 179 deletions(-)
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
>   BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
>   build-support/python/make-pycharm-virtualenv 
> d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
>   build-support/python/update-pants-requirements 
> 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
>   pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 
>   pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 
>   src/main/python/apache/aurora/tools/BUILD 
> e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 
>   src/main/python/apache/thermos/observer/BUILD 
> d7eedabc0930711530b45ac98a1159e69d1a0c00 
> 
> Diff: https://reviews.apache.org/r/39784/diff/
> 
> 
> Testing
> ---
> 
> Locally: `./pants test.pytest --no-fast src/test/python:: -- -v`
> 
> Also generated a pycharm project via:
>   `./build-support/python/make-pycharm-virtualenv`
> Confirmed library source linking worked as did running unit tests
> via the IDE.
> 
> Also grepped for pants commands in the repo, found `binary` and `setup-py`
> and confirmed these worked.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois 


> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > Would you also mind updating the commit message to point to the pants 
> > changelog?

Will do.


> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > BUILD.tools, line 1
> > 
> >
> > Aurora only uses pants for Python code. If we need to specify these JVM 
> > artifacts for it to work right now, can you please maintain the reference 
> > to issue 867?

Did not mean to nuke that - will restore.


> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > pants.ini, line 14
> > 
> >
> > Is this comment relevant anymore? If not mind removing it?

I'll kill it, its not a lie, but not particularaly useful.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104484
---


On Oct. 29, 2015, 4:05 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
> 
> (Updated Oct. 29, 2015, 4:05 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew.  Of note, the script is checked
> in with chmod 555, its not intended to be edited.
> 
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
> 
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
> 
>  .pantsversion  |   1 -
>  3rdparty/python/requirements.txt   |   2 +-
>  BUILD  |  25 -
>  BUILD.tools|  19 --
>  build-support/jenkins/build.sh |   2 +-
>  build-support/pants_requirements.txt   |  30 ---
>  build-support/python/make-pycharm-virtualenv   |  11 +-
>  build-support/python/update-pants-requirements |  34 -
>  pants  | 102 
> +++---
>  pants.ini  |  63 
> ++-
>  src/main/python/apache/aurora/tools/BUILD  |   2 +-
>  src/main/python/apache/thermos/observer/BUILD  |   2 +-
>  12 files changed, 114 insertions(+), 179 deletions(-)
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
>   BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
>   build-support/python/make-pycharm-virtualenv 
> d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
>   build-support/python/update-pants-requirements 
> 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
>   pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 
>   pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 
>   src/main/python/apache/aurora/tools/BUILD 
> e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 
>   src/main/python/apache/thermos/observer/BUILD 
> d7eedabc0930711530b45ac98a1159e69d1a0c00 
> 
> Diff: https://reviews.apache.org/r/39784/diff/
> 
> 
> Testing
> ---
> 
> Locally: `./pants test.pytest --no-fast src/test/python:: -- -v`
> 
> Also generated a pycharm project via:
>   `./build-support/python/make-pycharm-virtualenv`
> Confirmed library source linking worked as did running unit tests
> via the IDE.
> 
> Also grepped for pants commands in the repo, found `binary` and `setup-py`
> and confirmed these worked.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois 


> On Oct. 29, 2015, 4:26 p.m., Zameer Manji wrote:
> > pants.ini, line 84
> > 
> >
> > Follow up comment, should we bump this value to the latest setuptools 
> > release?
> 
> Stephan Erb wrote:
> +1

There was a specific comment that was guiding me to leave this alone in 
build-support/release/make-python-sdists, but now that I re-read the issue it 
highlights is different.

Will do.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104487
---


On Oct. 29, 2015, 4:05 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
> 
> (Updated Oct. 29, 2015, 4:05 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew.  Of note, the script is checked
> in with chmod 555, its not intended to be edited.
> 
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
> 
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
> 
>  .pantsversion  |   1 -
>  3rdparty/python/requirements.txt   |   2 +-
>  BUILD  |  25 -
>  BUILD.tools|  19 --
>  build-support/jenkins/build.sh |   2 +-
>  build-support/pants_requirements.txt   |  30 ---
>  build-support/python/make-pycharm-virtualenv   |  11 +-
>  build-support/python/update-pants-requirements |  34 -
>  pants  | 102 
> +++---
>  pants.ini  |  63 
> ++-
>  src/main/python/apache/aurora/tools/BUILD  |   2 +-
>  src/main/python/apache/thermos/observer/BUILD  |   2 +-
>  12 files changed, 114 insertions(+), 179 deletions(-)
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
>   BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
>   build-support/python/make-pycharm-virtualenv 
> d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
>   build-support/python/update-pants-requirements 
> 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
>   pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 
>   pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 
>   src/main/python/apache/aurora/tools/BUILD 
> e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 
>   src/main/python/apache/thermos/observer/BUILD 
> d7eedabc0930711530b45ac98a1159e69d1a0c00 
> 
> Diff: https://reviews.apache.org/r/39784/diff/
> 
> 
> Testing
> ---
> 
> Locally: `./pants test.pytest --no-fast src/test/python:: -- -v`
> 
> Also generated a pycharm project via:
>   `./build-support/python/make-pycharm-virtualenv`
> Confirmed library source linking worked as did running unit tests
> via the IDE.
> 
> Also grepped for pants commands in the repo, found `binary` and `setup-py`
> and confirmed these worked.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois 


> On Oct. 29, 2015, 4:57 p.m., Aurora ReviewBot wrote:
> > Master (bcb4774) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > 22:56:59 00:00   [unpack-jars]
> > 22:56:59 00:00 [unpack-jars]
> > 22:56:59 00:00   [deferred-sources]
> > 22:56:59 00:00 [deferred-sources]
> > 22:56:59 00:00   [jvm-platform-validate]
> > 22:56:59 00:00 [jvm-platform-validate]
> > 22:56:59 00:00   [gen]
> > 22:56:59 00:00 [thrift]
> > 22:56:59 00:00 [protoc]
> > 22:56:59 00:00 [antlr]
> > 22:56:59 00:00 [ragel]
> > 22:56:59 00:00 [jaxb]
> > 22:57:00 00:01 [wire]
> > 22:57:00 00:01   [resolve]
> > 22:57:00 00:01 [ivy]
> > 22:57:00 00:01   [ivy-bootstrap]
> > 22:57:02 00:03   [bootstrap-nailgun-server]
> > 22:57:02 00:03   [compile]
> > 22:57:02 00:03 [compile]
> > 22:57:02 00:03 [jvm]
> > 22:57:02 00:03   [jvm-compilers]
> > 22:57:02 00:03 [zinc-pre]
> > 22:57:02 00:03 [zinc-post]
> > 22:57:03 00:04 [jvm-dep-check]
> > 22:57:03 00:04   [resources]
> > 22:57:03 00:04 [prepare]
> > 22:57:03 00:04 [services]
> > 22:57:03 00:04   [test]
> > 22:57:03 00:04 [run_prep_command]
> > 22:57:03 00:04 [test]
> > 22:57:03 00:04 [pytest]
> > 22:57:03 00:04   [run]
> >  
> > 22:57:07 00:08 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > INFO] Fetched thrift binary from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  .
> > 
> > 22:57:15 00:16   [complete]
> >FAILURE
> > Exception message: Ambiguous resolvable: thrift
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

I need to dig in here, this is unexpected.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104495
---


On Oct. 29, 2015, 4:05 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
> 
> (Updated Oct. 29, 2015, 4:05 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew.  Of note, the script is checked
> in with chmod 555, its not intended to be edited.
> 
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
> 
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
> 
>  .pantsversion  |   1 -
>  3rdparty/python/requirements.txt   |   2 +-
>  BUILD  |  25 -
>  BUILD.tools|  19 --
>  build-support/jenkins/build.sh |   2 +-
>  build-support/pants_requirements.txt   |  30 ---
>  build-support/python/make-pycharm-virtualenv   |  11 +-
>  build-support/python/update-pants-requirements |  34 -
>  pants  | 102 
> +++---
>  pants.ini  |  63 
> ++-
>  src/main/python/apache/aurora/tools/BUILD  |   2 +-
>  src/main/python/apache/thermos/observer/BUILD  |   2 +-
>  12 files changed, 114 insertions(+), 179 deletions(-)
> 
> 
> Diffs
> -
> 
>   .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 
>   3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 
>   BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 
>   BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/pants_requirements.txt 
> fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 
>   build-support/python/make-pycharm-virtualenv 
> d7bd41835bcd9a8fe62ea522a177bfa7830a897b 
>   build-support/python/update-pants-requirements 
> 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec 
>   pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 
>   pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 
>   src/main/python/apache/aurora/tools/BUILD 
> e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 
>   src/main/python/apache/thermos/observer/BUILD 
> d7eedabc0930711530b45ac98a1159e69d1a0c00 
> 
> Diff: https://reviews.apache.org/r/39784/diff/
>

Re: Review Request 39854: Retry scheduler connection after unknown failures

2015-11-02 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39854/#review104719
---

Ship it!


Ship It!

- Bill Farner


On Nov. 2, 2015, 5:09 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39854/
> ---
> 
> (Updated Nov. 2, 2015, 5:09 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1533
> https://issues.apache.org/jira/browse/AURORA-1533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry scheduler connection after unknown failures.
> 
> The `with_scheduler` decorator used to guard the connection using a check of 
> `self._scheduler_client`. However, `_construct_scheduler` always sets 
> `self._scheduler_client` even though the actual thrift client in 
> `self._client` could not be created. This rendered the client useless, as it 
> can neither dispatch calls to Aurora, nor does it try to re-establish the 
> connection.
> 
> Many known classes of connection errors have not been affected by this bug 
> because those are explicitly handled in `method_wrapper` with a call to 
> `self.invalidate()`.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39854/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --options=-v 
> src/test/python/apache/aurora/client/api:scheduler_client
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 39854: Retry scheduler connection after unknown failures

2015-11-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39854/#review104704
---

Ship it!


Master (b712d57) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 2, 2015, 1:09 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39854/
> ---
> 
> (Updated Nov. 2, 2015, 1:09 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1533
> https://issues.apache.org/jira/browse/AURORA-1533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry scheduler connection after unknown failures.
> 
> The `with_scheduler` decorator used to guard the connection using a check of 
> `self._scheduler_client`. However, `_construct_scheduler` always sets 
> `self._scheduler_client` even though the actual thrift client in 
> `self._client` could not be created. This rendered the client useless, as it 
> can neither dispatch calls to Aurora, nor does it try to re-establish the 
> connection.
> 
> Many known classes of connection errors have not been affected by this bug 
> because those are explicitly handled in `method_wrapper` with a call to 
> `self.invalidate()`.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 
> 
> Diff: https://reviews.apache.org/r/39854/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --options=-v 
> src/test/python/apache/aurora/client/api:scheduler_client
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 39854: Retry scheduler connection after unknown failures

2015-11-02 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39854/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-1533
https://issues.apache.org/jira/browse/AURORA-1533


Repository: aurora


Description
---

Retry scheduler connection after unknown failures.

The `with_scheduler` decorator used to guard the connection using a check of 
`self._scheduler_client`. However, `_construct_scheduler` always sets 
`self._scheduler_client` even though the actual thrift client in `self._client` 
could not be created. This rendered the client useless, as it can neither 
dispatch calls to Aurora, nor does it try to re-establish the connection.

Many known classes of connection errors have not been affected by this bug 
because those are explicitly handled in `method_wrapper` with a call to 
`self.invalidate()`.


Diffs
-

  src/main/python/apache/aurora/client/api/scheduler_client.py 
8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 

Diff: https://reviews.apache.org/r/39854/diff/


Testing
---

./pants test.pytest --options=-v 
src/test/python/apache/aurora/client/api:scheduler_client


Thanks,

Stephan Erb