Re: Review Request 28696: Use abstract decorators in CommandLine class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review64247 --- Ship it! Ship It! - Bill Farner On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/ --- (Updated Dec. 4, 2014, 7:40 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 Diff: https://reviews.apache.org/r/28696/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28696: Use abstract decorators in CommandLine class.
On Dec. 8, 2014, 5:58 p.m., Bill Farner wrote: Ship It! This is now on master: ``` $ git log -1 --abbrev-commit origin/master commit a9e1217 Author: Zameer Manji zma...@twopensource.com Date: Mon Dec 8 09:59:32 2014 -0800 Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Reviewed at https://reviews.apache.org/r/28696/ ``` - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review64247 --- On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/ --- (Updated Dec. 4, 2014, 7:40 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 Diff: https://reviews.apache.org/r/28696/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review64259
---
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
https://reviews.apache.org/r/28617/#comment106898
Can you add this as a member to the Veto interface instead? This will
ensure we don't add new Veto types without updating this map.
Like
```java
interface Veto {
VetoGroup getVetoGroup();
}
```
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
https://reviews.apache.org/r/28617/#comment106899
If you follow the comment above this block becomes unnecessary.
- Kevin Sweeney
On Dec. 5, 2014, 2:57 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/
---
(Updated Dec. 5, 2014, 2:57 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-909
https://issues.apache.org/jira/browse/AURORA-909
Repository: aurora
Description
---
Modified the task offer/task matching logic to skip offer matching for tasks
previously vetoed statically.
Preliminary testing in vagrant (see pictures below) shows close to 50%
improvement in task scheduling performance.
Update:
Testing with JMH (https://reviews.apache.org/r/28710/ and
https://reviews.apache.org/r/28731/) shows over 97% better perf:
```
Master with cluster fillup 0.9:
Benchmark
Mode SamplesScoreError Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 8291046.074 ± 145251.995 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 7522269.050 ± 142446.265 ns/op
This RB with cluster fillup 0.9:
Benchmark
Mode Samples Score Error Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 204171.046 ± 3800.124 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 215854.129 ± 8959.851 ns/op
```
Diffs
-
src/main/java/org/apache/aurora/scheduler/TaskVars.java
f017cdd26ca40138a7e141f21613ed567314c399
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java
f66383830140e5eaba436f35ebb5192eee65947a
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
ead9d28100673440168a32d114ecaa15874978a6
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
c2a342ce07bfb223193886038761f0da5230135d
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
1cb56f19c331508a1585077e9c4a98f52aac343b
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
e1c29747c9854cf75bf63f6f085cf40ca68989af
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
4e7efb3c1214c3d193afd61f162713490eb8effb
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java
4cf602ad32b972c18eb5a81e9b2f59c67859bdb2
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java
5647349854a5e04de749c4d809684a0066d4da06
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
6cc13231560996b144101eba36577f49017aba06
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
265c38d20136210e7639ac8ea915d307a4b72949
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
411a55a8d85f60bb2703468f2d69b64b2736eee4
Diff: https://reviews.apache.org/r/28617/diff/
Testing
---
./gradlew -Pq build
Tested in vagrant
File Attachments
NoStaticVetoFiltering.png
https://reviews.apache.org/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png
StaticVetoFiltering.png
https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
Review Request 28806: More logging in MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28806/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-935 https://issues.apache.org/jira/browse/AURORA-935 Repository: aurora Description --- More logging in MaintenanceController. Diffs - src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda Diff: https://reviews.apache.org/r/28806/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:57 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Updated testing to show new log format. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing (updated) --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Update successful Update completed successfully
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:58 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Update the code to use PlainFormatter to remove logger name in output. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Update successful Update completed successfully
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64266 --- Ship it! Ship It! - Bill Farner On Dec. 8, 2014, 7:58 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 7:58 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$
Re: Review Request 28806: More logging in MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28806/#review64267 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java https://reviews.apache.org/r/28806/#comment106903 How about `Host %s still DRAINING tasks: %s` - Bill Farner On Dec. 8, 2014, 7:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28806/ --- (Updated Dec. 8, 2014, 7:53 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-935 https://issues.apache.org/jira/browse/AURORA-935 Repository: aurora Description --- More logging in MaintenanceController. Diffs - src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda Diff: https://reviews.apache.org/r/28806/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64268 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 7:58 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 7:58 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold
Re: Review Request 28806: More logging in MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28806/#review64269 --- Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 7:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28806/ --- (Updated Dec. 8, 2014, 7:53 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-935 https://issues.apache.org/jira/browse/AURORA-935 Repository: aurora Description --- More logging in MaintenanceController. Diffs - src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 8e6f4e7c18df4bac4dab747f05803e8e25b43cda Diff: https://reviews.apache.org/r/28806/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64270 --- src/main/python/apache/aurora/client/cli/client.py https://reviews.apache.org/r/28742/#comment106906 Is there a test for this? src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/28742/#comment106904 This can now be simplified with `base.combine_messages(resp)`. - Maxim Khutornenko On Dec. 8, 2014, 7:58 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 7:58 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO]
Re: Review Request 28742: Simplify logging in the client.
On Dec. 8, 2014, 12:33 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/client.py, lines 52-54 https://reviews.apache.org/r/28742/diff/4/?file=785651#file785651line52 Is there a test for this? There isn't a test. Adding a unit test is difficult because it modifies global interpreter state (logging module). - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64270 --- On Dec. 8, 2014, 11:58 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:58 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO]
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 12:50 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Use combine_messages. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Update successful Update completed successfully vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64278 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 8:50 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 8:50 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold
Review Request 28811: Improving logging experience in admin drain_hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64283 --- src/main/python/apache/aurora/admin/host_maintenance.py https://reviews.apache.org/r/28811/#comment106920 Can you elaborate why this is an improvement? AFAICT the former messaging was more accurate - we print out the hosts that you're waiting for, and will be queried/tracked. This change might make sense if we did _not_ do the initial DRAINED filtering here, and allow the caller to report that these hosts are ready. Finally - you should consider inlining this function - there's hardly any behavior here, and there's only one caller. src/main/python/apache/aurora/admin/host_maintenance.py https://reviews.apache.org/r/28811/#comment106921 Should this be: `self.check_if_drained(drainable_hostnames)` It seems strange that if we're watching 2 hosts, and 1 moves to DRAINED, we keep querying for its state. Coupled with the logging change in this diff, it appears that you'll keep logging the same hostnames over and over. - Bill Farner On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 85 https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line85 Should this be: `self.check_if_drained(drainable_hostnames)` It seems strange that if we're watching 2 hosts, and 1 moves to DRAINED, we keep querying for its state. Coupled with the logging change in this diff, it appears that you'll keep logging the same hostnames over and over. Not sure I understand. The `not_drained_hostnames =` assignment takes care of progressively reducing the logged hostset, so a DRAINED host will never show up in any of the subsequent iterations. On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 61 https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line61 Can you elaborate why this is an improvement? AFAICT the former messaging was more accurate - we print out the hosts that you're waiting for, and will be queried/tracked. This change might make sense if we did _not_ do the initial DRAINED filtering here, and allow the caller to report that these hosts are ready. Finally - you should consider inlining this function - there's hardly any behavior here, and there's only one caller. The current log placement may generate an empty message when draining is done faster than the initial wait interval, giving a somewhat confusing user experience. The reordering here makes sure a user sees the initial draining batch in the log at least once. I am fine with inlining if it makes things easier to read. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64283 --- On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64287 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 85 https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line85 Should this be: `self.check_if_drained(drainable_hostnames)` It seems strange that if we're watching 2 hosts, and 1 moves to DRAINED, we keep querying for its state. Coupled with the logging change in this diff, it appears that you'll keep logging the same hostnames over and over. Maxim Khutornenko wrote: Not sure I understand. The `not_drained_hostnames =` assignment takes care of progressively reducing the logged hostset, so a DRAINED host will never show up in any of the subsequent iterations. Got it now, you probably meant `not_drained_hostnames` as a parameter there. Makes sense. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64283 --- On Dec. 8, 2014, 9:13 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 10:43 p.m.) Review request for Aurora and Bill Farner. Changes --- CR comments. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs (updated) - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.
On Dec. 8, 2014, 7:29 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java,
line 102
https://reviews.apache.org/r/28617/diff/2/?file=784162#file784162line102
Can you add this as a member to the Veto interface instead? This will
ensure we don't add new Veto types without updating this map.
Like
```java
interface Veto {
VetoGroup getVetoGroup();
}
```
There is no Veto interface and I am hesitant to create one just for this
method. I have moved the group assignment into the VetoType instead. That also
helped to get rid of a null check code not reachable from unit tests.
On Dec. 8, 2014, 7:29 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java,
line 181
https://reviews.apache.org/r/28617/diff/2/?file=784162#file784162line181
If you follow the comment above this block becomes unnecessary.
Gone.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review64259
---
On Dec. 5, 2014, 10:57 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/
---
(Updated Dec. 5, 2014, 10:57 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-909
https://issues.apache.org/jira/browse/AURORA-909
Repository: aurora
Description
---
Modified the task offer/task matching logic to skip offer matching for tasks
previously vetoed statically.
Preliminary testing in vagrant (see pictures below) shows close to 50%
improvement in task scheduling performance.
Update:
Testing with JMH (https://reviews.apache.org/r/28710/ and
https://reviews.apache.org/r/28731/) shows over 97% better perf:
```
Master with cluster fillup 0.9:
Benchmark
Mode SamplesScoreError Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 8291046.074 ± 145251.995 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 7522269.050 ± 142446.265 ns/op
This RB with cluster fillup 0.9:
Benchmark
Mode Samples Score Error Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 204171.046 ± 3800.124 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 215854.129 ± 8959.851 ns/op
```
Diffs
-
src/main/java/org/apache/aurora/scheduler/TaskVars.java
f017cdd26ca40138a7e141f21613ed567314c399
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java
f66383830140e5eaba436f35ebb5192eee65947a
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
ead9d28100673440168a32d114ecaa15874978a6
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
c2a342ce07bfb223193886038761f0da5230135d
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
1cb56f19c331508a1585077e9c4a98f52aac343b
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
e1c29747c9854cf75bf63f6f085cf40ca68989af
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
4e7efb3c1214c3d193afd61f162713490eb8effb
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java
4cf602ad32b972c18eb5a81e9b2f59c67859bdb2
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java
5647349854a5e04de749c4d809684a0066d4da06
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
6cc13231560996b144101eba36577f49017aba06
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
265c38d20136210e7639ac8ea915d307a4b72949
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
411a55a8d85f60bb2703468f2d69b64b2736eee4
Diff: https://reviews.apache.org/r/28617/diff/
Testing
---
./gradlew -Pq build
Tested in vagrant
File Attachments
NoStaticVetoFiltering.png
https://reviews.apache.org/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png
StaticVetoFiltering.png
https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/ --- (Updated Dec. 8, 2014, 10:57 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments. Bugs: AURORA-909 https://issues.apache.org/jira/browse/AURORA-909 Repository: aurora Description --- Modified the task offer/task matching logic to skip offer matching for tasks previously vetoed statically. Preliminary testing in vagrant (see pictures below) shows close to 50% improvement in task scheduling performance. Update: Testing with JMH (https://reviews.apache.org/r/28710/ and https://reviews.apache.org/r/28731/) shows over 97% better perf: ``` Master with cluster fillup 0.9: Benchmark Mode SamplesScoreError Units o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example avgt 100 8291046.074 ± 145251.995 ns/op o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 7522269.050 ± 142446.265 ns/op This RB with cluster fillup 0.9: Benchmark Mode Samples Score Error Units o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example avgt 100 204171.046 ± 3800.124 ns/op o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 215854.129 ± 8959.851 ns/op ``` Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java f017cdd26ca40138a7e141f21613ed567314c399 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java f66383830140e5eaba436f35ebb5192eee65947a src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ead9d28100673440168a32d114ecaa15874978a6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c2a342ce07bfb223193886038761f0da5230135d src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 1cb56f19c331508a1585077e9c4a98f52aac343b src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java e1c29747c9854cf75bf63f6f085cf40ca68989af src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 4e7efb3c1214c3d193afd61f162713490eb8effb src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 4cf602ad32b972c18eb5a81e9b2f59c67859bdb2 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 6cc13231560996b144101eba36577f49017aba06 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 265c38d20136210e7639ac8ea915d307a4b72949 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 411a55a8d85f60bb2703468f2d69b64b2736eee4 Diff: https://reviews.apache.org/r/28617/diff/ Testing --- ./gradlew -Pq build Tested in vagrant File Attachments NoStaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png StaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png Thanks, Maxim Khutornenko
Re: Review Request 28742: Simplify logging in the client.
On Dec. 8, 2014, 12:33 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/client.py, lines 52-54 https://reviews.apache.org/r/28742/diff/4/?file=785651#file785651line52 Is there a test for this? Zameer Manji wrote: There isn't a test. Adding a unit test is difficult because it modifies global interpreter state (logging module). Maxim Khutornenko wrote: Given this feature has been broken for a long time, I highly suggest adding a test for it. FWIW, here is a relevant example of mocking/patching the logger: https://reviews.apache.org/r/28811/ Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64270 --- On Dec. 8, 2014, 3:18 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 3:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 3:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Add unit test for logging plugin. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Update successful Update
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64309 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 11:18 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance:
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64310 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 8, 2014, 11:18 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing
Re: Review Request 28742: Simplify logging in the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64311 --- On master now. - Maxim Khutornenko On Dec. 8, 2014, 11:18 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom aurora_client logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the --verbose-logging and --logging-level flags with a single --verbose/-v flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing --- ./pants ./src/test/python/apache/aurora:: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing
Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/#review64314 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 10:57 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/ --- (Updated Dec. 8, 2014, 10:57 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-909 https://issues.apache.org/jira/browse/AURORA-909 Repository: aurora Description --- Modified the task offer/task matching logic to skip offer matching for tasks previously vetoed statically. Preliminary testing in vagrant (see pictures below) shows close to 50% improvement in task scheduling performance. Update: Testing with JMH (https://reviews.apache.org/r/28710/ and https://reviews.apache.org/r/28731/) shows over 97% better perf: ``` Master with cluster fillup 0.9: Benchmark Mode SamplesScoreError Units o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example avgt 100 8291046.074 ± 145251.995 ns/op o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 7522269.050 ± 142446.265 ns/op This RB with cluster fillup 0.9: Benchmark Mode Samples Score Error Units o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example avgt 100 204171.046 ± 3800.124 ns/op o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example avgt 100 215854.129 ± 8959.851 ns/op ``` Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java f017cdd26ca40138a7e141f21613ed567314c399 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java f66383830140e5eaba436f35ebb5192eee65947a src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ead9d28100673440168a32d114ecaa15874978a6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c2a342ce07bfb223193886038761f0da5230135d src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 1cb56f19c331508a1585077e9c4a98f52aac343b src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java e1c29747c9854cf75bf63f6f085cf40ca68989af src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 4e7efb3c1214c3d193afd61f162713490eb8effb src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 4cf602ad32b972c18eb5a81e9b2f59c67859bdb2 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 6cc13231560996b144101eba36577f49017aba06 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 265c38d20136210e7639ac8ea915d307a4b72949 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 411a55a8d85f60bb2703468f2d69b64b2736eee4 Diff: https://reviews.apache.org/r/28617/diff/ Testing --- ./gradlew -Pq build Tested in vagrant File Attachments NoStaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png StaticVetoFiltering.png https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png Thanks, Maxim Khutornenko
Re: Review Request 28811: Improving logging experience in admin drain_hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64315 --- Ship it! Master (a9e1217) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 8, 2014, 10:43 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 10:43 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-943 https://issues.apache.org/jira/browse/AURORA-943 Repository: aurora Description --- Improving logging experience in admin drain_hosts. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py bff8afd2b52fdf3977f681a73c97000a38773498 src/test/python/apache/aurora/admin/test_host_maintenance.py 4b8072c0349a9b0905ebb249ed97c7dfe8e8b1de Diff: https://reviews.apache.org/r/28811/diff/ Testing --- ./pants src/test/python/apache/aurora/admin:host_maintenance Thanks, Maxim Khutornenko
Review Request 28831: Changing the default --batch-size to 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-961 https://issues.apache.org/jira/browse/AURORA-961 Repository: aurora Description --- Also, cleaned up kill command tests a bit. Diffs - src/main/python/apache/aurora/client/cli/options.py e844cf340583b631ce194352f403bbaec71655b7 src/test/python/apache/aurora/client/cli/test_kill.py 1eda72af4c19831ae27733f506858e67772b2075 src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074 Diff: https://reviews.apache.org/r/28831/diff/ Testing --- ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko
Re: Review Request 28831: Changing the default --batch-size to 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64326 --- Ship it! Master (9926af3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- (Updated Dec. 9, 2014, 1:25 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-961 https://issues.apache.org/jira/browse/AURORA-961 Repository: aurora Description --- Also, cleaned up kill command tests a bit. Diffs - src/main/python/apache/aurora/client/cli/options.py e844cf340583b631ce194352f403bbaec71655b7 src/test/python/apache/aurora/client/cli/test_kill.py 1eda72af4c19831ae27733f506858e67772b2075 src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074 Diff: https://reviews.apache.org/r/28831/diff/ Testing --- ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko
Re: Review Request 28831: Changing the default --batch-size to 1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64333 --- thanks for the drive-by cleanups! src/test/python/apache/aurora/client/cli/test_kill.py https://reviews.apache.org/r/28831/#comment106977 I believe this should be of the form `assert foo.mock_calls == [x]` Ditto elsewhere. - Bill Farner On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- (Updated Dec. 9, 2014, 1:25 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-961 https://issues.apache.org/jira/browse/AURORA-961 Repository: aurora Description --- Also, cleaned up kill command tests a bit. Diffs - src/main/python/apache/aurora/client/cli/options.py e844cf340583b631ce194352f403bbaec71655b7 src/test/python/apache/aurora/client/cli/test_kill.py 1eda72af4c19831ae27733f506858e67772b2075 src/test/python/apache/aurora/client/cli/util.py 67d7eaa6eff4e1dbaaa485166e084812a4f04074 Diff: https://reviews.apache.org/r/28831/diff/ Testing --- ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko
