Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:02 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 3, 2014, 2:49 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- There we go. Uploaded the right diff this time. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
On Nov. 3, 2014, 6:03 p.m., Joshua Cohen wrote: 3rdparty/python/requirements.txt, line 1 https://reviews.apache.org/r/27492/diff/2/?file=747354#file747354line1 We should be able to skip argparse now that we're pinned to python2.7 (it was added to the stdlib). Didn't even think about that when I was converting the file. Removed. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59600 --- On Nov. 4, 2014, 12:42 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Removed argparse requirement Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 21402: Add python checkstyle hooks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/#review43078
---
build-support/python/checkstyle-check
https://reviews.apache.org/r/21402/#comment77101
Could you consolidate checkstyle and checkstyle check by sourcing the venv
and calling deactivate once you're done?
- Dan Norris
On May 13, 2014, 8:04 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/
---
(Updated May 13, 2014, 8:04 p.m.)
Review request for Aurora, Jake Farrell and Kevin Sweeney.
Bugs: AURORA-149
https://issues.apache.org/jira/browse/AURORA-149
Repository: aurora
Description
---
Consolidates python checks into build-support/python.
Adds checkstyle tool, which runs pep8, pyflakes and a number of general code
cleanliness plugins.
Should I add the proposed style guide in this review or is a subsequent
review fine? It's essentially 2sp indent, 100-col lines, naming conventions
+ a few things to make life easy in a 2.x+3.x codebase. These latter plugins
can be omitted via the -n option in the checkstyle tool.
I have a separate branch that goes through and fixes all the checkstyle
errors. It's a ~1000 line diff but mostly minor changes.
Diffs
-
.gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff
build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a
build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f
build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a
build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07
build-support/python/checkstyle PRE-CREATION
build-support/python/checkstyle-check PRE-CREATION
src/main/python/apache/aurora/client/cli/task.py
1bd746da2f39f78b1497701f69777ca3ea6b70ea
Diff: https://reviews.apache.org/r/21402/diff/
Testing
---
mba=aurora=; build-support/python/checkstyle-check src/main/python/ | grep
^\w | awk '{ print $1 }' | sort | uniq -c | sort -rn
120 E251:ERROR
90 F401:ERROR
86 T001:ERROR
65 E221:ERROR
28 T800:WARNING
27 T301:ERROR
22 T302:ERROR
20 T607:ERROR
19 E261:ERROR
17 E303:ERROR
14 E501:ERROR
13 F841:ERROR
11 E226:ERROR
8 F821:ERROR
6 T803:ERROR
6 T802:WARNING
4 T000:ERROR
4 F403:ERROR
4 E712:ERROR
3 E241:ERROR
3 E203:ERROR
3 E202:ERROR
2 T801:ERROR
2 T602:ERROR
2 T200:ERROR
2 T100:ERROR
2 T002:ERROR
2 E711:ERROR
2 E201:ERROR
1 E231:ERROR
1 E222:ERROR
1 E122:ERROR
Thanks,
Brian Wickman
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review43083 --- kevints: Is there anything still blocking this that you see? It probably needs to be rebased again since it's been sitting for awhile. - Dan Norris On April 29, 2014, 3:15 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated April 29, 2014, 3:15 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 19c33210da7c390523b5890e20a137006345a62a build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated May 15, 2014, 2:47 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Rebase. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs (updated) - build-support/pex 4cecdedcb7615de350ec36f5b8ceed2b2e0a2419 build.gradle 6f43fee22215921c40efdf1bf1c7fdff9720 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
On May 6, 2014, 6:59 p.m., Brian Wickman wrote:
src/test/python/apache/aurora/executor/test_thermos_executor.py, line 213
https://reviews.apache.org/r/21055/diff/1/?file=574139#file574139line213
out of curiosity, how does this ever work? checker should always be an
instance and not a class, so issubclass will fail:
f = Foo()
issubclass(f, Foo)
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: issubclass() arg 1 must be a class
the constructor of ChainedStatusChecker also ensures that all inputs
are instances of the StatusChecker interface:
class ChainedStatusChecker(StatusChecker):
def __init__(self, status_checkers):
self._status_checkers = status_checkers
self._status = None
if not all(isinstance(h_i, StatusChecker) for h_i in
status_checkers):
raise TypeError('ChainedStatusChecker must take an iterable of
StatusCheckers.')
super(ChainedStatusChecker, self).__init__()
That's a copy/paste error on my part. It should have been:
if issubclass(type(checker), StatusChecker):
The whole reason for that line is to ensure that we don't try and call .name()
something that was coming back as a string in
te._chained_checker._status_checkers. I can send you the test output if you're
interested in taking a look.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42340
---
On May 4, 2014, 12:02 a.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/
---
(Updated May 4, 2014, 12:02 a.m.)
Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and
Brian Wickman.
Repository: aurora
Description
---
AURORA-14: Add jenkins-compatible script to build mesos core egg and run
executor-large tests
I took this over from wickman at his request (old review:
https://reviews.apache.org/r/19955/).
Changes:
- Use mesos 0.18.0 instead of 0.17.0
- Download mesos source from apache.org
- Conditionally build mesos .egg
- Fix a test in test_thermos_executor.py that was broken
Diffs
-
.mesosversion PRE-CREATION
3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6
build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f
build-support/jenkins/build_executor.sh PRE-CREATION
build-support/jenkins/build_mesos.sh PRE-CREATION
build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840
src/test/python/apache/aurora/executor/test_thermos_executor.py
0b143d0a2cbb25c1d35f79963478800a6b6713ec
Diff: https://reviews.apache.org/r/21055/diff/
Testing
---
./build-support/jenkins/build_mesos.sh ./pants
src/test/python/apache/aurora/executor:executor-large -vxs (what the new
build_executor.sh script does)
Thanks,
Dan Norris
Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21055/ --- (Updated May 4, 2014, 12:02 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Brian Wickman. Repository: aurora Description --- AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests I took this over from wickman at his request (old review: https://reviews.apache.org/r/19955/). Changes: - Use mesos 0.18.0 instead of 0.17.0 - Download mesos source from apache.org - Conditionally build mesos .egg - Fix a test in test_thermos_executor.py that was broken Diffs - .mesosversion PRE-CREATION 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f build-support/jenkins/build_executor.sh PRE-CREATION build-support/jenkins/build_mesos.sh PRE-CREATION build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 src/test/python/apache/aurora/executor/test_thermos_executor.py 0b143d0a2cbb25c1d35f79963478800a6b6713ec Diff: https://reviews.apache.org/r/21055/diff/ Testing (updated) --- ./build-support/jenkins/build_mesos.sh ./pants src/test/python/apache/aurora/executor:executor-large -vxs (what the new build_executor.sh script does) Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated April 29, 2014, 3:15 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Fix whitespace, print with a variable set to be in line with comment. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs (updated) - build-support/pex 19c33210da7c390523b5890e20a137006345a62a build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 20744: Upgrade Mesos to 0.18.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20744/ --- (Updated April 28, 2014, 1:34 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-322 https://issues.apache.org/jira/browse/AURORA-322 Repository: aurora Description --- Upgrade Mesos to 0.18.0. Unblocks AURORA-14 from switching to an apache.org source for building the Mesos .egg. Diffs - 3rdparty/python/BUILD 72e896dff8f9cdb5d797082740432b4faa4e536c build.gradle cb04661ecdbb17cac34f52167494bf08286c0841 docs/deploying-aurora-scheduler.md d50e9b8a3adf08d9d2e0b900cc9541768332715d examples/scheduler/scheduler-local.sh 8b69a4554ab00b96c15fdadb4cd50dbbf2b1016c examples/vagrant/provision-dev-cluster.sh 2b2ab0d93532bc4fdb3425aac4b306055067c6fe Diff: https://reviews.apache.org/r/20744/diff/ Testing --- Ran e2e test locally: + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated April 27, 2014, 2:10 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Rebase and simplifies the Python check in Gradle based on jfarrell's suggestion. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs (updated) - build-support/pex 19c33210da7c390523b5890e20a137006345a62a build.gradle cb04661ecdbb17cac34f52167494bf08286c0841 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/ --- (Updated April 25, 2014, 4:21 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Changes --- Rebase Bugs: AURORA-234 https://issues.apache.org/jira/browse/AURORA-234 Repository: aurora Description --- AURORA-234: Consider using markdown-style tables instead of HTML Diffs (updated) - docs/configuration-reference.md d469add1088736ce796c8d87324bf7377b444ac1 docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 Diff: https://reviews.apache.org/r/20027/diff/ Testing --- Generated the Aurora site using Middleman. Everything renders correctly, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris
Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 3:02 p.m.) Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Changes --- Added SANDBOX_DELETED. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 3db34ecf9a977fe4c84d1d00990d90248b40316e Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
On April 23, 2014, 3:14 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line 22 https://reviews.apache.org/r/20146/diff/5/?file=565577#file565577line22 Missing , for the new records. That's what I get for multitasking Fix should be up shortly. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41146 --- On April 23, 2014, 3:02 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 3:02 p.m.) Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 3db34ecf9a977fe4c84d1d00990d90248b40316e Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 24, 2014, 2:55 a.m.) Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Changes --- Added commas. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 3db34ecf9a977fe4c84d1d00990d90248b40316e Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:10 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs - src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 92045c41706ee9315f3522c3b5bbff7f6e7d2c64 Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:11 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Updated for the Angular.js switchover. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs (updated) - dist/resources/main/org/apache/aurora/scheduler/http/assets/dictionary.js PRE-CREATION dist/resources/test/org/apache/aurora/scheduler/http/assets/dictionary.js PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 3db34ecf9a977fe4c84d1d00990d90248b40316e Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 20249: AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20249/ --- (Updated April 11, 2014, 2:18 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-244 https://issues.apache.org/jira/browse/AURORA-244 Repository: aurora Description (updated) --- AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties I ended up just using the default log4j properties file that comes with Zookeeper. We might just want to write our own and use that in the Vagrant image. Diffs - examples/vagrant/upstart/aurora-scheduler.conf ec9e1b8db6a3d08c0a95765f4d78ffc43d5816b3 Diff: https://reviews.apache.org/r/20249/diff/ Testing --- In Vagrant: sudo stop aurora-scheduler; sudo rm /var/log/upstart/aurora-scheduler.log; sudo start aurora-scheduler. No more message about a missing log4j appender. Thanks, Dan Norris
Re: Review Request 20027: AURORA-234: Consider using markdown-style tables instead of HTML
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/ --- (Updated April 9, 2014, 2:28 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Changes --- Add link to commit on Github Bugs: AURORA-234 https://issues.apache.org/jira/browse/AURORA-234 Repository: aurora Description --- AURORA-234: Consider using markdown-style tables instead of HTML Diffs - docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 Diff: https://reviews.apache.org/r/20027/diff/ Testing (updated) --- Generated the Aurora site using Middleman. Everything renders correctly, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris
Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/ --- (Updated April 9, 2014, 2:31 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Changes --- Updated title Summary (updated) - AURORA-234: Replace HTML tables in docs with markdown Bugs: AURORA-234 https://issues.apache.org/jira/browse/AURORA-234 Repository: aurora Description --- AURORA-234: Consider using markdown-style tables instead of HTML Diffs - docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 Diff: https://reviews.apache.org/r/20027/diff/ Testing --- Generated the Aurora site using Middleman. Everything renders correctly, though I've updated the Jira ticket with a comparison between the two rendered tables. Commit on Github: https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97 Thanks, Dan Norris
Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-265 https://issues.apache.org/jira/browse/AURORA-265 Repository: aurora Description --- AURORA-265: Add missing tooltips for task states in dictionary.js Diffs - src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 92045c41706ee9315f3522c3b5bbff7f6e7d2c64 Diff: https://reviews.apache.org/r/20146/diff/ Testing --- Visually inspected the scheduler w/ a sample job to verify that nothing was messed up. I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states. Thanks, Dan Norris
Re: Review Request 19958: Revert AURORA-29: Clean up resource files under src/resources/org/apache/
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/#review39355 --- Ship it! Ship It! - Dan Norris On April 2, 2014, 8:49 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19958/ --- (Updated April 2, 2014, 8:49 p.m.) Review request for Aurora, Dan Norris and Bill Farner. Bugs: AURORA-14 https://issues.apache.org/jira/browse/AURORA-14 Repository: aurora Description --- Revert AURORA-29: Clean up resource files under src/resources/org/apache/ This reverts commit ad35931b2540372b5449ec5083b6473c4a61dfd1. Diffs - src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p1 PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p2 PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure/coordinator.p3 PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.a PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure_limit/coordinator.b PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/failure_limit/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/hello_world/coordinator.echo PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/hello_world/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_one PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_three PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ordering/coordinator.echo_two PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ordering/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ports/coordinator.echo PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/ports/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/coordinator.sleep PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/sleep60-lost/runner PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/sleep60/coordinator.sleep PRE-CREATION src/resources/org/apache/thermos/root/checkpoints/sleep60/runner PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p1/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p2/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p2/1/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p3/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p3/1/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure/p3/2/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/failure_limit/a/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/hello_world/echo/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/ordering/echo_one/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout PRE-CREATION src/resources/org/apache/thermos/root/sandbox/p1 PRE-CREATION src/resources/org/apache/thermos/root/sandbox/p2 PRE-CREATION src/resources/org/apache/thermos/root/sandbox/p3 PRE-CREATION src/resources/org/apache/thermos/root/tasks/active/sleep60-lost PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/failure PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/failure_limit PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/hello_world PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/ordering PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/ports PRE-CREATION src/resources/org/apache/thermos/root/tasks/finished/sleep60 PRE-CREATION Diff: https://reviews.apache.org/r/19958/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-large -vxs ... === 15 passed in 42.15 seconds === Writing log files to disk in /var/folders/4d/9tz0cd5n2n7947xs21gspsxcgp/T/tmpyFCRNS src.test.python.apache.aurora.executor.executor_builds . SUCCESS
Review Request 19819: AURORA-29: Clean up resource files under src/resources/org/apache/
/stdout bd1ced88024dd1a81ea5ea9197d64bedf153470c src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stderr e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/ordering/echo_three/0/stdout bbb02afe59338a70ee7d748f222648edae7b306f src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stderr e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/ordering/echo_two/0/stdout 0f07a6a18f57669284ef45e0c243d06d3228b692 src/resources/org/apache/thermos/root/logs/ports/echo/0/stderr e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/ports/echo/0/stdout 8bc55f97d7eb4dea22398ce0fe23986288f27109 src/resources/org/apache/thermos/root/logs/sleep60-lost/sleep/0/stderr e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/sleep60-lost/sleep/0/stdout e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/sleep60/sleep/0/stderr e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/logs/sleep60/sleep/0/stdout e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/resources/org/apache/thermos/root/sandbox/p1 f68190acd51e913e9d43c71cf422c3b1d4c5a64b src/resources/org/apache/thermos/root/sandbox/p2 c06ef8ea3fc328bc59f880a670104a7f11d64cb2 src/resources/org/apache/thermos/root/sandbox/p3 6bc16b8c7e6444e8540d9f4be0839fec342b1faf src/resources/org/apache/thermos/root/tasks/active/sleep60-lost 71562af4b0fc831a3bc6c7fdf00fca6eb810ba1d src/resources/org/apache/thermos/root/tasks/finished/failure 3362204da752ee70dade343a8f4265e0b02913be src/resources/org/apache/thermos/root/tasks/finished/failure_limit 642c4a8a69bc343b65b6d34f0b77f93035491378 src/resources/org/apache/thermos/root/tasks/finished/hello_world c331c53fc6057682b58eebf97fc08393ed0e8893 src/resources/org/apache/thermos/root/tasks/finished/ordering 6774dc0b78213b65aeb51ab2ff28eb8b4a2711a9 src/resources/org/apache/thermos/root/tasks/finished/ports 080ee718fc2c9189aac2a5c491c4da331d8b6f51 src/resources/org/apache/thermos/root/tasks/finished/sleep60 7c7dc4749c3da9e16116d35b41ba6065541e87ea Diff: https://reviews.apache.org/r/19819/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated March 21, 2014, 2:59 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle 9b8827ea05932620ebac4929838c158e853d73ae Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated March 10, 2014, 11:29 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Updates gradlew to check for the Python version before building Thrift. Also adds a Python check to the pex script. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs (updated) - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle 9b8827ea05932620ebac4929838c158e853d73ae Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18913: Bump protobuf version to match version used by mesos library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18913/#review36550 --- Ship it! Ship It! - Dan Norris On March 7, 2014, 6:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18913/ --- (Updated March 7, 2014, 6:19 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-250 https://issues.apache.org/jira/browse/AURORA-250 Repository: aurora Description --- Dependency report no longer shows conflict: $ ./gradlew dependencies | grep protobuf +--- com.google.protobuf:protobuf-java:2.5.0 |\--- com.google.protobuf:protobuf-java:2.5.0 +--- com.google.protobuf:protobuf-java:2.5.0 |\--- com.google.protobuf:protobuf-java:2.5.0 +--- com.google.protobuf:protobuf-java:2.5.0 |\--- com.google.protobuf:protobuf-java:2.5.0 +--- com.google.protobuf:protobuf-java:2.5.0 |\--- com.google.protobuf:protobuf-java:2.5.0 +--- com.google.protobuf:protobuf-java:2.5.0 |\--- com.google.protobuf:protobuf-java:2.5.0brary. Diffs - build.gradle 265f385377369491dc9244db168a72f7c5a7d3b3 Diff: https://reviews.apache.org/r/18913/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:21 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Unifies top-level dir variable to be called HERE. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs (updated) - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877/ --- (Updated Feb. 25, 2014, 2:53 a.m.) Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll. Changes --- Converts the exception passed to die() to be a string. Results in the following: ./pants py src/main/python/apache/aurora/client/bin:aurora_admin set_quota example fakerole 1 10a 3gb FATAL] Invalid size: Amount did not have a valid base: 10a. Valid bases: kb gb g mb tb k m t Bugs: AURORA-200 https://issues.apache.org/jira/browse/AURORA-200 Repository: aurora Description --- AURORA-200: set_quota should die if given invalid arguments Diffs (updated) - src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris
Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
On Feb. 11, 2014, 4:33 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/admin.py, line 174
https://reviews.apache.org/r/17877/diff/1/?file=481150#file481150line174
Die expects a message string, not an exception object. die('Invalid
unit specification') would end up with a better error message.
Oh yeah, I can see the the problem with not passing a string. I feel like the
default exception message provides a better explanation of what was wrong with
the argument though:
./pants py src/main/python/apache/aurora/client/bin:aurora_admin set_quota
example role 10 a b
FATAL] Invalid size: Amount did not have a valid base: a. Valid bases: kb gb g
mb tb k m t
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
---
On Feb. 10, 2014, 7:17 p.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---
(Updated Feb. 10, 2014, 7:17 p.m.)
Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200
Repository: aurora
Description
---
AURORA-200: set_quota should die if given invalid arguments
Diffs
-
src/main/python/apache/aurora/client/commands/admin.py
45686aec8d69f0dfa1d649a92a19ca87bd315823
Diff: https://reviews.apache.org/r/17877/diff/
Testing
---
./gradlew clean build ./pants src/test/python:all -vxs along with manual
testing w/ bad arguments.
Thanks,
Dan Norris
Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877/ --- (Updated Feb. 10, 2014, 7:17 p.m.) Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll. Bugs: AURORA-200 https://issues.apache.org/jira/browse/AURORA-200 Repository: aurora Description --- AURORA-200: set_quota should die if given invalid arguments Diffs - src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris
Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877/ --- Review request for Aurora and Jonathan Boulle. Bugs: AURORA-200 https://issues.apache.org/jira/browse/AURORA-200 Repository: aurora Description --- AURORA-200: set_quota should die if given invalid arguments Diffs - src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris
Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent
/config/loader.py 3c6d673d7fcd63e0828e148917b7e74de4949476 src/main/python/apache/thermos/config/schema_helpers.py 73789ddfc9b30dde75c857e2b5ab573b82154df7 src/main/python/apache/thermos/core/helper.py c9b4837da81a4bbcf963a20b58088e3f2d46647e src/main/python/apache/thermos/core/inspector.py c9899ef983afb9bde930848bf0d71663a4d19585 src/main/python/apache/thermos/core/muxer.py 2268764919ba3a91802a7bf5b610e611e0edba13 src/main/python/apache/thermos/core/process.py 90fd1da66bd52ac84a47b20275b97447ca80a3f7 src/main/python/apache/thermos/core/runner.py 77f0a92b287608788e5b3552e5e9ab38bbe0417a src/main/python/apache/thermos/monitoring/disk.py b6140e9b227eb0fb3bea594003b5e481886d0686 src/main/python/apache/thermos/monitoring/garbage.py 9508c13fef48cfba32794009113863918333ed97 src/main/python/apache/thermos/monitoring/monitor.py f11a9128c10ebce5d2ac92b766f0a01b66203c7e src/main/python/apache/thermos/monitoring/process_collector_psutil.py 07c6abe2e9aa970df85e5a48cf03cc9f8e2c17c8 src/main/python/apache/thermos/monitoring/resource.py 06e994c9df199fd1d045ca56423248a1d80e7b6b src/main/python/apache/thermos/observer/bin/thermos_observer.py d4115eb96a15aaf9b4eef4f8e4d593b6b00c4810 src/main/python/apache/thermos/observer/http/file_browser.py 2c5332b699605c143068f9181eca32f6bdb18cb5 src/main/python/apache/thermos/observer/http/http_observer.py 190bc296136f94b9a40b2a6ece9e568627de95cc src/main/python/apache/thermos/observer/http/static_assets.py 040715bf3f951b5e543c543c0c6f836fa68b58ec src/main/python/apache/thermos/observer/observed_task.py d72ff1837f498348e403bdb27f40f03d79e7fdc9 src/main/python/apache/thermos/observer/task_observer.py eae6b79473cce3e00c4b48ae709a314af78ee969 src/main/python/apache/thermos/testing/runner.py 64de3bd4c0d9d9b7788683fc0dd90a733e7c8830 src/test/python/apache/aurora/executor/test_gc_executor.py 0359098a2e25f68696cd24f9549bc19e73e55ea3 src/test/python/apache/aurora/executor/test_thermos_executor.py d91c3b06005ae6fa0fa7b23429a01fe1af68f178 Diff: https://reviews.apache.org/r/17734/diff/ Testing --- ./gradlew build ./pants src/test/python:all -vxs Thanks, Dan Norris
Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 3, 2014, 3:58 p.m.) Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko. Bugs: aurora-88 https://issues.apache.org/jira/browse/aurora-88 Repository: aurora Description --- AURORA-88: get_quota -h lists --cluster as deprecated Replaces CLUSTER_INVOKE_OPTION with a new CLUSTER_NAME_OPTION so that get_quota -h shows the correct help dialog. Diffs - src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/options.py 4e53b0765375989bb80ffd02e0ef2b08af1eea50 Diff: https://reviews.apache.org/r/17637/diff/ Testing --- Tests pass locally and running aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris
Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 2, 2014, 2:07 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: aurora-88 https://issues.apache.org/jira/browse/aurora-88 Repository: aurora Description --- AURORA-88: get_quota -h lists --cluster as deprecated Replaces CLUSTER_INVOKE_OPTION with a new CLUSTER_NAME_OPTION so that get_quota -h shows the correct help dialog. Diffs - src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/options.py 4e53b0765375989bb80ffd02e0ef2b08af1eea50 Diff: https://reviews.apache.org/r/17637/diff/ Testing --- Tests pass locally and running aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris
Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 6:46 p.m.) Review request for Aurora and Mark Chu-Carroll. Changes --- Added markcc Bugs: AURORA-136 https://issues.apache.org/jira/browse/AURORA-136 Repository: aurora Description --- AURORA-108: make set_quota in aurora_admin require explicit units set_quota now requies a specific unit (M or G) as input. This means that arguments to set_quote should resemble the following: set_quota(cluster, role, cpu, '50M', '20G') set_quota(cluster, role, cpu, '50G', '20G') Diffs - src/main/python/apache/aurora/client/api/__init__.py f82900371f8e7566da07beeef4ff0622105c64d6 src/main/python/apache/aurora/client/commands/admin.py 6d191f406a284c60326a49aed32914c81522d4d2 Diff: https://reviews.apache.org/r/17581/diff/ Testing --- Passes local tests. I could not find a test that tests the quota for the cli client so this patch does not contain an dedicated test case. Thanks, Dan Norris
Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 7:34 p.m.) Review request for Aurora and Mark Chu-Carroll. Changes --- Updated patch to use parse_data from twitter.common. Bugs: AURORA-136 https://issues.apache.org/jira/browse/AURORA-136 Repository: aurora Description --- AURORA-108: make set_quota in aurora_admin require explicit units set_quota now requies a specific unit (M or G) as input. This means that arguments to set_quote should resemble the following: set_quota(cluster, role, cpu, '50M', '20G') set_quota(cluster, role, cpu, '50G', '20G') Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py f82900371f8e7566da07beeef4ff0622105c64d6 src/main/python/apache/aurora/client/commands/admin.py 6d191f406a284c60326a49aed32914c81522d4d2 Diff: https://reviews.apache.org/r/17581/diff/ Testing --- Passes local tests. I could not find a test that tests the quota for the cli client so this patch does not contain an dedicated test case. Thanks, Dan Norris
