Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Maxim's feedback. Found the grouping tests! Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs (updated) - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Maxim's feedback. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs (updated) - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote: david -- could you publish a remote branch somewhere that i can use to merge this to master? the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs. https://github.com/zxvdr/incubator-aurora/tree/favicon - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 --- On July 31, 2014, 12:13 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Re: Review Request 25337: Preserve executor HealthCheckerThread name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52395 --- Ship it! src/main/python/apache/aurora/executor/common/health_checker.py https://reviews.apache.org/r/25337/#comment91188 Docstring, one variable per line so the style is consistent, and perhaps change the order so it's consistent with HealthChecker()? eg, s/ initial_interval_secs, interval_secs/ interval_secs, initial_interval_secs/ and update the caller to match. src/test/python/apache/aurora/executor/common/test_health_checker.py https://reviews.apache.org/r/25337/#comment91190 Why do you need to cast num_calls? - David Robinson On Sept. 5, 2014, 1:20 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 5, 2014, 1:20 a.m.) Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-682 https://issues.apache.org/jira/browse/AURORA-682 Repository: aurora Description --- Preserve executor HealthCheckerThread name Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676 src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 Diff: https://reviews.apache.org/r/25337/diff/ Testing --- ###STILL RUNNING E2E TESTS [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith
Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review52223 --- src/main/python/apache/thermos/core/runner.py https://reviews.apache.org/r/25175/#comment90965 This changes the return value from 0 to None upon timeout. Perhaps change 'break' to 'return 0'? - David Robinson On Aug. 28, 2014, 11:34 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- (Updated Aug. 28, 2014, 11:34 p.m.) Review request for Aurora. Bugs: AURORA-669 https://issues.apache.org/jira/browse/AURORA-669 Repository: aurora Description --- Fix possible deadlock in TaskRunner.collect_updates. Diffs - src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198 Diff: https://reviews.apache.org/r/25175/diff/ Testing --- Regression test y/n ? Thanks, Brian Wickman
Re: Review Request 25206: Fix aurora run in end to end tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52235 --- Ship it! Ship It! - David Robinson On Sept. 3, 2014, 6:33 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 6:33 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias Weingartner. Bugs: AURORA-676 https://issues.apache.org/jira/browse/AURORA-676 Repository: aurora Description --- Fix aurora run in end to end tests. Diffs - examples/vagrant/upstart/mesos-slave.conf e53d545f3a66383c12ed1e7de6b1eef2dbad1541 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 14a0b62c1b06179211d79f35a9c6df162c9a5999 src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION Diff: https://reviews.apache.org/r/25206/diff/ Testing --- $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Unfortunately the v2 client end to end tests are currently broken (filed https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test for aurora task run works in that script as well. Thanks, Joshua Cohen
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51045 --- Ship it! Ship It! - David Robinson On Aug. 19, 2014, 10:51 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 19, 2014, 10:51 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Changes --- Thought the 318 byte version was fine, but it's not (my browser had the previous version cached), it strips out too much detail. This update fixes the problem, but the favicon is slightly larger (2 KB). Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs (updated) - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Re: Review Request 23949: Make testing of v1 command hooks easier.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/#review49009 --- Ship it! Ship It! - David Robinson On July 25, 2014, 8:50 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/ --- (Updated July 25, 2014, 8:50 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: aurora-603 https://issues.apache.org/jira/browse/aurora-603 Repository: aurora Description --- Make testing of v1 command hooks easier. In order to be able to test v1 command hooks on real commands, it would be helpful to be able to mock out the body of the commands. In order to do this, I've separated the commands into an invocation frame, and the actual command implementation. Diffs - src/main/python/apache/aurora/client/commands/core.py b4169995e996b17dda3dc09f2e5961d77e045d87 Diff: https://reviews.apache.org/r/23949/diff/ Testing --- ? incubator-aurora git:(extract_killall) ? git commit -a --amend [extract_killall 570bd1e] Make testing of v1 command hooks easier. 2 files changed, 105 insertions(+), 73 deletions(-) ? incubator-aurora git:(extract_killall) ./pants src/test/python/apache/aurora/client:all Build operating on top level addresses: set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_config_noun.py ... === 3 passed in 0.88 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 28 items src/test/python/apache/aurora/client/api/test_updater.py == 28 passed in 0.94 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.76 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... === 3 passed in 0.72 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 10 items src/test/python/apache/aurora/client/test_config.py .. == 10 passed in 0.51 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/cli/test_cron.py ... === 7 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 44 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .. src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py . src/test
Re: Review Request 23329: remove embedded jquery
On July 8, 2014, 1:18 a.m., Kevin Sweeney wrote:
src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl, line
62
https://reviews.apache.org/r/23329/diff/1/?file=625207#file625207line62
-1, this is pretty much unacceptable from a security standpoint - data
visible to the observer origin includes sensitive application logs
-1 from a reliability standpoint as well - the observer is used to
debug low-level infrastructure and a dependency on an external CDN doesn't
work for that.
Thermos serves its static content (including the bundled jquery) and logs over
http, in clear text... that's a bigger security risk, no?
I understand why you wouldn't trust any old CDN, but why can't we trust
Google's?
We could instead use the local copy as a fallback:
script
src=//ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js/script
scriptwindow.jQuery || document.write('script
src=/assets/jquery.js\x3C/script')/script
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23329/#review47428
---
On July 8, 2014, 1:08 a.m., David Robinson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23329/
---
(Updated July 8, 2014, 1:08 a.m.)
Review request for Aurora, David McLaughlin and Brian Wickman.
Bugs: AURORA-578
https://issues.apache.org/jira/browse/AURORA-578
Repository: aurora
Description
---
remove embedded jquery
Diffs
-
src/main/python/apache/thermos/observer/http/assets/jquery.js
3774ff986139c8a7534e14bc8987fe80418dcc1b
src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl
511d7c06206ae5fd8a4206683f09348e1276b8c4
src/main/python/apache/thermos/observer/http/templates/index.tpl
3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88
src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl
b182a4b331fbe8b9dd437194d195d220184a2f7c
Diff: https://reviews.apache.org/r/23329/diff/
Testing
---
Thanks,
David Robinson
Re: Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- (Updated July 9, 2014, 9:50 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Changes --- Fall back to local jquery. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs (updated) - src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/assets/jquery.js 3774ff986139c8a7534e14bc8987fe80418dcc1b src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Re: Review Request 23189: Export zero for racks that have no lost tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/#review47095 --- Ship it! Ship It! - David Robinson On July 1, 2014, 1:53 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/ --- (Updated July 1, 2014, 1:53 a.m.) Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: AURORA-548 https://issues.apache.org/jira/browse/AURORA-548 Repository: aurora Description --- Export zero for racks that have no lost tasks. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java a58696ba094619ca130c4b8f5287696856d7c1e7 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 2e128f49173a69bb09dee32e8dbac27e5d3b1021 Diff: https://reviews.apache.org/r/23189/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 20285: Improve documentation and testing for host maintenance API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/#review43886 --- Ship it! Ship It! - David Robinson On May 21, 2014, 3:51 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/ --- (Updated May 21, 2014, 3:51 a.m.) Review request for Aurora, David Robinson, Kevin Sweeney, Tobias Weingartner, and Bill Farner. Bugs: AURORA-318 https://issues.apache.org/jira/browse/AURORA-318 Repository: aurora Description --- Add way more docstrings as well as unit tests for the HostMaintenance api. Diffs - src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2 src/test/python/apache/aurora/admin/BUILD 17aac54d636024a8e131eb2e4d996c2e15401de1 src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2 Diff: https://reviews.apache.org/r/20285/diff/ Testing --- 16:39:58 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/admin/BUILD:all)]) test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 9 items src/test/python/apache/aurora/admin/test_host_maintenance.py . == 9 passed in 0.67 seconds == src.test.python.apache.aurora.admin.host_maintenance . SUCCESS Thanks, Joe Smith
Re: Review Request 21093: Showing status message in Job UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21093/#review42231 --- Ship it! Ship It! - David Robinson On May 6, 2014, 12:43 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21093/ --- (Updated May 6, 2014, 12:43 a.m.) Review request for Aurora, David McLaughlin and Mark Chu-Carroll. Bugs: AURORA-339 and AURORA-374 https://issues.apache.org/jira/browse/AURORA-339 https://issues.apache.org/jira/browse/AURORA-374 Repository: aurora Description --- Bug fix. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 2cab2362aebce8015239051a2901de16b4a82ec5 Diff: https://reviews.apache.org/r/21093/diff/ Testing --- Tested on local laptop. Attached screenshot. File Attachments Screen Shot 2014-05-05 at 5.41.10 PM.png https://reviews.apache.org/media/uploaded/files/2014/05/06/2e4cbd97-44d6-4b40-9dfc-5f6acdc3922a__Screen_Shot_2014-05-05_at_5.41.10_PM.png Thanks, Suman Karumuri
Re: Review Request 20521: Extend the client configuration plugin architecture.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review41056 --- Ship it! Ship It! - David Robinson On April 22, 2014, 7:38 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 22, 2014, 7:38 p.m.) Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-332 https://issues.apache.org/jira/browse/aurora-332 Repository: aurora Description --- Extend the client configuration plugin architecture. Plugins can now run code at three key points: - Before arguments are processed and execution is dispatched to a command. - After argument processing and dispatch, but before execution. - After execution. This allows plugins to perform initialization required for argument processing, and for post-execution cleanups and synchronizations. Diffs - src/main/python/apache/aurora/client/cli/__init__.py f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 src/test/python/apache/aurora/client/cli/test_plugins.py 7cacb02ffda05fdf87a9334ed1de2092efb39f8b Diff: https://reviews.apache.org/r/20521/diff/ Testing --- [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py 4 passed in 0.02 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . 5 passed in 0.76 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... === 36 passed in 2.02 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/cli/test_logging.py . 1 passed in 0.68 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. 2 passed in 0.63 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py 4 passed in 0.61 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . 5 passed in 0.59 seconds == test session starts === platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest
Re: Review Request 20010: Fix two clientv2 command-line bugs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/#review39480 --- Ship it! Ship It! - David Robinson On April 3, 2014, 5:15 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/ --- (Updated April 3, 2014, 5:15 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-307 https://issues.apache.org/jira/browse/aurora-307 Repository: aurora Description --- Fix two clientv2 command-line bugs. - Clientv2 bridge would crash and dump cookies if you didn't give it any command-line parameters. - Clientv2 help formatting was messed up. Diffs - src/main/python/apache/aurora/client/cli/__init__.py a1063e1af24fd42adafbeebf757bca4de47db1fc src/main/python/apache/aurora/client/cli/bridge.py 37964b65b597abcf7f85b414fa5c6473da9f12ed Diff: https://reviews.apache.org/r/20010/diff/ Testing --- Manual command-line testing. Thanks, Mark Chu-Carroll
Re: Review Request 20009: Add the open command to clientv2, and fix an error case in v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20009/#review39481 --- Ship it! Ship It! - David Robinson On April 3, 2014, 4:58 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20009/ --- (Updated April 3, 2014, 4:58 p.m.) Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-307 https://issues.apache.org/jira/browse/aurora-307 Repository: aurora Description --- Add the open command to clientv2, and fix an error case in v1. Clientv2 didn't have an open command, which it needed. Clientv1 had an open command, but if you used it and you forgot to specify the parameter, it dropped its cookies. Diffs - src/main/python/apache/aurora/client/cli/context.py 83f7b6a4ae1e6896278752cb481901c6e381ba0e src/main/python/apache/aurora/client/cli/jobs.py 798f54deb35afb72cd3b8d3cb972d386e48d6c2e src/main/python/apache/aurora/client/commands/core.py b1abc9e7b1923d2e56f452c6891ddaa959d95b40 src/test/python/apache/aurora/client/cli/BUILD d93a2df0f146e2771de2ce6223438a671d0e92a2 src/test/python/apache/aurora/client/cli/test_open.py PRE-CREATION Diff: https://reviews.apache.org/r/20009/diff/ Testing --- Ran unit tests, added new tests of the open command. Thanks, Mark Chu-Carroll
Re: Review Request 18819: Removing rollback_on_failure from restart options.
On March 6, 2014, 12:43 a.m., David Robinson wrote: I added the missing flag instead: https://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? Brian Wickman wrote: I'm not sure the flag makes sense for the restart command, since it doesn't support rollback, right? Excellent point! - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/#review36306 --- On March 5, 2014, 11:20 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/ --- (Updated March 5, 2014, 11:20 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: AURORA-247 https://issues.apache.org/jira/browse/AURORA-247 Repository: aurora Description --- Removing rollback_on_failure from restart options. Diffs - src/main/python/apache/aurora/client/api/updater_util.py bbbd48411a036ab46e5c88087efadfdc467dacc9 src/main/python/apache/aurora/client/commands/core.py 7c3c5303201a73ac93cdeeea0fb9ba2574c70949 src/test/python/apache/aurora/client/commands/test_restart.py f281b3544dcc6b59d5dc44bc97b9910306c3a23e Diff: https://reviews.apache.org/r/18819/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 18819: Removing rollback_on_failure from restart options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/#review36306 --- Ship it! I added the missing flag instead: https://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? - David Robinson On March 5, 2014, 11:20 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/ --- (Updated March 5, 2014, 11:20 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: AURORA-247 https://issues.apache.org/jira/browse/AURORA-247 Repository: aurora Description --- Removing rollback_on_failure from restart options. Diffs - src/main/python/apache/aurora/client/api/updater_util.py bbbd48411a036ab46e5c88087efadfdc467dacc9 src/main/python/apache/aurora/client/commands/core.py 7c3c5303201a73ac93cdeeea0fb9ba2574c70949 src/test/python/apache/aurora/client/commands/test_restart.py f281b3544dcc6b59d5dc44bc97b9910306c3a23e Diff: https://reviews.apache.org/r/18819/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 18746: fix rollback on failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18746/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-148 https://issues.apache.org/jira/browse/AURORA-148 Repository: aurora Description --- fix rollback on failure Diffs - src/main/python/apache/aurora/client/commands/core.py 7c3c5303201a73ac93cdeeea0fb9ba2574c70949 Diff: https://reviews.apache.org/r/18746/diff/ Testing --- None - still sorting out vagrant. Thanks, David Robinson
Re: Review Request 16062: fixed structdump usage message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16062/ --- (Updated Feb. 27, 2014, 11:17 p.m.) Review request for Aurora and Bill Farner. Changes --- Maxim's feedback. Repository: aurora Description --- fixed structdump usage message Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/StructDump.java b7a33a6e8a3c01a45cdc02b28077523f102f282b Diff: https://reviews.apache.org/r/16062/diff/ Testing --- zilch Thanks, David Robinson
Re: Review Request 18267: Implement help for v2 bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/#review35070 --- src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/18267/#comment65459 Shouldn't this be removed? It's defined above. - David Robinson On Feb. 20, 2014, 9:02 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/ --- (Updated Feb. 20, 2014, 9:02 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-203 https://issues.apache.org/jira/browse/aurora-203 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/bridge.py 27079da1430d1b6b36d64c9176797f803db6ff62 src/main/python/apache/aurora/client/cli/client.py 56d63660850b7a3a437cb3575b9ba8add8813956 src/main/python/apache/aurora/client/cli/options.py 2f373723eb4aa51ebd9bd139ce455ae54fbdd3cd Diff: https://reviews.apache.org/r/18267/diff/ Testing --- [sun-wukong incubator-aurora (bridgehelp)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.61 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34259 --- Ship it! lgtm - David Robinson On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 11, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Review Request 17645: added rollback_on_failure to UpdateConfig
/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... 25 passed in 1.12 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 24 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py ... src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... 24 passed in 0.87 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . 1 passed in 0.13 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . 1 passed in 0.13 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py 12 passed in 0.11 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 4 passed in 0.10 seconds = src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, David Robinson
Re: Review Request 17645: added rollback_on_failure to UpdateConfig
/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... 25 passed in 1.12 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 24 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py ... src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... 24 passed in 0.87 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . 1 passed in 0.13 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . 1 passed in 0.13 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py 12 passed in 0.11 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 4 passed in 0.10 seconds = src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, David Robinson
Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/
---
(Updated Jan. 24, 2014, 1:28 a.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description (updated)
---
s/thermos_observe/thermos_observer/ in README.md
[drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
examples/vagrant/provision-dev-environment.sh: ./pants
src/main/python/apache/thermos/observer/bin:thermos_observer
examples/vagrant/provision-dev-environment.sh: for pex in aurora_admin
aurora_client gc_executor thermos_executor thermos_observer; do
examples/vagrant/provision-mesos-slave.sh:cat
/usr/local/bin/thermos_observer.sh EOF
examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer \
examples/vagrant/provision-mesos-slave.sh:chmod +x
/usr/local/bin/thermos_observer.sh
examples/vagrant/provision-mesos-slave.sh:install -m 755
/vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh
/var/log/thermos-observer.log 21
src/main/python/apache/thermos/README.md:$ ./pants
src/python/apache/thermos/bin:thermos_observe
src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex
--root=$HOME/.thermos
src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P
http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}}
--root=$HOME/.thermos'
src/main/python/apache/thermos/observer/bin/BUILD: name = 'thermos_observer',
src/main/python/apache/thermos/observer/bin/BUILD: source =
'thermos_observer.py',
src/main/python/apache/thermos/observer/bin/BUILD: entry_point =
'apache.thermos.observer.bin.thermos_observer:proxy_main',
src/main/python/apache/thermos/observer/BUILD:thermos_observer =
pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),
Diffs
-
src/main/python/apache/thermos/README.md
4bfefd37163dfbc5947acc7adc52f57c95cd174f
Diff: https://reviews.apache.org/r/17293/diff/
Testing
---
None, it's a document and it's out of date.
Thanks,
David Robinson
