Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen


 On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote:
  src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
  https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
 
  aurora job run?
 
 Joe Smith wrote:
 Kevin and Toby, can you two take a look at this ASAP? I'd like to have 
 the e2e tests fixed before I ship https://reviews.apache.org/r/25208/

It defaults to 'aurora run', for the aurora1 client, but we pass in 'aurora2 
job run' from the test_end_to_end_v2.sh script. Are you saying to switch the 
default (or maybe I should just remove the default altogether)?


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Aug. 29, 2014, 11:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 11:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joe Smith


 On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
  src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
  https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
 
  aurora job run?
 
 Joe Smith wrote:
 Kevin and Toby, can you two take a look at this ASAP? I'd like to have 
 the e2e tests fixed before I ship https://reviews.apache.org/r/25208/
 
 Joshua Cohen wrote:
 It defaults to 'aurora run', for the aurora1 client, but we pass in 
 'aurora2 job run' from the test_end_to_end_v2.sh script. Are you saying to 
 switch the default (or maybe I should just remove the default altogether)?

I was saying switch the default so it's the new syntax


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 4:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Mark Chu-Carroll
At the moment, there's two end-to-end tests: test_end_to_end.sh, and
test_end_to_end_v2.sh. Since this is the v1 test, it should use v1.

 -Mark


On Wed, Sep 3, 2014 at 2:05 PM, Joe Smith yasumo...@gmail.com wrote:

This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/

 On September 2nd, 2014, 6:47 p.m. PDT, *Joe Smith* wrote:

   src/test/sh/org/apache/aurora/e2e/test_run.sh
 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 
 (Diff
 revision 1)

 23

 aurora_command=${3:-aurora run}

   aurora job run?

  On September 2nd, 2014, 8:15 p.m. PDT, *Joe Smith* wrote:

 Kevin and Toby, can you two take a look at this ASAP? I'd like to have the 
 e2e tests fixed before I ship https://reviews.apache.org/r/25208/

  On September 3rd, 2014, 9:25 a.m. PDT, *Joshua Cohen* wrote:

 It defaults to 'aurora run', for the aurora1 client, but we pass in 'aurora2 
 job run' from the test_end_to_end_v2.sh script. Are you saying to switch the 
 default (or maybe I should just remove the default altogether)?

  I was saying switch the default so it's the new syntax


 - Joe

 On August 29th, 2014, 4:17 p.m. PDT, Joshua Cohen wrote:
   Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias
 Weingartner.
 By Joshua Cohen.

 *Updated Aug. 29, 2014, 4:17 p.m.*
  *Bugs: * AURORA-676 https://issues.apache.org/jira/browse/AURORA-676
  *Repository: * aurora
 Description

 Fix aurora run in end to end tests.

   Testing

 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.

   Diffs

- examples/vagrant/upstart/mesos-slave.conf
(e53d545f3a66383c12ed1e7de6b1eef2dbad1541)
- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
(fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f)
- src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
(14a0b62c1b06179211d79f35a9c6df162c9a5999)
- src/test/sh/org/apache/aurora/e2e/test_run.sh (PRE-CREATION)

 View Diff https://reviews.apache.org/r/25206/diff/



Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52210
---

Ship it!



examples/vagrant/upstart/mesos-slave.conf
https://reviews.apache.org/r/25206/#comment90955

Can you add a comment explaining why this is necessary (preferably with a 
link to a bug where we will fix this in the client - the clusters.json default 
should match the mesos default).


- Kevin Sweeney


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 4:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/
---

(Updated Sept. 3, 2014, 6:13 p.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
Weingartner.


Changes
---

Switch default in test_run.sh to use aurora2 command.


Bugs: AURORA-676
https://issues.apache.org/jira/browse/AURORA-676


Repository: aurora


Description
---

Fix aurora run in end to end tests.


Diffs (updated)
-

  examples/vagrant/upstart/mesos-slave.conf 
e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
14a0b62c1b06179211d79f35a9c6df162c9a5999 
  src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/25206/diff/


Testing
---

$ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Unfortunately the v2 client end to end tests are currently broken (filed 
https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test 
for aurora task run works in that script as well.


Thanks,

Joshua Cohen



Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/
---

(Updated Sept. 3, 2014, 6:33 p.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
Weingartner.


Changes
---

Added comment explaining --work_dir param when starting up the mesos slaves.


Bugs: AURORA-676
https://issues.apache.org/jira/browse/AURORA-676


Repository: aurora


Description
---

Fix aurora run in end to end tests.


Diffs (updated)
-

  examples/vagrant/upstart/mesos-slave.conf 
e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
14a0b62c1b06179211d79f35a9c6df162c9a5999 
  src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/25206/diff/


Testing
---

$ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Unfortunately the v2 client end to end tests are currently broken (filed 
https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test 
for aurora task run works in that script as well.


Thanks,

Joshua Cohen



Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen


 On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote:
  src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
  https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
 
  aurora job run?
 
 Joe Smith wrote:
 Kevin and Toby, can you two take a look at this ASAP? I'd like to have 
 the e2e tests fixed before I ship https://reviews.apache.org/r/25208/
 
 Joshua Cohen wrote:
 It defaults to 'aurora run', for the aurora1 client, but we pass in 
 'aurora2 job run' from the test_end_to_end_v2.sh script. Are you saying to 
 switch the default (or maybe I should just remove the default altogether)?
 
 Joe Smith wrote:
 I was saying switch the default so it's the new syntax

Updated.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Sept. 3, 2014, 6:33 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Sept. 3, 2014, 6:33 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen


 On Sept. 3, 2014, 6:10 p.m., Kevin Sweeney wrote:
  examples/vagrant/upstart/mesos-slave.conf, line 28
  https://reviews.apache.org/r/25206/diff/1/?file=672551#file672551line28
 
  Can you add a comment explaining why this is necessary (preferably with 
  a link to a bug where we will fix this in the client - the clusters.json 
  default should match the mesos default).

Added.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52210
---


On Sept. 3, 2014, 6:33 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Sept. 3, 2014, 6:33 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread David Robinson

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52235
---

Ship it!


Ship It!

- David Robinson


On Sept. 3, 2014, 6:33 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Sept. 3, 2014, 6:33 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/
---

(Updated Sept. 3, 2014, 8:55 p.m.)


Review request for Aurora, David Robinson, Kevin Sweeney, and Mark Chu-Carroll.


Changes
---

-tweingartner, +drobinson from reviewers.


Bugs: AURORA-676
https://issues.apache.org/jira/browse/AURORA-676


Repository: aurora


Description
---

Fix aurora run in end to end tests.


Diffs
-

  examples/vagrant/upstart/mesos-slave.conf 
e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
14a0b62c1b06179211d79f35a9c6df162c9a5999 
  src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/25206/diff/


Testing
---

$ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Unfortunately the v2 client end to end tests are currently broken (filed 
https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test 
for aurora task run works in that script as well.


Thanks,

Joshua Cohen



Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52245
---


I ran this before committing and it still fails (aurora run hangs). Looks like 
flags need to be pushed to the server-side ssh

- Kevin Sweeney


On Sept. 3, 2014, 1:55 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Sept. 3, 2014, 1:55 p.m.)
 
 
 Review request for Aurora, David Robinson, Kevin Sweeney, and Mark 
 Chu-Carroll.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/
---

(Updated Sept. 3, 2014, 10:40 p.m.)


Review request for Aurora, David Robinson, Kevin Sweeney, and Mark Chu-Carroll.


Changes
---

 Allow local ssh w/out strict host checking


Bugs: AURORA-676
https://issues.apache.org/jira/browse/AURORA-676


Repository: aurora


Description
---

Fix aurora run in end to end tests.


Diffs (updated)
-

  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  examples/vagrant/upstart/mesos-slave.conf 
e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
14a0b62c1b06179211d79f35a9c6df162c9a5999 
  src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/25206/diff/


Testing
---

$ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Unfortunately the v2 client end to end tests are currently broken (filed 
https://issues.apache.org/jira/browse/AURORA-677), but I verified that the test 
for aurora task run works in that script as well.


Thanks,

Joshua Cohen



Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52065
---

Ship it!


Ship It!

- Mark Chu-Carroll


On Aug. 29, 2014, 7:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 7:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---

Ship it!



src/test/sh/org/apache/aurora/e2e/test_run.sh
https://reviews.apache.org/r/25206/#comment90865

aurora job run?


- Joe Smith


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 4:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith


 On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
  src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
  https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
 
  aurora job run?

Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e 
tests fixed before I ship https://reviews.apache.org/r/25208/


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25206/
 ---
 
 (Updated Aug. 29, 2014, 4:17 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
 Weingartner.
 
 
 Bugs: AURORA-676
 https://issues.apache.org/jira/browse/AURORA-676
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix aurora run in end to end tests.
 
 
 Diffs
 -
 
   examples/vagrant/upstart/mesos-slave.conf 
 e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
 fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
 14a0b62c1b06179211d79f35a9c6df162c9a5999 
   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/25206/diff/
 
 
 Testing
 ---
 
 $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 Unfortunately the v2 client end to end tests are currently broken (filed 
 https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
 test for aurora task run works in that script as well.
 
 
 Thanks,
 
 Joshua Cohen