Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- Ship it! lgtm! src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java https://reviews.apache.org/r/31820/#comment123255 Maybe move this to the ticket and kill the commented out code here? src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java https://reviews.apache.org/r/31820/#comment123256 nit: probably preferable to move ImmutableSortedSet.of down to the next line. src/main/python/apache/aurora/common/clusters.py https://reviews.apache.org/r/31820/#comment123258 Is this change related? src/test/python/apache/aurora/common/test_clusters.py https://reviews.apache.org/r/31820/#comment123260 Same here, seems unrelated? Does this just need to be rebased? - Joshua Cohen On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 1:18 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31821/ --- (Updated March 10, 2015, 5:26 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Bill's comments. Bugs: AURORA-1158 https://issues.apache.org/jira/browse/AURORA-1158 Repository: aurora Description --- Extracting PreemptorSlotFinder to be reused for slot validation in later stages. The changes are very minimal and mostly around metric handling and test code. Also added missing test coverage. Diffs (updated) - src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 701b9052696337766cb233c865cb9fbb4907071e src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java e093ca54521ffb9399bb97ce60f510331af70853 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java 80c2023f46b63753dcec6a555dba626720a1925a src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java bddb9647493b3e7a58c40d4b477a06161c1388a2 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java ae56d1e09322869eedd7a27586cd6f96edd64e0a src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorMetrics.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 85b3874a36ed07c684f26da172952c932cff707a src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 58733bdc4dd6de29ccead5cb0a267286e8dc0656 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 891cc098cca99e84ba014b7131106ceb0b429b5f src/test/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImplTest.java 7207867813b0d096772dbc7f92fc1c76937e9831 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java b0380b3fabb45be8ace55cfcf38ce15ef8040188 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 83680769611878886da04e1794b321aa1986e678 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java 020b67187a18bba64d9b562c3a6c0969fc85d469 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31821/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 1:58 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76331 --- Master (ee1a13a) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.client . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.context . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.factory . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . FAILURE src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 13, 2015, 1:58 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 1:58 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Re: Review Request 32014: Adding more logging into MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76332 --- src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java https://reviews.apache.org/r/32014/#comment123873 `Tasks.ids(activeTasks)` src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java https://reviews.apache.org/r/32014/#comment123874 This is a pretty weird log entry to have. Can it be done in the client instead? src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java https://reviews.apache.org/r/32014/#comment123875 Ditto - this really seems like it should be client-side logging. The client gets back the actiosn that were taken, seems like it has all the info it needs to check for discrepancies. - Bill Farner On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 1:23 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Also added missing test coverage. Diffs - config/legacy_untested_classes.txt 06e130fae6bdc43b5e8aff182a530eac65acca53 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java b6f642e319b790544bc538098e7cb78b1bb49997 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 2:12 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes --- Neglected to commit hooked_api.py change. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76243 --- Ship it! src/main/python/apache/aurora/client/api/__init__.py https://reviews.apache.org/r/31966/#comment123752 Spacing seems off here and below. src/main/python/apache/aurora/client/cli/update.py https://reviews.apache.org/r/31966/#comment123755 I'd also include a short '-m' name to make typing less tedious. src/main/python/apache/aurora/client/cli/update.py https://reviews.apache.org/r/31966/#comment123753 While not entirely consistent, the majority of our CommandOption help strings start with a capital. src/main/python/apache/aurora/client/cli/update.py https://reviews.apache.org/r/31966/#comment123754 Mind sorting them alphabetically? - Maxim Khutornenko On March 12, 2015, 1:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 12, 2015, 1:27 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76257 --- Ship it! Ship It! - Zameer Manji On March 11, 2015, 6:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 11, 2015, 6:27 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76283 --- src/test/python/apache/aurora/client/test_base.py https://reviews.apache.org/r/31913/#comment123803 Mind adding a host maintenance test instead? I am concerned this may drift over time and will no longer represent how the grouping is actually used. - Maxim Khutornenko On March 11, 2015, 2:53 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31966: Add client support for including messages when changing update state.
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/__init__.py, line 157 https://reviews.apache.org/r/31966/diff/2/?file=891871#file891871line157 Spacing seems off here and below. Fixed. On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 104 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line104 I'd also include a short '-m' name to make typing less tedious. Done. On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 107 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line107 While not entirely consistent, the majority of our CommandOption help strings start with a capital. Changed. On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, lines 123-127 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123 Mind sorting them alphabetically? Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76243 --- On March 12, 2015, 1:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 12, 2015, 1:27 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Review Request 32012: Improve TaskDetector performance by memoizing regular expressions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Description --- We found that the new observer burns 10x the cpu in production. Most of the time is spent in compiling new regular expressions, so memoize them. Follow-up review adds TaskDetector caching in observer. Diffs - src/main/python/apache/thermos/common/path.py 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e src/main/python/apache/thermos/monitoring/detector.py e0922e61ef03fc578988f992aba46570ea1b5d6c src/test/python/apache/thermos/monitoring/BUILD 4e99da403f322940579fd4f9412e022df0790884 src/test/python/apache/thermos/monitoring/test_detector.py e9005c402ec81bbb415d9c814aa7b4e759138304 Diff: https://reviews.apache.org/r/32012/diff/ Testing --- Added generic TaskDetector test and made sure it passes before/after. Thanks, Brian Wickman
Review Request 32013: Cache TaskDetectors for reuse.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Description --- SSIA Diffs - src/main/python/apache/aurora/executor/common/path_detector.py e4135cca09b43e204c52774b747f74212d0a5732 src/main/python/apache/thermos/observer/detector.py 5347cded7061b085b135d62fdb3a5c4a75f81e5c Diff: https://reviews.apache.org/r/32013/diff/ Testing --- ./pants test src/test/python/apache/thermos/observer:: + manual observation Thanks, Brian Wickman
Re: Review Request 31966: Add client support for including messages when changing update state.
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, lines 123-127 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123 Mind sorting them alphabetically? Bill Farner wrote: Done. Spoke too soon here - ordering is important with these, and this pointed out that my new field should have been named `MESSAGE_OPTION` (as it's an option rather than an argument). I've sorted the options, which are order-agnostic. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76243 --- On March 12, 2015, 1:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 12, 2015, 1:27 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 32013: Cache TaskDetectors for reuse.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76318
---
Master (ee1a13a) is red with this patch.
./build-support/jenkins/build.sh
plugins: cov, timeout
[1m
collecting 0 items[0m[1m
collecting 1 items[0m[1m
collected 1 items
[0m
src/test/python/apache/aurora/executor/common/test_path_detector.py::test_path_detector
[31mFAILED[0m
FAILURES
___ test_path_detector ___
[1mdef test_path_detector():[0m
[1m ROOTS = ('/var/lib/mesos1/slaves',
'/var/lib/mesos2/slaves')[0m
[1m FAKE_ROOT = '/var/blah/blah'[0m
[1m FAKE_CHECKPOINT_DIR = 'ckpt'[0m
[1m[0m
[1m path1, path2 = ([0m
[1m ExecutorDetector.path(Match(ROOTS[0],
'slave001', 'framework1', 'executor1', 'latest')),[0m
[1m ExecutorDetector.path(Match(ROOTS[1],
'slave002', 'framework2', 'executor2', 'latest')),[0m
[1m )[0m
[1m[0m
[1m with mock.patch('glob.glob',
return_value=(path1, path2)) as glob:[0m
[1mmpd = MesosPathDetector(root=FAKE_ROOT,
sandbox_path=FAKE_CHECKPOINT_DIR)[0m
[1mpaths = list(mpd.get_paths())[0m
[1m assert len(paths) == 2[0m
[1m[31mE assert 0 == 2[0m
[1m[31mE+ where 0 = len([])[0m
src/test/python/apache/aurora/executor/common/test_path_detector.py:45:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.common.path_detector.xml
[1m[31m 1 failed in 0.06 seconds
[0m
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
. FAILURE
src.test.python.apache.thermos.cli.commands.commands
. SUCCESS
src.test.python.apache.thermos.cli.common
. SUCCESS
src.test.python.apache.thermos.cli.main
. SUCCESS
src.test.python.apache.thermos.common.test_pathspec
. SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
. SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On March 13, 2015, 12:48 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/
---
(Updated March 13, 2015, 12:48 a.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Repository: aurora
Description
---
SSIA
Diffs
-
src/main/python/apache/aurora/executor/common/path_detector.py
e4135cca09b43e204c52774b747f74212d0a5732
src/main/python/apache/thermos/observer/detector.py
5347cded7061b085b135d62fdb3a5c4a75f81e5c
Diff: https://reviews.apache.org/r/32013/diff/
Testing
---
./pants test src/test/python/apache/thermos/observer:: + manual observation
Thanks,
Brian Wickman
Re: Review Request 32013: Cache TaskDetectors for reuse.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76319 --- whoops, forgot that I added os.path.exists filtering -- will update tests. - Brian Wickman On March 13, 2015, 12:48 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 13, 2015, 12:48 a.m.) Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Description --- SSIA Diffs - src/main/python/apache/aurora/executor/common/path_detector.py e4135cca09b43e204c52774b747f74212d0a5732 src/main/python/apache/thermos/observer/detector.py 5347cded7061b085b135d62fdb3a5c4a75f81e5c Diff: https://reviews.apache.org/r/32013/diff/ Testing --- ./pants test src/test/python/apache/thermos/observer:: + manual observation Thanks, Brian Wickman
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76298 --- src/test/python/apache/aurora/client/test_base.py https://reviews.apache.org/r/31913/#comment123828 what does this line do? - Joe Smith On March 10, 2015, 7:53 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 10, 2015, 7:53 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Maxim's feedback. Found the grouping tests! Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs (updated) - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76303 --- Ship it! Master (f62e0f1) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76304 --- Ship it! Thanks! - Maxim Khutornenko On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76307 --- Thanks, it's now on master. - Maxim Khutornenko On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76305 --- Ship it! +10 :) - Joe Smith On March 12, 2015, 4:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 4:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76322 --- @ReviewBot retry - Brian Wickman On March 13, 2015, 12:47 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- (Updated March 13, 2015, 12:47 a.m.) Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Description --- We found that the new observer burns 10x the cpu in production. Most of the time is spent in compiling new regular expressions, so memoize them. Follow-up review adds TaskDetector caching in observer. Diffs - src/main/python/apache/thermos/common/path.py 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e src/main/python/apache/thermos/monitoring/detector.py e0922e61ef03fc578988f992aba46570ea1b5d6c src/test/python/apache/thermos/monitoring/BUILD 4e99da403f322940579fd4f9412e022df0790884 src/test/python/apache/thermos/monitoring/test_detector.py e9005c402ec81bbb415d9c814aa7b4e759138304 Diff: https://reviews.apache.org/r/32012/diff/ Testing --- Added generic TaskDetector test and made sure it passes before/after. Thanks, Brian Wickman
Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions
On March 13, 2015, 1:10 a.m., Brian Wickman wrote: @ReviewBot retry If you believe you have discovered a flaky test (which i assume you're asking the bot to try again), can you please file a ticket? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76322 --- On March 13, 2015, 12:47 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- (Updated March 13, 2015, 12:47 a.m.) Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Description --- We found that the new observer burns 10x the cpu in production. Most of the time is spent in compiling new regular expressions, so memoize them. Follow-up review adds TaskDetector caching in observer. Diffs - src/main/python/apache/thermos/common/path.py 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e src/main/python/apache/thermos/monitoring/detector.py e0922e61ef03fc578988f992aba46570ea1b5d6c src/test/python/apache/thermos/monitoring/BUILD 4e99da403f322940579fd4f9412e022df0790884 src/test/python/apache/thermos/monitoring/test_detector.py e9005c402ec81bbb415d9c814aa7b4e759138304 Diff: https://reviews.apache.org/r/32012/diff/ Testing --- Added generic TaskDetector test and made sure it passes before/after. Thanks, Brian Wickman
Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76324 --- Master (ee1a13a) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_detector . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_process . FAILURE src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 13, 2015, 12:47 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- (Updated March 13, 2015, 12:47 a.m.) Review request for Aurora, Joe Smith and Zameer Manji.
Review Request 32014: Adding more logging into MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Also added missing test coverage. Diffs - config/legacy_untested_classes.txt 06e130fae6bdc43b5e8aff182a530eac65acca53 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java b6f642e319b790544bc538098e7cb78b1bb49997 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 32014: Adding more logging into MaintenanceController.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76327 --- Ship it! Master (ee1a13a) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 1:23 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Also added missing test coverage. Diffs - config/legacy_untested_classes.txt 06e130fae6bdc43b5e8aff182a530eac65acca53 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java b6f642e319b790544bc538098e7cb78b1bb49997 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java bd031a5e0b7d2923e36ca5958c5074f40dc64848 Diff: https://reviews.apache.org/r/32014/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
