[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 24 Jul 2018 02:36:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. IMPALA-7212: Removes --use_krpc flag and remove old DataStream services This change removes the flag --use_krpc which allows users to fall back to using Thrift based implementation of DataStream services. This flag was originally added during development of IMPALA-2567. It has served its purpose. As we port more ImpalaInternalServices to use KRPC, it's becoming increasingly burdensome to maintain parallel implementation of the RPC handlers. Therefore, going forward, KRPC is always enabled. This change removes the Thrift based implemenation of DataStreamServices and also simplifies some of the tests which were skipped when KRPC is disabled. Testing done: core debug build. Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Reviewed-on: http://gerrit.cloudera.org:8080/10835 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc M be/src/exec/data-sink.cc M be/src/exec/exchange-node.cc M be/src/exec/exchange-node.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/backend-client.h D be/src/runtime/data-stream-mgr-base.h D be/src/runtime/data-stream-mgr.h D be/src/runtime/data-stream-recvr-base.h D be/src/runtime/data-stream-recvr.cc D be/src/runtime/data-stream-recvr.h D be/src/runtime/data-stream-sender.cc D be/src/runtime/data-stream-sender.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/fragment-instance-state.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/krpc-data-stream-mgr.h M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/scheduling/scheduler.cc M be/src/service/data-stream-service.cc M be/src/service/impala-internal-service.cc M be/src/service/impala-internal-service.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M bin/run-all-tests.sh M bin/start-impala-cluster.py M common/thrift/ImpalaInternalService.thrift M tests/common/custom_cluster_test_suite.py M tests/common/skip.py D tests/common/test_skip.py M tests/conftest.py M tests/custom_cluster/test_krpc_mem_usage.py M tests/custom_cluster/test_krpc_metrics.py M tests/custom_cluster/test_rpc_exception.py M tests/query_test/test_codegen.py M tests/webserver/test_web_pages.py 44 files changed, 88 insertions(+), 2,143 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/27/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 10 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Tue, 24 Jul 2018 01:51:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6174: [DOCS] Fixed the seed data type for RAND and RANDOM functions
Jinchul Kim has posted comments on this change. ( http://gerrit.cloudera.org:8080/11023 ) Change subject: IMPALA-6174: [DOCS] Fixed the seed data type for RAND and RANDOM functions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6393bd618a26148dd668b3323c32af263637e14 Gerrit-Change-Number: 11023 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Jinchul Kim Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 01:21:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements
Pooja Nilangekar has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. IMPALA-7209: Disallow self referencing in ALTER VIEW statements Previously, ALTER VIEW queries did not carry out reference checks in the analysis phase. This allowed the DDL operation to succeed but subsequent queries to the view threw StackOverflowError because the catalog was unable to resolve the reference. With this change, the AlterViewStmt checks for direct and in-direct self references before altering a view. Testing: Added tests to AnalyzeDDLTest to verify it. Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 --- M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 5 files changed, 101 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/10908/10 -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 10 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@138 PS7, Line 138: FeView > As discussed offline, using InlineViewRef makes it more consistent with col I tried the changes discussed offline. However, the InlineViewRef objects are not equal (their corresponding SQL strings match but the hash of the objects are different). On the other hand, equality check of FeView only compares the QueryStmt and the ColRefs which are equal. http://gerrit.cloudera.org:8080/#/c/10908/8/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/8/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@138 PS8, Line 138: public abstract void collectInlineViewRefs(Set inlineViewRefs); > Shouldn't we also collect view refs from withClause_? I see you added a tes Done. I have also changed the test. http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@148 PS7, Line 148: getWhereSubQuery > I think is is ok since it conveys the intention better than getWhereQuerySt Done -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 10 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Tue, 24 Jul 2018 01:14:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/26/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 Gerrit-Change-Number: 11007 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Tue, 24 Jul 2018 01:07:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11027 ) Change subject: IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/25/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e5ebc214d6620d165e13f8cc80f8fdda100734 Gerrit-Change-Number: 11027 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:53:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7308. Support Avro tables in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10970 ) Change subject: IMPALA-7308. Support Avro tables in LocalCatalog .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/19/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:52:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11007 ) Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/26/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 Gerrit-Change-Number: 11007 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Tue, 24 Jul 2018 00:44:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10973 ) Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/23/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba Gerrit-Change-Number: 10973 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:44:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7257. Support Kudu tables in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10912 ) Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/20/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd Gerrit-Change-Number: 10912 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:37:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10913 ) Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 Gerrit-Change-Number: 10913 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:37:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. IMPALA-7291: [DOCS] Note about no codegen support for CHAR Also, cleaned up confusing examples. Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Reviewed-on: http://gerrit.cloudera.org:8080/11022 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/topics/impala_char.xml 1 file changed, 92 insertions(+), 141 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 00:35:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/354/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 00:28:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 00:28:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 ) Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7baf05f16c6389ed900e0459708005ab44491e Gerrit-Change-Number: 10972 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:25:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10971 ) Change subject: IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/22/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I479b7f517091dd558768601e1e0704a1902b78a5 Gerrit-Change-Number: 10971 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 24 Jul 2018 00:25:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11007 to look at the new patch set (#3). Change subject: IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins .. IMPALA-7333: remove MarkNeedsDeepCopy() in aggs and joins This takes advantage of work (e.g. IMPALA-3200, IMPALA-5844) to remove a couple of uses of the API. Testing: Ran core, ASAN and exhaustive builds. Added a unit test to directly test the attaching behaviour. Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 --- M be/src/exec/grouping-aggregator.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h 4 files changed, 228 insertions(+), 120 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/11007/3 -- To view, visit http://gerrit.cloudera.org:8080/11007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91ac53bacc00df4726c015a30ba5a2026aa4b5f5 Gerrit-Change-Number: 11007 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc@51 PS9, Line 51: return ctx_->Allocate(size); > The temporary result allocation mechanism (used by StringVal(FunctionContex That would also avoid the necessity for the thread_local, because there's no requirement to free each allocation individually, right? -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 24 Jul 2018 00:17:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 00:12:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 ) Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml File docs/topics/impala_char.xml: http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@93 PS1, Line 93: Therefore, LENGTH() represents the : length including any trailing spaces, > I think this is backwards - LENGTH() strips off trailing spaces. CHAR_LENGT Done http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@99 PS1, Line 99: Retruns > typo: Returns Done -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Jul 2018 00:09:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Hello Balazs Jeszenszky, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11022 to look at the new patch set (#2). Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. IMPALA-7291: [DOCS] Note about no codegen support for CHAR Also, cleaned up confusing examples. Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a --- M docs/topics/impala_char.xml 1 file changed, 92 insertions(+), 141 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11022/2 -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11027 ) Change subject: IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/25/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e5ebc214d6620d165e13f8cc80f8fdda100734 Gerrit-Change-Number: 11027 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:58:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@138 PS7, Line 138: FeView > I had no semantic reason, I was only trying to follow the convention of col As discussed offline, using InlineViewRef makes it more consistent with collectTableRefs() http://gerrit.cloudera.org:8080/#/c/10908/8/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/8/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@138 PS8, Line 138: public abstract void collectInlineViewRefs(Set inlineViewRefs); Shouldn't we also collect view refs from withClause_? I see you added a test for it but something like the following would fail. Basically with clause's subqueries not referenced in from clause of the select stmt. (I couldn't think of a better example :D). alter view v2 as with temp(col_a) as (select * from v2) select * from t2; The reason the test case you added works is because the view referenced is also indirectly referenced in the fromClause_ of the SelectStmt. http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@148 PS7, Line 148: getWhereQueryStm > I have changed it to private. I initially named it getWhereSubQueryStmt but I think is is ok since it conveys the intention better than getWhereQueryStmt(). -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 8 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Mon, 23 Jul 2018 23:57:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded
Hello Bharath Vissapragada, Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11027 to review the following change. Change subject: IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded .. IMPALA-7320. Avoid calling getFileStatus() for each partition when table is loaded Prior to this patch, when a table is first loaded, the catalog iterated over each of the partition directories and called getFileStatus() on each, serially, to determine the overall access level of the table. In some testing, each such call took 1-2ms, so this could add many seconds to the overall table load time for a table with thousands of partitions and also add to the NN load. This patch adds some batch pre-fetching of file status information: for any parent directory which contains more than one partition, we use the listStatus() API to fetch the FileStatus objects in bulk. A new unit test verifies the number of API calls made to the NameNode during a table load. Change-Id: I83e5ebc214d6620d165e13f8cc80f8fdda100734 --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java A fe/src/main/java/org/apache/impala/util/FsPermissionCache.java M fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java 4 files changed, 200 insertions(+), 54 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/11027/1 -- To view, visit http://gerrit.cloudera.org:8080/11027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I83e5ebc214d6620d165e13f8cc80f8fdda100734 Gerrit-Change-Number: 11027 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7340. Only send necessary fields in THdfsPartition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11026 ) Change subject: IMPALA-7340. Only send necessary fields in THdfsPartition .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/24/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97e8402efdfdeea06463bb71a40ebb6abd1f11f0 Gerrit-Change-Number: 11026 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:58:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7340. Only send necessary fields in THdfsPartition
Hello Bharath Vissapragada, Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11026 to review the following change. Change subject: IMPALA-7340. Only send necessary fields in THdfsPartition .. IMPALA-7340. Only send necessary fields in THdfsPartition The THdfsPartition Thrift struct is used both for partition metadata (sent from catalogd to coordinator) and for descriptors (sent from coordinator frontend to backends). In the case of the descriptor, not all fields are actually used. This patch cleans up the Thrift struct definition to be more clear which fields are used where, and changes the serialization code to only fill in the necessary fields. Change-Id: I97e8402efdfdeea06463bb71a40ebb6abd1f11f0 --- M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/catalog/CatalogObject.java M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java 5 files changed, 71 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11026/1 -- To view, visit http://gerrit.cloudera.org:8080/11026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I97e8402efdfdeea06463bb71a40ebb6abd1f11f0 Gerrit-Change-Number: 11026 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6214: Determine and warn about stuck fragment instances.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11021 ) Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11021/1/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/11021/1/be/src/runtime/krpc-data-stream-recvr.cc@230 PS1, Line 230: stringstream dstid; : : dstid << recvr_->dest_node_id(); : string frgId = PrintId(recvr_->fragment_instance_id()); : string watchdog_str = "fragment_instance_id= " + frgId + " node= " + dstid.str(); : memset(buf, BUFSZ, 0); : sprintf(buf, "%s : %d %s", __FILE__, __LINE__, watchdog_str.c_str()); constructing this once per batch seems like a big performance red flag. Why not construct this string in the KrpcDataStreamRecvr? I don't know this code super well, but I thought this was constant for a given instance. That said, I also don't know if this is even a safe usage of ScopedWatchKernelStack -- I believe it relies on its argument not ever getting freed, because there is no synchronization that ensures that the "watcher" thread doesn't read this pointer after the "watched" thread exits. In other words, I think you might have a race here where the watcher prints arbitrary junk off of the target thread's stack. http://gerrit.cloudera.org:8080/#/c/11021/1/be/src/runtime/krpc-data-stream-recvr.cc@239 PS1, Line 239: kudu::SetStackTraceSignal(SIGRTMIN + 1); you should call this at init time, not once per batch. I'm not even sure it's thread-safe, and if it is, it probably takes a lock so this would collapse throughput. -- To view, visit http://gerrit.cloudera.org:8080/11021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 Gerrit-Change-Number: 11021 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 23 Jul 2018 23:56:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 7 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 23:56:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs Previously, the IRBuilder of the LlvmCodeGen class used CpuInfo's list of enabled features to determine the validity of certain instructions to emit intrinsics. It did not consider the whitelist which passed while initializing the LlvmCodeGen class. Now, the IRBuilder inspects its own CPU attributes before emitting instruction. This change also adds functionality to modify the CPU attributes of the LlvmCodeGen class for testing. Testing: Verified that the current tests which use and modify CpuInfo produce expected results. Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Reviewed-on: http://gerrit.cloudera.org:8080/10979 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/benchmarks/bloom-filter-benchmark.cc M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/filter-context.cc M be/src/util/cpu-info.cc 6 files changed, 95 insertions(+), 29 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 8 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10971 ) Change subject: IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/22/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I479b7f517091dd558768601e1e0704a1902b78a5 Gerrit-Change-Number: 10971 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10973 to look at the new patch set (#2). Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable .. IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable This adds support for the SHOW FILES IN ... command for LocalFsTable instances. Tested manually against functional.alltypesagg and also covered by existing e2e tests. Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba --- M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/main/java/org/apache/impala/service/Frontend.java 4 files changed, 26 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/10973/2 -- To view, visit http://gerrit.cloudera.org:8080/10973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba Gerrit-Change-Number: 10973 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog
Hello Tianyi Wang, Csaba Ringhofer, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10913 to look at the new patch set (#4). Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog .. IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog This fixed most of the remaining Kudu tests which relied on CTAS. Now only a few Kudu tests fail: FAIL query_test/test_kudu.py::TestKuduOperations::()::test_kudu_col_changed FAIL query_test/test_kudu.py::TestKuduOperations::()::test_kudu_col_null_changed FAIL query_test/test_kudu.py::TestKuduOperations::()::test_kudu_col_not_null_changed FAIL query_test/test_kudu.py::TestKuduOperations::()::test_kudu_col_added The above 4 fail because they are asserting something about the caching behavior of the old catalog implementation. FAIL query_test/test_kudu.py::TestImpalaKuduIntegration::()::test_delete_external_kudu_table FAIL query_test/test_kudu.py::TestImpalaKuduIntegration::()::test_delete_managed_kudu_table These fail due to attempting to load non-existent tables referred to by a DELETE statement. Need to investigate these further, but not related to CTAS. Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/FeDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M fe/src/main/java/org/apache/impala/planner/TableSink.java 9 files changed, 135 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/10913/4 -- To view, visit http://gerrit.cloudera.org:8080/10913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 Gerrit-Change-Number: 10913 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7257. Support Kudu tables in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10912 ) Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/20/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd Gerrit-Change-Number: 10912 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10973 ) Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/23/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba Gerrit-Change-Number: 10973 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7308. Support Avro tables in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10970 ) Change subject: IMPALA-7308. Support Avro tables in LocalCatalog .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/19/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7308. Support Avro tables in LocalCatalog
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10970 to look at the new patch set (#2). Change subject: IMPALA-7308. Support Avro tables in LocalCatalog .. IMPALA-7308. Support Avro tables in LocalCatalog This adds support for loading Avro-formatted tables in LocalCatalog. In the case that the table properties indicate a table is Avro-formatted, the semantics are identical to the existing catalog implementation: - if an explicit avro schema is specified, it overrides the schema provided by the HMS - if no explicit avro schema is specified, one is inferred, and then the inferred schema takes the place of the one provided by the HMS (thus promoting columns like TINYINT to INT) - on COMPUTE STATS, if any discrepancy is discovered between the HMS schema and the inferred schema, an error is emitted. The semantics for LocalCatalog are slightly different in the case of tables which have not been configured as Avro format on the table level: The existing implementation has the behavior that, when a table is loaded, all partitions are inspected, and, if any partition is discovered with Avro format, the above rules are applied. This has some very unexpected results, described in an earlier email to d...@impala.apache.org [1]. To summarize that email thread, the existing behavior was decided to be unintuitive and inconsistent with Hive. Additionally, this behavior requires loading all partitions up-front, which gets in the goal of lazy/granular metadata loading in LocalCatalog. Thus, the LocalCatalog implementation differs as follows: - the "schema override" behavior ONLY occurs if the Avro file format has been selected at a table level. - if an Avro partition is added to a non-Avro table, and that partition has a schema that isn't compatible with the table's schema, an error will occur on read. The thread additionally discusses adding an error message on "alter" to prevent users from adding an Avro partition to a table with an incompatible schema. To keep the scope of this patch minimal, that is not yet implemented here. I filed IMPALA-7309 to change the behavior of the existing catalog implementation to match. [1] https://lists.apache.org/thread.html/fb68c54bd66a40982ee17f9f16f87a4112220a5df035a311bda310f1@%3Cdev.impala.apache.org%3E Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 --- M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java M tests/query_test/test_avro_schema_resolution.py 7 files changed, 166 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10970/2 -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10913 ) Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/18/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 Gerrit-Change-Number: 10913 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10971 to look at the new patch set (#2). Change subject: IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog .. IMPALA-7307 (part 1). Support stats extrapolation in LocalCatalog Tested by running 'run-tests.py -k stats_extrap' and the tests passed. Change-Id: I479b7f517091dd558768601e1e0704a1902b78a5 --- M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/test/java/org/apache/impala/planner/StatsExtrapolationTest.java 7 files changed, 53 insertions(+), 69 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10971/2 -- To view, visit http://gerrit.cloudera.org:8080/10971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I479b7f517091dd558768601e1e0704a1902b78a5 Gerrit-Change-Number: 10971 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7257. Support Kudu tables in LocalCatalog
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10912 to look at the new patch set (#4). Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog .. IMPALA-7257. Support Kudu tables in LocalCatalog This adds support for querying Kudu tables when --use_local_catalog is enabled. With this change, most of the kudu e2e tests pass. Those that don't are related to missing support for CREATE TABLE AS SELECT, which currently has some downcasts to 'Db' causing issues. That will be addressed in a separate patch along with fixing CTAS for FS-backed tables. Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd --- M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java M fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java A fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java A fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalView.java M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/planner/TableSink.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java 33 files changed, 693 insertions(+), 343 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/10912/4 -- To view, visit http://gerrit.cloudera.org:8080/10912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd Gerrit-Change-Number: 10912 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 ) Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/21/ Running initial code review checks. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7baf05f16c6389ed900e0459708005ab44491e Gerrit-Change-Number: 10972 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:48:49 + Gerrit-HasComments: No
[Impala-ASF-CR] Test docs change
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11025 ) Change subject: Test docs change .. Patch Set 1: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/1/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/11025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b183243ad2ed1d982e3be09022ed3a39bd72ab9 Gerrit-Change-Number: 11025 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 23:41:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Test docs change
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11025 ) Change subject: Test docs change .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/1/ Testing docs change. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b183243ad2ed1d982e3be09022ed3a39bd72ab9 Gerrit-Change-Number: 11025 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 23:41:05 + Gerrit-HasComments: No
[Impala-ASF-CR] Test docs change
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11025 Change subject: Test docs change .. Test docs change Change-Id: I4b183243ad2ed1d982e3be09022ed3a39bd72ab9 --- M docs/topics/impala_datatypes.xml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11025/1 -- To view, visit http://gerrit.cloudera.org:8080/11025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4b183243ad2ed1d982e3be09022ed3a39bd72ab9 Gerrit-Change-Number: 11025 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 23 Jul 2018 23:30:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2851/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 23 Jul 2018 23:30:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. Patch Set 6: Code-Review+2 Fix clang-tidy error. Carry Sailesh's +2. -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 23 Jul 2018 23:29:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#6). Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services .. IMPALA-7212: Removes --use_krpc flag and remove old DataStream services This change removes the flag --use_krpc which allows users to fall back to using Thrift based implementation of DataStream services. This flag was originally added during development of IMPALA-2567. It has served its purpose. As we port more ImpalaInternalServices to use KRPC, it's becoming increasingly burdensome to maintain parallel implementation of the RPC handlers. Therefore, going forward, KRPC is always enabled. This change removes the Thrift based implemenation of DataStreamServices and also simplifies some of the tests which were skipped when KRPC is disabled. Testing done: core debug build. Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 --- M be/src/common/global-flags.cc M be/src/exec/data-sink.cc M be/src/exec/exchange-node.cc M be/src/exec/exchange-node.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/backend-client.h D be/src/runtime/data-stream-mgr-base.h D be/src/runtime/data-stream-mgr.h D be/src/runtime/data-stream-recvr-base.h D be/src/runtime/data-stream-recvr.cc D be/src/runtime/data-stream-recvr.h D be/src/runtime/data-stream-sender.cc D be/src/runtime/data-stream-sender.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/fragment-instance-state.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/krpc-data-stream-mgr.h M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/scheduling/scheduler.cc M be/src/service/data-stream-service.cc M be/src/service/impala-internal-service.cc M be/src/service/impala-internal-service.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M bin/run-all-tests.sh M bin/start-impala-cluster.py M common/thrift/ImpalaInternalService.thrift M tests/common/custom_cluster_test_suite.py M tests/common/skip.py D tests/common/test_skip.py M tests/conftest.py M tests/custom_cluster/test_krpc_mem_usage.py M tests/custom_cluster/test_krpc_metrics.py M tests/custom_cluster/test_rpc_exception.py M tests/query_test/test_codegen.py M tests/webserver/test_web_pages.py 44 files changed, 88 insertions(+), 2,143 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10835/6 -- To view, visit http://gerrit.cloudera.org:8080/10835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3 Gerrit-Change-Number: 10835 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml
File docs/topics/impala_char.xml:
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@93
PS1, Line 93: Therefore, LENGTH() represents the
: length including any trailing spaces,
I think this is backwards - LENGTH() strips off trailing spaces. CHAR_LENGTH()
is the alternative version that doesn't:
[localhost:21000] default> select length(cast('test' as char(10)));
Query: select length(cast('test' as char(10)))
Query submitted at: 2018-07-23 16:19:11 (Coordinator:
http://tarmstrong-box:25000)
Query progress can be monitored at:
http://tarmstrong-box:25000/query_plan?query_id=643b0d940529bcf:2872caec
+--+
| length(cast('test' as char(10))) |
+--+
| 4|
+--+
Fetched 1 row(s) in 0.12s
[localhost:21000] default> select char_length(cast('test' as char(10)));
Query: select char_length(cast('test' as char(10)))
Query submitted at: 2018-07-23 16:19:36 (Coordinator:
http://tarmstrong-box:25000)
Query progress can be monitored at:
http://tarmstrong-box:25000/query_plan?query_id=a046dffe3b57352f:4acea776
+---+
| char_length(cast('test' as char(10))) |
+---+
| 10|
+---+
Fetched 1 row(s) in 0.11s
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@99
PS1, Line 99: Retruns
typo: Returns
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Balazs Jeszenszky
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Mon, 23 Jul 2018 23:21:36 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10973 ) Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10973/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10973/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2111 PS1, Line 2111: new ArrayList<> > no particular reason, figured that since Java 7 it's easier to just use the Done -- To view, visit http://gerrit.cloudera.org:8080/10973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba Gerrit-Change-Number: 10973 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:11:56 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 ) Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2160 PS1, Line 2160:*/ > I'm fine with the move to utils. its consistent with the other changes and k, deleted this copy. I'm going to put up a new commit at some time soon to try to consolidate these util functions into a more consistent pattern but didn't make the changes here to avoid churning the patch too much. -- To view, visit http://gerrit.cloudera.org:8080/10972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7baf05f16c6389ed900e0459708005ab44491e Gerrit-Change-Number: 10972 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:10:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10913 ) Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10913/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10913/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@114 PS3, Line 114: load them? > ok, so just for future proofing. yep. improved the TODO to be more clear what I meant. -- To view, visit http://gerrit.cloudera.org:8080/10913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46 Gerrit-Change-Number: 10913 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 23 Jul 2018 23:01:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11024 ) Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO .. IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd --- M docs/topics/impala_conditional_functions.xml 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11024/2 -- To view, visit http://gerrit.cloudera.org:8080/11024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd Gerrit-Change-Number: 11024 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11024 Change subject: IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull .. IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd --- M docs/topics/impala_conditional_functions.xml 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11024/1 -- To view, visit http://gerrit.cloudera.org:8080/11024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd Gerrit-Change-Number: 11024 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7257. Support Kudu tables in LocalCatalog
Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/10912 )
Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java:
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@369
PS3, Line 369: for (KuduPartitionParam partitionParam:
table.getPartitionBy()) {
> I've been somewhat inconsistent with what goes into KuduTable or HdfsTable
moved to FeKuduTable.Utils
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@258
PS3, Line 258: public static List loadPartitionByParams(
> Another option is to put them in a class FeKuduTable.Common. It would be cl
k, I'll move them to a new class FeKuduTable.Utils (seems the name "utils" is
used more often in the code base)
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java:
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java@59
PS3, Line 59: public static LocalTable loadFromKudu(LocalDb db, Table
msTable) {
> package-private? It's for the local package only.
Done
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java@139
PS3, Line 139: {
> long line
Done
http://gerrit.cloudera.org:8080/#/c/10912/3/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java@147
PS3, Line 147: // TODO(todd)
> oops, this was a bug. It was a TODO to setKey_columns, but then I did the T
yea, appears key_columns are only used by the backend for logging. fixed.
--
To view, visit http://gerrit.cloudera.org:8080/10912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd
Gerrit-Change-Number: 10912
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Tianyi Wang
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Mon, 23 Jul 2018 22:45:48 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6214: Determine and warn about stuck fragment instances.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11021 ) Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/17/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 Gerrit-Change-Number: 11021 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 22:41:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 23 Jul 2018 22:39:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10792/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1375 PS8, Line 1375: Set msPartitionNames = Sets.newHashSet(); : msPartitionNames.addAll(client.listPartitionNames(db_.getName(), name_, (short) -1)); : // Names of loaded partitions in this table > I changed the definition of it instead of removing. We have to drop the par nice catch. http://gerrit.cloudera.org:8080/#/c/10792/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1414 PS9, Line 1414: dropPartitions(dirtyPartitions, false); Add a comment that dirtyPartitions are reloaded and hence cachedirectives are not dropped. Easier for those reading the code to understand. -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 23 Jul 2018 22:38:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6174: [DOCS] Fixed the seed data type for RAND and RANDOM functions
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11023 Change subject: IMPALA-6174: [DOCS] Fixed the seed data type for RAND and RANDOM functions .. IMPALA-6174: [DOCS] Fixed the seed data type for RAND and RANDOM functions Change-Id: If6393bd618a26148dd668b3323c32af263637e14 --- M docs/topics/impala_math_functions.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/11023/1 -- To view, visit http://gerrit.cloudera.org:8080/11023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If6393bd618a26148dd668b3323c32af263637e14 Gerrit-Change-Number: 11023 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Jul 2018 22:37:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: memset NULL
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10948 ) Change subject: IMPALA-5031: Fix undefined behavior: memset NULL .. IMPALA-5031: Fix undefined behavior: memset NULL memset has undefined behavior when its first argument is NULL. The instance fixed here was found by Clang's undefined behavior sanitizer. It was found in the end-to-end tests. The interesting part of the stack trace is: /exec/data-source-scan-node.cc:152:10: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:62:79: note: nonnull attribute specified here #0 0x482fd8e in DataSourceScanNode::GetNextInputBatch() /exec/data-source-scan-node.cc:152:3 #1 0x482fb40 in DataSourceScanNode::Open(RuntimeState*) /exec/data-source-scan-node.cc:124:10 #2 0x47ef854 in AggregationNode::Open(RuntimeState*) /exec/aggregation-node.cc:71:49 #3 0x23506a4 in FragmentInstanceState::Open() /runtime/fragment-instance-state.cc:266:53 #4 0x234b6a8 in FragmentInstanceState::Exec() /runtime/fragment-instance-state.cc:81:12 #5 0x236ee52 in QueryState::ExecFInstance(FragmentInstanceState*) /runtime/query-state.cc:401:24 #6 0x237093e in QueryState::StartFInstances()::$_0::operator()() const /runtime/query-state.cc:341:44 Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Reviewed-on: http://gerrit.cloudera.org:8080/10948 Reviewed-by: Jim Apple Tested-by: Impala Public Jenkins --- M be/src/exec/data-source-scan-node.cc A be/src/util/ubsan.h 2 files changed, 39 insertions(+), 1 deletion(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 5 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11022 Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR .. IMPALA-7291: [DOCS] Note about no codegen support for CHAR Also, cleaned up confusing examples. Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a --- M docs/topics/impala_char.xml 1 file changed, 75 insertions(+), 141 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11022/1 -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0666ae3d45fbd8615d3fa9a8626ebd29cf94fb4b Gerrit-Change-Number: 11001 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Mon, 23 Jul 2018 22:23:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11020 ) Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/14/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60 Gerrit-Change-Number: 11020 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 22:16:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6214: Determine and warn about stuck fragment instances.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11021 ) Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/17/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/11021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 Gerrit-Change-Number: 11021 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 21:52:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6214: Determine and warn about stuck fragment instances.
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11021 Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. .. IMPALA-6214: Determine and warn about stuck fragment instances. In order to diagnose query hangs, we need to know the fragment execution time on a particular exec node. Inspecting the query run time profile to find the cause of hang does not give much details. This change helps in finding the problematic 'exec node' where the fragment execution is not making progress. The change makes use of kudu watchdog that periodically polls and prints the delay in response from an exec node. Testing: a) Added a delay on the sender side as a part of manual test case to notice the affect of change. The watchdog prints the detail of fragmentID and nodeID when the watchdog timer expires. b) Ran the core test without failure. Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 --- M be/src/common/global-flags.cc M be/src/runtime/krpc-data-stream-recvr.cc 2 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/11021/1 -- To view, visit http://gerrit.cloudera.org:8080/11021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 Gerrit-Change-Number: 11021 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/16/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11014 to look at the new patch set (#2). Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. IMPALA-7330. After LOAD DATA, only refresh affected partition This changes LOAD DATA so that, if a specific partition is provided, only the named partition will be refreshed upon completion of the statement. No new tests are added since this code path is covered by existing tests and this just optimizes the metadata reload. I did verify looking at the catalogd logs that only the single specified partition was refreshed when I issued a LOAD statement from the shell. Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 --- M be/src/service/client-request-state.cc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/11014/2 -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2850/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/11014/1/be/src/service/client-request-state.cc@185 PS1, Line 185: > nit: 4 space indent Done -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 23 Jul 2018 21:51:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/15/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/11001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0666ae3d45fbd8615d3fa9a8626ebd29cf94fb4b Gerrit-Change-Number: 11001 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Mon, 23 Jul 2018 21:50:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. IMPALA-7234: Improve memory estimates produced by the Planner Previously, the planner used the getMajorityFormat to estimate the memory requirements of its partitions. Additionally, before IMPALA-6625 was merged, the majority format for a multi-format table with no numerical majority was calculated using a HashMap, thus producing non deterministic results. This change ensures that the memory estimate is deterministic and always based on partition that has the maximum memory requirement. Testing: Ran all PlannerTests. Also, modified plans of scans with multiple partitions to ensure that the memory estimate produced corresponds to the partition with the maximum requirement. Change-Id: I0666ae3d45fbd8615d3fa9a8626ebd29cf94fb4b --- M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering-disabled.test M testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test 8 files changed, 54 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/11001/4 -- To view, visit http://gerrit.cloudera.org:8080/11001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0666ae3d45fbd8615d3fa9a8626ebd29cf94fb4b Gerrit-Change-Number: 11001 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7234: Improve memory estimates produced by the Planner
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11001 ) Change subject: IMPALA-7234: Improve memory estimates produced by the Planner .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11001/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/11001/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@83 PS1, Line 83: int numInstances = fragment_.getNumInstances(queryOptions.getMt_dop()); : // Compute the per-instance number of partitions, taking the number of nodes : // and the data partition of the fragment executing this sink into account. : long numPartitionsPerInstance = > you can probably add a check for unsupported formats Done -- To view, visit http://gerrit.cloudera.org:8080/11001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0666ae3d45fbd8615d3fa9a8626ebd29cf94fb4b Gerrit-Change-Number: 11001 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Mon, 23 Jul 2018 21:50:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11020 ) Change subject: IMPALA-7242/IMPALA-7243: check for overflow when converting IntVal to DecimalValue .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/14/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/11020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5808802096bb0e6cfd4ab6464538474e42cab60 Gerrit-Change-Number: 11020 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 21:44:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5826 IMPALA-7162: [DOCS] Documented the IDLE SESSION TIMEOUT query option
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/11004 ) Change subject: IMPALA-5826 IMPALA-7162: [DOCS] Documented the IDLE_SESSION_TIMEOUT query option .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37182a3c5cf19fdcbb5f247ed71d43f963143510 Gerrit-Change-Number: 11004 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Jul 2018 20:57:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 7 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:55:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:54:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Code-Review+1 Will let Bikram verify that his comments were addressed. -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:41:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:41:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: I cancelled the job while playing around - ignore the failure. -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:39:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/12/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:38:05 + Gerrit-HasComments: No
[Impala-ASF-CR] Test gerrit trigger with docs change
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11013 ) Change subject: Test gerrit trigger with docs change .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I6301aca3a92841d5971957981090f6098b58f756 Gerrit-Change-Number: 11013 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] Test gerrit trigger not disabled
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11011 ) Change subject: Test gerrit trigger not disabled .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I17e7c82ed127c8d94dc6e9425e94d82bd5dcd4fd Gerrit-Change-Number: 11011 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] Test gerrit trigger 2
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11012 ) Change subject: Test gerrit trigger 2 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I87f87032ca041f7ac68d782a48fe7bab84edbdf9 Gerrit-Change-Number: 11012 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Test gerrit trigger
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11010 ) Change subject: Test gerrit trigger .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I52314e4b72f36d9bef0d9572fcaa00668f0c0097 Gerrit-Change-Number: 11010 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:23:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3675: part 1: -Werror for ASAN
Tim Armstrong has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11002 ) Change subject: IMPALA-3675: part 1: -Werror for ASAN .. IMPALA-3675: part 1: -Werror for ASAN This fixes some clang warnings and enables -Werror going forward for ASAN. It adds -Wno-return-type-c-linkage to suppress a warning that otherwise would fail the build. It also enables the mismatched tags check and fixes the various instances of it (this warning is irritating for YouCompleteMe users). Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec --- M .clang-tidy M be/CMakeLists.txt M be/src/exec/hdfs-table-writer.h M be/src/exprs/expr.h M be/src/exprs/scalar-expr.h M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/mem-tracker.h 7 files changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/11002/6 -- To view, visit http://gerrit.cloudera.org:8080/11002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Gerrit-Change-Number: 11002 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3675: part 1: -Werror for ASAN
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11002 ) Change subject: IMPALA-3675: part 1: -Werror for ASAN .. IMPALA-3675: part 1: -Werror for ASAN This fixes some clang warnings and enables -Werror going forward for ASAN. It adds -Wno-return-type-c-linkage to suppress a warning that otherwise would fail the build. It also enables the mismatched tags check and fixes the various instances of it (this warning is irritating for YouCompleteMe users). Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Reviewed-on: http://gerrit.cloudera.org:8080/11002 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M .clang-tidy M be/CMakeLists.txt M be/src/exec/hdfs-table-writer.h M be/src/exprs/expr.h M be/src/exprs/scalar-expr.h M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/mem-tracker.h 7 files changed, 10 insertions(+), 13 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Gerrit-Change-Number: 11002 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-6299: Use LlvmCodeGen's internal list of white-li > Use LlvmCodeGen's internal list of white-listed CPU attributes for handcraf Done http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG@10 PS5, Line 10: determine the validity of certain : instructions > to emit intrinsics Done http://gerrit.cloudera.org:8080/#/c/10979/5/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/10979/5/be/src/codegen/llvm-codegen-test.cc@116 PS5, Line 116: EnableCodeGenCPUFeat > nit: EnableCodeGenCPUFeature Done -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:10:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs Previously, the IRBuilder of the LlvmCodeGen class used CpuInfo's list of enabled features to determine the validity of certain instructions to emit intrinsics. It did not consider the whitelist which passed while initializing the LlvmCodeGen class. Now, the IRBuilder inspects its own CPU attributes before emitting instruction. This change also adds functionality to modify the CPU attributes of the LlvmCodeGen class for testing. Testing: Verified that the current tests which use and modify CpuInfo produce expected results. Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f --- M be/src/benchmarks/bloom-filter-benchmark.cc M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/filter-context.cc M be/src/util/cpu-info.cc 6 files changed, 95 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10979/6 -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 ) Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs .. Patch Set 6: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/12/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Jul 2018 20:10:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 19:54:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 23 Jul 2018 19:50:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Mon, 23 Jul 2018 19:50:54 + Gerrit-HasComments: No
[Impala-ASF-CR] Test gerrit trigger 2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11012 ) Change subject: Test gerrit trigger 2 .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: https://issues.apache.org/jira/browse/IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87f87032ca041f7ac68d782a48fe7bab84edbdf9 Gerrit-Change-Number: 11012 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 19:37:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5826 IMPALA-7162: [DOCS] Documented the IDLE SESSION TIMEOUT query option
Hello Zoltan Borok-Nagy, Balazs Jeszenszky, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11004 to look at the new patch set (#2). Change subject: IMPALA-5826 IMPALA-7162: [DOCS] Documented the IDLE_SESSION_TIMEOUT query option .. IMPALA-5826 IMPALA-7162: [DOCS] Documented the IDLE_SESSION_TIMEOUT query option Also, claried cacelled queries vs closed queries Change-Id: I37182a3c5cf19fdcbb5f247ed71d43f963143510 --- M docs/impala.ditamap M docs/shared/impala_common.xml A docs/topics/impala_idle_session_timeout.xml M docs/topics/impala_timeouts.xml 4 files changed, 177 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11004/2 -- To view, visit http://gerrit.cloudera.org:8080/11004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I37182a3c5cf19fdcbb5f247ed71d43f963143510 Gerrit-Change-Number: 11004 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11014 ) Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/9/ Running initial code review checks. -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Jul 2018 19:30:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7330. After LOAD DATA, only refresh affected partition
Hello Bharath Vissapragada, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11014 to review the following change. Change subject: IMPALA-7330. After LOAD DATA, only refresh affected partition .. IMPALA-7330. After LOAD DATA, only refresh affected partition This changes LOAD DATA so that, if a specific partition is provided, only the named partition will be refreshed upon completion of the statement. No new tests are added since this code path is covered by existing tests and this just optimizes the metadata reload. I did verify looking at the catalogd logs that only the single specified partition was refreshed when I issued a LOAD statement from the shell. Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 --- M be/src/service/client-request-state.cc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/11014/1 -- To view, visit http://gerrit.cloudera.org:8080/11014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b29846deac49a89abcd3495e4b757ef536ff331 Gerrit-Change-Number: 11014 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bharath Vissapragada
