[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 ) Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 .. Patch Set 3: Passed pre-review-test: https://jenkins.impala.io/job/pre-review-test/196/ -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 05 Aug 2018 06:55:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 16: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 16 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 05:08:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/193/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:58:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/192/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 14 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:58:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 16: Code-Review+1 (1 comment) Fixed formatting and carry Adam's +1. http://gerrit.cloudera.org:8080/#/c/11039/15/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11039/15/fe/src/main/java/org/apache/impala/util/SentryProxy.java@334 PS15, Line 334: PrincipalPrivilege existingPriv = catalog_.getPrincipalPrivilege(roleName, > line too long (94 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 16 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:34:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. IMPALA-7342: Add initial support for user-level permissions This patch refactors the authorization code in prepartion to add initial support for for user-level permissions (IMPALA-6794) and object ownership (IMPALA-7075). It introduces the notion of Principal to store either role or user. The authorization tests are updated to run the tests with user and role permissions. Testing: - Update authorization tests - Ran core tests Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f --- M be/src/catalog/catalog-util.cc M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java M fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java M fe/src/main/java/org/apache/impala/analysis/ShowGrantRoleStmt.java M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java A fe/src/main/java/org/apache/impala/catalog/Principal.java R fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java D fe/src/main/java/org/apache/impala/catalog/Role.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/java/org/apache/impala/util/SentryPolicyService.java M fe/src/main/java/org/apache/impala/util/SentryProxy.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java 21 files changed, 987 insertions(+), 554 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/11039/16 -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 16 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/191/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/10813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe Gerrit-Change-Number: 10813 Gerrit-PatchSet: 14 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Sun, 05 Aug 2018 04:31:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/11039/15/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11039/15/fe/src/main/java/org/apache/impala/util/SentryProxy.java@334 PS15, Line 334: PrincipalPrivilege existingPriv = catalog_.getPrincipalPrivilege(roleName, privilege); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:30:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 15: Code-Review+1 (3 comments) Fixed formatting and carry Adam's +1. http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@257 PS14, Line 257: public synchronized Principal dropRole(User user, String roleName) > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@269 PS14, Line 269:*/ > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@282 PS14, Line 282:*/ > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:29:59 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. IMPALA-7342: Add initial support for user-level permissions This patch refactors the authorization code in prepartion to add initial support for for user-level permissions (IMPALA-6794) and object ownership (IMPALA-7075). It introduces the notion of Principal to store either role or user. The authorization tests are updated to run the tests with user and role permissions. Testing: - Update authorization tests - Ran core tests Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f --- M be/src/catalog/catalog-util.cc M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java M fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java M fe/src/main/java/org/apache/impala/analysis/ShowGrantRoleStmt.java M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java A fe/src/main/java/org/apache/impala/catalog/Principal.java R fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java D fe/src/main/java/org/apache/impala/catalog/Role.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/java/org/apache/impala/util/SentryPolicyService.java M fe/src/main/java/org/apache/impala/util/SentryProxy.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java 21 files changed, 986 insertions(+), 554 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/11039/15 -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 14: Code-Review+1 Rebased and carry +1 -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 14 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sun, 05 Aug 2018 04:24:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/11039 )
Change subject: IMPALA-7342: Add initial support for user-level permissions
..
Patch Set 14:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java
File fe/src/main/java/org/apache/impala/util/SentryProxy.java:
http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@257
PS14, Line 257: public synchronized Principal dropRole(User user, String
roleName) throws ImpalaException {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@269
PS14, Line 269: public synchronized Principal grantRoleGroup(User user,
String roleName, String groupName)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@282
PS14, Line 282: public synchronized Principal revokeRoleGroup(User user,
String roleName, String groupName)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@333
PS14, Line 333: PrincipalPrivilege existingPriv =
catalog_.getPrincipalPrivilege(roleName, privilege);
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/11039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f
Gerrit-Change-Number: 11039
Gerrit-PatchSet: 14
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Sun, 05 Aug 2018 04:25:31 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions
Fredy Wijaya has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. IMPALA-7342: Add initial support for user-level permissions This patch refactors the authorization code in prepartion to add initial support for for user-level permissions (IMPALA-6794) and object ownership (IMPALA-7075). It introduces the notion of Principal to store either role or user. The authorization tests are updated to run the tests with user and role permissions. Testing: - Update authorization tests - Ran core tests Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f --- M be/src/catalog/catalog-util.cc M common/thrift/CatalogObjects.thrift M fe/src/main/java/org/apache/impala/analysis/CreateDropRoleStmt.java M fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java M fe/src/main/java/org/apache/impala/analysis/ShowGrantRoleStmt.java M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java A fe/src/main/java/org/apache/impala/catalog/Principal.java R fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java D fe/src/main/java/org/apache/impala/catalog/Role.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/java/org/apache/impala/util/SentryPolicyService.java M fe/src/main/java/org/apache/impala/util/SentryProxy.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java 21 files changed, 983 insertions(+), 552 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/11039/14 -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 14 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class
Sailesh Mukil has posted comments on this change. (
http://gerrit.cloudera.org:8080/10813 )
Change subject: IMPALA-7163: Implement a state machine for the QueryState class
..
Patch Set 13:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/10813/13//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10813/13//COMMIT_MSG@28
PS13, Line 28: The fragment instances update the query wide query status if an
error is hit
> nit: a few long lines here
Done
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.h
File be/src/runtime/fragment-instance-state.h:
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.h@79
PS13, Line 79: hould WaitForPrepare
> nit: update comment
Done
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.cc@86
PS13, Line 86: if (!status.ok()) {
: goto done;
: }
> nit: one line
Done
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.cc@98
PS13, Line 98: if (!status.ok()) {
: goto done;
: }
> nit: one line
Done
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/fragment-instance-state.cc@107
PS13, Line 107: <=
> ==
Hmm, the enums are ordered incorrectly. I think the right thing to do would
just be to adjust that.
The UpdateState() function also logically expects that WAITIING_FOR_PREPARE
comes before WAITING_FOR_CODEGEN.
I've made the change in the thrift structure. Let me know if you have any
concerns.
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/query-state.cc@217
PS13, Line 217:
> The method comment mentions that : "A state transition happens if the curre
It should be a DCHECK. Added it.
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/query-state.cc@390
PS13, Line 390: fis_map_.emplace(fis->instance_id(), fis);
> any specific reason why you moved this before you actually start up the thr
There's a race between here and L141 and L156 in the coordinator.cc file.
In L146 in coordinator.cc, the QueryState::GetFInstancesState() call blocks on
WaitForPrepare(), which can unblock before the 'fis_map_' can be updated with
the last fragment instance, which will cause the coordinator to cancel the
query.
Updated the comment above.
http://gerrit.cloudera.org:8080/#/c/10813/13/be/src/runtime/query-state.cc@435
PS13, Line 435: ReportExecStatusAux(true, thread_create_status, nullptr, true);
> looks like we can now return a done exec status before the started fragment
There actually is no issue in sending this report earlier. But I see the
confusion that's derived from the special case behavior here. Michael and I had
a conversation about the same in a previous patchset.
I think the code becomes more readable if we go with your suggestion. So I've
added the WaitForePrepare() since that was the old behavior anyway.
http://gerrit.cloudera.org:8080/#/c/10813/12/tests/failure/test_failpoints.py
File tests/failure/test_failpoints.py:
http://gerrit.cloudera.org:8080/#/c/10813/12/tests/failure/test_failpoints.py@162
PS12, Line 162: i = 0
> It should work with for i in range(50):
Done
--
To view, visit http://gerrit.cloudera.org:8080/10813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe
Gerrit-Change-Number: 10813
Gerrit-PatchSet: 13
Gerrit-Owner: Sailesh Mukil
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Dan Hecht
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Sailesh Mukil
Gerrit-Comment-Date: Sun, 05 Aug 2018 03:55:26 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class
Hello Michael Ho, Joe McDonnell, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#14). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. IMPALA-7163: Implement a state machine for the QueryState class This patch adds a state machine for the QueryState class. The motivation behind this patch is to make the query lifecycle from the point of view of an executor much easier to reason about and this patch is key for a follow on patch for IMPALA-2990 where the status reporting will be per-query rather than per-fragment-instance. Currently, the state machine provides no other purpose, and it will mostly be used for IMPALA-2990. We introduce 5 possible states for the QueryState which include 3 terminal states (FINISHED, CANCELLED and ERROR) and 2 non-terminal states (PREPARING, EXECUTING). The transition from one state to the next is always handled by a single thread which is also the QueryState thread. This thread will additionally bear the purpose of sending periodic updates after IMPALA-4063, which is the primary reason behind having only this thread modify the state of the query. Counting barriers are introduced to keep a count of how many fragment instances have finished Preparing and Executing. These barriers also block until all the fragment instances have finished a respective state. The fragment instances update the query wide query status if an error is hit and unblocks the barrier if it is in the EXECUTING state. The PREPARING state blocks regardless of whether a fragment instance hit an error or not, until all the fragment instances have completed successfully or unsuccessfully, to maintain the invariant that fragment instances cannot be cancelled until the entire QueryState has finished PREPARING. The status reporting protocol has not been changed and remains exactly as it was. Testing: - Added 3 failure points in the query lifecycle using debug actions and added tests to validate the same (extension of IMPALA-7376). - Ran 'core' and 'exhaustive' tests. Future related work: 1) IMPALA-2990: Make status reporting per-query. 2) Try to logically align the FIS states with the QueryState states. 3) Consider mirroring the QueryState state machine to CoordinatorBackendState Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe --- M be/src/runtime/coordinator.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-instance-state.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M common/thrift/ImpalaInternalService.thrift M tests/failure/test_failpoints.py 7 files changed, 286 insertions(+), 69 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/10813/14 -- To view, visit http://gerrit.cloudera.org:8080/10813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe Gerrit-Change-Number: 10813 Gerrit-PatchSet: 14 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. IMPALA-7394: Don't print stack trace in ExpireSessions() When sessions expire, ExpireSessions() may create excessive amount of log spew due to printing of the stack traces esp when there are a massive amount of sessions expiring at the same time. This stack crawling also unnecessarily extends the critical section under the session_state_map_lock_, increasing the contention for that lock. This change converts the use of Status() to Status::Expected() to remove the unnecessary stack crawl. Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Reviewed-on: http://gerrit.cloudera.org:8080/7 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/7 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Gerrit-Change-Number: 7 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Gerrit-Change-Number: 7 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 21:23:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2922/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/7 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Gerrit-Change-Number: 7 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 18:12:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Gerrit-Change-Number: 7 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 18:12:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7 ) Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions() .. Patch Set 1: Build failed due to IMPALA-7328 -- To view, visit http://gerrit.cloudera.org:8080/7 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa Gerrit-Change-Number: 7 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 18:11:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Gerrit-Change-Number: 10995 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 04 Aug 2018 17:42:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions In the prior code, the authorization checker for the masked privilege requests skips the check for system database access. As a result, certain commands, such as SHOW CREATE VIEW that references built-in database requires permission to access to the built-in database where accessing built-in database should always be allowed. The patch fixes it by using the authorizePrivilegeRequest() method that does a check on the system database similar to how other authorization checks are performed. Testing: - Added new authorization test - Ran all FE tests Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Reviewed-on: http://gerrit.cloudera.org:8080/10995 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java 3 files changed, 42 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Gerrit-Change-Number: 10995 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-6789: disable impersonation in hive in minicluster
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9 ) Change subject: IMPALA-6789: disable impersonation in hive in minicluster .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 9 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 04 Aug 2018 17:40:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 ) Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/190/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 04 Aug 2018 15:31:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 ) Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/189/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 04 Aug 2018 15:23:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc@51 PS9, Line 51: return ctx_->Allocate(size); > Personally I would vote to upgrade (or just patch) rapidjson even if it wil I'm ok since this patch is for 3.x. We're still using the 2.x branch in production... Patch for upgrade rapidjson to v1.1.0 is ready for review: https://gerrit.cloudera.org/#/c/11124/ -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 04 Aug 2018 14:59:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11124 to look at the new patch set (#3). Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 .. IMPALA-7364: Bump RapidJSON version to 1.1.0 There're five kinds of broken APIs to fix: * Document::AddMember can't accept parameters in const char* types. These parameters should be wrapped with rapidjson::StringRef(). * Document::AddMember can't accpet primitive values like int, bool, double, etc. These parameters should be explicitly constructed into rapidjson::Value. * Document::GetParseError now returns ParseErrorCode instead of a string. We should wrap it with GetParseError_En(). The error messages are also changed. Strings in unit tests should be changed correspondingly. * rapidjson::FileStream is replaced by rapidjson::FileReadStream Tests: * Pass all tests in my dev env Change-Id: I21353b0d769f81c13f506737e41fbac17655245c --- M be/src/kudu/util/jsonreader-test.cc M be/src/kudu/util/jsonreader.cc M be/src/kudu/util/jsonwriter.cc M be/src/rpc/impala-service-pool.cc M be/src/rpc/rpc-mgr.cc M be/src/rpc/rpc-trace.cc M be/src/runtime/coordinator-backend-state.cc M be/src/service/impala-http-handler.cc M be/src/statestore/statestore.cc M be/src/util/collection-metrics.h M be/src/util/default-path-handlers.cc M be/src/util/logging-support.cc M be/src/util/metrics.cc M be/src/util/metrics.h M be/src/util/redactor-config-parser-test.cc M be/src/util/redactor.cc M be/src/util/thread.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M bin/impala-config.sh 20 files changed, 126 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11124/3 -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 ) Change subject: IMPALA-7364: Add RapidJson 1.1.0 .. Patch Set 3: It works as expected. Patch ready for review: https://gerrit.cloudera.org/#/c/11124/ -- To view, visit http://gerrit.cloudera.org:8080/11092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859 Gerrit-Change-Number: 11092 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 04 Aug 2018 14:56:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/11124 )
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/rpc/impala-service-pool.cc
File be/src/rpc/impala-service-pool.cc:
http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/rpc/impala-service-pool.cc@268
PS2, Line 268: value->AddMember("idle_threads",
Value(service_queue_.estimated_idle_worker_count()).Move(),
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/util/metrics.h
File be/src/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/util/metrics.h@169
PS2, Line 169: document->AddMember(rapidjson::StringRef(key_.c_str()), val,
document->GetAllocator());
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/11124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c
Gerrit-Change-Number: 11124
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 04 Aug 2018 14:50:53 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7364: Bump RapidJSON version to 1.1.0
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11124 Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 .. IMPALA-7364: Bump RapidJSON version to 1.1.0 There're five kinds of broken APIs to fix: * Document::AddMember can't accept parameters in const char* types. These parameters should be wrapped with rapidjson::StringRef(). * Document::AddMember can't accpet primitive values like int, bool, double, etc. These parameters should be explicitly constructed into rapidjson::Value. * Document::GetParseError now returns ParseErrorCode instead of a string. We should wrap it with GetParseError_En(). The error messages are also changed. Strings in unit tests should be changed correspondingly. * rapidjson::FileStream is replaced by rapidjson::FileReadStream Tests: * Pass all tests in my dev env Change-Id: I21353b0d769f81c13f506737e41fbac17655245c --- M be/src/kudu/util/jsonreader-test.cc M be/src/kudu/util/jsonreader.cc M be/src/kudu/util/jsonwriter.cc M be/src/rpc/impala-service-pool.cc M be/src/rpc/rpc-mgr.cc M be/src/rpc/rpc-trace.cc M be/src/runtime/coordinator-backend-state.cc M be/src/service/impala-http-handler.cc M be/src/statestore/statestore.cc M be/src/util/collection-metrics.h M be/src/util/default-path-handlers.cc M be/src/util/logging-support.cc M be/src/util/metrics.cc M be/src/util/metrics.h M be/src/util/redactor-config-parser-test.cc M be/src/util/redactor.cc M be/src/util/thread.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M bin/impala-config.sh 20 files changed, 124 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11124/2 -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang
[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2921/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Gerrit-Change-Number: 10995 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 04 Aug 2018 14:32:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Gerrit-Change-Number: 10995 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 04 Aug 2018 14:32:40 + Gerrit-HasComments: No
