[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 10: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9005/ -- To view, visit http://gerrit.cloudera.org:8080/19379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ee8b6b7559e6590698b46ef1d574e55ed52f9a Gerrit-Change-Number: 19379 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 31 Jan 2023 07:54:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. IMPALA-11285: Deflake timeout in test_async_load The LOAD statement in TestAsyncLoadData.test_async_load intermittently times out in S3 builds. The test doesn't measure the performance of the query execution. It just makes sure the query succeed and asserts it waits more than 3s (when enable_async_load_data = True). It doesn't make sense to fail the test if the query runs longer than 10s. This bumps the timeout from 10s to 20s. Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Reviewed-on: http://gerrit.cloudera.org:8080/19452 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/metadata/test_load.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Gerrit-Change-Number: 19452 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Gerrit-Change-Number: 19452 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 31 Jan 2023 06:33:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11693: Enable allow erasure coded files by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19362 ) Change subject: IMPALA-11693: Enable allow_erasure_coded_files by default .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cfef087f2a7ae0889f47e85c5fab61a795d8fd4 Gerrit-Change-Number: 19362 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 05:11:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 31 Jan 2023 04:43:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11872: Fix typo in executor groups flag description
Yifan Zhang has abandoned this change. ( http://gerrit.cloudera.org:8080/19453 ) Change subject: IMPALA-11872: Fix typo in executor_groups flag description .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/19453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Idb97076f446a87f810efb51decf261db2df4d744 Gerrit-Change-Number: 19453 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yifan Zhang
[Impala-ASF-CR] IMPALA-11872: Fix typo in executor groups flag description
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19453 ) Change subject: IMPALA-11872: Fix typo in executor_groups flag description .. Patch Set 1: > Patch Set 1: > > Is it sure that it is a typo? > Here it seems that the default value is indeed 1: > > https://github.com/apache/impala/blob/43928b190bb86b2a9d7378292c5825d3a4aac5fc/be/src/service/impala-server.cc#L405 Ah indeed, I thought it was an explanation of the example --executor_groups default-pool-1:3. -- To view, visit http://gerrit.cloudera.org:8080/19453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb97076f446a87f810efb51decf261db2df4d744 Gerrit-Change-Number: 19453 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Tue, 31 Jan 2023 04:19:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9005/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ee8b6b7559e6590698b46ef1d574e55ed52f9a Gerrit-Change-Number: 19379 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 31 Jan 2023 02:43:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9004/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bd2dce248a9e096fc1c0bd914fc3fa4686fb0 Gerrit-Change-Number: 19419 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 31 Jan 2023 02:41:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance
lipeng...@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ee8b6b7559e6590698b46ef1d574e55ed52f9a Gerrit-Change-Number: 19379 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 31 Jan 2023 02:36:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11809: Support non unique primary key for Kudu
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d7882bf3d01a3492cc9827c072d1f3200d9eebd Gerrit-Change-Number: 19383 Gerrit-PatchSet: 12 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 31 Jan 2023 02:14:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11809: Support non unique primary key for Kudu
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/19383/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/19383/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2365 PS10, Line 2365: partition by hash > It's in the goals during initial design, but removed later due to too many In this case, there is only one partition for a table so the table could not be large. They think it's a rare use case. -- To view, visit http://gerrit.cloudera.org:8080/19383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d7882bf3d01a3492cc9827c072d1f3200d9eebd Gerrit-Change-Number: 19383 Gerrit-PatchSet: 12 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 31 Jan 2023 02:07:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11809: Support non unique primary key for Kudu
Wenzhe Zhou has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/19383 ) Change subject: IMPALA-11809: Support non unique primary key for Kudu .. IMPALA-11809: Support non unique primary key for Kudu Kudu engine recently enables the auto-incrementing column feature. The feature works by appending a system generated auto-incrementing column to the primary key columns to guarantee the uniqueness on primary key when the primary key columns can be non-unique. The non unique primary key columns and the auto-incrementing column form the effective unique composite primary key. This auto-incrementing column is named as 'auto_incrementing_id' with big int type. The assignment to it during insertion is automatic so insertion statements should not specify values for auto-incrementing column. In current Kudu implementation, there is no central key provider for auto-incrementing columns. It uses a per tablet-server global counter to assign values for auto-incrementing columns. So the values of auto-incrementing columns are not unique in a Kudu table, but unique in a tablet-server. This patch upgraded Kudu version to 345fd44ca3 to pick up Kudu changes needed for supporting non-unique primary key. It added syntactic support for creating Kudu table with non unique primary key. When creating a Kudu table, specifying PRIMARY KEY is optional. If there is no primary key attribute specified, the partition key columes will be promoted as non unique primary key if those columns are the beginning columns of the table. New column "key_unique" is added to the output of 'describe' table command for Kudu table. Examples of CREATE TABLE statement with non unique primary key: CREATE TABLE tbl (i INT NON UNIQUE PRIMARY KEY, s STRING) PARTITION BY HASH (i) partitions 3 STORED as KUDU; CREATE TABLE tbl (i INT, s STRING, NON UNIQUE PRIMARY KEY(i)) PARTITION BY HASH (i) partitions 3 STORED as KUDU; CREATE TABLE tbl NON UNIQUE PRIMARY KEY(id) PARTITION BY HASH (id) partitions 3 STORED as KUDU AS SELECT id, string_col FROM functional.alltypes WHERE id = 10; SELECT statement does not show the system generated auto-incrementing column unless the column is explicitly specified in the select list. Auto-incrementing column cannot be added, removed or renamed with ALTER TABLE statements. UPSERT operation is not supported now for Kudu tables with auto incrementing column due to limitation in Kudu engine. Testing: - Ran manual test in impala-shell with queries to create tables with non unique primary key, and tested insert/update/delete operations for Kudu tables with non unique primary key. - Added front end tests, and end to end unit tests for Kudu tables with non unique primary key. - Passed exhaustive test. Change-Id: I4d7882bf3d01a3492cc9827c072d1f3200d9eebd --- M bin/impala-config.sh M common/thrift/CatalogObjects.thrift M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/FeDb.java M fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test M testdata/workloads/fun
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9003/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Gerrit-Change-Number: 19452 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 31 Jan 2023 01:28:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Gerrit-Change-Number: 19452 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 31 Jan 2023 01:28:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 ) Change subject: IMPALA-11285: Deflake timeout in test_async_load .. Patch Set 1: Code-Review+2 Looks worth trying. -- To view, visit http://gerrit.cloudera.org:8080/19452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c Gerrit-Change-Number: 19452 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 31 Jan 2023 01:20:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 ) Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12272/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 Gerrit-Change-Number: 19461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 31 Jan 2023 01:06:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11883: Calculate erasure-coded bytes read directly
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19460 to look at the new patch set (#3). Change subject: IMPALA-11883: Calculate erasure-coded bytes read directly .. IMPALA-11883: Calculate erasure-coded bytes read directly Calculate the metric erasure-coded-bytes-read directly from HDFS reads rather than through hdfsFileGetReadStatistics. This allows us to use it for other filesystem implementations (Ozone). Also renumbers is_erasure_coded in THdfsFileSplit to 8, where it was originally before it was removed by IMPALA-9485 (and never replaced). Testing: - ran updated test_io_metrics.py with Ozone, with and without EC - ran updated test_io_metrics.py with HDFS, with and without EC Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c --- M be/src/runtime/io/hdfs-file-reader.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/scan-range.cc M common/thrift/PlanNodes.thrift M tests/query_test/test_io_metrics.py 5 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/19460/3 -- To view, visit http://gerrit.cloudera.org:8080/19460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c Gerrit-Change-Number: 19460 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19461 to look at the new patch set (#2). Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. IMPALA-11859: Add bytes-read-encrypted metric Adds a metric bytes-read-encrypted to track encrypted reads. Testing: - ran test_io_metrics.py with Ozone (encrypts by default) - ran test_io_metrics.py with HDFS (no encryption) Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 --- M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/orc/hdfs-orc-scanner.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/scheduling/scheduler.cc M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/fbs/CatalogObjects.fbs M common/protobuf/planner.proto M common/thrift/PlanNodes.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java D fe/src/main/java/org/apache/impala/compat/HdfsShim.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M tests/query_test/test_io_metrics.py 19 files changed, 79 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/2 -- To view, visit http://gerrit.cloudera.org:8080/19461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 Gerrit-Change-Number: 19461 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. Since IMPALA-11240 the default value of ssl_cipher_list is not empty. Update the docs to cover this change. TESTING: - Built docs locally. Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Reviewed-on: http://gerrit.cloudera.org:8080/19447 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/topics/impala_ssl.xml 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:32:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12270/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I464faedb4e3bbcd417bab2e3cb0d57e339d42605 Gerrit-Change-Number: 19155 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 31 Jan 2023 00:30:27 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12271/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:30:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/380/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:24:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:24:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:13:07 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Revert "IMPALA-11865: Set thread names for Java thread pools" This reverts commit 41117e649049b3490639851c611d9d6a044c64c2. Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Reviewed-on: http://gerrit.cloudera.org:8080/19462 Reviewed-by: Michael Smith Reviewed-by: Joe McDonnell Tested-by: Joe McDonnell --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java 5 files changed, 9 insertions(+), 27 deletions(-) Approvals: Michael Smith: Looks good to me, approved Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:12:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:12:01 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Patch Set 1: We noticed some minor issues in the original patch at https://gerrit.cloudera.org/#/c/19458/. Let's go ahead and revert, then take some time to get it right. -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:11:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java@447 PS2, Line 447: new ThreadFactoryBuilder().setDaemon(true) > Oh, I missed that. Let me revert and we can do it right. I'm going off https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Executors.html#defaultThreadFactory(), which notes "Each new thread is created as a non-daemon thread". -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:11:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Hello Michael Smith, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19462 to review the following change. Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Revert "IMPALA-11865: Set thread names for Java thread pools" This reverts commit 41117e649049b3490639851c611d9d6a044c64c2. Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java 5 files changed, 9 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/19462/1 -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] Revert "IMPALA-11865: Set thread names for Java thread pools"
Joe McDonnell has created a revert of this change. ( http://gerrit.cloudera.org:8080/19462 ) Change subject: Revert "IMPALA-11865: Set thread names for Java thread pools" .. Uploaded patch set 1. -- To view, visit http://gerrit.cloudera.org:8080/19462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: revert Gerrit-Change-Id: Ic84c6ed85b3b2fd06f65453025801cabbe8bc124 Gerrit-Change-Number: 19462 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java@447 PS2, Line 447: new ThreadFactoryBuilder().setDaemon(true) > Marking as daemon threads seems to make sense for this. It does look like i Oh, I missed that. Let me revert and we can do it right. -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Jan 2023 00:10:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/19155/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19155/4//COMMIT_MSG@9 PS4, Line 9: HMS emits an event when a compaction is committed > I see. Thanks for the explanation! Ack http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@441 PS7, Line 441: public static Map getFieldsFromReloadEvent(NotificationEvent event) > Why do we need to change the return type of this? I intend to change the other method return type. My bad!! http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@449 PS7, Line 449: > nit: our code style tend to put the type and var name at the same line. Ack http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@570 PS7, Line 570: This method extracts the partition name field from the :* notification event and returns it in the form > Please update this Ack http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@577 PS7, Line 577: throws MetastoreNotificationException > nit: it seems no exceptions will be thrown It is possible that the new impala client can talk to the old HMS where there is no implementation of getCommitCompactionMessage() or it is possible that the event can message is incorrectly encoded and we can hit an error during decoding. In these cases, it is nice to catch this exception in the form of MetastoreNotificationException. What do you think? http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/19155/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2632 PS7, Line 2632: MetastoreEvent > I think we should extend MetastoreTableEvent so we can reuse its reload met There is no method in CatalogServiceCatalog that would only refresh the file metadata of the table. reloadTableIfExists() method would reload table metadata and file metadata which would be an overhead here. CommitCompaction event would only change the file metadata. So I thought I'll implement a method that does only file metadata reload. Are you ok with this? -- To view, visit http://gerrit.cloudera.org:8080/19155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I464faedb4e3bbcd417bab2e3cb0d57e339d42605 Gerrit-Change-Number: 19155 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala Gerrit-Comment-Date: Tue, 31 Jan 2023 00:09:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11626: Handle COMMIT COMPACTION EVENT from HMS
Hello Quanlong Huang, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19155 to look at the new patch set (#8). Change subject: IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS .. IMPALA-11626: Handle COMMIT_COMPACTION_EVENT from HMS Since HIVE-24329 HMS emits an event when a compaction is committed, but Impala ignores it. Handling it would allow automatic refreshing of file metadata after commit compactions. Change-Id: I464faedb4e3bbcd417bab2e3cb0d57e339d42605 --- M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java 4 files changed, 106 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/19155/8 -- To view, visit http://gerrit.cloudera.org:8080/19155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I464faedb4e3bbcd417bab2e3cb0d57e339d42605 Gerrit-Change-Number: 19155 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sai Hemanth Gantasala
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/19458 )
Change subject: IMPALA-11865: Set thread names for Java thread pools
..
Patch Set 2:
(2 comments)
Noticed a few things after merge.
http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java@394
PS2, Line 394:* running on the {@link #policyReader_} thread.
This comment is out-of-date. I'm curious how it works now.
http://gerrit.cloudera.org:8080/#/c/19458/2/fe/src/main/java/org/apache/impala/service/Frontend.java@447
PS2, Line 447: new ThreadFactoryBuilder().setDaemon(true)
Marking as daemon threads seems to make sense for this. It does look like it's
a change in behavior we'll want to be aware of.
--
To view, visit http://gerrit.cloudera.org:8080/19458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc
Gerrit-Change-Number: 19458
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:05:10 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. IMPALA-11865: Set thread names for Java thread pools Currently, some Java thread pools use the default thread names, which take the form "pool-N-thread-M". This sets the thread names to more human-friendly names by adding a ThreadFactory to Executor thread pools in our Java code. This should make the jstack output easier to understand. For example, "pool-8-thread-1" becomes "TableLoadingSubmitterThread-0". Testing: - Ran jstack locally and verified Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Reviewed-on: http://gerrit.cloudera.org:8080/19458 Reviewed-by: Michael Smith Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java 5 files changed, 27 insertions(+), 9 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 37: Will review when I have a chance this week. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2ba789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 37 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 23:59:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11809: Support non unique primary key for Kudu
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 11: Code-Review+1 (3 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/19383/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19383/11//COMMIT_MSG@45 PS11, Line 45: When creating a Kudu table, specifying PRIMARY KEY is optional. : If there is no primary key attribute specified, the partition key : columes will be promoted as non unique primary key if those columns : are the beginning columns of the table. : New column "key_unique" is added to the output of 'describe' table : command for Kudu table. Suggest to move this para between line 25 and 26. http://gerrit.cloudera.org:8080/#/c/19383/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/19383/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2365 PS10, Line 2365: partition by hash > Added two more test cases as suggested. I see. It may be a good feature to have! http://gerrit.cloudera.org:8080/#/c/19383/10/testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test File testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test: http://gerrit.cloudera.org:8080/#/c/19383/10/testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test@204 PS10, Line 204: order by id > Yes, we can order by auto_incrementing_id. But auto_incrementing_id is not When is it unique? Maybe we can clarify in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/19383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d7882bf3d01a3492cc9827c072d1f3200d9eebd Gerrit-Change-Number: 19383 Gerrit-PatchSet: 11 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 23:58:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11693: Enable allow erasure coded files by default
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19362 ) Change subject: IMPALA-11693: Enable allow_erasure_coded_files by default .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9002/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cfef087f2a7ae0889f47e85c5fab61a795d8fd4 Gerrit-Change-Number: 19362 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 23:58:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 23:58:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 ) Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12269/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 Gerrit-Change-Number: 19461 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Jan 2023 23:55:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9001/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 23:44:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 23: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 23:44:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19461 Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. IMPALA-11859: Add bytes-read-encrypted metric Adds a metric bytes-read-encrypted to track encrypted reads. Testing: - ran test_io_metrics.py with Ozone (encrypts by default) - ran test_io_metrics.py with HDFS (no encryption) Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 --- M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/orc/hdfs-orc-scanner.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/scheduling/scheduler.cc M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/fbs/CatalogObjects.fbs M common/protobuf/planner.proto M common/thrift/PlanNodes.thrift M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java D fe/src/main/java/org/apache/impala/compat/HdfsShim.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M tests/query_test/test_io_metrics.py 19 files changed, 79 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/1 -- To view, visit http://gerrit.cloudera.org:8080/19461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34 Gerrit-Change-Number: 19461 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 ) Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Gerrit-Change-Number: 19455 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 30 Jan 2023 23:11:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19455 ) Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled .. IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled This fixes a script error of unbound variable when running the mini cluster on Ozone with ERASURE_CODING=false. In such case, OZONE_ERASURECODE_POLICY is not set in bin/impala-config.sh. Adds a default empty string when using it. Tests: - Verified CORE tests can run with TARGET_FILESYSTEM=ozone and ERASURE_CODING=false. Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Reviewed-on: http://gerrit.cloudera.org:8080/19455 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/cluster/admin 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Gerrit-Change-Number: 19455 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:32:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml@206 PS2, Line 206: from https://wiki.mozilla.org/Security/Server_Side_TLS. > These seem like they could change over time. Do we have a way to track that Yes it's a moving target. I did think of saying "look in the source code to see the current list" but that's a bit... presumptive? Mostly I wanted to get the docs closer to reality. -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:31:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11883: Calculate erasure-coded bytes read directly
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19460 ) Change subject: IMPALA-11883: Calculate erasure-coded bytes read directly .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12268/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c Gerrit-Change-Number: 19460 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:27:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/695/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:26:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml@206 PS2, Line 206: from https://wiki.mozilla.org/Security/Server_Side_TLS. These seem like they could change over time. Do we have a way to track that? -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:20:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11883: Calculate erasure-coded bytes read directly
Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/19460 )
Change subject: IMPALA-11883: Calculate erasure-coded bytes read directly
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19460/1/be/src/runtime/io/scan-range.cc
File be/src/runtime/io/scan-range.cc:
http://gerrit.cloudera.org:8080/#/c/19460/1/be/src/runtime/io/scan-range.cc@254
PS1, Line 254: if (is_erasure_coded_) {
I wonder if we should do this in HdfsFileReader at
https://github.com/apache/impala/blob/master/be/src/runtime/io/hdfs-file-reader.cc#L236
to avoid counting ReadDataCache. That's closer to where we were doing
hdfsFileGetReadStatistics too.
--
To view, visit http://gerrit.cloudera.org:8080/19460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:19:24 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (2 comments) Thanks for comments http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204 PS1, Line 204: > https://gerrit.cloudera.org/c/19448/2/docs/impala_keydefs.ditamap is also d Thanks http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204 PS1, Line 204: > Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use th Done -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:17:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. Since IMPALA-11240 the default value of ssl_cipher_list is not empty. Update the docs to cover this change. TESTING: - Built docs locally. Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa --- M docs/topics/impala_ssl.xml 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/19447/2 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/695/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 22:17:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11883: Calculate erasure-coded bytes read directly
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19460 Change subject: IMPALA-11883: Calculate erasure-coded bytes read directly .. IMPALA-11883: Calculate erasure-coded bytes read directly Calculate the metric erasure-coded-bytes-read directly from HDFS reads rather than through hdfsFileGetReadStatistics. This allows us to use it for other filesystem implementations (Ozone). Also renumbers is_erasure_coded in THdfsFileSplit to 8, where it was originally before it was removed by IMPALA-9485 (and never replaced). Testing: - ran updated test_io_metrics.py with Ozone, with TODO: and without EC - TODO: ran updated test_io_metrics.py with HDFS, with and without EC Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c --- M be/src/runtime/io/hdfs-file-reader.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/scan-range.cc M common/thrift/PlanNodes.thrift M tests/query_test/test_io_metrics.py 5 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/19460/1 -- To view, visit http://gerrit.cloudera.org:8080/19460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide0fc806590b2328df8068a9a54645d1d1fb137c Gerrit-Change-Number: 19460 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. IMPALA-11867: [DOCS] Document Ozone support Adds a topic documenting Apache Ozone support, and recommends using the ofs protocol. Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Reviewed-on: http://gerrit.cloudera.org:8080/19448 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml A docs/topics/impala_ozone.xml M docs/topics/impala_parquet_file_size.xml M docs/topics/impala_tables.xml 6 files changed, 128 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Gerrit-Change-Number: 19448 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Gerrit-Change-Number: 19448 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 30 Jan 2023 21:50:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/379/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Gerrit-Change-Number: 19448 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 30 Jan 2023 21:42:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Gerrit-Change-Number: 19448 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 30 Jan 2023 21:42:08 + Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11809: Bump Kudu version to 345fd44ca3
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19454 ) Change subject: IMPALA-11809: Bump Kudu version to 345fd44ca3 .. IMPALA-11809: Bump Kudu version to 345fd44ca3 This bumps KUDU_VERSION to the latest upstream Kudu 345fd44ca3 to pick up Kudu changes needed for supporting non-unique primary key. The issue seen in IMPALA-11441 was caused by KUDU-1644. It has been fixed with KUDU-3384 so we can switch back to upstream Kudu repo. Testing: - Passed Impala exhaustive test. Change-Id: Ib0b668982c9d129f5bcb8abd0b4975bbb0fce29e Reviewed-on: http://gerrit.cloudera.org:8080/19454 Reviewed-by: Joe McDonnell Tested-by: Wenzhe Zhou --- M buildall.sh 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Wenzhe Zhou: Verified -- To view, visit http://gerrit.cloudera.org:8080/19454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b668982c9d129f5bcb8abd0b4975bbb0fce29e Gerrit-Change-Number: 19454 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou
[native-toolchain-CR] IMPALA-11809: Bump Kudu version to 345fd44ca3
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19454 ) Change subject: IMPALA-11809: Bump Kudu version to 345fd44ca3 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0b668982c9d129f5bcb8abd0b4975bbb0fce29e Gerrit-Change-Number: 19454 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 21:24:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204 PS1, Line 204: > Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use th https://gerrit.cloudera.org/c/19448/2/docs/impala_keydefs.ditamap is also doing this if you want to copy it. -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 21:21:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. Patch Set 2: Code-Review+2 This makes sense to me, thanks for adding this -- To view, visit http://gerrit.cloudera.org:8080/19448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I724a40c086fe0466646e7e108645fd8dbaee5f1d Gerrit-Change-Number: 19448 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 30 Jan 2023 20:44:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11693: Enable allow erasure coded files by default
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19362 ) Change subject: IMPALA-11693: Enable allow_erasure_coded_files by default .. Patch Set 4: Code-Review+2 This makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/19362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cfef087f2a7ae0889f47e85c5fab61a795d8fd4 Gerrit-Change-Number: 19362 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 20:39:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204 PS1, Line 204: Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use that? -- To view, visit http://gerrit.cloudera.org:8080/19447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa Gerrit-Change-Number: 19447 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 30 Jan 2023 20:37:51 + Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11809: Bump Kudu version to 345fd44ca3
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19454 ) Change subject: IMPALA-11809: Bump Kudu version to 345fd44ca3 .. Patch Set 1: Code-Review+2 This makes sense to me, good to get this updated -- To view, visit http://gerrit.cloudera.org:8080/19454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0b668982c9d129f5bcb8abd0b4975bbb0fce29e Gerrit-Change-Number: 19454 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 30 Jan 2023 20:34:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage
Riza Suminto has posted comments on this change. (
http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage
..
Patch Set 37:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/analysis/Expr.java
File fe/src/main/java/org/apache/impala/analysis/Expr.java:
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/analysis/Expr.java@473
PS37, Line 473: public float evalCost() { return evalCost_; }
This is unused. However, this point me to existing evalCost_ added in
IMPALA-2805.
We should experiment using that evalCost_ weighting vs equal cost of 1 per
expression.
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1025
PS37, Line 1025: childCostChange = adjustNonSharedJoinBuildChildCount();
I'm having a second thought on this join-build recomputation on non-shared join
build (PARTITIONED).
Since it is PARTITIONED, changing instance count of the join fragment will not
change the output cardinality of join-build fragment. Hence, there will be no
change in total processing cost of the exchange node, and recomputation is not
necessary.
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/planner/ProcessingCost.java
File fe/src/main/java/org/apache/impala/planner/ProcessingCost.java:
http://gerrit.cloudera.org:8080/#/c/19033/37/fe/src/main/java/org/apache/impala/planner/ProcessingCost.java@40
PS37, Line 40: public final static long MIN_COST_PER_THREAD = 100L;
This should be a backend flag instead of constant so that tuning is possible.
--
To view, visit http://gerrit.cloudera.org:8080/19033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If32dc770dfffcdd0be2ba789a7720952c68a
Gerrit-Change-Number: 19033
Gerrit-PatchSet: 37
Gerrit-Owner: Qifan Chen
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Kurt Deschler
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Riza Suminto
Gerrit-Reviewer: Wenzhe Zhou
Gerrit-Comment-Date: Mon, 30 Jan 2023 20:25:12 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. Patch Set 4: Code-Review+2 Looks good to me, thank you! -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 19:23:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12267/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 19:09:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50
Hello Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19436 to look at the new patch set (#4). Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. IMPALA-11855: Upgrade jetty to 9.4.50 Upgrades jetty to 9.4.50 due to CVE-2022-2047, CVE-2022-2048. Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 --- M fe/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/19436/4 -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 23: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12266/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 18:51:27 + Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Guard data load for Ozone
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19459 Change subject: [tools] Guard data load for Ozone .. [tools] Guard data load for Ozone Guards data load for Ozone as a usable snapshot is required. Also fixes a typo in fixed issues. Change-Id: Idc37d03780fca35427b977524b2b97a6892c88f7 --- M docs/topics/impala_fixed_issues.xml M testdata/bin/create-load-data.sh 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/19459/1 -- To view, visit http://gerrit.cloudera.org:8080/19459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idc37d03780fca35427b977524b2b97a6892c88f7 Gerrit-Change-Number: 19459 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9000/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 18:44:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 23: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8999/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 18:32:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level
Hello Andrew Sherman, Attila Bukor, Wenzhe Zhou, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19199 to look at the new patch set (#23). Change subject: IMPALA-11856: Use POST requests to set log level .. IMPALA-11856: Use POST requests to set log level Set and reset loglevel handlers now require a POST. Implements Cross-Site Request Forgery (CSRF) prevention in Impala's webserver using the Double Submit Cookie pattern - where POST requests must include a csrf_token field in their post with the random value from the cookie - or a custom header. CSRF attacks rely on the browser always sending a cookie or 'Authorization: Basic' header. - With cookies, attacks don't have access to default form values or the original cookie, so we can include the cookie's random value in the form as a cross-check. As the cookie is cryptographically signed, they also can't be replaced with one that would match an attack's forms. - When not using cookies, a custom header (X-Requested-By) is required as CSRFs are unable to add custom headers. This approach is also used by Jersey; see http://blog.alutam.com/2011/09/14/jersey-and-cross-site-request-forgery-csrf In a broader implementation this would require a separate cookie so it can be used to protect logins as well, but login is handled external to Impala so we re-use the cookie the page already has. Cookies are now generated for the HTPASSWD authentication method. Authenticating via JWT still omits cookies because the JWT is already provided via custom header (preventing CSRF) and disabling authentication (NONE) means anyone could directly send a request so CSRF protection is meaningless. We also start an additional Webserver instance with authentication NONE when metrics_webserver_port > 0, and the Webserver metric "impala.webserver.total-cookie-auth-success" can only be registered once. Additional changes would be necessary to make metric names unique in Webserver (based on port); for the moment we avoid that by ensuring all metrics counters are only instantiated for Webservers that use authentication. Cookie generation and authentication were updated to provide access to the random value. Adds flag to enable SameSite=Strict for defense in depth as mentioned in https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis. This can be enabled if another CSRF attack method is found. Verified that this prevents CSRF attacks by disabling SameSite=Strict and visiting (via https://security.love/CSRF-PoC-Genorator): ``` http://localhost:45000/set_glog_level";> glog http://localhost:45000/set_glog_level";> ``` Adds tests for the webserver with basic authentication, LDAP, and SPNEGO that authorization fails on POST unless - using a cookie and csrf_token is correctly set in the POST body - the X-Requested-By header is set Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 --- M be/src/rpc/authentication-util.cc M be/src/rpc/authentication-util.h M be/src/util/logging-support.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java M fe/src/test/java/org/apache/impala/customcluster/JwtWebserverTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java M fe/src/test/java/org/apache/impala/service/JdbcTest.java A fe/src/test/java/org/apache/impala/testutil/WebClient.java D fe/src/test/java/org/apache/impala/util/Metrics.java M tests/webserver/test_web_pages.py M www/form-hidden-inputs.tmpl M www/log_level.tmpl 19 files changed, 900 insertions(+), 369 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/19199/23 -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Jan 2023 18:26:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. Since IMPALA-10153, time travel queries use the schema of the table from the point specified by the time travel parameters. Update the docs to cover this change. TESTING: - Built docs locally Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Reviewed-on: http://gerrit.cloudera.org:8080/19420 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/topics/impala_iceberg.xml 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I476d98884b5fd192dfcd4feeec7947526aebe993 Gerrit-Change-Number: 19322 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 30 Jan 2023 18:24:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 1: Code-Review+2 That'll be nice for debugging. -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 30 Jan 2023 18:23:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 9: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/19379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ee8b6b7559e6590698b46ef1d574e55ed52f9a Gerrit-Change-Number: 19379 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Xiaoqing Gao Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Jan 2023 18:22:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.48
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.48 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19436/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/19436/3/fe/pom.xml@537 PS3, Line 537: 9.4.48.v20220622 > Any reason not to go with the latest version? I don't know of one. I'll give it a try. -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 18:20:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/378/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Jan 2023 18:16:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Jan 2023 18:16:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19458 ) Change subject: IMPALA-11865: Set thread names for Java thread pools .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12265/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 30 Jan 2023 18:11:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3120: Support Bucket Shuffle Join for bucketed table
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/19430 )
Change subject: IMPALA-3120: Support Bucket Shuffle Join for bucketed table
..
Patch Set 9:
(14 comments)
Thanks for working on this optimization, looks great!
I haven't processed the whole patch yet, I have mainly high level comments.
http://gerrit.cloudera.org:8080/#/c/19430/9//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19430/9//COMMIT_MSG@9
PS9, Line 9: and have operations
Besides the bucket operations do we also apply predicates to buckets? For
example if a table is bucketed by id, id=2 can be filter down to only one
bucket (or id in (2,3) can filter to 2 buckets).
http://gerrit.cloudera.org:8080/#/c/19430/9//COMMIT_MSG@10
PS9, Line 10: such as join, group by, sort by, etc.
Can you add more info about these optimizations?
- for sort, bucketing is only applied in case it is in a partitioned analytic
function, right?
- is bucketing supported in case there are multiple bucketing columns?
- is bucketing supported if there are multiple keys columns in a join / group,
and only a subset of it is bucketed?
http://gerrit.cloudera.org:8080/#/c/19430/9//COMMIT_MSG@11
PS9, Line 11: optimize
Can you add some info about the tradeoffs? My understanding is that while
bucketing reduces data transfer, it can have two side-effects:
- can decrease parallelism as each bucket will be processed by a single node +
thread
- can lead to remote reads as split->node assignment happens based on bucket
instead of locality
http://gerrit.cloudera.org:8080/#/c/19430/9//COMMIT_MSG@13
PS9, Line 13:
Can you add some info about the effect on scheduling?
My understanding is the we try to schedule each bucket to a separate executor -
is there some sort of affinity for this (e.g. assign to executor with most
local blocks on HDFS), or it is done randomly?
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java:
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@324
PS9, Line 324:* TODO: take bucketing into account to produce a naturally
hash-partitioned
:* fragment
Todo can be removed
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@510
PS9, Line 510: broadcast join or a repartitioning join
Can you mention buckating join?
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@521
PS9, Line 521: and the children are placed in the same fragment to prevent
shuffle.
Is this always the optimal solution?
My understanding is that bucketing can lead to remote reads on HDFS, so if one
of the scan nodes are very selective then shuffling after evaluating the
predicate leads to less network traffic than remote reads of the whole files.
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@984
PS9, Line 984: // If the node is a bucketed node, put the node and its
children in the same fragment
: // to prevent shuffle
: if (node.isBucketedNode()) {
: childFragment.addPlanRoot(node);
: return childFragment;
: }
I think that this should be handled in createMergeAggregationFragment - isn't
this a similar optimizaton to childHasCompatPartition at line 1024?
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2539
PS9, Line 2539: kudu hash
Isn't it Hive hash?
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/PlanNode.java
File fe/src/main/java/org/apache/impala/planner/PlanNode.java:
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1203
PS9, Line 1203: int numExecutors =
ExecutorMembershipSnapshot.getCluster().numExecutors();
I think that this can lead to incorrectly disabling bucketing, as numExecutors
can be much more than the number of executors the this node will use in the end
(without bucketing). E.g. if there are 100 nodes in the cluster and a table
with 4 buckets with 1 file in each bucket, the maximum parallelism will be
reduced to 4, while bucketing can still potentially make things faster.
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/SortNode.java
File fe/src/main/java/org/apache/impala/planner/SortNode.java:
http://gerrit.cloudera.org:8080/#/c/19430/9/fe/src/main/java/org/apache/impala/planner/SortNode
[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 ) Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Gerrit-Change-Number: 19455 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 30 Jan 2023 17:59:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 ) Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8998/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Gerrit-Change-Number: 19455 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 30 Jan 2023 17:59:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 ) Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled .. Patch Set 1: Code-Review+2 Oops, thanks for fixing that! -- To view, visit http://gerrit.cloudera.org:8080/19455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173 Gerrit-Change-Number: 19455 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 30 Jan 2023 17:57:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba0b604733c14b697d268b9ea2067a829c0e351 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Gergely Fürnstáhl Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Noemi Pap-Takacs Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 30 Jan 2023 17:55:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11865: Set thread names for Java thread pools
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19458 Change subject: IMPALA-11865: Set thread names for Java thread pools .. IMPALA-11865: Set thread names for Java thread pools Currently, some Java thread pools use the default thread names, which take the form "pool-N-thread-M". This sets the thread names to more human-friendly names by adding a ThreadFactory to Executor thread pools in our Java code. This should make the jstack output easier to understand. For example, "pool-8-thread-1" becomes "TableLoadingSubmitterThread-0". Testing: - Ran jstack locally and verified Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java 5 files changed, 27 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/19458/1 -- To view, visit http://gerrit.cloudera.org:8080/19458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I583093eeb2e92a208ee5ea5a023686e36436c4dc Gerrit-Change-Number: 19458 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-11629: Support for huawei OBS FileSystem
Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/19110 )
Change subject: IMPALA-11629: Support for huawei OBS FileSystem
..
Patch Set 9:
(3 comments)
> Patch Set 9:
>
> > Uploaded patch set 9.
>
> Hi all, Patch#9 add OBS related configurations to core-site.xml to reduce
> manual work, and export 'WAREHOUSE_LOCATION_PREFIX' env variable.
>
> I figured out that when the 'fs.defaultFS' in core-site.xml set to
> 'obs://...', the table's location will defaulted to 'obs://...' but
> 'hdfs://localhost:20500', then some failed cases in Patch#8 will be passed,
> thus the '$NAMENODE' variable I mentioned doesn't need to change, see
> https://github.com/apache/impala/blob/4.2.0/tests/util/hdfs_util.py#L55 .
>
> Another challenge I face is some EE tests rely on hbase, but hbase table
> store data on hdfs currently, so I need to start the hdfs cluster. But
> namenode will fail to start when 'fs.defaultFS' set to 'obs://...'. So I need
> to initialize 'fs.defaultFS' to 'hdfs://localhost:20500' and start hdfs
> cluster, then change it to 'obs://...' to start hive and impala cluster.
> It'll then cause some EE tests failed because of unique_database or table
> location defaults to 'hdfs://localhost:20500/...' for unknown reason. So I
> export 'WAREHOUSE_LOCATION_PREFIX' env variable so the
> 'hive.metastore.warehouse.dir' and 'hive.metastore.warehouse.external.dir' in
> hive-site.xml fixed with explicit filesystem schema, or I have to research
> how to modify hbase table's location to point to obs filesystem.
Tests that use hbase should be skipped via
https://github.com/apache/impala/blob/master/tests/common/skip.py#L78, and
hbase shouldn't be started -
https://github.com/apache/impala/blob/master/testdata/bin/run-all.sh#L62 -
unless DEFAULT_FS == 'hdfs://localhost:20500'.
http://gerrit.cloudera.org:8080/#/c/19110/9/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/19110/9/bin/impala-config.sh@710
PS9, Line 710: WAREHOUSE_LOCATION_PREFIX=${DEFAULT_FS}
This shouldn't need to be set. It's only used if your warehouse is not
"obs://${OBS_BUCKET}/test-warehouse".
http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:
http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py@1214
PS9, Line 1214: if IS_HDFS:
This should be IS_HDFS or IS_OZONE now. Probably should have updated the
comment.
http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py@1242
PS9, Line 1242: if IS_HDFS:
Same as above.
--
To view, visit http://gerrit.cloudera.org:8080/19110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1
Gerrit-Change-Number: 19110
Gerrit-PatchSet: 9
Gerrit-Owner: Xiang Yang
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Smith
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Xiang Yang
Gerrit-Reviewer: Yida Wu
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:47:51 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12264/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I476d98884b5fd192dfcd4feeec7947526aebe993 Gerrit-Change-Number: 19322 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Mon, 30 Jan 2023 17:45:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 37: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12263/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2ba789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 37 Gerrit-Owner: Qifan Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 30 Jan 2023 17:42:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.48
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.48 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19436/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/19436/3/fe/pom.xml@537 PS3, Line 537: 9.4.48.v20220622 Any reason not to go with the latest version? https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.50.v20221201 -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 17:34:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.48
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.48 .. Patch Set 3: Verified+1 Carry verified through commit message update and rebase. -- To view, visit http://gerrit.cloudera.org:8080/19436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc6d3ad40b63986137ea1b5c71b9af61bd9e637 Gerrit-Change-Number: 19436 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 30 Jan 2023 17:28:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18958 ) Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458 Gerrit-Change-Number: 18958 Gerrit-PatchSet: 8 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Baike Xia Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Xiang Yang Gerrit-Comment-Date: Mon, 30 Jan 2023 17:25:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18958 ) Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone .. IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone For /etc/sysconfig/clock, when a row has a '#', we can skip that row, and optimize the content of parsing lines. This will fix the parsing problem caused by the '# Zone="utc"'. Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458 Reviewed-on: http://gerrit.cloudera.org:8080/18958 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exprs/timezone_db.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458 Gerrit-Change-Number: 18958 Gerrit-PatchSet: 9 Gerrit-Owner: Baike Xia Gerrit-Reviewer: Baike Xia Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jian Zhang Gerrit-Reviewer: Xiang Yang
