[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Reviewed-on: http://gerrit.cloudera.org:8080/19394 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/authorization/test_ranger.py 1 file changed, 239 insertions(+), 242 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 16 Jan 2023 09:36:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 16 Jan 2023 04:22:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8965/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 16 Jan 2023 04:22:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: Thanks for the +2 Qifan! Does anyone else still have any comment on the patch? Thanks very much for the help! -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 16 Jan 2023 03:05:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: Code-Review+2 Looks good! -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 15 Jan 2023 18:00:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19394/9/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/19394/9/tests/authorization/test_ranger.py@1337
PS9, Line 1337: err = ("AuthorizationException: User '{0}' does not have
privileges to execute"
: + " 'SELECT' on: {1}.foo").format(test_user,
test_db)
I revised this to get rid of the warning of "line break after binary operator."
--
To view, visit http://gerrit.cloudera.org:8080/19394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28
Gerrit-Change-Number: 19394
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Fri, 06 Jan 2023 23:36:32 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12124/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 06 Jan 2023 23:29:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests
..
Patch Set 9:
(1 comment)
> Patch Set 7:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py@329
PS7, Line 329: admin_client, "grant create on user_defined_fn {0}.{1}
to {2} {3}"
> The idention looks lengthy. Can we use the second idention style mentioned
Thanks Quanlong!
I have changed the indentation to make the code less lengthy in patch set 9.
--
To view, visit http://gerrit.cloudera.org:8080/19394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28
Gerrit-Change-Number: 19394
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Fri, 06 Jan 2023 23:25:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: (44 comments) I have fixed all the indentation problems pointed out by impala-flake8 in patch set 9. http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@330 PS8, Line 330: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@332 PS8, Line 332: > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@333 PS8, Line 333: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@338 PS8, Line 338: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@341 PS8, Line 341: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@342 PS8, Line 342: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@347 PS8, Line 347: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@350 PS8, Line 350: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@351 PS8, Line 351: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@352 PS8, Line 352: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@357 PS8, Line 357: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@360 PS8, Line 360: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@384 PS8, Line 384: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@407 PS8, Line 407: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@410 PS8, Line 410: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@430 PS8, Line 430: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@437 PS8, Line 437: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@439 PS8, Line 439: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@440 PS8, Line 440: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@445 PS8, Line 445: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@451 PS8, Line 451: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@454 PS8, Line 454: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@460 PS8, Line 460: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@468 PS8, Line 468: m > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@470 PS8, Line 470: [ > flake8: E122 continuation line missing indentation or outdented Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@480 PS8, Line 480: > flake8: E241 multiple spaces after ',' Done http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@481 PS8, Line 481: m > flake8: E131 continuation line
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12123/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 06 Jan 2023 23:13:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#9). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 --- M tests/authorization/test_ranger.py 1 file changed, 239 insertions(+), 242 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/19394/9 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 8: (44 comments) http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@330 PS8, Line 330: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@332 PS8, Line 332: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@333 PS8, Line 333: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@338 PS8, Line 338: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@341 PS8, Line 341: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@342 PS8, Line 342: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@347 PS8, Line 347: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@350 PS8, Line 350: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@351 PS8, Line 351: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@352 PS8, Line 352: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@357 PS8, Line 357: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@360 PS8, Line 360: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@384 PS8, Line 384: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@407 PS8, Line 407: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@410 PS8, Line 410: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@430 PS8, Line 430: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@437 PS8, Line 437: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@439 PS8, Line 439: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@440 PS8, Line 440: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@445 PS8, Line 445: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@451 PS8, Line 451: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@454 PS8, Line 454: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@460 PS8, Line 460: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@468 PS8, Line 468: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@470 PS8, Line 470: [ flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@480 PS8, Line 480: flake8: E241 multiple spaces after ',' http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@481 PS8, Line 481: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/19394/8/tests/authorization/test_ranger.py@484 PS8, Line 484: [ flake8: E122 continuation line missing indentation or outdented
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#8). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 --- M tests/authorization/test_ranger.py 1 file changed, 237 insertions(+), 240 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/19394/8 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py@329
PS7, Line 329: "grant create on
user_defined_fn {0}.{1} "
The idention looks lengthy. Can we use the second idention style mentioned here?
https://peps.python.org/pep-0008/#indentation
self._update_privileges_and_verify(
admin_client, "grant create on user_defined_fn {0}.{1} to {2} {3}"...
--
To view, visit http://gerrit.cloudera.org:8080/19394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28
Gerrit-Change-Number: 19394
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Qifan Chen
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Thu, 05 Jan 2023 04:36:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12086/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 03 Jan 2023 21:26:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 7: (1 comment) Thanks for the review Qifan! Let me know if anyone still has any suggestion. Thanks! http://gerrit.cloudera.org:8080/#/c/19394/6/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/6/tests/authorization/test_ranger.py@1248 PS6, Line 1248: 'test_ > nit 'test_user' Done -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 03 Jan 2023 21:05:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#7). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 --- M tests/authorization/test_ranger.py 1 file changed, 317 insertions(+), 240 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/19394/7 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: Code-Review+2 (1 comment) Thanks for the improvement! http://gerrit.cloudera.org:8080/#/c/19394/6/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/6/tests/authorization/test_ranger.py@1248 PS6, Line 1248: a user nit 'test_user' -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 03 Jan 2023 19:38:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: Hi all, please let me know if there is any comment on this patch. This patch does not contain any functionality change. It was prepared according to Qifan's suggestions in the following. 1. https://gerrit.cloudera.org/c/19194/15//COMMIT_MSG#7. I added a new test case at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#1254 to include the scenario where UDF is called in an INSERT statement. 2. https://gerrit.cloudera.org/c/19194/15/tests/authorization/test_ranger.py#482. The code comment has been revised at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#528. 3. https://gerrit.cloudera.org/c/19194/15/tests/authorization/test_ranger.py#526. I refactored the code by wrapping the pattern in the function _update_privileges_and_verify() at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#192. This pattern is used throughout test_ranger.py. I only refactored the code added in IMPALA-10986 and not very sure whether I should also refactor the functions not touched in IMPALA-10986. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Qifan Chen Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 03 Jan 2023 17:23:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 06:31:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12081/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 01:58:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12080/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 01:47:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py@530 PS5, Line 530: > flake8: E501 line too long (93 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py@549 PS5, Line 549: > flake8: E501 line too long (93 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 01:37:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#6). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 --- M tests/authorization/test_ranger.py 1 file changed, 317 insertions(+), 240 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/19394/6 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19394 Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests This patch adds an additional test case in test_select_function to verify Impala's behavior when a user tries to execute a UDF in an INSERT statement. Moreover, some test functions added in IMPALA-10986 are refactored according to reviewers' suggestion. Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 --- M tests/authorization/test_ranger.py 1 file changed, 317 insertions(+), 240 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/19394/5 -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8936/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 01:28:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py@530 PS5, Line 530: 2 flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19394/5/tests/authorization/test_ranger.py@549 PS5, Line 549: 2 flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Jan 2023 01:28:46 + Gerrit-HasComments: Yes
