[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-19 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/15560/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:52:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-19 Thread Riza Suminto (Code Review) 
Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 4:

(5 comments)

Looks good. Just few style nits to edit.

http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised
   :   ERROR: Invalid value for query option NUM_NODES: 
 is not in range [0, 1]
nit: Use short title and separate the title with the rest of commit message 
with an empty line. I recommend to change it like this:

IMPALA-11938: Raise error if NUM_NODES is set to invalid value.

If NUM_NODES is set to a value other than 0 or 1 below error is raised:
ERROR: Invalid value for query option NUM_NODES:  is not in range [0, 1]


http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc
File be/src/service/query-options-test.cc:

http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@273
PS4, Line 273: {
nit: align the open curly brace with the one in L266


http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@274
PS4, Line 274:   };
nit: keep this L274 the same as the original.


http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option, value, 0, 1, _t_val));
> line has trailing whitespace
nit: Please remove the trailing whitespace.


http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option
nit: add 4 spaces indentation before 'option'.



--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:45:15 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-19 Thread Anonymous Coward (Code Review) 
j_ansh...@yahoo.in has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..

IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is 
raised
  ERROR: Invalid value for query option NUM_NODES:  is not 
in range [0, 1]

Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/4
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-19 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option, value, 0, 1, _t_val));
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:29:28 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raisedERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/15509/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:26:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Riza Suminto (Code Review) 
Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raisedERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 2:

Thank you for fixing this.
Please also add test in QueryOptions.SetIntOptions. Adding the following line 
in case_set should do it.

{MAKE_OPTIONDEF(num_nodes),{0, 1}},

https://github.com/apache/impala/blob/691604b1d1f0e5f0dc95fdb4976cf826135e08fb/be/src/service/query-options-test.cc#L247-L248


--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Riza Suminto 
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:19:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Anonymous Coward (Code Review) 
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/21147

to look at the new patch set (#2).

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raisedERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..

IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is 
raised

ERROR: Invalid value for query option NUM_NODES:  is not in range [0, 1]

Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/2
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Anonymous Coward (Code Review) 
j_ansh...@yahoo.in has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21147


Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..

IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is 
raised
  ERROR: Invalid value for query option NUM_NODES:  is not 
in range [0, 1]

Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options.cc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/1
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward

[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]

2024-03-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21147 )

Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 
below error is raised   ERROR: Invalid value for query option 
NUM_NODES:  is not in range [0, 1]
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21147/1/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/21147/1/be/src/service/query-options.cc@246
PS1, Line 246: option, value, 0, 1, _t_val));
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:04:33 +
Gerrit-HasComments: Yes