[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - '-mm-dd hh:mm:ss.ms' Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. - Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Reviewed-on: http://gerrit.cloudera.org:8080/21015 Tested-by: Impala Public Jenkins Reviewed-by: Wenzhe Zhou --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 454 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Wenzhe Zhou: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 17 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Sat, 02 Mar 2024 17:15:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Sat, 02 Mar 2024 06:17:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10344/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Sat, 02 Mar 2024 01:37:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 16: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10343/ -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Sat, 02 Mar 2024 00:51:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15379/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 15 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 20:29:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15377/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 14 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 20:10:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10343/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 20:09:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 15: Updated the planner test and rebased with latest master. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 15 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 20:04:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#15). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - '-mm-dd hh:mm:ss.ms' Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. - Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 454 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/15 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 15 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 14: Please rebase your code to pick up latest changes -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 14 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 19:55:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#14). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - '-mm-dd hh:mm:ss.ms' Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. - Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 454 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/14 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 14 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 13: There were two test failures in GVO, one is irrelevant, PlannerTest.testDataSourceTables need to be fixed. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 01:52:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has removed a vote on this change. Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Removed Code-Review+2 by Wenzhe Zhou -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 13: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10331/ -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 01 Mar 2024 01:19:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 29 Feb 2024 20:42:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10331/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 29 Feb 2024 20:40:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 12 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 19:54:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 12: Commit message updated. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 12 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 16:16:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#12). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - '-mm-dd hh:mm:ss.ms' Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. - Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 460 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/12 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 12 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15329/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 00:31:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 00:30:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG@10 PS11, Line 10: The timestamp is of the ISO 8601 format(SQL standard): : '-mm-dd hh:mm:ss.ms'. It returns the timestamp as : string to the remote database. The description could be improved. Maybe, something like following: "Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - '-mm-dd hh:mm:ss.ms'" http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG@19 PS11, Line 19: - Added coverage for timestamp with/without milliseconds in timestamp. Also, include: "Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs" -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 00:19:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#11). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 460 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/11 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 10: Extended planner test to include cast() and to_timestamp() functions. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Tue, 27 Feb 2024 00:04:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#10). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 460 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/10 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15323/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 9 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 20:31:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#9). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 446 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/9 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 9 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15319/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 8 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 17:47:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 8: Rebased from latest master. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 8 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 17:23:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#8). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 461 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/8 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 8 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 7: please rebase and solve the merge conflicts. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 7 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 17:10:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15317/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 7 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 17:00:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 6: Added planner test for both date and timestamp SCAN predicates. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Mon, 26 Feb 2024 16:35:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#7). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 5 files changed, 446 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/7 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 7 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 6: We should update the planner test to show which all SCAN predicates are getting pushed down to remote Data Source: https://github.com/apache/impala/blob/master/testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Fri, 23 Feb 2024 21:25:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 6: Code-Review+1 Looks good to me. I can give +2 if Abhishek does not have additional comments. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 22 Feb 2024 21:51:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15279/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 22 Feb 2024 17:49:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@16 PS5, Line 16: postgre > nit: Postgres Done http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@17 PS5, Line 17: remote > nit: remote impala Done http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@19 PS5, Line 19: timestam > nit: timestamp Done http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@33 PS5, Line 33: import org.apache.impala.analysis.Expr; > nit: keep alphabet order Thanks. Moved it to above the TupleDescriptor. http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@275 PS5, Line 275: between > it's better to use count(*) for 'between', like select count(*) from alltyp Done. Thanks. Changed it for mysql and postgres as well. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 22 Feb 2024 17:25:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#6). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql and remote impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timestamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 4 files changed, 432 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/6 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@16 PS5, Line 16: impala, nit: Postgres http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@17 PS5, Line 17: impala nit: remote impala http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@19 PS5, Line 19: timetamp nit: timestamp http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@33 PS5, Line 33: import org.apache.impala.analysis.TimestampLiteral; nit: keep alphabet order http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@275 PS5, Line 275: between it's better to use count(*) for 'between', like select count(*) from alltypes_jdbc_datasource where timestamp_col between '2009-01-03 00:12:00' and '2009-01-05 00:12:00'. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 5 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 22 Feb 2024 06:44:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15266/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 5 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Wed, 21 Feb 2024 18:05:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: * Literals will finally be converted to string for pushdown. > It's probably okay to use string representation here as all Literals will a Thanks. Updated comment. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 5 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Wed, 21 Feb 2024 17:40:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#5). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for impala, mysql and impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timetamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 4 files changed, 450 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/5 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 5 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( > Most databases should accept multiple timestamp formats. ISO 8601 should be It's probably okay to use string representation here as all Literals will anyways be converted to string for pushdown. But, it will be good to add a comment here explaining why we're using the string representation and not binary representation for TimeStamp. As for what format to use as default, it's probably okay to use the '-mm-dd hh:mm:ss.ms'. But, I think we will find more as we do more tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 15 Feb 2024 20:47:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( > The timestamp format used by most databases is ISO 8601. Most databases should accept multiple timestamp formats. ISO 8601 should be an acceptable format for most (if not the default one). -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 15 Feb 2024 16:08:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( > timestamp_val is defined as 16 byte binary array. When calling setTimestamp The timestamp format used by most databases is ISO 8601. >From the postgres documentation: The output format of the date/time types can >be set to one of the four styles ISO 8601, SQL (Ingres), traditional POSTGRES >(Unix date format), or German. The default is the ISO format. ISO ISO 8601, SQL standard 1997-12-17 07:37:16-08 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 15 Feb 2024 15:48:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( > We should probably just call the setTimestamp_val() and not set the string timestamp_val is defined as 16 byte binary array. When calling setTimestamp_val(), we should call getValue, e.g. return new TColumnValue().setTimestamp_val( ((TimestampLiteral) expr).getValue()); In jdbc function QueryConditionUtil.getTColumnValueAsString(), we need to convert byte array to string. The byte array structure is defined in backend code be/src/runtime/timestamp-value.h, including 8 bytes for the nanoseconds within the current day and 4 -bytes for the date as a day. We can use nanoseconds and date to create a java.sql.Timestamp object, then use SimpleDateFormat to generate timestamp string. When using setString_val, we don't need to convert Timestamp value to string. This assume the external SQL databases have exact same string format for timestamp as Impala. Can we make such assumption? -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Thu, 15 Feb 2024 13:31:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15238/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Wed, 14 Feb 2024 22:04:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@148 PS4, Line 148: return new TColumnValue().setString_val( We should probably just call the setTimestamp_val() and not set the string val? -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Wed, 14 Feb 2024 21:52:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 ) Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12815: Support timestamp for scan predicates > Much cleaner to create a separate JIRA for timestamp support Created a separate jira: IMPALA-12815 http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@10 PS2, Line 10: The timestamp is of the ISO 8601 format(SQL standard): > We should be more specific here, we're only talking about SCAN predicates h Done. Updated the commit message about timestamp format ISO 8601 (sql standard) http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@14 PS2, Line 14: Testing: > Would be good to be more specific about what kind of tests: e2e, unit, cust specified custom cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh Gerrit-Comment-Date: Wed, 14 Feb 2024 21:40:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12815: Support timestamp for scan predicates for external data source table.
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21015 to look at the new patch set (#4). Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. .. IMPALA-12815: Support timestamp for scan predicates for external data source table. The timestamp is of the ISO 8601 format(SQL standard): '-mm-dd hh:mm:ss.ms'. It returns the timestamp as string to the remote database. Testing: - Added custom cluster tests for timestamp predicates with operators: '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for impala, mysql and impala. - Added coverage for timestamp with/without time in the timestamp - Added coverage for timetamp with/without milliseconds in timestamp. Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 --- M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test 4 files changed, 448 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/21015/4 -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: gaurav singh