[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. IMPALA-8426: Logging error in DROP_TABLE event processing Fixing the bug in condition check while logging in DROP_TABLE event processing. Also updating EVENTS_SKIPPED metric to keep track of the number of drop table events skipped when CREATION_TIME matches. Testing: - Added metric check to unit test. - Ran existing unit tests. Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Reviewed-on: http://gerrit.cloudera.org:8080/13056 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 14 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 18 Apr 2019 01:20:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2825/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 20:39:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4038/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 20:18:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Bharath Krishna has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. IMPALA-8426: Logging error in DROP_TABLE event processing Fixing the bug in condition check while logging in DROP_TABLE event processing. Also updating EVENTS_SKIPPED metric to keep track of the number of drop table events skipped when CREATION_TIME matches. Testing: - Added metric check to unit test. - Ran existing unit tests. Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/13056/2 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Krishna Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724 PS1, Line 724: assertEquals(1, : eventsProcessor_.getMetrics() : .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount() : - numFilteredEvents); > nit: assertEquals(numFilteredevents +1 , ..getCount() ? +1 to above suggestion. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 19:03:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 19:03:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724 PS1, Line 724: assertEquals(1, : eventsProcessor_.getMetrics() : .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount() : - numFilteredEvents); nit: assertEquals(numFilteredevents +1 , ..getCount() ? I think that is more readable. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 19:00:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2823/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 17 Apr 2019 17:15:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing
Bharath Krishna has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13056 Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. IMPALA-8426: Logging error in DROP_TABLE event processing Fixing the bug in condition check while logging in DROP_TABLE event processing. Also updating EVENTS_SKIPPED metric to keep track of the number of drop table events skipped when CREATION_TIME matches. Testing: - Added metric check to unit test. - Ran existing unit tests. Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 2 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/13056/1 -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vihang Karajgaonkar
