[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has abandoned this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 10
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-8795 : Enable event polling by default in tests
Should be "in dockerized tests" - this makes it sound like it's enabled for all 
tests, which is not true.


http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@13
PS1, Line 13: Testing done [WIP]:
Can update this now?


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py@a43
PS1, Line 43:
It doesn't really make sense to remove thse execute_serially markers for custom 
cluster tests, since they always have to execute serially anyway


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py@45
PS1, Line 45: isHiveInsert
should be is_hive_insert



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 21:15:52 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Sep 2019 08:23:41 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4602/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Sep 2019 04:52:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4976/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 20 Sep 2019 04:12:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 1:

Continuing Vihang's work here: https://gerrit.cloudera.org/#/c/13922/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Comment-Date: Fri, 20 Sep 2019 04:11:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14272


Change subject: IMPALA-8795 : Enable event polling by default in tests
..

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done [WIP]:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 170 insertions(+), 173 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/1
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 9:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4971/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Fri, 20 Sep 2019 02:34:49 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-09-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4971/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 19 Sep 2019 22:27:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4868/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 28 Aug 2019 23:15:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4868/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 28 Aug 2019 18:20:20 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 9:

LMK when I should take another look at this, it's been through quite a bit of 
churn


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 28 Aug 2019 00:38:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4816/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sat, 17 Aug 2019 11:01:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 8:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4296/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sat, 17 Aug 2019 07:28:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4816/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sat, 17 Aug 2019 06:51:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 8:

(25 comments)

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@332
PS8, Line 332: w
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@341
PS8, Line 341: ,
flake8: E501 line too long (117 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@350
PS8, Line 350: i
flake8: F821 undefined name 'impala_url'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@384
PS8, Line 384: r
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971: l
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971: """Confirm the database with 'db_name' is present in the 
impalad's local catalog.
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@43
PS8, Line 43: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@63
PS8, Line 63: R
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@77
PS8, Line 77: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@86
PS8, Line 86: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@91
PS8, Line 91: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py
File tests/custom_cluster/test_hive_parquet_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py@91
PS8, Line 91: E
flake8: F821 undefined name 'EventProcessorUtils'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:   
EventProcessorUtils.wait_for_event_processing(self.hive_client)
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@136
PS8, Line 136: "
flake8: E126 continuation line over-indented for hanging indent



--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: 

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-17 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#8). ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done [WIP]:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 155 insertions(+), 167 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/8
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4756/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 08 Aug 2019 02:14:17 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 7:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4179/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:47:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 7:

(24 comments)

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@332
PS7, Line 332: w
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@341
PS7, Line 341: ,
flake8: E501 line too long (117 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@350
PS7, Line 350: i
flake8: F821 undefined name 'impala_url'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@384
PS7, Line 384: r
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971
PS7, Line 971: l
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971
PS7, Line 971: """Confirm the database with 'db_name' is present in the 
impalad's local catalog.
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py
File tests/custom_cluster/test_hive_parquet_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py@91
PS7, Line 91: E
flake8: F821 undefined name 'EventProcessorUtils'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66
PS7, Line 66:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66
PS7, Line 66:   
EventProcessorUtils.wait_for_event_processing(self.hive_client)
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@22
PS7, Line 22: import logging
flake8: F401 'logging' imported but unused


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@28
PS7, Line 28: class EventProcessorUtils(object):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@31
PS7, Line 31: @
flake8: E301 expected 1 blank line, found 0


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@47
PS7, Line 47: T
flake8: F821 undefined name 'TimeoutError'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@49
PS7, Line 49: .
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53
PS7, Line 53:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53
PS7, Line 53:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54
PS7, Line 54:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54
PS7, Line 54:   @staticmethod
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62
PS7, Line 62:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62
PS7, Line 62:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66
PS7, Line 66:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66
PS7, Line 66:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69
PS7, Line 69:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69
PS7, Line 69:  
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:07:12 +
Gerrit-HasComments: 

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4756/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:06:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-07 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done [WIP]:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
A tests/util/event_processor_utils.py
8 files changed, 157 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/7
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4742/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 07 Aug 2019 00:31:26 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4742/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 06 Aug 2019 19:39:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change.

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Removed Verified-1 by Impala Public Jenkins 
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4: Code-Review+2

Looks like this just hit the issues we had with start-impala-cluster. Not sure 
if this is superseded by the other change, but this still looks OK


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 06 Aug 2019 06:33:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4700/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 31 Jul 2019 07:38:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4700/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 31 Jul 2019 06:02:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4677/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 29 Jul 2019 10:28:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4677/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 29 Jul 2019 03:51:03 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4056/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sun, 28 Jul 2019 22:39:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/metadata/test_hms_integration.py
3 files changed, 16 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/4
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4668/


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 27 Jul 2019 06:25:09 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4668/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 27 Jul 2019 00:02:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 27 Jul 2019 00:02:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 26 Jul 2019 23:54:45 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4036/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 26 Jul 2019 21:53:08 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-07-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
..

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/2
--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins