[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Use 'wget http://169.254.169.254/' to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance 'dmidecode -s bios-version' prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the 'grep' assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Reviewed-on: http://gerrit.cloudera.org:8080/12727 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M bin/bootstrap_system.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 7 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 6 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 25 Mar 2019 21:01:21 + Gerrit-HasComments: No
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2531/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 6 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 25 Mar 2019 17:19:10 + Gerrit-HasComments: No
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3951/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 6 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 25 Mar 2019 16:43:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 6: Code-Review+2 Thanks for this! -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 6 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 25 Mar 2019 16:41:03 + Gerrit-HasComments: No
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Hello Lars Volker, Laszlo Gaal, Jim Apple, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#6). Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Use 'wget http://169.254.169.254/' to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance 'dmidecode -s bios-version' prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the 'grep' assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 --- M bin/bootstrap_system.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/6 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 6 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 5: (2 comments) I'm ready to +2 this. Just one more round of nitpicking. http://gerrit.cloudera.org:8080/#/c/12727/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/5//COMMIT_MSG@12 PS5, Line 12: `dmidecode -s bios-version` Nit: one more to switch to normal quotes http://gerrit.cloudera.org:8080/#/c/12727/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/5/bin/bootstrap_system.sh@239 PS5, Line 239: # EC2 nodes expose this IP address internally as a way to gather instance metadata. : # The assumption is that only AWS nodes do this Nit: Can we keep the original comment? i.e. # If on EC2, use Amazon's ntp servers # EC2 nodes expose this IP address internally as a way to gather instance metadata. # The assumption is that only AWS nodes do this -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 5 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2019 21:37:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG@7 PS4, Line 7: `wget http://169.254.169.254/` > Please excuse the drive-by comment. Can we change the quotes to normale quo Done -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2019 19:39:56 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws
Hello Lars Volker, Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#5). Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Use 'wget http://169.254.169.254/' to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance `dmidecode -s bios-version` prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the 'grep' assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 --- M bin/bootstrap_system.sh 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/5 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 5 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG@7 PS4, Line 7: `wget http://169.254.169.254/` Please excuse the drive-by comment. Can we change the quotes to normale quotes to make sure that we don't break tooling that might somehow echo and interpret the commit message? If you decide to go with it, please change below, too. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2019 18:00:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 21 Mar 2019 20:31:45 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Hello Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#4). Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Use `wget http://169.254.169.254/` to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance `dmidecode -s bios-version` prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the `grep` assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 --- M bin/bootstrap_system.sh 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/4 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/3/bin/bootstrap_system.sh@239 PS3, Line 239: # The following wget command determines if we're running in aws I'd suggest something like "EC2 nodes expose this IP address internally as a way to gather instance metadata. The assumption is that only AWS nodes do this". -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 21 Mar 2019 18:55:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 21 Mar 2019 16:18:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2489/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Wed, 20 Mar 2019 21:04:21 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Hello Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#3). Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Use `wget http://169.254.169.254/` to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance `dmidecode -s bios-version` prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the `grep` assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/3 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: Code-Review+1 (1 comment) The check looks OK; see my suggestion about adding more explanation to where wget is called. http://gerrit.cloudera.org:8080/#/c/12727/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/2/bin/bootstrap_system.sh@239 PS2, Line 239: If on EC2, use Amazon's ntp servers I'd suggest expanding the comment text here with a brief description about the URL and the purpose of the connection (verifying that the instance is running on EC2). Since this script is one of the first things a new Impala contributor encounters, they might get suspicious when they see it trying to connect to an unusual URL containing a numerical IP address -- not everyone is familiar with Amazon's metadata services. Repeating what's in the commit message is probably OK, it's just that the comment here stays associated with the wget line it describes. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 18 Mar 2019 19:37:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG@9 PS2, Line 9: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html > That says "check the instance identity document, including its signature". IIUC wget is not doing that. In order to verify the instance metadata returned by http://169.254.169.254/ we'd need to perform the steps outlined here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-identity-documents.html Verifying metadata signatures here seems like an overkill to me. This patch makes the assumption that if http://169.254.169.254/ is reachable then it's reasonable to assume that we're in an ec2 instance. we're just using /latest/dynamic/instance-identity/ as a documented url endpoint. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 18 Mar 2019 04:30:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 16 Mar 2019 01:04:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG@9 PS2, Line 9: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html That says "check the instance identity document, including its signature". Does this patch do that? I don't see it, but maybe wget does that? -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 15 Mar 2019 23:40:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2442/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 15 Mar 2019 20:56:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3915/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 15 Mar 2019 20:49:55 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Use `wget http://169.254.169.254/` to determine if we're running in aws https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html lists the above endpoint as the first choice. In my running instance `dmidecode -s bios-version` prints out: 1.0 dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative here. I removed the `grep` assertions since it's possible that images may have already configured ntp here. Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 --- M bin/bootstrap_system.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/2 -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal
