[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 2:

I see this is already submitted, but:

> Do you know how I can only run 1 of the 2 (e.g. just codegen enabled) for 
> this particular test fn?

To be safe, I think the mark for serial is still a good idea, since the test 
truly needs to be serial.

A quick method would simply be to inspect something in the vector and 
pytest.skip(), or separating out the Kudu DDL stuff separately into a separate 
class that only uses 1 dimension. There's no great, perfect solution available 
to us at this time though.

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


IMPALA-4567: Fix test_kudu_alter_table exhaustive failures

The issue is that we set the Kudu table name explicitly via
tblproperty so it doesn't have the unique db name in the
underlying Kudu name. Meanwhile, the tests are run
concurrently in exhaustive so this test may end up running
the multiple times (w/ different parameters, e.g.
disable_codegen) concurrently.  This test needs to be run
serially.

Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Reviewed-on: http://gerrit.cloudera.org:8080/5312
Reviewed-by: David Knupp 
Reviewed-by: Dimitris Tsirogiannis 
Tested-by: Internal Jenkins
---
M tests/query_test/test_kudu.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  David Knupp: Looks good to me, but someone else must approve
  Internal Jenkins: Verified
  Dimitris Tsirogiannis: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 1:

> I used this command to see the test simply runs the .test file with
 > codegen enabled and disabled.
 > 
 > impala-py.test --collect-only --workload_exploration_strategy
 > functional-query:exhaustive -k test_kudu_alter query_test/test_kudu.py
 > 
 > Are both query options needed for these tests?

 > I used this command to see the test simply runs the .test file with
 > codegen enabled and disabled.
 > 
 > impala-py.test --collect-only --workload_exploration_strategy
 > functional-query:exhaustive -k test_kudu_alter query_test/test_kudu.py
 > 
 > Are both query options needed for these tests?

Yeah that's a good question. I was thinking about only running w/ codegen 
enabled since it probably doesn't really matter for this test. However, I  
thought if the matrix grows in the future it could be an issue again. I'd be OK 
with limiting it & adding a comment, though.

Do you know how I can only run 1 of the 2 (e.g. just codegen enabled) for this 
particular test fn? I could always split it into a separate class and change 
the filters.

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 1:

I used this command to see the test simply runs the .test file with codegen 
enabled and disabled.

impala-py.test --collect-only --workload_exploration_strategy 
functional-query:exhaustive -k test_kudu_alter query_test/test_kudu.py

Are both query options needed for these tests?

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Dimitris Tsirogiannis (Code Review)]

Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: David Knupp 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

[Matthew Jacobs (Code Review)]

Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5312

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
..

IMPALA-4567: Fix test_kudu_alter_table exhaustive failures

The issue is that we set the Kudu table name explicitly via
tblproperty so it doesn't have the unique db name in the
underlying Kudu name. Meanwhile, the tests are run
concurrently in exhaustive so this test may end up running
the multiple times (w/ different parameters, e.g.
disable_codegen) concurrently.  This test needs to be run
serially.

Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
---
M tests/query_test/test_kudu.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/5312/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs