[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

[Zach Amsden (Code Review)]

Zach Amsden has posted comments on this change.

Change subject: IMPALA-5748 Record query handle for invalid handle
..


Patch Set 2:

Henry, I don't think it matters at all in this case, but I did want to figure 
out how to use the unit test and benchmark code.  The boost syntax is pretty 
ugly.

-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-5748 Record query handle for invalid handle
..


Patch Set 2:

(2 comments)

Do you think the perf difference is worth considering replacing Substitute()? I 
don't think that Substitute() appears (or should) on perf critical paths, and I 
gotta say I'm not in love with karma's syntax.

http://gerrit.cloudera.org:8080/#/c/5748/2//COMMIT_MSG
Commit Message:

PS2, Line 7: 5748
I think this is the wrong jira (plus, nitpicking, add a : after the number for 
consistency).


http://gerrit.cloudera.org:8080/#/c/5748/2/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

Line 38: #include 
We really try not to expand our boost footprint if at all possible.


-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

[Zach Amsden (Code Review)]

Zach Amsden has posted comments on this change.

Change subject: IMPALA-5748 Record query handle for invalid handle
..


Patch Set 1:

So I wrote a little benchmark.  As expected, karma blew away all the other 
forms of string concatenation.  Will come up with a nicer syntax for this but 
likely it will need to be a macro.

impala@impala-dev:~/Impala$ ./be/build/debug/util/debug-util-test
[==] Running 5 tests from 1 test case.
[--] Global test environment set-up.
[--] 5 tests from DebugUtil
[ RUN  ] DebugUtil.UniqueID
[   OK ] DebugUtil.UniqueID (0 ms)
[ RUN  ] DebugUtil.ErrMsgBenchmark
Rate Append: 1750.86
Rate Subst: 934.806
Rate Gen: 379.784
[   OK ] DebugUtil.ErrMsgBenchmark (165 ms)
[ RUN  ] DebugUtil.StackDump

-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

[Zach Amsden (Code Review)]

Zach Amsden has uploaded a new patch set (#2).

Change subject: IMPALA-5748 Record query handle for invalid handle
..

IMPALA-5748 Record query handle for invalid handle

Add the query handle to error messages for Invalid Query Handle
for beeswax and HS2 interfaces.

Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
---
M be/src/service/impala-beeswax-server.cc
M be/src/util/debug-util-test.cc
M tests/comparison/leopard/report.py
3 files changed, 80 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/5748/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Zach Amsden