Zach Amsden has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle ......................................................................
Patch Set 1: So I wrote a little benchmark. As expected, karma blew away all the other forms of string concatenation. Will come up with a nicer syntax for this but likely it will need to be a macro. impala@impala-dev:~/Impala$ ./be/build/debug/util/debug-util-test [==========] Running 5 tests from 1 test case. [----------] Global test environment set-up. [----------] 5 tests from DebugUtil [ RUN ] DebugUtil.UniqueID [ OK ] DebugUtil.UniqueID (0 ms) [ RUN ] DebugUtil.ErrMsgBenchmark Rate Append: 1750.86 Rate Subst: 934.806 Rate Gen: 379.784 [ OK ] DebugUtil.ErrMsgBenchmark (165 ms) [ RUN ] DebugUtil.StackDump -- To view, visit http://gerrit.cloudera.org:8080/5748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: No
