Henry Robinson has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle ......................................................................
Patch Set 2: (2 comments) Do you think the perf difference is worth considering replacing Substitute()? I don't think that Substitute() appears (or should) on perf critical paths, and I gotta say I'm not in love with karma's syntax. http://gerrit.cloudera.org:8080/#/c/5748/2//COMMIT_MSG Commit Message: PS2, Line 7: 5748 I think this is the wrong jira (plus, nitpicking, add a : after the number for consistency). http://gerrit.cloudera.org:8080/#/c/5748/2/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 38: #include <boost/spirit/include/karma.hpp> We really try not to expand our boost footprint if at all possible. -- To view, visit http://gerrit.cloudera.org:8080/5748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
