[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: C++ client: deprecating KuduPartialRow::SetString()
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2757/

-- 
To view, visit http://gerrit.cloudera.org:8080/3723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-08 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change.

Change subject: C++ client: deprecating KuduPartialRow::SetString()
..


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3723/3//COMMIT_MSG
Commit Message:

Line 21: An alternative approach might be to change behavior of
> That would break ABI compatibility and it doesn't seem to be really necessa
OK, for the other approach a created a separate changeset: 
http://gerrit.cloudera.org:8080/3868


http://gerrit.cloudera.org:8080/#/c/3723/3/src/kudu/common/partial_row.cc
File src/kudu/common/partial_row.cc:

Line 289: Status KuduPartialRow::SetBinaryNoCopy(const Slice& col_name, const 
Slice& val) {
> style note: If you change the order in the header file please also change t
Done


http://gerrit.cloudera.org:8080/#/c/3723/3/src/kudu/common/partial_row.h
File src/kudu/common/partial_row.h:

Line 98:   // Set the string/binary value but does not copy the value. The slice
> style nit: It makes more sense to me to keep all the string methods togethe
Good point!  However, the point here is to emphasize the groups of different 
behavior.


Line 109: ATTRIBUTE_DEPRECATED(
> style nit: Line continuations should be 4 spaces, not 2. See https://google
Done


Line 110:   "use SetStringNoCopy() instead; also consider using 
SetStringCopy()");
> style: Another line continuation, add an additional 4 spaces more than the 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..


Patch Set 3: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2753/

-- 
To view, visit http://gerrit.cloudera.org:8080/3738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: client/sample.cc: fixed a couple of crashes
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2752/

-- 
To view, visit http://gerrit.cloudera.org:8080/3685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5fa3b812e6402a113bf5e432a3a451dc4cc3735
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-08-08 Thread Alexey Serbin (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3685

to look at the new patch set (#3).

Change subject: client/sample.cc: fixed a couple of crashes
..

client/sample.cc: fixed a couple of crashes

Fixed 'pure virtual method called' error with subsequent SIGABRT
termination due to attempt to access destroyed log callback object
while logging some messages from terminating reactor threads.

Fixed issue with an attempt to access non-existing element
of pending errors array with subsequent SIGSEGV termination.

Change-Id: Ic5fa3b812e6402a113bf5e432a3a451dc4cc3735
---
M src/kudu/client/samples/sample.cc
1 file changed, 43 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/3685/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5fa3b812e6402a113bf5e432a3a451dc4cc3735
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: C++ client: deprecating KuduPartialRow::SetString()
..


Patch Set 3:

Can we try to close this one out for 0.10? Seems like it's basically ready and 
a good API improvement.

-- 
To view, visit http://gerrit.cloudera.org:8080/3723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I348b0b9437b8d7928e3b607a0e0610d8d0c58f7c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] WIP: Adding some missing 0.10.0 release notes

2016-08-08 Thread Todd Lipcon (Code Review) 
Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3802

to look at the new patch set (#2).

Change subject: WIP: Adding some missing 0.10.0 release notes
..

WIP: Adding some missing 0.10.0 release notes

This isn't complete and is missing some information, but it should
give us a head start. Several TODOs need to be addressed before
this is complete.

Change-Id: Ibdc9fd57b05434874845ffa9c0ff905b5b8d0422
---
M docs/release_notes.adoc
1 file changed, 116 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/3802/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdc9fd57b05434874845ffa9c0ff905b5b8d0422
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] WIP: Adding some missing 0.10.0 release notes

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: WIP: Adding some missing 0.10.0 release notes
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2751/

-- 
To view, visit http://gerrit.cloudera.org:8080/3802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc9fd57b05434874845ffa9c0ff905b5b8d0422
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [C++ client] doxygenized all C++ client API
..


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/callbacks.h
File src/kudu/client/callbacks.h:

Line 60:   /// @param [in] line_number
> Done
You missed the change from "is" to "was".


http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/client/callbacks.h
File src/kudu/client/callbacks.h:

Line 46:   KuduLoggingCallback() {
Why do we need this?


http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/util/slice.h
File src/kudu/util/slice.h:

Line 137:   /// @note The data isn't actually modified, just the base/bounds of 
the slice.
Nit: restyled a bit: "Only the base and bounds of the slice are changed; the 
data is not modified." Below too.


http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/util/status.h
File src/kudu/util/status.h:

Line 30: #define KUDU_RETURN_NOT_OK(s) do { \
> These macros are user-facing; should we doxygenate their comments too?
I think you missed this comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f82a6c8a500a892bc1daff8444e91191dab3af
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..


Patch Set 3: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2750/

-- 
To view, visit http://gerrit.cloudera.org:8080/3738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [java client] Support add/remove partition

2016-08-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: [java client] Support add/remove partition
..


Patch Set 1:

(18 comments)

http://gerrit.cloudera.org:8080/#/c/3854/1/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java:

Line 19: import com.google.common.base.Preconditions;
This doesn't make Guava part of the API itself, right? This will be our shaded 
Guava?


Line 37:   AlterTableRequestPB.Builder pb = AlterTableRequestPB.newBuilder();
Hmm, can we make this private?


Line 118:* Multiple range partitions may be added as part of a single alter 
table transaction by calling
Nit: I get that this is copied from the C++ client, but we should probably 
replace "transaction" with "operation" (below too). We don't want users to 
think that once the AlterTable is done, a "transaction" has been committed 
across the cluster.


http://gerrit.cloudera.org:8080/#/c/3854/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

PS1, Line 360:   tableLocations.clear();
 :   tablet2client.clear();
What's the intuition behind clearing these two but not client2tablet?


PS1, Line 697:   // Sending both as an errback and returning fromError 
because sendRpcToTablet might be
 :   // called via a callback that won't care about the 
returned Deferred.
There's no danger of a code path that would "double count" the error by virtue 
of installing an errback() AND considering the return value, is there?


PS1, Line 1343: // Doing a get first instead of putIfAbsent to avoid 
creating unnecessary CSLMs because in
  : // the most common case the table should already be present
This comment needs to be updated.


Line 1366: tablets.add(currentTablet);
Why this change? Doesn't it contradict this block's comment?


PS1, Line 1380:   // This is making this tablet available
  :   // Even if two clients were racing in this method they 
are putting the same RemoteTablet
  :   // with the same start key in the CSLM in the end
Needs to be updated. To be honest, all the comments in this method could stand 
to be refined a bit.


PS1, Line 1395:   /**
  :* Gives the tablet's ID for the table ID and partition key.
  :* In the future there will be multiple tablets and this 
method will find the right one.
  :* @param tableId table to find the tablet for
  :* @return a tablet ID as a slice or null if not found
  :*/
Update this.


http://gerrit.cloudera.org:8080/#/c/3854/1/java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java:

Line 77:long ttl) {
As written, each new entry is likely to have a slightly different deadline, 
which is a bit odd: they were created en masse here, so shouldn't they expire 
en masse too?

To fix, you could make just one call to System.nanoTime(), compute the 
deadline, and passing it into each new entry.


PS1, Line 99: 
AsyncKuduClient.EMPTY_ARRAY,
: ttl));
Nit: indentation.


Line 170: overlappingEntries = 
overlappingEntries.headMap(discoveredUpperBound, false);
If we're executing this line, why bother executing L167-168?


Line 200: private final long deadline;
Maybe we can track these via DeadlineTrackers?


Line 246:   return deadline - System.nanoTime();
Should we prevent this value from becoming negative (i.e. return zero if the 
deadline expires)?


http://gerrit.cloudera.org:8080/#/c/3854/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java:

Line 1: package org.apache.kudu.client;
Missing copyright statement.


PS1, Line 32: and range partitioned
:* on c0 with no range bounds.
That's not true if I pass something into 'bounds', right?


http://gerrit.cloudera.org:8080/#/c/3854/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java:

Line 282: String tableName = name.getMethodName();
Note that we need to add system time to these table names, because if the test 
fails and is retried, I don't believe the cluster state is cleaned out in 
between, so there'd be a table name collision.


http://gerrit.cloudera.org:8080/#/c/3854/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 1347: return Status::InvalidArgument("No tablet

[kudu-CR] Adding some missing 0.10.0 release notes

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: Adding some missing 0.10.0 release notes
..


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/3802/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 71: - link:http://gerrit.cloudera.org:8080/3737[Gerrit #3737] The Java 
client was repackaged
> s/was packaged/has been repackaged
Done


Line 76: - link:https://gerrit.cloudera.org/#/c/3055/[Gerrit #3055] Changed the 
Java client's
> The Java client's synchronous API methods now throw `KuduException` instead
Done


Line 93:   write operations. It is disabled by default, and requires setting 
`--enable_exactly_once` on the
> To enable 'exactly-once' semantics, set the `--enable_exactly_once` configu
I actually removed this because it sounds like it will only be included as 
experimental given amount of stuff we have to get done this week


Line 101: - link:https://issues.apache.org/jira/browse/KUDU-1516[KUDU-1516] 
Added improvements to the
> The `kudu-ksck` tool has been improved and now detects problems such as whe
Done


Line 107: - link:https://gerrit.cloudera.org:8080/3477[Gerrit #3477] Reworked 
how operations are buffered in
> The way operations are buffered in the client has been reworked. Previously
Done


Line 113: - link:https://gerrit.cloudera.org/#/c/3674/[Gerrit #3674] Added add 
LESS and GREATER options for
> s/add//
Done


Line 122:   The effect was that the RPC would not be sent, and users of the 
synchronous API would get
> s/get/receive
Done


Line 127:   a tablet server or master. This would exhibit itself the same way 
Gerrit #3541 did.
> This would manifest in the same way as Gerrit #3541.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc9fd57b05434874845ffa9c0ff905b5b8d0422
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Upgrade to NVML 1.1

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged.

Change subject: Upgrade to NVML 1.1
..


Upgrade to NVML 1.1

Change-Id: I9b28130407b4ec30bc13a9acfc2390cee7a69de4
Reviewed-on: http://gerrit.cloudera.org:8080/3866
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b28130407b4ec30bc13a9acfc2390cee7a69de4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Persistent cache support for NVM

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Persistent cache support for NVM
..


Patch Set 18: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2747/

-- 
To view, visit http://gerrit.cloudera.org:8080/2593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sarah Jelinek 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sarah Jelinek 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Persistent cache support for NVM

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Persistent cache support for NVM
..


Patch Set 18:

Build Started http://104.196.14.100/job/kudu-gerrit/2745/

-- 
To view, visit http://gerrit.cloudera.org:8080/2593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sarah Jelinek 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sarah Jelinek 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Add weekly update for 8/8
..


Patch Set 2: Code-Review+2

Glad I noticed the more important error.

-- 
To view, visit http://gerrit.cloudera.org:8080/3864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has uploaded a new patch set (#2).

Change subject: Add weekly update for 8/8
..

Add weekly update for 8/8

Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
---
A _posts/2016-08-08-weekly-update.md
1 file changed, 63 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/3864/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Add weekly update for 8/8
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3864/1/_posts/2016-08-08-weekly-update.md
File _posts/2016-08-08-weekly-update.md:

Line 14:  [adding add/remove range partition 
support](https://gerrit.cloudera.org/#/c/3648/)
Nit: looks like this should be indented by another space?


-- 
To view, visit http://gerrit.cloudera.org:8080/3864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add weekly update for 8/8

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3864

Change subject: Add weekly update for 8/8
..

Add weekly update for 8/8

Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
---
A _posts/2016-08-08-weekly-update.md
1 file changed, 63 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/3864/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd1dcb28082b476c18a92a91f6f84af4c69df66b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-08 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: Add table id to AlterTableResponsePB
..


Patch Set 1:

I'm using it in the rust client.  There are a couple of cases where the field 
could be used in the C++ and Java clients:

  * When waiting for the table alteration to finish, the table ID can be set 
instead of the table name in IsAlterTableDoneRequestPB which closes a race 
between concurrent renames.
* The table ID can be used to scope the clearing of the meta cache to just the 
altered table.

I actually tried to implement both of these in the C++ client along with this 
patch, but they aren't exactly trivial changes.  Partially clearing the 
meta-cache breaks some invariants between the internal cache maps, and there 
isn't currently a way to use table IDs instead of table names when doing RPCs 
(especially in the client-internal layer).

-- 
To view, visit http://gerrit.cloudera.org:8080/3859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63402581fbdaef2abdf37910c1dfaedbdcba76e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] catalog manager: cleanup status messages

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: catalog manager: cleanup status messages
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: Add table id to AlterTableResponsePB
..


Patch Set 1:

you don't want to use this new field in the client? seems strange to add it 
with no use case

-- 
To view, visit http://gerrit.cloudera.org:8080/3859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63402581fbdaef2abdf37910c1dfaedbdcba76e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen

2016-08-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: [CMakeLists.txt] dot is mandatory for doxygen
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3466a587f98a528d9aa57edd4f4e96684b6922a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/2738/

-- 
To view, visit http://gerrit.cloudera.org:8080/3668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No