[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-22 Thread Maxim Smyatkin (Code Review) 
Maxim Smyatkin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4800

Change subject: KUDU-78. Fix pb_util functions which return bool to return 
Status
..

KUDU-78. Fix pb_util functions which return bool to return Status

As suggested in ticket, I've refactored four pb_util functions to return Status 
instead of bool.
Only one of them can actually fail, for now: ParseFromSequentialFile. It can 
fail in two wais:
either with IO error or with Protobuf error (Status::Corruption). To track 
which one, I had to add
GetStatus() method into SequentialFileFileInputStream.

Also there were few misprints in master/sys_catalog.cc error messages 
("table"/"tablet"),
and a small bug in consensus/log.cc with wrong string::Substitute format ($1 
instead of $0).

Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/util/pb_util-internal.h
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
9 files changed, 48 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/4800/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin

[kudu-CR] [util/crypto] first certificate management (part 1)

2016-10-22 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4799

Change subject: [util/crypto] first certificate management (part 1)
..

[util/crypto] first certificate management (part 1)

Added utility classes to generate certificate signing requests
(X509 CSRs) and certify/sign those.  Using OpenSSL crypto library
as the crypto engine.

This is to provide support for the next phase where tablet servers issue
certificate signing requests (CSRs) and the master server, acting as
a certificate authority (CA), processes and certifies/signs those,
returning back corresponding X509 certs.  The generated certs will
be used to establish SSL/TLS connections.

Change-Id: I69c1da97e6d013a034aefda59988b593ae1d6304
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/crypto/cert_management-test.cc
A src/kudu/util/crypto/cert_management.cc
A src/kudu/util/crypto/cert_management.h
A src/kudu/util/crypto/crypto_engine.cc
A src/kudu/util/crypto/crypto_engine.h
6 files changed, 981 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/4799/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69c1da97e6d013a034aefda59988b593ae1d6304
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-22 Thread Anonymous Coward (Code Review) 
g.kocu...@gmail.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4797

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
..

KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

Added DICT_ENCODING to the Python API.
Extended test_schema to include all encodings.

Change-Id: I81917b201707dea0296e82a4edd4492231303ec4
---
M python/kudu/__init__.py
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_schema.py
4 files changed, 13 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/4797/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81917b201707dea0296e82a4edd4492231303ec4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocu...@gmail.com

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-22 Thread Jordan Birdsell (Code Review) 
Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
..


Patch Set 1:

(1 comment)

Thanks for the patch Greg! Can you also add dictionary encoding?  Make sure to 
also include a test for this, take a look at test_schema.py:test_encoding.

http://gerrit.cloudera.org:8080/#/c/4796/1//COMMIT_MSG
Commit Message:

PS1, Line 9: is an internally used encoding which was removed for the C++ api.
I would say its no longer supported and as such being removed from the Python 
API.


-- 
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocu...@gmail.com
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1691 - [python] Enable bitshuffle and dictionary encoding

2016-10-22 Thread Jordan Birdsell (Code Review) 
Jordan Birdsell has abandoned this change.

Change subject: KUDU-1691 - [python] Enable bitshuffle and dictionary encoding
..


Abandoned

Patch being worked on by @Greg

-- 
To view, visit http://gerrit.cloudera.org:8080/4780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic722579493da1bca422c643898d6312f272ee398
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-22 Thread Anonymous Coward (Code Review) 
g.kocu...@gmail.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4796

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
..

KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

GROUP_VARINT is an internally used encoding which was removed for the C++ api.
BIT_SHUFFLE encoding was enabled in the python api.

Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
---
M python/kudu/__init__.py
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
3 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/4796/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocu...@gmail.com