Maxim Smyatkin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4800
Change subject: KUDU-78. Fix pb_util functions which return bool to return
Status
......................................................................
KUDU-78. Fix pb_util functions which return bool to return Status
As suggested in ticket, I've refactored four pb_util functions to return Status
instead of bool.
Only one of them can actually fail, for now: ParseFromSequentialFile. It can
fail in two wais:
either with IO error or with Protobuf error (Status::Corruption). To track
which one, I had to add
GetStatus() method into SequentialFileFileInputStream.
Also there were few misprints in master/sys_catalog.cc error messages
("table"/"tablet"),
and a small bug in consensus/log.cc with wrong string::Substitute format ($1
instead of $0).
Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/util/pb_util-internal.h
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
9 files changed, 48 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/4800/1
--
To view, visit http://gerrit.cloudera.org:8080/4800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <[email protected]>
