[kudu-CR] Add previous / current thread to collision warner

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9237 )

Change subject: Add previous / current thread to collision warner
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h
File src/kudu/gutil/threading/thread_collision_warner.h:

http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h@132
PS1, Line 132: // The class ThreadCollisionWarner uses an Asserter to notify 
the collision
 : // AsserterBase is the interfaces and DCheckAsserter is the 
default asserter
 : // used. During the unit tests is used another class that 
doesn't "DCHECK"
 : // in case of collision (check 
thread_collision_warner_unittests.cc)
nit: it's not the part of your change, but maybe consider updating this 
description because it's hard to read.



--
To view, visit http://gerrit.cloudera.org:8080/9237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7
Gerrit-Change-Number: 9237
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 05:43:47 +
Gerrit-HasComments: Yes

[kudu-CR] Add previous / current thread to collision warner

[Mike Percy (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/9237

to review the following change.


Change subject: Add previous / current thread to collision warner
..

Add previous / current thread to collision warner

The failure message is now more useful and looks like the following:

F0206 20:31:24.554322 30972 thread_collision_warner.cc:23] Thread Collision! 
Previous thread id: 30962, current thread id: 30972

I found this necessary when debugging a particular issue since by the
time the SIGABRT triggered in GDB the previous thread had already exited
the critical section (perhaps while printing the fatal log message).

Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7
---
M src/kudu/gutil/threading/thread_collision_warner.cc
M src/kudu/gutil/threading/thread_collision_warner.h
2 files changed, 15 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9237/1
--
To view, visit http://gerrit.cloudera.org:8080/9237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7
Gerrit-Change-Number: 9237
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Fix crash when log dir is not specified

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9233 )

Change subject: Fix crash when log_dir is not specified
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725a7da038913ff05227c6dc34167138148b
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 07 Feb 2018 03:36:14 +
Gerrit-HasComments: No

[kudu-CR] Fix crash when log dir is not specified

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9233 )

Change subject: Fix crash when log_dir is not specified
..

Fix crash when log_dir is not specified

This fixes the tpch1 benchmark after the recent enabling of metrics
logging. The crash was due to FLAGS_log_dir being unset. In typical
servers, we rely on InitGoogleLoggingSafe to default log_dir to /tmp,
but our tpch1 benchmark embeds a client, and a constructor function in
the client calls InitGoogleLoggingSafeBasic which doesn't do this
defaulting. So, we ended up starting the minicluster with an empty log
dir.

This patch just makes it not start the metrics logger if no log dir is
set.

Change-Id: I725a7da038913ff05227c6dc34167138148b
Reviewed-on: http://gerrit.cloudera.org:8080/9233
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
---
M src/kudu/server/server_base.cc
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified
  Mike Percy: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I725a7da038913ff05227c6dc34167138148b
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [docs] MacPorts specific build instructions

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9236


Change subject: [docs] MacPorts specific build instructions
..

[docs] MacPorts specific build instructions

Added instructions to build Kudu on macOS using MacPorts.

Change-Id: Ic103c1d883cd94c5e21b291e81005e14324a813f
---
M docs/installation.adoc
1 file changed, 54 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/9236/1
--
To view, visit http://gerrit.cloudera.org:8080/9236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic103c1d883cd94c5e21b291e81005e14324a813f
Gerrit-Change-Number: 9236
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] docs: improvements to transaction semantics

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9235 )

Change subject: docs: improvements to transaction semantics
..


Patch Set 1: Code-Review+1

Which version of Kudu does this apply?


--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:46:20 +
Gerrit-HasComments: No

[kudu-CR] docs: improvements to transaction semantics

[Hao Hao (Code Review)]

Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9235


Change subject: docs: improvements to transaction semantics
..

docs: improvements to transaction semantics

Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
---
M docs/transaction_semantics.adoc
1 file changed, 16 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9235/1
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 

[kudu-CR] docs: Update release management documentation

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8744 )

Change subject: docs: Update release management documentation
..


Patch Set 3:

Updated render: https://github.com/mpercy/kudu/blob/releasing-1b/RELEASING.adoc


--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:33:21 +
Gerrit-HasComments: No

[kudu-CR] docs: Update release management documentation

[Mike Percy (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8744

to look at the new patch set (#3).

Change subject: docs: Update release management documentation
..

docs: Update release management documentation

Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
---
M RELEASING.adoc
1 file changed, 74 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/8744/3
--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] docs: Update release management documentation

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8744 )

Change subject: docs: Update release management documentation
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8744/2/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/8744/2/RELEASING.adoc@42
PS2, Line 42: 1.6.x
> perhaps '1.x.y' here and below?
Done



--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:31:55 +
Gerrit-HasComments: Yes

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:15:00 +
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..

Update instructions for publishing changes to the live site

Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Reviewed-on: http://gerrit.cloudera.org:8080/8059
Reviewed-by: Dan Burkert 
Tested-by: Mike Percy 
---
M README.adoc
1 file changed, 26 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Mike Percy: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Mike Percy has removed a vote on this change.

Change subject: Update instructions for publishing changes to the live site
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] docs: improvements to NTP troubleshooting

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9234 )

Change subject: docs: improvements to NTP troubleshooting
..


Patch Set 1:

This will probably conflict with Mahdi's in-flight change. I'll take care of 
merging after review


--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:08:38 +
Gerrit-HasComments: No

[kudu-CR] docs: improvements to NTP troubleshooting

[Todd Lipcon (Code Review)]

Hello Alex Rodoni, Jean-Daniel Cryans,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/9234

to review the following change.


Change subject: docs: improvements to NTP troubleshooting
..

docs: improvements to NTP troubleshooting

Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
---
M docs/troubleshooting.adoc
1 file changed, 143 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/9234/1
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jean-Daniel Cryans 

[kudu-CR] Update instructions for publishing changes to the live site

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..


Patch Set 2: Code-Review+2

OK SGTM


--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:37:33 +
Gerrit-HasComments: No

[kudu-CR] Add log parser script

[Mike Percy (Code Review)]

Hello David Ribeiro Alves, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8229

to look at the new patch set (#3).

Change subject: Add log parser script
..

Add log parser script

This script collates and filters logs from a cluster, printing messages
indicating latency issues and RaftConsensus election activity. It's a
work-in-progress but I found it useful for an investigation I was doing
(it highlighted some problems I hadn't noticed).

It's pretty simple and basically consists of a bunch of regexes it runs
on the logs. It's also a little slow and could be optimized, as it
currently does an in-memory sort (by timestamp) of any included log
entries right before it prints the relevant log lines to stdout.

Change-Id: I3bd8bb5d9a3c598ade7bc1bbc8f5a9e24ca618af
---
A src/kudu/scripts/kudu-log-parser.pl
1 file changed, 399 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/8229/3
--
To view, visit http://gerrit.cloudera.org:8080/8229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bd8bb5d9a3c598ade7bc1bbc8f5a9e24ca618af
Gerrit-Change-Number: 8229
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] docs: Update release management documentation

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8744 )

Change subject: docs: Update release management documentation
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8744/2/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/8744/2/RELEASING.adoc@42
PS2, Line 42: 1.6.x
perhaps '1.x.y' here and below?



--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:37:19 +
Gerrit-HasComments: Yes

[kudu-CR] Add log parser script

[Mike Percy (Code Review)]

Hello David Ribeiro Alves, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8229

to look at the new patch set (#2).

Change subject: Add log parser script
..

Add log parser script

This script collates and filters logs from a cluster, printing messages
indicating latency issues and RaftConsensus election activity. It's a
work-in-progress but I found it useful for an investigation I was doing
(it highlighted some problems I hadn't noticed).

It's pretty simple and basically consists of a bunch of regexes it runs
on the logs. It's also a little slow and could be optimized, as it
currently does an in-memory sort (by timestamp) of any included log
entries right before it prints the relevant log lines to stdout.

Change-Id: I3bd8bb5d9a3c598ade7bc1bbc8f5a9e24ca618af
---
A src/kudu/scripts/kudu-log-parser.pl
1 file changed, 399 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/8229/2
--
To view, visit http://gerrit.cloudera.org:8080/8229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bd8bb5d9a3c598ade7bc1bbc8f5a9e24ca618af
Gerrit-Change-Number: 8229
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..


Patch Set 2:

> what do you think about moving the entire section out of README.md to 
> RELEASING.md?  It may fit better there

That document basically assumes we are doing a full release, while updating the 
docs can be done out-of-cycle, so it doesn't really seem to mesh that well to 
me.


--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:30:26 +
Gerrit-HasComments: No

[kudu-CR] docs: Update release management documentation

[Mike Percy (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8744

to look at the new patch set (#2).

Change subject: docs: Update release management documentation
..

docs: Update release management documentation

Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
---
M RELEASING.adoc
1 file changed, 67 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/8744/2
--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: Update release management documentation

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8744 )

Change subject: docs: Update release management documentation
..


Patch Set 2:

Rendered version: 
https://github.com/mpercy/kudu/blob/releasing-1a/RELEASING.adoc


--
To view, visit http://gerrit.cloudera.org:8080/8744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43575df56bb36e49a06feffe6efac96a52347c24
Gerrit-Change-Number: 8744
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:27:48 +
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..


Patch Set 2:

Text looks good to me, but what do you think about moving the entire section 
out of README.md to RELEASING.md?  It may fit better there


--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:15:07 +
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc
File README.adoc:

http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc@348
PS1, Line 348: cd _publish && git push  # Update the live web site.
> May want to add a note about having to push an empty commit if the change i
Good call, done



--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:11:36 +
Gerrit-HasComments: Yes

[kudu-CR] Update instructions for publishing changes to the live site

[Mike Percy (Code Review)]

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8059

to look at the new patch set (#2).

Change subject: Update instructions for publishing changes to the live site
..

Update instructions for publishing changes to the live site

Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
---
M README.adoc
1 file changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8059/2
--
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Fix crash when log dir is not specified

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9233 )

Change subject: Fix crash when log_dir is not specified
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725a7da038913ff05227c6dc34167138148b
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:01:55 +
Gerrit-HasComments: No

[kudu-CR] Fix crash when log dir is not specified

[Todd Lipcon (Code Review)]

Hello Jean-Daniel Cryans,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/9233

to review the following change.


Change subject: Fix crash when log_dir is not specified
..

Fix crash when log_dir is not specified

This fixes the tpch1 benchmark after the recent enabling of metrics
logging. The crash was due to FLAGS_log_dir being unset. In typical
servers, we rely on InitGoogleLoggingSafe to default log_dir to /tmp,
but our tpch1 benchmark embeds a client, and a constructor function in
the client calls InitGoogleLoggingSafeBasic which doesn't do this
defaulting. So, we ended up starting the minicluster with an empty log
dir.

This patch just makes it not start the metrics logger if no log dir is
set.

Change-Id: I725a7da038913ff05227c6dc34167138148b
---
M src/kudu/server/server_base.cc
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9233/1
--
To view, visit http://gerrit.cloudera.org:8080/9233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I725a7da038913ff05227c6dc34167138148b
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8804 )

Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode
..


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1953
PS10, Line 1953:   // Make sure that there is no snapshot timestamp sent back.
   :   ASSERT_TRUE(!resp.has_snap_timestamp());
> I see, so looks like you are proposing to make this read mode fault-toleran
I think we discussed a couple of reasons why it might be interesting to have 
the response include the timestamp (like using that to update the last 
propagated timestamp). I agree that fault-tolerance work doesn't need to be 
included in this patch though



--
To view, visit http://gerrit.cloudera.org:8080/8804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48
Gerrit-Change-Number: 8804
Gerrit-PatchSet: 10
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Tue, 06 Feb 2018 23:50:05 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add scaling guide

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8842 )

Change subject: [docs] Add scaling guide
..


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@15
PS3, Line 15: Please
Remove


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@20
PS3, Line 20: on use
a line break?


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@28
PS3, Line 28:  a
A


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@31
PS3, Line 31: a
A


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@32
PS3, Line 32: say
for example,


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@35
PS3, Line 35: the
The


http://gerrit.cloudera.org:8080/#/c/8842/3/docs/scaling_guide.adoc@165
PS3, Line 165: limit
OS limit



--
To view, visit http://gerrit.cloudera.org:8080/8842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d8999addc41fe0b726342a27dbba199ddf7dd2
Gerrit-Change-Number: 8842
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 06 Feb 2018 23:48:50 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Document how to recover from a majority failed tablet

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8402 )

Change subject: [docs] Document how to recover from a majority failed tablet
..


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc@811
PS7, Line 811: majority
is there a quantifiable definition of "majority"?


http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc@813
PS7, Line 813: and so
potentially resulting in permanent data loss.


http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc@840
PS7, Line 840: ,
remove ","


http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc@844
PS7, Line 844: ,
Remove ,


http://gerrit.cloudera.org:8080/#/c/8402/7/docs/administration.adoc@844
PS7, Line 844: those
Those



--
To view, visit http://gerrit.cloudera.org:8080/8402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6326f65d029a1cd75e487b16ce5be4baea2f215
Gerrit-Change-Number: 8402
Gerrit-PatchSet: 7
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 06 Feb 2018 23:37:08 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8692 )

Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8692/5/src/kudu/hms/sasl_client_transport.cc
File src/kudu/hms/sasl_client_transport.cc:

http://gerrit.cloudera.org:8080/#/c/8692/5/src/kudu/hms/sasl_client_transport.cc@123
PS5, Line 123: ...
> Ok that makes sense. I'm fine with keeping it this way too.
Note that this is unconditionally re-throwing the exception, it just making 
sure to close the transport if that happens.  The syntax is a little weird, 
since it doesn't assign the exception to a local variable.



--
To view, visit http://gerrit.cloudera.org:8080/8692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345
Gerrit-Change-Number: 8692
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 06 Feb 2018 17:25:12 +
Gerrit-HasComments: Yes

[kudu-CR] tablet: don't store row count in delta tracker

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9216 )

Change subject: tablet: don't store row count in delta tracker
..


Patch Set 5:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.h
File src/kudu/tablet/diskrowset.h:

http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.h@366
PS5, Line 366:   Status CountRows(rowid_t *count) const override;
> can we mark this final so that calls from within this class can be inlined
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.h@474
PS5, Line 474:   // Number of rows in the rowset.
> can you add a comment here that this might be unset?
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.h@475
PS5, Line 475:   mutable std::atomic num_rows_;
> let's just use int64_t here, rowid_t is kinda old and gross
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.cc
File src/kudu/tablet/diskrowset.cc:

http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.cc@522
PS5, Line 522:   num_rows_(0),
> let's use -1 as a signifier of unknown here
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.cc@672
PS5, Line 672:  rowid_t num_rows;
 :   RETURN_NOT_OK(CountRows(_rows));
> this can be inside an #ifndef NDEBUG right?
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.cc@700
PS5, Line 700:   rowid_t num_rows;
> same
Done


http://gerrit.cloudera.org:8080/#/c/9216/5/src/kudu/tablet/diskrowset.cc@725
PS5, Line 725: {
> I don't think the extra nesting is worth making the critical section one st
Done



--
To view, visit http://gerrit.cloudera.org:8080/9216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I084e0944f388c22e838b017663a812b0ba77245d
Gerrit-Change-Number: 9216
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 06 Feb 2018 16:13:44 +
Gerrit-HasComments: Yes

[kudu-CR] tablet: don't store row count in delta tracker

[Andrew Wong (Code Review)]

Hello Tidy Bot, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9216

to look at the new patch set (#6).

Change subject: tablet: don't store row count in delta tracker
..

tablet: don't store row count in delta tracker

DeltaTracker's constructor previously required a row-count that can
only be obtained by first reading from disk. While useful as a sanity
check while tracking updates, it's not important for this count to be
known at instantiation-time.

This patch is helpful in reducing the amount of data required from disk
at startup, as one of the reasons we need to fully open some CFiles is
to get this row count. This patch itself doesn't defer any reads; it
just defers the requirement of the row count.

This patch has no functional changes.

Change-Id: I084e0944f388c22e838b017663a812b0ba77245d
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
5 files changed, 49 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/9216/6
--
To view, visit http://gerrit.cloudera.org:8080/9216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I084e0944f388c22e838b017663a812b0ba77245d
Gerrit-Change-Number: 9216
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Move configuration keys into its own class and make public

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8920 )

Change subject: Move configuration keys into its own class and make public
..


Patch Set 2:

Hey Clemens, sorry for the delay on this one.

I'm wary of exposing the actual key/value strings because it limits our ability 
to evolve things in the future. For example, we may want to start passing all 
of the info down into the class by serializing a protobuf into the 
configuration instead of all these separate string fields.

We already have the TableInputFormatConfigurator class with some methods for 
things like the table name, master addresses, etc. Is there an issue with using 
that from Hive?


--
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente 
Gerrit-Reviewer: Clemens Valiente 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:07:54 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2279 (part 3): metrics: don't emit untouched metrics to log

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9177 )

Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d2c4640e54c91791fab9c420215bafa3fe8f20
Gerrit-Change-Number: 9177
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:05:43 +
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9159 )

Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:01:07 +
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9159 )

Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
..

[thirdparty] fix sized-deallocation issue on OS X 10.11

Fixed the issue of building gperftools 2.6.3 on OS X 10.11.  Also,
updated the top-level CMakeLists.txt to enable or disable the sized
deallocation feature for Kudu binaries accordingly.

Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Reviewed-on: http://gerrit.cloudera.org:8080/9159
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-sized-alloc-build-fix.patch
3 files changed, 49 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] build-support: fix reporting of build configuration

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9182 )

Change subject: build-support: fix reporting of build configuration
..

build-support: fix reporting of build configuration

Our older Jenkins setup for running flaky test builds seemed to use the
deprecated "build from the source root" setup with cmake. Now, we use a
build dir which isn't the same as the source root, which means we no
longer have a CMakeCache.txt in the source root.

This updates the test reporting to look for CMakeCache.txt in the proper
spot.

Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Reviewed-on: http://gerrit.cloudera.org:8080/9182
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao 
Reviewed-by: Grant Henke 
---
M build-support/report-test.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, but someone else must approve
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Gerrit-Change-Number: 9182
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Edward Fancher 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9180 )

Change subject: KUDU-2279 (part 5): don't include entity attributes in log
..

KUDU-2279 (part 5): don't include entity attributes in log

Entity attributes like table names and partition descriptions aren't
very useful in the context of the metrics log. They can always be
grabbed from other places like 'kudu remote_replica list', etc, and are
rarely relevant for tserver-scope debugging.

Additionally, these might be considered somewhat sensitive for users to
share publically in bug reports, etc, so may as well "redact" them.

This shaves a few more bytes off the entries in the metrics log.

Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Reviewed-on: http://gerrit.cloudera.org:8080/9180
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/server/server_base.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley