Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9237 )
Change subject: Add previous / current thread to collision warner ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h File src/kudu/gutil/threading/thread_collision_warner.h: http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h@132 PS1, Line 132: // The class ThreadCollisionWarner uses an Asserter to notify the collision : // AsserterBase is the interfaces and DCheckAsserter is the default asserter : // used. During the unit tests is used another class that doesn't "DCHECK" : // in case of collision (check thread_collision_warner_unittests.cc) nit: it's not the part of your change, but maybe consider updating this description because it's hard to read. -- To view, visit http://gerrit.cloudera.org:8080/9237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7 Gerrit-Change-Number: 9237 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 05:43:47 +0000 Gerrit-HasComments: Yes
