[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib64 - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to OFF directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Reviewed-on: http://gerrit.cloudera.org:8080/12847 Reviewed-by: Grant Henke Tested-by: Grant Henke --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 133 insertions(+), 47 deletions(-) Approvals: Grant Henke: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 7 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 6: Verified+1 Failure is a known flaky. -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 6 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 20:23:57 + Gerrit-HasComments: No
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Grant Henke has removed a vote on this change. Change subject: [KUDU-1344] Part 1: cmake install for executables .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 6 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#6). Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib64 - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to OFF directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 133 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/6 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 6 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/5//COMMIT_MSG@23 PS5, Line 23: setting these flags to OFF directs cmake to skip > Nit: They aren't skip flags anymore. Should be OFF. Done -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 6 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 19:49:58 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 5 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 19:46:05 + Gerrit-HasComments: No
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#5). Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib64 - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to ON directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 133 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/5 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 5 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#4). Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib64/ - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to ON directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 133 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/4 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 4 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#3). Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib/ - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to ON directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 133 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/3 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 3 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc File docs/installation.adoc: PS2: > Should I wrap to 100 characters? I had my editor set up to 120 and noticed Yes please. There's no real consensus amongst developers, but 100 is a good place to start. -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 2 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 19:12:07 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc File docs/installation.adoc: PS2: > Some of the new lines are too long; can you wrap? Should I wrap to 100 characters? I had my editor set up to 120 and noticed that some text here was already over 100. http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@172 PS2, Line 172: * Kudu client library in `/usr/local/lib/` > You sure this lands in lib and not lib64? Thanks for catching this. This lands in lib64. http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@295 PS2, Line 295: * Kudu client library in `/usr/local/lib/` > You sure this lands in lib and not something with x86_64 in it? it lands in /usr/local/lib64 http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@406 PS2, Line 406: * Kudu client library in `/usr/local/lib/` > Likewise I thought this might end up in lib64. Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@101 PS2, Line 101: kudu-master > Nit: "the Kudu Master executable" Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@104 PS2, Line 104: else(KUDU_MASTER_INSTALL) > You can omit KUDU_MASTER_INSTALL from the body of the else() and endif(). Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@143 PS2, Line 143: option(KUDU_CLIENT_INSTALL "Whether to install the Kudu client executable" ON) > It's not really the "client executable" as the "CLI" or "command line tool" Indeed. I will also change to "command line tool" in the documentation. http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@148 PS2, Line 148: endif(KUDU_CLIENT_INSTALL) > Nit: separate from the next line with an empty line. Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt File src/kudu/tserver/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@a142 PS2, Line 142: > Could you restore this? I think it's nice to see these "headers" separate t Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@149 PS2, Line 149: kudu-tserver > "the Kudu Tablet Server executable" Done http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@154 PS2, Line 154: endif(KUDU_TSERVER_INSTALL) > Nit: separate with a blank line. Done -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 2 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 19:05:46 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (11 comments) Could you provide a rendering of the new installation.adoc? http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc File docs/installation.adoc: PS2: Some of the new lines are too long; can you wrap? http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@172 PS2, Line 172: * Kudu client library in `/usr/local/lib/` You sure this lands in lib and not lib64? http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@295 PS2, Line 295: * Kudu client library in `/usr/local/lib/` You sure this lands in lib and not something with x86_64 in it? http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@406 PS2, Line 406: * Kudu client library in `/usr/local/lib/` Likewise I thought this might end up in lib64. http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@101 PS2, Line 101: kudu-master Nit: "the Kudu Master executable" http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@104 PS2, Line 104: else(KUDU_MASTER_INSTALL) You can omit KUDU_MASTER_INSTALL from the body of the else() and endif(). Elsewhere too. http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@143 PS2, Line 143: option(KUDU_CLIENT_INSTALL "Whether to install the Kudu client executable" ON) It's not really the "client executable" as the "CLI" or "command line tool". http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@148 PS2, Line 148: endif(KUDU_CLIENT_INSTALL) Nit: separate from the next line with an empty line. http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt File src/kudu/tserver/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@a142 PS2, Line 142: Could you restore this? I think it's nice to see these "headers" separate the actual logic with empty lines. http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@149 PS2, Line 149: kudu-tserver "the Kudu Tablet Server executable" http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@154 PS2, Line 154: endif(KUDU_TSERVER_INSTALL) Nit: separate with a blank line. -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 2 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 27 Mar 2019 03:31:44 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Hello Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#2). Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib/ - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (ON by default): - KUDU_CLIENT_INSTALL - KUDU_TSERVER_INSTALL - KUDU_MASTER_INSTALL setting these flags to ON directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 123 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/2 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 2 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): > Should we continue to only install the client by default? Are there existin it probably breaks some workflows somewhere, but I think we can release note this and make the change anyway, since it definitely is more the expectation that "make install" installs everything -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 26 Mar 2019 23:19:31 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): > Good point about double negative flags. Should we continue to only install the client by default? Are there existing workflows using `make install` that this could break if we start also installing the master and tserver? -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 26 Mar 2019 21:57:55 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): > instead of the "double negative" flags, can we add on-by-default flags whic Good point about double negative flags. -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 25 Mar 2019 22:46:13 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): instead of the "double negative" flags, can we add on-by-default flags which enable the install? eg by adding in the top-level CMakeLists.txt something like: set(KUDU_CLIENT_INSTALL ON CACHE BOOL "Whether to install the Kudu client library") (see https://cmake.org/cmake/help/v2.8.8/cmake.html#command%3aset) -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 25 Mar 2019 22:34:10 + Gerrit-HasComments: Yes
[kudu-CR] [KUDU-1344] Part 1: cmake install for executables
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12847 Change subject: [KUDU-1344] Part 1: cmake install for executables .. [KUDU-1344] Part 1: cmake install for executables This change adds cmake install commands for kudu, kudu-tserver and kudu-master executables. Running 'sudo make install' installs the following: - kudu-tserver and kudu-master executables in /usr/local/sbin - Kudu client executable in /usr/local/bin - Kudu client library in /usr/local/lib/ - Kudu client headers in /usr/local/include/kudu This change also adds 3 cmake flags (off by default): - KUDU_SKIP_CLIENT_INSTALL - KUDU_SKIP_TSERVER_INSTALL - KUDU_SKIP_MASTER_INSTALL setting these flags to ON directs cmake to skip corresponding install commands. Update documentation to reflect these changes. Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 --- M docs/installation.adoc M src/kudu/master/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt 4 files changed, 123 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/1 -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev
