[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. [build] Add the option to use the protoc from thirdparty in the java build This patch introduces the option to use the thirdparty protoc in the java build via `-PuseKuduProtoc`. This is useful if a specific OS or architecture is not published to Maven. ex: `gradle assemble -PuseKuduProtoc` Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Reviewed-on: http://gerrit.cloudera.org:8080/16854 Reviewed-by: Alexey Serbin Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins --- M java/gradle/dependencies.gradle M java/gradle/protobuf.gradle 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle@29 PS3, Line 29: warn > Only the warn level shows up by default and we want to print/show it becaus Ack -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 20:03:44 + Gerrit-HasComments: Yes
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16854/4/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/4/java/gradle/protobuf.gradle@30 PS4, Line 30: $rootDir/../thirdparty/installed/uninstrumented/bin/protoc" nit: would it be possible to use this variable in the logger's message above? -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:53:14 + Gerrit-HasComments: Yes
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG@12 PS3, Line 12: : Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f : ex: `gradle assemble -PuseKuduProtoc` > nit: swap lines Done http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle@70 PS3, Line 70: warn > nit: same here? Why not info? Only the warn level shows up by default and we want to print/show it because it's "unusual". http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle@29 PS3, Line 29: warn > nit: why is this a warning? If a user's opted into it, isn't it expected be Only the warn level shows up by default and we want to print/show it because it's "unusual". The downside might be non reproducible builds depending on the state of thirdparty. -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:38:20 + Gerrit-HasComments: Yes
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Greg Solovyev, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16854 to look at the new patch set (#4). Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. [build] Add the option to use the protoc from thirdparty in the java build This patch introduces the option to use the thirdparty protoc in the java build via `-PuseKuduProtoc`. This is useful if a specific OS or architecture is not published to Maven. ex: `gradle assemble -PuseKuduProtoc` Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f --- M java/gradle/dependencies.gradle M java/gradle/protobuf.gradle 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/16854/4 -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG@12 PS3, Line 12: : Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f : ex: `gradle assemble -PuseKuduProtoc` nit: swap lines -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:22:32 + Gerrit-HasComments: Yes
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle@70 PS3, Line 70: warn nit: same here? Why not info? http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle@29 PS3, Line 29: warn nit: why is this a warning? If a user's opted into it, isn't it expected behavior? Are there downsides to using thirdparty's protoc? -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:22:09 + Gerrit-HasComments: Yes
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 18:42:57 + Gerrit-HasComments: No
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has removed a vote on this change. Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 1: Code-Review+1 > osx arm64 for the time being Thanks. -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 20:33:36 + Gerrit-HasComments: No
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 1: osx arm64 for the time being -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 20:24:52 + Gerrit-HasComments: No
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 1: What's an example of a specific OS or arch missing from Maven that applies to Kudu? -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 18:53:56 + Gerrit-HasComments: No
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 ) Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 18:08:47 + Gerrit-HasComments: No
[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16854 Change subject: [build] Add the option to use the protoc from thirdparty in the java build .. [build] Add the option to use the protoc from thirdparty in the java build This patch introduces the option to use the thirdparty protoc in the java build via `-PuseKuduProtoc`. This is useful if a specific OS or architecture is not published to Maven. Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f ex: `gradle assemble -PuseKuduProtoc` --- M java/gradle/dependencies.gradle M java/gradle/protobuf.gradle 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/16854/1 -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
