[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-12-01 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..

[client] expose non-voter replicas for kudu CLI tool

Added private interface to expose non-voter replica in the kudu CLI
tools.  Also, use that functionality to list table's replicas.

Updated output of ksck to include information on non-voters replicas:
  * renamed column 'Voters' into 'Replicas'
  * a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:

 Config source |   Replicas   | Current term | Config index | Committed?
---+--+--+--+---
 master| A*  B~  C~   |  |  | Yes
 A | A*  B~  C~   | 4| 5| Yes
 B | A*  B~  C~   | 4| 5| Yes
 C | A*  B~  C~   | 4| 5| Yes

I also updated the format of output to make it more readable.  An
example of new output for 'kudu table list --list_tablets':

loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
  T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876

  T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

  T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Reviewed-on: http://gerrit.cloudera.org:8080/8586
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller-internal.cc
A src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 429 insertions(+), 150 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-12-01 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 01 Dec 2017 23:13:28 +
Gerrit-HasComments: No

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-12-01 Thread Alexey Serbin (Code Review) 
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8586

to look at the new patch set (#5).

Change subject: [client] expose non-voter replicas for kudu CLI tool
..

[client] expose non-voter replicas for kudu CLI tool

Added private interface to expose non-voter replica in the kudu CLI
tools.  Also, use that functionality to list table's replicas.

Updated output of ksck to include information on non-voters replicas:
  * renamed column 'Voters' into 'Replicas'
  * a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:

 Config source |   Replicas   | Current term | Config index | Committed?
---+--+--+--+---
 master| A*  B~  C~   |  |  | Yes
 A | A*  B~  C~   | 4| 5| Yes
 B | A*  B~  C~   | 4| 5| Yes
 C | A*  B~  C~   | 4| 5| Yes

I also updated the format of output to make it more readable.  An
example of new output for 'kudu table list --list_tablets':

loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
  T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876

  T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

  T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller-internal.cc
A src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 429 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8586/5
--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-12-01 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@a340
PS3, Line 340:
> When you omit the parentheses, it makes me feel like you are doing it for a
I think between 'A a();' and 'A a;' it's better to use the latter if they do 
the leave the constructed object in the same state.

Since we are using C++11 in this project, the below contains more relevant 
info, I think:

http://en.cppreference.com/w/cpp/language/default_initialization

For the context on value initialization, the following might be useful as well: 
http://en.cppreference.com/w/cpp/language/value_initialization


http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/client/client.cc
File src/kudu/client/client.cc:

http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/client/client.cc@550
PS4, Line 550: e
> nit: End the comment with a period per the style guide.
Done



--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 01 Dec 2017 22:20:37 +
Gerrit-HasComments: Yes

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-29 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc
File src/kudu/tools/ksck-test.cc:

http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc@214
PS4, Line 214:   void CreateAndFillTablet(shared_ptr& tablet, int 
num_replicas,
> warning: non-const reference parameter 'tablet', make it const or use a poi
I'm going to ignore this. That fix is better to publish as a separate patch, 
IMO.



--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 01:09:13 +
Gerrit-HasComments: Yes

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-29 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@a340
PS3, Line 340:
> Is there a reason for removing these parens?
They are not needed in C++ default constructors.  Also, it's less symbols total 
:)


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@550
PS3, Line 550: bool is_leader = r.role() == consensus::RaftPeerPB::LEADER;
> Would you mind adding a TODO comment to try to go back and use member_type
Done


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h
File src/kudu/client/replica_controller.h:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@27
PS3, Line 27: namespace internal {
> Based on recent convention, I think these files (.h and .cc) should also be
Done


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@29
PS3, Line 29: which
> nit: whose
Done


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@20
PS3, Line 20: #include 
> warning: #includes are not sorted properly [llvm-include-order]
Done


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc
File src/kudu/tools/ksck-test.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc@214
PS3, Line 214:   void CreateAndFillTablet(shared_ptr& tablet, int 
num_replicas,
> warning: non-const reference parameter 'tablet', make it const or use a poi
ignoring


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc@74
PS3, Line 74: using std::right;
> warning: using decl 'right' is unused [misc-unused-using-decls]
Done



--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:14:43 +
Gerrit-HasComments: Yes

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-29 Thread Alexey Serbin (Code Review) 
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8586

to look at the new patch set (#4).

Change subject: [client] expose non-voter replicas for kudu CLI tool
..

[client] expose non-voter replicas for kudu CLI tool

Added private interface to expose non-voter replica in the kudu CLI
tools.  Also, use that functionality to list table's replicas.

Updated output of ksck to include information on non-voters replicas:
  * renamed column 'Voters' into 'Replicas'
  * a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:

 Config source |   Replicas   | Current term | Config index | Committed?
---+--+--+--+---
 master| A*  B~  C~   |  |  | Yes
 A | A*  B~  C~   | 4| 5| Yes
 B | A*  B~  C~   | 4| 5| Yes
 C | A*  B~  C~   | 4| 5| Yes

I also updated the format of output to make it more readable.  An
example of new output for 'kudu table list --list_tablets':

loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
  T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876

  T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

  T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller-internal.cc
A src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 429 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8586/4
--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-29 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h
File src/kudu/client/replica_controller.h:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@29
PS3, Line 29: which
nit: whose



--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 29 Nov 2017 16:42:57 +
Gerrit-HasComments: Yes

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-28 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8586 )

Change subject: [client] expose non-voter replicas for kudu CLI tool
..


Patch Set 3: Code-Review+1

(3 comments)

lgtm

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@a340
PS3, Line 340:
Is there a reason for removing these parens?


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@550
PS3, Line 550: bool is_leader = r.role() == consensus::RaftPeerPB::LEADER;
Would you mind adding a TODO comment to try to go back and use member_type with 
attributes instead of role for the meta cache and related client code? Role is 
starting to become an outdated concept as we evolve the system.


http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h
File src/kudu/client/replica_controller.h:

http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@27
PS3, Line 27: namespace internal {
Based on recent convention, I think these files (.h and .cc) should also be 
named -internal.*



--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 29 Nov 2017 04:04:52 +
Gerrit-HasComments: Yes

[kudu-CR] [client] expose non-voter replicas for kudu CLI tool

2017-11-19 Thread Alexey Serbin (Code Review) 
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8586

to look at the new patch set (#3).

Change subject: [client] expose non-voter replicas for kudu CLI tool
..

[client] expose non-voter replicas for kudu CLI tool

Added private interface to expose non-voter replica in the kudu CLI
tools.  Also, use that functionality to list table's replicas.

Updated output of ksck to include information on non-voters replicas:
  * renamed column 'Voters' into 'Replicas'
  * a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:

 Config source |   Replicas   | Current term | Config index | Committed?
---+--+--+--+---
 master| A*  B~  C~   |  |  | Yes
 A | A*  B~  C~   | 4| 5| Yes
 B | A*  B~  C~   | 4| 5| Yes
 C | A*  B~  C~   | 4| 5| Yes

I also updated the format of output to make it more readable.  An
example of new output for 'kudu table list --list_tablets':

loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
  T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876

  T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

  T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872

  T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874

  T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870

Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller.cc
A src/kudu/client/replica_controller.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 428 insertions(+), 149 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8586/3
--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley