Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8586 )
Change subject: [client] expose non-voter replicas for kudu CLI tool ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@a340 PS3, Line 340: > Is there a reason for removing these parens? They are not needed in C++ default constructors. Also, it's less symbols total :) http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@550 PS3, Line 550: bool is_leader = r.role() == consensus::RaftPeerPB::LEADER; > Would you mind adding a TODO comment to try to go back and use member_type Done http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h File src/kudu/client/replica_controller.h: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@27 PS3, Line 27: namespace internal { > Based on recent convention, I think these files (.h and .cc) should also be Done http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@29 PS3, Line 29: which > nit: whose Done http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@20 PS3, Line 20: #include <ostream> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc@214 PS3, Line 214: void CreateAndFillTablet(shared_ptr<KsckTablet>& tablet, int num_replicas, > warning: non-const reference parameter 'tablet', make it const or use a poi ignoring http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc@74 PS3, Line 74: using std::right; > warning: using decl 'right' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2017 00:14:43 +0000 Gerrit-HasComments: Yes
