Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8586 )
Change subject: [client] expose non-voter replicas for kudu CLI tool ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc@214 PS4, Line 214: void CreateAndFillTablet(shared_ptr<KsckTablet>& tablet, int num_replicas, > warning: non-const reference parameter 'tablet', make it const or use a poi I'm going to ignore this. That fix is better to publish as a separate patch, IMO. -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2017 01:09:13 +0000 Gerrit-HasComments: Yes
