[kudu-CR] [docker] Update pip install
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. [docker] Update pip install It looks like Python has adjusted the get-pip.py URL to no longer support Python 2.7. This patch updates the Docker scripts to use the 2.7 specific URL and drop the old 2.6 speicific url now that no supported images use Python 2.6. Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Reviewed-on: http://gerrit.cloudera.org:8080/16984 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M docker/bootstrap-dev-env.sh M docker/bootstrap-python-env.sh 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update pip install
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@37 PS1, Line 37: "7" > We could, though I haven't really made a habit of handling things we don't Yeah, I guess having explicit case for any unexpected version of python here would be nice, but if you know it's guaranteed not to happen, it would be just some never-used extra code. -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 17:10:59 + Gerrit-HasComments: Yes
[kudu-CR] [docker] Update pip install
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16984/2/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/2/docker/bootstrap-python-env.sh@38 PS2, Line 38: standary > nit: standard Done -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 15:37:26 + Gerrit-HasComments: Yes
[kudu-CR] [docker] Update pip install
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16984 to look at the new patch set (#3). Change subject: [docker] Update pip install .. [docker] Update pip install It looks like Python has adjusted the get-pip.py URL to no longer support Python 2.7. This patch updates the Docker scripts to use the 2.7 specific URL and drop the old 2.6 speicific url now that no supported images use Python 2.6. Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 --- M docker/bootstrap-dev-env.sh M docker/bootstrap-python-env.sh 2 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/16984/3 -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update pip install
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16984/2/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/2/docker/bootstrap-python-env.sh@38 PS2, Line 38: standary nit: standard -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 15:16:04 + Gerrit-HasComments: Yes
[kudu-CR] [docker] Update pip install
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16984 to look at the new patch set (#2). Change subject: [docker] Update pip install .. [docker] Update pip install It looks like Python has adjusted the get-pip.py URL to no longer support Python 2.7. This patch updates the Docker scripts to use the 2.7 specific URL and drop the old 2.6 speicific url now that no supported images use Python 2.6. Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 --- M docker/bootstrap-dev-env.sh M docker/bootstrap-python-env.sh 2 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/16984/2 -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Update pip install
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@37 PS1, Line 37: "7" > Would it make sense to fail if below 2.7 in an obvious way? I imagine it'll We could, though I haven't really made a habit of handling things we don't expect to happen at all in these scripts given all the base images we allow are guaranteed to have Python 2.7 or higher. For simplicity, I would rather not handle it. http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@38 PS1, Line 38:c > nit: maybe mention that pypa's generic script isn't supported with 2.7 so w Done http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@40 PS1, Line 40: Python 2. > nit: 2 and 3, as before? Done -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 14:32:21 + Gerrit-HasComments: Yes
[kudu-CR] [docker] Update pip install
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@37 PS1, Line 37: "7" Would it make sense to fail if below 2.7 in an obvious way? I imagine it'll fail now complaining about a syntax error trying to use the general get-pip.py http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@38 PS1, Line 38:c nit: maybe mention that pypa's generic script isn't supported with 2.7 so we need to get a specific one. http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@40 PS1, Line 40: Python 2. nit: 2 and 3, as before? -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Jan 2021 19:20:33 + Gerrit-HasComments: Yes
[kudu-CR] [docker] Update pip install
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 ) Change subject: [docker] Update pip install .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Jan 2021 18:37:43 + Gerrit-HasComments: No
[kudu-CR] [docker] Update pip install
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16984 Change subject: [docker] Update pip install .. [docker] Update pip install It looks like Python has adjusted the get-pip.py URL to no longer support Python 2.7. This patch updates the Docker scripts to use the 2.7 specific URL and drop the old 2.6 speicific url now that no supported images use Python 2.6. Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 --- M docker/bootstrap-dev-env.sh M docker/bootstrap-python-env.sh 2 files changed, 5 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/16984/1 -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
