[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Will Berkeley (Code Review)]

Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..

[docs] Update kudu-spark section and add Upsert ignoreNull subsection

Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Reviewed-on: http://gerrit.cloudera.org:8080/9849
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley 
---
M docs/developing.adoc
1 file changed, 65 insertions(+), 20 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:08:45 +
Gerrit-HasComments: No

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Hello Will Berkeley, Alex Rodoni, Dan Burkert, Attila Bukor, Kudu Jenkins, Hao 
Hao,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9849

to look at the new patch set (#4).

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..

[docs] Update kudu-spark section and add Upsert ignoreNull subsection

Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
---
M docs/developing.adoc
1 file changed, 65 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/9849/4
--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Patch Set 3: Code-Review+1

(1 comment)

Looks good to me, just one minor nit.

http://gerrit.cloudera.org:8080/#/c/9849/3/docs/developing.adoc
File docs/developing.adoc:

http://gerrit.cloudera.org:8080/#/c/9849/3/docs/developing.adoc@116
PS3, Line 116: val df = spark.read.options(Map("kudu.master" -> 
"kudu.master:7051","kudu.table" -> "kudu_table")).kudu
nit: this line is too long.



--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 25 Apr 2018 18:31:06 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc
File docs/developing.adoc:

http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@93
PS2, Line 93:
> Remove trailing whitespace here and throughout.
Done


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@101
PS2, Line 101:
> Wrap lines in body test (not code blocks) at about 80 characters. Meaning,
Done


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@104
PS2, Line 104:
> 1.7.0
Done


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@163
PS2, Line 163: u S
> Remove.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 25 Apr 2018 16:59:44 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Patch Set 2:

(4 comments)

One correction and some small things and it LGTM.

http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc
File docs/developing.adoc:

http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@93
PS2, Line 93:
Remove trailing whitespace here and throughout.


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@101
PS2, Line 101: to
Wrap lines in body test (not code blocks) at about 80 characters. Meaning, add 
a line break to break up a long line into two shorter ones. This won't affect 
how it's rendered on the website.


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@104
PS2, Line 104: 5
1.7.0


http://gerrit.cloudera.org:8080/#/c/9849/2/docs/developing.adoc@163
PS2, Line 163: the
Remove.



--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 25 Apr 2018 15:57:50 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9849 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Patch Set 2:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc
File docs/developing.adoc:

http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@98
PS1, Line 98: 1.5.0
> I'm pretty sure we stopped supporting Spark 1 for 1.6, so we should call th
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@98
PS1, Line 98: 1.5.0
> +1 for getting rid of Spark1 docs, since we don't ship it anymore.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@104
PS1, Line 104: .5.0
> Spark 2 artifacts are available up to 1.7.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@114
PS1, Line 114: Read a table from Kudu
> We should "talk Spark 2" by default now.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162
PS1, Line 162:
> Remove.
?


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162
PS1, Line 162: Upsert
> I don't think this needs to be capitalized.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162
PS1, Line 162:
> Add "the".
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162
PS1, Line 162:
> Please wrap at 80-100 characters.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@166
PS1, Line 166:
> This variable wasn't defined.
Done


http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@176
PS1, Line 176:
> nit: s/with/and
Done



--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 23 Apr 2018 18:42:15 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Fengling Wang has abandoned this change. ( 
http://gerrit.cloudera.org:8080/10157 )

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..


Abandoned

deuplicate patch
--
To view, visit http://gerrit.cloudera.org:8080/10157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8b89191617cf48979f466452f2059f68008c9910
Gerrit-Change-Number: 10157
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Hello Will Berkeley, Alex Rodoni, Dan Burkert, Attila Bukor, Kudu Jenkins, Hao 
Hao,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9849

to look at the new patch set (#2).

Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..

[docs] Update kudu-spark section and add Upsert ignoreNull subsection

Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
---
M docs/developing.adoc
1 file changed, 60 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/9849/2
--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Fengling Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10157


Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..

[docs] Update kudu-spark section and add Upsert ignoreNull subsection

Change-Id: I8b89191617cf48979f466452f2059f68008c9910
---
M docs/developing.adoc
1 file changed, 60 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/10157/1
--
To view, visit http://gerrit.cloudera.org:8080/10157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b89191617cf48979f466452f2059f68008c9910
Gerrit-Change-Number: 10157
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

[Fengling Wang (Code Review)]

Fengling Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9849


Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull 
subsection
..

[docs] Update kudu-spark section and add Upsert ignoreNull subsection

Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
---
M docs/developing.adoc
1 file changed, 43 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/9849/1
--
To view, visit http://gerrit.cloudera.org:8080/9849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e
Gerrit-Change-Number: 9849
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang